| *** oz_akan_ has joined #openstack-marconi | 00:42 | |
| *** oz_akan_ has quit IRC | 00:46 | |
| *** amitgandhi has joined #openstack-marconi | 00:52 | |
| *** nosnos has joined #openstack-marconi | 01:22 | |
| *** amitgandhi has left #openstack-marconi | 01:50 | |
| *** oz_akan_ has joined #openstack-marconi | 03:29 | |
| *** oz_akan_ has quit IRC | 03:41 | |
| *** oz_akan_ has joined #openstack-marconi | 03:42 | |
| *** oz_akan_ has quit IRC | 03:46 | |
| *** nosnos has quit IRC | 05:32 | |
| *** nosnos has joined #openstack-marconi | 05:32 | |
| *** ykaplan has joined #openstack-marconi | 06:45 | |
| *** nosnos_ has joined #openstack-marconi | 07:00 | |
| *** nosnos has quit IRC | 07:01 | |
| *** flaper87|afk is now known as flaper87 | 07:13 | |
| * flaper87 shakes the channel and wakes everyone up | 09:08 | |
| al-maisan | *yawn* :-) | 09:09 |
|---|---|---|
| flaper87 | al-maisan: good morning :D | 09:10 |
| al-maisan | Good morning flaper87 | 09:10 |
| al-maisan | we should have our VC today | 09:10 |
| al-maisan | is 14:00 CEST ok? | 09:11 |
| flaper87 | Yup, souuunds good to me! | 09:11 |
| flaper87 | al-maisan: ^ | 09:11 |
| flaper87 | G+ ? | 09:12 |
| al-maisan | great, let's do a Google hangout at 14 | 09:12 |
| al-maisan | :-) | 09:12 |
| flaper87 | I'm flaper87 there too. | 09:12 |
| flaper87 | damn I'm so easy to find | 09:12 |
| al-maisan | that's handy :) | 09:12 |
| *** ykaplan has quit IRC | 09:55 | |
| *** ykaplan has joined #openstack-marconi | 10:27 | |
| *** nosnos_ has quit IRC | 10:39 | |
| flaper87 | Alex_Gaynor: could you take a quick look here again? https://review.openstack.org/#/c/45070/ | 11:05 |
| *** oz_akan_ has joined #openstack-marconi | 11:12 | |
| *** cthulhup has joined #openstack-marconi | 11:16 | |
| flaper87 | cthulhup: yo, welcome back! | 11:17 |
| *** tedross has joined #openstack-marconi | 11:26 | |
| *** cthulhup has quit IRC | 12:00 | |
| *** cthulhup has joined #openstack-marconi | 12:01 | |
| cthulhup | greetings | 12:01 |
| *** ykaplan has quit IRC | 12:03 | |
| *** ykaplan has joined #openstack-marconi | 12:07 | |
| *** oz_akan_ has quit IRC | 12:26 | |
| *** flaper87 has quit IRC | 12:44 | |
| *** flaper87 has joined #openstack-marconi | 12:44 | |
| *** amitgandhi has joined #openstack-marconi | 13:09 | |
| *** rustlebee is now known as russellb | 13:14 | |
| *** oz_akan_ has joined #openstack-marconi | 13:23 | |
| flaper87 | amitgandhi: will cppcabrera be around today? | 13:23 |
| *** oz_akan_ has quit IRC | 13:25 | |
| *** oz_akan_ has joined #openstack-marconi | 13:25 | |
| *** malini_afk is now known as malini | 13:28 | |
| flaper87 | malini: HELLOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO | 13:28 |
| flaper87 | sooooo happy to have you back! | 13:28 |
| flaper87 | good morning | 13:28 |
| zyuan_ | morning | 13:29 |
| flaper87 | zyuan_: heyyyy, good morning! :) | 13:29 |
| flaper87 | zyuan_: how was the conference ? | 13:29 |
| zyuan_ | flaper87: great, except the last day | 13:29 |
| flaper87 | hat happened? Did someone said C# is better? | 13:29 |
| flaper87 | s/said/say/ | 13:29 |
| zyuan_ | i was tired on the last day, the last day is all M$ craps | 13:29 |
| zyuan_ | CRAPS | 13:30 |
| flaper87 | baahhhh!!! buuuuuuu!!!! | 13:30 |
| zyuan_ | i felt like that's too stupid taht i don't know whether should i comment... | 13:30 |
| zyuan_ | i recognize visual c++ as a good compiler until... | 13:31 |
| zyuan_ | until they told me how they did the optimizer | 13:31 |
| zyuan_ | -_- | 13:31 |
| flaper87 | ooohhhh do tell | 13:32 |
| zyuan_ | in front of me was Chandler, the LLVM guy | 13:32 |
| zyuan_ | and he confirmed twice with the Visual C++ guys, like, are they serious... | 13:33 |
| zyuan_ | most of other talks are great | 13:34 |
| *** tedross has quit IRC | 13:36 | |
| zyuan_ | noone took the timeutil one? | 13:42 |
| zyuan_ | if not, i can do it now | 13:42 |
| flaper87 | zyuan_: timeutil ? | 13:43 |
| *** amitgandhi has quit IRC | 13:44 | |
| zyuan_ | flaper87: yea, change mongo's datetime type | 13:44 |
| flaper87 | zyuan_: ah, erm, no, I don't recall any of us taking it\ | 13:45 |
| flaper87 | zyuan_: go ahead | 13:46 |
| zyuan_ | after the patches being merged last week | 13:46 |
| zyuan_ | sqlite driver's converage finally went back to 100% | 13:46 |
| zyuan_ | yea!!! | 13:46 |
| flaper87 | zyuan_: +1 for you!!!! | 13:46 |
| flaper87 | zyuan_: do you know if cppcabrera will be around today? | 13:49 |
| flaper87 | zyuan_: btw, did you see we're now incubated? :D w0000t | 13:50 |
| flaper87 | Migration under openstack/* will happen later this week or the next one, I guess. -infra guys still have to figure that out. (Meeting tomorrow) | 13:50 |
| zyuan_ | flaper87: see? i know we passed incubation | 13:51 |
| zyuan_ | you mean is code is moved? | 13:51 |
| flaper87 | zyuan_: no no, I meant if you knew we're and you do :D | 13:52 |
| malini | flaper87: hola !!! | 13:57 |
| malini | Sorry got distracted with all the stuff happening in office ..& I was out for just a week :D | 13:58 |
| flaper87 | malini: hehehehe!! Thought so! | 13:58 |
| *** ykaplan has quit IRC | 13:59 | |
| flaper87 | malini: do you have some time to go through test patches? | 14:03 |
| flaper87 | I bet you've tons of emails to read | 14:03 |
| malini | flaper87: I am going thru those right now.. | 14:04 |
| malini | is there any patch you would like to see go first? | 14:05 |
| flaper87 | The first one :P (I had to chain them to make this whole refactor work) | 14:06 |
| flaper87 | malini: https://review.openstack.org/#/c/44475/ | 14:06 |
| flaper87 | which you already +1'd | 14:06 |
| * flaper87 dials cppcabrera's direct line to check whether he'll show up today or not. | 14:07 | |
| malini | he won't | 14:07 |
| malini | he is still in jury duty | 14:08 |
| flaper87 | malini: :( | 14:08 |
| flaper87 | poor boy! | 14:08 |
| flaper87 | do you guys mind if I ninja approve that first patch? | 14:08 |
| flaper87 | mmh, I should wait for kurt | 14:08 |
| flaper87 | even if he already +2'd | 14:08 |
| flaper87 | kgriffs_afk: knock knock, time to +2 some patches :D | 14:08 |
| zyuan_ | a lot! | 14:09 |
| *** ykaplan has joined #openstack-marconi | 14:15 | |
| malini | flaper87: do we have/need a standard abt using % vs .format for string operations ? | 14:20 |
| flaper87 | malini: we don't have one but I think we should. We use % dict(...) in other projects | 14:21 |
| malini | I remember cppcabrera leaning towards .format..But I just cant remember why.. | 14:22 |
| flaper87 | malini: Py3K comptatibility, most probably | 14:22 |
| malini | thts what I thought too | 14:22 |
| malini | especially since its cppcabrera :D | 14:23 |
| malini | do we want to stick with % (or) start using .format ? | 14:24 |
| *** kgriffs_afk is now known as kgriffs | 14:25 | |
| kgriffs | hey folks | 14:25 |
| kgriffs | got a bomb to drop on you | 14:26 |
| kgriffs | flaper87: ping | 14:26 |
| flaper87 | malini: I leaning towards .format as well. %-format is old and has some issues | 14:26 |
| flaper87 | kgriffs: pong | 14:26 |
| flaper87 | kgriffs: good morning | 14:26 |
| kgriffs | good afternoon! | 14:26 |
| flaper87 | kgriffs: shooooot | 14:26 |
| kgriffs | so, like you, leaving one message in each queue has bugged be for a while | 14:26 |
| kgriffs | s/be/me | 14:27 |
| kgriffs | this morning on the bus I was thinking about it again and something was tickling the back of my mind | 14:27 |
| kgriffs | so when I got to the office I started doodling on a whiteboard… | 14:28 |
| kgriffs | <who gave that guy a marker?!> | 14:28 |
| kgriffs | anyway, I think I've got a solution | 14:28 |
| flaper87 | :P | 14:28 |
| flaper87 | ohhh, shoot shoot!!! | 14:28 |
| flaper87 | I can give you an etherpad if you want | 14:29 |
| flaper87 | :D | 14:29 |
| kgriffs | might need it, we'll see | 14:29 |
| kgriffs | the key is to not increment the side counter when you retrieve it | 14:29 |
| kgriffs | you increment it after you've written the new message | 14:29 |
| kgriffs | but, there's a problem with that | 14:29 |
| kgriffs | which originally stumped my. but the solution was staring me in the face, I just didn't see it before. | 14:30 |
| kgriffs | anyone want to take a guess at the problem? | 14:30 |
| kgriffs | https://etherpad.openstack.org/queuing-marker | 14:32 |
| flaper87 | by you increment it after, you mean, store the message, increment the counter and store it in the message ? | 14:32 |
| kgriffs | no, let me write it out on the pad | 14:32 |
| kgriffs | make sense | 14:34 |
| kgriffs | ? | 14:34 |
| kgriffs | you still have to have the unique index and retry on collisions, as currently implemented | 14:35 |
| flaper87 | yeah | 14:36 |
| flaper87 | (worte a comment there) | 14:36 |
| *** tedross has joined #openstack-marconi | 14:36 | |
| kgriffs | so, there may be other problems I haven't thought of yet, but here is the first one I thought of | 14:38 |
| flaper87 | go | 14:38 |
| kgriffs | Suppose a parallel request comes in, and so one of the requests "wins" and causes the other to retry | 14:38 |
| kgriffs | BUT | 14:38 |
| kgriffs | suppose the thread that wins crashes before it manages to update the side counter? | 14:39 |
| flaper87 | mmhhh | 14:40 |
| zyuan_ | 1. do we do it currenly | 14:40 |
| zyuan_ | 2. even we do, does it affects invariants? | 14:40 |
| zyuan_ | looks like not, if we just skipped some markers | 14:40 |
| kgriffs | zyuan_: we don't use a side counter currently, we are discussing the consequences of introducing one | 14:40 |
| kgriffs | and on a retry currently there is a max number of retries before the thread gives up | 14:41 |
| zyuan_ | kgriffs: i saw a seperated marker in mongo | 14:41 |
| kgriffs | where? | 14:41 |
| *** whenry has joined #openstack-marconi | 14:41 | |
| zyuan_ | 'k' | 14:41 |
| flaper87 | kgriffs: what happens if we increment it before? with a findAndModify ? | 14:41 |
| flaper87 | that will give us a counter we can use | 14:42 |
| kgriffs | ok, when I say "side counter" I mean one that is not stored in the message document itself | 14:42 |
| flaper87 | if another insert wins, it doesn't matter, we just increment it again | 14:42 |
| zyuan_ | that's... hard to do it in mongo | 14:42 |
| flaper87 | (not the side counter, but the one we're using for the marker) | 14:42 |
| kgriffs | flaper87: if we do that, we have the out-of-order insertion/race condition problem | 14:42 |
| zyuan_ | because mongo can not query 2 collections atomically | 14:42 |
| flaper87 | kgriffs: why out of order? | 14:43 |
| kgriffs | flaper87: let me illustrate on the pad | 14:43 |
| kgriffs | make sense? | 14:48 |
| flaper87 | kgriffs: sorry, got distracted w/ another convo | 14:58 |
| flaper87 | kgriffs: I was thinking to call findAndModify once per every message (let me read your proposal carfully) | 14:58 |
| flaper87 | kgriffs: btw, can we ninja approve some of the test patches if they get some +1? | 15:09 |
| flaper87 | not sure when cppcabrera will be back and the chain is getting bigger and bigger | 15:09 |
| kgriffs | flaper87: sure thing | 15:10 |
| flaper87 | kgriffs: awesome, whenever you get a chance :) | 15:10 |
| * flaper87 back to the pad | 15:10 | |
| kgriffs | kk | 15:10 |
| *** BigChzy_away has joined #openstack-marconi | 15:12 | |
| *** BigChzy_away is now known as BigChzy | 15:12 | |
| * kgriffs is back from the ether | 15:14 | |
| * flaper87 is back from a black hole | 15:14 | |
| flaper87 | kgriffs: it makes sense overall, I'm not sure how failure cases should be handled there | 15:14 |
| kgriffs | so, my idea was to have some kind of hall monitor that breaks up the fights. | 15:15 |
| kgriffs | you would have to set a timestamp when incrementing the counter | 15:15 |
| kgriffs | (last update time) | 15:15 |
| kgriffs | and then have a daemon running that checks for counters that are really stale and increments them | 15:15 |
| * kgriffs is trying to decide if that introduces another race condition | 15:16 | |
| kgriffs | alternatively, a worker after retrying X times will check the timestamp and increment it if it is stale | 15:16 |
| kgriffs | let me write that out to see if there is a race condition | 15:17 |
| flaper87 | mmh, I'n not sure about adding yet another process to marconi's stack. | 15:17 |
| flaper87 | it seems to me we're moving some of mongodb's logic to marconi | 15:17 |
| zyuan_ | ahhhhhh | 15:17 |
| flaper87 | (btw, we've a meeting today, right?) | 15:17 |
| zyuan_ | why python2's datetime has no .timestamp() | 15:17 |
| kgriffs | oh, yeah. I forgot to send an email | 15:17 |
| kgriffs | let me do that | 15:17 |
| zyuan_ | when? | 15:18 |
| flaper87 | ykaplan: is here ready to talk about sql backend | 15:18 |
| flaper87 | :D | 15:18 |
| kgriffs | zyuan_; 45 mins | 15:18 |
| zyuan_ | ok | 15:18 |
| ykaplan | flaper87, yes | 15:21 |
| kgriffs | FWIW: https://wiki.openstack.org/wiki/Meetings/Marconi#Next_meeting | 15:24 |
| kgriffs | zyuan_: time.time() | 15:25 |
| kgriffs | but we should be using utils.utcnow_ts() since it allows us to override "now" for testability | 15:26 |
| * kgriffs still thinks that function is poorly named | 15:26 | |
| zyuan_ | kgriffs: no, i mean the one convert a datetime to timestamp | 15:26 |
| zyuan_ | because bson ObjectId only gives you datetime | 15:27 |
| zyuan_ | now i get it | 15:27 |
| zyuan_ | different for python2 and python3 | 15:27 |
| kgriffs | yeah, I think it would be great to see some of timeutils get into python propper | 15:27 |
| zyuan_ | python3 did it | 15:27 |
| kgriffs | ah, so python3 has it. nice | 15:27 |
| zyuan_ | but they refuse to backport | 15:28 |
| kgriffs | booh | 15:28 |
| malini | kgriffs: I love this on the agenda 'Commit tsung configs in Marconi's tree' ..Was just thinking about it on my way in today :) | 15:28 |
| zyuan_ | see? python2 and 3 are two languages | 15:28 |
| flaper87 | malini: o/ | 15:30 |
| flaper87 | :D | 15:30 |
| malini | flaper87: strawberry chocolate pop tarts for you ! | 15:30 |
| flaper87 | w0000000000000000000000000000000000t | 15:31 |
| flaper87 | today's agenda is quite big! | 15:33 |
| kgriffs | flaper87: not sure if this happened to you, but I ended up not being able to use crate.io since it wouldn't install pbr from there. Maybe my system is messed up in a different way, but it seemed like crate.io was the culprit: https://gist.github.com/kgriffs/6392186 | 15:33 |
| kgriffs | using /simple seems to help anyway | 15:33 |
| flaper87 | kgriffs: ah yes, indeed it happened to me | 15:33 |
| kgriffs | flaper87: I think we will need a 3rd-party process after all to check and increment stale counters. If you have the request handler do it, you could get into a situation similar to the findAndModify race condition | 15:37 |
| kgriffs | but, we could simple make it part of marconi-gc | 15:37 |
| kgriffs | ? | 15:37 |
| kgriffs | marconi-watcher | 15:37 |
| kgriffs | blah | 15:37 |
| * kgriffs doesn't want to have to come up with a new name | 15:38 | |
| kgriffs | marconi-sweeper | 15:38 |
| kgriffs | actually, we don't need GC any more if we make this change, since we can just use mongo's TTL feature | 15:39 |
| kgriffs | thoughts? | 15:39 |
| *** BigChzy has left #openstack-marconi | 15:40 | |
| *** jergerber has joined #openstack-marconi | 15:41 | |
| flaper87 | kgriffs: mmh, that's true, we don't need a gc anymore! | 15:43 |
| flaper87 | kgriffs: marconi-aligner :P | 15:43 |
| flaper87 | like the worst name ever | 15:43 |
| kgriffs | marconi-smackdown | 15:43 |
| flaper87 | what if we leave the align process to the process inserting the message ? | 15:43 |
| flaper87 | I mean, the counter is aligned when it is >= than the marker used in the message that was just inserted | 15:44 |
| flaper87 | right? | 15:44 |
| flaper87 | we could check if the counter is >= k after calling findAndModify | 15:45 |
| flaper87 | and call findAndModify again if it isn't | 15:46 |
| *** tedross has quit IRC | 15:49 | |
| flaper87 | http://docs.mongodb.org/manual/tutorial/create-an-auto-incrementing-field/ <- read the warning | 15:50 |
| kgriffs | are you proposing this as a way to do findandmodify for each new message, or just when a worker dies and a counter gets "frozen"? | 15:50 |
| kgriffs | flaper87: yes, I understand the scaling implications. | 15:50 |
| flaper87 | kgriffs: mmh I'd say when the counter gets frozen | 15:51 |
| flaper87 | I mean, aren't we going to call findAndModify for each post operation? | 15:52 |
| kgriffs | i see, we check if it is > the last inserted K and if not then we set it to k+1 | 15:52 |
| flaper87 | yeah | 15:52 |
| flaper87 | :) | 15:52 |
| kgriffs | so if two workers do that at the same time, they will set it to the same value | 15:52 |
| flaper87 | well, findAndModify happens 1 at a time | 15:52 |
| kgriffs | oh, maybe not findandmodify then | 15:53 |
| flaper87 | we can teak the query and say: if counter < x, incr +1 | 15:53 |
| kgriffs | grrr | 15:53 |
| kgriffs | to many windows | 15:53 |
| flaper87 | :P | 15:53 |
| kgriffs | yeah, do one will have the query fail | 15:53 |
| kgriffs | so it doesn't get incremented twice | 15:53 |
| flaper87 | yup | 15:54 |
| kgriffs | s/do/so | 15:54 |
| kgriffs | i like it | 15:54 |
| flaper87 | w000t | 15:54 |
| kgriffs | I guess that is cool as long as all the messages don't expire in the mean time | 15:54 |
| kgriffs | then you loose your reference point | 15:54 |
| kgriffs | s/loose/lose | 15:54 |
| flaper87 | O.O | 15:54 |
| flaper87 | (plop) | 15:54 |
| kgriffs | so, there is a slim chance that a worker could insert a message, die before updating | 15:55 |
| kgriffs | then several minutes go by, the message expires | 15:55 |
| kgriffs | then a client posts a new message | 15:55 |
| kgriffs | seems like the only way to detect that is to use a heuristic | 15:56 |
| kgriffs | lets see, if we also insert a "last modified" timestamp per counter | 15:57 |
| kgriffs | then you could do a findandmodify that is like | 15:58 |
| kgriffs | query: { last_modified: {$lt: now - fudge_sec}} | 15:59 |
| kgriffs | so, only update it if it hasn't been updated for a few seconds | 15:59 |
| kgriffs | we would only do that if the queue is empty (last 'k' is unknown) | 16:00 |
| flaper87 | (current status: http://www.lacapital.com.ar/export/sites/core/imagenes/2012/08/30/08-30-malabares.jpg_88717827.jpg ) | 16:01 |
| kgriffs | although, I guess if fudge_sec is like 2, then maybe we can just always do that | 16:01 |
| *** zyuan has joined #openstack-marconi | 16:01 | |
| *** zyuan has quit IRC | 16:01 | |
| *** zyuan has joined #openstack-marconi | 16:02 | |
| flaper87 | mmh, yeah, I think we can use the last_modified field for that | 16:02 |
| flaper87 | mmh | 16:02 |
| flaper87 | (btw, meeting time) | 16:02 |
| kgriffs | mtg | 16:02 |
| kgriffs | #openstack-meeting-alt | 16:02 |
| flaper87 | ykaplan: ^ | 16:02 |
| *** zyuan_ has quit IRC | 16:02 | |
| *** tedross has joined #openstack-marconi | 16:06 | |
| *** cpritchett has joined #openstack-marconi | 16:36 | |
| zyuan | RT @HackerNewsOnion: Obama – "The national technical debt is increasing at an alarming rate. We have to stop writing PHP." | 16:56 |
| zyuan | LOL | 16:56 |
| flaper87 | btw guys, I forgot to mention: Marconi | 17:04 |
| flaper87 | damn it | 17:04 |
| flaper87 | MArconi's migration under openstack/* will be discussed in the next -infra meeting https://wiki.openstack.org/wiki/Meetings/InfraTeamMeeting | 17:04 |
| flaper87 | (Meeting is tomorrow) | 17:04 |
| flaper87 | kgriffs: ^ | 17:05 |
| *** openstackgerrit has quit IRC | 17:05 | |
| *** openstackgerrit has joined #openstack-marconi | 17:05 | |
| flaper87 | malini: did you create the bp or you want me to do it ? | 17:05 |
| malini | flaper87: I'll let you do it | 17:05 |
| flaper87 | malini: kk | 17:05 |
| malini | can steal your actions ;) | 17:05 |
| flaper87 | hahaha | 17:05 |
| malini | can't * | 17:05 |
| flaper87 | I can give them away | 17:05 |
| flaper87 | though | 17:05 |
| flaper87 | :D | 17:06 |
| flaper87 | who wants the bp creation action? | 17:06 |
| flaper87 | ( malini take your chance) | 17:06 |
| flaper87 | :D | 17:06 |
| malini | flaper87: we need to have the tempest tests in the next 6 weeks ? | 17:06 |
| *** cpritchett has quit IRC | 17:06 | |
| flaper87 | malini: nope, we need to have it 6 weeks before the next release | 17:06 |
| flaper87 | :D | 17:06 |
| flaper87 | which gives us a bunch of weeks | 17:06 |
| malini | tht is good :) | 17:07 |
| malini | I was getting worried | 17:07 |
| malini | I'll start looking at tempest though | 17:08 |
| flaper87 | malini: what's your nick on lp ? | 17:09 |
| malini | malini-pk | 17:10 |
| kgriffs | flaper87: I understand the integrated projects are currently in feature freeze, right? | 17:10 |
| flaper87 | kgriffs: correct | 17:10 |
| flaper87 | all frozen | 17:10 |
| kgriffs | ok, I think we should frozen too, with the exception of the proxy which is critical for scaling | 17:10 |
| kgriffs | for Icehouse we will obviously have to be super strict, tho | 17:11 |
| flaper87 | kgriffs: agreed! | 17:11 |
| flaper87 | kgriffs: when you get a chance: https://review.openstack.org/#/c/44475/4 | 17:12 |
| flaper87 | that's the one of the series | 17:12 |
| flaper87 | malini: I saw your comments | 17:12 |
| flaper87 | malini: can we do the .format as part of a separate patch? | 17:12 |
| flaper87 | since we just discussed that | 17:12 |
| malini | flaper87: sure | 17:13 |
| flaper87 | and re setUpClass, the issue is with loading the config instance | 17:13 |
| flaper87 | (read the comment in functional/base.py) | 17:13 |
| flaper87 | that's why I changed that from setUpClass to setUp | 17:13 |
| flaper87 | I don't think we should be using setUpClass there | 17:13 |
| flaper87 | :/ | 17:13 |
| flaper87 | anyway, brb! | 17:14 |
| * flaper87 is starving | 17:14 | |
| kgriffs | zyuan: https://bugs.launchpad.net/marconi/+bug/1222928 | 17:14 |
| kgriffs | I made it a bug | 17:14 |
| kgriffs | I will make other perf issues bugs as well | 17:15 |
| malini | flaper87: thanks..makes sense now | 17:15 |
| malini | Sorry I missed tht comment | 17:15 |
| flaper87 | malini: no worries :D | 17:17 |
| malini | That leaves us with just one, the last comment in https://review.openstack.org/#/c/44723/6/tests/functional/test_queue.py | 17:17 |
| flaper87 | malini: https://blueprints.launchpad.net/marconi/+spec/tsung-configs | 17:17 |
| malini | flaper87: can you assign me to tht bp ? | 17:18 |
| flaper87 | malini: yup, what's your lp nick ? | 17:18 |
| flaper87 | username | 17:18 |
| malini | malini-pk | 17:18 |
| flaper87 | malini: re the last comment, The metadata endpoint belongs to a specific queue: https://github.com/stackforge/marconi/blob/master/marconi/transport/wsgi/driver.py#L89 | 17:19 |
| flaper87 | malini: assigned to you | 17:20 |
| malini | flaper87: But the base_url is the same for all queues,eg. 'https://marconi.com/v1' + '/queues/queuename' | 17:21 |
| flaper87 | malini: replied here as well: https://review.openstack.org/#/c/44477/ | 17:21 |
| flaper87 | well, actually, I think you're right there. Plus, queue_url is not being used in that test case | 17:22 |
| flaper87 | good catch | 17:22 |
| flaper87 | I'll get rid of that | 17:23 |
| flaper87 | ok, brb, dinner | 17:23 |
| flaper87 | thanks malini | 17:23 |
| *** ykaplan has quit IRC | 17:35 | |
| kgriffs | malini: have you verified this is fixed? https://bugs.launchpad.net/marconi/+bug/1218990 | 17:35 |
| kgriffs | nevermind, just saw the comment | 17:36 |
| *** cppcabrera has joined #openstack-marconi | 17:40 | |
| openstackgerrit | A change was merged to stackforge/marconi: Pull actual tests out of marconi/tests https://review.openstack.org/44475 | 17:43 |
| openstackgerrit | A change was merged to stackforge/marconi: Remove util packages https://review.openstack.org/44476 | 17:44 |
| openstackgerrit | A change was merged to stackforge/marconi: Use oslo.config for functional tests https://review.openstack.org/44477 | 17:45 |
| cppcabrera | Seems I've walked in on a merge-a-thon. :P | 17:45 |
| cppcabrera | Heya, guys. | 17:45 |
| flaper87 | cppcabrera: HELLOOOOOOOOOOOOOOOOOOOO | 17:52 |
| flaper87 | cppcabrera: so happy to have you BACK!!!!! | 17:52 |
| *** kgriffs is now known as kgriffs_afk | 17:53 | |
| * flaper87 steps out again | 17:53 | |
| cppcabrera | Hahaha, glad to be back, flaper87. :) | 17:54 |
| cppcabrera | Today's a day off for me, so I'm just sitting back and catching up on everything I've missed. | 17:54 |
| *** jergerber has quit IRC | 17:56 | |
| *** kgriffs_afk is now known as kgriffs | 18:06 | |
| *** ayoung is now known as ayoung-afk | 18:29 | |
| flaper87 | back | 19:02 |
| flaper87 | cppcabrera: yo yo yo!!!! | 19:02 |
| flaper87 | hope you're ok, enjoy your day off | 19:02 |
| cppcabrera | thanks, flaper87! | 19:03 |
| flaper87 | btw, guys, still very experimental / young but, in case you want to give it a try https://github.com/FlaPer87/gerrit-cli | 19:08 |
| * flaper87 is already using it to query gerrit from cli | 19:08 | |
| kgriffs | flaper87: excellent | 19:10 |
| flaper87 | kgriffs: pip install gerrit-cli | 19:10 |
| * kgriffs does that | 19:11 | |
| flaper87 | 1 thing is really annoying, you have to specify the server, I use .ssh/config though | 19:11 |
| kgriffs | oic | 19:12 |
| flaper87 | kgriffs: http://paste.openstack.org/show/46351/ | 19:12 |
| flaper87 | kgriffs: this is what the command looks like: gerrit reviews list review --projects=stackforge/marconi | 19:12 |
| flaper87 | I'll make it read .gerritconfig | 19:12 |
| flaper87 | so, if you're in marconi's dir, it'll read that | 19:12 |
| kgriffs | that would awesome sauce | 19:14 |
| kgriffs | hmm | 19:14 |
| kgriffs | "Incorrect padding" | 19:14 |
| kgriffs | doesn't like my rsa key | 19:14 |
| flaper87 | mmmmhh, you using spaces instead of tabs? | 19:14 |
| flaper87 | is it complaining about .ssh/config ? | 19:14 |
| kgriffs | checking | 19:15 |
| kgriffs | no, doesn't seem to like my identity key | 19:18 |
| kgriffs | it's 2048 RSA, does that matter? | 19:18 |
| kgriffs | (vs. 1024) | 19:18 |
| flaper87 | kgriffs: mmh, don't think so. Try ssh kgriffs@review.openstack.org port | 19:20 |
| *** ayoung-afk is now known as ayoung | 19:21 | |
| kgriffs | port 29418 ? | 19:22 |
| flaper87 | kgriffs: yup | 19:22 |
| kgriffs | stupid mac | 19:26 |
| kgriffs | had to put -p in there | 19:26 |
| kgriffs | ssh kgriffs@review.openstack.org -p 29418 | 19:26 |
| kgriffs | anyway, it works fine | 19:26 |
| flaper87 | ah sorry, actually, -p is required in linux as well :D | 19:27 |
| flaper87 | sorry | 19:27 |
| kgriffs | heh, I should have known better | 19:27 |
| kgriffs | :p | 19:27 |
| kgriffs | flaper87: got a sec to talk about the indexing patch? | 19:42 |
| kgriffs | https://review.openstack.org/#/c/44340/6/marconi/storage/mongodb/messages.py | 19:42 |
| malini | flaper87: How do I specify the 'MARCONI_TESTS_CONFIGS_DIR' for the refactored functional tests? | 19:44 |
| flaper87 | kgriffs: yup | 19:48 |
| flaper87 | malini: export MARCONI_TESTS_CONFIG_DIR=/path/to/configs/dir | 19:49 |
| kgriffs | flaper87: ok, I just added a comment in reply | 19:49 |
| kgriffs | TL;DR it's a good idea to leave 'e' out of the index | 19:49 |
| flaper87 | kgriffs: awesome | 19:50 |
| flaper87 | I've to admit it's bit weird that leaving fields out of the index actually makes the query faster | 19:50 |
| flaper87 | anyway | 19:50 |
| flaper87 | :D | 19:50 |
| openstackgerrit | Kurt Griffiths proposed a change to stackforge/marconi: fix: Requests get slower when queues have a lot of messages https://review.openstack.org/44340 | 19:51 |
| kgriffs | flaper87: yes, we may see different characteristics depending on # of messages in the queue | 19:51 |
| openstackgerrit | Kurt Griffiths proposed a change to stackforge/marconi: fix: Requests get slower when queues have a lot of messages https://review.openstack.org/44340 | 19:56 |
| kgriffs | (rebased) | 19:56 |
| kgriffs | flaper87: ^^ Any other comments? | 19:56 |
| flaper87 | kgriffs: yeah, just 1 | 19:58 |
| flaper87 | kgriffs: LGTM | 19:58 |
| flaper87 | :D | 19:59 |
| flaper87 | (waiting for Jenkins to bless it) | 19:59 |
| kgriffs | w00t | 19:59 |
| kgriffs | I will have some folks benchmark it a final time to be sure | 19:59 |
| kgriffs | I'll get malini and/or oz to +1 and then it should be good to merge at you convenience. | 19:59 |
| kgriffs | (+1 after they benchmark) | 19:59 |
| *** tedross has quit IRC | 20:01 | |
| flaper87 | kgriffs: awesome, I'll wait for they bless as well then! | 20:04 |
| kgriffs | rock on | 20:04 |
| *** kgriffs is now known as kgriffs_afk | 20:06 | |
| *** kgriffs_afk is now known as kgriffs | 20:12 | |
| *** tedross has joined #openstack-marconi | 20:17 | |
| *** torgomatic has quit IRC | 20:31 | |
| *** kgriffs is now known as kgriffs_afk | 20:31 | |
| *** russell_h has quit IRC | 20:31 | |
| *** torgomatic has joined #openstack-marconi | 20:32 | |
| *** kgriffs_afk is now known as kgriffs | 20:33 | |
| *** russell_h has joined #openstack-marconi | 20:34 | |
| *** kgriffs is now known as kgriffs_afk | 20:39 | |
| *** cppcabrera has quit IRC | 20:48 | |
| *** oz_akan_ has quit IRC | 21:08 | |
| *** oz_akan_ has joined #openstack-marconi | 21:08 | |
| openstackgerrit | Zhihao Yuan proposed a change to stackforge/marconi: feat(mongo): use UNIX timestamp instead of datetime https://review.openstack.org/45760 | 21:09 |
| openstackgerrit | Zhihao Yuan proposed a change to stackforge/marconi: feat(mongo): use UNIX timestamp instead of datetime https://review.openstack.org/45760 | 21:30 |
| *** tedross has quit IRC | 21:33 | |
| *** malini is now known as malini_afk | 21:38 | |
| *** tedross has joined #openstack-marconi | 21:49 | |
| *** kgriffs_afk is now known as kgriffs | 21:53 | |
| *** oz_akan_ has quit IRC | 21:58 | |
| *** tedross has quit IRC | 22:14 | |
| *** kgriffs is now known as kgriffs_afk | 22:38 | |
| *** flaper87 is now known as flaper87|afk | 22:51 | |
| *** oz_akan_ has joined #openstack-marconi | 23:09 | |
| *** oz_akan_ has quit IRC | 23:13 | |
| *** tedross has joined #openstack-marconi | 23:14 | |
| *** oz_akan_ has joined #openstack-marconi | 23:20 | |
| *** tedross has quit IRC | 23:39 | |
| *** oz_akan_ has quit IRC | 23:55 | |
| *** oz_akan_ has joined #openstack-marconi | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
