| opendevreview | Merged openstack/puppet-manila master: Support [DEFAULT] admin_only_metadata https://review.opendev.org/c/openstack/puppet-manila/+/915043 | 02:40 |
|---|---|---|
| opendevreview | christian okeke proposed openstack/manila master: Add delete CLI helper to ShareCommands https://review.opendev.org/c/openstack/manila/+/911694 | 05:14 |
| ccokeke[m] | Hey gouthamr: carloss_: Review https://review.opendev.org/c/openstack/manila/+/911694 when you are available | 07:46 |
| opendevreview | Vida Haririan proposed openstack/manila master: [doc] Quota paramaters have moved to the [quota] section https://review.opendev.org/c/openstack/manila/+/914996 | 10:52 |
| opendevreview | Stephen Finucane proposed openstack/manila master: Add job to test with SQLAlchemy master (2.x) https://review.opendev.org/c/openstack/manila/+/888318 | 12:39 |
| opendevreview | Stephen Finucane proposed openstack/manila master: db: rename_table is not a batch operation https://review.opendev.org/c/openstack/manila/+/915127 | 12:39 |
| opendevreview | Merged openstack/manila master: db: update migrations to use SQLA 2.0 patterns https://review.opendev.org/c/openstack/manila/+/914721 | 13:15 |
| opendevreview | Stephen Finucane proposed openstack/manila master: Add job to test with SQLAlchemy master (2.x) https://review.opendev.org/c/openstack/manila/+/888318 | 13:33 |
| opendevreview | Stephen Finucane proposed openstack/manila master: tests: Don't (always) auto-create snapshot instances https://review.opendev.org/c/openstack/manila/+/915131 | 13:33 |
| tspyderboy[m] | https://review.opendev.org/c/openstack/python-manilaclient/+/913216 | 13:57 |
| tspyderboy[m] | Hi gouthamr: Please have a look when available. | 13:57 |
| tspyderboy[m] | Thanks | 13:57 |
| opendevreview | Stephen Finucane proposed openstack/manila master: tests: Don't (always) auto-create snapshot instances https://review.opendev.org/c/openstack/manila/+/915131 | 14:17 |
| opendevreview | Stephen Finucane proposed openstack/manila master: DNM: Reproducer for SQLA 2.0 ordering changes https://review.opendev.org/c/openstack/manila/+/915133 | 14:17 |
| opendevreview | Stephen Finucane proposed openstack/manila master: Add job to test with SQLAlchemy master (2.x) https://review.opendev.org/c/openstack/manila/+/888318 | 14:17 |
| stephenfin | gouthamr: carloss: I'd appreciate your thoughts on https://review.opendev.org/c/openstack/manila/+/915131. I think SQLA 2.x has unveiled a latent bug | 14:21 |
| stephenfin | gouthamr: I notice in Share.instance you specifically ordered the instances before selecting one, but we don't do that for ShareSnapshotInstance | 14:21 |
| stephenfin | i.e. https://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/models.py#L261-L294 vs https://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/models.py#L680-L701 | 14:22 |
| gouthamr | stephenfin: o/ is this failure in this unit test? https://opendev.org/openstack/manila/src/branch/master/manila/tests/db/sqlalchemy/test_api.py#L1826 | 14:42 |
| gouthamr | noob q; but i wasn't able to locate a log | 14:43 |
| opendevreview | christian okeke proposed openstack/manila master: Add delete CLI helper to ShareCommands https://review.opendev.org/c/openstack/manila/+/911694 | 14:52 |
| opendevreview | christian okeke proposed openstack/manila master: Add delete CLI helper to ShareCommands https://review.opendev.org/c/openstack/manila/+/911694 | 15:08 |
| opendevreview | christian okeke proposed openstack/manila master: Add delete CLI helper to ShareCommands https://review.opendev.org/c/openstack/manila/+/911694 | 15:09 |
| stephenfin | gouthamr: apologies, missed the ping. Yes, that test | 16:10 |
| stephenfin | Only with sqlalchemy 2.0 | 16:10 |
| opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph stable/2023.1: Bump to Reef https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/915146 | 16:13 |
| gouthamr | stephenfin: thank you; i missed your notes on this patch: https://review.opendev.org/c/openstack/manila/+/888318 :) i'll try this locally too and see if adding an ordering is functionally what we expect | 16:14 |
| tspyderboy[m] | Hi gouthamr: carloss:... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/MzeZrtrflqAjPhOPLNyJPpOq>) | 16:46 |
| tspyderboy[m] | s/// | 16:47 |
| tspyderboy[m] | s/// | 16:47 |
| gouthamr | tspyderboy[m]: o/ thanks; adding comments there | 16:58 |
| opendevreview | Merged openstack/manila master: db: turn off autocommit https://review.opendev.org/c/openstack/manila/+/914936 | 21:50 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!