opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Require enabled_share_backends https://review.opendev.org/c/openstack/puppet-manila/+/914576 | 06:03 |
---|---|---|
opendevreview | tspyderboy proposed openstack/python-manilaclient master: Handle empty metadata properly in filter/list https://review.opendev.org/c/openstack/python-manilaclient/+/914227 | 12:46 |
ccokeke[m] | gouthamr: kindly review https://review.opendev.org/c/openstack/manila/+/911694 | 15:39 |
ccokeke[m] | gouthamr: kindly review https://review.opendev.org/c/openstack/manila/+/913987 | 15:40 |
opendevreview | Ashley Rodriguez proposed openstack/manila master: [DOC] Add subnet metadata to user guide https://review.opendev.org/c/openstack/manila/+/914103 | 16:00 |
NaymulIslam[m] | gouthamr: | 16:10 |
NaymulIslam[m] | * gouthamr: Hi could you please have a look at the following: | 16:10 |
NaymulIslam[m] | https://review.opendev.org/c/openstack/manila/+/913210 | 16:10 |
NaymulIslam[m] | gouthamr: I am having some build issue could you please help me find out what the error is about: | 16:36 |
NaymulIslam[m] | https://review.opendev.org/c/openstack/python-manilaclient/+/913214 | 16:36 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph stable/2023.1: Fix stable CI https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/909055 | 16:43 |
gouthamr | ccokeke[m]: thanks; will do.. i intended to test both of these because unit tests don't cover them well.. if you want to start exploring the rest of the bugfix (apiref update and unit tests), go for it | 17:01 |
gouthamr | ccokeke[m]: have you setup a devstack host? | 17:02 |
gouthamr | NaymulIslam[m]: linting tests are failing on your patch | 17:03 |
gouthamr | NaymulIslam[m]: have you seen the logs here? https://zuul.opendev.org/t/openstack/build/80e5c31820db454eb0e464c5fcbbb066 (you'll find this if you click on "Zuul Summary" on the change, and click on "openstack-tox-pep8" | 17:03 |
gouthamr | NaymulIslam[m]: you can reproduce this test locally too... from the manila repo folder, execute: "tox -e pep8" | 17:04 |
ccokeke[m] | gouthamr: Permit me to have a look at this error and revert back shortly Thanks | 17:05 |
ccokeke[m] | <gouthamr> "Naymul Islam: have you seen..." <- This error is as a result pep8 violation | 17:13 |
gouthamr | ccokeke[m] ^ +1 | 17:14 |
ccokeke[m] | <gouthamr> "ccokeke: thanks; will do.. i..." <- Noted Sir | 17:17 |
ccokeke[m] | Naymul Islam: Run on your local environment `tox -e pep8` | 17:37 |
ccokeke[m] | Let me know the output | 17:37 |
opendevreview | Carlos Eduardo proposed openstack/manila master: [doc] Mount options in the ceph native driver https://review.opendev.org/c/openstack/manila/+/913846 | 17:57 |
NaymulIslam[m] | <gouthamr> "Naymul Islam: you can reproduce..." <- Let me do it once... | 18:06 |
NaymulIslam[m] | <gouthamr> "Naymul Islam: have you seen..." <- Yeah got it | 18:06 |
NaymulIslam[m] | <ccokeke[m]> "Naymul Islam: Run on your..." <- > <@ccokeke:matrix.org> Naymul Islam: Run on your local environment `tox -e pep8` | 18:07 |
NaymulIslam[m] | > Let me know the output | 18:07 |
NaymulIslam[m] | Thanks ccokeke I will do that shortly and update you :) | 18:07 |
opendevreview | Carlos Eduardo proposed openstack/manila master: [doc] Mount options in the ceph native driver https://review.opendev.org/c/openstack/manila/+/913846 | 18:15 |
tspyderboy[m] | <tspyderboy[m]> "Hi gouthamr carloss_..." <- > <@tspyderboy:matrix.org> Hi gouthamr carloss_... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/tdYgQoUgKPOlzSmBQhmJHgnY>) | 18:26 |
gouthamr | tspyderboy[m]: hmmm; that's an interesting question, and am following up on the conversation between you and tkajinam; lets chat on the patch | 19:14 |
tspyderboy[m] | Thanks, sure | 19:15 |
opendevreview | mike_mp@zzzcomputing.com proposed openstack/manila master: remove all use of autocommit https://review.opendev.org/c/openstack/manila/+/914720 | 22:01 |
opendevreview | mike_mp@zzzcomputing.com proposed openstack/manila master: WIP: update migrations to use SQLA 2.0 patterns https://review.opendev.org/c/openstack/manila/+/914721 | 22:02 |
opendevreview | mike_mp@zzzcomputing.com proposed openstack/manila master: WIP: update migrations to use SQLA 2.0 patterns https://review.opendev.org/c/openstack/manila/+/914721 | 22:03 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!