| *** enick_952 is now known as diablo_rojo | 03:09 | |
| opendevreview | Gireesh Awasthi proposed openstack/manila master: Implement the share backup for NetApp driver https://review.opendev.org/c/openstack/manila/+/909115 | 05:48 |
|---|---|---|
| opendevreview | melaku alehegn proposed openstack/manila-ui master: Create share network panel workflows https://review.opendev.org/c/openstack/manila-ui/+/840326 | 08:58 |
| opendevreview | kiran pawar proposed openstack/manila-tempest-plugin master: Add share backup tests. https://review.opendev.org/c/openstack/manila-tempest-plugin/+/841015 | 09:02 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: Add ceph filesystem name to share metadata https://review.opendev.org/c/openstack/manila/+/909175 | 13:03 |
| msaravan | Zoom invite for collab review meeting for Backup/Restore and Human Readable shares feature @14:00 UTC - https://netapp.zoom.us/j/96908608436?pwd=aCtNSngxMWVTVlV6Ykx6OW85UDZndz09&from=addon | 13:32 |
| carloss | https://meetpad.opendev.org/manila-caracal-cback-driver - Cback collab review meeting link :) | 16:03 |
| opendevreview | Carlos Eduardo proposed openstack/manila-tempest-plugin master: Skip driver/admin metadata in share metadata tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/909798 | 17:27 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: Add a new config option to specify admin metadata https://review.opendev.org/c/openstack/manila/+/909175 | 17:33 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: Add cephfs filesystem to shares metadata https://review.opendev.org/c/openstack/manila/+/909916 | 17:41 |
| klindgren_ | carloss, On 909916 - is something special needed to be ran to get existing shares to be updated? I cherrypicked this patch back to 2023.1 and it applied fine. Existing shares aren't updated - however new shares do get the metadata added to them, thoughts? | 17:49 |
| carloss | klindgren_: o/ so I think we need to make sure that ensure_shares is running, and that is identified by something changing in the backend | 17:50 |
| carloss | we can ensure that the routine is run by specifying a flag in the cephfs native backend stanza in the manila.conf: | 17:50 |
| carloss | for example: cephfs_ensure_all_shares_salt=manila_cephfs_reef_caracal | 17:50 |
| carloss | this way, when we get the backend stanza updated info, manila will check the database and try to see if the hash of the previous conf matches the new | 17:51 |
| carloss | it won't, so it will re-run the ensure_shares routine | 17:51 |
| carloss | which will force manila to go through the code path I am introducing :) | 17:51 |
| carloss | and set the __mount_option metadata in the existing shares | 17:52 |
| gouthamr | ^ carloss i suggest we change the salt with your patch to force an update | 17:58 |
| carloss | gouthamr: makes sense | 18:04 |
| klindgren_ | https://paste.openstack.org/show/bvrAUCy0O2ex1yUgEsbi/ - guessing this is because 2023.1 doesn't have the cephfs manage shares option that merged later on and was included in 2023.2 | 18:05 |
| klindgren_ | :sadpanda: | 18:05 |
| carloss | ah, I think that's my mistake klindgren_ | 18:07 |
| carloss | yeah, my mistake... I updated the method signature but didn't update the usage in the cephfs driver after a review by gouthamr | 18:08 |
| carloss | updating the change in a sec | 18:08 |
| klindgren_ | question - just so I know what to cherrypick back is 909916 dependent on 909175? | 18:09 |
| klindgren_ | it was nice when it was in all one patch :-) - hehehe | 18:09 |
| carloss | > question - just so I know what to cherrypick back is 909916 dependent on 909175? | 18:15 |
| carloss | yes, so 909916 should be cherry-picked on top of 909175, as it uses some bits of the 909175 implementation | 18:15 |
| carloss | klindgren_: yeah, it honestly was easier to apply and review, but we usually split changes like this for some reasons: | 18:23 |
| carloss | 1. share driver interface changes are supposed generic, so they should't target a specific driver | 18:23 |
| carloss | 2. If we introduce driver specific changes alongside a core change, it might be difficult to check back on the history of things being merged. In the way it was, if we were looking at the commit history for a reason and we saw the commit message in the lines of "add config option to admin share metadata" it would be difficult to figure out that the cephfs driver metadata was introduced alongside | 18:23 |
| carloss | 3. if the feature is merged and we find an issue in the driver, the entire change would need to be reverted, even if the core worked just fine :p | 18:23 |
| klindgren_ | ok | 18:26 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: Add cephfs filesystem to shares metadata https://review.opendev.org/c/openstack/manila/+/909916 | 18:28 |
| carloss | ^ this should work :) | 18:28 |
| carloss | klindgren_: apologies for the older version that didn't work... most recent PS worked on my devstack | 18:36 |
| klindgren_ | Consider it my fully function tested code review :-) | 18:37 |
| klindgren_ | confirmed that the new code on hash update, doesn't throw errors and does updated existing shares. | 19:14 |
| carloss | klindgren_: tyvm for testing | 20:14 |
| opendevreview | Carlos Eduardo proposed openstack/manila-tempest-plugin master: Ensure metadata tests manipulate only its own metadata https://review.opendev.org/c/openstack/manila-tempest-plugin/+/909798 | 21:26 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!