| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/wallaby: [rbac] Pull up policy checks on share/snapshot APIs https://review.opendev.org/c/openstack/manila/+/908386 | 01:15 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/yoga: [RBAC] Enforce check for share updates https://review.opendev.org/c/openstack/manila/+/898488 | 05:03 |
| opendevreview | James Page proposed openstack/manila master: tests: has_calls -> assert_has_calls https://review.opendev.org/c/openstack/manila/+/908400 | 09:40 |
| opendevreview | kiran pawar proposed openstack/manila-specs master: Add spec for share encryption https://review.opendev.org/c/openstack/manila-specs/+/898999 | 11:12 |
| opendevreview | kiran pawar proposed openstack/manila-specs master: Add spec for share encryption https://review.opendev.org/c/openstack/manila-specs/+/898999 | 12:36 |
| opendevreview | Merged openstack/devstack-plugin-ceph stable/2023.1: Remote Ceph with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/897972 | 16:24 |
| opendevreview | Merged openstack/manila stable/xena: [rbac] Pull up policy checks on share/snapshot APIs https://review.opendev.org/c/openstack/manila/+/907945 | 20:46 |
| opendevreview | Merged openstack/python-manilaclient stable/2023.2: Fix "per_share_gigabytes" in "openstack quota set" https://review.opendev.org/c/openstack/python-manilaclient/+/907932 | 21:19 |
| opendevreview | Merged openstack/manila master: Retry on connection error to neutron https://review.opendev.org/c/openstack/manila/+/905695 | 21:40 |
| klindgren | Hello - I submitted https://review.opendev.org/c/openstack/manila/+/905986 a while back - which has some changes to allow manila along with using the existing oversubscription logic, to provision shares between multiple cephfs filesystems on the ceph cluster. I haven't seen any reviews or any discussion of this, the associated bug or the PR. Just wondering if this is an OK approach to take to this problem or if something else should be done? | 22:01 |
| opendevreview | Merged openstack/devstack-plugin-ceph stable/2023.1: Update default ceph image tag to remove patch version https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/900581 | 22:13 |
| gouthamr | klindgren: o/ hi thanks for checking.. carloss (may be out today) was taking a look at this and will provide an update... he may comment on your patch if he seeks changes | 22:39 |
| gouthamr | klindgren: i consulted with ceph engineering folks, and they confirmed that there's no ceph mgr API that we can take advantage of to get the allocated_capacity_gb like we need; so, your approach may be the one to take | 22:39 |
| gouthamr | i was hoping we can optimize this further - instead of reading this information every minute (that's the default periodicity of the _update_share_stats() method that you're modifying), we could read that data on startup (once) and maintain a running tally of the allocated space... we have a database handle in the driver that can be used for storing information like this for quick retrieval | 22:41 |
| gouthamr | i'll let carloss chime in on your patch when he's played with this a bit | 22:42 |
| opendevreview | Merged openstack/manila master: tests: has_calls -> assert_has_calls https://review.opendev.org/c/openstack/manila/+/908400 | 23:37 |
| klindgren | ok thanks - happy to make any changes - just hadn't heard anything yet. I also looked for a similar API to make a single call to get information - but didn't find one. Currently the approach works ok, but if you have a ton of shares its going to generate a ton of calls, which is obviously less than ideal. On my own deployment I was thinking of decreasing the frequency of the periodic, since I am not sure minute accurate cluster consumption i | 23:48 |
| klindgren | s particularly needed for us as well. | 23:48 |
| JayF | klindgren: thanks for stopping by and advocating for your patch ++ I don't work on manila generally or I would've responded | 23:50 |
| klindgren | :thumbsup: - I kinda figured people were busy with other things, but it was a pretty trivial change to get *something* that would work. So I figured I would push it up to see if there was some otherway I should go about it. I am not familure with the Manila code base at all. | 23:54 |
| JayF | Yeah, many projects are maintained by people with myriad responsibilities, inside and outside Openstack. Part of why I idle in so many project channels is so I can ping a PTL if people aren't getting helped :) | 23:57 |
| JayF | So thank you for going the extra mile here 👍 | 23:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!