| carloss | o/ Uggla just uploaded a new openstacksdk patch set. I haven't tested it yet, will do in a sec | 11:43 |
|---|---|---|
| Uggla | Hi carloss ! Great. Have you seen my comment about the rev ? | 12:19 |
| carloss | Uggla: https://review.opendev.org/c/openstack/openstacksdk/+/889519/3..5/openstack/shared_file_system/v2/_proxy.py#b881 this one? | 12:20 |
| Uggla | carloss, nop that one : https://review.opendev.org/c/openstack/openstacksdk/+/889519/comment/757a9c38_c6dfb836/ I think the µversion should be 2.81. | 12:22 |
| carloss | ah yeah, saw that... updated in the newest PS | 12:22 |
| carloss | versions changing quickly with lots of API bumps in manila this cycle :) | 12:22 |
| carloss | Uggla: it should be fine | 12:22 |
| carloss | fine now* | 12:22 |
| Uggla | carloss, please let me know when I can use it. I'm about to run new tests, so I can use this latest version. | 12:24 |
| Uggla | just need your confirmation that it is ok. | 12:24 |
| Uggla | carloss, so I use the latest sdk, can't wait to test it. :) | 12:55 |
| Uggla | carloss, and it works fine. | 12:55 |
| carloss | ah, thanks Uggla | 12:56 |
| carloss | sorry for the delay, having a couple of meetings atm | 12:56 |
| Uggla | carloss, gouthamr I will be on vacation starting this evening for 3 weeks. I will send you a status and possible improvements. | 12:58 |
| carloss | awesome Uggla - thanks! hope you have a good time | 12:58 |
| carloss | I'll also be on vacation, but only in the next week. I'll be back on Aug 14thj | 12:58 |
| carloss | 14th* | 12:59 |
| Uggla | But so far it works well. | 12:59 |
| Uggla | carloss, cool ! enjoy your vacation too. | 12:59 |
| Uggla | the only thing that need more work is that currently it uses the admin context and not the security context. Either my configuration is bad or I miss something. | 13:01 |
| carloss | > carloss, cool ! enjoy your vacation too. | 13:10 |
| carloss | thanks! | 13:10 |
| carloss | > the only thing that need more work is that currently it uses the admin context and not the security context. Either my configuration is bad or I miss something. | 13:12 |
| carloss | puzzling... we are identifying the service context by the presence of a service role in the request | 13:12 |
| carloss | Uggla: https://review.opendev.org/c/openstack/manila/+/887115/9/manila/context.py#62 | 13:13 |
| carloss | one way would be to try to see what's in the request context manila is receiving, so we' ensure that we have a service role there | 13:13 |
| carloss | I believe we saw something similar being done in cinder | 13:13 |
| Uggla | carloss, yep that's my understanding, you are looking for the service token in the request. | 13:14 |
| Uggla | and I think I configure nova/manila to use there token. But I might make a mistake somewhere. | 13:15 |
| Uggla | Anyway, we could probably fix that as soon as I'll be back. | 13:15 |
| Uggla | And atm, I have not looked at the http request, if it has the token or not. I focused mainly on the code logic. | 13:16 |
| opendevreview | Liron Kuchlani proposed openstack/python-manilaclient master: Enable the option to return the response body https://review.opendev.org/c/openstack/python-manilaclient/+/890330 | 13:22 |
| opendevreview | Renan Vitor proposed openstack/manila master: NetApp: Improve REST API cover and fix internals https://review.opendev.org/c/openstack/manila/+/887562 | 13:46 |
| carloss | > And atm, I have not looked at the http request, if it has the token or not. I focused mainly on the code logic. | 13:58 |
| carloss | Uggla ack | 13:58 |
| carloss | I think you will be back in the week of the feature freeze. I am hoping we have everything merged by then | 13:59 |
| carloss | on the manila side | 13:59 |
| opendevreview | Merged openstack/manila master: [API] Validate display name/description length https://review.opendev.org/c/openstack/manila/+/886164 | 22:05 |
| opendevreview | Merged openstack/manila-ui master: Remove empty choices added to required fields https://review.opendev.org/c/openstack/manila-ui/+/890142 | 22:20 |
| opendevreview | Merged openstack/manila master: [NetApp] Fix NetApp driver create from snapshot https://review.opendev.org/c/openstack/manila/+/883175 | 22:26 |
| opendevreview | Merged openstack/manila-tempest-plugin master: Fixed multiple subnet negative tempest test https://review.opendev.org/c/openstack/manila-tempest-plugin/+/858448 | 23:07 |
| opendevreview | Merged openstack/manila stable/2023.1: [NetApp] Fix non-disruptive migration cifs shares https://review.opendev.org/c/openstack/manila/+/880593 | 23:31 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!