| Uggla | gouthamr, I am just using the sdk through the python interpreter without giving any version to use. | 08:02 |
|---|---|---|
| Uggla | gouthamr, carloss , I have done this patch and it appears to work in my case. (https://review.opendev.org/c/openstack/openstacksdk/+/888909) | 08:44 |
| Uggla | gouthamr, carloss, here is the result after using this patch https://paste.opendev.org/show/bSiewq6brKzcyR2fq8VK/ | 08:45 |
| carloss | ty for the patch Uggla | 11:50 |
| Uggla | carloss, no pb, but please review it to be sure it is correct. :) | 11:58 |
| carloss | Uggla: yeah, I'm taking a look, I must confess I'm confused with the usage of _max_microversion and _min_microversion in all the examples in the SDK haha | 11:59 |
| Uggla | carloss, me too. ;) | 12:13 |
| carloss | Uggla: left a comment in the change, maybe stephenfin can shed some light on this :) | 12:20 |
| Uggla | carloss, from stephenfin I understood that _min_microversion is not used. And I think _max_microversion is used to negociate the version and then if it fails, then it is downgraded until a microversion between client and server works. | 12:23 |
| carloss | Uggla: that makes sense, thanks... _max_microversion was the thing that confused me the most | 12:27 |
| carloss | stephenfin: thanks for the response in the change | 12:34 |
| stephenfin | nw | 12:35 |
| carloss | Uggla: I think the most appropriate version for _max_microversion is 2.47 then, could you please update the change? | 12:35 |
| Uggla | carloss, are you sure ? I used 2.63 because it was set in the functional test example provided by gouthamr above. | 12:37 |
| carloss | Uggla: yes... I think he's added 2.63 in the functional tests because that was the most recent microversion in Manila by the time he introduced that code... If you blame this file: https://github.com/openstack/manila/blame/master/manila/api/openstack/api_version_request.py - it shows 2.63 as modified 2 years ago, and blaming this file: | 12:40 |
| carloss | https://github.com/openstack/openstacksdk/blame/b93ea39ea5c1edff4b59ad0940992b5e4a8c695a/openstack/tests/functional/shared_file_system/base.py#L25-L26, it shows that it was also ~2 years ago | 12:40 |
| carloss | but 2.63 is not related to changes in the export location APIs | 12:41 |
| Uggla | carloss, ok I gonna change. | 12:42 |
| carloss | tyvm Uggla :) | 12:42 |
| Uggla | carloss, done | 12:48 |
| carloss | Uggla: LGTM, were you able to test with this version? | 13:19 |
| carloss | I'm trying to now, but that's one of the first times I test stuff with openstacksdk :p | 13:19 |
| carloss | I'm lost on where to apply the changes | 13:19 |
| Uggla | carloss, yep I have just done a new test with this version and it works fine. | 13:22 |
| carloss | tyvm Uggla :) | 13:22 |
| Uggla | carloss, just to explain my test, I have a devstack setup with manila and a share created. Then I pull the openstacksdk on this devstack, install it and just run what is in https://paste.opendev.org/show/bSiewq6brKzcyR2fq8VK/ | 13:25 |
| carloss | ah, thanks Uggla - I was unsure about the install part. After the clone + applying your changes I did pip install I was able to test it too | 13:27 |
| carloss | Uggla++ :) | 13:27 |
| Uggla | carloss, no pb. You just need to take care it takes the good openstacksdk version. Because it can be confusing if you have already a local install. | 13:29 |
| carloss | ack, thanks :) | 13:35 |
| opendevreview | kiran pawar proposed openstack/manila master: NetApp: Stop clone split while deleting child share. https://review.opendev.org/c/openstack/manila/+/888927 | 14:11 |
| opendevreview | Carlos Eduardo proposed openstack/python-manilaclient master: [WIP] Allow restricting access rules https://review.opendev.org/c/openstack/python-manilaclient/+/888355 | 18:45 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: [WIP] Add APIs to restrict rules fields and lock rules https://review.opendev.org/c/openstack/manila/+/887725 | 19:10 |
| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: Update location of cephadm script https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/888952 | 19:47 |
| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: Update location of cephadm script https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/888952 | 19:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!