| rotensepro | gouthamr: please are you here? | 02:43 |
|---|---|---|
| gouthamr | hey rotensepro: wassup? | 02:43 |
| rotensepro | gouthamr: ooh thats fast haha | 02:44 |
| rotensepro | gouthamr: these are the dependency to be removed right (first two lines) ? | 02:45 |
| rotensepro | https://prnt.sc/m9IEvcedqNS3 | 02:46 |
| rotensepro | its pops up after typed "``git rebase -i origin/master`" | 02:47 |
| rotensepro | gouthamr: i hope im following right steps haha.... | 02:49 |
| gouthamr | rotensepro: thought you were planning to start with this patch: https://review.opendev.org/c/openstack/manila/+/858228/ | 02:51 |
| rotensepro | yes i did | 02:52 |
| rotensepro | the id is | 02:52 |
| rotensepro | 858228 | 02:52 |
| rotensepro | gouthamr: see my terminal here >>> https://prnt.sc/KEYrPa3Z7AV- | 02:54 |
| rotensepro | gouthamr: is there any correction or mistake please :( ? | 02:56 |
| gouthamr | rotensepro: ack rotensepro; lets delete those two lines and see what happens; i'm confused because gerrit isn't seeing those parent commits that you're seeing | 02:57 |
| rotensepro | ooh really | 02:58 |
| rotensepro | gouthamr: okay i will do that now | 02:58 |
| gouthamr | after you go through the rebase, inspect the last commit just to be sure you have a good starting point | 03:00 |
| rotensepro | okay, using git commt --amend right? | 03:01 |
| gouthamr | rotensepro: inspecting the commit? "git show" | 03:02 |
| rotensepro | gouthamr, ooh thats true | 03:03 |
| gouthamr | rotensepro: after you make your changes, you'd "git commit --amend .." | 03:03 |
| rotensepro | just for confirmation please....no need to add any line in the git rebase process right? just save and quit right? | 03:04 |
| gouthamr | yes | 03:04 |
| rotensepro | gouthamr: I got this reponse after inspect with "git show", https://prnt.sc/_QDttZilawC7 | 03:08 |
| gouthamr | looks good; now improve it :) | 03:09 |
| rotensepro | :) thank you okay haha | 03:10 |
| rotensepro | i can generate the release note with "reno new slug-goes-here" ? | 03:12 |
| rotensepro | gouthamr: i understand the reno now cool haha | 03:17 |
| rotensepro | gouthamr: is this a good way to name my release note haha “bug-858228-fixed-the-build-error” ? | 03:18 |
| gouthamr | "fixed the build error" doesn't sound right for that bug | 03:30 |
| gouthamr | also this is the bug id rotensepro: https://bugs.launchpad.net/manila/+bug/1944478 | 03:30 |
| gouthamr | so probably something like "bug-1944478-share-type-format-check" | 03:30 |
| gouthamr | or along those lines | 03:30 |
| rotensepro | okay cool...noted | 03:32 |
| rotensepro | gouthamr: i think i can add close bug to the commit message, "Closes-Bug: #1944478" | 03:48 |
| gouthamr | rotensepro: yes | 03:55 |
| rotensepro | gouthamr: okay, thanks so much....on it...almost done | 03:56 |
| gouthamr | ++ | 03:56 |
| opendevreview | Rotense Gabriel proposed openstack/manila master: Fixed share_type bug https://review.opendev.org/c/openstack/manila/+/858214 | 04:07 |
| opendevreview | Rotense Gabriel proposed openstack/manila master: Format check bug in Share_type request fixed https://review.opendev.org/c/openstack/manila/+/858228 | 04:07 |
| opendevreview | Rotense Gabriel proposed openstack/manila master: Share_type format check in request fixed https://review.opendev.org/c/openstack/manila/+/858228 | 04:11 |
| rotensepro | done :) | 04:14 |
| rotensepro | https://paste.opendev.org/show/bhU3rE60HTeKEemoL7Kr/ | 04:14 |
| rotensepro | gouthamr: Gerrit: https://review.opendev.org/c/openstack/manila/+/858228 | 04:15 |
| rotensepro | can i add my two mentors under CC ? | 04:16 |
| rotensepro | fpantano and ashley | 04:16 |
| gouthamr | sure rotensepro | 04:27 |
| rotensepro | done :) Thank you. | 04:27 |
| gouthamr | thanks; remember that your patch doens't have to merge before the application deadline | 04:27 |
| rotensepro | okay sir, thanks :) | 04:27 |
| rotensepro | looking out to contribute more and learn more as i'm passionate about openstack and linux . | 04:28 |
| rotensepro | hope i become an active contributor soon :) | 04:29 |
| rotensepro | thank you! | 04:29 |
| rotensepro | your response was the best ha! | 04:29 |
| rotensepro | +1 | 04:30 |
| gouthamr | that's awesome; thanks rotensepro - all the best! | 04:30 |
| opendevreview | kiran pawar proposed openstack/manila master: Add config option to set per_share_extend_size_limit. https://review.opendev.org/c/openstack/manila/+/853957 | 09:07 |
| *** dviroel|holiday is now known as dviroel|rover | 11:19 | |
| opendevreview | Dmitriy Rabotyagov proposed openstack/devstack-plugin-ceph master: Use default Ubuntu Jammy ceph repos https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/863524 | 14:05 |
| opendevreview | kiran pawar proposed openstack/manila-specs master: Add spec for share backup https://review.opendev.org/c/openstack/manila-specs/+/330306 | 14:15 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/devstack-plugin-ceph master: Use default Ubuntu Jammy ceph repos https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/863524 | 15:16 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/devstack-plugin-ceph master: Use default Ubuntu Jammy ceph repos https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/863524 | 15:19 |
| opendevreview | Merged openstack/manila stable/ussuri: Define queues at project level https://review.opendev.org/c/openstack/manila/+/847445 | 15:36 |
| *** dviroel|rover is now known as dviroel|afk | 15:50 | |
| gouthamr | chuanm: i don't have a netapp system to test this, but my concern was that an update is going to be async --- so firing off a "promote" without waiting isn't helpful | 16:02 |
| gouthamr | https://review.opendev.org/c/openstack/manila/+/856539/4/manila/share/manager.py#2476 | 16:03 |
| felipe_rodrigues | agree | 16:04 |
| felipe_rodrigues | actually, calling the driver "update_replica_state" won't call the storage "update" relationship | 16:10 |
| kpdev | Please review https://review.opendev.org/c/openstack/manila-specs/+/330306 | 16:24 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/devstack-plugin-ceph master: Use default Ubuntu Jammy ceph repos https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/863524 | 16:32 |
| *** dviroel|afk is now known as dviroel|rover | 16:56 | |
| opendevreview | Carlos Eduardo proposed openstack/manila stable/train: Define queues at project level https://review.opendev.org/c/openstack/manila/+/863548 | 17:53 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/train: Fix stable/train CI jobs https://review.opendev.org/c/openstack/manila/+/847595 | 18:20 |
| opendevreview | Merged openstack/manila stable/ussuri: [RBAC] Return 404 if share is inaccessible https://review.opendev.org/c/openstack/manila/+/859240 | 19:23 |
| *** dviroel|rover is now known as dviroel|afk | 22:29 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!