opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: DNM: Test missing rootwrap filter rule for Manila https://review.opendev.org/c/openstack/puppet-manila/+/855300 | 00:22 |
---|---|---|
opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: DNM: Test missing rootwrap filter rule for Manila https://review.opendev.org/c/openstack/puppet-manila/+/855300 | 01:22 |
opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: DNM: Test missing rootwrap filter rule for Manila https://review.opendev.org/c/openstack/puppet-manila/+/855300 | 01:46 |
opendevreview | haixin proposed openstack/manila master: Update micversion to API 2.73, support share transfer between project https://review.opendev.org/c/openstack/manila/+/843832 | 02:32 |
opendevreview | haixin proposed openstack/python-manilaclient master: WIP: update micversion to 2.73,support share transfer between project. https://review.opendev.org/c/openstack/python-manilaclient/+/854312 | 02:36 |
opendevreview | Goutham Pacha Ravi proposed openstack/python-manilaclient master: [reno] Announce openstackclient GA https://review.opendev.org/c/openstack/python-manilaclient/+/855306 | 02:59 |
gouthamr | \m/ | 03:01 |
opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: DNM: Test missing rootwrap filter rule for Manila https://review.opendev.org/c/openstack/puppet-manila/+/855300 | 03:26 |
opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: DNM: Test missing rootwrap filter rule for Manila https://review.opendev.org/c/openstack/puppet-manila/+/855300 | 03:42 |
opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: DNM: Test missing rootwrap filter rule for Manila https://review.opendev.org/c/openstack/puppet-manila/+/855300 | 04:42 |
opendevreview | kiran pawar proposed openstack/manila master: onlyHostFilter: Fix follow-up suggestions. https://review.opendev.org/c/openstack/manila/+/824726 | 06:54 |
opendevreview | haixin proposed openstack/python-manilaclient master: WIP: update micversion to 2.73,support share transfer between project. https://review.opendev.org/c/openstack/python-manilaclient/+/854312 | 08:07 |
opendevreview | kiran pawar proposed openstack/python-manilaclient master: Add 'share-network' option for share replica create. https://review.opendev.org/c/openstack/python-manilaclient/+/804579 | 09:22 |
opendevreview | kiran pawar proposed openstack/manila master: Fix tests for 'share-network' param in share replica create https://review.opendev.org/c/openstack/manila/+/855123 | 09:55 |
opendevreview | kiran pawar proposed openstack/python-manilaclient master: Add 'share-network' option for share replica create. https://review.opendev.org/c/openstack/python-manilaclient/+/804579 | 10:42 |
opendevreview | Victoria Martinez de la Cruz proposed openstack/manila-tempest-plugin master: [CI] Add CephFS Native and CephFS NFS with cephadm jobs https://review.opendev.org/c/openstack/manila-tempest-plugin/+/834220 | 10:55 |
*** dviroel|out is now known as dviroel | 11:23 | |
opendevreview | Lucas Morais de oliveira proposed openstack/manila master: Remove status field from security services API https://review.opendev.org/c/openstack/manila/+/845586 | 11:52 |
opendevreview | Lucas Morais de oliveira proposed openstack/manila master: Remove status field from security services API https://review.opendev.org/c/openstack/manila/+/845586 | 11:55 |
opendevreview | Franca Mgbogu proposed openstack/python-manilaclient master: [OSC] Implement Share Server Migration check and restart-check https://review.opendev.org/c/openstack/python-manilaclient/+/854179 | 11:58 |
opendevreview | Franca Mgbogu proposed openstack/python-manilaclient master: [OSC] Implement Share Server Migration check and restart-check https://review.opendev.org/c/openstack/python-manilaclient/+/854179 | 12:00 |
opendevreview | kiran pawar proposed openstack/python-manilaclient master: Add 'share-network' option for share replica create. https://review.opendev.org/c/openstack/python-manilaclient/+/804579 | 12:54 |
opendevreview | Victoria Martinez de la Cruz proposed openstack/manila-tempest-plugin master: [CI] Add CephFS Native and CephFS NFS with cephadm jobs https://review.opendev.org/c/openstack/manila-tempest-plugin/+/834220 | 13:56 |
opendevreview | kiran pawar proposed openstack/python-manilaclient master: Add 'share-network' option for share replica create. https://review.opendev.org/c/openstack/python-manilaclient/+/804579 | 14:27 |
*** dviroel is now known as dviroel|lunch | 15:25 | |
opendevreview | Franca Mgbogu proposed openstack/python-manilaclient master: [OSC] Implement Share Server Migration check and restart-check https://review.opendev.org/c/openstack/python-manilaclient/+/854179 | 15:28 |
opendevreview | Deokjune, Yi proposed openstack/python-manilaclient master: Make the OSC plugin handle the --insecure flag input https://review.opendev.org/c/openstack/python-manilaclient/+/855382 | 15:32 |
opendevreview | Deokjune, Yi proposed openstack/python-manilaclient master: Make the OSC plugin handle the --insecure flag input https://review.opendev.org/c/openstack/python-manilaclient/+/855382 | 15:39 |
opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: DNM: Test missing rootwrap filter rule for Manila https://review.opendev.org/c/openstack/puppet-manila/+/855300 | 15:39 |
opendevreview | Deokjune, Yi proposed openstack/python-manilaclient master: Make the OSC plugin handle the --insecure flag https://review.opendev.org/c/openstack/python-manilaclient/+/855382 | 15:42 |
fzzf[m] | gouthamr: Hi, I see you message, do you mean I should update pacth about this commit. https://review.opendev.org/c/openstack/manila/+/825429 | 15:53 |
gouthamr | hey fzzf[m]: you can respond inline and make a follow up patch if you wish - we have a merge deadline for feature-ful changes tomorrow | 15:54 |
vkmc | fzzf[m], gouthamr is away for this week... for what I see in his review, seems he have a couple of concerns and he would like a response on that patch or in a follow up patch (after this merges) | 15:54 |
gouthamr | fzzf[m]: so I don’t want to hold your patch up with my comments :) | 15:55 |
vkmc | gouthamr, oh you are around :D | 15:55 |
gouthamr | vkmc: ++ /me is checking irc on a phone 😛 but yes, will be away in an hour :) | 15:55 |
fzzf[m] | gouthamr: sorry, I can't be able to finish the new patch tomorrow. I need a few days. | 15:57 |
fzzf[m] | vkmc: thanks. I get. | 15:58 |
gouthamr | fzzf[m]: sure thing; I’m okay with that … carloss ^ | 15:58 |
fzzf[m] | gouthamr: do you mean, if I update new patch, it need zuul+1 and CI run with success. then it should be finish. | 16:00 |
fzzf[m] | gouthamr: What is the exact deadline for tomorrow? | 16:01 |
gouthamr | fzzf[m]: your changes with respect to my comments can come in a separate/follow up change; if other reviewers are okay we might merge your current patch as is. The follow up change will need Zuul and your CI system to run and vote on it | 16:03 |
gouthamr | fzzf[m]: to clarify, we expect that your CI system will run on every code change submitted against manila from now on, even if the change doesn’t involve your driver | 16:04 |
fzzf[m] | gouthamr: sorry, How to come in a separate change with comments? I don't know. | 16:07 |
gouthamr | fzzf[m]: by “end of day” UTC tomorrow… but, if you’d like an extension, please check with carloss … your current change is adding a new feature - the driver; but follow up changes responding to these comments could be tweaking a few things - not adding new features; | 16:07 |
fzzf[m] | gouthamr: okay, I get it | 16:08 |
gouthamr | fzzf[m]: https://releases.openstack.org/zed/schedule.html - this has the deadlines and schedule ; after our feature freeze tomorrow, we will only be merging bug fixes and non-feature code for a while | 16:10 |
gouthamr | fzzf[m]: per that schedule, we ship a release candidate on or before Sep 16 from the “master” branch; at that time, we’ll create a branch for the “zed” release and we’re open to merging new features in the “master” branch again | 16:12 |
carloss | thanks for responding gouthamr vkmc | 16:13 |
carloss | but gouthamr is correct, fzzf[m] - we can merge your change as is if no other reviewer find something that blocks it | 16:14 |
carloss | and then you can submit other separate change to just address the comments | 16:14 |
fzzf[m] | carloss: do you mean I can submit other separate change after change is merged? | 16:16 |
carloss | fzzf[m]: yes | 16:16 |
carloss | that would be the said follow-up change | 16:16 |
fzzf[m] | carloss: okay, I get. thanks | 16:17 |
carloss | added my +2 as well - dviroel|lunch also reviewed this change in the past, I'll get him a chance for a second pass in case he has some time for it | 16:18 |
*** dviroel|lunch is now known as dviroel | 16:25 | |
dviroel | carloss: fzzf[m]: i will take a look in a few minutes, | 16:28 |
carloss | thanks dviroel | 16:28 |
opendevreview | Merged openstack/manila master: [Infinidat] add support for TLS/SSL communication https://review.opendev.org/c/openstack/manila/+/853780 | 18:06 |
opendevreview | Franca Mgbogu proposed openstack/python-manilaclient master: [OSC] Implement Share Server Migration check and restart-check https://review.opendev.org/c/openstack/python-manilaclient/+/854179 | 18:25 |
opendevreview | Ashley Rodriguez proposed openstack/manila master: Metadata for Share Snapshots Resource https://review.opendev.org/c/openstack/manila/+/825008 | 18:31 |
opendevreview | Ashley Rodriguez proposed openstack/python-manilaclient master: Metadata for Share Snapshots https://review.opendev.org/c/openstack/python-manilaclient/+/803424 | 18:33 |
carloss | thanks dviroel | 18:47 |
dviroel | fzzf[m]: o/ congrats for the hard work on MacroSan driver | 18:47 |
dviroel | fzzf[m]++ | 18:48 |
carloss | fzzf[m]: it took some time, but the driver is in the gates now. congratulations! your hard work with the CI and the driver is paying off :) | 18:48 |
gouthamr | ya’ll are tempting zuul’s wrath on feature freeze day 😂 | 18:49 |
carloss | I'm sorry we didn't have much documentation on third party drivers setup, but that just highlighted how much improvement we need in that area | 18:50 |
carloss | gouthamr lol | 18:50 |
*** dviroel is now known as dviroel|afk | 19:47 | |
opendevreview | Merged openstack/python-manilaclient master: Add 'share-network' option for share replica create. https://review.opendev.org/c/openstack/python-manilaclient/+/804579 | 20:02 |
opendevreview | Merged openstack/manila master: Add Macrosan Manila Driver https://review.opendev.org/c/openstack/manila/+/825429 | 20:14 |
opendevreview | Merged openstack/python-manilaclient stable/yoga: Add FIPS testing jobs https://review.opendev.org/c/openstack/python-manilaclient/+/848114 | 20:26 |
opendevreview | Ashley Rodriguez proposed openstack/manila master: Metadata for Share Snapshots Resource https://review.opendev.org/c/openstack/manila/+/825008 | 20:39 |
opendevreview | Ashley Rodriguez proposed openstack/manila master: Metadata for Share Snapshots Resource https://review.opendev.org/c/openstack/manila/+/825008 | 21:07 |
opendevreview | Victoria Martinez de la Cruz proposed openstack/manila master: Refactor the Ceph NFS driver to use Cephadm NFS https://review.opendev.org/c/openstack/manila/+/848987 | 22:19 |
*** dviroel|afk is now known as dviroel | 23:12 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!