| opendevreview | Merged openstack/manila master: early return for _share_replica_update() if there is no active replica https://review.opendev.org/c/openstack/manila/+/786658 | 00:09 |
|---|---|---|
| *** dviroel is now known as dviroel|out | 02:53 | |
| opendevreview | Merged openstack/manila stable/ussuri: init_host should be called before RPC consumer is created https://review.opendev.org/c/openstack/manila/+/802780 | 04:19 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/train: init_host should be called before RPC consumer is created https://review.opendev.org/c/openstack/manila/+/821172 | 07:55 |
| opendevreview | haixin proposed openstack/manila master: remove usage of six library in driver layer and the corresponding test https://review.opendev.org/c/openstack/manila/+/821162 | 08:22 |
| opendevreview | haixin proposed openstack/manila master: remove usage of six library in api layer https://review.opendev.org/c/openstack/manila/+/756450 | 08:48 |
| opendevreview | haixin proposed openstack/manila-tempest-plugin master: Remove all usage of six library https://review.opendev.org/c/openstack/manila-tempest-plugin/+/755183 | 08:51 |
| opendevreview | haixin proposed openstack/manila master: remove usage of six library https://review.opendev.org/c/openstack/manila/+/756991 | 08:54 |
| opendevreview | haixin proposed openstack/manila master: remove usage of six library in driver layer and the corresponding test https://review.opendev.org/c/openstack/manila/+/821162 | 09:04 |
| opendevreview | haixin proposed openstack/manila master: remove usage of six library in driver layer and the corresponding test https://review.opendev.org/c/openstack/manila/+/821162 | 09:07 |
| *** dviroel|out is now known as dviroel | 10:49 | |
| opendevreview | Felipe Rodrigues proposed openstack/manila-specs master: WIP: Add spec for multiple subnet share servers https://review.opendev.org/c/openstack/manila-specs/+/619925 | 15:09 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/python-manilaclient master: Fix the id attr for share group type access repr https://review.opendev.org/c/openstack/python-manilaclient/+/821110 | 15:29 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/python-manilaclient master: Fix the id attr for share group type access repr https://review.opendev.org/c/openstack/python-manilaclient/+/821110 | 15:32 |
| gouthamr | fabiooliveira vhari: yoga-2 to start with? if it takes longer, we can kick it down to yoga-3 | 16:02 |
| gouthamr | wdyt? | 16:02 |
| vhari | gouthamr, sounds reasonable | 16:03 |
| fabiooliveira | gouthamr, fine by me | 16:03 |
| ganso | felipe_rodrigues, sfernand : I believe this patch is complementary to your spec: https://review.opendev.org/c/openstack/manila-specs/+/619925 | 16:54 |
| ganso | it was written with that in mind | 16:54 |
| ganso | nvm I said that before opening the link, didn't realize it was the same one | 17:07 |
| ganso | Jiabo_, megharth: congratulations! | 17:11 |
| ganso | rishabhdutta, tutkuna as well ^ | 17:11 |
| megharth | Thank you so much ganso | 17:12 |
| Jiabo_ | Thank you so much! | 17:15 |
| sfernand | ganso: hi ganso, we are using your spec as reference and it is really full of details! Thanks for that :) We would like to focus on a specific use case tho. The idea is to initially add support for including more IPv4 subnets in a same network segment to a existing share network | 17:18 |
| sfernand | but I don't know if we can partially implement a spec :P | 17:19 |
| ganso | sfernand: thanks! +1 for incremental approach | 17:19 |
| sfernand | cool! | 17:19 |
| ganso | sfernand: you can split the spec work into several cycles and work items, this has been done before | 17:19 |
| sfernand | so we can split yours in several smaller ones | 17:19 |
| sfernand | ganso: cool! | 17:20 |
| ganso | sfernand: well I think it would be best to split the work (implementation), not the spec, because at least the design of the feature is something that it is important to be able to see the whole picture | 17:20 |
| sfernand | that is a good point | 17:21 |
| ganso | sfernand: unless it gets too complex, then maybe small specs accompanying each small work item to make it easier to review and understand, but still the big picture design is important to have | 17:22 |
| ganso | this is exactly why we need that WIP spec in the past, to merge https://review.opendev.org/c/openstack/manila-specs/+/615947 | 17:24 |
| sfernand | ganso: yes, make sense and I'm totally ok with that. would like to know gouthamr opinion as well | 17:24 |
| ganso | because we needed to see the big picture. In fact, that older one partially-implements the blueprint | 17:24 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/manila master: Support group specs search for share group type API https://review.opendev.org/c/openstack/manila/+/821002 | 17:24 |
| sfernand | my only concern is if we have time to merge the entire spec until the end of next week. | 17:25 |
| sfernand | may be split the specific use case only if we need a plan B | 17:25 |
| sfernand | more close to the end of next week | 17:25 |
| ganso | actually this is the original one: https://review.opendev.org/c/openstack/manila-specs/+/323646 | 17:27 |
| ganso | sfernand: it goes waaaaaaaaaay back | 17:28 |
| ganso | sfernand: that a look at those 2 above if you haven't, maybe what you need is already in there | 17:28 |
| ganso | indeed, that feature is huuuge, so many specs | 17:29 |
| ganso | sfernand: yea maybe you will need to have a lite spec for a small piece of work you intend to get merged in Yoga. Then my spec will still remain WIP for the next cycles when it is expected the feature will be completed | 17:30 |
| ganso | s/that a look/take a look | 17:31 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: DNM - Add temporary link to patched paramiko https://review.opendev.org/c/openstack/manila/+/819375 | 17:32 |
| sfernand | ganso: yes I believe so. We would have more chances to have something approved for next week with a lite spec. | 17:41 |
| gouthamr | sfernand: shoot for it, but i'm assuming we'll have dwindling review attention going into next week | 17:43 |
| gouthamr | sfernand: i wanted to keep the deadline for submissions, but if folks need more time to review and ask questions, i'm okay letting them merge beyond next week | 17:43 |
| gouthamr | sfernand felipe_rodrigues: agree with ganso that we could look at this better with the whole picture in mind - we have a "release_independent" folder in the specs that we use to track multi-release features | 17:44 |
| gouthamr | feel free to edit add release specific targets in the same spec or break it out - i'm okay with both approaches, as you start editing the spec maybe you'll find a preference | 17:45 |
| felipe_rodrigues | nice gouthamr! We just need to address again the point that you pointed during PTG | 17:47 |
| felipe_rodrigues | Our customer is running our of IPs, they want to add more subnets to the share network (same brodcast domain).. you have mentioned that it could have a bad user experience (different from Nova), if one of sub fails and other works... In fact, we tested with Nova and it seems that the behaviour is what we want... If two subnets are attached to a network, the nova just gets from one subnet, and only when it is | 17:51 |
| felipe_rodrigues | full, it starts getting from other... Exactly what we want right now to solve the lack of IPs using same segmentation! | 17:51 |
| felipe_rodrigues | Can we proceed with this approach ? | 17:51 |
| gouthamr | ah I see; good to know - do add notes regarding your findings about nova in the spec felipe_rodrigues | 17:56 |
| felipe_rodrigues | nice, I'll do it! thank you | 17:59 |
| sfernand | gouthamr: thanks gouthamr we shall have something written and proposed for the beginning of next week. | 18:29 |
| gouthamr | ++ | 18:46 |
| EmilienM | hello there, have you seen this error when doing a dbsync on stable/victoria? https://paste.opendev.org/show/811587/ cc gouthamr tbarron vkmc | 19:16 |
| gouthamr | strange and nope, EmilienM | 19:18 |
| gouthamr | what version of oslo_policy is getting installed? | 19:19 |
| EmilienM | gouthamr: I have `2021-12-09T19:10:32.2331355Z ERROR: manila 13.1.0.dev55 has requirement oslo.policy>=3.7.0, but you'll have oslo-policy 3.5.0 which is incompatible.` | 19:20 |
| EmilienM | seems like the reason. Note; I'm running that manually; so somehow it's pulling a wrong dependency? | 19:21 |
| gouthamr | yep we need 3.7.0 with this commit: https://github.com/openstack/oslo.policy/commit/16840b6a3f85a070a8f600b09db580c5ccd215a0 | 19:22 |
| EmilienM | would it be a bug in requirements? /me checking | 19:22 |
| gouthamr | :( https://github.com/openstack/manila/blob/deaa1bf16ac1ac6f77220b8f08759d7b262e8305/requirements.txt#L20 --- we didn't bump the minimum requirement here - that's probably what's tripping it up? | 19:23 |
| EmilienM | oslo.policy===3.5.0 in upper-constraints.txt | 19:23 |
| EmilienM | gouthamr: very likely | 19:24 |
| EmilienM | I'll submit a patch? | 19:24 |
| gouthamr | EmilienM: the code that i'm seeing in the paste doesn't look like its from stable/victoria | 19:25 |
| EmilienM | oh yeah? | 19:25 |
| EmilienM | that's interesting. | 19:25 |
| * gouthamr is still looking | 19:25 | |
| gouthamr | yeah we did the "DEPRECATED_CONTEXT_IS_ADMIN" only in wallaby | 19:26 |
| gouthamr | https://github.com/openstack/manila/commit/02cc5c6760a294d49f70751bbaed574bf74f7068 | 19:26 |
| gouthamr | ^ so did you perhaps get manila from a later branch on your devstack? | 19:27 |
| EmilienM | oh ok, so I probably missed something on my side | 19:29 |
| EmilienM | gouthamr: I'll have a look and let you know. Thanks | 19:29 |
| EmilienM | I did, git checkout stable/victoria on devstack | 19:29 |
| EmilienM | and did enable_plugin manila https://opendev.org/openstack/manila | 19:29 |
| EmilienM | I guess I missed the branch at the end | 19:29 |
| EmilienM | :/ | 19:29 |
| gouthamr | yes, likely need to add that manually - we don't do it in the gate because zuul preps the environment by cloning the correct branch | 19:30 |
| gouthamr | "enable_plugin manila https://opendev.org/openstack/manila stable/victoria" should do the trick | 19:30 |
| EmilienM | ok | 19:30 |
| EmilienM | thx | 19:30 |
| gouthamr | you're welcome! | 19:30 |
| carloss | o/ folks | 19:43 |
| carloss | as mentioned earlier today in the manila meeting, we need some help with reviews in some changes from our etherpad: https://etherpad.opendev.org/p/manila-yoga-review-focus | 19:44 |
| carloss | the first item on the list that doesn't have reviewers assigned is: Move Metadata Spec from Wallaby to Yoga | https://review.opendev.org/c/openstack/manila-specs/+/814678 | 19:45 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add a stable/xena job and drop the stable/ussuri job https://review.opendev.org/c/openstack/manila-tempest-plugin/+/821280 | 19:46 |
| carloss | we need some eyes on this specification :) | 19:47 |
| carloss | I can be one of the reviewers for this | 19:47 |
| * carloss adds himself to the list of reviewers | 19:47 | |
| gouthamr | haixin said he'd take a look, i'd tack vkmc and myself as well - more eyes the better for specs | 19:47 |
| * gouthamr is only useful for +/-1 here since he collaborated | 19:48 | |
| EmilienM | gouthamr: that worked! thx and sorry for noise | 19:48 |
| gouthamr | no problem EmilienM! glad you asked! :) | 19:48 |
| carloss | awesome | 19:48 |
| carloss | next up: Set service specific rpc control_exchange defaults | https://review.opendev.org/c/openstack/manila/+/820197 | 19:49 |
| carloss | I see we had gouthamr's eyes there :) | 19:50 |
| gouthamr | yeah, i can review this one - although i will defer to oslo/deployment folks regarding upgrade impact | 19:51 |
| gouthamr | will add folks there | 19:51 |
| gouthamr | need manila reviewers though - perhaps felipe_rodrigues? | 19:52 |
| carloss | :) | 19:52 |
| felipe_rodrigues | add me | 19:53 |
| felipe_rodrigues | :) | 19:53 |
| carloss | thanks felipe_rodrigues | 19:53 |
| carloss | next on the list: Fix ignored [neutron] options | https://review.opendev.org/c/openstack/manila/+/813831 | 19:54 |
| carloss | this has been up for some time now | 19:54 |
| carloss | I can be one of the reviewers for this | 19:55 |
| carloss | but we need more folks to review this change | 19:55 |
| felipe_rodrigues | add me carloss, I can help | 19:57 |
| carloss | great, thanks felipe_rodrigues! | 19:58 |
| carloss | next up is NetApp OnTap: Fix compatibility check for share migrate | https://review.opendev.org/c/openstack/manila/+/820891 | 20:00 |
| gouthamr | felipe_rodrigues++ | 20:00 |
| carloss | I see we had gouthamr's eyes there (thanks!) | 20:00 |
| carloss | we need more eyes on this too | 20:00 |
| gouthamr | this options change looks good - i added my review and triaged the bug | 20:00 |
| carloss | I can be one of them and would be nice to have another netapper on the reviewers list :) | 20:00 |
| gouthamr | carloss: i like the current solution, i think it solves the bug effectively - allowing us at RHAT to keep our old netapp box blissfully on 9.0 | 20:02 |
| felipe_rodrigues | nahimsouza, would you mind to review it for us ? | 20:03 |
| nahimsouza[m] | sure, i can review | 20:04 |
| felipe_rodrigues | thank you! :) | 20:04 |
| carloss | > carloss: i like the current solution, i think it solves the bug effectively - allowing us at RHAT to keep our old netapp box blissfully on 9.0 | 20:04 |
| carloss | yes, sounds like a nice way to solve it | 20:04 |
| carloss | nahimsouza[m]++ | 20:04 |
| carloss | :) | 20:04 |
| carloss | next: [OSC] Add missing waiters | https://review.opendev.org/c/openstack/python-manilaclient/+/788060 | 20:06 |
| carloss | I see we had gouthamr reviewing this... would be nice to have some more eyes | 20:07 |
| gouthamr | i reviewed its predecessors i think | 20:07 |
| felipe_rodrigues | add me carloss | 20:08 |
| gouthamr | help us, fabiooliveira - you're our only hope | 20:08 |
| gouthamr | :P | 20:08 |
| gouthamr | kidding, felipe_rodrigues is in a good ROPC mood today | 20:08 |
| gouthamr | ROPC = reading other peoples' code :) | 20:08 |
| carloss | xD | 20:08 |
| carloss | I like that | 20:08 |
| fabiooliveira | i can help | 20:09 |
| felipe_rodrigues | yeah, I have no plans for weekend, that's the reason rs | 20:09 |
| felipe_rodrigues | fabiooliveira ++ | 20:09 |
| carloss | next one, related to the recycle bin changes from haixin :) | 20:10 |
| carloss | Manila client suppot recycle bin https://review.opendev.org/c/openstack/python-manilaclient/+/801424 | 20:10 |
| carloss | I can be another reviewer for this, but couple more of eyes are appreciated | 20:10 |
| carloss | I see gouthamr has already looked at it in the past too D: | 20:10 |
| carloss | :D * | 20:10 |
| gouthamr | yep | 20:10 |
| gouthamr | i'm reading through the server patch now | 20:11 |
| carloss | our robot doesn't lose track of anything xD | 20:11 |
| carloss | gouthamr++ :) | 20:11 |
| fabiooliveira | I can take a look also :D | 20:12 |
| carloss | awesome | 20:12 |
| * carloss double checks the list to see if he didn't forget anything | 20:13 | |
| gouthamr | the world thinks today what haixin thought yesterday: https://aws.amazon.com/blogs/aws/new-recycle-bin-for-ebs-snapshots/ | 20:13 |
| carloss | xD | 20:13 |
| carloss | i *think* we covered all the changes pending reviewers | 20:16 |
| carloss | unless someone wants to bring up a change :) | 20:17 |
| gouthamr | fabiooliveira++, i think dviroel had also looked at the recycle bin feature changes | 20:17 |
| gouthamr | carloss++ thanks for rounding these up | 20:18 |
| carloss | my pleasure gouthamr | 20:18 |
| opendevreview | Carlos Eduardo proposed openstack/manila stable/xena: Update admin, user and contributor guide https://review.opendev.org/c/openstack/manila/+/821258 | 20:22 |
| opendevreview | Ashley Rodriguez proposed openstack/manila master: Add admin only keys to share metadata https://review.opendev.org/c/openstack/manila/+/806647 | 20:48 |
| *** dviroel is now known as dviroel|out | 21:13 | |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add a stable/xena job and drop the stable/ussuri job https://review.opendev.org/c/openstack/manila-tempest-plugin/+/821280 | 23:10 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!