opendevreview | Takashi Kajinami proposed openstack/puppet-manila master: Support Puppet 7 https://review.opendev.org/c/openstack/puppet-manila/+/804628 | 09:05 |
---|---|---|
opendevreview | Merged openstack/puppet-manila master: Support Puppet 7 https://review.opendev.org/c/openstack/puppet-manila/+/804628 | 10:13 |
kinpaa12389 | Hi, | 11:11 |
kinpaa12389 | what is correct way to mention dependency for change in manila and manila-tempest-plugin. I see failure in PR, https://review.opendev.org/c/openstack/manila-tempest-plugin/+/804589 and same failures in manila for PR https://review.opendev.org/c/openstack/manila/+/804578 | 11:12 |
vkmc | kinpaa12389, hi, with the full url | 11:13 |
vkmc | Depends-On: https://review.opendev.org/c/openstack/manila/+/804578 | 11:14 |
vkmc | in the commit message for https://review.opendev.org/c/openstack/manila-tempest-plugin/+/804589 | 11:14 |
*** dviroel|out is now known as dviroel|ruck | 11:26 | |
kinpaa12389 | vmkc, so manila-tempest-plugin(1) will have reference of manila, but what about manila PR, zuul execute tempest-plugin tests there too and it might consider master instead of (1). | 11:29 |
vkmc | kinpaa12389, so I believe what you are trying to do is not possible | 12:40 |
vkmc | perhaps what you want to do is to get the manila change first, and then get the manila-tempest-plugin change | 12:41 |
vkmc | having the depends-on from manila-tempest to manila change allows you to test your manila change with the tempest test you added | 12:41 |
vkmc | so presumably it is working as expected | 12:41 |
vkmc | but I might be wrong | 12:41 |
vkmc | you can ask in #openstack-infra for more details on how dependencies work | 12:42 |
opendevreview | kiran pawar proposed openstack/manila master: Add "share-network" option for replica create API. https://review.opendev.org/c/openstack/manila/+/804578 | 13:11 |
opendevreview | kiran pawar proposed openstack/python-manilaclient master: Update share replica create CLI https://review.opendev.org/c/openstack/python-manilaclient/+/804579 | 13:11 |
opendevreview | kiran pawar proposed openstack/manila-tempest-plugin master: Update tests for share replica create https://review.opendev.org/c/openstack/manila-tempest-plugin/+/804589 | 14:11 |
kinpaa12389 | vmkc, I have update PRs, can you please check ? | 15:13 |
vkmc | kinpaa12389, sure | 15:30 |
opendevreview | kiran pawar proposed openstack/manila-tempest-plugin master: Update tests for share replica create https://review.opendev.org/c/openstack/manila-tempest-plugin/+/804589 | 16:07 |
*** dviroel|ruck is now known as dviroel|out | 17:49 | |
opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/ussuri: Filter shares by share type "extra_specs" https://review.opendev.org/c/openstack/manila/+/804724 | 17:55 |
opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/ussuri: TrivialFix: Fix the filter name in config helper https://review.opendev.org/c/openstack/manila/+/804725 | 17:56 |
opendevreview | Merged openstack/manila stable/victoria: Filter shares by share type "extra_specs" https://review.opendev.org/c/openstack/manila/+/799915 | 19:05 |
opendevreview | Merged openstack/manila stable/victoria: TrivialFix: Fix the filter name in config helper https://review.opendev.org/c/openstack/manila/+/799250 | 19:13 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!