| opendevreview | Archana Kumari proposed openstack/manila master: Replace assertDictMatch with assertDictEqual method in tests https://review.opendev.org/c/openstack/manila/+/795990 | 09:00 |
|---|---|---|
| opendevreview | Victoria Martinez de la Cruz proposed openstack/manila master: Add Ceph version check https://review.opendev.org/c/openstack/manila/+/794275 | 10:33 |
| opendevreview | zhangboye proposed openstack/manila master: test_git_review https://review.opendev.org/c/openstack/manila/+/797274 | 10:37 |
| opendevreview | zhangboye proposed openstack/manila master: test_git_review https://review.opendev.org/c/openstack/manila/+/797277 | 10:46 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/python-manilaclient master: [DNM] Baseline testing https://review.opendev.org/c/openstack/python-manilaclient/+/797278 | 10:47 |
| opendevreview | Merged openstack/manila-ui stable/wallaby: Fix parsing names in switched fields https://review.opendev.org/c/openstack/manila-ui/+/797105 | 13:01 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/manila master: Add Ceph version check https://review.opendev.org/c/openstack/manila/+/794275 | 13:19 |
| opendevreview | Kafilat Adeleke proposed openstack/manila master: Filter shares by share type "extra_specs" https://review.opendev.org/c/openstack/manila/+/795256 | 16:43 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Add CentOS8 Stream support https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/797124 | 17:55 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Fix class inheritances in base.py https://review.opendev.org/c/openstack/manila-tempest-plugin/+/794977 | 18:14 |
| opendevreview | Vida Haririan proposed openstack/manila stable/train: [DNM] https://review.opendev.org/c/openstack/manila/+/797302 | 18:51 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add stable branch jobs on the plugins master gate https://review.opendev.org/c/openstack/manila-tempest-plugin/+/725692 | 18:59 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-ui master: [CI] Temporarily set integration test job to non-voting https://review.opendev.org/c/openstack/manila-ui/+/797347 | 19:10 |
| gouthamr | vkmc carloss: ^ pushed this up while we take time to investigate what's causing the timeout in the manila-ui test job | 19:15 |
| gouthamr | would like your review when you get a chance :) | 19:15 |
| gouthamr | thanks! | 19:15 |
| opendevreview | Simon Dodsley proposed openstack/manila master: Add Pure Storage FlashBlade driver https://review.opendev.org/c/openstack/manila/+/789384 | 19:21 |
| simondodsley | Need some advice... My unit test code is failing pep8 as a few lines are over 79 characters, but I know of no way to shorten these. Any ideas would be appreciated - the review is https://review.opendev.org/c/openstack/manila/+/789384 and has just failed the tox pep8 in Zuul | 19:38 |
| simondodsley | These are the pep8 failures https://www.irccloud.com/pastebin/s4d3nwy9/ | 19:39 |
| JayF | I'll note I'm not a manila contributor generally, but do work on other OpenStack projects. You can likely shorten some of those lines (e.g. self._sys.file_system_snapshots.delete_file_system_snapshots.assert_called_once_with()) by putting a \ before one of the periods and putting it on a new line. You can also use "#noqa RULE123" at the end of a line to exclude it from | 19:41 |
| JayF | failures for RULE123. Most communities will prefer you make it pass pep8 without a noqa. | 19:41 |
| simondodsley | JayF: Thanks - I'll give the \ a try | 19:42 |
| JayF | Good luck! If you're down to pep8 failures as your only barrier, you've gotta be close! | 19:42 |
| gouthamr | JayF++ | 19:57 |
| opendevreview | Simon Dodsley proposed openstack/manila master: Add Pure Storage FlashBlade driver https://review.opendev.org/c/openstack/manila/+/789384 | 19:57 |
| opendevreview | Simon Dodsley proposed openstack/manila master: Add Pure Storage FlashBlade driver https://review.opendev.org/c/openstack/manila/+/789384 | 20:28 |
| opendevreview | Merged openstack/manila-ui master: Fix parsing names in switched fields https://review.opendev.org/c/openstack/manila-ui/+/796384 | 20:36 |
| opendevreview | Simon Dodsley proposed openstack/manila master: Add Pure Storage FlashBlade driver https://review.opendev.org/c/openstack/manila/+/789384 | 20:40 |
| opendevreview | Merged openstack/devstack-plugin-ceph master: Add CentOS8 Stream support https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/797124 | 20:56 |
| *** dviroel is now known as dviroel|out | 21:39 | |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-ui master: Fix share group creation with share types https://review.opendev.org/c/openstack/manila-ui/+/797354 | 21:59 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-ui master: Fix share group creation with share types https://review.opendev.org/c/openstack/manila-ui/+/797354 | 22:01 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-ui master: Fix share group creation with share types https://review.opendev.org/c/openstack/manila-ui/+/797354 | 23:12 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!