| carloss | hey, gouthamr... I was still curious about the thing we just talked, and I remembered I haven't seen any database migration for share_group quotas and in the share_network quotas implementation... | 00:14 |
|---|---|---|
| carloss | then, after further investigations I found out what was happening | 00:15 |
| gouthamr | carloss: yeah this one is special, because we didn't introduce quotas along with the resources | 00:15 |
| carloss | I think it was my mistake, and here is why: | 00:16 |
| gouthamr | ... | 00:16 |
| carloss | when we ask manila to reserve some quota for a given resource, the quota system will call a function in the db to reserve the quotas. Then if a quota usage record with that resource name is not yet created, a new record is going to be created in the db | 00:16 |
| carloss | otherwise it will not be created and a sync with the existing resources is not going to be performed | 00:17 |
| carloss | when creating this new record, manila checks of there is need to refresh - https://github.com/openstack/manila/blob/3be50ced7a57ab84fcc2b65c52213d339424ec17/manila/db/sqlalchemy/api.py#L994 | 00:17 |
| carloss | If so, it will call the _sync_usages function for a given resource, _sync_replica_gigabytes, for example. If this query is executed, the usages for the resource are going to be updated and the resources are going to be synchronized according to the current usages | 00:17 |
| carloss | Here is my mistake: I have tested this patch in my env some days ago, then I worked in another branch and then went back to the quota tests. | 00:18 |
| carloss | When I applied the patch again, the records for 'share_replicas' and 'replica_gigabytes' were already created in my db, so they were not being synchronized :) | 00:19 |
| carloss | then, if you get an environment that never had the quotas for share replicas before, it will work just fine | 00:19 |
| carloss | i've performed tests again to confirm this behavior. I've deleted all the entries for that spcific quota_usages in my database, so I was able to simulate an environment that neved had quotas for share replicas before | 00:21 |
| gouthamr | oh, nice - so you had quotas, and then for a brief period didn't, and created stuff, and now you have them again? | 00:21 |
| carloss | yep... basically because I used a single environment to test different changes | 00:23 |
| gouthamr | cool, i was thinking we were persisting usage in the db (which i think cinder currently does) | 00:23 |
| gouthamr | and had no refresh mechanism, but this makes sense | 00:24 |
| carloss | yep. my mistake :p | 00:24 |
| carloss | sry | 00:25 |
| dviroel | awesome! | 00:39 |
| openstackgerrit | Merged openstack/manila master: Increase MANILA_SERVICE_VM_FLAVOR_DISK https://review.opendev.org/717104 | 00:41 |
| dviroel | oh, great! | 00:41 |
| carloss | :) | 00:42 |
| openstackgerrit | Douglas Viroel proposed openstack/manila master: [NetApp] Improve create share from snapshot functionality https://review.opendev.org/712642 | 00:42 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila stable/train: Increase MANILA_SERVICE_VM_FLAVOR_DISK https://review.opendev.org/717159 | 00:55 |
| openstackgerrit | haixin proposed openstack/manila-tempest-plugin master: Add function to test user messages query by timestamp https://review.opendev.org/716848 | 01:58 |
| openstackgerrit | Merged openstack/manila master: Hacking: Fix E731 https://review.opendev.org/716563 | 03:34 |
| openstackgerrit | haixin proposed openstack/manila-tempest-plugin master: Add function to test user messages query by timestamp https://review.opendev.org/716848 | 03:45 |
| openstackgerrit | Merged openstack/manila-specs master: the message-list command now support filter since and before. https://review.opendev.org/716467 | 04:32 |
| *** brinzhang has joined #openstack-manila | 05:16 | |
| *** brinzhang_ has quit IRC | 05:16 | |
| openstackgerrit | Merged openstack/manila master: Hacking: Fix W605 https://review.opendev.org/716573 | 05:39 |
| openstackgerrit | haixin proposed openstack/manila-tempest-plugin master: Add function to test user messages query by timestamp https://review.opendev.org/716848 | 05:41 |
| *** maaritamm has joined #openstack-manila | 05:51 | |
| *** haixin has joined #openstack-manila | 05:52 | |
| *** haixin_inspur has joined #openstack-manila | 05:56 | |
| *** haixin has quit IRC | 05:58 | |
| openstackgerrit | Merged openstack/manila-tempest-plugin master: Update hacking for Python3 https://review.opendev.org/716559 | 07:13 |
| *** brinzhang_ has joined #openstack-manila | 07:17 | |
| *** haixin__ has joined #openstack-manila | 07:18 | |
| *** brinzhang has quit IRC | 07:21 | |
| *** haixin_inspur has quit IRC | 07:21 | |
| *** maaritamm has quit IRC | 07:34 | |
| *** tosky has joined #openstack-manila | 07:44 | |
| *** brinzhang has joined #openstack-manila | 08:33 | |
| *** haixin_inspur has joined #openstack-manila | 08:33 | |
| *** brinzhang_ has quit IRC | 08:36 | |
| *** haixin__ has quit IRC | 08:36 | |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-manila stable/train: Fix rabbitmq dependency https://review.opendev.org/717247 | 08:37 |
| openstackgerrit | Takashi Kajinami proposed openstack/puppet-manila stable/stein: Fix rabbitmq dependency https://review.opendev.org/717248 | 08:38 |
| *** maaritamm has joined #openstack-manila | 08:42 | |
| *** rmart04 has joined #openstack-manila | 08:49 | |
| *** haixin__ has joined #openstack-manila | 08:49 | |
| *** haixin_inspur has quit IRC | 08:52 | |
| *** maaritamm has quit IRC | 09:05 | |
| *** maaritamm has joined #openstack-manila | 09:06 | |
| *** haixin_inspur has joined #openstack-manila | 09:23 | |
| *** haixin__ has quit IRC | 09:26 | |
| *** haixin__ has joined #openstack-manila | 09:38 | |
| *** haixin_inspur has quit IRC | 09:41 | |
| *** maaritamm has quit IRC | 10:00 | |
| *** maaritamm has joined #openstack-manila | 10:06 | |
| *** brinzhang has quit IRC | 10:09 | |
| *** haixin__ has quit IRC | 10:19 | |
| *** maaritamm has quit IRC | 10:31 | |
| *** maaritamm has joined #openstack-manila | 10:48 | |
| *** andrebeltrami has joined #openstack-manila | 12:48 | |
| *** zigo has quit IRC | 12:48 | |
| *** zigo has joined #openstack-manila | 12:51 | |
| *** maaritamm has quit IRC | 13:11 | |
| *** maaritamm has joined #openstack-manila | 13:13 | |
| *** maaritamm has quit IRC | 13:55 | |
| *** maaritamm has joined #openstack-manila | 14:13 | |
| openstackgerrit | Merged openstack/puppet-manila stable/stein: Fix rabbitmq dependency https://review.opendev.org/717248 | 14:20 |
| openstackgerrit | Merged openstack/puppet-manila stable/train: Fix rabbitmq dependency https://review.opendev.org/717247 | 14:27 |
| openstackgerrit | Merged openstack/manila master: Revert "Remove provisioned calculation on non thin provision backends" https://review.opendev.org/716683 | 14:37 |
| *** maaritamm has quit IRC | 15:18 | |
| *** maaritamm has joined #openstack-manila | 15:28 | |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-ui master: Use unittest.mock instead of third party mock https://review.opendev.org/717325 | 15:40 |
| *** maaritamm has quit IRC | 16:10 | |
| *** maaritamm has joined #openstack-manila | 16:18 | |
| *** maaritamm has quit IRC | 16:32 | |
| openstackgerrit | Douglas Viroel proposed openstack/manila master: [NetApp] Improve create share from snapshot functionality https://review.opendev.org/712642 | 16:44 |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-ui master: Use unittest.mock instead of third party mock https://review.opendev.org/717325 | 17:48 |
| openstackgerrit | Merged openstack/manila master: Support query user message by timestamp https://review.opendev.org/706438 | 18:11 |
| *** maaritamm has joined #openstack-manila | 18:19 | |
| *** rmart04 has quit IRC | 18:38 | |
| dviroel | hey gouthamr | 19:03 |
| gouthamr | dviroel: sup | 19:04 |
| dviroel | gouthamr: what do you think of updating the features changes with the following microversion: quotas 2.53 and create share from snap another pool to 2.54 | 19:04 |
| gouthamr | dviroel: sure, good idea, are there no other code conflicts? | 19:05 |
| dviroel | a few I think, messages for example. easy to deal it | 19:05 |
| dviroel | gouthamr: the idea is to merge quotas first, do you agree them | 19:06 |
| dviroel | then | 19:07 |
| dviroel | quotas has less dependencies than the other patches.. | 19:07 |
| gouthamr | dviroel: yeah, i've no issue with it | 19:10 |
| dviroel | gouthamr: ack, ty | 19:10 |
| dviroel | carloss: 2.53 for you :) | 19:10 |
| carloss | ack. ty dviroel gouth | 19:11 |
| *** maaritamm has quit IRC | 19:17 | |
| *** maaritamm has joined #openstack-manila | 19:19 | |
| * carloss realizes now that the autocomplete haven't worked :p | 19:22 | |
| *** maaritamm has quit IRC | 19:36 | |
| *** maaritamm has joined #openstack-manila | 19:40 | |
| openstackgerrit | Merged openstack/python-manilaclient master: Support query user message by timestamp https://review.opendev.org/708807 | 20:37 |
| openstackgerrit | Douglas Viroel proposed openstack/manila master: Create share from snapshot in another pool or backend https://review.opendev.org/709697 | 20:47 |
| gouthamr | tbarron: hey, how about constraining the version of manila tempest plugin in older python 2 jobs? | 21:05 |
| gouthamr | tbarron: something else that's python3 specific could potentially break next, no? | 21:05 |
| openstackgerrit | Douglas Viroel proposed openstack/manila master: [NetApp] Improve create share from snapshot functionality https://review.opendev.org/712642 | 21:07 |
| tbarron | we could but I think we should also/first fix the test-requirement for hacking to by py3 specific | 21:07 |
| tbarron | requires less philosopy than constraining tempest to a tag b/c it's branchless, etc. | 21:08 |
| gouthamr | tbarron: hmmm, yeah either fix will work, but, we specifically created a tag for python2 | 21:09 |
| gouthamr | or we didn't for manila-tempest-plugin | 21:13 |
| openstackgerrit | Tom Barron proposed openstack/manila-tempest-plugin master: Fix hacking test requirement https://review.opendev.org/717395 | 21:13 |
| tbarron | gouthamr: I don't object to the approach you are advocating (if we find or make a tag). | 21:14 |
| tbarron | maybe some tempest purists would? | 21:14 |
| tbarron | But the proposed fix ^^^ would not be incompatible with it, and this one should be quick. | 21:15 |
| gouthamr | tbarron: figured that was the route when i was exploring the neutron-tempest-plugin issue | 21:15 |
| tbarron | gouthamr: we might as well just branch the plugin :D then, wouldn't really break anything, right? | 21:16 |
| tbarron | a tag is like a branch that never grows | 21:16 |
| gouthamr | tbarron: sigh, we need a drink | 21:16 |
| tbarron | morphine | 21:16 |
| gouthamr | lol | 21:17 |
| vkmc | o.o | 21:17 |
| * vkmc sends coffee | 21:17 | |
| tbarron | shouldn't have said, that, I might summon carlos' tramydol friend | 21:17 |
| dviroel | lol | 21:18 |
| gouthamr | not irc police, but carloss has a friend that sells tramadol? | 21:19 |
| vkmc | aahaha | 21:19 |
| carloss | lol | 21:19 |
| vkmc | I remember that | 21:19 |
| vkmc | the tramadol guy even reported a bug in manila | 21:19 |
| gouthamr | manila can serve your pharmacy needs | 21:20 |
| vkmc | well, commented in a reported bug | 21:20 |
| vkmc | xD | 21:20 |
| carloss | haha | 21:21 |
| vkmc | do you want storage? or you mean... drugs? | 21:21 |
| carloss | that bug modifications/comments were completely unexpected | 21:21 |
| tbarron | we kept fixing this bug carloss owned, but the t-guy kept changing it into an advertisement for his wares | 21:26 |
| carloss | found the bug link, tbarron :p | 21:29 |
| carloss | https://bugs.launchpad.net/manila/+bug/1820118 | 21:29 |
| openstack | Launchpad bug 1820118 in Manila "Manila unexpectedly attempts to delete a share server when deleting a share network" [Medium,Fix released] - Assigned to Carlos Eduardo (silvacarlose) | 21:29 |
| gouthamr | good times | 21:29 |
| tbarron | carloss: seems like yesterday | 21:30 |
| carloss | yes, tbarron... time flies | 21:31 |
| vkmc | hahaha | 21:31 |
| tbarron | gouthamr: i had a merge conflict and chose the wrong combo, sec | 21:32 |
| tbarron | gouthamr: mordred was suggesting just skipping the hacking requirement when python < 3, just | 21:35 |
| tbarron | omitting that line | 21:36 |
| gouthamr | tbarron: oh | 21:36 |
| tbarron | I'm gonna post it that way but if you want to do that we can | 21:36 |
| gouthamr | tbarron: no you're right, we don't run pep8 jobs | 21:36 |
| tbarron | s/I'm gonna/I was going to/ | 21:36 |
| gouthamr | tbarron: so its okay to skip it since we won't test manila-tempest-plugin itself with py2 linters | 21:37 |
| gouthamr | or in a py2 env | 21:37 |
| tbarron | do you prefer ">'3'" or ">='3'" ? | 21:37 |
| tbarron | we wont run with exactly 3 | 21:37 |
| gouthamr | true, >3 would do i think | 21:37 |
| tbarron | kk | 21:38 |
| openstackgerrit | Tom Barron proposed openstack/manila-tempest-plugin master: Fix hacking test requirement https://review.opendev.org/717395 | 21:38 |
| tbarron | lets see what I can mangle this time | 21:38 |
| tbarron | there is no python vesion | 21:38 |
| tbarron | dviroel: ty, sec | 21:39 |
| openstackgerrit | Tom Barron proposed openstack/manila-tempest-plugin master: Fix hacking test requirement https://review.opendev.org/717395 | 21:41 |
| dviroel | :) | 21:43 |
| *** maaritamm has quit IRC | 22:07 | |
| openstackgerrit | Merged openstack/manila-tempest-plugin master: Fix hacking test requirement https://review.opendev.org/717395 | 22:23 |
| *** andrebeltrami has quit IRC | 22:57 | |
| *** tosky has quit IRC | 23:16 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!