| *** enriquetaso has joined #openstack-manila | 00:44 | |
| openstackgerrit | haixin proposed openstack/manila-tempest-plugin master: Add update share type functional tests https://review.opendev.org/674230 | 00:55 |
|---|---|---|
| *** enriquetaso has quit IRC | 01:23 | |
| *** enriquetaso has joined #openstack-manila | 02:21 | |
| *** whoami-rajat has joined #openstack-manila | 02:38 | |
| *** enriquetaso has quit IRC | 03:07 | |
| *** kopecmartin|pto is now known as kopecmartin | 06:51 | |
| *** pcaruana has joined #openstack-manila | 07:08 | |
| *** tosky has joined #openstack-manila | 07:19 | |
| openstackgerrit | DingDong proposed openstack/manila master: [Unity] Driver Un-handled Share Server Support. https://review.opendev.org/673948 | 07:38 |
| *** Kuirong has joined #openstack-manila | 07:41 | |
| openstackgerrit | Eric Xie proposed openstack/manila master: Add missing space https://review.opendev.org/674544 | 07:48 |
| *** Kuirong has quit IRC | 07:51 | |
| openstackgerrit | Merged openstack/manila master: Add missing space https://review.opendev.org/674544 | 08:08 |
| *** e0ne has joined #openstack-manila | 08:48 | |
| *** haixin has joined #openstack-manila | 09:05 | |
| *** haixin has quit IRC | 09:15 | |
| *** haixin has joined #openstack-manila | 09:16 | |
| *** haixin has quit IRC | 09:16 | |
| *** haixin has joined #openstack-manila | 09:21 | |
| *** haixin has quit IRC | 09:21 | |
| *** haixin has joined #openstack-manila | 09:22 | |
| *** haixin has quit IRC | 09:38 | |
| *** baojg has quit IRC | 10:41 | |
| *** baojg has joined #openstack-manila | 10:46 | |
| *** baojg has quit IRC | 10:50 | |
| *** baojg has joined #openstack-manila | 10:53 | |
| *** lseki has joined #openstack-manila | 11:11 | |
| *** dviroel has joined #openstack-manila | 12:00 | |
| *** enriquetaso has joined #openstack-manila | 13:15 | |
| openstackgerrit | Douglas Viroel proposed openstack/manila master: Add share network with multiple subnets https://review.opendev.org/671043 | 13:17 |
| *** s0ru has joined #openstack-manila | 13:22 | |
| *** pcaruana has quit IRC | 13:47 | |
| *** pcaruana has joined #openstack-manila | 14:00 | |
| *** eharney has joined #openstack-manila | 14:20 | |
| *** _erlon_ has joined #openstack-manila | 14:23 | |
| *** petitbois has joined #openstack-manila | 15:24 | |
| petitbois | hello everyone! it seems that all the driver tests in the manila/tests folder are using the mock library. how exactly do I run these "mock" tests after writing a test case driver? | 15:31 |
| petitbois | ahhh -- nevermind! I believe the tox command is what I was looking for | 15:34 |
| *** enriquetaso has quit IRC | 15:43 | |
| vkmc | petitbois, probably run them by now, but yes... we use tox | 16:02 |
| vkmc | and you can pick the environment by passing the -e flag | 16:02 |
| vkmc | e.g. tox -e pep8 | 16:02 |
| vkmc | tox -e py37 | 16:02 |
| tbarron | https://docs.openstack.org/manila/latest/contributor/development.environment.html#running-unit-tests | 16:05 |
| vkmc | yep | 16:05 |
| vkmc | :) | 16:05 |
| vkmc | thx tbarron | 16:06 |
| *** lpetrut has joined #openstack-manila | 16:09 | |
| petitbois | awesome thanks! :) (y) tbarron vkmc | 16:10 |
| *** e0ne has quit IRC | 16:19 | |
| *** enriquetaso has joined #openstack-manila | 16:34 | |
| *** carloss has joined #openstack-manila | 16:56 | |
| *** kopecmartin is now known as kopecmartin|off | 16:59 | |
| vkmc | s0ru, hey, just reviewed your change for the manila list --count command in the server side | 17:35 |
| vkmc | s0ru, seems there are some tabs/trailing spaces messing with your code | 17:35 |
| vkmc | remove them and resubmit | 17:35 |
| vkmc | plus, add a unit test for the case in which a list is empty | 17:35 |
| vkmc | the test you need to add should go here https://github.com/openstack/manila/blob/master/manila/tests/api/v2/test_shares.py#L1551 | 17:35 |
| s0ru | vkmc, o/ I'm already working with unit tests :) I'll fix the tabs/trailing spaces | 17:42 |
| vkmc | s0ru, \o super | 17:42 |
| s0ru | vkmc, thanks n.n | 17:42 |
| *** e0ne has joined #openstack-manila | 18:05 | |
| *** dviroel has quit IRC | 18:16 | |
| openstackgerrit | Soledad Kuczala proposed openstack/manila master: Fix _list_view function for count https://review.opendev.org/673913 | 18:22 |
| *** tosky has quit IRC | 18:32 | |
| *** e0ne has quit IRC | 18:45 | |
| *** lpetrut has quit IRC | 19:05 | |
| *** e0ne has joined #openstack-manila | 19:16 | |
| *** carloss has quit IRC | 19:23 | |
| *** e0ne has quit IRC | 19:31 | |
| *** eharney has quit IRC | 21:07 | |
| *** whoami-rajat has quit IRC | 21:58 | |
| *** tosky has joined #openstack-manila | 22:26 | |
| *** tosky has quit IRC | 22:47 | |
| openstackgerrit | Soledad Kuczala proposed openstack/manila master: Fix _list_view function for count https://review.opendev.org/673913 | 23:03 |
| *** enriquetaso has quit IRC | 23:23 | |
| *** lseki has quit IRC | 23:38 | |
| *** enriquetaso has joined #openstack-manila | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!