| *** dviroel_ has quit IRC | 01:24 | |
| openstackgerrit | Lucio Seki proposed openstack/manila-tempest-plugin master: Delete servers before deleting its share network https://review.openstack.org/644905 | 02:51 |
|---|---|---|
| openstackgerrit | Soledad Kuczala proposed openstack/manila master: Adding documentation for user messages in Manila https://review.openstack.org/645010 | 03:15 |
| *** whoami-rajat has joined #openstack-manila | 04:10 | |
| *** lseki has quit IRC | 04:59 | |
| *** MisterS has quit IRC | 05:07 | |
| *** carlos_silva has quit IRC | 05:17 | |
| *** e0ne has joined #openstack-manila | 06:06 | |
| *** e0ne has quit IRC | 06:07 | |
| *** pcaruana has joined #openstack-manila | 06:11 | |
| *** e0ne has joined #openstack-manila | 07:45 | |
| *** openstackgerrit has quit IRC | 08:17 | |
| *** kopecmartin|off is now known as kopecmartin | 08:18 | |
| *** kopecmartin is now known as randarah | 08:19 | |
| *** randarah is now known as kopecmartin | 08:19 | |
| *** tosky has joined #openstack-manila | 08:27 | |
| *** e0ne has quit IRC | 08:48 | |
| *** e0ne has joined #openstack-manila | 08:51 | |
| *** whoami-rajat has quit IRC | 09:10 | |
| *** whoami-rajat has joined #openstack-manila | 09:18 | |
| *** pcaruana has quit IRC | 09:45 | |
| *** pcaruana has joined #openstack-manila | 09:46 | |
| *** e0ne has quit IRC | 10:14 | |
| *** e0ne has joined #openstack-manila | 10:17 | |
| *** dviroel_ has joined #openstack-manila | 10:30 | |
| *** carlos_silva has joined #openstack-manila | 10:56 | |
| *** e0ne has quit IRC | 10:58 | |
| *** e0ne has joined #openstack-manila | 10:59 | |
| *** openstackgerrit has joined #openstack-manila | 11:12 | |
| openstackgerrit | Lucian Petrut proposed openstack/manila master: Document Windows SMB driver https://review.openstack.org/645128 | 11:12 |
| *** eharney has quit IRC | 11:16 | |
| openstackgerrit | Helen Walsh proposed openstack/manila stable/pike: VMAX manila - deprecate old tags correctly https://review.openstack.org/645129 | 11:16 |
| openstackgerrit | Helen Walsh proposed openstack/manila stable/pike: VMAX manila doc - use of correct VMAX tags https://review.openstack.org/645134 | 11:22 |
| openstackgerrit | Helen Walsh proposed openstack/manila stable/pike: VMAX manila doc - SSL Support https://review.openstack.org/645136 | 11:25 |
| openstackgerrit | Helen Walsh proposed openstack/manila stable/pike: Manila VMAX docs - clarify driver_handles_share_servers https://review.openstack.org/645137 | 11:27 |
| *** thgcorrea has joined #openstack-manila | 11:28 | |
| *** whoami-rajat has quit IRC | 11:30 | |
| *** whoami-rajat has joined #openstack-manila | 11:34 | |
| openstackgerrit | Helen Walsh proposed openstack/manila stable/pike: Manila VMAX docs - clarify snapshot support https://review.openstack.org/645140 | 11:37 |
| *** eharney has joined #openstack-manila | 11:43 | |
| openstackgerrit | Lucian Petrut proposed openstack/manila master: Document Windows SMB driver https://review.openstack.org/645128 | 11:45 |
| openstackgerrit | Helen Walsh proposed openstack/manila stable/pike: Manila VMAX docs - improve pre-configurations on VMAX section https://review.openstack.org/645148 | 11:50 |
| openstackgerrit | Helen Walsh proposed openstack/manila stable/pike: Manila VMAX docs - differences between quotas https://review.openstack.org/645150 | 11:53 |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/python-manilaclient master: [WIP] Get rid of python-keystoneclient requirement https://review.openstack.org/511483 | 12:06 |
| *** eharney has quit IRC | 12:09 | |
| openstackgerrit | Lucian Petrut proposed openstack/manila master: Document Windows SMB driver https://review.openstack.org/645128 | 12:20 |
| *** lpetrut has joined #openstack-manila | 12:26 | |
| openstackgerrit | Carlos Eduardo proposed openstack/manila-tempest-plugin master: Delete servers before deleting its share network https://review.openstack.org/644905 | 12:28 |
| openstackgerrit | Carlos Eduardo proposed openstack/manila-tempest-plugin master: Delete servers before deleting its share network https://review.openstack.org/644905 | 12:42 |
| openstackgerrit | Lucian Petrut proposed openstack/manila master: Document Windows SMB driver https://review.openstack.org/645128 | 12:45 |
| *** e0ne has quit IRC | 12:51 | |
| *** lseki has joined #openstack-manila | 12:53 | |
| *** eharney has joined #openstack-manila | 12:56 | |
| *** enriquetaso has joined #openstack-manila | 13:01 | |
| *** irclogbot_0 has quit IRC | 13:07 | |
| *** irclogbot_0 has joined #openstack-manila | 13:09 | |
| *** altlogbot_1 has quit IRC | 13:23 | |
| *** e0ne has joined #openstack-manila | 13:23 | |
| *** altlogbot_3 has joined #openstack-manila | 13:24 | |
| *** e0ne has quit IRC | 13:37 | |
| *** altlogbot_3 has quit IRC | 13:39 | |
| *** whoami-rajat has quit IRC | 13:40 | |
| *** altlogbot_2 has joined #openstack-manila | 13:40 | |
| tbarron | gouthamr: lseki: carlos_silva: I bought a little time from the release team if we can still land https://review.openstack.org/644560 today | 13:43 |
| gouthamr | tbarron: ack, thank you | 13:43 |
| tbarron | gouthamr: but we need to avoid last minute theatrics, the earlier the better | 13:44 |
| *** irclogbot_0 has quit IRC | 13:45 | |
| lseki | tbarron: great! thank you! | 13:45 |
| *** e0ne has joined #openstack-manila | 13:45 | |
| carlos_silva | tbarron: ok, thanks! | 13:45 |
| *** irclogbot_0 has joined #openstack-manila | 13:46 | |
| carlos_silva | we are figuring out what's happening with the tempest tests | 13:46 |
| *** lpetrut has quit IRC | 14:06 | |
| *** lpetrut has joined #openstack-manila | 14:07 | |
| openstackgerrit | Lucian Petrut proposed openstack/manila master: Document Windows SMB driver https://review.openstack.org/645128 | 14:08 |
| tbarron | toabctl: if you could take another look at https://review.openstack.org/#/c/640185/ that would be great | 14:10 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Dummy driver: Don't fail unmanage on malformed share servers https://review.openstack.org/645190 | 14:13 |
| gouthamr | carlos_silva lseki: try this ^ | 14:14 |
| carlos_silva | thanks, I'll try | 14:15 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Dummy driver: Don't fail unmanage on malformed share servers https://review.openstack.org/645190 | 14:16 |
| gouthamr | or that ^ :) | 14:16 |
| lseki | gouthamr: makes sense, thanks! | 14:17 |
| *** whoami-rajat has joined #openstack-manila | 14:23 | |
| *** altlogbot_2 has quit IRC | 14:35 | |
| *** altlogbot_3 has joined #openstack-manila | 14:36 | |
| *** irclogbot_0 has quit IRC | 14:38 | |
| *** irclogbot_3 has joined #openstack-manila | 14:39 | |
| openstackgerrit | Amit Oren proposed openstack/manila master: INFINIDAT: suppress 'no-member' pylint errors https://review.openstack.org/645198 | 14:40 |
| carlos_silva | gouthamr: we cherry-picked your patch but the dummy driver test is still failing :/ | 14:50 |
| gouthamr | carlos_silva: are you running it locally? | 14:50 |
| carlos_silva | yeah | 14:50 |
| gouthamr | carlos_silva: cool, what's the log now? | 14:51 |
| lseki | btw its failing on zuul as well :-( http://logs.openstack.org/60/644560/5/check/manila-tempest-minimal-dsvm-dummy/bd19b76/job-output.txt.gz | 14:56 |
| carlos_silva | In the assertRases of the test_share_servers_manage_negative looks like we was waiting for ShareServerBuildErrorException but it was throwing BadRequest, I changed this and now the test is trying to manage a share server that is in unmanage_starting status | 14:56 |
| carlos_silva | s/we was/we were | 14:57 |
| carlos_silva | the method that fails is the test_manage_share_server_invalid_identifier... what is weird 'cause we have a "self._unmanage_share_server_and_wait(share_server)" that shouldn't let the test proceed to the next steps unless the share server is in a valid state | 14:59 |
| carlos_silva | gouthamr: it fails in the 2nd time that the "self._unmanage_share_server_and_wait(share_server)" is called | 14:59 |
| ganso | gouthamr: wow, how did that not fail before? | 15:02 |
| gouthamr | ganso: we were probably ignoring the share server until the share network was being torn down.. | 15:02 |
| gouthamr | ganso: and share network teardowns won't fail if share servers are there because it's an RPC call to the share manager, and cleanup on the database as far as the API is concerned | 15:03 |
| gouthamr | RPC calls to the share manager to clean up the share servers* | 15:03 |
| carlos_silva | ganso: idk :p | 15:04 |
| gouthamr | carlos_silva: can you add a depends-On on the test patch so we can see what's going on | 15:12 |
| carlos_silva | ok | 15:15 |
| *** spd_25 has joined #openstack-manila | 15:16 | |
| carlos_silva | gouthamr: should I add the depends that points to your patch on in the lseki's patch? | 15:21 |
| *** gouthamr has left #openstack-manila | 15:21 | |
| *** gouthamr has joined #openstack-manila | 15:21 | |
| gouthamr | carlos_silva: yep | 15:21 |
| *** eharney has quit IRC | 15:22 | |
| lseki | I think #644560 already depends on #644905 | 15:22 |
| spd_25 | Hi all! I am an outreachy aspirant and would like to fix the Bug #1799742 . Can someone please explain me the expected code structure. Thanks. | 15:22 |
| openstack | bug 1799742 in Manila "Wrong segmentation ID sent to drivers when using multi-segments" [Medium,New] https://launchpad.net/bugs/1799742 | 15:22 |
| lseki | but #644560 didn't run since #644905 was rebased on top of #645190 | 15:23 |
| tbarron | spd_25: we're in a weekly meeting on #openstack-meeting-alt right now but will come back here on the hour | 15:23 |
| lseki | so should carlos_silva just recheck his patch,gouthamr? | 15:23 |
| spd_25 | tbarron: okay! will wait. | 15:25 |
| *** enriquetaso has quit IRC | 15:31 | |
| gouthamr | lseki: unsure what you mean, carlos_silva said you're still seeing a dummy driver failure with https://review.openstack.org/#/c/644905/ after cherry-picking https://review.openstack.org/#/c/645190/ | 15:33 |
| gouthamr | lseki: i wanted to see the error to understand the issue, so asking for the commit message in https://review.openstack.org/#/c/644905/ to have a Depends-On: https://review.openstack.org/#/c/645190/ | 15:34 |
| lseki | gouthamr: oh, I see. Will do it, thanks | 15:35 |
| openstackgerrit | Carlos Eduardo proposed openstack/manila-tempest-plugin master: Delete servers before deleting its share network https://review.openstack.org/644905 | 15:39 |
| carlos_silva | gouthamr: done! I've added the depends on in the patch | 15:41 |
| gouthamr | thanks carlos_silva | 15:41 |
| tbarron | spd_25: our meeting ended early. Do you undertand the bug report for https://bugs.launchpad.net/manila/+bug/1799742 and the code where the problem is? | 15:41 |
| openstack | Launchpad bug 1799742 in Manila "Wrong segmentation ID sent to drivers when using multi-segments" [Medium,New] | 15:41 |
| carlos_silva | also rechecked https://review.openstack.org/#/c/644560 | 15:41 |
| spd_25 | tbarron: I got the code and understood why the problem is occuring, but I couldn't figure out what should be expected change. | 15:53 |
| spd_25 | like, If the segmentation ID should not be assigned there (as in the current code), then where should it be assigned? | 16:00 |
| openstackgerrit | Soledad Kuczala proposed openstack/manila master: Adding documentation for user messages in Manila https://review.openstack.org/645010 | 16:01 |
| tbarron | spd_25: as I read that bug the last segmentation ID is always being assigned instead of the appropriate one, so one needs to loop over them and pick the right one. | 16:03 |
| tbarron | spd_25: you may want to check with ganso if that is correct | 16:04 |
| tbarron | spd_25: he's Rodrigo Barbieri who reported the bug | 16:04 |
| tbarron | spd_25: but if that's right, I'd approach it by making a unit test (or adapting an existing one) such that | 16:04 |
| tbarron | spd_25: you hit more than one segmentation ID that fulfills the condition at https://github.com/openstack/manila/blob/2b40e5618f2c1039bbbbd1a3e31b72e104b5436b/manila/network/neutron/neutron_network_plugin.py#L268 | 16:05 |
| tbarron | spd_25: understand why the last one of those is getting chosen and figure how to get a better condition and break out of the loop ... | 16:06 |
| spd_25 | Thanks for the response tbarron. Am I required to query ganso? | 16:07 |
| tbarron | spd_25: in manila one is required to make (or adapt) unit tests for bug fixes like this anyways and that would enable you to test this out without having to actually set up a network with multi-segemnts etc. just to fix this bug | 16:08 |
| tbarron | spd_25: you are not *required* to do so, I was just letting you know that this bug reporter is on irc in this channel so if it is helpful to you you'll know who he is. | 16:09 |
| tbarron | spd_25: we will add him as a reviewer for your proposed patch though :) | 16:09 |
| *** e0ne has quit IRC | 16:10 | |
| spd_25 | ohh, thanks. I will try to find how the in the loop the last one is getting selected. | 16:10 |
| tbarron | spd_25: There is an "assigned to" field for this bug, you can assign it to yourself. | 16:10 |
| spd_25 | tbarron: sure! | 16:11 |
| tbarron | spd_25: thanks for working on this one! | 16:11 |
| spd_25 | tbarron: will come back here if I get stuck. | 16:11 |
| tbarron | spd_25: yup | 16:11 |
| *** eharney has joined #openstack-manila | 16:14 | |
| ganso | gouthamr: shouldn't https://review.openstack.org/#/c/644560 be tagged with APIImpact? | 16:16 |
| gouthamr | ganso: can be.. | 16:17 |
| ganso | carlos_silva: ^ | 16:18 |
| openstackgerrit | Carlos Eduardo proposed openstack/manila master: Fix server delete attempt along with share net deletion https://review.openstack.org/644560 | 16:25 |
| carlos_silva | ganso: APIImpact done ^ | 16:26 |
| carlos_silva | s/done/added in the commit message | 16:27 |
| carlos_silva | :p | 16:27 |
| gouthamr | carlos_silva lseki: https://review.openstack.org/#/c/644905/6/manila_tempest_tests/tests/api/admin/test_share_servers_manage_negative.py@258 | 16:28 |
| *** lpetrut has quit IRC | 16:32 | |
| lseki | gouthamr: yep, makes sense. will put the shareserverbuildexception back | 16:35 |
| carlos_silva | gouthamr: i agree with your comment... | 16:36 |
| openstackgerrit | Carlos Eduardo proposed openstack/manila-tempest-plugin master: Delete servers before deleting its share network https://review.openstack.org/644905 | 16:46 |
| openstackgerrit | Merged openstack/manila master: Document Windows SMB driver https://review.openstack.org/645128 | 16:56 |
| *** enriquetaso has joined #openstack-manila | 17:41 | |
| *** enriquetaso has quit IRC | 17:42 | |
| *** enriquetaso has joined #openstack-manila | 17:42 | |
| *** senrique_ has joined #openstack-manila | 17:44 | |
| *** enriquetaso has quit IRC | 17:46 | |
| *** gouthamr has left #openstack-manila | 17:49 | |
| *** gouthamr has joined #openstack-manila | 17:49 | |
| gouthamr | ganso: if you're around, i've a quick question around this bugfix | 17:49 |
| gouthamr | ganso: please take a look at https://review.openstack.org/#/c/644905/7/manila_tempest_tests/tests/api/admin/test_share_manage.py@135 -> do you agree? - the ability to run tempest tests with a configured share_network_id is important - if using a single neutron plugin or if you need to do stuff on the share network, like assigning security services - which is mandatory for NetApp/CIFS | 17:51 |
| *** senrique_ has quit IRC | 18:00 | |
| *** spd_25 has quit IRC | 18:02 | |
| ganso | gouthamr: I agree | 18:04 |
| ganso | gouthamr: we already did this for several other tests | 18:04 |
| ganso | gouthamr: it makes sense | 18:04 |
| gouthamr | ganso: awesome :) thanks! | 18:04 |
| gouthamr | lseki: moar comments ^ | 18:05 |
| *** e0ne has joined #openstack-manila | 18:05 | |
| gouthamr | lseki: but the good news is that your last PS passed | 18:05 |
| lseki | \O/ | 18:05 |
| lseki | gouthamr: thx, will check'em | 18:05 |
| *** e0ne has quit IRC | 18:12 | |
| carlos_silva | \o/ | 18:15 |
| *** whoami-rajat has quit IRC | 18:23 | |
| gouthamr | lseki carlos_silva: can we expect a patchset soon? to address comments in https://review.openstack.org/#/c/644905/? I don't mind merging as is, so you can fix it in a follow up patch | 18:23 |
| gouthamr | lseki carlos_silva: the priority is to get the bugfix passing/merged so we don't have an ugly backport to deal with | 18:24 |
| carlos_silva | lseki: is working on a new patch | 18:26 |
| lseki | gouthamr: sure, gimme 5min plz | 18:26 |
| gouthamr | thanks lseki carlos_silva.. | 18:26 |
| amito | need one more core for: https://review.openstack.org/#/c/645198/ :) thanks | 18:30 |
| openstackgerrit | Lucio Seki proposed openstack/manila-tempest-plugin master: Delete servers before deleting its share network https://review.openstack.org/644905 | 18:32 |
| lseki | gouthamr: ^ | 18:33 |
| gouthamr | lseki: neat | 18:39 |
| *** kopecmartin is now known as kopecmartin|off | 18:43 | |
| openstackgerrit | Merged openstack/manila master: Dummy driver: Don't fail unmanage on malformed share servers https://review.openstack.org/645190 | 18:59 |
| *** whoami-rajat has joined #openstack-manila | 19:26 | |
| *** e0ne has joined #openstack-manila | 19:30 | |
| gouthamr | bummer | 19:33 |
| carlos_silva | hey folks... lseki's patch passed in the dummy driver but mine didn't | 19:34 |
| carlos_silva | it was supposed to pass 'cause it has a depend's on in lseki's patch, right? | 19:36 |
| gouthamr | carlos_silva: hmmm, yeah.. looking at the tests and their, i found one issue. i'm seeing if that's it, or there are more problems | 19:42 |
| gouthamr | s/their/their logs: http://logs.openstack.org/60/644560/6/check/manila-tempest-minimal-dsvm-dummy/4000c6e/logs/tempest_1/ | 19:43 |
| gouthamr | so far i only see a problem in the tests | 19:44 |
| tbarron | meaning all the failures are in the test teardownclass? | 19:46 |
| gouthamr | yes | 19:46 |
| carlos_silva | yes | 19:47 |
| gouthamr | four share networks were created in the manage tests and they were reused everywhere else, which caused 14 failures: a17c23c2-2b11-4fa1-b3e7-58d05c35713d, 5a3f5901-28aa-4497-adde-3c314f763008, 18ab203d-6073-42ff-9102-e96cda811893, 9aebcc28-f9a1-4067-9cbb-f1e27594e0a0 | 19:47 |
| *** e0ne has quit IRC | 19:49 | |
| *** e0ne has joined #openstack-manila | 19:52 | |
| carlos_silva | gouthamr: yep | 19:53 |
| gouthamr | carlos_silva: hey, feel free to fix up the obvious problem noted here: https://review.openstack.org/#/c/644905/8 | 19:53 |
| gouthamr | i'm still troubleshooting | 19:54 |
| lseki | gouthamr: whoops, will fix it | 19:55 |
| gouthamr | wait, hold on.. shouldn't share and managed share have the same share_server_id | 19:55 |
| gouthamr | it's possible they may not, however... | 19:55 |
| lseki | oh, they should | 19:56 |
| lseki | they are the same, unless when the share-server is unmanaged as well | 19:57 |
| gouthamr | yeah.. line 96... | 19:57 |
| lseki | but it's not the case | 19:57 |
| gouthamr | ack | 19:57 |
| gouthamr | hmmm, so here's what i'm thinking - tempest tests are going to share the share network across test classes | 19:58 |
| gouthamr | when they decide they're done, they're going to teardown the share network | 19:59 |
| gouthamr | in the meanwhile, if the network has an undeletable share server, it blows up during teardown of that share network | 19:59 |
| gouthamr | so, it made sense to me that we enumerate these specific share servers during share network teardown and blow them away | 20:00 |
| lseki | gouthamr: so should I put back those cleanup instructions in the base test class? | 20:01 |
| gouthamr | ganso's suggestion that you have currently implemented isn't working... although it makes sense to cleanup resources that you forced the creation of | 20:01 |
| *** thgcorrea has quit IRC | 20:02 | |
| gouthamr | this current solution makes best sense if you turned down the concurrency to 1 (from 24)... | 20:02 |
| gouthamr | or prevent share networks from being reused by different/unrelated classes | 20:03 |
| lseki | makes sense, we ran the tests locally with concurrency=1 | 20:03 |
| *** e0ne has quit IRC | 20:04 | |
| lseki | hmm is it possible that the share networks are reused, even restoring the cleanup code in the bsae test class teardown? due to the concurrency? | 20:06 |
| gouthamr | lseki: yes, it is possible, however, the teardown happens towards the end, i.e, when we don't plan on ever reusing the credential that we used to run the tests | 20:08 |
| gouthamr | lseki: the tests run with concurrency 24, and there are a lot of "test accounts" available to use them with... so 24 threads are spawned and each of of them picks up test classes to execute.. | 20:09 |
| gouthamr | lseki: so at any point, when a thread looks for more test classes, but doesn't find any (because the other threads are already working on any remaining tests), it's time for a "teardown" | 20:10 |
| gouthamr | lseki: so, you can't really tell *which* test class will eventually be the final one to use your share network, but... the cleanup in the base class will be the *last* thing certainly | 20:11 |
| gouthamr | lseki: https://review.openstack.org/#/c/328391/ should add some context | 20:11 |
| gouthamr | this whole thing is because of our use of test credentials (tenants/projects that run tests) - and their isolated tenant networks | 20:12 |
| *** senrique_ has joined #openstack-manila | 20:21 | |
| lseki | gouthamr: I see... so the failing tests might be happening because threads start to teardown as they run out of test classes to execute | 20:24 |
| lseki | gouthamr: and each thread uses an account (w/ isolated share-network), which is reused among the tests that the thread runs | 20:25 |
| carlos_silva | gouthamr: makes sense... thanks for the explanation | 20:26 |
| lseki | gouthamr: and there might be is_auto_deletable=False share-servers (that might be in deleting state), associated to the share-networks about to be deleted, and that raises the error...? | 20:27 |
| *** e0ne has joined #openstack-manila | 20:28 | |
| lseki | gouthamr: so in this case, delete-and-wait-for-deletion of those share-servers upon share-network deletion would avoid teardown to fail | 20:30 |
| lseki | gouthamr: may I try this change and recheck carlos_silva's patch? | 20:33 |
| openstackgerrit | Merged openstack/manila master: INFINIDAT: suppress 'no-member' pylint errors https://review.openstack.org/645198 | 20:33 |
| gouthamr | lseki: it's possible.. for confirmation - don't change anything from your patch... let's just do this: | 20:37 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: [DNM] Log share servers on the share network before deletion https://review.openstack.org/645341 | 20:37 |
| lseki | gouthamr: nice! | 20:38 |
| *** e0ne has quit IRC | 21:17 | |
| *** pcaruana has quit IRC | 21:33 | |
| *** whoami-rajat has quit IRC | 21:45 | |
| lseki | gouthamr: http://logs.openstack.org/41/645341/1/check/manila-tempest-minimal-dsvm-dummy/ada9ad9/logs/tempest_1/tempest.txt.gz?level=INFO | 21:56 |
| gouthamr | lseki: looking | 21:59 |
| gouthamr | need to regex search this :) downloading it | 22:02 |
| gouthamr | wow, 107 share networks created and deleted, concurrency ftw | 22:04 |
| *** irclogbot_3 has quit IRC | 22:05 | |
| gouthamr | lseki: http://logs.openstack.org/41/645341/1/check/manila-tempest-minimal-dsvm-dummy/ada9ad9/logs/tempest_1/tempest.txt.gz?#_2019-03-21_21_16_25_406 | 22:06 |
| gouthamr | one instance where we have a non-autodeletable server | 22:06 |
| gouthamr | weird thing is that we never tried to delete that server.. | 22:08 |
| openstackgerrit | Merged openstack/manila master: Only allow IP access type for CephFS NFS https://review.openstack.org/640185 | 22:23 |
| lseki | gouthamr: hmm some test is creating it and leaving behind without deleting? | 22:25 |
| gouthamr | lseki: noticed the cleanup patch didn't touch the manage share server test class | 22:25 |
| gouthamr | lseki: although i'm seeing other residue not pertaining to that test class | 22:26 |
| *** erlon has joined #openstack-manila | 22:32 | |
| gouthamr | i mean, i see one share network with a non-autodeletable server left over from that test class (https://github.com/openstack/manila-tempest-plugin/blob/370569/manila_tempest_tests/tests/api/admin/test_share_servers_manage.py).. | 22:33 |
| lseki | gouthamr: ? the code seems to be deleting the server in the last line of this file | 22:38 |
| gouthamr | it does.. | 22:38 |
| lseki | and the share network is created with cleanup_in_class=True | 22:39 |
| gouthamr | i usually type out loud, and answer my own questions shortly after | 22:39 |
| gouthamr | lseki: yes.. the "class" over there is the base class, if the share network is being reused | 22:40 |
| *** senrique_ has quit IRC | 22:40 | |
| *** senrique_ has joined #openstack-manila | 22:41 | |
| *** senrique_ has quit IRC | 22:57 | |
| *** tosky has quit IRC | 22:59 | |
| gouthamr | lseki: are you still around? | 23:11 |
| lseki | hi | 23:11 |
| gouthamr | lseki: hey, found a bug | 23:13 |
| lseki | oh no | 23:13 |
| lseki | (or oh yes if the fix is easy | 23:14 |
| gouthamr | lseki: commented on https://review.openstack.org/#/c/644905/ | 23:16 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Delete servers before deleting its share network https://review.openstack.org/644905 | 23:35 |
| dviroel_ | fingers crossed | 23:41 |
| carlos_silva | ^ :p | 23:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!