| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Fix version selector when for proxy-style URLs https://review.openstack.org/639805 | 00:26 |
|---|---|---|
| *** dviroel has quit IRC | 00:54 | |
| *** takamatsu has quit IRC | 03:25 | |
| *** ganso has quit IRC | 03:38 | |
| *** enriquetaso has quit IRC | 04:21 | |
| *** takamatsu has joined #openstack-manila | 05:05 | |
| *** takamatsu has quit IRC | 05:10 | |
| *** kshitija has joined #openstack-manila | 06:21 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Fix version selector when for proxy-style URLs https://review.openstack.org/639805 | 06:32 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Fix version selector when for proxy-style URLs https://review.openstack.org/639805 | 06:35 |
| *** kshitija has quit IRC | 06:42 | |
| *** kshitija has joined #openstack-manila | 06:44 | |
| *** kshitija has quit IRC | 07:20 | |
| *** kshitija has joined #openstack-manila | 07:24 | |
| *** kshitija has quit IRC | 07:36 | |
| *** kshitija has joined #openstack-manila | 07:38 | |
| *** kshitija has quit IRC | 08:05 | |
| *** kshitija has joined #openstack-manila | 08:21 | |
| *** pcaruana has joined #openstack-manila | 08:32 | |
| *** tosky has joined #openstack-manila | 08:39 | |
| *** e0ne has joined #openstack-manila | 09:32 | |
| *** luizbag has joined #openstack-manila | 10:38 | |
| *** cmoura has quit IRC | 10:47 | |
| *** ganso has joined #openstack-manila | 10:56 | |
| *** mauricio_ps has joined #openstack-manila | 10:56 | |
| *** dviroel_ has joined #openstack-manila | 10:56 | |
| *** erlon has joined #openstack-manila | 11:08 | |
| amito | tbarron: ping | 11:14 |
| tbarron | amito: 'sup? | 11:16 |
| amito | tbarron: all good. I have a suggestion for the HTTP codes thing... would you like me to propose it in a separate patch or add to yours? | 11:17 |
| tbarron | amito: probably just propose it separately, that way if I like it I can +2 it and abandon mine | 11:19 |
| amito | tbarron: what I did, basically, is keep the http_codes.py file, but change it to import from httplib if we're in Python 2, or use HTTPStatus if we're in 3. Since pylint still doesn't eat it well, I added manila.api.http_codes to ignored-modules. I think ignoring that module is a small price to pay (it also means we only ignore it where it's imported, it still lints that module when you run pylint on 'all'). | 11:19 |
| tbarron | amito: +2 | 11:20 |
| amito | tbarron: thanks :) | 11:21 |
| tbarron | amito: thank you! | 11:21 |
| amito | tbarron: sure, np! | 11:23 |
| *** thaihust__ has joined #openstack-manila | 11:25 | |
| ganso | tbarron, gouthamr, bswartz, toabctl: Hi folks! Friendly reminder that Manage/Unmanage in DHSS=True patches are ready in gerrit waiting for your reviews: https://wiki.openstack.org/wiki/Manila/SteinCycle#Manage.2FUnmanage_Share_Servers | 11:27 |
| ganso | tbarron, gouthamr, bswartz, toabctl: All comments and concerns have been addressed so far, all tests are being run and passing for the Container and NetApp driver | 11:28 |
| tbarron | ganso: yes, and thank you for your work on this, including the recent extra work :) | 11:28 |
| thaihust__ | hi, i've deployed OpenStack Manila 3 nodes. I got a problem below | 11:28 |
| ganso | tbarron: =) | 11:28 |
| *** e0ne has quit IRC | 11:30 | |
| thaihust__ | when i create a share, manila-share on 1st node get request and create a share ok. I try stopping manila-share on this node, then delete the share created | 11:30 |
| thaihust__ | manila stucked at status deleting | 11:30 |
| thaihust__ | despite the fact that 2 remaining manila-share nodes still alive | 11:32 |
| thaihust__ | i wanna know how to configure HA for manila-share components | 11:33 |
| *** e0ne has joined #openstack-manila | 11:36 | |
| tbarron | thaihust__: sec | 11:38 |
| tbarron | thaihust__: are you deploying using an openstack distribution with its packages? | 11:50 |
| tbarron | thaihust__: anyways, there's a 'host' field in the DEFAULT section of manila.conf | 11:52 |
| tbarron | if you don't see it you're using its default value | 11:53 |
| tbarron | thaihust__: https://paste.fedoraproject.org/paste/9xttP57v19NYfmYOIH~RdQ | 11:54 |
| tbarron | thaihust__: you'll want the value of this to be the same on all three nodes for manila-share | 11:55 |
| thaihust__ | no, i build all component in docker | 11:55 |
| tbarron | thaihust__: so you want it in manila.conf for the containers running manila share | 11:56 |
| tbarron | thaihust__: manila share service | 11:56 |
| thaihust__ | i've already set host value be the same on all node as you recommeded | 11:56 |
| thaihust__ | but i got a new error | 11:56 |
| tbarron | thaihust__: leave them to the hostname for the other services | 11:56 |
| tbarron | thaihust__: you'll have to mess with the database for the shares created before they were set the same | 11:57 |
| thaihust__ | i set up exactly as you recommended, when i type: manila service-list, i got 3 scheduler service and only 1 manila-share name: cloud-fs@cephfsnative | 11:59 |
| thaihust__ | with cloud-fs is the host name i set for manila-share | 11:59 |
| thaihust__ | but as i told you above | 11:59 |
| tbarron | thaihust__: ok maybe my theory about why you're stuck deleting is wrong :) | 12:00 |
| tbarron | thaihust__: i'd turn on debug and look at the manila share-logs on the surviving nodes as well as the scheduler logs to see if | 12:02 |
| tbarron | thaihust__: manila share service on one of the surviving nodes is even attempting the delete operation | 12:02 |
| tbarron | thaihust__: and to see if the surviving share services are doing their periodic reports to the scheduler nodes | 12:03 |
| thaihust__ | i got a new problem: when i create the 1st share, everything ok, i watch manila-share on 1st controller handle this request. But when i create new shares, requests were load balanced to others controllers, manila-share stuck at creating new share | 12:03 |
| tbarron | thaihust__: if you have multiple nodes they'll load balance among the nodes for api and scheduler services but you only want to run one manila-share service at any time, are you doing that somehow? | 12:05 |
| tbarron | thaihust__: in our distro downstream we use pacemaker for that | 12:05 |
| tbarron | manila-share service (like cinder-volume) does not have active-active support yet | 12:06 |
| thaihust__ | could i use keepalived instead of pacemaker | 12:07 |
| tbarron | thaihust__: probably | 12:08 |
| tbarron | thaihust__: i use what our downstream distro uses already for cinder, etc. -- what our HA folks think is most reliable, etc. | 12:08 |
| tbarron | thaihust__: but I'm not an HA expert | 12:09 |
| thaihust__ | i'll try keepalived, thanks for your info | 12:11 |
| tbarron | thaihust__: good luck; in any case you'll want to run in debug and inspect share-service logs on the nodes that are up to see who is catching the message from the scheduler to do the operation and what problem is happening at that point | 12:12 |
| openstackgerrit | Arne Wiebalck proposed openstack/manila master: Fix error message when updating quota values https://review.openstack.org/640019 | 12:25 |
| toabctl | tbarron, what is the best way (in your opinion) to use ceph with manila but use cifs and/or nfs on the clients? | 12:44 |
| toabctl | the generic driver? | 12:44 |
| tbarron | toabctl: well *in my opinion* it is to use cephfs back end with nfs ganesha and samba for cifs | 12:45 |
| tbarron | toabctl: but I haven't built the samba part | 12:45 |
| tbarron | toabctl: only on back of envelope | 12:45 |
| toabctl | :) | 12:45 |
| tbarron | toabctl: i don't know of anyone who has deployed generic driver in production for real | 12:46 |
| toabctl | tbarron, so nfs-ganesha would be deployed manually and mounts a manila backend? | 12:46 |
| toabctl | yeah. that's why I'm asking. I don't think the generic driver is very useful in real world | 12:47 |
| tbarron | toabctl: by which I mean without introducing single point of failure on the data path, having limited number of cinder attaches for volumes, etc. etc. | 12:47 |
| toabctl | or do we have a manila driver that handles nfs-ganesah? | 12:47 |
| tbarron | networking issues too | 12:47 |
| tbarron | toabctl: we have a manila nfs-ganesh back end | 12:47 |
| tbarron | toabctl: sec | 12:47 |
| * toabctl lost overview about the backend drivers... | 12:47 | |
| tbarron | https://docs.openstack.org/manila/latest/admin/cephfs_driver.html#for-cephfs-nfs-shares | 12:49 |
| tbarron | toabctl: ^^ | 12:49 |
| tbarron | toabctl: for devstack, this may be helful: https://github.com/tombarron/vagrant-libvirt-devstack | 12:51 |
| tbarron | toabctl: buried in the ansible templates there you'll see devstack local.conf for deploying devstack that will deploy ganesha for you as well as an integrated cephfs back end | 12:52 |
| tbarron | toabctl: and here's how we do it downstream with tripleo: https://www.slideshare.net/Inktank_Ceph/ceph-day-berlin-practical-cephfs-and-nfs-using-openstack-manila | 12:53 |
| tbarron | toabctl: i'd love to see non-tripleo deployments also supporting cephfs with nfs back end | 12:54 |
| tbarron | toabctl: because i consider it the best end-to-end 100% open source way to deploy manila | 12:54 |
| tbarron | toabctl: glusterfs could also qualify there if the folks working with it would involve themselves again with the upstream manila community | 12:55 |
| tbarron | with PTL hat on I don't favor cephfs over other open source solutions, I'd like multiple open source back ends that | 12:56 |
| tbarron | people are willing to support | 12:56 |
| tbarron | and I want viable, supported proprietary back ends as well | 12:57 |
| *** mauricio_ps has quit IRC | 12:58 | |
| *** erlon has quit IRC | 12:58 | |
| *** luizbag has quit IRC | 12:58 | |
| *** enriquetaso has joined #openstack-manila | 13:13 | |
| *** erlon has joined #openstack-manila | 13:15 | |
| *** mauricio_ps has joined #openstack-manila | 13:16 | |
| *** luizbag has joined #openstack-manila | 13:16 | |
| openstackgerrit | Amit Oren proposed openstack/manila master: [pylint] fix errors with http_client status codes https://review.openstack.org/640025 | 13:20 |
| *** s0ru has joined #openstack-manila | 13:22 | |
| *** lseki has joined #openstack-manila | 13:26 | |
| *** thgcorrea has joined #openstack-manila | 13:36 | |
| toabctl | tbarron, thx for the info! | 13:45 |
| tbarron | toabctl: yw, as you can see I have a keen interest in that topic | 13:50 |
| tbarron | toabctl: would love to see healthy cooperation and competition in that area | 13:51 |
| openstackgerrit | Amit Oren proposed openstack/manila master: [pylint] fix errors with http_client status codes https://review.openstack.org/640025 | 13:53 |
| vkmc | toabctl, amito can you check this one? https://review.openstack.org/#/c/638320/ :) | 13:57 |
| amito | vkmc: no problem, I'll review it this evening as I'm on some downstream work at the moment :) | 13:58 |
| vkmc | amito, sure, thanks! | 13:58 |
| *** s0ru has quit IRC | 13:59 | |
| *** jmlowe has quit IRC | 14:01 | |
| *** mmethot has joined #openstack-manila | 14:06 | |
| *** kopecmartin has joined #openstack-manila | 14:08 | |
| *** a-pugachev has joined #openstack-manila | 14:14 | |
| *** a-pugachev has quit IRC | 14:17 | |
| *** ianychoi has joined #openstack-manila | 14:20 | |
| *** jgrosso has joined #openstack-manila | 14:28 | |
| *** jmlowe has joined #openstack-manila | 14:29 | |
| *** carlos_silva has joined #openstack-manila | 15:00 | |
| *** e0ne has quit IRC | 15:16 | |
| *** e0ne has joined #openstack-manila | 15:19 | |
| bswartz | I just noticed @slow_me_down for the first time | 15:22 |
| openstackgerrit | Amit Oren proposed openstack/manila master: [pylint] fix errors with http_client status codes https://review.openstack.org/640025 | 15:27 |
| amito | bswartz: what's that? | 15:32 |
| bswartz | amito: I'm wondering what it is | 15:33 |
| bswartz | It's in dummy.py | 15:34 |
| gouthamr | bswartz amito: https://review.openstack.org/#/c/400331/ | 15:35 |
| gouthamr | just sets predetermined artificial delays in execution of driver methods in the dummy driver to simulate storage backend delays | 15:36 |
| bswartz | gouthamr: +1 | 15:36 |
| amito | bswartz: seems like it just adds some delay before the function starts | 15:37 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Fix version selector when for proxy-style URLs https://review.openstack.org/639805 | 15:50 |
| *** a-pugachev has joined #openstack-manila | 15:59 | |
| *** a-pugachev has quit IRC | 15:59 | |
| ganso | tbarron, gouthamr: regarding https://review.openstack.org/#/c/638681/ | 16:00 |
| ganso | we've been investigating the proper fix across manila | 16:00 |
| ganso | we are able to fix in the database in 2 ways | 16:01 |
| * tbarron listens | 16:01 | |
| ganso | 1 is very simple: rename size property in models.py to instance_size and create a property size that returns either self.size or self.snapshot.size | 16:01 |
| ganso | but in the database, the share_snapshot_instance database will continue to store size as null | 16:02 |
| ganso | just to add some context, in the database, regular snapshots create instances with null size, and snaphots created via group snapshots create instances with the correct size | 16:02 |
| ganso | so, approach 1 is simple, no impact, but doesn't fix the real issue. | 16:03 |
| ganso | approach 2 is to fix for every new share snapshot instance created, so DB will always create the snapshot instance with the proper size regardless of how it is created | 16:03 |
| ganso | but we would need a database migration to fix it for all the existing DB entries | 16:04 |
| ganso | thus copying the snapshot size to the share snapshot instance size where it is null | 16:04 |
| ganso | and approach 3 is even simpler, just go with the patch already proposed 638681 xD | 16:04 |
| ganso | in my mind, approach 2 is the ideal one, but also the riskier | 16:05 |
| gouthamr | ganso: i like option 1, is there any problem in having a property in the snapshot instance model that overrides an existing attribute? | 16:05 |
| ganso | gouthamr: yes, in order to not override it, we rename the existing attribute to instance_size("size",Column(int)) | 16:05 |
| tbarron | ganso: just so I understand, why is doing a DB migration *riskier*? | 16:06 |
| ganso | gouthamr: and every time we do a create or update to the share_snapshot_instance model, we make sure the field is properly named "instance_size" instead of "size", as it is today | 16:06 |
| tbarron | ganso: i can understand that it's more work ... | 16:06 |
| gouthamr | ganso: oh, hmm, yeah. I think that's clean | 16:06 |
| ganso | tbarron: it is slightly risky in the sense that we are not 100% sure we won't find something different than what we expect in production clouds when running the db migration | 16:07 |
| gouthamr | ganso: option 3 will be a -2 from me, just saying :) | 16:08 |
| ganso | tbarron: we don't expect anything to be different, but we never know. Here's an example: | 16:08 |
| gouthamr | ganso: glad you guys found the root of the problem, but it's sketchy if we can't agree upon a generalized solution across all drivers - most of them won't have tests that would have caught this | 16:09 |
| ganso | tbarron: if there's an old production cloud that has snapshot since the old Liberty days when there wasn't share snapshot instances or group snapshots yet, they could have something different there. The bug happens on new snapshot instances created as of today | 16:09 |
| ganso | gouthamr: proposal 1 and 2 don't affect any driver at all | 16:10 |
| tbarron | ganso: k, I understand what you are saying then | 16:10 |
| ganso | gouthamr: it is fixed in the DB transparently | 16:10 |
| tbarron | the other thing is that if want to backport this fix to stable it can't involve db schema changes | 16:10 |
| ganso | tbarron: oh right, good point, didn't think about that | 16:10 |
| ganso | tbarron: so if there is a db migration it is not backportable | 16:11 |
| tbarron | well i'm not sure #1 is either | 16:11 |
| tbarron | gouthamr: ^^? | 16:11 |
| ganso | tbarron: hmm why wouldn't it? | 16:11 |
| ganso | tbarron: it looks like to me we will need the 2 fixes separated, one that we can backport, and the db migration that will fix the database for the current and next releases | 16:12 |
| gouthamr | don't see a problem with backporting a change to the model representation | 16:12 |
| tbarron | ganso: i guess changing properties in db isn't really a schema change but ... | 16:12 |
| tbarron | just thinking out loud and making sure | 16:13 |
| ganso | tbarron: it is just the model representation, the database column name isn't changed | 16:13 |
| tbarron | yes | 16:13 |
| gouthamr | if the fix isn't there, the bug is as it is today, there's really no user impact if drivers used to check the size like the netapp driver does | 16:13 |
| gouthamr | i.e, the real size would be set in the backend always, anyway | 16:13 |
| tbarron | but the "virtual database" as consumed by the upper layers has changed | 16:14 |
| tbarron | so not sure we'd really want to backport to stable/* | 16:14 |
| ganso | tbarron: not really, because of the property | 16:14 |
| ganso | tbarron: if the upper layer uses the snapshot_instance_create and update db methods, as it should be, then the upper layer will not notice a change | 16:14 |
| *** enriquetaso has quit IRC | 16:14 | |
| tbarron | ganso: what I'm saying is that we do queries using the properties, etc. not just the real columns | 16:14 |
| ganso | tbarron: if by "we" you mean other parts of manila or other drivers etc, we will submit the fix upstream and see what breaks | 16:15 |
| tbarron | it may be ok, just want to make sure you guys think this through :) | 16:15 |
| tbarron | sounds like you are converging on #1 | 16:16 |
| *** e0ne has quit IRC | 16:16 | |
| tbarron | we really don't need to backport for python 3 support anyways I think | 16:16 |
| ganso | tbarron: based on the fact that we can't backport db migrations, #1 will have to be done I guess... #2 is a very good improvement to be done as well for the current and future releases | 16:16 |
| tbarron | we need py3 for Stein | 16:17 |
| ganso | hmmm | 16:18 |
| tbarron | so consider the possiblity of #2 for Stein and forwards if you think it's the better fix | 16:18 |
| ganso | so, well, yea we need to decide between #1 or #2 | 16:18 |
| ganso | tbarron: yea it is better, but riskier :P | 16:18 |
| tbarron | sounds like gouthamr prefers #1 anyways? | 16:18 |
| ganso | tbarron: you know production clouds better than me, so if you think #2 is safe | 16:18 |
| ganso | tbarron: then I believe you | 16:18 |
| * tbarron watches ganso try to wiggle off the trout hook | 16:19 | |
| ganso | lol | 16:19 |
| ganso | gouthamr: what do you think ? | 16:20 |
| *** e0ne has joined #openstack-manila | 16:23 | |
| openstackgerrit | Tom Barron proposed openstack/manila master: Move grenade job to bionic and run with python 3 https://review.openstack.org/630727 | 16:23 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: [pylint] Fix/ignore pylint errors in test modules https://review.openstack.org/638067 | 16:36 |
| *** jmlowe has quit IRC | 16:43 | |
| *** e0ne has quit IRC | 17:05 | |
| openstackgerrit | Merged openstack/puppet-manila stable/queens: Support cephfs_volume_mode parameter https://review.openstack.org/639645 | 17:14 |
| *** luizbag has quit IRC | 17:16 | |
| *** luizbag has joined #openstack-manila | 17:16 | |
| *** kopecmartin is now known as kopecmartin|off | 17:17 | |
| *** jgrosso has quit IRC | 17:39 | |
| *** yajushiSri has joined #openstack-manila | 17:53 | |
| *** luizbag has quit IRC | 17:56 | |
| *** jmlowe has joined #openstack-manila | 18:03 | |
| *** kshitija has quit IRC | 18:37 | |
| *** e0ne has joined #openstack-manila | 18:51 | |
| *** mauricio_ps has quit IRC | 18:54 | |
| *** luizbag has joined #openstack-manila | 18:57 | |
| *** luizbag_ has joined #openstack-manila | 19:02 | |
| *** e0ne has quit IRC | 19:03 | |
| *** luizbag has quit IRC | 19:04 | |
| *** thaihust__ has quit IRC | 19:08 | |
| *** mauricio_ps has joined #openstack-manila | 19:14 | |
| *** enriquetaso has joined #openstack-manila | 19:14 | |
| *** pcaruana has quit IRC | 19:14 | |
| *** whoami-rajat has quit IRC | 19:20 | |
| ganso | gouthamr, tbarron: is there any way we can try to reach agreement on the above discussion? This is a high priority for us and I have a team mate that is waiting for this agreement so we can finish the implementation and send it upstream | 19:25 |
| gouthamr | ganso: thought we agreed... we won't backport a database migration, so if the fix can be done without one, great.. | 19:27 |
| ganso | gouthamr: ok, we will proceed with this fix, and if we ever want to improve the bugfix fixing it in the database, we make a separate patch | 19:28 |
| ganso | gouthamr: thanks | 19:28 |
| gouthamr | ganso: yw, thanks for the bugfix! | 19:29 |
| *** senrique_ has joined #openstack-manila | 19:50 | |
| *** enriquetaso has quit IRC | 19:52 | |
| *** senrique_ has quit IRC | 19:55 | |
| *** senrique_ has joined #openstack-manila | 19:55 | |
| *** thgcorrea has quit IRC | 20:02 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Add manage/unmanage of shares in DHSS=True https://review.openstack.org/635831 | 20:06 |
| * gouthamr grrr | 20:06 | |
| gouthamr | ganso: imma complete the API review on PS19, and do the others on PS20, seeing as you've only addressed one of my comments :) | 20:07 |
| ganso | gouthamr: omg how many are there | 20:08 |
| gouthamr | ganso: you wait | 20:08 |
| gouthamr | :P | 20:08 |
| *** mauricio_ps has quit IRC | 20:09 | |
| *** luizbag_ has quit IRC | 20:13 | |
| openstackgerrit | Merged openstack/manila master: Fix error message when updating quota values https://review.openstack.org/640019 | 20:15 |
| *** e0ne has joined #openstack-manila | 20:16 | |
| *** senrique_ is now known as enriquetaso | 20:20 | |
| *** lseki has left #openstack-manila | 20:23 | |
| openstackgerrit | Lucio Seki proposed openstack/manila-tempest-plugin master: Add functional tests for manage/unmanage of shares in DHSS=True https://review.openstack.org/638231 | 20:23 |
| openstackgerrit | Tom Barron proposed openstack/manila master: Only allow IP access type for CephFS NFS https://review.openstack.org/640185 | 20:38 |
| openstackgerrit | Lucio Seki proposed openstack/manila-tempest-plugin master: Add functional tests for manage/unmanage of shares in DHSS=True https://review.openstack.org/638231 | 20:41 |
| *** erlon has quit IRC | 21:01 | |
| gouthamr | ganso: while you wait can you review these test changes? it'll be good to have them merged: https://review.openstack.org/628921 https://review.openstack.org/635703 | 21:07 |
| openstackgerrit | Lucio Seki proposed openstack/manila-tempest-plugin master: Add functional tests for manage/unmanage of shares in DHSS=True https://review.openstack.org/638231 | 21:11 |
| ganso | gouthamr: I'm on the bus home and I will work on addressing the comments as soon as I get home so I can push a patch to get the CI to run tonight. I'll review those changes tomorrow morning | 21:13 |
| gouthamr | ganso: oh, no rush.. didn't realize you're four hours ahead! :) goodnight! | 21:14 |
| ganso | gouthamr: 5 hours actually, if you're in seattle at this moment | 21:17 |
| gouthamr | ganso: nice.. I'll be wrong again in 10 days :P | 21:18 |
| *** e0ne has quit IRC | 21:19 | |
| *** e0ne has joined #openstack-manila | 21:42 | |
| openstackgerrit | Lucio Seki proposed openstack/manila-tempest-plugin master: Add functional tests for manage/unmanage of shares in DHSS=True https://review.openstack.org/638231 | 21:43 |
| *** e0ne has quit IRC | 21:44 | |
| *** e0ne has joined #openstack-manila | 21:45 | |
| *** zul has quit IRC | 21:53 | |
| *** e0ne has quit IRC | 22:01 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Add manage/unmanage of shares in DHSS=True https://review.openstack.org/635831 | 22:54 |
| *** carlos_silva has quit IRC | 22:59 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila-tempest-plugin master: Add functional tests for manage/unmanage of shares in DHSS=True https://review.openstack.org/638231 | 23:04 |
| ganso | gouthamr: ok I addressed the comments (some I replied with some questions), and I have triggered the CIs. I will have dinner now. Do you have more comments inbound today? | 23:05 |
| gouthamr | ganso: 'course i do, i was going to post on your patch that you don't address them tonight.. | 23:06 |
| gouthamr | we're going to see some midair collisions if new patchsets come in | 23:06 |
| ganso | gouthamr: what do you mean? I dont mind with post the comments related to previous patchsets, since they are on different files | 23:09 |
| gouthamr | ganso: sure, np if you don't mind.. i meant that i'm working through those files in batches; and like you saw, we're still in the API | 23:10 |
| ganso | gouthamr: hmm maybe you could re-review just after you finished your first pass through all the code, and dont mind the changes based on your comments that I push up | 23:14 |
| gouthamr | ganso: sure.. | 23:14 |
| *** enriquetaso has quit IRC | 23:22 | |
| *** dviroel_ has quit IRC | 23:41 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!