*** erlon has joined #openstack-manila | 00:07 | |
*** enriquetaso has quit IRC | 00:45 | |
*** enriquetaso has joined #openstack-manila | 00:49 | |
*** erlon has quit IRC | 02:19 | |
*** enriquetaso has quit IRC | 03:31 | |
*** e0ne has joined #openstack-manila | 06:41 | |
*** e0ne has quit IRC | 06:47 | |
*** e0ne has joined #openstack-manila | 07:35 | |
*** e0ne has quit IRC | 07:38 | |
*** pcaruana has joined #openstack-manila | 07:43 | |
*** tosky has joined #openstack-manila | 08:33 | |
*** pcaruana|afk| has joined #openstack-manila | 09:01 | |
*** pcaruana has quit IRC | 09:02 | |
*** e0ne has joined #openstack-manila | 09:08 | |
*** trident has joined #openstack-manila | 09:38 | |
*** pcaruana|afk| has quit IRC | 10:01 | |
*** pcaruana has joined #openstack-manila | 10:07 | |
openstackgerrit | Merged openstack/manila stable/rocky: [LVM] Run filesystem check before assigning UUID https://review.openstack.org/637378 | 10:33 |
---|---|---|
*** luizbag has joined #openstack-manila | 11:08 | |
*** erlon has joined #openstack-manila | 11:23 | |
openstackgerrit | Tom Barron proposed openstack/manila master: Suppress pylint warnings from dell_emc drivers https://review.openstack.org/636739 | 11:29 |
openstackgerrit | Tom Barron proposed openstack/manila master: Suppress pylint warnings from dell_emc drivers https://review.openstack.org/636739 | 11:30 |
*** thgcorrea has joined #openstack-manila | 12:22 | |
openstackgerrit | Tom Barron proposed openstack/manila stable/queens: add tripleo scenario004 to experimental queue https://review.openstack.org/637532 | 12:34 |
*** enriquetaso has joined #openstack-manila | 13:13 | |
*** eharney has joined #openstack-manila | 13:20 | |
*** kaisers has quit IRC | 13:42 | |
*** jmlowe has quit IRC | 13:43 | |
*** kaisers has joined #openstack-manila | 13:49 | |
*** ganso has joined #openstack-manila | 13:51 | |
*** thgcorrea has quit IRC | 14:20 | |
*** eharney has quit IRC | 14:23 | |
*** thgcorrea has joined #openstack-manila | 14:34 | |
*** jmlowe has joined #openstack-manila | 14:41 | |
openstackgerrit | Tom Barron proposed openstack/manila stable/queens: Fix service image boot issues https://review.openstack.org/637565 | 15:09 |
openstackgerrit | Tom Barron proposed openstack/manila stable/queens: [LVM] Run filesystem check before assigning UUID https://review.openstack.org/637566 | 15:10 |
*** jmlowe has quit IRC | 15:20 | |
*** jmlowe has joined #openstack-manila | 15:21 | |
*** e0ne has quit IRC | 15:42 | |
*** e0ne has joined #openstack-manila | 15:48 | |
*** pcaruana has quit IRC | 16:10 | |
*** e0ne has quit IRC | 16:34 | |
*** eharney has joined #openstack-manila | 16:40 | |
openstackgerrit | Tom Barron proposed openstack/manila stable/queens: [LVM] Run filesystem check before assigning UUID https://review.openstack.org/637566 | 16:57 |
*** jmlowe has quit IRC | 17:02 | |
*** carlos_silva has joined #openstack-manila | 17:19 | |
*** jmlowe has joined #openstack-manila | 17:20 | |
*** jmlowe has quit IRC | 17:31 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila master: Deploy manila with uwsgi on devstack https://review.openstack.org/631338 | 17:37 |
*** jmlowe has joined #openstack-manila | 17:45 | |
openstackgerrit | Merged openstack/puppet-manila master: Dell EMC Manila Driver- rebranding changes https://review.openstack.org/637016 | 18:07 |
openstackgerrit | Merged openstack/puppet-manila master: Service_token_roles_required missing in the server config file https://review.openstack.org/637098 | 18:20 |
*** e0ne has joined #openstack-manila | 18:24 | |
ganso | gouthamr: ping | 18:52 |
gouthamr | hey ganso o/ | 18:52 |
ganso | gouthamr: hey Goutham! I have reviewed your patch https://review.openstack.org/#/c/633155 | 18:55 |
ganso | gouthamr: shouldn't it have the APIImpact flag? | 18:55 |
ganso | gouthamr: in the commit mss | 18:56 |
ganso | gouthamr: *msg | 18:56 |
gouthamr | ganso: it should, i've not been using that flag very consistently, my bad... but it has DocImpact though, because i am missing docs, and would like to track and get them up | 18:57 |
gouthamr | ganso: i'll add notes to the API-Ref if necessary when i close the resulting doc bug | 18:57 |
ganso | gouthamr: ok, I'll add it along with my other comment | 19:00 |
gouthamr | ganso: thanks! | 19:00 |
ganso | gouthamr: done | 19:00 |
ganso | gouthamr: wait, sorry, I may have misinterpreted what you just said | 19:01 |
ganso | gouthamr: did you say that it is ok to miss the APIImpact flag because you will add notes to the API-Ref? | 19:02 |
ganso | gouthamr: "APIImpact - Use this tag when the code change modifies a public HTTP API interface. This tag indicates that the patch creates, changes, or deletes a public API interface or changes its behavior. The tag may be followed by a reason beginning on the next line. If you are touching manila’s API layer and you are unsure if your change has an impact on the API, use this tag anyway." | 19:02 |
gouthamr | ganso: yes, we used to add the APIImpact flag to ask for API reviews from the API SIG, we haven't been doing that for the last few releases... right now, i tend to use that flag to only call out real impact (potentially backwards affecting compatibility - with reasonoing) that i want reviewers' attention on... not changes that preserve backwards compatibility | 19:04 |
gouthamr | ganso: sorta like forgetting "TrivialFix" in teh commit messages :) i.e, it's a convention, but we don't enforce it | 19:06 |
ganso | gouthamr: oh ok | 19:06 |
ganso | gouthamr: so if you think it there is no problem I can just workflow it | 19:06 |
gouthamr | ganso: yes, responded to your other comment in line.. | 19:07 |
ganso | gouthamr: ok, so I will workflow it | 19:07 |
gouthamr | thanks ganso | 19:08 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila-tempest-plugin master: Temporarily disable test_manage_invalid https://review.openstack.org/635885 | 19:19 |
ganso | gouthamr, bswartz, toabctl: Hi folks! Friendly reminder that Manage/Unmanage in DHSS=True patches are ready in gerrit waiting for your reviews: https://wiki.openstack.org/wiki/Manila/SteinCycle#Manage.2FUnmanage_Share_Servers Thanks in advance! =) | 19:20 |
ganso | I see tbarron has started reviewing the code. Thanks! =D | 19:20 |
bswartz | ganso: Today is US holiday | 19:20 |
bswartz | Nobody in office | 19:20 |
ganso | bswartz: oh, my bad! didn't know | 19:21 |
gouthamr | me neither :D /kidding | 19:21 |
ganso | bswartz: looking forward for your review tomorrow then hah. enjoy the holiday! =D | 19:21 |
gouthamr | ganso: where be the tempest tests? i started looking at the code too, would be nice to see the test cases in parallel | 19:22 |
gouthamr | there's a ton of LOCs of change, and i bet the unit tests were a pain to write, but, we mock out way too much good stuff in the unit tests that only end-to-end tests finally catch :) case-in-point, my patch you just workflowed :D | 19:23 |
ganso | gouthamr: yup there will be, we are finishing them and will probably submit them by the end of the day tomorrow | 19:26 |
gouthamr | ganso: nice, thanks | 19:28 |
*** e0ne has quit IRC | 19:30 | |
*** e0ne has joined #openstack-manila | 19:37 | |
bswartz | gouthamr: you're not taking the day off? | 19:57 |
bswartz | Thing must have gone downhill since the acquisition ;-) | 19:57 |
gouthamr | bswartz: nope, not a day off for me/tbarron :) | 19:57 |
gouthamr | maybe they don't like the current president or something :D | 19:58 |
bswartz | I think president's day is for the dead ones | 19:58 |
*** thgcorrea has quit IRC | 20:00 | |
gouthamr | bswartz: makes sense, my humor is on vacation today :P | 20:02 |
bswartz | I was trying to make a joke about IBM | 20:07 |
*** luizbag has quit IRC | 20:19 | |
*** eharney has quit IRC | 20:29 | |
openstackgerrit | Merged openstack/manila stable/queens: Fix service image boot issues https://review.openstack.org/637565 | 20:38 |
openstackgerrit | Merged openstack/manila stable/queens: [LVM] Run filesystem check before assigning UUID https://review.openstack.org/637566 | 20:38 |
openstackgerrit | Merged openstack/manila master: Allow configuring availability_zones in share types https://review.openstack.org/633155 | 20:38 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: [ZFSOnLinux] Log ZFS options as they are retrieved https://review.openstack.org/637626 | 20:47 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: [ZFSOnLinux] Log ZFS options as they are retrieved https://review.openstack.org/637626 | 20:48 |
*** jmlowe has quit IRC | 20:56 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Add policy to create/update public shares https://review.openstack.org/634864 | 20:56 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Fix typo in test name https://review.openstack.org/637629 | 20:59 |
* gouthamr -- | 20:59 | |
*** erlon has quit IRC | 21:04 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila master: Deploy manila with uwsgi on devstack https://review.openstack.org/631338 | 21:12 |
*** ganso has quit IRC | 21:50 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: [pylint] Stop linting usage of 'mock.Mock' module https://review.openstack.org/637634 | 21:54 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: [pylint] - DNM - Run pylint on the whole tree https://review.openstack.org/637637 | 21:57 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: [pylint] - DNM - Run pylint on the whole tree https://review.openstack.org/637637 | 21:59 |
*** e0ne has quit IRC | 22:03 | |
*** e0ne has joined #openstack-manila | 22:04 | |
*** carlos_silva has quit IRC | 22:09 | |
*** enriquetaso has quit IRC | 22:26 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Fix sshpool.remove https://review.openstack.org/637644 | 22:32 |
*** jmlowe has joined #openstack-manila | 22:32 | |
*** S0ru has joined #openstack-manila | 22:43 | |
*** eharney has joined #openstack-manila | 22:45 | |
S0ru | Hi everyone! I'm Sol, I've just joined Outreachy and I'd like to participate on Sofia Enriquez's project. Nice to meet you! | 22:51 |
*** eharney has quit IRC | 22:58 | |
*** e0ne has quit IRC | 23:12 | |
gouthamr | S0ru: hey Sol! | 23:16 |
gouthamr | S0ru: glad to have you here! Welcome | 23:17 |
gouthamr | S0ru: this channel is usually buzzing during US work-time since a bulk of the contributors align with the US East Coast timezone.. that said, most of us have IRC bouncers so we can always answer your questions when we're back in front of our keyboards | 23:19 |
*** e0ne has joined #openstack-manila | 23:23 | |
*** e0ne has quit IRC | 23:30 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!