| *** enriquetaso has quit IRC | 00:24 | |
| openstackgerrit | Tom Barron proposed openstack/manila stable/queens: Fix ganesha for 0.0.0.0/0 access https://review.openstack.org/626865 | 00:27 |
|---|---|---|
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add tests for share type availability_zones extra-spec https://review.openstack.org/635703 | 01:04 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add tests for share type availability_zones extra-spec https://review.openstack.org/635703 | 01:21 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add tests for export location changes in APIv 2.47 https://review.openstack.org/628921 | 01:33 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add tests for share type availability_zones extra-spec https://review.openstack.org/635703 | 01:33 |
| *** ianychoi has quit IRC | 03:49 | |
| *** ianychoi has joined #openstack-manila | 03:55 | |
| *** e0ne has joined #openstack-manila | 06:50 | |
| *** e0ne has quit IRC | 07:06 | |
| *** pcaruana has joined #openstack-manila | 07:23 | |
| *** takamatsu has joined #openstack-manila | 08:00 | |
| *** ianychoi has quit IRC | 08:50 | |
| *** raissa has joined #openstack-manila | 09:07 | |
| *** a-pugachev has joined #openstack-manila | 09:15 | |
| *** e0ne has joined #openstack-manila | 09:20 | |
| *** tosky has joined #openstack-manila | 09:45 | |
| *** luizbag has joined #openstack-manila | 10:00 | |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-manila master: Remove Ubuntu Xenial from metadata.json https://review.openstack.org/635755 | 10:31 |
| *** ganso has joined #openstack-manila | 10:57 | |
| openstackgerrit | Tom Barron proposed openstack/manila stable/queens: Fix ganesha for 0.0.0.0/0 access https://review.openstack.org/626865 | 11:01 |
| *** erlon has joined #openstack-manila | 11:11 | |
| openstackgerrit | Tom Barron proposed openstack/manila master: DNM - baseline on master https://review.openstack.org/622951 | 11:14 |
| openstackgerrit | Tom Barron proposed openstack/manila master: Add tripleo scenario004 job to experimental queu https://review.openstack.org/634396 | 11:14 |
| openstackgerrit | Tobias Urdin proposed openstack/puppet-manila master: Use puppet 4 compatible mysql functions https://review.openstack.org/635798 | 11:16 |
| *** takamatsu_ has joined #openstack-manila | 11:20 | |
| *** takamatsu has quit IRC | 11:20 | |
| *** raissa has quit IRC | 11:46 | |
| *** e0ne has quit IRC | 12:29 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Add manage/unmanage of shares in DHSS=True https://review.openstack.org/635831 | 13:03 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Add manage/unmanage of shares in DHSS=True https://review.openstack.org/635831 | 13:05 |
| *** eharney has joined #openstack-manila | 13:15 | |
| *** e0ne has joined #openstack-manila | 13:17 | |
| openstackgerrit | Tom Barron proposed openstack/manila master: Bump timeout on generic job https://review.openstack.org/635834 | 13:21 |
| openstackgerrit | Tom Barron proposed openstack/manila master: Bump timeout on scenario job https://review.openstack.org/635834 | 13:22 |
| *** ianychoi has joined #openstack-manila | 13:27 | |
| *** eharney has quit IRC | 13:38 | |
| *** eharney has joined #openstack-manila | 13:43 | |
| *** raissa has joined #openstack-manila | 13:46 | |
| *** enriquetaso has joined #openstack-manila | 13:55 | |
| *** a-pugachev has quit IRC | 14:04 | |
| openstackgerrit | Merged openstack/manila stable/queens: Only run the needed services for CephFS jobs https://review.openstack.org/626879 | 14:04 |
| *** a-pugachev has joined #openstack-manila | 14:08 | |
| *** erlon has quit IRC | 14:23 | |
| *** raissa has quit IRC | 14:46 | |
| *** a-pugachev has quit IRC | 15:12 | |
| *** a-pugachev has joined #openstack-manila | 15:13 | |
| openstackgerrit | Tom Barron proposed openstack/manila master: Bump timeout on mysql-generic and scenario jobs https://review.openstack.org/635834 | 15:19 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Add manage/unmanage of shares in DHSS=True https://review.openstack.org/635831 | 15:20 |
| *** raissa has joined #openstack-manila | 15:22 | |
| *** raissa has quit IRC | 15:27 | |
| *** pcaruana has quit IRC | 15:31 | |
| *** eharney has quit IRC | 15:58 | |
| *** eharney has joined #openstack-manila | 16:09 | |
| *** e0ne has quit IRC | 16:17 | |
| *** erlon has joined #openstack-manila | 16:21 | |
| *** a-pugachev has quit IRC | 16:28 | |
| *** a-pugachev has joined #openstack-manila | 16:31 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila-tempest-plugin master: Temporarily disable test_manage_invalid https://review.openstack.org/635885 | 16:41 |
| *** raissa has joined #openstack-manila | 16:43 | |
| *** eharney has quit IRC | 16:48 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Add manage/unmanage of shares in DHSS=True https://review.openstack.org/635831 | 17:02 |
| openstackgerrit | Tom Barron proposed openstack/manila stable/pike: Only run the needed services for CephFS jobs https://review.openstack.org/635887 | 17:05 |
| *** a-pugachev has quit IRC | 17:26 | |
| *** a-pugachev has joined #openstack-manila | 17:27 | |
| ganso | gouthamr: ping | 17:29 |
| *** a-pugachev has quit IRC | 18:08 | |
| *** jmlowe has quit IRC | 18:11 | |
| *** luizbag has quit IRC | 18:12 | |
| *** eharney has joined #openstack-manila | 18:38 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Add manage/unmanage of shares in DHSS=True https://review.openstack.org/635831 | 18:45 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient master: Add CLI commands for Manage-Unmanage of Share Servers https://review.openstack.org/635915 | 18:49 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add tests for export location changes in APIv 2.47 https://review.openstack.org/628921 | 18:57 |
| gouthamr | ganso: pong, still need me? | 18:57 |
| ganso | gouthamr: yes! hey Goutham! =) | 18:57 |
| gouthamr | ganso: hey Rodrigo, wassup? | 18:58 |
| ganso | gouthamr: I need assistance from someone with PhD in docs such as you | 18:58 |
| ganso | gouthamr: :P | 18:58 |
| gouthamr | :P | 18:58 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add tests for share type availability_zones extra-spec https://review.openstack.org/635703 | 18:58 |
| ganso | gouthamr: in https://review.openstack.org/#/c/635831/ | 18:59 |
| ganso | gouthamr: I updated the docstrings of the manage_existing_snapshot from the HNAS driver | 18:59 |
| ganso | gouthamr: and docs started complaining about that | 18:59 |
| ganso | gouthamr: first I fixed the indentation | 18:59 |
| ganso | gouthamr: and docs started complaining about that | 19:00 |
| ganso | gouthamr: reverting the fix, hence, leaving it incorrectly indented (IMO, also, look at other occurrences in the same class), causes docs build to not complain anymore | 19:00 |
| ganso | gouthamr: I am confused as to what is the problem only for this particular method | 19:01 |
| *** raissa has quit IRC | 19:01 | |
| ganso | gouthamr: the latest patch I submitted is running in zuul now, but the docs build already pased | 19:02 |
| *** raissa has joined #openstack-manila | 19:02 | |
| ganso | gouthamr: s/pased/passed | 19:02 |
| *** raissa has quit IRC | 19:02 | |
| gouthamr | ganso: weird, i see the indentation in some methods, and no indentation in others | 19:02 |
| ganso | gouthamr: do you have any idea of why it has to be incorrectly indented like that in order for the docs build to pass? | 19:02 |
| *** raissa has joined #openstack-manila | 19:03 | |
| *** raissa has quit IRC | 19:03 | |
| gouthamr | so everywhere you've indented, you've a blank line underneath, did you check the doc output? | 19:03 |
| *** raissa has joined #openstack-manila | 19:04 | |
| *** raissa has quit IRC | 19:04 | |
| ganso | gouthamr: hmm yea the doc output said that it was unexpectedly indented | 19:04 |
| ganso | gouthamr: let me grab the link of previous zuul builds | 19:04 |
| gouthamr | i saw that | 19:04 |
| gouthamr | i meant, the output on the successful build | 19:04 |
| *** raissa has joined #openstack-manila | 19:04 | |
| ganso | gouthamr: if you see patchset 2 and 3, I tried with blank line and without, and it didn't make a difference | 19:04 |
| *** raissa has quit IRC | 19:04 | |
| ganso | gouthamr: oh, not yet | 19:05 |
| gouthamr | the output does look bad: http://logs.openstack.org/31/635831/5/check/openstack-tox-docs/a824bd5/html/admin/hitachi_hnas_driver.html | 19:05 |
| *** raissa has joined #openstack-manila | 19:05 | |
| *** raissa has quit IRC | 19:05 | |
| gouthamr | it has always been: https://docs.openstack.org/manila/latest/admin/hitachi_hnas_driver.html#driver-version-3-0 | 19:06 |
| ganso | gouthamr: yikes | 19:06 |
| ganso | gouthamr: ok so this is weirder than I thought | 19:06 |
| ganso | gouthamr: this is probably being caused by another problem then | 19:06 |
| ganso | gouthamr: I was going to say that maybe it needs a line break between the last :param: and :returns: | 19:08 |
| ganso | gouthamr: but I saw other occurrences are fine without it | 19:08 |
| gouthamr | ganso: no, we use reStructured text within docstrings, so the indentation seems weird and off, i wonder if it works if you just push it to the text level - like bulleted lists | 19:11 |
| ganso | gouthamr: I'd guess it is something in the middle of the text causing issues | 19:12 |
| *** erlon has quit IRC | 19:12 | |
| gouthamr | ganso: look at an existing method: https://review.openstack.org/#/c/635831/5/manila/share/drivers/hitachi/hnas/driver.py@1417 | 19:12 |
| gouthamr | ganso: like a bulleted list, if you're breaking lines, push the text directly underneath where the description text begins in the previous line | 19:13 |
| ganso | gouthamr: hmm I'll try that in my local build | 19:13 |
| ganso | gouthamr: just a sec | 19:13 |
| *** raissa has joined #openstack-manila | 19:14 | |
| *** raissa has quit IRC | 19:14 | |
| *** raissa has joined #openstack-manila | 19:15 | |
| *** raissa has quit IRC | 19:15 | |
| ganso | gouthamr: fails /home/ganso/manila/manila/manila/share/drivers/hitachi/hnas/driver.py:docstring of manila.share.drivers.hitachi.hnas.driver.HitachiHNASDriver.manage_existing_snapshot:8:Unexpected indentation. | 19:15 |
| *** raissa has joined #openstack-manila | 19:16 | |
| gouthamr | ganso: strange, i typed description, but meant parameter | 19:17 |
| ganso | gouthamr: oh you mean shift the description as well? | 19:17 |
| ganso | gouthamr: ok it worked now | 19:17 |
| ganso | gouthamr: it need to have a blank line before :returns: | 19:18 |
| *** raissa has joined #openstack-manila | 19:18 | |
| *** raissa has quit IRC | 19:18 | |
| ganso | gouthamr: but I can't see the output in my PC, will have to push it | 19:18 |
| gouthamr | that's going to mess up the build though, you must check it | 19:18 |
| ganso | gouthamr: no I didn't shift the description | 19:19 |
| ganso | https://www.irccloud.com/pastebin/OFnExV0G/ | 19:19 |
| ganso | gouthamr: that's how it worked | 19:20 |
| gouthamr | ganso: yep, that looks correct | 19:20 |
| ganso | gouthamr: I said with the blank line, but I got it backwards, it is actually without the blank line | 19:21 |
| ganso | gouthamr: wait a minute, now both worked | 19:21 |
| ganso | gouthamr: just ran it again with the blank line, and it worked as well | 19:21 |
| gouthamr | ganso: blank line will work, just like in a bulleted list, but is unnecessary | 19:22 |
| gouthamr | ganso: your problem was with lining up the text to the name of the parameter | 19:22 |
| ganso | gouthamr: I am not sure what's going on, but I will only be able to confirm after I submit this | 19:22 |
| ganso | gouthamr: but it is weird that this is the only entry in the file that looks wrong, while all other ones look fine in the docs build, like a bulleted list, even though their indentation is not correct | 19:23 |
| ganso | gouthamr: thanks for the help, I will push a patch soon | 19:23 |
| ganso | gouthamr: =) | 19:24 |
| gouthamr | ganso: np, sure.. | 19:24 |
| openstackgerrit | Tom Barron proposed openstack/manila stable/pike: DNM - baseline run on stable/pike https://review.openstack.org/635920 | 19:26 |
| ganso | gouthamr: found what the real problem is | 19:29 |
| ganso | gouthamr: I reverted the indentation | 19:29 |
| ganso | gouthamr: it needed a blank line between the description paragraph and the first :param: | 19:29 |
| gouthamr | ganso: hmm, that's already there in https://www.irccloud.com/pastebin/OFnExV0G/ | 19:30 |
| ganso | gouthamr: I pasted what worked | 19:30 |
| ganso | gouthamr: I changed the indentation AND the blank line | 19:30 |
| ganso | gouthamr: and didn't realize that what made it work was the blank line below the description | 19:31 |
| gouthamr | ganso: makes sense | 19:32 |
| *** erlon has joined #openstack-manila | 19:40 | |
| *** eharney has quit IRC | 20:03 | |
| *** enriquetaso has quit IRC | 20:07 | |
| *** trident has quit IRC | 20:21 | |
| *** trident has joined #openstack-manila | 20:22 | |
| *** e0ne has joined #openstack-manila | 20:29 | |
| *** trident has quit IRC | 20:34 | |
| *** trident has joined #openstack-manila | 20:35 | |
| *** e0ne has quit IRC | 21:06 | |
| *** e0ne has joined #openstack-manila | 21:11 | |
| *** e0ne has quit IRC | 21:24 | |
| openstackgerrit | Tom Barron proposed openstack/manila stable/pike: Only run the needed services for CephFS jobs https://review.openstack.org/635887 | 22:10 |
| *** ganso has quit IRC | 22:17 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add tests for share type availability_zones extra-spec https://review.openstack.org/635703 | 22:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!