*** tosky has quit IRC | 00:02 | |
*** erlon has joined #openstack-manila | 00:14 | |
openstackgerrit | Tom Barron proposed openstack/manila master: Run cephfs jobs under py3 https://review.openstack.org/632521 | 00:35 |
---|---|---|
*** ganso has quit IRC | 00:49 | |
*** erlon has quit IRC | 01:20 | |
*** tinwood has quit IRC | 02:09 | |
*** tinwood has joined #openstack-manila | 02:11 | |
openstackgerrit | Merged openstack/manila master: Set mode for CephFS volumes and snapshots https://review.openstack.org/614332 | 03:51 |
*** arne_wiebalck_ has joined #openstack-manila | 05:20 | |
*** mmethot_ has joined #openstack-manila | 06:06 | |
*** _mmethot_ has quit IRC | 06:06 | |
*** mmethot_ has quit IRC | 06:12 | |
*** mmethot has joined #openstack-manila | 06:14 | |
*** arne_wiebalck_ has quit IRC | 06:22 | |
*** arne_wiebalck_ has joined #openstack-manila | 07:29 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: Allow configuring availability_zones in share types https://review.openstack.org/633155 | 07:50 |
*** e0ne has joined #openstack-manila | 07:56 | |
*** pcaruana has joined #openstack-manila | 08:10 | |
*** e0ne has quit IRC | 08:20 | |
*** arne_wiebalck_ has quit IRC | 08:34 | |
*** arne_wiebalck_ has joined #openstack-manila | 08:46 | |
*** tosky has joined #openstack-manila | 08:55 | |
*** arne_wiebalck_ has quit IRC | 08:59 | |
*** kaisers has quit IRC | 08:59 | |
*** mmethot has quit IRC | 09:23 | |
*** mmethot has joined #openstack-manila | 09:24 | |
*** kaisers has joined #openstack-manila | 09:37 | |
*** ganso has joined #openstack-manila | 09:44 | |
openstackgerrit | Tom Barron proposed openstack/manila stable/rocky: Set mode for CephFS volumes and snapshots https://review.openstack.org/633904 | 10:07 |
*** e0ne has joined #openstack-manila | 10:18 | |
*** erlon has joined #openstack-manila | 10:30 | |
openstackgerrit | Tom Barron proposed openstack/manila master: Run cephfs jobs under py3 https://review.openstack.org/632521 | 10:34 |
*** erlon has quit IRC | 10:55 | |
*** erlon has joined #openstack-manila | 10:56 | |
*** luizbag has joined #openstack-manila | 11:58 | |
*** lseki has joined #openstack-manila | 12:27 | |
*** e0ne has quit IRC | 12:48 | |
*** enriquetaso has joined #openstack-manila | 13:15 | |
openstackgerrit | Merged openstack/manila master: Fix pylint errors for ganesha manager https://review.openstack.org/633721 | 13:37 |
*** e0ne has joined #openstack-manila | 13:46 | |
*** pcaruana has quit IRC | 13:50 | |
*** pcaruana has joined #openstack-manila | 13:57 | |
*** arne_wiebalck_ has joined #openstack-manila | 14:01 | |
*** arne_wiebalck_ has quit IRC | 14:01 | |
*** arne_wiebalck_ has joined #openstack-manila | 14:04 | |
*** eharney has joined #openstack-manila | 14:08 | |
*** enriquetaso has quit IRC | 14:14 | |
*** enriquetaso has joined #openstack-manila | 14:35 | |
*** arne_wiebalck_ has quit IRC | 14:50 | |
*** pcaruana has quit IRC | 16:01 | |
*** carlos_silva has joined #openstack-manila | 16:01 | |
*** luizbag has quit IRC | 16:03 | |
*** lseki has quit IRC | 16:05 | |
*** lseki_ has joined #openstack-manila | 16:06 | |
*** luizbag has joined #openstack-manila | 16:10 | |
*** pcaruana has joined #openstack-manila | 16:17 | |
*** e0ne has quit IRC | 16:31 | |
*** e0ne has joined #openstack-manila | 16:31 | |
*** pcaruana has quit IRC | 16:45 | |
openstackgerrit | Maurice Schreiber proposed openstack/manila master: NetApp ONTAP: allow multiple DNS IPs https://review.openstack.org/558465 | 16:56 |
*** e0ne has quit IRC | 17:31 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila master: [CI] Drop redundant if condition in the LVM job playbook https://review.openstack.org/634014 | 17:35 |
tbarron | gouthamr: I can't remember the rationale for https://review.openstack.org/#/c/539186 but suspect it in combo with neutron tempest plugin install is causing | 17:48 |
tbarron | gouthamr: the current failure of 623061 | 17:48 |
gouthamr | tbarron: me neither, i thought it was a result of consultation with the QA/tempest team | 17:49 |
gouthamr | tbarron: ack, i'll take a look at how the other tempest plugins are being installed | 17:50 |
tbarron | http://logs.openstack.org/61/623061/10/check/manila-tempest-minimal-dsvm-lvm/6adc45e/job-output.txt.gz#_2019-01-29_23_23_31_331569 | 17:50 |
*** erlon has quit IRC | 17:50 | |
tbarron | gouthamr: I *think* the "normal" way is to install tempext under .tox/tempest but for some reason we don't do that ... | 17:52 |
tbarron | gouthamr: and all the tempest plugins | 17:52 |
gouthamr | tbarron: you mean use tempest's tox runner instead of the bin/tempest utility | 17:52 |
tbarron | gouthamr: yes | 17:52 |
gouthamr | makes sense with the whole push to standardize testing that we'd do that | 17:53 |
*** pcaruana has joined #openstack-manila | 18:17 | |
*** mmethot has quit IRC | 18:30 | |
*** mmethot has joined #openstack-manila | 18:30 | |
openstackgerrit | Tom Barron proposed openstack/manila stable/rocky: Add Ubuntu Bionic CephFS jobs https://review.openstack.org/634028 | 18:46 |
openstackgerrit | Tom Barron proposed openstack/manila stable/rocky: Set mode for CephFS volumes and snapshots https://review.openstack.org/633904 | 18:48 |
*** mmethot has quit IRC | 18:55 | |
*** e0ne has joined #openstack-manila | 19:06 | |
*** carlos_silva has quit IRC | 19:11 | |
*** luizbag has quit IRC | 19:17 | |
gouthamr | o/ tbarron | 19:26 |
gouthamr | i had a pre-emptive question about how we're treating "invalid" keys in API micro-versions prior to the version in which they're introduced | 19:28 |
gouthamr | this one for instance: https://github.com/openstack/manila/blob/3355dd0915a75cee730cbdd13b05b2e9c208d2aa/manila/api/v2/share_types.py#L132 | 19:28 |
*** erlon has joined #openstack-manila | 19:29 | |
tbarron | gouthamr: are we inconsistent? | 19:29 |
gouthamr | wondering if we should continue following that style -> i.e, raise 400 BadRequest on older microversions -> i hate it because it upsets the idea of micro-versions | 19:29 |
gouthamr | tbarron: yes :( see https://github.com/openstack/manila/blob/3355dd0915a75cee730cbdd13b05b2e9c208d2aa/manila/api/v2/shares.py#L188 | 19:30 |
tbarron | so raise 400 vs tolerate and ignore, right? | 19:31 |
gouthamr | yes | 19:31 |
tbarron | and this is a question we go around and around on ... | 19:31 |
tbarron | right? | 19:31 |
gouthamr | yes :( | 19:31 |
gouthamr | because i'm about to introduce another one :( | 19:32 |
tbarron | gouthamr: you and bswartz are a lot smarter on microversions and api compatability stuff than I am -- do you two agree on the tolerate and ignore policy? | 19:33 |
*** mmethot has joined #openstack-manila | 19:33 | |
gouthamr | thanks tbarron, i think we pushed the discussion over our last disagreement because we thought we'd land the json schema validation change and fix all these problems | 19:34 |
tbarron | gouthamr: we agreed that at and after we land json schema we can use it to throw errors when garbage (in the form of stuff that would be valid at a later microversion) is presented | 19:36 |
tbarron | gouthamr: but that before that microversion (still in the future) we tolerate and ignore | 19:36 |
gouthamr | tbarron: nice, thank you - that sounds sane | 19:37 |
tbarron | ganso raised the question again a while ago and that's what we re-enforced | 19:37 |
tbarron | cinder got into a bit of backwards-incompatability trouble by enforcing api schema retroactively. | 19:38 |
tosky | maybe not relevant, but did you ask the API SIG about the "proper" way of handling this? | 19:38 |
gouthamr | tbarron: so can i change the behavior here for the "extra_specs" key? I can log a message and introduce a user-message that the filter is being ignored | 19:38 |
tbarron | tosky: well goutamr is our api sig liaison :) | 19:38 |
tbarron | tosky: but I think mostly we just follwd the conversation about cinder's experience with json query validation | 19:39 |
gouthamr | tosky: i did, a while ago, and the answer was land strict schema validation ASAP, and don't touch older API versions | 19:39 |
tbarron | gouthamr: meta-backwards-incompatability :) but yes, it was a bug that it was enforcing rather than toleratiing and ignoring | 19:40 |
tbarron | tolerating | 19:41 |
openstackgerrit | Nir Gilboa proposed openstack/manila-tempest-plugin master: Scenario test: Create/manage share and write data https://review.openstack.org/545695 | 19:52 |
openstackgerrit | Nir Gilboa proposed openstack/manila-tempest-plugin master: Scenario test: Create/manage share and write data https://review.openstack.org/545695 | 20:00 |
gouthamr | actually, my concern may be invalid | 20:04 |
*** e0ne has quit IRC | 20:05 | |
gouthamr | tbarron: since i'm actually changing the behavior of a extra-spec itself, i think i am not introducing a new behavior/incompatibility | 20:05 |
gouthamr | extra-specs are meant to be loose admin-defined key-value pairs | 20:06 |
*** nirg22 has joined #openstack-manila | 20:06 | |
*** eharney has quit IRC | 20:06 | |
*** erlon has quit IRC | 20:12 | |
*** e0ne has joined #openstack-manila | 20:17 | |
*** e0ne has quit IRC | 20:19 | |
openstackgerrit | Merged openstack/manila master: [CI] Drop redundant if condition in the LVM job playbook https://review.openstack.org/634014 | 20:20 |
bswartz | tbarron: I'm having a hard time getting context on your ping | 20:31 |
bswartz | My opinion is that you shouldn't tolerate and ignore | 20:31 |
tbarron | bswartz: and we've decided that at a microversion when validation is introduced we can start doing that | 20:32 |
bswartz | k | 20:32 |
tbarron | bswartz: unfort the json query validation appears to have lost steam but | 20:32 |
tbarron | bswartz: I'd like to get it moving again and then we can enforce from then on | 20:33 |
bswartz | Yeah we need to get real validation, and then raise the microversion | 20:34 |
*** nirg22 has quit IRC | 20:38 | |
*** e0ne has joined #openstack-manila | 20:48 | |
*** eharney has joined #openstack-manila | 21:07 | |
*** e0ne has quit IRC | 21:18 | |
*** e0ne has joined #openstack-manila | 21:47 | |
*** openstackgerrit has quit IRC | 21:50 | |
*** e0ne has quit IRC | 21:58 | |
*** ganso has quit IRC | 22:01 | |
*** erlon has joined #openstack-manila | 22:32 | |
*** erlon has quit IRC | 23:35 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!