Friday, 2019-01-18

« Thursday, 2019-01-17 Index Saturday, 2019-01-19 »
*** erlon has quit IRC01:38
*** mmethot_ has joined #openstack-manila01:51
*** tridde has joined #openstack-manila01:57
*** mmethot has quit IRC02:00
*** trident has quit IRC02:00
*** openstackgerrit has quit IRC02:02
*** baojg has joined #openstack-manila02:10
*** tridde is now known as trident03:06
*** vollman has joined #openstack-manila03:42
*** zul has quit IRC03:42
*** pcaruana has joined #openstack-manila07:25
*** kaisers_ has joined #openstack-manila07:26
*** arne_wiebalck has quit IRC07:43
*** arne_wiebalck has joined #openstack-manila07:43
*** arne_wiebalck_ has joined #openstack-manila07:44
*** arne_wiebalck_ has quit IRC07:48
*** arne_wiebalck_ has joined #openstack-manila07:51
*** pcaruana has quit IRC07:55
*** pcaruana has joined #openstack-manila07:55
*** openstackgerrit has joined #openstack-manila08:23
openstackgerritGoutham Pacha Ravi proposed openstack/python-manilaclient master: [CI] Fix logs for the functional test job  https://review.openstack.org/63146008:23
*** kaisers_ is now known as kaisers_away08:40
*** kaisers_away is now known as kaisers_08:42
openstackgerritMerged openstack/python-manilaclient master: Convert functional tests to python3  https://review.openstack.org/62953608:50
*** e0ne has joined #openstack-manila08:55
*** a-pugachev has joined #openstack-manila09:12
*** luizbag has joined #openstack-manila09:38
openstackgerritTobias Urdin proposed openstack/puppet-manila master: Remove redundantly tested code  https://review.openstack.org/63174409:42
*** kaisers_ is now known as kaisers_away09:44
*** kaisers_away is now known as kaisers_09:45
*** kaisers_ is now known as kaisers_away09:45
*** ganso has joined #openstack-manila09:48
*** kaisers_away is now known as kaisers_10:44
*** kaisers_ is now known as kaisers_away10:44
*** erlon has joined #openstack-manila11:05
*** a-pugachev has quit IRC11:21
*** erlon_ has joined #openstack-manila11:21
*** a-pugachev has joined #openstack-manila11:21
*** erlon has quit IRC11:24
*** kaisers_away is now known as kaisers_11:42
*** kaisers_ is now known as kaisers_away11:42
*** kaisers_away is now known as kaisers_12:18
*** kaisers_ has quit IRC12:25
*** e0ne has quit IRC12:33
*** e0ne has joined #openstack-manila12:39
*** e0ne has quit IRC12:40
*** e0ne has joined #openstack-manila12:40
*** a-pugachev has quit IRC12:40
*** zul has joined #openstack-manila13:41
*** a-pugachev has joined #openstack-manila13:48
*** a-pugachev has quit IRC13:52
*** a-pugachev has joined #openstack-manila13:52
*** eharney has joined #openstack-manila13:58
*** arne_wiebalck_ has quit IRC13:59
*** arne_wiebalck_ has joined #openstack-manila14:00
*** zul has quit IRC14:01
*** zul has joined #openstack-manila14:22
*** zul has quit IRC15:00
*** arne_wiebalck_ has quit IRC15:21
tbarronbswartz: do you know how the tagged images at http://tarballs.openstack.org/manila-image-elements/images/ were created?  current job just makes the a qcow2 on master/HEAD ...15:57
tbarronbswartz: which is typically untagged15:57
bswartzThe post job is supposed to look for a tag and name the file appropriately15:58
tbarronbswartz: but there typically won't be a tag, right?15:58
bswartzRight15:58
bswartzThe intention is that every tagged release gets a unique filename that will never get overwritten15:59
bswartzOrdinary commits overwrite the last file from the same branch name15:59
bswartzSo there should be one image for every tag, and 1 image for the latest commit from each branch15:59
*** pcaruana has quit IRC16:00
tbarronbswartz: so when we do a *release* for manila-image-elements *that* job should be doing this16:00
tbarronthe release job16:00
bswartzWell it's the same job IIRC16:00
tbarronhmm16:00
bswartzUnless they've changed stuff16:00
tbarronit's broken16:00
tbarronthere's some JJB variables that appear to be intended to do this but they don't work in zuulv316:00
tbarronwe get names like: manila-service-image-refs-heads-master.qcow216:01
bswartzYeah, I imagine it broke in the migration16:01
tbarronprob the refs-heads- were supposed to be tag-like16:01
tbarrondo you know a git command that would get what we want here?16:02
bswartzI think we should be looking for another project that pushes similar artifacts and copy what they're doing16:02
tbarronmostly I'm just going to have manila-service-image.qcow2 show up in tarballs.o.o as images/manila-service-image-master.qcow216:03
tbarronbswartz: yeah, I've been looking, haven't found one that uses tags yet16:03
bswartzThis was one of those things that vponomaryov did initially, and then I tried to keep hacking it to keep it in shape16:03
bswartzBut I never really had a good idea of what was going on in the infrastructure16:04
tbarronk, thanks, I'll keep poking around16:04
bswartzDid you ask in the infra channel?16:05
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila master: Deploy manila with uwsgi on devstack  https://review.openstack.org/63133816:12
*** e0ne has quit IRC16:22
*** zul has joined #openstack-manila16:34
*** a-pugachev has quit IRC16:58
*** a-pugachev has joined #openstack-manila16:59
*** a-pugachev has quit IRC17:29
openstackgerritTom Barron proposed openstack/manila-image-elements master: DNM - experimenting with zuulv3 conversion  https://review.openstack.org/63184617:41
*** erlon_ has quit IRC17:41
gansotbarron:  ping17:51
tbarrondganspong17:53
gansotbarron: hey Tom17:54
tbarronbswartz: I did ask in infra and am making some progress17:54
gansotbarron: quick question17:54
tbarronganso: hi17:54
gansotbarron: I remember seeing a recent patch from you updating how our pylint runs17:54
gansotbarron: since then, pylint in our internal CI and running manually in our PC fails with false positives17:54
gansosuch as17:54
tbarronganso: hmm, don't think that was me17:54
* tbarron looks17:55
gansotbarron: manila/tests/share/test_manager.py:4431:12: E1101: Method 'migration_start' has no 'assert_called_once_with' member (no-member)17:55
gansotbarron: I could be wrong about the person, thought it was you, but I remember seeing a patch merging in manila17:55
tbarronyeah I think there were some changes, sec17:55
gansotbarron: I would like to ask if you've seen this kind of error before17:56
gansotbarron: also, we get several import errors now, and we need to install mock and ddt manually in virtualenv17:56
gansotbarron: for some reason when we run tox -epylint -vv, even after deleting .tox folder to force it to re-download everything, it doesn't install mock and ddt17:57
tbarronganso: 'git log --oneline | grep lint'17:57
tbarronganso: are you thinking of 4d0abb4a149eea597e51f79c8e76d9d2284d65ee17:57
gansopossibly17:58
tbarronganso: or 4c943fbcb25f4d4f8e2e9d8b77f0e389bed13c8b ?17:58
gansoI'm not sure17:58
ganso4c!17:58
gansoyea, that's the one17:58
gansoI did not see the other one17:59
gansobut 4d could be the culprit17:59
tbarronganso: if you git reset to the change before 4c... then the issue goes away?17:59
gansoI'll try that, hold on a minute17:59
tbarronor before 4d ..;17:59
gansotbarron: it will take some time, I deleted .tox folder again to be sure18:01
gansotbarron: but the funny thing is, it runs fine in the gate18:02
openstackgerritTom Barron proposed openstack/manila-image-elements master: DNM - experimenting with zuulv3 conversion  https://review.openstack.org/63184618:13
gansotbarron: it seems was the culprit is 4d0abb4a149eea597e51f79c8e76d9d2284d65ee18:19
gansos/was/18:22
*** luizbag has quit IRC18:25
*** erlon_ has joined #openstack-manila18:36
*** erlon_ has quit IRC18:48
*** zul has quit IRC19:03
openstackgerritGoutham Pacha Ravi proposed openstack/python-manilaclient master: [CI] Fix logs for the functional test job  https://review.openstack.org/63146019:05
gansotbarron: ok I am further isolating the issue to the fact that my pylint is reading .pylintrc, but is ignoring the disable list19:22
gansotbarron: the disable list includes all errors I am seeing19:22
tbarronganso: I'll try running it locally myself19:28
*** e0ne has joined #openstack-manila19:29
tbarronganso: running on a local f29 machine i get: https://paste.fedoraproject.org/paste/woRg0AAj4G~zLsCv9FiLDg19:33
tbarronganso: does that match?19:34
gansotbarron: yes! you have the same problem19:34
gansotbarron: now we need to find out how it works in the gate19:35
tbarronganso: agree19:36
*** zul has joined #openstack-manila19:36
*** zul has left #openstack-manila19:37
openstackgerritTom Barron proposed openstack/manila-image-elements master: DNM - experimenting with zuulv3 conversion  https://review.openstack.org/63184619:43
gansotbarron: this -E is overriding the error list set in .pylintrc https://github.com/openstack/manila/commit/4d0abb4a149eea597e51f79c8e76d9d2284d65ee#diff-5c6aaf64256305adfaeb255b4a7a7a90R4019:46
gansotbarron: removing it makes it work19:47
gansotbarron: although, I am not sure if the behavior becomes the same as the gate19:47
gansotbarron: our gate is broken too http://logs.openstack.org/60/499560/7/check/openstack-tox-pylint/264d307/job-output.txt.gz19:51
gansotbarron: I was checking the logs of stable branches <facepalm/>19:51
gansotbarron: that's why it was working19:51
tbarronganso: so probably there are some issues in master that it's catching and that we need to fix?19:53
gansotbarron: so, that commit actually broke our pylint, and we have not noticed until now19:53
gansotbarron: yea there are 2 ways we can look at this19:53
tbarronganso: :)19:53
gansotbarron: 1) that patch made our pylint too restrictive. I was able to fix one of the messages by changing the mock statement to one that causes it to not complain anymore19:53
gansotbarron: so we could just fix all the problems, which are far too many19:54
gansotbarron: or we could just customize our pylint to be less restrictive, as it was before19:54
tbarronganso: stable are working only b/c we didn't backport it.  I wonder if chuck short was planning on opening bugs on these issues ?19:54
ganso*2)or we could just customize our pylint to be less restrictive, as it was before19:55
gansotbarron: yea, I don't know19:55
gansotbarron: there are literally thousands of errors to address19:55
gansotbarron: and they are very stupid19:55
gansotbarron: for example: "self.mock_object(db, 'share_server_backend_details_set')" and "db.share_server_backend_details_set.assert_called_once_with" generate an error19:56
gansotbarron: but,19:56
gansotbarron: "self.mock_object(self.manager.db, 'share_server_backend_details_set')" and "self.manager.db.share_server_backend_details_set.assert_called_once_with" fix the error19:57
gansotbarron: it is just how you mock. The unit tests work either way19:57
gansotbarron: and that kind of thing is everywhere19:57
tbarronganso: sounds lik a meeting topic, probably should try to get chuck there ...19:58
gansotbarron: good idea20:00
*** erlon_ has joined #openstack-manila20:30
*** erlon_ has quit IRC20:46
*** e0ne has quit IRC20:55
*** carlos_silva has quit IRC21:21
openstackgerritTom Barron proposed openstack/manila-image-elements master: DNM - experimenting with zuulv3 conversion  https://review.openstack.org/63184621:39
openstackgerritTom Barron proposed openstack/manila-image-elements master: DNM - experimenting with zuulv3 conversion  https://review.openstack.org/63184622:10
openstackgerritTom Barron proposed openstack/manila-image-elements master: DNM - experimenting with zuulv3 conversion  https://review.openstack.org/63184622:11
*** eharney has quit IRC22:40
openstackgerritTom Barron proposed openstack/manila-image-elements master: DNM - experimenting with zuulv3 conversion  https://review.openstack.org/63184622:51
*** ganso has quit IRC23:06
openstackgerritTom Barron proposed openstack/manila-image-elements master: DNM - experimenting with zuulv3 conversion  https://review.openstack.org/63184623:50
« Thursday, 2019-01-17 Index Saturday, 2019-01-19 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!