| openstackgerrit | zhongjun proposed openstack/manila master: Support metadata for access rule resource https://review.openstack.org/570708 | 02:04 |
|---|---|---|
| openstackgerrit | zhongjun proposed openstack/manila master: Add priority for access rule https://review.openstack.org/572283 | 02:17 |
| *** jmlowe has quit IRC | 02:35 | |
| *** rishabh_ has joined #openstack-manila | 03:38 | |
| *** rishabh__ has joined #openstack-manila | 03:55 | |
| *** rishabh_ has quit IRC | 03:58 | |
| *** rishabh_ has joined #openstack-manila | 04:01 | |
| *** rishabh__ has quit IRC | 04:03 | |
| *** vivsoni_ has joined #openstack-manila | 04:38 | |
| *** vivsoni has quit IRC | 04:38 | |
| *** vivsoni has joined #openstack-manila | 04:41 | |
| *** vivsoni_ has quit IRC | 04:43 | |
| openstackgerrit | zhongjun proposed openstack/manila master: Add priority for access rule https://review.openstack.org/572283 | 05:15 |
| *** e0ne has joined #openstack-manila | 05:16 | |
| *** e0ne has quit IRC | 05:18 | |
| *** arnewiebalck___ is now known as arnewiebalck_ | 05:31 | |
| *** arnewiebalck_ has quit IRC | 05:33 | |
| *** markstur has joined #openstack-manila | 05:59 | |
| *** markstur has quit IRC | 06:04 | |
| *** belmoreira has joined #openstack-manila | 06:19 | |
| *** belmorei_ has joined #openstack-manila | 06:24 | |
| *** belmore__ has joined #openstack-manila | 06:26 | |
| *** belmoreira has quit IRC | 06:28 | |
| *** belmorei_ has quit IRC | 06:29 | |
| *** vivsoni_ has joined #openstack-manila | 06:58 | |
| *** vivsoni has quit IRC | 06:59 | |
| *** markstur has joined #openstack-manila | 07:02 | |
| *** vivsoni has joined #openstack-manila | 07:02 | |
| *** belmoreira has joined #openstack-manila | 07:04 | |
| *** vivsoni_ has quit IRC | 07:04 | |
| *** belmore__ has quit IRC | 07:05 | |
| *** markstur has quit IRC | 07:06 | |
| *** dsariel has joined #openstack-manila | 07:23 | |
| *** peereb has joined #openstack-manila | 07:25 | |
| *** e0ne has joined #openstack-manila | 07:27 | |
| *** belmoreira has quit IRC | 07:40 | |
| *** belmoreira has joined #openstack-manila | 07:56 | |
| openstackgerrit | zhongjun proposed openstack/manila master: Support metadata for access rule resource https://review.openstack.org/570708 | 08:04 |
| *** dsariel has quit IRC | 08:04 | |
| *** rraja has joined #openstack-manila | 08:06 | |
| *** dsariel has joined #openstack-manila | 08:19 | |
| *** dsariel has quit IRC | 08:51 | |
| *** dsariel has joined #openstack-manila | 08:51 | |
| *** dsariel has quit IRC | 09:02 | |
| *** hoonetorg has quit IRC | 09:27 | |
| *** belmoreira has quit IRC | 09:31 | |
| openstackgerrit | zhongjun proposed openstack/manila-tempest-plugin master: Add tempest test for share access metadata https://review.openstack.org/579534 | 09:38 |
| *** hoonetorg has joined #openstack-manila | 09:40 | |
| *** belmoreira has joined #openstack-manila | 10:19 | |
| openstackgerrit | zhongjun proposed openstack/manila-tempest-plugin master: Add tempest test for share access metadata https://review.openstack.org/579534 | 10:49 |
| *** erlon has joined #openstack-manila | 10:51 | |
| *** ganso has joined #openstack-manila | 10:53 | |
| openstackgerrit | zhongjun proposed openstack/manila-tempest-plugin master: Add tempest test for share access metadata https://review.openstack.org/579534 | 10:53 |
| *** dsariel has joined #openstack-manila | 11:04 | |
| openstackgerrit | TommyLike proposed openstack/python-manilaclient master: Add "start_version" and "end_version" support to argparse https://review.openstack.org/582160 | 11:46 |
| openstackgerrit | TommyLike proposed openstack/python-manilaclient master: Add "start_version" and "end_version" support to argparse https://review.openstack.org/582160 | 11:48 |
| *** belmorei_ has joined #openstack-manila | 11:53 | |
| *** belmoreira has quit IRC | 11:55 | |
| *** tpsilva has joined #openstack-manila | 12:03 | |
| *** belmorei_ has quit IRC | 12:09 | |
| *** dustins has joined #openstack-manila | 12:10 | |
| *** belmorei_ has joined #openstack-manila | 12:10 | |
| *** vgreen has joined #openstack-manila | 12:16 | |
| *** belmorei_ has quit IRC | 12:32 | |
| *** assassin has joined #openstack-manila | 12:46 | |
| openstackgerrit | TommyLike proposed openstack/python-manilaclient master: Add "start_version" and "end_version" support to argparse https://review.openstack.org/582160 | 13:03 |
| *** belmoreira has joined #openstack-manila | 13:08 | |
| *** rishabh_ has quit IRC | 13:49 | |
| openstackgerrit | zhongjun proposed openstack/manila-tempest-plugin master: Add tempest test for share access metadata https://review.openstack.org/579534 | 13:50 |
| *** belmorei_ has joined #openstack-manila | 13:56 | |
| *** belmore__ has joined #openstack-manila | 13:58 | |
| *** belmoreira has quit IRC | 14:00 | |
| *** belmorei_ has quit IRC | 14:01 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: [NetApp driver] Control snapshot folder visibility https://review.openstack.org/581068 | 14:09 |
| *** eharney has joined #openstack-manila | 14:12 | |
| *** belmore__ has quit IRC | 14:36 | |
| openstackgerrit | zhongjun proposed openstack/python-manilaclient master: Support metadata for access rule resource https://review.openstack.org/571366 | 14:37 |
| openstackgerrit | zhongjun proposed openstack/python-manilaclient master: Support metadata for access rule resource https://review.openstack.org/571366 | 14:41 |
| *** e0ne has quit IRC | 14:59 | |
| tbarron | meeting time | 15:00 |
| *** jmlowe has joined #openstack-manila | 15:02 | |
| *** erlon_ has joined #openstack-manila | 15:02 | |
| *** markstur has joined #openstack-manila | 15:18 | |
| *** rraja has quit IRC | 15:30 | |
| *** e0ne has joined #openstack-manila | 15:40 | |
| *** dustins_ has joined #openstack-manila | 15:43 | |
| *** peereb has quit IRC | 15:45 | |
| *** dustins has quit IRC | 15:47 | |
| *** markstur has quit IRC | 15:47 | |
| *** jmlowe has quit IRC | 15:47 | |
| *** markstur has joined #openstack-manila | 15:49 | |
| *** markstur has quit IRC | 15:49 | |
| *** markstur has joined #openstack-manila | 15:50 | |
| bswartz | (12:00:07 PM) bswartz: So the challenge is that the schema isn't written down anywhere, and writing it is a lot of work? | 16:00 |
| gouthamr | bswartz: yep, we've not written the schema outside of the api-ref | 16:01 |
| bswartz | It's sad state of affairs if we can't get someone to write the whole schema in 1 release | 16:01 |
| bswartz | That seems like a pretty basic thing | 16:01 |
| bswartz | I realize the final document will be 1000 lines probably | 16:01 |
| tbarron | bswartz: well we just started reviewing their submission very recently | 16:02 |
| bswartz | Or more | 16:02 |
| tbarron | bswartz: and these NEC folks know the infra for json query validation very well but are | 16:02 |
| bswartz | But it's something we really need, and in fact have needed for a lont time | 16:02 |
| tbarron | likely just studying manila api as they go along | 16:02 |
| bswartz | I suppose the versioning complicates the effort | 16:02 |
| bswartz | Because you need a slightly different schema at each version | 16:02 |
| tbarron | yeah | 16:03 |
| zhongjun__ | Do we have to finish all schema work in this cycle | 16:03 |
| gouthamr | bswartz: true, they've "simplified" this in the implementation proposed, and it looks a lot like writing out our API-ref with os-api-ref | 16:03 |
| gouthamr | https://review.openstack.org/#/c/563429/9/manila/api/schemas/share_types.py as an example | 16:04 |
| tbarron | getting the schema validation infra in and a good example for an api or two (at all microversions) would be a good beach head position though | 16:04 |
| bswartz | I suppose so | 16:04 |
| gouthamr | yes, i had a compromise for zhongjun__'s APIs | 16:04 |
| bswartz | If it must be done incrementally, then getting starting is better than not getting started | 16:05 |
| gouthamr | +1 | 16:05 |
| *** dustins_ has quit IRC | 16:06 | |
| gouthamr | i think zhongjun__ can implement strict validation in the APIs she's modifying from the new microversion she's bumping them to | 16:06 |
| gouthamr | she doesn't need the json validation code | 16:06 |
| tbarron | gouthamr: so does this patch do the right thing from your POV w.r.t. 'description' at v 26 vs 27? | 16:06 |
| tbarron | I mean at 241? | 16:07 |
| gouthamr | it'd be a simple check-keys-in-body from 2.46, raise 400 error if extra-keys | 16:07 |
| gouthamr | don't do anything with those keys if less than 2.46 | 16:07 |
| gouthamr | tbarron: as far as i understand it does, i need to test it to confirm | 16:07 |
| tbarron | gouthamr: when I was testing it threw and error at the lower microversion | 16:08 |
| tbarron | gouthamr: but I lost a week and a half context, will set it up again soon | 16:08 |
| gouthamr | if zhongjun__ implements this simple validation, we can layer the JSON schema validation on top of that | 16:08 |
| tbarron | gouthamr: but if I'm right about what it does it shouldn't be a big deal to change the action to ignore at the lower microversion in these schema | 16:09 |
| gouthamr | tbarron: oh.. yep, let's confirm | 16:09 |
| * tbarron also wonders whether, api philosophy aside, it's worth checking what nova and cinder do in this circumstance | 16:10 | |
| gouthamr | +1 | 16:11 |
| tbarron | it's true that we want manila to *be able* to stand alone, but we may not want it to *stand out* anomalous w.r.t. operator microversion expectations | 16:12 |
| tbarron | and gophercloud, etc :D | 16:12 |
| * tbarron heads off to lunch | 16:13 | |
| tbarron | and recommends that gouthamr get breakfast and zhongjun__ a nightcap | 16:13 |
| gouthamr | tbarron++ | 16:18 |
| *** e0ne has quit IRC | 16:20 | |
| *** e0ne has joined #openstack-manila | 16:23 | |
| *** e0ne has quit IRC | 16:23 | |
| *** assassin has quit IRC | 16:25 | |
| openstackgerrit | zhongjun proposed openstack/manila master: Support metadata for access rule resource https://review.openstack.org/570708 | 16:26 |
| zhongjun__ | tbarron: :P | 16:27 |
| *** e0ne has joined #openstack-manila | 16:41 | |
| *** e0ne has quit IRC | 16:43 | |
| *** dsariel has quit IRC | 16:52 | |
| *** rraja has joined #openstack-manila | 18:19 | |
| *** jmlowe has joined #openstack-manila | 18:24 | |
| *** harlowja has joined #openstack-manila | 18:24 | |
| *** e0ne has joined #openstack-manila | 18:42 | |
| *** e0ne_ has joined #openstack-manila | 18:47 | |
| *** e0ne has quit IRC | 18:47 | |
| *** e0ne has joined #openstack-manila | 18:51 | |
| *** e0ne_ has quit IRC | 18:52 | |
| *** e0ne has quit IRC | 18:54 | |
| *** e0ne_ has joined #openstack-manila | 18:54 | |
| *** e0ne_ has quit IRC | 18:56 | |
| *** erlon_ has quit IRC | 19:11 | |
| *** e0ne has joined #openstack-manila | 19:12 | |
| *** e0ne has quit IRC | 19:23 | |
| *** vgreen has quit IRC | 19:28 | |
| *** e0ne has joined #openstack-manila | 19:31 | |
| *** e0ne_ has joined #openstack-manila | 19:34 | |
| *** e0ne has quit IRC | 19:36 | |
| *** dustins has joined #openstack-manila | 19:37 | |
| *** e0ne_ has quit IRC | 19:41 | |
| *** eharney has quit IRC | 19:46 | |
| *** markstur_ has joined #openstack-manila | 19:50 | |
| *** markstur has quit IRC | 19:54 | |
| *** e0ne has joined #openstack-manila | 19:55 | |
| *** e0ne has quit IRC | 19:59 | |
| *** e0ne has joined #openstack-manila | 20:03 | |
| *** erlon has quit IRC | 20:07 | |
| *** e0ne has quit IRC | 20:07 | |
| *** e0ne has joined #openstack-manila | 20:13 | |
| *** e0ne has quit IRC | 20:18 | |
| *** e0ne has joined #openstack-manila | 20:21 | |
| *** e0ne_ has joined #openstack-manila | 20:27 | |
| *** e0ne has quit IRC | 20:28 | |
| *** belmoreira has joined #openstack-manila | 20:30 | |
| *** e0ne_ has quit IRC | 20:31 | |
| *** e0ne has joined #openstack-manila | 20:35 | |
| *** belmoreira has quit IRC | 20:36 | |
| *** e0ne has quit IRC | 20:42 | |
| *** e0ne has joined #openstack-manila | 20:48 | |
| *** e0ne has quit IRC | 20:50 | |
| *** rraja has quit IRC | 20:56 | |
| *** rraja has joined #openstack-manila | 20:56 | |
| *** dustins has quit IRC | 21:02 | |
| *** e0ne has joined #openstack-manila | 21:27 | |
| *** e0ne has quit IRC | 21:39 | |
| *** e0ne has joined #openstack-manila | 21:59 | |
| *** boris_42_ has joined #openstack-manila | 22:08 | |
| *** rraja has quit IRC | 22:17 | |
| *** rraja has joined #openstack-manila | 22:21 | |
| *** ganso has quit IRC | 22:27 | |
| *** e0ne has quit IRC | 22:32 | |
| *** rraja has quit IRC | 22:33 | |
| gouthamr | tbarron: you're right about the schema validation patch | 22:39 |
| gouthamr | it doesn't ignore unknown keys, it returns 400 even for older microversions | 22:40 |
| *** tpsilva has quit IRC | 23:01 | |
| tbarron | gouthamr: yeah, good comment in the review | 23:03 |
| tbarron | gouthamr: json schema validation is already in cinder and nova, dyk what they do in this circumstance? | 23:03 |
| gouthamr | tbarron: i pointed to a patch in cinder from the set that seem to be worked on this release: https://review.openstack.org/#/q/message:%255Ejsonschema+project:openstack/cinder | 23:04 |
| tbarron | gouthamr: and do they raise 400 for earlier microversions? | 23:07 |
| gouthamr | inconsistently as it appears from code-reading | 23:07 |
| tbarron | s/raise/return/400/ | 23:07 |
| tbarron | gouthamr: so maybe this needs to be a cross-project issue? | 23:07 |
| tbarron | I'd like manila to do the right thing but I also want us to be drivers of uniform user experience in openstack rather than being an anomaly | 23:08 |
| gouthamr | tbarron: agreed, i'll check out what's the pattern here, i don't see an API sig spec in flight | 23:10 |
| tbarron | gouthamr++ | 23:12 |
| *** erlon has joined #openstack-manila | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!