Thursday, 2017-12-07

« Wednesday, 2017-12-06 Index Friday, 2017-12-08 »
*** aspiers[m] has joined #openstack-manila00:07
*** junboli has joined #openstack-manila01:04
*** caowei has joined #openstack-manila01:36
openstackgerritMerged openstack/manila master: QNAP: Add support for QES 1.1.4  https://review.openstack.org/52301702:02
*** markstur has quit IRC02:03
*** harlowja has quit IRC02:22
*** markstur has joined #openstack-manila02:51
*** markstur has quit IRC03:16
*** threestrands has joined #openstack-manila03:52
*** threestrands has quit IRC03:52
*** threestrands has joined #openstack-manila03:52
*** markstur has joined #openstack-manila03:58
*** markstur_ has joined #openstack-manila04:01
*** markstu__ has joined #openstack-manila04:02
*** markstur has quit IRC04:04
*** markstur_ has quit IRC04:06
*** junboli has quit IRC04:32
*** harlowja has joined #openstack-manila04:39
*** caowei has quit IRC05:12
*** gouthamr has quit IRC05:24
*** junboli has joined #openstack-manila05:25
*** harlowja has quit IRC05:30
*** sticker has quit IRC05:32
*** caowei has joined #openstack-manila05:39
*** markstu__ has quit IRC06:02
*** markstur has joined #openstack-manila06:03
*** markstur_ has joined #openstack-manila06:08
*** gcb has quit IRC06:08
*** gcb has joined #openstack-manila06:10
*** markstur has quit IRC06:12
*** AlexeyAbashkin has joined #openstack-manila06:15
*** AlexeyAbashkin has quit IRC06:26
*** threestrands has quit IRC06:32
*** caowei has quit IRC06:57
*** caowei has joined #openstack-manila06:57
*** markstur_ has quit IRC07:32
openstackgerritzhongjun proposed openstack/manila master: [Doc] Add admin doc for share group  https://review.openstack.org/50293607:45
*** AlexeyAbashkin has joined #openstack-manila08:07
*** caowei has quit IRC08:09
*** caowei has joined #openstack-manila08:09
*** rraja has joined #openstack-manila09:08
amitocan someone else please take a look at https://review.openstack.org/#/c/515432/ and trigger the gate jobs if everything is ok?09:11
*** ganso has joined #openstack-manila09:31
*** andreaf has quit IRC09:42
*** andreaf has joined #openstack-manila09:42
*** a-pugachev has joined #openstack-manila10:04
*** raissa has quit IRC10:22
*** dsariel has quit IRC10:28
*** gcb has quit IRC10:29
*** a-pugachev_ has joined #openstack-manila10:33
*** a-pugachev has quit IRC10:36
*** a-pugachev_ is now known as a-pugachev10:36
*** dsariel has joined #openstack-manila11:27
*** caowei has quit IRC12:00
tbarronamito: I'll review it today12:28
openstackgerritTom Barron proposed openstack/manila master: QNAP Manila driver: Access rule setting is override by the later access rule setting.  https://review.openstack.org/52552712:33
*** junboli has quit IRC12:39
*** dsariel has quit IRC13:01
*** erlon has joined #openstack-manila13:09
*** raissa has joined #openstack-manila13:11
tbarronamito: only a minor issue, but I think it should be fixed before we merge13:14
amitotbarron: thx, I'll fix it soon. We don't support ipv6 atm. What should the exception in l88 be? ShareBackendException?13:25
tbarronamito: the ipv6 question was just my curiosity.  Yeah, I think ShareBackendException with a good message would be appropriate.13:26
openstackgerritOpenStack Proposal Bot proposed openstack/manila master: Updated from global requirements  https://review.openstack.org/52538213:29
*** dustins has joined #openstack-manila13:46
*** raissa has quit IRC13:48
*** dsariel has joined #openstack-manila13:51
amitotbarron: about the doc, what should I do so the two bullets won't be rendered on the same line?14:12
*** AlexeyAbashkin has quit IRC14:12
tbarronamito: I don't know right off but will try asking my friend google in a bit.14:13
* tbarron is better at seeing things that need fixing than at fixing them.14:14
amitotbarron: lol :) according to sphinx doc that's the right way to do it14:14
tbarronamito: just submit again w/o that part fixed; we can do it as a followup if need be14:15
tbarronamito: I put "outstanding driver work" on the agenda today, we should merge this one today I think14:15
*** dsariel has quit IRC14:15
amitotbarron: thanks! btw, how can I build this doc locally?14:16
tbarronamito: ah, now I can actually help :-) Run 'tox -edocs'.  You can see the different things you can do with tox (which builds venvs for you so you don't pollute your local machine) by looking at tox.ini14:17
tbarronamito: you can run coverage, unit tests, build releasenotes, etc. too14:17
tbarronamito: and it's really a good idea to do a lot of this stuff locally since your get quicker turnaround and don't use upstream infra and reviewer time on stuff that you can catch yourself first.14:18
amitotbarron: thanks. fails on lxml version14:19
tbarronamito: although it's inevitable that there will be little things that don't get caught until upstream,14:19
tbarronamito: try 'rm -rf .tox; tox -edocs'14:19
tbarronamito: and if you have to, start with a brand newly cloned workspace and get it to run w/o your patches14:20
tbarronamito: what is your laptop OS?14:20
amitotbarron: it's OSX, but I found the reason, it was because I was running with our local company pypi and not the global (pypi.python.org) configured. now I'm using tox's -i flag and it seems to work.14:22
amitotbarron: I guess we don't have lxml 4.1.1 in our local pypi, should add that later.14:22
tbarronamito: ok, when you get that fixed give us your local pypi so we can mirror from it14:23
tbarronamito: just jokinig14:23
openstackgerritMerged openstack/manila master: Updated from global requirements  https://review.openstack.org/52538214:35
*** a-pugachev has quit IRC14:36
*** openstackgerrit has quit IRC14:48
*** dustins has quit IRC14:48
*** tinwood has quit IRC14:48
*** ameade has quit IRC14:48
*** logan- has quit IRC14:48
*** DuncanT has quit IRC14:48
*** wiggin15 has quit IRC14:48
*** yuval has quit IRC14:48
*** ChanServ has quit IRC14:48
*** chenying has quit IRC14:48
*** gnarld_ has quit IRC14:48
*** cargonza has quit IRC14:48
*** toabctl has quit IRC14:48
*** netapp has quit IRC14:48
*** masber has quit IRC14:48
*** hoonetorg has quit IRC14:48
*** zigo has quit IRC14:48
*** abhi has quit IRC14:48
*** erlon has quit IRC14:48
*** zhongjun has quit IRC14:48
*** tbarron has quit IRC14:48
*** rraja has quit IRC14:48
*** vkmc has quit IRC14:48
*** amito has quit IRC14:48
*** Reepicheep has quit IRC14:48
*** jiaopengju has quit IRC14:48
*** bswartz has quit IRC14:48
*** EmilienM has quit IRC14:48
*** sapcc-bot has quit IRC14:48
*** gregsfortytwo has quit IRC14:48
*** kfox1111 has quit IRC14:48
*** aspiers[m] has quit IRC14:51
*** wiggin15 has joined #openstack-manila14:54
*** tinwood has joined #openstack-manila14:54
*** ameade has joined #openstack-manila14:54
*** logan- has joined #openstack-manila14:54
*** DuncanT has joined #openstack-manila14:54
*** yuval has joined #openstack-manila14:54
*** chenying has joined #openstack-manila14:54
*** nug has joined #openstack-manila14:54
*** cargonza has joined #openstack-manila14:54
*** openstackgerrit has joined #openstack-manila14:54
*** gouthamr has joined #openstack-manila14:54
*** erlon has joined #openstack-manila14:54
*** rraja has joined #openstack-manila14:54
*** zhongjun has joined #openstack-manila14:54
*** tbarron has joined #openstack-manila14:54
*** masber has joined #openstack-manila14:54
*** jiaopengju has joined #openstack-manila14:54
*** hoonetorg has joined #openstack-manila14:54
*** toabctl has joined #openstack-manila14:54
*** abhi has joined #openstack-manila14:54
*** zigo has joined #openstack-manila14:54
*** EmilienM has joined #openstack-manila14:54
*** sapcc-bot has joined #openstack-manila14:54
*** netapp has joined #openstack-manila14:54
*** bswartz has joined #openstack-manila14:54
*** vkmc has joined #openstack-manila14:54
*** gregsfortytwo has joined #openstack-manila14:54
*** amito has joined #openstack-manila14:54
*** kfox1111 has joined #openstack-manila14:54
*** Reepicheep has joined #openstack-manila14:54
openstackgerritAmit Oren proposed openstack/manila master: INFINIDAT add Manila driver  https://review.openstack.org/51543215:05
*** dsariel has joined #openstack-manila15:06
*** dustins has joined #openstack-manila15:16
*** ChanServ has joined #openstack-manila15:16
*** barjavel.freenode.net sets mode: +o ChanServ15:16
*** dustins has quit IRC15:16
*** dustins has joined #openstack-manila15:16
openstackgerritRamana Raja proposed openstack/manila master: ganesha: store exports and export counter in RADOS  https://review.openstack.org/51054715:16
*** dustins has quit IRC15:16
amitotbarron: no problem actually, if I'm not mistaken some of our python repos are public, and we also have lots of opensource repos on github (but that's another thing) :) thanks for the quick review!15:17
*** nug is now known as Guest2014815:20
*** dustins_ has joined #openstack-manila15:20
*** dustins_ is now known as dustins15:21
*** rraja has quit IRC15:24
*** aspiers[m] has joined #openstack-manila15:37
tbarrondustin if you have time it would probably be good to discuss them here then16:01
bswartzdustins: do those other ones require discussion, or do we just need to make sure to find owners?16:02
*** markstur has joined #openstack-manila16:02
tbarrons/discuss/find owners for/ is fine16:02
dustinsNot really, two are just "do we have docs for these" and one is an error with manila manage's error output16:02
bswartzokay16:03
bswartzlet's keep them on the list for next week16:03
dustinsbswartz: Sure thing, I'll keep those and add a few more as I go :D16:03
bswartztbarron: regarding https://bugs.launchpad.net/manila/+bug/1733286 is there a scenario test which could catch it16:04
openstackLaunchpad bug 1733286 in Manila "snapshot share data Sync with the source share" [Undecided,New]16:04
bswartzbecause it seems like a great test to write if not16:05
tbarronbswartz: agree16:05
zhongjungouthamr: ping16:06
tbarronwe need to get our scenario tests working again though16:06
tbarroni'm spending most of my time in tripleo right now but would like to get over to manila tests when I can16:07
gouthamrzhongjun: pong16:10
gouthamrbswartz: https://specs.openstack.org/openstack/manila-specs/specs/ocata/scenario-tests.html#relationships-between-source-shares-and-child-shares16:13
gouthamr:)16:13
zhongjungouthamr: manila list --name~ test --all-tenants   It is work,  but the bug command is "manila show"16:13
zhongjungouthamr: https://bugs.launchpad.net/manila/+bug/172178716:14
openstackLaunchpad bug 1721787 in python-manilaclient "Shares cannot be found by name in admin context" [Medium,In progress] - Assigned to jiaopengju (pj-jiao)16:14
zhongjungouthamr: so it looks like the bug is still exist16:16
gouthamrzhongjun: yep, responding as to why the behavior is intentional16:17
gouthamri'll try suggesting a workaround16:17
zhongjungouthamr: Could you add some response on the bug link when you free16:18
zhongjungouthamr: sorry, I have to go to sleep, thanks16:18
gouthamrzhongjun: yep.. np,  good night!16:19
*** AlexeyAbashkin has joined #openstack-manila16:24
*** AlexeyAbashkin has quit IRC16:31
*** dsariel has quit IRC16:38
*** aspiers[m] has quit IRC16:39
*** harlowja has joined #openstack-manila17:08
*** markstur_ has joined #openstack-manila17:11
*** markstur has quit IRC17:13
*** aspiers[m] has joined #openstack-manila17:57
*** aspiers[m] has quit IRC18:05
*** dustins has quit IRC18:11
*** vivsoni__ has joined #openstack-manila18:24
*** vivsoni_ has quit IRC18:24
*** aspiers[m] has joined #openstack-manila18:40
bswartzgouthamr: over here18:42
gouthamrhey bswartz/tbarron: re: https://bugs.launchpad.net/manila/+bug/1721787 - The problem can be sidestepped by grabbing the ID from the list and using it to "show"/"delete", etc18:42
openstackLaunchpad bug 1721787 in python-manilaclient "Shares cannot be found by name in admin context" [Medium,In progress] - Assigned to jiaopengju (pj-jiao)18:42
bswartzgouthamr: isn't that how show-by-name normally works?18:42
gouthamrshow/delete/update by name being a client optimization and the bug isn't in the server18:43
bswartzokay I see where this is going18:43
gouthamryes, we list all resources and try to filter them by name18:43
bswartzwhen listing, manilaclient does nothing special, but for other operations it knows how to look up shares by name using the list API18:44
bswartzhowever for admins, the name lookup doesn't work as expected without the --all-tenants flag18:44
gouthamryep, the name lookup would require the find() operation to pass "all_tenants" to its list call18:44
gouthamrwhich is what https://review.openstack.org/#/c/522452 tries to do18:45
gouthamri don18:45
bswartzcan you do a "manila show blah --all-tenants" to work around this?18:45
gouthamri don't disagree with the implementation there18:45
gouthamrhowever, i think "manila show blah --all-tenants" is a more meaningful way of doing this18:45
gouthamrbecause we might introduce a regression for administrators who are used to this behavior18:46
tbarronthere's also the consideration of consistent expectations between manila and cinder and perhaps other projects18:46
gouthamr"manila show blah --all-tenants" doesn't work today, but we can start accepting the "all-tenants" flag in all the "show" commands and pass it up to the list18:46
gouthamrinvocation18:47
tbarronthough maybe everybody should do that ^^18:47
bswartzokay you answered my question18:47
amitotbarron gouthamr: thanks for the quick +2's on the last patch set :)18:47
tbarronamito: yw18:47
bswartzI'm with tbarron on this -- consistency with other projects is probably more important than consistency with how it worked in the past18:48
bswartzI wish we had some of the cool features of openstackclient btw18:48
bswartzour CLI is really falling behind18:48
tbarronI want us in shade18:48
gouthamr^^ +111118:48
tbarronwe need to see where these are with microversions18:49
bswartzmordred mordred mordred18:49
bswartzor does that only work with evil spirits?18:49
tbarroni've been using shade to set up nodes in an openstack cloud to run devstack on, really like it.18:50
bswartzanyways back to the topic of the bug18:50
gouthamrso Jiao Pengju's client fix will work for us then18:50
bswartzmy only concern with fixing this is the definite performance regression this will cause for administrators using show/delete/update by name18:51
gouthamri'll comment on the patch to include a reno stating the change in behavior18:51
bswartzI assume the name lookup has a reasonable way of dealing with ambiguous names?18:51
gouthamrit might not always be a performance regression, as much as a command didn't work because manilaclient now finds more shares with the same name even if they don't belong in my namespace18:52
bswartzif the admin was looking up his own shares by name, it would have worked in the past18:52
bswartzand now it will be slower18:52
gouthamrreasonable way: no unique match18:52
gouthamrso fail the request18:52
* gouthamr crap, Tennessee hired a coach, gah, plan B18:54
tbarronheh18:56
bswartzgouthamr: were you hoping to get that job?18:56
gouthamrweren't we all? they were taking so long18:56
bswartzI'm just glad they didn't steal schiano18:56
gouthamrthought i had a chance :)18:56
gouthamrschiano18:57
gouthamrmade money18:57
gouthamrbswartz: you're okay with the regression then, in terms of the likely performance hit and behavior change wrt likely inability to show/update/delete shares under admin's own project when names collide?19:00
bswartzit annoys me, but I don't see a better solution19:00
bswartzso I say we fix the bug19:00
gouthamrwhy i'm not happy with it is "manila list --name xyz" requires 'all_tenants' to list all the shares named xyz in the cloud, but "manila show xyz" will complain if there are collisions19:02
bswartzgouthamr: he's how I would think about it -- imagine that the admin always sees shares from all tenants, but that the list command has an implicit filter if you don't specify --all-tenants -- in order to protect admins from accidentally turning on a JSON firehose19:04
gouthamrbswartz: sure, updated the bug...19:20
*** harlowja has quit IRC19:21
*** dustins has joined #openstack-manila19:26
*** aspiers[m] has quit IRC19:33
amitozuul gate failed for our commit (POST_FAILURE) due to some ssh error during the sphinx docs test.19:42
amitocan it be re-triggered in some way?19:43
amito(pinging gouthamr and tbarron on that ^)19:45
bswartzamito: just post a comment with the word "recheck"19:53
tbarronamito: yeah, I don'19:53
tbarrondon't know a way just to run just that one job19:53
amitook, a regular recheck then19:53
tbarroninfra seems to be being worked pretty hard today19:54
tbarronhttps://review.openstack.org/#/c/510547/ has passed all tests except that the jobs that depend on the cephfs-devstack-plugin haven't even started, just sitting there for hours19:55
tbarronamito: your driver is in good shape for the release even if M2 tag gets cut before it merges19:56
tbarronamito: you've met all the deadlines19:57
* bswartz is pushing tags as we speak19:57
tbarronamito: but there is a psychological satisfaction that you may miss this time19:57
amitotbarron: ty :)19:57
bswartzmaybe take pleasure in being the first commit after the tag?19:57
bswartzgit repos are all just long chains of commits19:58
amitotbarron: posted the recheck. I now see that by mistake I didn't post the comments for the previous patch set, they were all drafted and posted now. oops.20:00
amitobah, so I think I need to post another comment actually starting with "recheck" and not "(3 comments)"20:01
*** a-pugachev has joined #openstack-manila20:11
*** dustins has quit IRC20:33
*** dustins has joined #openstack-manila20:38
*** ganso has quit IRC21:07
*** sticker has joined #openstack-manila21:39
*** chenying has quit IRC21:43
*** Guest20148 has quit IRC21:43
*** cargonza has quit IRC21:43
*** chenying has joined #openstack-manila21:48
*** Guest20148 has joined #openstack-manila21:48
*** cargonza has joined #openstack-manila21:48
*** openstackgerrit has quit IRC21:48
*** openstackgerrit has joined #openstack-manila21:48
openstackgerritTom Barron proposed openstack/manila master: ganesha: store exports and export counter in RADOS  https://review.openstack.org/51054721:48
tbarronwas just stuck in zuul ^^ all I did was remove a Depends-On to a patch that has already merged22:03
*** threestrands has joined #openstack-manila22:04
*** threestrands has quit IRC22:04
*** threestrands has joined #openstack-manila22:04
*** dustins has quit IRC22:05
*** dustins has joined #openstack-manila22:24
*** ianychoi has quit IRC22:30
*** ianychoi has joined #openstack-manila22:33
*** chenying has quit IRC22:36
*** Guest20148 has quit IRC22:36
*** cargonza has quit IRC22:36
*** dustins has quit IRC22:40
*** chenying has joined #openstack-manila22:42
*** Guest20148 has joined #openstack-manila22:42
*** cargonza has joined #openstack-manila22:42
*** gouthamr has quit IRC22:59
*** a-pugachev has quit IRC23:06
*** harlowja has joined #openstack-manila23:07
*** erlon has quit IRC23:28
*** gouthamr has joined #openstack-manila23:41
*** threestrands has quit IRC23:55
openstackgerritMerged openstack/manila master: INFINIDAT add Manila driver  https://review.openstack.org/51543223:58
« Wednesday, 2017-12-06 Index Friday, 2017-12-08 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!