| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila-ui master: Updated from global requirements https://review.openstack.org/488238 | 00:06 |
|---|---|---|
| openstackgerrit | Merged openstack/python-manilaclient master: Enable IPv6 in manila(client) https://review.openstack.org/328932 | 00:12 |
| openstackgerrit | Merged openstack/manila master: Updated from global requirements https://review.openstack.org/488012 | 00:14 |
| *** jiaopengju has joined #openstack-manila | 00:32 | |
| *** jiaohaolin1 has quit IRC | 00:42 | |
| *** catintheroof has quit IRC | 00:57 | |
| *** harlowja has quit IRC | 01:10 | |
| *** kaisers__ has joined #openstack-manila | 01:17 | |
| *** catintheroof has joined #openstack-manila | 01:18 | |
| *** kaisers_ has quit IRC | 01:20 | |
| *** catintheroof has quit IRC | 01:25 | |
| openstackgerrit | zhongjun proposed openstack/manila master: Fix tempests tests cannot run in test_rules https://review.openstack.org/485165 | 01:25 |
| *** jiaopengju has quit IRC | 01:30 | |
| *** jiaopengju has joined #openstack-manila | 01:31 | |
| *** gouthamr has quit IRC | 01:33 | |
| openstackgerrit | zhongjun proposed openstack/manila master: Enable IPv6 in manila(documentation) https://review.openstack.org/416870 | 01:44 |
| *** jmlowe has joined #openstack-manila | 02:04 | |
| *** gouthamr has joined #openstack-manila | 03:22 | |
| *** gouthamr has quit IRC | 03:46 | |
| *** gouthamr has joined #openstack-manila | 03:58 | |
| *** gouthamr has quit IRC | 03:58 | |
| *** gouthamr has joined #openstack-manila | 03:59 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila master: Updated from global requirements https://review.openstack.org/488281 | 04:16 |
| *** ganso has quit IRC | 04:24 | |
| *** gouthamr has quit IRC | 04:30 | |
| *** dsariel has joined #openstack-manila | 04:30 | |
| *** harlowja has joined #openstack-manila | 04:32 | |
| *** arnewiebalck_ has joined #openstack-manila | 04:41 | |
| *** kaisers__ has quit IRC | 05:19 | |
| *** dsariel has quit IRC | 05:26 | |
| *** harlowja has quit IRC | 05:28 | |
| *** kaisers_ has joined #openstack-manila | 05:32 | |
| *** kaisers_ has quit IRC | 05:37 | |
| *** harlowja has joined #openstack-manila | 05:41 | |
| *** arnewiebalck_ has quit IRC | 05:47 | |
| *** kaisers_ has joined #openstack-manila | 05:50 | |
| *** sticker_ has quit IRC | 06:23 | |
| *** kaisers_ has quit IRC | 06:43 | |
| *** harlowja has quit IRC | 06:48 | |
| *** kaisers has quit IRC | 07:20 | |
| *** kaisers has joined #openstack-manila | 07:29 | |
| *** kaisers has quit IRC | 07:37 | |
| *** kaisers has joined #openstack-manila | 07:39 | |
| *** kaisers1 has joined #openstack-manila | 07:42 | |
| *** kaisers has quit IRC | 07:50 | |
| *** zhonghua2 has quit IRC | 08:07 | |
| *** zhonghua2 has joined #openstack-manila | 08:07 | |
| *** openstackgerrit has quit IRC | 08:18 | |
| *** tuanluong has joined #openstack-manila | 08:45 | |
| *** kaisers has joined #openstack-manila | 08:47 | |
| *** kaisers has quit IRC | 09:24 | |
| *** gcb has quit IRC | 09:53 | |
| *** ganso has joined #openstack-manila | 09:54 | |
| *** jiaopengju has quit IRC | 10:06 | |
| *** openstackgerrit has joined #openstack-manila | 10:10 | |
| openstackgerrit | Tatyana proposed openstack/manila master: [do not merge] manila CHEPH shares tests https://review.openstack.org/488360 | 10:10 |
| *** kaisers has joined #openstack-manila | 10:21 | |
| *** dsariel has joined #openstack-manila | 10:24 | |
| *** tuanluong has quit IRC | 10:31 | |
| *** kaisers has quit IRC | 10:32 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila-ui master: Imported Translations from Zanata https://review.openstack.org/488365 | 10:37 |
| *** kaisers has joined #openstack-manila | 11:34 | |
| *** catintheroof has joined #openstack-manila | 11:48 | |
| *** catintheroof has quit IRC | 12:14 | |
| openstackgerrit | Tom Barron proposed openstack/manila-ui master: Fix gate manilclient import error https://review.openstack.org/488406 | 12:45 |
| *** catintheroof has joined #openstack-manila | 12:50 | |
| *** kaisers has quit IRC | 12:51 | |
| *** Yogi1 has joined #openstack-manila | 12:53 | |
| ganso | tbarron: nice! | 12:54 |
| tbarron | ganso: think that will work | 12:55 |
| ganso | tbarron: according to the error in the logs, I don't think so | 12:56 |
| ganso | tbarron: I saw errors failing to import availability_zone | 12:56 |
| ganso | tbarron: so I guess the manilaclient version in the requirements needs to be update | 12:56 |
| ganso | tbarron: I had this problem back when we merged mountable snapshots | 12:57 |
| tbarron | ganso: it works locally. from 'manilaclient.v2 import availability_zones' fails because 'import manilaclient.v2' fails | 12:58 |
| tbarron | ganso: hmm, so let me look at requirements again | 12:58 |
| ganso | tbarron: oh, and manilaclient.v2 fails because of ipaddress? | 12:58 |
| ganso | tbarron: I remember that we bumped upper constraints to update manila-ui | 12:59 |
| ganso | tbarron: I am not sure if this is necessary in this case | 12:59 |
| ganso | tbarron: haven't looked into it much | 12:59 |
| tbarron | yes, manilaclient.v2 fails b/c of ipaddress | 13:00 |
| tbarron | importing ipaddress fixes the problem locally | 13:00 |
| ganso | tbarron: oh, cool, so your fix will most likely work | 13:00 |
| tbarron | i mean: requiring ipaddress | 13:00 |
| tbarron | but let me look at the manilaclient versiono | 13:01 |
| tbarron | version too | 13:01 |
| tbarron | that might be a better way | 13:01 |
| *** raissa_ is now known as raissa | 13:03 | |
| tbarron | ganso: heh, manila-ui is requiring python-manilaclient >= 1.12.0 and we just released 1.17.0 | 13:03 |
| raissa | tbarron: the voting gates seem happy now (I think errors in nv gates are unrelated) https://review.openstack.org/#/c/334596/ | 13:05 |
| *** xyang1 has joined #openstack-manila | 13:06 | |
| tbarron | raissa: nice! | 13:08 |
| tbarron | raissa: cephfs-nfs is broken b/c of new luminous minor version; rraja is looking at it | 13:08 |
| raissa | ahh all right :) | 13:08 |
| tbarron | raissa: and the other non-votings like hdfs and glusterfs-native have been failing "forever" | 13:09 |
| tbarron | they are basically unsupported atm | 13:09 |
| tbarron | and cephfs-native job just timed out, slow devstack load, an intermittent issue for all jobs | 13:10 |
| raissa | andreaf: ^ re patch 334596 | 13:10 |
| tbarron | raissa: so I agree that the nonvoting job failures have nothing to do with your patch | 13:10 |
| andreaf | raissa: nice work | 13:11 |
| *** eharney has joined #openstack-manila | 13:14 | |
| openstackgerrit | Raissa Sarmento proposed openstack/manila master: Use tempest-plugin service client registration https://review.openstack.org/334596 | 13:18 |
| ganso | tbarron: we need to update the upper constraints then I suppose | 13:20 |
| tbarron | ganso: looks like it has 1.15.0 for python-manilaclient | 13:23 |
| *** dustins has joined #openstack-manila | 13:24 | |
| tbarron | ganso: we also have explicit requirement line in manila-ui/requirements, I just tried bumping it locally and that alone doesn't fix the issue | 13:24 |
| tbarron | ganso: but offhand I don't see why both manila-ui/requirements and upper-constraints shouldn't be 1.17.0 now | 13:25 |
| openstackgerrit | Tom Barron proposed openstack/manila-ui master: DNM - requirements bump expt https://review.openstack.org/488417 | 13:26 |
| bswartz | guys I created the pike-rc1 milestone yesterday in LP | 13:33 |
| bswartz | please target bugs to that | 13:33 |
| tbarron | raissa: please add yourself as co-author on 334596 | 13:34 |
| bswartz | tbarron: u-c should be 1.17 but requirements doesn't need to move unless something is broken | 13:34 |
| tbarron | bswartz: ack, something is broken but fixable by requiring ipaddress module in manila-ui w/o bumping python-manilclient requirement | 13:35 |
| tbarron | bswartz: and bumping the requirement doesn't itself fix the issue | 13:35 |
| ganso | tbarron: jenkins failed | 13:36 |
| bswartz | can someone explains to me how the import of "ipaddress" could possibly fail? isn't that part of the standard library? | 13:36 |
| tbarron | bswartz: good question | 13:36 |
| tbarron | i think it is starting in python 2.6 or 2.7 | 13:36 |
| tbarron | and of course in python3 | 13:36 |
| tbarron | ganso: i didn't specify a version on ipaddr | 13:38 |
| bswartz | I don't understand how parts of the standard library could have versions -- it's just the python version right? | 13:38 |
| tbarron | requirement, looks like I need to make it match, i'll set it to >=1.0.7 | 13:38 |
| bswartz | am I wrong about ipaddress being in the standard library? | 13:38 |
| tbarron | bswartz: maybe not in python2? | 13:39 |
| openstackgerrit | Raissa Sarmento proposed openstack/manila master: Use tempest-plugin service client registration https://review.openstack.org/334596 | 13:39 |
| tbarron | bswartz: we aren't having to include it in requirements in manila or python-manilaclient | 13:39 |
| bswartz | interesting | 13:39 |
| tbarron | though | 13:39 |
| tbarron | so either we have a transitive requirement there that makes it work in python2 or something | 13:40 |
| bswartz | https://pypi.python.org/pypi/ipaddress | 13:40 |
| tbarron | funny is going on in manila-ui | 13:40 |
| bswartz | >_< | 13:40 |
| bswartz | the sooner we kill the py2.7 the better | 13:40 |
| tbarron | +1 | 13:40 |
| *** cknight has joined #openstack-manila | 13:41 | |
| openstackgerrit | Tom Barron proposed openstack/manila-ui master: Fix gate manilclient import error https://review.openstack.org/488406 | 13:43 |
| *** kaisers has joined #openstack-manila | 13:48 | |
| *** gouthamr has joined #openstack-manila | 13:54 | |
| *** tosky has joined #openstack-manila | 13:59 | |
| *** tellesnobrega has joined #openstack-manila | 14:00 | |
| tosky | tbarron: hi! I've noticed https://bugs.launchpad.net/manila-ui/+bug/1707194 and the fix https://review.openstack.org/#/c/488406/, we have a similar issue in sahara-dashboard | 14:00 |
| openstack | Launchpad bug 1707194 in manila-ui "test: gate: Failure: ImportError (cannot import name availability_zones)" [Critical,In progress] - Assigned to Tom Barron (tpb) | 14:00 |
| *** kaisers has quit IRC | 14:00 | |
| tosky | tbarron: but shouldn't the import be added to manilaclient, instead of each possible users of manilaclient (in this case, manila-ui, but also any other?) | 14:00 |
| tbarron | tosky: probably right, please -1 that patch | 14:01 |
| * tbarron goes off to BJ | 14:01 | |
| tbarron | tosky: and feel free to propose the right fix in the mean time | 14:01 |
| tosky | ack :) | 14:01 |
| openstackgerrit | Luigi Toscano proposed openstack/python-manilaclient master: Fix manilclient.v2 import error https://review.openstack.org/488427 | 14:05 |
| openstackgerrit | Luigi Toscano proposed openstack/python-manilaclient master: Fix manilclient.v2 import error https://review.openstack.org/488427 | 14:06 |
| *** AlexeyAbashkin has joined #openstack-manila | 14:18 | |
| openstackgerrit | Luigi Toscano proposed openstack/python-manilaclient master: Fix manilclient.v2 import error https://review.openstack.org/488427 | 14:27 |
| *** tellesnobrega has quit IRC | 14:33 | |
| openstackgerrit | Merged openstack/manila master: Enable IPv6 in manila(documentation) https://review.openstack.org/416870 | 14:43 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila master: Updated from global requirements https://review.openstack.org/488281 | 14:45 |
| *** harlowja has joined #openstack-manila | 14:51 | |
| openstackgerrit | Tom Barron proposed openstack/manila-ui master: DO NOT MERGE https://review.openstack.org/488445 | 14:53 |
| tbarron | tosky: dunno if it will work but I'm trying with Depends-On: <yourchange> | 14:54 |
| tosky | tbarron: I was going to ask the same, but see #openstack-release | 14:55 |
| tosky | jobs use on the released versions of the clients (not from git HEAD) | 14:55 |
| tbarron | oh | 14:56 |
| *** kaisers has joined #openstack-manila | 14:57 | |
| *** Yogi1 has quit IRC | 15:01 | |
| tosky | tbarron: please change https://review.openstack.org/#/c/488445/ to depend on https://review.openstack.org/488492 | 15:08 |
| tosky | or I can do it | 15:08 |
| tosky | it should do the trick | 15:08 |
| tbarron | tosky: please just do it as my attention is diverted atm | 15:09 |
| tosky | tbarron: sure :) | 15:09 |
| * tbarron has been enjoying having raissa work in manila, maybe he can entice tosky over here too | 15:09 | |
| tosky | >.> I'm fixing Sahara and this is like http://imgur.com/gallery/t0XHtgJ | 15:10 |
| tbarron | we just have to keep breaking sahara to achieve that goal | 15:10 |
| tbarron | rofl | 15:10 |
| raissa | tosky: welcome back to work eheh | 15:11 |
| tosky | eh :D | 15:11 |
| openstackgerrit | Luigi Toscano proposed openstack/manila-ui master: DO NOT MERGE https://review.openstack.org/488445 | 15:12 |
| *** dsariel has quit IRC | 15:14 | |
| *** tellesnobrega has joined #openstack-manila | 15:15 | |
| *** kaisers has quit IRC | 15:26 | |
| *** tellesnobrega has quit IRC | 15:26 | |
| *** kaisers has joined #openstack-manila | 15:26 | |
| tbarron | ganso: bswartz I think we should merge https://review.openstack.org/#/c/48842 even if | 15:27 |
| tbarron | we may need temporary fixes in manila-ui and sahara-ui (TBD whether we will) | 15:28 |
| tbarron | b/c it would be good to get the root cause fix in before stable/pike is cut (imminent) | 15:29 |
| raissa | is that the right link? | 15:31 |
| raissa | ok I guess it's https://review.openstack.org/#/c/488427 | 15:34 |
| *** kaisers has quit IRC | 15:38 | |
| bswartz | tbarron: wrong link? | 15:43 |
| tbarron | raissa: thanks - bswartz 488427 - I truncated | 15:43 |
| bswartz | thanks raissa | 15:43 |
| tosky | bswartz: see also the discussion on #openstack-release (you may see a ping), maybe a new release could be tagged for pike | 15:44 |
| tosky | with that fix | 15:44 |
| tosky | otherwise any user of 'import manilaclient.v2' should add that dependency | 15:44 |
| bswartz | I have no problem tagging another version | 15:48 |
| bswartz | it seems like a backport after stable/pike gets cut would require less rule bending | 15:49 |
| bswartz | I'm not clear on how bad the problem is | 15:49 |
| tosky | try to run 'import manilaclient.v2' | 15:50 |
| tosky | it explodes because ipaddress is missing | 15:50 |
| tosky | I would say "bad" | 15:51 |
| *** harlowja has quit IRC | 15:51 | |
| *** jmlowe has quit IRC | 15:51 | |
| tosky | also because it's blocking pike3 for sahara-dashboard | 15:51 |
| tbarron | current consumers of manilaclient being manila-ui and sahara-dashboard at least | 15:51 |
| bswartz | I don't understand how testing didn't catch this | 15:52 |
| bswartz | if it's that bad | 15:52 |
| tosky | which uses manilaclient; I know that we could add the dependency, but according ttx on #openstack-release a new client can be easily tagged if the operation is done today | 15:52 |
| tosky | ehm, I don't know why it was not catched | 15:52 |
| bswartz | pushing a new tag is easy, but I'd more interested in how we avoid the same problem in the future | 15:52 |
| bswartz | s/I'd/I'm/ | 15:53 |
| tosky | sure, it makes sense | 15:53 |
| tbarron | bswartz: i guess until the client was released ui and sahara dashboard jobs in gate didn't see the changes that introduced the need for the requirement | 15:54 |
| tosky | yes, but that's one part of it | 15:55 |
| tosky | manilaclient/v2/shares.py:import ipaddress | 15:55 |
| bswartz | tbarron: so there needs to be some kind of job in the manilaclient project that detects this condition | 15:55 |
| tosky | but no ipaddress in requirements; maybe it's covered elsewhere | 15:55 |
| tbarron | we didn't need ipaddress explicitly in requirements in manila or in python-manilaclient itself | 15:56 |
| tosky | uhm, also manila.git imports ipaddress in various places, but I don't see in the requirements | 15:56 |
| * tosky puzzled | 15:56 | |
| tosky | maybe it was installed on the test images by default? | 15:56 |
| tbarron | i'm thinking maybe it was transitively (implicitly) required | 15:57 |
| tosky | so most likely a patch for manila is needed too | 15:58 |
| tbarron | it is present in my .tox/py27/lib/... and 'pip list/freeze' shows it in those components when I activate a .tox venv | 15:58 |
| tosky | and if you create a new py27 venv? | 16:00 |
| tbarron | tosky: probably, but not urgently I guess and manila server isn't imported | 16:01 |
| tbarron | tosky: I did 'rm -rf .tox' and rebuilt before looking | 16:01 |
| tbarron | s/I guess and/I guess since/ | 16:02 |
| tosky | tbarron: codesearch.openstack.org finds it in test-requirements.txt for oslo.serialization | 16:07 |
| bswartz | tbarron: how confident are we that the patch moving through the gate is the right one? | 16:07 |
| bswartz | I saw the discussion in #release about various mechanisms to test it | 16:08 |
| tbarron | bswartz: it matches global-requirements.txt so it seems correct | 16:11 |
| tbarron | I think the question was whether if we can't get it in the release we need to also patch the consumers | 16:11 |
| *** jmlowe has joined #openstack-manila | 16:12 | |
| tosky | bswartz: the various mechanisms don't work for non-devstack tests, like unit tests | 16:13 |
| tbarron | yeah, looks like dhellman's 3-way Depends-On trick doesn't work for this | 16:14 |
| tosky | but testing locally the failure in sahara-dashboard are gone | 16:15 |
| tbarron | bswartz: I don't think we know how to test this except that when the same requirement is added to the consumer it fixes the consumer. | 16:16 |
| tbarron | tosky: were you able to make sahara-dashboard Depend-On: the candidate python-manilaclient itself? | 16:17 |
| tosky | tbarron: yes and no; I did, but it's pointless for unit tests | 16:17 |
| tbarron | ack | 16:17 |
| *** dustins has quit IRC | 16:26 | |
| bswartz | zuul says 0 minutes | 16:32 |
| * bswartz waits for it..... | 16:32 | |
| openstackgerrit | Merged openstack/python-manilaclient master: Fix manilclient.v2 import error https://review.openstack.org/488427 | 16:32 |
| tosky | \o/ | 16:32 |
| bswartz | yay | 16:32 |
| bswartz | https://review.openstack.org/488522 | 16:34 |
| *** kaisers has joined #openstack-manila | 16:34 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-manilaclient master: Updated from global requirements https://review.openstack.org/488524 | 16:35 |
| tbarron | thanks tosky! | 16:36 |
| tosky | now I only hope that it was not the only blocker for sahara-dashboard; I get one last error but I hope it's my setup | 16:36 |
| tbarron | tosky: fingers crossed | 16:37 |
| bswartz | tbarron: the bot doesn't like ltoscano's whitespace choices ^ | 16:40 |
| *** openstackstatus has quit IRC | 16:41 | |
| *** openstack has joined #openstack-manila | 16:45 | |
| tbarron | that would be handy | 16:47 |
| tosky | I don't think that gerrit has that information | 16:47 |
| tosky | it's in the launchpad profile most likely | 16:47 |
| bswartz | yeah launchpad is usually where I go to hunt down unknown names | 16:52 |
| bswartz | it would be nice if gerrit allowed you to add an IRC nick to your account | 16:52 |
| *** catinthe_ has joined #openstack-manila | 16:54 | |
| *** harlowja has joined #openstack-manila | 16:54 | |
| *** harlowja_ has joined #openstack-manila | 16:55 | |
| *** catintheroof has quit IRC | 16:58 | |
| *** harlowja has quit IRC | 16:59 | |
| *** tellesnobrega has joined #openstack-manila | 17:00 | |
| *** kaisers has quit IRC | 17:02 | |
| openstackgerrit | Boris Pavlovic proposed openstack/manila master: Revert "Updated from global requirements" https://review.openstack.org/488533 | 17:02 |
| *** kaisers has joined #openstack-manila | 17:04 | |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being taken offline for roughly 5 minutes to perform a database backup and reconfiguration | 17:12 | |
| *** dustins has joined #openstack-manila | 17:16 | |
| *** kaisers has quit IRC | 17:17 | |
| *** kaisers has joined #openstack-manila | 17:25 | |
| *** tosky has quit IRC | 17:31 | |
| *** tellesnobrega has quit IRC | 17:31 | |
| *** openstackgerrit has quit IRC | 17:33 | |
| *** kaisers has quit IRC | 17:45 | |
| *** kaisers has joined #openstack-manila | 17:45 | |
| *** kaisers has quit IRC | 17:49 | |
| *** catinthe_ has quit IRC | 18:08 | |
| *** catintheroof has joined #openstack-manila | 18:10 | |
| *** openstackstatus has quit IRC | 18:11 | |
| *** openstack has joined #openstack-manila | 18:15 | |
| bswartz | ganso: ping | 18:35 |
| bswartz | ganso: I think I might have found a bug in mountable snapshots for LVM | 18:35 |
| *** kaisers has joined #openstack-manila | 18:37 | |
| *** mayur__ has joined #openstack-manila | 18:41 | |
| *** openstackstatus has quit IRC | 18:42 | |
| *** openstack has joined #openstack-manila | 18:45 | |
| *** openstackgerrit has joined #openstack-manila | 18:51 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila master: Change the way snapshots are exported in LVM https://review.openstack.org/488569 | 18:51 |
| *** mayur__ has quit IRC | 18:54 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila master: Changes to allow manila-test-image to work with scenario tests https://review.openstack.org/435786 | 18:57 |
| *** chenying__ has quit IRC | 19:45 | |
| *** chenying__ has joined #openstack-manila | 19:47 | |
| *** cknight has quit IRC | 20:07 | |
| *** catintheroof has quit IRC | 20:08 | |
| ganso | bswartz: pong | 20:13 |
| bswartz | ganso: ! | 20:13 |
| ganso | bswartz: gerrit is down | 20:13 |
| ganso | bswartz: oh wait, it is not | 20:14 |
| bswartz | ganso: so I did an experiment -- https://review.openstack.org/488569 | 20:14 |
| bswartz | but I wanted to ask you about this | 20:14 |
| bswartz | It's not clear that there is a bug but I saw a test failure and that snapshot code made me suspicious | 20:14 |
| bswartz | I want to verify that there is in fact a bug before actually pushing for this fix | 20:15 |
| ganso | bswartz: do you have a trace of the failure? | 20:16 |
| bswartz | ganso: http://logs.openstack.org/39/476239/11/check/gate-manila-tempest-minimal-dsvm-lvm-ubuntu-xenial/a4b36a1/ | 20:16 |
| bswartz | in that test job 1 test failed, and upon inspection the reason was that snapshot creation failed during the "mount" command | 20:17 |
| ganso | bswartz: no error in m-shr http://logs.openstack.org/39/476239/11/check/gate-manila-tempest-minimal-dsvm-lvm-ubuntu-xenial/a4b36a1/logs/screen-m-shr.txt.gz?level=ERROR | 20:17 |
| bswartz | the "mount" command returned status 32 (device in use or busy) | 20:17 |
| bswartz | ganso: grep for error, the button is broken | 20:17 |
| ganso | bswartz: ah | 20:18 |
| ganso | bswartz: you cannot consistently reproduce the problem, right? | 20:18 |
| bswartz | no I just saw it this one time | 20:19 |
| bswartz | but people have been complaining about flaky lvm jobs lately | 20:19 |
| ganso | bswartz: AFAIK, changing the order as you did in your patch does nothing | 20:19 |
| bswartz | so I'm digging into each and every LVM failure I see to find the root cause | 20:19 |
| ganso | bswartz: the problem is that sometimes the mount operation takes a long time | 20:19 |
| ganso | bswartz: sometimes it doesn't | 20:19 |
| ganso | bswartz: tommylikehu invested a lot of time investigating this stuff | 20:20 |
| bswartz | so the issue with the existing code is that it sets up a share on the wrong directory | 20:20 |
| bswartz | it creates a CIFS share for an empty directory, then mounts the LV into that directory after the share exists | 20:20 |
| bswartz | it's unlikely that Samba does the right thing (need to confirm that though) | 20:20 |
| bswartz | in any case, do you see any downsides to that change I proposed? | 20:21 |
| ganso | bswartz: it seems you are creating the export before mounting the LVM | 20:21 |
| bswartz | the existing code creates the export then mounts | 20:21 |
| bswartz | my proposal is to mount then create the export | 20:21 |
| *** boris_42 has joined #openstack-manila | 20:21 | |
| boris_42 | vponomaryov bswartz hi there | 20:22 |
| ganso | bswartz: oh right, sorry, was reading the other way around | 20:22 |
| bswartz | intuitively, mounting first seems like the right thing to do | 20:22 |
| boris_42 | Rally Manila job start failing few days ago | 20:22 |
| ganso | bswartz: just a sec | 20:22 |
| bswartz | but since you were co-author on the patch that added these lines I wanted to ask you | 20:22 |
| boris_42 | did you guys change anything?) | 20:22 |
| boris_42 | https://review.openstack.org/#/c/486017/ | 20:23 |
| bswartz | boris_42: yes you might have hit https://bugs.launchpad.net/python-manilaclient/+bug/1707194 | 20:23 |
| openstack | Launchpad bug 1707194 in python-manilaclient "test: gate: Failure: ImportError (cannot import name availability_zones)" [Critical,In progress] - Assigned to Tom Barron (tpb) | 20:23 |
| boris_42 | http://logs.openstack.org/17/486017/5/check/gate-rally-dsvm-manila-multibackend/21bf136/rally-plot/results.html.gz | 20:23 |
| boris_42 | @bswartz so you are already working on this issue?) | 20:23 |
| ganso | bswartz: I think your change is correct | 20:23 |
| boris_42 | bswartz just making sure that things are undercontrol =) | 20:23 |
| bswartz | boris_42: feature freeze was yesterday and a bunch of code merged this week | 20:23 |
| ganso | bswartz: but I am unsure of why the current code is flaky | 20:23 |
| bswartz | we had some critical bugs | 20:23 |
| boris_42 | @bswartz that's the evil thing about feature freeze =) | 20:23 |
| boris_42 | creates chaos =) | 20:23 |
| bswartz | but in theory everything is fixed now | 20:24 |
| bswartz | if we continue to see problems we will investigate and fix them | 20:24 |
| bswartz | ganso: yes it's hard to understand how the current code would behave nondeterministically -- it seems pretty straightforward | 20:24 |
| bswartz | I wanted to do a good scenario test of that | 20:24 |
| bswartz | create a share with some data, then snapshot it and mount the snapshot (with CIFS) | 20:25 |
| boris_42 | bswartz: I'll recheck the job | 20:25 |
| bswartz | boris_42: what was the time of the earliest failure? | 20:25 |
| boris_42 | @bswartz something about 2-3 days ago | 20:26 |
| boris_42 | @bswartz I resubmit emtpy change patch to see whatever gates are passing or not | 20:26 |
| boris_42 | @bswartz that is going to give us result in about 20 minutes | 20:26 |
| bswartz | boris_42: ty | 20:26 |
| *** jmlowe has quit IRC | 20:39 | |
| boris_42 | @bswartz its' still failing with the same errors | 20:44 |
| boris_42 | @bswartz http://logs.openstack.org/17/486017/6/check/gate-rally-dsvm-manila-multibackend/8c022c9/rally-plot/results.html.gz#/ManilaShares.create_and_list_share/failures | 20:45 |
| boris_42 | File "/opt/stack/new/python-manilaclient/manilaclient/v2/shares.py", line 328, in list | 20:45 |
| boris_42 | search_opts.pop("export_location", None) | 20:45 |
| boris_42 | AttributeError: 'NoneType' object has no attribute 'pop | 20:45 |
| boris_42 | @bswartz seems like it's some typo in client during the recent work on shares | 20:48 |
| *** kaisers has quit IRC | 20:51 | |
| ganso | bswartz: yes. But logically it seems incorrect. It sure slipped under our radars | 20:55 |
| *** kaisers has joined #openstack-manila | 20:58 | |
| gouthamr | boris_42: still around? | 21:11 |
| boris_42 | yep | 21:12 |
| gouthamr | is there an LP for the bug you found just now? | 21:12 |
| boris_42 | *big brother is watching you* | 21:12 |
| gouthamr | lol | 21:12 |
| boris_42 | ;) | 21:12 |
| boris_42 | so no bug I just saw that manila gates started failing | 21:12 |
| boris_42 | and we didn't intorduce (from Rally side anything that may cause that) | 21:12 |
| gouthamr | boris_42: yes... true, i'll file one. thanks for noticing! | 21:13 |
| openstackgerrit | Merged openstack/python-manilaclient master: Updated from global requirements https://review.openstack.org/488524 | 21:14 |
| gouthamr | boris_42: https://bugs.launchpad.net/python-manilaclient/+bug/1707303 | 21:14 |
| openstack | Launchpad bug 1707303 in python-manilaclient "Manilaclient errors on share list for API versions <=2.34" [Undecided,New] | 21:14 |
| boris_42 | @gouthamr thanks | 21:15 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/python-manilaclient master: Fix list command when not given search_opts https://review.openstack.org/488848 | 21:18 |
| *** gouthamr has quit IRC | 21:24 | |
| *** dustins has quit IRC | 21:33 | |
| *** gouthamr has joined #openstack-manila | 21:36 | |
| boris_42 | @gouthamr btw I did this change https://review.openstack.org/#/c/486017/ just to check whatever your fix works or not | 21:45 |
| boris_42 | @gouthamr and thanks for quick fix | 21:45 |
| gouthamr | boris_42: np.. but wouldn't the job still pull down python-manilaclient>=1.12.0,<=1.16.0 | 21:50 |
| boris_42 | gouthamr: nope it uses upstream clients | 21:50 |
| gouthamr | nice.. | 21:50 |
| boris_42 | gouthamr: it's dark magic of CI jobs | 21:50 |
| boris_42 | but it works=) | 21:50 |
| gouthamr | haha.. dark magic really, finding all these bugs. :) | 21:51 |
| *** kaisers has quit IRC | 21:52 | |
| boris_42 | @gouthamr both jobs passed https://review.openstack.org/#/c/488848/1 this works works as expected ;) | 22:02 |
| gouthamr | boris_42: thanks, we'll merge it | 22:02 |
| *** jmlowe has joined #openstack-manila | 22:18 | |
| boris_42 | gouthamr: btw maybe it makes sense to all rally jobs to client repo as well? | 22:19 |
| gouthamr | boris_42: absolutely... they're not long running jobs.. | 22:22 |
| boris_42 | @gouthamr ya and that is going to catch some issues as well | 22:22 |
| *** kaisers has joined #openstack-manila | 22:23 | |
| gouthamr | boris_42: adding them to the check queue would suffice? | 22:26 |
| gouthamr | i don't think we need them in the gate queue, vponomaryov may have other ideas.. | 22:27 |
| gouthamr | https://review.openstack.org/488880 | 22:27 |
| *** kaisers has quit IRC | 22:27 | |
| boris_42 | @gouthamr ya just in check | 22:32 |
| boris_42 | @gouthamr as non voting | 22:32 |
| gouthamr | boris_42: these two jobs are non-voting in general, across all projects that have them enabled.. | 22:33 |
| boris_42 | @gouthamr ya | 22:34 |
| gouthamr | boris_42: awesome. thanks for pointing this out! | 22:34 |
| *** ganso has quit IRC | 23:23 | |
| openstackgerrit | Merged openstack/manila master: Updated from global requirements https://review.openstack.org/488281 | 23:35 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!