*** ianychoi has quit IRC | 00:10 | |
*** ianychoi has joined #openstack-manila | 00:11 | |
*** delatte has quit IRC | 00:13 | |
*** gcb has quit IRC | 00:26 | |
openstackgerrit | Peter Wang proposed openstack/manila master: Handle ssl for VNX manila driver https://review.openstack.org/440364 | 01:11 |
---|---|---|
openstackgerrit | OpenStack Proposal Bot proposed openstack/manila-ui master: Updated from global requirements https://review.openstack.org/440872 | 01:58 |
*** mtanino_ has quit IRC | 02:09 | |
*** erlon has quit IRC | 02:15 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-image-elements master: Adds support for NFS Ganesha https://review.openstack.org/411500 | 02:27 |
*** akapil has joined #openstack-manila | 02:40 | |
*** akapil has quit IRC | 02:44 | |
openstackgerrit | Merged openstack/puppet-manila master: Add service workers API config option https://review.openstack.org/441880 | 03:05 |
*** bswartz has quit IRC | 03:25 | |
*** gouthamr has quit IRC | 03:55 | |
*** bswartz has joined #openstack-manila | 04:36 | |
*** akapil has joined #openstack-manila | 04:38 | |
*** akapil has quit IRC | 04:42 | |
*** dsariel has quit IRC | 05:03 | |
*** dsariel has joined #openstack-manila | 05:37 | |
*** gcb has joined #openstack-manila | 06:28 | |
*** nkrinner_afk is now known as nkrinner | 06:40 | |
*** tuanluong has joined #openstack-manila | 06:51 | |
*** lpetrut has joined #openstack-manila | 06:58 | |
openstackgerrit | TommyLike proposed openstack/manila master: Fix: [LVM] Can't extend share when snapshots exist https://review.openstack.org/431315 | 07:10 |
*** jprovazn has joined #openstack-manila | 07:16 | |
*** lpetrut has quit IRC | 07:43 | |
*** gcb has quit IRC | 07:45 | |
*** pcaruana has joined #openstack-manila | 07:50 | |
*** makowals_ has quit IRC | 07:55 | |
*** gcb has joined #openstack-manila | 07:58 | |
*** makowals has joined #openstack-manila | 07:58 | |
*** akapil has joined #openstack-manila | 08:00 | |
*** makowals has quit IRC | 08:01 | |
*** akapil has quit IRC | 08:05 | |
*** akapil has joined #openstack-manila | 08:05 | |
*** lpetrut has joined #openstack-manila | 08:12 | |
*** makowals has joined #openstack-manila | 08:14 | |
*** makowals has quit IRC | 08:16 | |
*** makowals has joined #openstack-manila | 08:41 | |
*** makowals has quit IRC | 08:51 | |
*** makowals has joined #openstack-manila | 09:04 | |
*** akapil has quit IRC | 09:14 | |
*** lpetrut has quit IRC | 09:15 | |
*** akapil has joined #openstack-manila | 09:15 | |
*** lpetrut has joined #openstack-manila | 09:17 | |
*** a-pugachev has joined #openstack-manila | 09:20 | |
openstackgerrit | kavitha h r proposed openstack/manila master: The python version is added Python 3 and 3.5 version was missing. https://review.openstack.org/442335 | 09:21 |
*** faizy has joined #openstack-manila | 09:22 | |
*** belmoreira has joined #openstack-manila | 09:24 | |
tommylikehu | ping vponomaryov | 09:37 |
tommylikehu | hey vponomaryov, are you around? | 09:37 |
*** ociuhandu has joined #openstack-manila | 10:10 | |
*** rraja has joined #openstack-manila | 10:22 | |
*** gcb has quit IRC | 10:26 | |
*** openstackgerrit has quit IRC | 10:33 | |
*** ganso has joined #openstack-manila | 10:42 | |
vponomaryov | tommylikehu: pong | 10:44 |
*** akapil has quit IRC | 10:45 | |
tommylikehu | vponomaryov: thanks, could you take some time on this patch? https://review.openstack.org/#/q/is:starred | 10:47 |
vponomaryov | ьфниу нщг рфму ьщку зкщзук дштл, | 10:48 |
tommylikehu | ... | 10:48 |
vponomaryov | maybe you have more proper link? | 10:48 |
tommylikehu | sorry | 10:48 |
tommylikehu | https://review.openstack.org/#/c/431315/ | 10:48 |
ganso | tommylikehu: Hi TommyLike, could you please elaborate on your comment in the gerrit change above ^ ? | 10:52 |
ganso | tommylikehu: it seems you are trying to say that there is concurrency in that test | 10:52 |
tommylikehu | ganso: I think so, you can tell from the log, we collect all the snapshots and then detect the original volume one by one, but the failed snapshot is deleted just few seconds before, so that could happen | 10:54 |
*** akapil has joined #openstack-manila | 10:55 | |
ganso | tommylikehu: that shouldn't be allowed to happen | 10:57 |
tommylikehu | ganso: what do you exactly mean by shouldn't be allowed to happen | 10:58 |
ganso | tommylikehu: a request to delete the LVM shouldn't be accepted if it is already in a reverting state, and vice-versa | 10:59 |
ganso | tommylikehu: shouldn't be allowed to accept a request to revert if it is in a deleting state | 10:59 |
tommylikehu | ganso: no | 10:59 |
tommylikehu | ganso: we are not reverting you mean deleting? | 11:00 |
tommylikehu | s/deleting/extending | 11:00 |
ganso | tommylikehu: sorry s/reverting/extending | 11:00 |
*** akapil has quit IRC | 11:00 | |
ganso | tommylikehu: I had "revert-to-snapshot" on my mind | 11:01 |
tommylikehu | ok, wait a second | 11:01 |
ganso | tommylikehu: from what I see, there is currently no control of that because extending is an operation on a share, and deleting is an operation on the snapshot | 11:01 |
tommylikehu | ganso: please take a look at line 132 | 11:02 |
tommylikehu | https://review.openstack.org/#/c/431315/16/manila/share/drivers/lvm.py | 11:02 |
ganso | tommylikehu: so it looks a bit more plausible that the snapshot shouldn't be allowed to be deleted if the share is busy extending | 11:02 |
tommylikehu | ganso: actually we collect all the snapshots, not related to this volume | 11:02 |
tommylikehu | and choose the correct ones by lvdisplay origin command | 11:03 |
tommylikehu | so we could have other snapshots | 11:03 |
ganso | tommylikehu: oh I see, so, after you listed the snapshot, it goes missing, and the next command fails, correct? | 11:03 |
tommylikehu | ganso: you are right | 11:03 |
tommylikehu | ganso: this error is caused by your comments that we should not pass the related snapshots from manila to driver :) | 11:04 |
*** akapil has joined #openstack-manila | 11:05 | |
ganso | tommylikehu: hold on I gotta refresh my memory | 11:05 |
ganso | tommylikehu: I need to remember why I said that | 11:05 |
ganso | tommylikehu: I am looking at previous patchsets | 11:05 |
*** akapil has quit IRC | 11:06 | |
tommylikehu | ganso: I am just kidding, your comments are right | 11:06 |
*** akapil has joined #openstack-manila | 11:06 | |
ganso | tommylikehu: lol, ok, then maybe a try/except block could work? | 11:06 |
ganso | tommylikehu: like, if the snapshot does not exist anymore, you shouldn't have to worry about it | 11:06 |
ganso | tommylikehu: if it is not related, that's fine, if it was related, it is gone and unmounted already | 11:07 |
ganso | tommylikehu: I don't like the idea of preventing snapshot deletion when share is extending, and we would still need the try/except block for the unrelated snapshots that may go missing | 11:07 |
tommylikehu | ganso: I am sorry where does your idea ' preventing snapshot deletion when share is extending' comes from, Is that one of my suggestions? | 11:09 |
ganso | tommylikehu: no, I said I do not like that idea very much | 11:10 |
ganso | tommylikehu: it came from me | 11:10 |
tommylikehu | ganso: ok~ | 11:10 |
ganso | tommylikehu: what do you think about the try/except block? | 11:12 |
tommylikehu | ganso: to be clear the snapshots are different in this case. but your concern could be a bug for this feature. | 11:12 |
tommylikehu | ganso: a valid bug | 11:12 |
ganso | tommylikehu: the main problem about that idea is that it wouldn't make sense for other drivers | 11:12 |
ganso | tommylikehu: why a valid bug? are you saying we cannot address this bug in other ways? | 11:12 |
tommylikehu | ganso: If we call extending share and deleting snapshot of this share at the same time, does this could happen? | 11:14 |
ganso | tommylikehu: it could happen, yes, why prevent it? | 11:14 |
ganso | tommylikehu: it seems only LVM has this bug, we should address it in the driver if possible | 11:15 |
tommylikehu | ganso: any suggestion on this? | 11:25 |
ganso | tommylikehu: ok I had suggested a try/except block, but I see the command does not fail | 11:30 |
tommylikehu | ganso: try/excerpt block for what? | 11:31 |
ganso | tommylikehu: for a command that would fail | 11:31 |
ganso | tommylikehu: wait, I am very confused | 11:32 |
ganso | tommylikehu: the link you gave me http://logs.openstack.org/15/431315/15/check/gate-manila-tempest-minimal-dsvm-lvm-ubuntu-xenial/4e4ec52/logs/screen-m-shr.txt.gz?#_2017-03-07_02_44_27_927 | 11:32 |
ganso | tommylikehu: shows that the command succeeded, but below the command fails | 11:32 |
tommylikehu | ganso lvremove command succeed and lvdisplay command failed | 11:33 |
ganso | tommylikehu: oh great! so we can use the try/except block | 11:33 |
ganso | tommylikehu: for the lvdisplay command | 11:33 |
ganso | tommylikehu: if it fails, you could just skip | 11:33 |
ganso | tommylikehu: what do you think about that? | 11:33 |
tommylikehu | ganso: you mean: https://review.openstack.org/#/c/431315/16/manila/share/drivers/lvm.py line110? | 11:34 |
ganso | tommylikehu: yes | 11:34 |
tommylikehu | ganso: it's already done | 11:34 |
ganso | tommylikehu: oh so that log is from a previous patchset | 11:35 |
*** openstackgerrit has joined #openstack-manila | 11:35 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [DNM] Squash SGS member and SS instances DB tables https://review.openstack.org/442115 | 11:35 |
tommylikehu | ganso: yes | 11:35 |
ganso | tommylikehu: I am seeing the diff now | 11:36 |
ganso | tommylikehu: ok cool | 11:36 |
tommylikehu | hey vponomaryov I see a lot of patches with a DNM label. what does DNM mean? | 11:36 |
vponomaryov | Do Not Merge | 11:36 |
tommylikehu | vponomaryov: thanks | 11:37 |
openstackgerrit | Merged openstack/manila master: Start NFS and SMB services on fedora platforms https://review.openstack.org/442073 | 11:37 |
ganso | tommylikehu: I'd like tbarron's centOS patch to merge before +2'ing your patch | 11:37 |
ganso | tommylikehu: there we go ^ | 11:37 |
ganso | tommylikehu: ok, I'll recheck your patch, and centOS job should pass | 11:38 |
tommylikehu | ganso: thanks | 11:38 |
ganso | tommylikehu: thanks for working on this fix | 11:38 |
vponomaryov | tommylikehu: about https://review.openstack.org/#/c/431315/16/manila_tempest_tests/tests/api/test_shares_actions.py | 11:46 |
vponomaryov | tommylikehu: why do you use "STATUS_EXTENDING_ERROR" there? | 11:46 |
vponomaryov | tommylikehu: just to reduce wait time? | 11:46 |
vponomaryov | tommylikehu: if error appears? | 11:47 |
vponomaryov | if yes, then line 366 in https://review.openstack.org/#/c/431315/16/manila_tempest_tests/services/share/v2/json/shares_client.py already solves this case | 11:47 |
vponomaryov | tommylikehu: so, for the moment, I do not see the reason of update of https://review.openstack.org/#/c/431315/16/manila_tempest_tests/services/share/v2/json/shares_client.py | 11:48 |
vponomaryov | ganso ^ | 11:49 |
ganso | vponomaryov: he wants to accept ["Available", "Extending_error"] | 11:50 |
vponomaryov | why? | 11:50 |
vponomaryov | my question was and is "why" | 11:50 |
ganso | vponomaryov: because of additional checks in the test | 11:54 |
ganso | vponomaryov: you could take a look at the previous patchset comments | 11:54 |
ganso | vponomaryov: as it was before, it was accepting only "available". So it the wait function was either going to fail the test if the status was "extending_error", or if status reaches available, there was no need for further validation | 11:55 |
ganso | vponomaryov: I suggested that tommylikehu could remove the validation, or add a way to the code to continue if status was "extending_error". He chose to implement the latter | 11:56 |
vponomaryov | ganso: validation of size is a must anyway | 11:58 |
vponomaryov | second status is redundant | 11:58 |
vponomaryov | changes to client redundant too | 11:58 |
vponomaryov | expected success status only one - available | 11:58 |
vponomaryov | as it is now | 11:58 |
vponomaryov | ganso: file https://review.openstack.org/#/c/431315/16/manila_tempest_tests/tests/api/test_shares_actions.py does not have comments related to my question | 11:59 |
ganso | vponomaryov: why is it a must? it is an API contract that if status changes from extending to available, the size will be changed regardless | 11:59 |
vponomaryov | ganso: in none of patch sets | 11:59 |
ganso | vponomaryov: it does https://review.openstack.org/#/c/431315/8/manila_tempest_tests/tests/api/test_shares_actions.py | 12:00 |
vponomaryov | ganso: in https://review.openstack.org/#/c/431315/8/manila_tempest_tests/tests/api/test_shares_actions.py your comment for line 593 is false | 12:01 |
vponomaryov | it will not timeout | 12:01 |
vponomaryov | so, this variant is correct | 12:01 |
ganso | vponomaryov: yes it will fail, because it has "error" in the status | 12:01 |
vponomaryov | it will not TIMEOUT | 12:02 |
ganso | vponomaryov: Valeriy, if it fails, it will not proceed to the validations | 12:02 |
vponomaryov | it will fail immediatly | 12:02 |
ganso | vponomaryov: yes I noticed it will not timeout, but it will fail, and will not proceed to the validations | 12:03 |
ganso | vponomaryov: so the only case it will proceed to the validations is of success, and in that case, API contract already guarantees size increase, and this is covered in other tests | 12:03 |
ganso | vponomaryov: so size validation would be redundant | 12:03 |
vponomaryov | ganso: why is that? | 12:04 |
vponomaryov | ganso: you check status first, then size as second | 12:04 |
vponomaryov | ganso: and fail on any of them | 12:04 |
ganso | vponomaryov: no need to check size if it transitions to "available" | 12:04 |
ganso | vponomaryov: it will not fail if wait function succeeds | 12:04 |
vponomaryov | ganso: success of status has nothing to prove about size | 12:05 |
vponomaryov | at all | 12:05 |
vponomaryov | it is 2 separate things | 12:05 |
ganso | vponomaryov: that behavior is covered in another test | 12:05 |
vponomaryov | and comment for line 604 https://review.openstack.org/#/c/431315/8/manila_tempest_tests/tests/api/test_shares_actions.py is false too | 12:06 |
ganso | vponomaryov: it is part of the feature workflow to increase the size when transitioning from extending to available | 12:06 |
vponomaryov | ganso: it is test | 12:08 |
vponomaryov | its goal is to validate | 12:08 |
ganso | vponomaryov: feel free to add comments in the patch to change it how you'd like then | 12:08 |
vponomaryov | presence of snapshot may touch different code and we can have bug only here | 12:08 |
vponomaryov | so, check for size is a must and second status is redundant | 12:09 |
vponomaryov | tommylikehu: also, you fix case with "mounted" snapshot | 12:10 |
vponomaryov | tommylikehu: would be good to add such test | 12:10 |
*** tuanluong has quit IRC | 12:11 | |
*** faizy has quit IRC | 12:12 | |
*** dgonzalez has quit IRC | 12:22 | |
*** catintheroof has joined #openstack-manila | 12:24 | |
*** erlon has joined #openstack-manila | 12:43 | |
*** chlong has joined #openstack-manila | 13:00 | |
*** porrua has joined #openstack-manila | 13:01 | |
*** faizy has joined #openstack-manila | 13:01 | |
*** dustins has joined #openstack-manila | 13:02 | |
*** porrua_ has joined #openstack-manila | 13:02 | |
*** esker has joined #openstack-manila | 13:03 | |
*** porrua has quit IRC | 13:06 | |
*** dsariel has quit IRC | 13:06 | |
*** esker has quit IRC | 13:08 | |
*** eharney has quit IRC | 13:12 | |
*** faizy has quit IRC | 13:20 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [Share Groups] Squash SGS member and SS instances DB tables https://review.openstack.org/433854 | 13:24 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [DNM] test share groups https://review.openstack.org/430296 | 13:28 |
*** tommylikehu_ has joined #openstack-manila | 13:37 | |
*** gouthamr has joined #openstack-manila | 13:43 | |
*** lpetrut has quit IRC | 13:49 | |
*** crushil has joined #openstack-manila | 13:55 | |
*** gouthamr has quit IRC | 13:59 | |
*** gouthamr has joined #openstack-manila | 14:02 | |
*** rraja has quit IRC | 14:03 | |
*** lpetrut has joined #openstack-manila | 14:09 | |
*** xyang1 has joined #openstack-manila | 14:15 | |
*** rraja has joined #openstack-manila | 14:18 | |
*** ociuhandu has quit IRC | 14:18 | |
*** ociuhandu has joined #openstack-manila | 14:29 | |
*** cknight has joined #openstack-manila | 14:47 | |
*** mtanino has joined #openstack-manila | 14:49 | |
*** Yogi1 has joined #openstack-manila | 14:49 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [Share Groups] Squash SGS member and SS instances DB tables https://review.openstack.org/433854 | 14:50 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [DNM] test share groups https://review.openstack.org/430296 | 14:51 |
*** sandanar has joined #openstack-manila | 14:59 | |
*** pcaruana has quit IRC | 15:09 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: Update share replicas after promotion in proper order https://review.openstack.org/438892 | 15:13 |
*** pcaruana has joined #openstack-manila | 15:23 | |
*** dgonzalez has joined #openstack-manila | 15:24 | |
*** sandanar has quit IRC | 15:33 | |
*** tommylikehu_ has quit IRC | 15:33 | |
*** dsariel has joined #openstack-manila | 15:43 | |
*** eharney has joined #openstack-manila | 15:45 | |
*** jprovazn has quit IRC | 15:49 | |
*** nkrinner is now known as nkrinner_afk | 15:53 | |
*** lpetrut has quit IRC | 16:03 | |
*** akapil_ has joined #openstack-manila | 16:17 | |
*** akapil_ has quit IRC | 16:17 | |
*** akapil has quit IRC | 16:20 | |
*** belmoreira has quit IRC | 16:22 | |
*** crushil has quit IRC | 16:22 | |
*** pcaruana has quit IRC | 16:26 | |
*** esker has joined #openstack-manila | 16:29 | |
*** esker has quit IRC | 16:29 | |
gouthamr | vponomaryov: https://review.openstack.org/#/c/438892/3/manila/share/manager.py you live and you learn | 16:29 |
gouthamr | :P | 16:29 |
*** rraja has quit IRC | 16:35 | |
*** eharney_ has joined #openstack-manila | 16:36 | |
*** eharney has quit IRC | 16:38 | |
*** eharney_ is now known as eharney | 16:39 | |
*** JoseMello has joined #openstack-manila | 16:39 | |
gouthamr | vponomaryov: mind if i submit the next patch? | 16:45 |
vponomaryov | gouthamr: in my commit? | 16:45 |
gouthamr | vponomaryov: yes.. we're fixing the bug eventually, want to do it right.. i don't agree with you that it's unrelated. the bug existed because of all the complicated things shoved into one long inseparable flow | 16:46 |
vponomaryov | gouthamr: I mind, actually | 16:47 |
gouthamr | vponomaryov: haha. okay. feel free to merge yours then, i'll commit the refactor | 16:47 |
*** crushil has joined #openstack-manila | 16:48 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [Tempest] Fix concurrency in test with listing share servers https://review.openstack.org/442633 | 17:23 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [Tempest] Fix concurrency in test with listing share servers https://review.openstack.org/442633 | 17:26 |
*** david-lyle_ has joined #openstack-manila | 17:52 | |
*** david-lyle has quit IRC | 17:54 | |
*** david-lyle_ is now known as david-lyle | 17:55 | |
*** david-lyle has quit IRC | 18:04 | |
*** david-lyle has joined #openstack-manila | 18:05 | |
*** a-pugachev has quit IRC | 18:06 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: [Tempest] Fix concurrency in test with listing share servers https://review.openstack.org/442633 | 18:22 |
*** david-lyle has quit IRC | 18:23 | |
*** david-lyle has joined #openstack-manila | 18:25 | |
*** david-lyle has quit IRC | 18:29 | |
*** david-lyle has joined #openstack-manila | 18:36 | |
*** eharney has quit IRC | 18:41 | |
*** eharney has joined #openstack-manila | 18:45 | |
*** david-lyle has quit IRC | 19:04 | |
*** david-lyle has joined #openstack-manila | 19:06 | |
*** crushil has quit IRC | 19:08 | |
*** crushil has joined #openstack-manila | 19:18 | |
openstackgerrit | Andrea Frittoli proposed openstack/manila master: Local copy of scenario test base class https://review.openstack.org/442719 | 19:18 |
*** markstur has joined #openstack-manila | 19:19 | |
*** gouthamr has quit IRC | 20:01 | |
*** dsariel has quit IRC | 20:07 | |
*** dustins has quit IRC | 20:15 | |
*** dsariel has joined #openstack-manila | 20:20 | |
*** gouthamr has joined #openstack-manila | 20:29 | |
*** JoseMello has quit IRC | 20:35 | |
*** dustins has joined #openstack-manila | 20:55 | |
*** lpetrut has joined #openstack-manila | 21:07 | |
*** eharney has quit IRC | 21:13 | |
*** eharney has joined #openstack-manila | 21:29 | |
*** Yogi1 has quit IRC | 21:36 | |
*** gouthamr has quit IRC | 21:37 | |
*** cknight has quit IRC | 21:51 | |
*** gouthamr has joined #openstack-manila | 21:59 | |
*** crushil has quit IRC | 22:00 | |
*** porrua_ has quit IRC | 22:06 | |
*** cknight has joined #openstack-manila | 22:13 | |
*** cknight1 has joined #openstack-manila | 22:19 | |
*** cknight has quit IRC | 22:21 | |
*** ganso has quit IRC | 22:25 | |
*** lpetrut has quit IRC | 22:26 | |
*** cknight1 has quit IRC | 22:28 | |
openstackgerrit | Alex Schultz proposed openstack/puppet-manila master: Prepare Pike metadata https://review.openstack.org/442824 | 22:34 |
*** catintheroof has quit IRC | 22:41 | |
*** catintheroof has joined #openstack-manila | 22:42 | |
*** catintheroof has quit IRC | 22:47 | |
*** dustins has quit IRC | 22:52 | |
*** erlon has quit IRC | 23:05 | |
*** eharney has quit IRC | 23:16 | |
*** ociuhandu has quit IRC | 23:17 | |
*** xyang1 has quit IRC | 23:27 | |
*** jungleboyj has joined #openstack-manila | 23:31 | |
*** catintheroof has joined #openstack-manila | 23:32 | |
*** ociuhandu has joined #openstack-manila | 23:40 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!