*** erlon has quit IRC | 00:00 | |
*** ganso has quit IRC | 00:04 | |
openstackgerrit | Merged openstack/manila-test-image: Support testing on Fedora https://review.openstack.org/426804 | 00:09 |
---|---|---|
*** xyang1 has quit IRC | 00:12 | |
*** esker has quit IRC | 00:19 | |
*** tinwood has quit IRC | 00:20 | |
*** tinwood has joined #openstack-manila | 00:21 | |
*** esker has joined #openstack-manila | 00:41 | |
*** openstackgerrit has quit IRC | 01:02 | |
*** esker has quit IRC | 01:03 | |
*** mtanino has quit IRC | 01:53 | |
*** cdelatte has quit IRC | 02:19 | |
*** kaisers_ has joined #openstack-manila | 02:53 | |
*** kaisers has quit IRC | 02:56 | |
*** mtanino has joined #openstack-manila | 03:20 | |
*** gouthamr has quit IRC | 03:24 | |
*** mtanino has quit IRC | 03:24 | |
*** gaurangt has joined #openstack-manila | 03:36 | |
*** test123 has joined #openstack-manila | 04:21 | |
*** akapil has joined #openstack-manila | 04:21 | |
*** test123 has quit IRC | 04:24 | |
*** gaurangt has left #openstack-manila | 04:25 | |
*** akapil has quit IRC | 04:25 | |
*** gaurangt has joined #openstack-manila | 04:26 | |
*** kaisers_ has quit IRC | 06:09 | |
*** zhonghua2 has joined #openstack-manila | 06:10 | |
*** zhonghua has quit IRC | 06:12 | |
*** mnaser has quit IRC | 06:12 | |
*** rhefner has quit IRC | 06:13 | |
*** lpetrut has joined #openstack-manila | 06:18 | |
*** kaisers has joined #openstack-manila | 06:30 | |
*** mnaser has joined #openstack-manila | 06:35 | |
*** tommylikehu_ has joined #openstack-manila | 07:04 | |
*** lpetrut has quit IRC | 07:07 | |
*** kaisers has quit IRC | 07:16 | |
*** kaisers has joined #openstack-manila | 07:17 | |
*** jprovazn has joined #openstack-manila | 07:25 | |
*** lpetrut has joined #openstack-manila | 07:29 | |
*** a-pugachev has joined #openstack-manila | 07:32 | |
*** a-pugachev has quit IRC | 07:32 | |
*** pcaruana has joined #openstack-manila | 07:39 | |
*** pcaruana has quit IRC | 07:42 | |
*** pcaruana has joined #openstack-manila | 07:43 | |
*** nkrinner_afk is now known as nkrinner | 07:45 | |
*** lpetrut has quit IRC | 08:07 | |
*** lpetrut has joined #openstack-manila | 08:18 | |
*** shausy has joined #openstack-manila | 08:22 | |
*** openstackgerrit has joined #openstack-manila | 08:40 | |
openstackgerrit | Tatiana Ovchinnikova proposed openstack/manila-ui master: Fix Manage Replicas button availability https://review.openstack.org/368726 | 08:40 |
*** tommylikehu_ has quit IRC | 08:40 | |
*** akapil has joined #openstack-manila | 08:41 | |
*** akapil has quit IRC | 08:44 | |
*** akapil has joined #openstack-manila | 08:51 | |
*** lpetrut has quit IRC | 08:57 | |
*** lpetrut has joined #openstack-manila | 09:01 | |
*** lpetrut has quit IRC | 09:19 | |
*** yumiriam has joined #openstack-manila | 09:48 | |
*** ganso has joined #openstack-manila | 09:50 | |
*** akapil has quit IRC | 09:56 | |
*** makowals has quit IRC | 09:56 | |
*** makowals has joined #openstack-manila | 09:59 | |
*** akapil has joined #openstack-manila | 10:04 | |
*** alyson_ has joined #openstack-manila | 10:10 | |
*** makowals has quit IRC | 10:15 | |
*** makowals has joined #openstack-manila | 10:26 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: [DEBUG] Some CI testing https://review.openstack.org/426762 | 10:34 |
openstackgerrit | Alyson proposed openstack/manila master: Fix HNAS driver always handling mountable snapshots https://review.openstack.org/428077 | 10:36 |
*** erlon has joined #openstack-manila | 10:45 | |
*** a-pugachev has joined #openstack-manila | 10:48 | |
openstackgerrit | Miriam Yumi proposed openstack/manila master: HNAS: Fix managed snapshots not being mounted https://review.openstack.org/427616 | 10:58 |
*** lpetrut has joined #openstack-manila | 11:01 | |
*** makowals has quit IRC | 11:06 | |
openstackgerrit | Alyson proposed openstack/manila master: Fix HNAS driver always handling mountable snapshots https://review.openstack.org/428077 | 11:13 |
*** ociuhandu has quit IRC | 11:17 | |
*** makowals has joined #openstack-manila | 11:19 | |
*** akapil has quit IRC | 11:25 | |
*** dsariel has quit IRC | 11:31 | |
*** tinwood is now known as tinwood_afk | 11:44 | |
*** dsariel has joined #openstack-manila | 11:44 | |
*** akapil has joined #openstack-manila | 11:45 | |
*** catintheroof has joined #openstack-manila | 11:47 | |
jprovazn | ameade: hello | 11:48 |
*** akapil has quit IRC | 11:50 | |
*** jcsp has quit IRC | 11:51 | |
openstackgerrit | Merged openstack/manila-ui master: Fix Manage Replicas button availability https://review.openstack.org/368726 | 11:54 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions https://review.openstack.org/427660 | 11:56 |
*** openstackgerrit has quit IRC | 12:03 | |
*** akapil has joined #openstack-manila | 12:06 | |
*** ociuhandu has joined #openstack-manila | 12:21 | |
*** openstackgerrit has joined #openstack-manila | 12:21 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: Fix default approach for share group snapshot creation https://review.openstack.org/427811 | 12:21 |
*** makowals has quit IRC | 12:44 | |
*** makowals has joined #openstack-manila | 12:45 | |
*** assassin has quit IRC | 12:52 | |
*** ubijtsa has joined #openstack-manila | 12:52 | |
*** ubijtsa has quit IRC | 12:52 | |
*** ubijtsa has joined #openstack-manila | 12:52 | |
*** ubijtsa is now known as assassin | 12:55 | |
*** lseki has joined #openstack-manila | 12:59 | |
*** gcb has joined #openstack-manila | 13:00 | |
*** gouthamr has joined #openstack-manila | 13:12 | |
*** jprovazn has quit IRC | 13:21 | |
*** jprovazn has joined #openstack-manila | 13:23 | |
*** eharney has quit IRC | 13:29 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: Fix default approach for share group snapshot creation https://review.openstack.org/427811 | 13:32 |
*** shausy has quit IRC | 13:36 | |
*** akapil has quit IRC | 13:45 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila master: Fix default approach for share group snapshot creation https://review.openstack.org/427811 | 13:46 |
*** crushil has quit IRC | 13:56 | |
*** eharney has joined #openstack-manila | 14:02 | |
*** dsariel has quit IRC | 14:04 | |
*** gcb has quit IRC | 14:05 | |
*** eharney has quit IRC | 14:07 | |
*** akapil has joined #openstack-manila | 14:08 | |
*** dustins has joined #openstack-manila | 14:09 | |
vponomaryov | rhagarty: according to your topic for weekly meeting, we have appropriate API and client method for it -> "$ manila -d api-version" | 14:11 |
vponomaryov | rhagarty: doesn't it solve the needs you describe in topic? | 14:12 |
*** jcsp has joined #openstack-manila | 14:15 | |
*** dustins has quit IRC | 14:17 | |
*** dustins has joined #openstack-manila | 14:17 | |
*** crushil has joined #openstack-manila | 14:19 | |
*** eharney has joined #openstack-manila | 14:19 | |
*** jprovazn has quit IRC | 14:21 | |
*** jcsp has quit IRC | 14:27 | |
*** xyang_ has joined #openstack-manila | 14:28 | |
*** porrua has joined #openstack-manila | 14:28 | |
vponomaryov | rraja: Hello, are you aware that Ci job for "glusterfs-native" driver constantly fails? | 14:31 |
vponomaryov | csaba: ^ | 14:32 |
*** jprovazn has joined #openstack-manila | 14:33 | |
*** jprovazn is now known as jprovazn_ | 14:33 | |
*** jprovazn_ is now known as jprovazn | 14:33 | |
csaba | vponomaryov: what I know that tbarron had invested some effort to fix it up, but I haven't synced up with him on that. | 14:33 |
openstackgerrit | Merged openstack/manila master: Decrease share migration periodic task interval https://review.openstack.org/427099 | 14:34 |
*** sandanar has joined #openstack-manila | 14:35 | |
rraja | vponomaryov: yes. | 14:35 |
*** jprovazn has quit IRC | 14:36 | |
vponomaryov | csaba, rraja: tbarron is responsible for maintenance of this job now? Is it correct? | 14:37 |
rraja | vponomaryov: I think it's csaba and I. tbarron has been helping out. | 14:39 |
vponomaryov | csaba, rraja: as I can see now from logs, job config requires update, based on this error in scheduler -> Share type extra spec requirement "create_share_from_snapshot_support=<is> False" does not match reported capability "True" | 14:39 |
bswartz | vponomaryov: how many open bugs remain on share groups? | 14:39 |
vponomaryov | bswartz: you mean targeted? | 14:40 |
vponomaryov | to rc1& | 14:40 |
vponomaryov | ? | 14:40 |
rraja | vponomaryov: we'll look into it. thanks for the pointer. | 14:40 |
bswartz | vponomaryov: https://wiki.openstack.org/wiki/Manila/Meetings | 14:40 |
bswartz | I put an agenda item for the meeting to discuss share groups remaining issues | 14:40 |
bswartz | I'm sure I missed 1 or 2 known issues | 14:41 |
bswartz | I'm going to propose disabling the APIs for Ocata until we fix the remaining bugs in Pike | 14:41 |
vponomaryov | bswartz: disabling APIs? | 14:42 |
vponomaryov | bswartz: first 2 are finished | 14:42 |
vponomaryov | from list | 14:42 |
vponomaryov | third in netapp only and forth - even not sure | 14:43 |
bswartz | Yes I'm worried that leaving the API enabled will cause problems | 14:43 |
bswartz | I'm writing some more bugs as I think of them | 14:43 |
*** crushil has quit IRC | 14:43 | |
*** dustins has quit IRC | 14:43 | |
*** crushil has joined #openstack-manila | 14:44 | |
*** dustins has joined #openstack-manila | 14:44 | |
bswartz | maybe all of the remaining issues are specific to the consistent_snapshot group type extra spec | 14:45 |
vponomaryov | bswartz: we even haven't discussed group specs | 14:46 |
vponomaryov | bswartz: I consider absence of group specs as expected for now | 14:47 |
rhagarty | vponomaryov: does it consider that client might be out of sync with service? or do you think that is not an issue? | 14:48 |
vponomaryov | rhagarty: what do you mean by "out of sync"? | 14:49 |
vponomaryov | rhagarty: client requests root URL | 14:49 |
vponomaryov | rhagarty: server ignores microversion | 14:50 |
vponomaryov | rhagarty: and returns list of supported APIs with their microversions | 14:50 |
rhagarty | vponomaryov: ok - I will try it out | 14:51 |
*** xyang_ has quit IRC | 14:53 | |
rhagarty | vponomaryov: what I meant by out of sync is the client might be older than service. Service might support 2.51, but older client doesn't have support for feature added in 2.44, for ex. | 14:55 |
vponomaryov | rhagarty: how is it related to possibility to get list of supported microversions? | 14:55 |
*** xyang_ has joined #openstack-manila | 14:56 | |
rhagarty | vponomaryov: current microversion support is just returned by endpoint, without regard to what client version is | 14:57 |
rhagarty | vponomaryov: am thinking this may become an issue as we add more and more features based on microversion. maybe not... | 14:59 |
vponomaryov | rhagarty: your topic says "provide an easy way for other projects to know our current supported microversion?" - I mentioned the way it is possible now | 14:59 |
vponomaryov | you can get it now either from server directly or via client | 15:00 |
rhagarty | vponomaryov: - from manila-ui perspective. let me play with it some | 15:00 |
rhagarty | vponomaryov: ok - thanks. I will try it ot | 15:00 |
*** Yogi1 has joined #openstack-manila | 15:00 | |
rhagarty | ot/ot | 15:00 |
ganso | gouthamr: Hi Goutham, could you please +W https://review.openstack.org/#/c/427101 ? | 15:00 |
rhagarty | ot/out | 15:00 |
bswartz | --> #openstack-meeting-alt <-- | 15:01 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions https://review.openstack.org/427660 | 15:03 |
*** jprovazn has joined #openstack-manila | 15:04 | |
*** tinwood_afk is now known as tinwood | 15:05 | |
*** rraja_ has joined #openstack-manila | 15:06 | |
*** rraja has quit IRC | 15:06 | |
*** rraja_ has quit IRC | 15:11 | |
openstackgerrit | Merged openstack/manila master: Fix setup of DHSS=False mode for generic driver https://review.openstack.org/426737 | 15:11 |
*** mtanino has joined #openstack-manila | 15:13 | |
*** xyang_ has quit IRC | 15:16 | |
*** xyang_ has joined #openstack-manila | 15:18 | |
*** rraja_ has joined #openstack-manila | 15:20 | |
*** jcsp has joined #openstack-manila | 15:22 | |
*** rraja_ has quit IRC | 15:25 | |
*** rraja_ has joined #openstack-manila | 15:25 | |
*** breitz has quit IRC | 15:33 | |
*** breitz has joined #openstack-manila | 15:34 | |
*** sandanar has quit IRC | 15:36 | |
*** rraja_ has quit IRC | 15:38 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Blocked migration of shares within share groups https://review.openstack.org/427834 | 15:38 |
openstackgerrit | Miriam Yumi proposed openstack/manila master: HNAS: Fix managed snapshots not being mounted https://review.openstack.org/427616 | 15:47 |
openstackgerrit | Merged openstack/manila master: Enable host-assisted migration in ZFSOnLinux CI https://review.openstack.org/427101 | 16:02 |
openstackgerrit | Tom Barron proposed openstack/manila master: Do Not Merge https://review.openstack.org/428230 | 16:03 |
*** dsariel has joined #openstack-manila | 16:04 | |
ganso | vponomaryov: if you could please +W the patches that you +2'ed, have 2 +2, green CI (basically all 4 of them), and there's nothing holding back, it would be great to merge asap so we can rebase asap if they end up conflicting with each other when merging. Here are the links: https://review.openstack.org/428077 https://review.openstack.org/426806 | 16:13 |
ganso | https://review.openstack.org/#/c/427096 and https://review.openstack.org/427332 | 16:13 |
bswartz | ganso: +1 | 16:14 |
bswartz | get those merge conflicts out of the way! | 16:14 |
bswartz | (hopefully not to many merge conflits between bugfixes) | 16:15 |
*** kberger has joined #openstack-manila | 16:25 | |
*** xyang_ has quit IRC | 16:56 | |
*** hoonetorg has quit IRC | 17:03 | |
*** hoonetorg has joined #openstack-manila | 17:04 | |
*** xyang_ has joined #openstack-manila | 17:06 | |
*** xyang_ has quit IRC | 17:07 | |
openstackgerrit | Alyson proposed openstack/manila master: HNAS: Fix syntax to make shares read-only in snapshot create https://review.openstack.org/428267 | 17:11 |
*** akapil_ has joined #openstack-manila | 17:15 | |
openstackgerrit | Merged openstack/manila master: HNAS: Fix concurrency error when managing snapshots https://review.openstack.org/426806 | 17:17 |
openstackgerrit | Merged openstack/manila master: HNAS: avoid mismatch access level for managed shares https://review.openstack.org/427096 | 17:17 |
openstackgerrit | Merged openstack/manila master: Fix snapshot export locations incorrectly handled https://review.openstack.org/427332 | 17:17 |
*** mtanino_ has joined #openstack-manila | 17:18 | |
*** mtanino__ has joined #openstack-manila | 17:19 | |
*** akapil has quit IRC | 17:19 | |
*** mtanino has quit IRC | 17:19 | |
*** timcl has quit IRC | 17:19 | |
*** akapil_ has quit IRC | 17:20 | |
*** mtanino_ has quit IRC | 17:22 | |
*** dsariel has quit IRC | 17:24 | |
*** timcl has joined #openstack-manila | 17:24 | |
*** xyang_ has joined #openstack-manila | 17:25 | |
*** xyang_ has quit IRC | 17:26 | |
*** hoonetorg has quit IRC | 17:38 | |
*** chlong has joined #openstack-manila | 17:39 | |
*** hoonetorg has joined #openstack-manila | 17:40 | |
*** nkrinner is now known as nkrinner_afk | 17:41 | |
markstur | ganso: https://review.openstack.org/#/c/428267/1 | 17:44 |
markstur | ganso: ^ what the heck? | 17:44 |
ganso | markstur: lol | 17:44 |
ganso | markstur: for HNAS we always make the share readonly | 17:45 |
ganso | markstur: when taking snapshots | 17:45 |
*** xyang_ has joined #openstack-manila | 17:45 | |
markstur | does user get stale mounts or just fail when trying to save stuff? | 17:45 |
markstur | I mean is it really bad or just bad | 17:45 |
ganso | markstur: does not get stable mount at all | 17:46 |
ganso | markstur: *stale | 17:46 |
markstur | That is good. | 17:46 |
ganso | markstur: it is very seamless | 17:46 |
ganso | markstur: if application is writing to disc, it gets a "filesystem is read-only" message from the OS | 17:46 |
*** hoonetorg has quit IRC | 17:47 | |
markstur | Seriously, you do what you need to do, but I didn't know manila share might fail on write when someone takes a snap | 17:47 |
*** xyang_ has quit IRC | 17:47 | |
markstur | ganso: So the app fails | 17:47 |
ganso | markstur: but this is very fast, as the create_snapshot operation is efficient by only creating links/references | 17:47 |
vponomaryov | markstur: suddenly )) | 17:47 |
markstur | or the write fails or the transaction fails, whatever | 17:47 |
vponomaryov | markstur: I am surprised too ) | 17:47 |
vponomaryov | ganso: why it just does not hand a bit? | 17:48 |
markstur | well if it is so fast that nobody notices then it is not a problem :) | 17:48 |
vponomaryov | s/hand/hang/ | 17:48 |
markstur | It is a "flash" snap | 17:48 |
* markstur looks to see if anyone is using "flash" for anything important or trademarks it | 17:48 | |
ganso | vponomaryov, markstur: unfortunately, we cannot freeze/delay I/O with this mechanism... there is another mechanism that is capable of that, and it is consistent, but it takes snapshot of the whole filesystem... | 17:49 |
ganso | vponomaryov: "does not hand a bit" ? sorry I don't get the expression | 17:49 |
markstur | I suppose it is one of those things where you get a support call and the support folks says "try again" and the write works, so they say call closed | 17:49 |
ganso | markstur: yes, kinda like that | 17:49 |
ganso | markstur: for CIFS it is more complicated | 17:50 |
vponomaryov | ganso: "does not hanG a bit" | 17:50 |
* markstur grumbles | 17:50 | |
ganso | vponomaryov: oh... as I said above, we cannot freeze/delay I/O in this mechanism | 17:50 |
vponomaryov | ganso: yeah, its ok )) | 17:50 |
ganso | markstur: for CIFS we have a config option to say "Error, please unmount your share when taking snapshots" | 17:51 |
markstur | nice | 17:51 |
ganso | markstur: or, if option is not enabled, take snapshots anyway at your own risk | 17:51 |
gouthamr | ganso: typically, people go out and build stuff into the applications if applications have to be quiesced.. | 17:52 |
markstur | ganso: ? what do you mean option not enabled? You mean outside of manila? | 17:52 |
vponomaryov | ganso: if your data stayed consistent, we are sorry, it is completely accidentally? )) | 17:52 |
ganso | markstur: in manila | 17:52 |
gouthamr | ganso: i feel there's no need to protect your share through manila | 17:52 |
ganso | markstur: in the config | 17:52 |
*** xyang_ has joined #openstack-manila | 17:52 | |
markstur | create snapshot --lossy-is-fine | 17:53 |
ganso | gouthamr: we don't know how it is used for, so without much effort, we added a little config option | 17:53 |
ganso | create snapshot --i-dont-care-if-it-is-consistent | 17:53 |
gouthamr | :P | 17:53 |
markstur | ganso: I'm a fan of toggles. If they want to turn it off, then good. | 17:53 |
*** xyang_ has quit IRC | 17:54 | |
markstur | ganso: put a ' in don't. So you have to be an advanced user to escape it properly | 17:54 |
ganso | markstur: good, it will be an option only for advanced users | 17:55 |
markstur | So ultimately I think we hopefully don't need more snapshot options (that was so ocata) but perhaps this superfast glitch is just something that maybe is an HNAS bug(?) so a "known limitation" which may or may not ever get fixed | 17:56 |
*** lpetrut has quit IRC | 17:56 | |
vponomaryov | markstur: GPFS is not like that? )) | 17:57 |
vponomaryov | markstur: how is it done there? | 17:57 |
*** xyang_ has joined #openstack-manila | 17:57 | |
markstur | vponomaryov: Hey! What? | 17:57 |
vponomaryov | markstur: snapshotting and access to share being snapshotted at once? | 17:57 |
markstur | Oh. I haven't seen any problem snapshotting while accessing, but maybe I wouldn't know yet. | 17:58 |
markstur | I'd assume most have figured out how to do live snaps, but... | 17:58 |
markstur | exactly how consistent and "crash-consistent"' does vary | 17:58 |
*** hoonetorg has joined #openstack-manila | 17:59 | |
bswartz | crash consistent is a bare minimum standard | 17:59 |
ganso | markstur: it is a known limitation at this moment, it is documented | 17:59 |
*** xyang_ has quit IRC | 18:00 | |
markstur | vponomaryov: "o run concurrently with user updates and still obtain a consistent copy of the file system as of the time the copy was created' | 18:01 |
* markstur sees no shenanigans in gpfs | 18:02 | |
vponomaryov | markstur: which approach is used? temp I/O freeze? | 18:02 |
markstur | vponomaryov: How did this friendly conversation turn on me? | 18:02 |
vponomaryov | markstur: ^_^ | 18:03 |
vponomaryov | markstur: nice trick to say "don't know" )0 | 18:03 |
markstur | ignorance is bliss | 18:04 |
markstur | So it does a flush, quiesce, flush-again, snap. I wonder if it is ever possible that it takes too long and the writer can catch an error. | 18:06 |
*** xyang_ has joined #openstack-manila | 18:06 | |
*** a-pugachev has quit IRC | 18:09 | |
vponomaryov | markstur: you just won a prise! you can be the first person marking this commit https://review.openstack.org/#/c/427811/ with +2, hurry up! Don't miss your chance! | 18:09 |
markstur | vponomaryov: Will look at it later. First I need to reply to a Nigerian prince who wants me to help him with his money. | 18:10 |
markstur | ... and buy a timeshare | 18:11 |
ganso | markstur: LOL that's a classic one | 18:11 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions https://review.openstack.org/427660 | 18:11 |
*** akapil has joined #openstack-manila | 18:14 | |
openstackgerrit | Alyson proposed openstack/manila master: HNAS: Fix syntax to make shares read-only in snapshot create https://review.openstack.org/428267 | 18:14 |
vponomaryov | markstur: I am aware about nice timeshares in Ukraine, lots of nice places, and it is completely cheap! =) | 18:15 |
vponomaryov | markstur: look, chances are around you! | 18:16 |
markstur | :) OK I'm looking at the patch | 18:16 |
vponomaryov | markstur: good choice | 18:18 |
vponomaryov | markstur: I should admit you have really good taste of excellence, very good choice | 18:19 |
ganso | markstur: Mark, Alyson and I discussed about not needing a reno | 18:21 |
ganso | markstur: see my previous comment in patch https://review.openstack.org/#/c/428267 | 18:21 |
ganso | markstur: with the bug or bugfix, the snapshot is the same... the only difference is that the application does not get an error message | 18:23 |
markstur | usually gouthamr is the reno enforcer | 18:24 |
*** akapil has quit IRC | 18:26 | |
ganso | markstur: https://review.openstack.org/#/c/427616/ is ready | 18:28 |
ganso | vponomaryov: https://review.openstack.org/#/c/427834/ is ready | 18:28 |
vponomaryov | ganso: what ELSE i can do for you with this change? | 18:29 |
vponomaryov | ganso: bless it for successful merge? )) | 18:29 |
ganso | vponomaryov: lol sorry my page was stale I did not notice | 18:30 |
ganso | vponomaryov: but blessing it would be nice | 18:30 |
markstur | I think ganso has hit some quota limit for today | 18:30 |
* markstur goes back to reviewing Valeriy's TODOs | 18:30 | |
vponomaryov | markstur: those todo in 5 words - "make it prety, but later" | 18:32 |
markstur | -1 s/prety/pretty/ | 18:32 |
vponomaryov | just typo | 18:32 |
vponomaryov | have a mercy | 18:32 |
gouthamr | vponomaryov: have a minute to talk about a related concern? | 18:33 |
vponomaryov | gouthamr: sure | 18:33 |
vponomaryov | gouthamr: go ahead | 18:33 |
bswartz | gouthamr: are you out of your meeting yet? | 18:33 |
gouthamr | vponomaryov: how can you tell if a share group supports consistent snapshots? | 18:33 |
vponomaryov | gouthamr: you mean right now, with current code? | 18:34 |
gouthamr | bswartz: not yet.. multitasking :P | 18:34 |
gouthamr | vponomaryov: i.e, i can look at the group type extra specs... | 18:34 |
vponomaryov | gouthamr: not planned? | 18:34 |
vponomaryov | gouthamr: we do not have group type specs defined yet | 18:34 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions https://review.openstack.org/427660 | 18:34 |
vponomaryov | gouthamr: I guess, it is PTG topic | 18:34 |
vponomaryov | gouthamr: to define it | 18:34 |
gouthamr | vponomaryov: but you can change group type extra-specs :( | 18:35 |
gouthamr | vponomaryov: can we do what we're doing with shares, right now | 18:35 |
vponomaryov | gouthamr: yes, we have mechanism | 18:35 |
vponomaryov | gouthamr: just do not use it atm | 18:35 |
bswartz | gouthamr: no worries, I want to make that API change we talked about | 18:36 |
gouthamr | vponomaryov: because it's a DB migration that you can't back-port | 18:36 |
gouthamr | bswartz: oh.. the one about the access rules change? | 18:37 |
vponomaryov | gouthamr: backport? I guess it should have some context | 18:37 |
vponomaryov | gouthamr: the thing you are talking about | 18:37 |
gouthamr | vponomaryov: you can make a group that supports consistent snapshots | 18:37 |
gouthamr | vponomaryov: then go back and change that group | 18:37 |
vponomaryov | gouthamr: addon of a member is change too | 18:37 |
bswartz | gouthamr: locking out reverts on shares undergoing access rules updates | 18:37 |
gouthamr | vponomaryov: change the group-type* | 18:38 |
gouthamr | bswartz: +1 | 18:38 |
bswartz | gouthamr: I need to know exactly what field I should be looking at | 18:38 |
vponomaryov | gouthamr: such vulnerability we have for share types too | 18:38 |
gouthamr | vponomaryov: which we solved with share capability fields | 18:39 |
gouthamr | bswartz: "access_rules_status" | 18:39 |
vponomaryov | gouthamr: right, but we should "decide" what exactly should it be for groups | 18:40 |
vponomaryov | first | 18:40 |
vponomaryov | then implement | 18:40 |
vponomaryov | it is more than one cycle of efforts for such big feature | 18:40 |
vponomaryov | and it is expected | 18:41 |
gouthamr | vponomaryov: i'd call it "consistent_snapshot_support" | 18:41 |
vponomaryov | gouthamr: keep for PTG )) | 18:41 |
vponomaryov | or add notes in etherpad ) | 18:41 |
gouthamr | vponomaryov: will do.. but wanted to know if we can do it now.. because adding a new field requires a DB migration | 18:43 |
vponomaryov | gouthamr: I don't mind | 18:43 |
gouthamr | vponomaryov: as we discussed today, we won't shy away from fixing all the bugs now, even if we turn off the APIs | 18:43 |
bswartz | vponomaryov: gouthamr is asking us to fast track this one extra spec because it we can get it into ocata it makes possible other bugfix backports | 18:43 |
bswartz | I'm neutral on whether it's a good idea | 18:44 |
vponomaryov | bswartz: I understood | 18:44 |
bswartz | I don't see any harm in it but the gain is also pretty minimal | 18:44 |
vponomaryov | redundant field, if it is redundant don't make harm | 18:44 |
ganso | vponomaryov: can we get db migration export locations for group_snapshots as well? | 18:45 |
vponomaryov | ganso: why? | 18:45 |
vponomaryov | ganso: I was thinking about it | 18:45 |
ganso | vponomaryov: so we can backport to ocata | 18:45 |
ganso | vponomaryov: cool | 18:45 |
vponomaryov | ganso: and came to idea, that it will be too much | 18:45 |
ganso | vponomaryov: thx | 18:45 |
ganso | vponomaryov: ((((((((((((((((((((((((((((((((((( | 18:46 |
vponomaryov | ganso: we just do not support mountable snapshots in groups as of Ocata | 18:46 |
vponomaryov | ganso: it could be developed for CGs | 18:46 |
openstackgerrit | Merged openstack/manila master: Blocked migration of shares within share groups https://review.openstack.org/427834 | 18:46 |
ganso | vponomaryov: but you have regular snapshots, in groups... | 18:46 |
vponomaryov | ganso: it does not mean we have wide support of mountable snapshots | 18:47 |
vponomaryov | to implement it so late | 18:47 |
vponomaryov | it is feature | 18:47 |
ganso | vponomaryov: ok | 18:47 |
vponomaryov | "provider_location" is a must | 18:47 |
vponomaryov | because some drivers , like HNAS, will not work without it, right? | 18:48 |
*** xyang_ has quit IRC | 18:48 | |
*** xyang_ has joined #openstack-manila | 18:50 | |
vponomaryov | ganso: https://review.openstack.org/#/c/427660/5..6/manila/share/drivers/hitachi/hnas/ssh.py -> hiding trace you may not get know that you could search share with typo'ed share name | 18:52 |
vponomaryov | ganso: it is always useful to have a trace | 18:52 |
ganso | vponomaryov: I replied your comment | 18:52 |
vponomaryov | ganso: I see, I amreplying to reply here ) | 18:52 |
vponomaryov | ganso: will you reply to my reply for your reply? ) | 18:53 |
ganso | vponomaryov: sorry I don't understand what the error scenario is | 18:53 |
ganso | vponomaryov: what you just said above | 18:53 |
vponomaryov | ganso: you get there "not found" | 18:53 |
ganso | vponomaryov: y | 18:53 |
ganso | vponomaryov: *yes | 18:53 |
vponomaryov | ganso: I am saying, that you could get "false" not found because of bug | 18:53 |
ganso | vponomaryov: what bug? | 18:54 |
vponomaryov | ganso: which is typo in name you search with | 18:54 |
ganso | vponomaryov: the error message prints the share_name | 18:54 |
ganso | vponomaryov: in LOG.error | 18:54 |
vponomaryov | it is separately created | 18:54 |
vponomaryov | not the command you used | 18:54 |
vponomaryov | so, having there "exception" you do not lose anything, just cover one more possible error case | 18:55 |
vponomaryov | but yes, since it is your driver and your head ache, I don't mind merge it as is now ) | 18:55 |
ganso | vponomaryov: still not understanding the need for it, how is it separately from the command just created? | 18:56 |
vponomaryov | ganso: because you can log "proper" name, but search with wrong one indeed | 18:56 |
*** carthaca_ has quit IRC | 19:00 | |
*** sapcc-bot has quit IRC | 19:00 | |
*** eharney has quit IRC | 19:00 | |
*** carthaca_ has joined #openstack-manila | 19:00 | |
*** yumiriam has quit IRC | 19:00 | |
*** dgonzalez_ has joined #openstack-manila | 19:00 | |
*** sapcc-bot has joined #openstack-manila | 19:00 | |
*** tpatzig_ has joined #openstack-manila | 19:00 | |
*** ociuhandu has quit IRC | 19:01 | |
*** dgonzalez_ has quit IRC | 19:02 | |
*** tpatzig_ has quit IRC | 19:02 | |
ganso | vponomaryov: sorry I got pulled... so I use my string to search, how am I seeing the "proper" name anywhere? The string I search is the one I log | 19:05 |
vponomaryov | ganso: ok, forget, you have +2 there | 19:07 |
*** lpetrut has joined #openstack-manila | 19:08 | |
*** porrua has quit IRC | 19:08 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions https://review.openstack.org/427660 | 19:09 |
*** cknight has joined #openstack-manila | 19:12 | |
openstackgerrit | Merged openstack/manila master: HNAS: Fix managed snapshots not being mounted https://review.openstack.org/427616 | 19:14 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: HNAS: Fix syntax to make shares read-only in snapshot create https://review.openstack.org/428267 | 19:24 |
ganso | markstur: rebase hell | 19:26 |
markstur | very busy hnas today | 19:27 |
*** ociuhandu has joined #openstack-manila | 19:28 | |
markstur | git rebase failed with "commit failed. Repo is read-only while snapshot in progress." | 19:35 |
*** xyang_ has quit IRC | 19:37 | |
*** eharney has joined #openstack-manila | 19:37 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions https://review.openstack.org/427660 | 19:38 |
ganso | markstur: :P | 19:38 |
*** mtanino__ has quit IRC | 19:39 | |
*** xyang_ has joined #openstack-manila | 19:39 | |
openstackgerrit | Yogesh proposed openstack/manila master: Improve test coverage for share migration https://review.openstack.org/418559 | 19:41 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Fix HNAS driver always handling mountable snapshots https://review.openstack.org/428077 | 19:41 |
bswartz | ganso markstur xyang vponomaryov cknight toabctl gouthamr tbarron: http://imgur.com/a/Thb5f | 19:45 |
bswartz | feedback? | 19:46 |
gouthamr | :P I like it | 19:46 |
markstur | SQUIREL! | 19:46 |
gouthamr | not a skunk | 19:47 |
gouthamr | :P | 19:47 |
markstur | it is a little weasely. I might like a skunk better. But it is not bad. | 19:47 |
gouthamr | xyang_ ^ | 19:47 |
bswartz | I didn't want a skunk | 19:47 |
markstur | looks a little like a honey badger :) | 19:47 |
bswartz | I think they did a good job of making it non-skunky | 19:48 |
gouthamr | markstur: ikr... | 19:48 |
markstur | bswartz: Is there a scratch-and-sniff version? | 19:48 |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: [WIP] Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 19:50 |
bswartz | ganso: ^ if you want a preview of how I'm trying to fix LVM revert | 19:51 |
ganso | bswartz: looking | 19:53 |
*** a-pugachev has joined #openstack-manila | 19:57 | |
ganso | bswartz: did you forget to upload the ugly part? | 19:57 |
bswartz | ganso: haven't tested it yet | 19:58 |
ganso | bswartz: oh | 19:58 |
bswartz | what's ugly is what will happen inside the LVM driver | 19:58 |
bswartz | ganso: also I need to add a couple of lines to api/v2/shares.py | 19:58 |
ganso | bswartz: it's not different than what I expected... remove all rules... add them back | 19:58 |
gouthamr | ganso: a likely migration/mount-snapshot-support bug when you have a min | 19:59 |
ganso | gouthamr: sure | 19:59 |
gouthamr | ganso: so, firstly, snapshot-instance-export locations aren't being updated from the driver after migrate | 19:59 |
bswartz | gouthamr ganso: if you find any new bugs add them to LP immediately so we can track RC1 status | 19:59 |
gouthamr | bswartz: yep.. will confirm with ganso and add it | 20:00 |
ganso | gouthamr: yea... bug | 20:00 |
gouthamr | ganso: secondly, if we wanted to add that, it'd be a couple of lines of a code-fix, but then we need to get into the intricacies of whether we should allow export locations to be set, depending on whether we have the mount-snapshot-support capability in the destination share type | 20:01 |
ganso | gouthamr: hold on you lost me on "allow export locations to be set" | 20:01 |
ganso | gouthamr: why wouldn't we? it is the same as provider location update | 20:01 |
gouthamr | ganso: this is wrt your recent bugfix.. https://review.openstack.org/#/c/427332/ | 20:02 |
gouthamr | ganso: we can't allow export-locations to be updated by the driver if the destination share type doesn't need it | 20:02 |
ganso | gouthamr: yes, we just wouldn't show at the API | 20:02 |
ganso | gouthamr: the driver wouldn't return export locations if it doesn't support | 20:03 |
ganso | gouthamr: and we would handle it like this https://review.openstack.org/427332 | 20:03 |
gouthamr | ganso: in that bugfix, you fixed it such that we'd ignore the driver's update.. | 20:04 |
ganso | gouthamr: yes | 20:04 |
gouthamr | ganso: drivers don't have the destination share type to tell whether export locations should be updated | 20:04 |
ganso | we would do the same | 20:04 |
ganso | gouthamr: oh right | 20:04 |
ganso | gouthamr: wait I handled that | 20:04 |
ganso | gouthamr: just a sec | 20:04 |
gouthamr | ganso: well, we have the share-type-id, we can call into the DB code if we wanted to | 20:05 |
* gouthamr bswartz: smh | 20:05 | |
ganso | gouthamr: https://github.com/openstack/manila/blob/master/manila/share/manager.py#L1321 | 20:05 |
gouthamr | ganso: yah, that's too late, we'd need to bubble up snapshot updates | 20:06 |
bswartz | gouthamr: ? | 20:06 |
ganso | gouthamr: no no, I am saying I'd handle the same way | 20:06 |
ganso | gouthamr: we have snapshot instances | 20:06 |
ganso | gouthamr: we pass the snapshot_dict | 20:06 |
ganso | gouthamr: the snapshot_dict contains mount_snapshot_support | 20:06 |
ganso | gouthamr: we pass the destination snapshot instance to drivers | 20:07 |
ganso | gouthamr: so they will have that info | 20:07 |
gouthamr | bswartz: was just typing "smh" for you based off my sentence before that, lol | 20:07 |
bswartz | what did we miss here? | 20:07 |
bswartz | export locations of snapshots after a migration? | 20:08 |
ganso | bswartz: yes | 20:08 |
gouthamr | bswartz: yes.. | 20:08 |
ganso | bswartz: cooperation between mountable and migration features | 20:08 |
* bswartz smh | 20:08 | |
gouthamr | ganso: mount_snapshot_support is in the share model.. | 20:08 |
gouthamr | lol | 20:08 |
bswartz | is it not just more model updates? | 20:08 |
gouthamr | bswartz: it's teh question of selective updates.. | 20:09 |
* ganso wonders why smh means... googles it... finds "shake my head" | 20:09 | |
* ganso is still confused | 20:09 | |
bswartz | shaking my head | 20:09 |
ganso | gouthamr: it is, but... | 20:09 |
bswartz | the nonverbal version of "no" | 20:09 |
ganso | gouthamr: it is proxified | 20:10 |
ganso | gouthamr: and snapshot['share'] is a share_instance | 20:10 |
ganso | gouthamr: which can do snapshot['share']['mount_snapshot_support'] to read the proxified property | 20:10 |
ganso | gouthamr: and that would not work because it would read the old value | 20:10 |
ganso | gouthamr: :\ | 20:11 |
gouthamr | ganso: last i saw, it wasn't... https://bugs.launchpad.net/manila/+bug/1660825 | 20:11 |
openstack | Launchpad bug 1660825 in Manila "Share capabilities are missing from share instance model" [Undecided,New] | 20:11 |
gouthamr | ganso: it's a low priority bug since nothing needs it.. ^ | 20:11 |
gouthamr | ganso: but you're right.. proxying doesn't work for this, because we need the new share type | 20:12 |
ganso | gouthamr: https://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/models.py#L341 | 20:12 |
gouthamr | ganso: ah, nice. you did the right thing.. but we didn't do that for revert_to_snapshot_support, snapshot_support and csfss | 20:12 |
* gouthamr counts typos in above sentence.. no typos. yay. | 20:13 | |
ganso | gouthamr: if I did, vponomaryov would come and -1 "unrelated change" | 20:13 |
gouthamr | haha | 20:13 |
ganso | gouthamr: I would mark it high priority though | 20:14 |
ganso | gouthamr: wait | 20:14 |
gouthamr | ganso: so i think we should call https://github.com/openstack/manila/blob/master/manila/share/share_types.py#L180 and update the export locations based on the share-type-id | 20:14 |
ganso | gouthamr: only NetApp and ZFS do driver assisted migration, and none of them do mountable snapshots | 20:14 |
ganso | gouthamr: so ok Low priority... although it breaks dummy driver :( poor dummy | 20:15 |
gouthamr | ganso: you'd be surprised if i told you which one did | 20:15 |
gouthamr | ganso: there you go | 20:15 |
*** lpetrut has quit IRC | 20:15 | |
ganso | gouthamr: dummy will have to remain broken | 20:15 |
ganso | gouthamr: :P | 20:15 |
ganso | gouthamr: jk | 20:16 |
gouthamr | ganso: our all capable driver breaks on migration tests for snapshots.. and helps discover this important bug | 20:16 |
ganso | gouthamr: did Yogesh's patch find this? | 20:16 |
gouthamr | ganso: yep | 20:16 |
ganso | gouthamr: very cool | 20:16 |
ganso | gouthamr: did you suggest that drivers would call this? https://github.com/openstack/manila/blob/master/manila/share/share_types.py#L180] | 20:17 |
gouthamr | ganso: no, we'll do that in the manager code.. | 20:17 |
gouthamr | ganso: allow the update selectively.. | 20:17 |
ganso | gouthamr: ok and how would drivers figure out they need to return export locations? | 20:17 |
gouthamr | ganso: they probably shouldn't care.. do what they do for all snapshots | 20:20 |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: [WIP] Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 20:22 |
bswartz | gouthamr: https://review.openstack.org/#/c/428398/2/manila/api/v2/shares.py <-- going to test this now | 20:22 |
ganso | gouthamr: could you log the bug? | 20:23 |
gouthamr | ganso: yep.. will do | 20:25 |
ganso | bswartz: I'd do that check in share/api.revert_to_snapshot | 20:25 |
bswartz | ganso: what check? | 20:26 |
*** crushil has quit IRC | 20:26 | |
bswartz | ganso: it's too late to do it there, we've already logged that the operation is happening | 20:26 |
*** crushil has joined #openstack-manila | 20:26 | |
*** jprovazn has quit IRC | 20:32 | |
*** makowals_ has joined #openstack-manila | 20:32 | |
*** kaisers_ has joined #openstack-manila | 20:32 | |
gouthamr | ganso: https://bugs.launchpad.net/manila/+bug/1661381 | 20:33 |
openstack | Launchpad bug 1661381 in Manila "Can't update snapshot instance export locations on completion of (driver assisted) migration" [High,New] | 20:33 |
*** makowals has quit IRC | 20:34 | |
*** kaisers has quit IRC | 20:35 | |
ganso | gouthamr: thanks | 20:42 |
ganso | bswartz: oh, revert performed all checks in v2/shares.py | 20:43 |
ganso | bswartz: I normally don't do that, but in that case, it is ok | 20:44 |
*** zhonghua2 has quit IRC | 20:50 | |
*** zhonghua has joined #openstack-manila | 20:52 | |
*** akapil has joined #openstack-manila | 21:00 | |
*** harlowja has quit IRC | 21:00 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions https://review.openstack.org/427660 | 21:05 |
*** alyson_ has quit IRC | 21:07 | |
openstackgerrit | Yogesh proposed openstack/manila master: Improve test coverage for share migration https://review.openstack.org/418559 | 21:09 |
*** catintheroof has quit IRC | 21:14 | |
*** xyang_ has quit IRC | 21:15 | |
*** catintheroof has joined #openstack-manila | 21:15 | |
*** xyang_ has joined #openstack-manila | 21:17 | |
*** xyang_ has quit IRC | 21:18 | |
*** xyang_ has joined #openstack-manila | 21:18 | |
*** catintheroof has quit IRC | 21:19 | |
*** xyang_ has quit IRC | 21:20 | |
*** sapcc-bot has quit IRC | 21:33 | |
*** carthaca_ has quit IRC | 21:33 | |
*** sapcc-bot has joined #openstack-manila | 21:35 | |
*** tpatzig_ has joined #openstack-manila | 21:35 | |
*** tpatzig_ has quit IRC | 21:37 | |
ganso | gouthamr: do you have any idea how the dummy job got so unstable? | 21:40 |
gouthamr | ganso: what are the failures? | 21:41 |
ganso | gouthamr: every run is a different failure | 21:41 |
gouthamr | ganso: there's one we know and we've slated to talk about at the PTG | 21:41 |
ganso | gouthamr: I've seen several on revert tests | 21:41 |
ganso | gouthamr: but not this https://review.openstack.org/#/c/428267/ and https://review.openstack.org/#/c/428077/ are different | 21:41 |
gouthamr | ganso: https://bugs.launchpad.net/manila/+bug/1631314 <-- this one | 21:42 |
openstack | Launchpad bug 1631314 in Manila "Tempest test "test_promote_out_of_sync_share_replica" is concurrency-prone" [High,Confirmed] - Assigned to Goutham Pacha Ravi (gouthamr) | 21:42 |
gouthamr | ganso: failure on https://review.openstack.org/#/c/428267/ is the bug ^ | 21:43 |
*** Yogi1 has quit IRC | 21:43 | |
gouthamr | ganso: http://logs.openstack.org/77/428077/3/check/gate-manila-tempest-minimal-dsvm-dummy-ubuntu-xenial/eee927a/console.html <-- seeing this for the first time.. will take a look | 21:43 |
*** cknight has quit IRC | 21:52 | |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: [WIP] Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 21:53 |
*** porrua has joined #openstack-manila | 21:55 | |
*** xyang_ has joined #openstack-manila | 22:02 | |
*** xyang_ has quit IRC | 22:03 | |
openstackgerrit | Tom Barron proposed openstack/manila master: Do not merge https://review.openstack.org/428463 | 22:05 |
*** akapil has quit IRC | 22:07 | |
openstackgerrit | Tom Barron proposed openstack/manila master: Do Not Merge https://review.openstack.org/428230 | 22:07 |
*** breitz has quit IRC | 22:14 | |
*** xyang_ has joined #openstack-manila | 22:18 | |
*** crushil has quit IRC | 22:19 | |
*** harlowja has joined #openstack-manila | 22:25 | |
*** breitz has joined #openstack-manila | 22:26 | |
*** harlowja has quit IRC | 22:32 | |
*** harlowja has joined #openstack-manila | 22:33 | |
*** dustins has quit IRC | 22:39 | |
*** erlon has quit IRC | 22:40 | |
*** kaisers_ has quit IRC | 22:47 | |
*** mtanino has joined #openstack-manila | 22:51 | |
-openstackstatus- NOTICE: Restarting gerrit due to performance problems | 22:51 | |
*** lseki has quit IRC | 23:00 | |
bswartz | ganso xyang vponomaryov cknight toabctl tbarron: still curious if you have any issues with: http://imgur.com/a/Thb5f | 23:20 |
*** xyang_ has quit IRC | 23:26 | |
openstackgerrit | Ben Swartzlander proposed openstack/manila master: Pass access rules to driver on snapshot revert https://review.openstack.org/428398 | 23:31 |
*** gouthamr has quit IRC | 23:33 | |
*** a-pugachev has quit IRC | 23:42 | |
ganso | bswartz: it could use a brigher brown | 23:45 |
ganso | bswartz: s/brighter/lighter | 23:45 |
ganso | bswartz: so it is more distinguishable from the black | 23:45 |
bswartz | ganso: your color contrast on your monitor might be off | 23:46 |
bswartz | it looks pretty light to me | 23:46 |
ganso | whoa | 23:46 |
ganso | bswartz: lemme try on my cell phone | 23:46 |
ganso | bswartz: same | 23:47 |
ganso | bswartz: I mean, it is distinguishable, but I suppose we are going to have T-shirts, caps, stickers, etc, and I think it would be better if it is a little lighter | 23:47 |
markstur | I actually would have gone with blue or something colorful, but brown is OK | 23:52 |
markstur | I think the contrast is fine. I just thought other colors would be more cartoony which I think is the style they are using | 23:52 |
markstur | brown is kind of real | 23:52 |
markstur | could be a Manila Mink | 23:52 |
markstur | but I left that varmint up on my monitor for a while and I'll add that the more I saw it the more I liked it. It grows on you | 23:53 |
ganso | markstur: which animal is our mascot again? I forgot the real name, all I can remember is that it is similar to skunk | 23:53 |
markstur | Manila Zorilla | 23:53 |
ganso | markstur: zorilla! | 23:53 |
ganso | markstur: thanks | 23:54 |
markstur | ganso: Don't let bswartz hear you say similar to skunk! | 23:54 |
ganso | markstur: lol | 23:54 |
ganso | bswartz: ok so comparing to google images of zorillas | 23:54 |
markstur | ^ that's good research there | 23:55 |
ganso | bswartz: I think it should have have a grayer tone instead of brownish | 23:55 |
ganso | bswartz: and should have some white detail on its head | 23:55 |
ganso | bswartz: maybe if it was drawn a bit in perspective, or with its head turning, it would be able to draw some white detail on its head | 23:56 |
ganso | bswartz: because right now the ear is covering that | 23:56 |
* ganso is aware of why people usually regret asking for his opinion on something | 23:57 | |
markstur | http://giphy.com/gifs/pepe-J6edbjeFkeoJa | 23:58 |
bswartz | ganso: I don't think we can change the artistic style | 23:58 |
bswartz | ganso: mostly the question is whether we're happy with zorilla and the mascot overall | 23:58 |
bswartz | I think it's pretty good | 23:58 |
bswartz | and it definitely non-skunky | 23:59 |
markstur | I'd say just the right amount of skunky | 23:59 |
ganso | lol | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!