*** chlong has quit IRC | 00:01 | |
*** gouthamr has quit IRC | 00:02 | |
*** yumiriam has left #openstack-manila | 00:05 | |
*** cknight has quit IRC | 00:12 | |
*** gouthamr has joined #openstack-manila | 00:26 | |
*** furlongm has quit IRC | 00:34 | |
*** furlongm has joined #openstack-manila | 00:36 | |
*** furlongm has quit IRC | 00:38 | |
*** gouthamr has quit IRC | 00:47 | |
*** mtani____ has quit IRC | 00:47 | |
*** furlongm has joined #openstack-manila | 00:56 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-image-elements: Adds support for NFS Ganesha https://review.openstack.org/411500 | 01:00 |
---|---|---|
openstackgerrit | Lucio Seki proposed openstack/manila: [DEBUG] Show LVM volume filesystem and list mount path https://review.openstack.org/419627 | 01:26 |
*** kaisers2 has joined #openstack-manila | 01:36 | |
*** kaisers3 has joined #openstack-manila | 01:36 | |
*** kaisers1 has quit IRC | 01:37 | |
*** kaisers has quit IRC | 01:38 | |
openstackgerrit | zhongjun proposed openstack/manila: Add manila-manage db purge command https://review.openstack.org/308212 | 01:38 |
*** kaisers has joined #openstack-manila | 02:17 | |
*** kaisers_ has quit IRC | 02:20 | |
*** gouthamr has joined #openstack-manila | 02:34 | |
*** gouthamr has quit IRC | 02:43 | |
*** ganso has quit IRC | 02:44 | |
*** gouthamr has joined #openstack-manila | 02:45 | |
*** breitz has quit IRC | 02:52 | |
openstackgerrit | Jeremy Liu proposed openstack/python-manilaclient: Enable coverage report in console output https://review.openstack.org/419733 | 02:57 |
*** porrua has joined #openstack-manila | 02:59 | |
*** porrua has quit IRC | 03:04 | |
*** absubram has joined #openstack-manila | 03:11 | |
*** absubram_ has joined #openstack-manila | 03:18 | |
*** absubram has quit IRC | 03:19 | |
*** absubram_ is now known as absubram | 03:19 | |
*** gcb has quit IRC | 03:26 | |
openstackgerrit | Pony Chou proposed openstack/manila: Add QNAP Manila Driver https://review.openstack.org/394703 | 03:39 |
openstackgerrit | zhongjun proposed openstack/manila: [TrivialFix] Add negative test in quota detail https://review.openstack.org/419746 | 03:40 |
*** gouthamr has quit IRC | 04:04 | |
*** alekseyruban has joined #openstack-manila | 04:10 | |
*** alekseyruban has quit IRC | 04:14 | |
*** breitz has joined #openstack-manila | 04:28 | |
*** porrua has joined #openstack-manila | 04:48 | |
*** porrua has quit IRC | 04:52 | |
*** kaisers has quit IRC | 04:54 | |
*** sticker has quit IRC | 05:31 | |
*** alekseyruban has joined #openstack-manila | 05:32 | |
*** kaisers has joined #openstack-manila | 05:55 | |
*** lpetrut has joined #openstack-manila | 05:59 | |
*** alekseyruban has quit IRC | 06:06 | |
*** jprovazn has joined #openstack-manila | 06:27 | |
*** porrua has joined #openstack-manila | 06:36 | |
*** kaisers has quit IRC | 06:40 | |
*** porrua has quit IRC | 06:41 | |
*** alekseyruban has joined #openstack-manila | 06:48 | |
*** lpetrut has quit IRC | 06:50 | |
*** a-pugachev has joined #openstack-manila | 06:53 | |
*** nkrinner_afk is now known as nkrinner | 07:15 | |
*** kaisers has joined #openstack-manila | 07:36 | |
*** a-pugachev has quit IRC | 07:57 | |
*** nherciu has joined #openstack-manila | 07:58 | |
openstackgerrit | zhongjun proposed openstack/manila: Fix column name error in migration script https://review.openstack.org/418168 | 08:24 |
openstackgerrit | zhongjun proposed openstack/manila: Fix column name error in migration script https://review.openstack.org/418168 | 08:27 |
*** tuanluong has joined #openstack-manila | 08:28 | |
*** kaisers has quit IRC | 08:41 | |
*** ociuhandu has joined #openstack-manila | 09:05 | |
*** a-pugachev has joined #openstack-manila | 09:17 | |
*** porrua has joined #openstack-manila | 09:18 | |
*** porrua has quit IRC | 09:22 | |
*** ganso has joined #openstack-manila | 09:31 | |
*** gaurangt has joined #openstack-manila | 09:51 | |
*** lpetrut has joined #openstack-manila | 10:08 | |
*** tuanluong has quit IRC | 10:09 | |
*** tuanluong has joined #openstack-manila | 10:10 | |
*** tuanluong has quit IRC | 10:11 | |
openstackgerrit | Tina Tang proposed openstack/manila: [Unity driver] VLAN enhancement https://review.openstack.org/410037 | 10:17 |
*** JoseMello has joined #openstack-manila | 10:18 | |
*** openstackgerrit has quit IRC | 10:18 | |
*** kaisers has joined #openstack-manila | 10:36 | |
*** makowals has quit IRC | 10:42 | |
*** makowals has joined #openstack-manila | 10:44 | |
*** absubram has quit IRC | 10:47 | |
*** makowals has quit IRC | 10:54 | |
*** tommylikehu_ has joined #openstack-manila | 10:58 | |
*** yumiriam has joined #openstack-manila | 11:01 | |
*** tommylikehu_ has quit IRC | 11:03 | |
*** porrua has joined #openstack-manila | 11:06 | |
*** makowals_ has joined #openstack-manila | 11:08 | |
*** porrua has quit IRC | 11:11 | |
ganso | vponomaryov: ping | 11:14 |
vponomaryov | ganso: pong | 11:14 |
ganso | vponomaryov: Hi Valeriy. Why are you suggesting the use of skip_if_microversion_lt instead of skip_if_microversion_not_supported in test_share_basic_ops.py ? | 11:15 |
vponomaryov | ganso: why do you suggest using "not_supported"? | 11:16 |
ganso | vponomaryov: you told me some time ago that using "not_supported" is more appropriate | 11:16 |
vponomaryov | ganso: my argument is that we are ok with higher version | 11:16 |
vponomaryov | even if this particular one is ot supported | 11:16 |
vponomaryov | s/ot/not/ | 11:16 |
vponomaryov | ganso: every statement has its context | 11:17 |
ganso | vponomaryov: why cannot it be "not_support" ? | 11:17 |
vponomaryov | ganso: it can, but it is wrong | 11:17 |
ganso | vponomaryov: why? | 11:18 |
vponomaryov | ganso: we need exactly "greater" or "notless than" | 11:18 |
ganso | vponomaryov: what if this function changes? | 11:18 |
ganso | vponomaryov: we would need to update the decorator again | 11:18 |
vponomaryov | ganso: Rodrigo, update of test after update of API is expected thing | 11:18 |
*** openstackgerrit has joined #openstack-manila | 11:19 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/python-manilaclient: Add share group support to Manila client https://review.openstack.org/335120 | 11:19 |
ganso | vponomaryov: ok so in what situation "not_supported" is properly used? | 11:19 |
vponomaryov | ganso: when you need specific version, obviously | 11:20 |
ganso | vponomaryov: let's take CG tests as an example... it is going to not be supported anymore, why would we maintain tests for that? | 11:21 |
vponomaryov | ganso: where do you see it is being maintained? | 11:21 |
ganso | vponomaryov: like, we could either rename and update the tests, in that case "skip_if_microversion_lt" is valid | 11:21 |
ganso | vponomaryov: I am trying to find an example where "not_supported" is correct but "skip_if_microversion_lt" is not, despite other factors such as "we can update the tests and use the higher version always" | 11:22 |
vponomaryov | https://github.com/openstack/manila/blob/0d6db358/manila_tempest_tests/tests/api/admin/test_share_manage.py | 11:23 |
vponomaryov | ganso: you are burying deep into useless thing. Answer has already been given | 11:24 |
vponomaryov | ganso: when you need specific version, that's all | 11:24 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 11:32 |
*** lseki has joined #openstack-manila | 11:34 | |
*** kaisers has quit IRC | 11:43 | |
*** openstackgerrit has quit IRC | 11:47 | |
dmellado | vponomaryov: hey o/ | 11:57 |
dmellado | could you please have another look at https://review.openstack.org/#/c/419440/ | 11:57 |
*** openstackgerrit has joined #openstack-manila | 11:57 | |
dmellado | it should be quite straightforward and already has 2 +2's ;) | 11:57 |
dmellado | thanks! | 11:57 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 11:58 |
openstackgerrit | Lucio Seki proposed openstack/manila: Mountable snapshots scenario tests https://review.openstack.org/412001 | 11:59 |
vponomaryov | dmellado: done | 12:00 |
dmellado | vponomaryov: thanks! | 12:01 |
*** makowals_ has quit IRC | 12:06 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/python-manilaclient: Add share group support to Manila client https://review.openstack.org/335120 | 12:09 |
*** tommylikehu_ has joined #openstack-manila | 12:21 | |
*** timcl has joined #openstack-manila | 12:22 | |
*** catintheroof has joined #openstack-manila | 12:30 | |
*** catintheroof has quit IRC | 12:31 | |
*** catintheroof has joined #openstack-manila | 12:32 | |
openstackgerrit | Merged openstack/manila: Allow skipping manila tempest tests. https://review.openstack.org/419440 | 12:37 |
*** kaisers has joined #openstack-manila | 12:39 | |
*** gaurangt has left #openstack-manila | 12:43 | |
*** dsariel has quit IRC | 12:54 | |
*** makowals has joined #openstack-manila | 13:02 | |
openstackgerrit | Tom Barron proposed openstack/manila: Remove NovaNetworkPlugin https://review.openstack.org/410450 | 13:13 |
*** jcsp has joined #openstack-manila | 13:15 | |
*** tommylikehu_ has quit IRC | 13:17 | |
*** tommylikehu_ has joined #openstack-manila | 13:17 | |
*** kaisers has quit IRC | 13:27 | |
openstackgerrit | zhongjun proposed openstack/manila: Fix column name error in migration script https://review.openstack.org/418168 | 13:30 |
*** absubram has joined #openstack-manila | 13:40 | |
*** timcl1 has joined #openstack-manila | 13:42 | |
*** timcl has quit IRC | 13:45 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 13:46 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 13:59 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 13:59 |
*** xyang1 has joined #openstack-manila | 14:06 | |
*** gouthamr has joined #openstack-manila | 14:15 | |
*** jprovazn has quit IRC | 14:21 | |
*** jprovazn has joined #openstack-manila | 14:21 | |
*** kaisers has joined #openstack-manila | 14:22 | |
*** jprovazn has quit IRC | 14:23 | |
ganso | gouthamr: ping | 14:28 |
gouthamr | ganso: pong | 14:30 |
*** jprovazn has joined #openstack-manila | 14:30 | |
ganso | gouthamr: Hi Goutham. Good morning! I have a question about https://review.openstack.org/#/c/419163/4/manila/share/api.py@441 | 14:30 |
*** dustins has joined #openstack-manila | 14:31 | |
gouthamr | ganso: Goodmorning. Wassup? | 14:31 |
*** ChanServ changes topic to "OpenStack Shared File Systems | Manila| Feature Proposal Freeze is here | Core reviewers use your -2 powers!" | 14:31 | |
*** porrua has joined #openstack-manila | 14:32 | |
ganso | gouthamr: I would like to understand it better, because I followed where it leads, and it seems it does absolutely nothing | 14:32 |
ganso | gouthamr: the value is passed to create_share_instance_and_get_request_spec, which sets in the share_replica variable it returns, and then only uses the ID from it | 14:33 |
*** tommylikehu has quit IRC | 14:33 | |
*** tommylikehu has joined #openstack-manila | 14:34 | |
gouthamr | ganso: we create the instance with that field set to True; https://review.openstack.org/#/c/419163/4/manila/share/api.py@372 | 14:35 |
ganso | gouthamr: set to False, you mean? | 14:39 |
ganso | gouthamr: where is it created set to True? o_O | 14:39 |
*** makowals has quit IRC | 14:45 | |
*** chlong has joined #openstack-manila | 14:45 | |
*** makowals has joined #openstack-manila | 14:45 | |
*** eharney has quit IRC | 14:46 | |
openstackgerrit | Merged openstack/manila: [TrivialFix] Add negative test in quota detail https://review.openstack.org/419746 | 14:49 |
gouthamr | ganso: L442: readable replicas have it set to True, L444, others have it set to False, L363-372: We're committing that to the database when we create the replica | 14:56 |
*** cknight has joined #openstack-manila | 14:57 | |
ganso | gouthamr: omg I can't believe I missed that DB call | 14:57 |
gouthamr | ganso: :) | 14:58 |
ganso | gouthamr: I was coding the validation in the wrong unit | 14:58 |
ganso | gouthamr: thanks! | 14:58 |
ganso | gouthamr: unit *test | 14:58 |
gouthamr | ganso: you're welcome! thanks for handling that | 14:59 |
*** mtanino has joined #openstack-manila | 14:59 | |
*** rraja has joined #openstack-manila | 14:59 | |
*** eharney has joined #openstack-manila | 15:08 | |
openstackgerrit | Clinton Knight proposed openstack/manila: Implement share revert to snapshot https://review.openstack.org/340502 | 15:09 |
*** tommylikehu_ has quit IRC | 15:17 | |
*** xyang1 has quit IRC | 15:19 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add cast_rules_to_readonly to share instances https://review.openstack.org/419163 | 15:21 |
*** nkrinner is now known as nkrinner_afk | 15:37 | |
*** kaisers has quit IRC | 15:39 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 16:06 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 16:10 |
*** cdelatte has joined #openstack-manila | 16:15 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 16:18 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature https://review.openstack.org/355264 | 16:18 |
*** kaisers has joined #openstack-manila | 16:35 | |
*** makowals has quit IRC | 16:35 | |
*** pcaruana has joined #openstack-manila | 16:36 | |
*** chlong has quit IRC | 16:38 | |
*** chlong has joined #openstack-manila | 16:43 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-image-elements: Enables end user to pick share protocol https://review.openstack.org/400411 | 16:43 |
*** chlong has quit IRC | 16:48 | |
*** rraja has quit IRC | 16:57 | |
*** chlong has joined #openstack-manila | 16:59 | |
*** ociuhandu has quit IRC | 17:07 | |
*** chlong has quit IRC | 17:09 | |
*** nherciu_ has joined #openstack-manila | 17:28 | |
*** eharney has quit IRC | 17:29 | |
*** nherciu has quit IRC | 17:29 | |
*** kaisers has quit IRC | 17:30 | |
*** nherciu__ has joined #openstack-manila | 17:31 | |
*** lpetrut has quit IRC | 17:33 | |
*** nherciu_ has quit IRC | 17:34 | |
*** eharney has joined #openstack-manila | 17:51 | |
*** ociuhandu has joined #openstack-manila | 17:58 | |
*** a-pugachev has quit IRC | 18:02 | |
*** dustins has quit IRC | 18:04 | |
*** dustins has joined #openstack-manila | 18:09 | |
*** dustins has quit IRC | 18:09 | |
*** dustins has joined #openstack-manila | 18:10 | |
*** dustins has quit IRC | 18:21 | |
*** dustins has joined #openstack-manila | 18:21 | |
*** jprovazn has quit IRC | 18:24 | |
*** pcaruana has quit IRC | 18:26 | |
*** kaisers has joined #openstack-manila | 18:27 | |
*** dustins has quit IRC | 18:29 | |
*** dustins has joined #openstack-manila | 18:29 | |
openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-image-elements: Enables end user to pick share protocol https://review.openstack.org/400411 | 18:38 |
*** pcaruana has joined #openstack-manila | 18:39 | |
*** lpetrut has joined #openstack-manila | 18:43 | |
*** cknight has quit IRC | 18:57 | |
*** openstack has joined #openstack-manila | 19:01 | |
*** lpetrut has quit IRC | 19:01 | |
*** gouthamr has joined #openstack-manila | 19:02 | |
*** pcaruana has quit IRC | 19:02 | |
*** lpetrut has joined #openstack-manila | 19:09 | |
*** chlong has joined #openstack-manila | 19:14 | |
*** ianychoi has quit IRC | 19:15 | |
*** yumiriam has quit IRC | 19:27 | |
*** dustins has quit IRC | 19:46 | |
*** cknight has quit IRC | 19:51 | |
*** gouthamr has quit IRC | 19:51 | |
*** ganso has quit IRC | 19:54 | |
*** cknight has joined #openstack-manila | 19:54 | |
*** gouthamr has joined #openstack-manila | 19:55 | |
*** kaisers has joined #openstack-manila | 19:57 | |
*** openstackstatus has quit IRC | 19:57 | |
*** openstack has joined #openstack-manila | 20:01 | |
*** nherciu__ has quit IRC | 20:01 | |
*** eharney has quit IRC | 20:11 | |
*** eharney has joined #openstack-manila | 20:26 | |
*** openstackstatus has quit IRC | 20:27 | |
*** openstack has joined #openstack-manila | 20:31 | |
*** porrua has quit IRC | 20:36 | |
*** cdelatte has quit IRC | 20:43 | |
*** timcl1 has quit IRC | 20:44 | |
*** dustins has joined #openstack-manila | 21:01 | |
*** absubram has quit IRC | 21:05 | |
*** lpetrut has quit IRC | 21:05 | |
*** alekseyruban has quit IRC | 21:09 | |
*** kaisers has quit IRC | 21:10 | |
*** JoseMello has quit IRC | 21:25 | |
*** xyang1 has joined #openstack-manila | 21:28 | |
*** gouthamr has quit IRC | 21:31 | |
*** adrianofr_ has quit IRC | 21:49 | |
*** eharney has quit IRC | 22:06 | |
*** kaisers has joined #openstack-manila | 22:06 | |
*** lseki has quit IRC | 22:10 | |
*** xyang1 has quit IRC | 22:21 | |
*** baling-wire is now known as david-lyle | 22:26 | |
*** catintheroof has quit IRC | 22:38 | |
*** dustins has quit IRC | 22:56 | |
*** tommylikehu_ has joined #openstack-manila | 23:06 | |
*** tommylikehu_ has quit IRC | 23:07 | |
*** tommylikehu_ has joined #openstack-manila | 23:10 | |
*** kaisers has quit IRC | 23:14 | |
*** tommylikehu_ has quit IRC | 23:15 | |
*** cknight has quit IRC | 23:38 | |
*** chlong has quit IRC | 23:38 | |
*** tommylikehu has quit IRC | 23:46 | |
*** tommylikehu has joined #openstack-manila | 23:46 | |
*** gouthamr has joined #openstack-manila | 23:54 | |
*** harlowja has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!