| *** akerr has quit IRC | 00:05 | |
| *** chlong has quit IRC | 00:16 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 00:16 |
|---|---|---|
| *** gouthamr has joined #openstack-manila | 00:20 | |
| openstackgerrit | gecong proposed openstack/manila: Change assertTrue(isinstance()) by optimal assert https://review.openstack.org/362671 | 00:27 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 00:33 |
| *** mtanino has quit IRC | 00:34 | |
| openstackgerrit | Jay Mehta proposed openstack/manila: HPE 3PAR driver pool support https://review.openstack.org/329552 | 00:41 |
| *** wangqun has joined #openstack-manila | 00:41 | |
| *** Suyi_1 has quit IRC | 00:43 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 00:46 |
| *** cknight has joined #openstack-manila | 00:51 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 00:58 |
| *** gouthamr_ has joined #openstack-manila | 01:01 | |
| *** gouthamr has quit IRC | 01:05 | |
| *** gouthamr_ is now known as gouthamr | 01:09 | |
| *** yangyapeng has joined #openstack-manila | 01:20 | |
| *** zengyingzhe has quit IRC | 01:22 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration https://review.openstack.org/345142 | 01:22 |
| *** zengyingzhe has joined #openstack-manila | 01:24 | |
| *** akshai has quit IRC | 01:26 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 01:34 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration https://review.openstack.org/345142 | 01:34 |
| *** chlong has joined #openstack-manila | 01:41 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Update Share Migration CLI https://review.openstack.org/328437 | 01:46 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Add share type change to Share Migration CLI https://review.openstack.org/345125 | 01:46 |
| openstackgerrit | Peter Wang proposed openstack/manila: Unity: Use job for NFS share creation https://review.openstack.org/359567 | 01:54 |
| *** cknight has quit IRC | 01:57 | |
| *** cknight has joined #openstack-manila | 01:57 | |
| gouthamr | ganso: +----------------+---------------------+ | 02:00 |
| gouthamr | | Property | Value | | 02:00 |
| gouthamr | +----------------+---------------------+ | 02:00 |
| gouthamr | | task_state | migration_cancelled | | 02:00 |
| gouthamr | | total_progress | 100 | | 02:00 |
| gouthamr | +----------------+---------------------+ | 02:00 |
| *** cknight1 has joined #openstack-manila | 02:05 | |
| *** cknight has quit IRC | 02:05 | |
| ganso | yes? | 02:10 |
| ganso | gouthamr: ^ | 02:11 |
| ganso | gouthamr: sorry for the delay | 02:11 |
| *** cknight1 has quit IRC | 02:18 | |
| *** cknight has joined #openstack-manila | 02:23 | |
| *** faiz89 has joined #openstack-manila | 02:27 | |
| *** csaba has quit IRC | 02:35 | |
| *** cknight has quit IRC | 02:52 | |
| *** cknight has joined #openstack-manila | 02:56 | |
| *** cknight has quit IRC | 03:09 | |
| *** cknight1 has joined #openstack-manila | 03:09 | |
| openstackgerrit | Faiz Abidi proposed openstack/python-manilaclient: Allow deletion of multiple resources for some manila commands https://review.openstack.org/358119 | 03:51 |
| *** gouthamr has quit IRC | 03:51 | |
| *** faiz89 has quit IRC | 03:54 | |
| *** cknight has joined #openstack-manila | 04:15 | |
| *** cknight1 has quit IRC | 04:17 | |
| *** kaisers has quit IRC | 04:17 | |
| *** kaisers has joined #openstack-manila | 04:19 | |
| *** cknight has quit IRC | 04:30 | |
| *** senk has joined #openstack-manila | 04:38 | |
| *** chlong has quit IRC | 04:38 | |
| *** chlong has joined #openstack-manila | 04:39 | |
| *** chlong has quit IRC | 04:45 | |
| *** chlong has joined #openstack-manila | 04:57 | |
| *** nidhimittalhada has joined #openstack-manila | 05:01 | |
| *** ganso has quit IRC | 05:15 | |
| *** senk has quit IRC | 05:20 | |
| *** mtanino has joined #openstack-manila | 05:48 | |
| *** senk has joined #openstack-manila | 05:54 | |
| *** sandanar has joined #openstack-manila | 05:57 | |
| *** nkrinner_afk is now known as nkrinner | 06:01 | |
| *** nidhimittalhada has quit IRC | 06:08 | |
| *** lpetrut has joined #openstack-manila | 06:09 | |
| *** jseiler_ has joined #openstack-manila | 06:12 | |
| *** nidhimittalhada has joined #openstack-manila | 06:15 | |
| *** pcaruana has joined #openstack-manila | 06:15 | |
| *** jseiler has quit IRC | 06:15 | |
| *** nidhimittalhada has quit IRC | 06:30 | |
| *** nidhimittalhada has joined #openstack-manila | 06:31 | |
| *** mtanino has quit IRC | 06:32 | |
| *** nidhimittalhada has quit IRC | 06:33 | |
| *** dsariel has joined #openstack-manila | 06:41 | |
| *** rraja has joined #openstack-manila | 06:41 | |
| *** csaba has joined #openstack-manila | 06:44 | |
| *** lpetrut has quit IRC | 07:03 | |
| *** kaisers_ has joined #openstack-manila | 07:13 | |
| *** kaisers_ has quit IRC | 07:35 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 07:51 |
| openstackgerrit | NidhiMittalHada proposed openstack/python-manilaclient: type-create should support specifying extra-specs https://review.openstack.org/315012 | 07:52 |
| *** chlong has quit IRC | 08:06 | |
| openstackgerrit | zhongjun proposed openstack/manila: Add IPv6 ACL support in Manila https://review.openstack.org/312321 | 08:30 |
| *** rhefner has quit IRC | 08:31 | |
| openstackgerrit | zhongjun proposed openstack/manila: Add IPv6 ACL support in Manila https://review.openstack.org/312321 | 08:36 |
| *** aovchinnikov has joined #openstack-manila | 08:43 | |
| *** nidhimittalhada has joined #openstack-manila | 08:57 | |
| *** lpetrut has joined #openstack-manila | 08:58 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [ZFSonLinux] Add share migration support https://review.openstack.org/353417 | 09:01 |
| nidhimittalhada | @vponomaryov @gouthamr @bswartz @ganso @xyang @cknight Can you please review..? https://review.openstack.org/348160 https://review.openstack.org/351034 https://review.openstack.org/315012 | 09:02 |
| *** lpetrut has quit IRC | 09:02 | |
| *** lpetrut1 has joined #openstack-manila | 09:02 | |
| *** lpetrut1 is now known as lpetrut | 09:05 | |
| openstackgerrit | Lucian Petrut proposed openstack/manila: Windows SMB: avoid default read share access https://review.openstack.org/354853 | 09:06 |
| *** houming has joined #openstack-manila | 09:06 | |
| openstackgerrit | zhongjun proposed openstack/manila-specs: Add spec for enable IPv6 in manila https://review.openstack.org/362786 | 09:15 |
| *** nidhimittalhada has quit IRC | 09:25 | |
| *** zhongjun_ has quit IRC | 09:26 | |
| *** zhongjun_ has joined #openstack-manila | 09:27 | |
| *** wangqun has quit IRC | 10:19 | |
| *** yangyapeng has quit IRC | 10:30 | |
| openstackgerrit | Peter Wang proposed openstack/manila: Unity: Use job for NFS share creation https://review.openstack.org/359567 | 10:42 |
| openstackgerrit | Peter Wang proposed openstack/manila: Unity: Use job for NFS share creation https://review.openstack.org/359567 | 10:47 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Dummy driver] Add share migration support https://review.openstack.org/347853 | 10:54 |
| *** ganso has joined #openstack-manila | 10:55 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [ZFSonLinux] Add share migration support https://review.openstack.org/353417 | 11:15 |
| openstackgerrit | Merged openstack/puppet-manila: Add more info for deprecated parameters documentation. https://review.openstack.org/362482 | 11:19 |
| *** xyang1 has quit IRC | 11:39 | |
| *** yangyapeng has joined #openstack-manila | 11:41 | |
| openstackgerrit | gecong proposed openstack/manila: Correct reraising of exception https://review.openstack.org/360190 | 11:53 |
| *** gouthamr has joined #openstack-manila | 12:09 | |
| *** xyang_ has joined #openstack-manila | 12:20 | |
| ganso | gouthamr: ping | 12:26 |
| gouthamr | ganso: Goodmorning Rodrigo.. | 12:26 |
| ganso | gouthamr: good morning Goutham! | 12:26 |
| ganso | gouthamr: patch with the corrections is ready to be pushed | 12:27 |
| ganso | gouthamr: but I have one last thing to discuss with you before pushing it | 12:27 |
| gouthamr | ganso: sure..wassup? | 12:27 |
| ganso | gouthamr: I am feeling a bit inclined to include TASK_STATE_MIGRATION_ERROR to the case of migration_get_progress where it returns 'total_progress': 100 | 12:27 |
| ganso | gouthamr: for the same reason as cancelled | 12:28 |
| gouthamr | ganso: that can occur at multiple places? | 12:28 |
| ganso | gouthamr: yes | 12:28 |
| gouthamr | ganso: what if the migration never started? | 12:28 |
| ganso | gouthamr: then task_state would be None | 12:29 |
| gouthamr | ganso: hmm.... i'm okay with that.. technically total_progress should be ignored for those task_states.. would this behavior remain the same with a jobs API/jobs table? | 12:30 |
| ganso | gouthamr: so let's say task_state was migration_starting, because it is still in the beginning, creating destination instance etc, at this point it already shows total_progress: 0 if the user queries for progress. Then it fails and transitions to migration_error... then migration_get_progress returns error every time it is queried saying that is no migration | 12:31 |
| ganso | performed. <= This is current behavior | 12:31 |
| ganso | gouthamr: would there be any reason for the behavior to change with the jobs table? | 12:32 |
| gouthamr | ganso: yes.. change would be consistent with the other task_states | 12:32 |
| ganso | gouthamr: I mean, change from what I am proposing right now | 12:33 |
| gouthamr | ganso: your inclination to include TASK_STATE_MIGRATION_ERROR to the case of migration_get_progress where it returns 'total_progress': 100 | 12:33 |
| gouthamr | ganso: no, i can | 12:34 |
| *** openstackgerrit has quit IRC | 12:34 | |
| gouthamr | can't think of any inconsistency when we do the jobs table | 12:34 |
| ganso | gouthamr: me neither | 12:34 |
| *** openstackgerrit has joined #openstack-manila | 12:34 | |
| ganso | gouthamr: ok I will make the change | 12:35 |
| gouthamr | ganso: +1 | 12:35 |
| *** dustins has joined #openstack-manila | 12:35 | |
| gouthamr | ganso: Can host_assisted_migration tests run along with driver_assisted_migration tests? | 12:41 |
| ganso | gouthamr: yes | 12:41 |
| gouthamr | ganso: okay.. we've turned them off for zfsonlinux - but that could be because other gate drivers are running those tests | 12:41 |
| ganso | gouthamr: yes... but ideally, host_assisted should be enabled for all drivers | 12:42 |
| ganso | gouthamr: so drivers are validated to support... host_assisted primarily prevents vendor lock-in | 12:43 |
| ganso | gouthamr: and to be compatible between one-another | 12:43 |
| ganso | gouthamr: so if it is not tested | 12:43 |
| ganso | gouthamr: it may be possible to not support | 12:43 |
| gouthamr | ganso: yes i agree, but we're not testing mounting and copying across drivers.. i'd turn them on on the NetApp CI but currently only for DHSS=False; we've some infra issues around DHSS=True; for now | 12:44 |
| *** houming has quit IRC | 12:46 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 12:52 |
| ganso | gouthamr: also, do you think there's harm in having a code path that would allow gluster to be supported, even though we not tested and we are not listing it in the reno? | 12:53 |
| gouthamr | ganso: i think so.. i think we should add it, test it and then add a reno | 12:53 |
| ganso | gouthamr: gluster CI is broken | 12:54 |
| gouthamr | ganso: the GlusterFS CI is broken for a while now.. | 12:54 |
| ganso | gouthamr: I don't think we will be able to do it in time | 12:54 |
| *** porrua has joined #openstack-manila | 12:54 | |
| ganso | gouthamr: I don't see harm in having the code, if we don't say anything in the reno | 12:54 |
| gouthamr | ganso: hmmm... the default value for the config opt suggests that it's supported.. | 12:55 |
| ganso | gouthamr: humm it does suggest | 12:55 |
| ganso | gouthamr: well, alright, when it is supported, we write a new patch to allow it... also, it is a config option, if it is discovered to be supported later, it can be overridden in clouds running newton | 12:56 |
| ganso | gouthamr: I'll remove hdfs as well since we have not tested | 12:57 |
| gouthamr | ganso: i think we can update the default value as a bug? | 12:57 |
| gouthamr | bugfix* | 12:57 |
| *** cknight has joined #openstack-manila | 12:57 | |
| ganso | gouthamr: if bug is "it is supported, but not listed as so"... yes | 12:58 |
| gouthamr | ganso: because, as you said, the CI hooks can set the appropriate protocol mapping and go ahead and test it | 12:58 |
| ganso | gouthamr: it shouldn't require any change other than that | 12:58 |
| gouthamr | ganso: yah, then we can add supported in the reno.. it would be nice to explicitly claim support to NFS and CIFS for now.. | 12:59 |
| ganso | gouthamr: yes | 12:59 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 13:10 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration https://review.openstack.org/345142 | 13:10 |
| gouthamr | ganso: https://review.openstack.org/#/c/328431/56/manila_tempest_tests/tests/api/admin/test_migration_negative.py | 13:12 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 13:14 |
| ganso | gouthamr: thanks | 13:14 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration https://review.openstack.org/345142 | 13:14 |
| *** mtanino has joined #openstack-manila | 13:15 | |
| *** rooneym has joined #openstack-manila | 13:17 | |
| *** akerr has joined #openstack-manila | 13:33 | |
| *** mtanino has quit IRC | 13:37 | |
| *** xyang_ has quit IRC | 13:40 | |
| *** xyang1 has joined #openstack-manila | 13:44 | |
| *** xyang_ has joined #openstack-manila | 13:52 | |
| *** eharney has joined #openstack-manila | 13:54 | |
| *** akapil has joined #openstack-manila | 14:05 | |
| *** baojg has joined #openstack-manila | 14:05 | |
| *** faiz89 has joined #openstack-manila | 14:06 | |
| *** akshai has joined #openstack-manila | 14:07 | |
| *** akapil has quit IRC | 14:09 | |
| *** Yogi1 has joined #openstack-manila | 14:09 | |
| *** akapil has joined #openstack-manila | 14:09 | |
| *** aovchinnikov has quit IRC | 14:12 | |
| *** sandanar has quit IRC | 14:15 | |
| *** tpsilva has joined #openstack-manila | 14:16 | |
| *** mtanino has joined #openstack-manila | 14:20 | |
| *** akapil has quit IRC | 14:22 | |
| *** akapil has joined #openstack-manila | 14:22 | |
| openstackgerrit | Faiz Abidi proposed openstack/python-manilaclient: Allow deletion of multiple resources for some manila commands https://review.openstack.org/358119 | 14:29 |
| *** akshai has quit IRC | 14:32 | |
| *** akshai has joined #openstack-manila | 14:33 | |
| *** vbellur has quit IRC | 14:36 | |
| *** senk has quit IRC | 14:39 | |
| *** esker has joined #openstack-manila | 14:44 | |
| *** dustins has quit IRC | 14:50 | |
| *** nkrinner is now known as nkrinner_afk | 14:54 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 15:01 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration https://review.openstack.org/345142 | 15:03 |
| *** dmellado is now known as dmellado|mtg | 15:04 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [ZFSonLinux] Add share migration support https://review.openstack.org/353417 | 15:05 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Dummy driver] Add share migration support https://review.openstack.org/347853 | 15:06 |
| *** akapil has quit IRC | 15:12 | |
| *** xyang_ has quit IRC | 15:13 | |
| *** porrua has quit IRC | 15:13 | |
| *** akapil has joined #openstack-manila | 15:13 | |
| *** xyang_ has joined #openstack-manila | 15:14 | |
| *** porrua has joined #openstack-manila | 15:18 | |
| *** pcaruana has quit IRC | 15:22 | |
| *** sandanar has joined #openstack-manila | 15:29 | |
| *** dmellado|mtg is now known as dmellado | 15:33 | |
| *** xyang_ has quit IRC | 15:38 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 15:38 |
| *** xyang_ has joined #openstack-manila | 15:39 | |
| vponomaryov | ganso: if you want to see your commits merged, you should calm down, breathe deeply and do not upload new patch sets anymore! | 15:46 |
| *** kaisers_ has joined #openstack-manila | 15:48 | |
| *** faiz89 has quit IRC | 15:52 | |
| vponomaryov | ganso: share type change in migration commit requires update, see comments in it -> https://review.openstack.org/#/c/345142 | 15:55 |
| ganso | vponomaryov: I am already working on it | 15:55 |
| ganso | vponomaryov: some recent change broke it | 15:55 |
| ganso | vponomaryov: cannot go from DHSS=True to False and vice-versa anymore | 15:55 |
| vponomaryov | ganso: didn't you inted to go home early today? )) | 15:55 |
| ganso | vponomaryov: definitely not | 15:55 |
| vponomaryov | )) | 15:55 |
| vponomaryov | I read it in code )) | 15:56 |
| ganso | vponomaryov: if only dummy driver migration support merged I could code a tempest test for it | 15:57 |
| ganso | vponomaryov: it is the only CI that has the two driver modes enabled at the same time | 15:57 |
| vponomaryov | ganso: you still can code it even if it is not merged | 15:57 |
| ganso | vponomaryov: I usually run manually, but I did not run it again after recent changes... so I did not notice it broke | 15:58 |
| *** dsariel has quit IRC | 15:58 | |
| vponomaryov | hope you have enough coffee | 15:58 |
| vponomaryov | ^_^ | 15:58 |
| ganso | vponomaryov: and I usually upload patches to gerrit when I want to test in jenkins. I gained time by uploading it and leaving for lunch, so I came back and saw the result | 16:00 |
| ganso | vponomaryov: I can't drink coffee anymore | 16:00 |
| ganso | vponomaryov: since 2 years ago | 16:00 |
| ganso | vponomaryov: unfortunately :( | 16:00 |
| ganso | vponomaryov: I only drink decaf | 16:00 |
| *** yangyapeng has quit IRC | 16:06 | |
| vponomaryov | ganso: do you realize, that you break client compat with old server versions here -> https://review.openstack.org/#/c/328437/17 ? | 16:08 |
| vponomaryov | ganso: client is not server, you cannot just change inerfaces | 16:09 |
| vponomaryov | ganso: so, in client you should just add new microversioned methods | 16:10 |
| vponomaryov | ganso: not removing old ones that should work for mitaka/liberty releases | 16:10 |
| ganso | vponomaryov: as I noticed in my testing, if user is using the latest client version, he cannot use the previous versions anymore because migration-start has a different parameter. It gives error because of "force-host-copy" | 16:11 |
| vponomaryov | ganso: again, our client can be used for newton as well as mitaka and liberty releases | 16:12 |
| *** dustins has joined #openstack-manila | 16:12 | |
| vponomaryov | s/as/as for/ | 16:12 |
| ganso | vponomaryov: if that was desired, then "force-host_copy" mustn't be changed | 16:12 |
| bswartz | ganso: https://review.openstack.org/#/c/226389 | 16:12 |
| ganso | bswartz: ? | 16:13 |
| bswartz | ganso: wondering if you want to be the other +2 on that | 16:14 |
| bswartz | did you read my comment about what dhellmann said? | 16:14 |
| ganso | bswartz: I don't have time to test and review it right now :( | 16:14 |
| ganso | bswartz: If I am to give +2 on that, I want to test it first | 16:14 |
| ganso | bswartz: yes I read | 16:14 |
| vponomaryov | bswartz: migration code not ready yet, please, do not load ganso with something else | 16:15 |
| bswartz | ganso: okay mostly wanted to make sure you know we can still merge it | 16:15 |
| ganso | bswartz: thanks | 16:15 |
| bswartz | vponomaryov: just pinged him because he's reviewed it before | 16:15 |
| *** kaisers_ has quit IRC | 16:18 | |
| ganso | vponomaryov: so what's the decision on the python-manilaclient? we have no other choice than break compatibility | 16:18 |
| vponomaryov | bswartz: do you agree that client should not remove support of old code for migration? | 16:18 |
| bswartz | xyang1 xyang_ markstur toabctl tbarron: need another +2 on https://review.openstack.org/#/c/226389 | 16:18 |
| *** akshai has quit IRC | 16:18 | |
| ganso | vponomaryov: the client was the first to break compatibility and it was inevitable | 16:18 |
| bswartz | I don't think it's worth keeping old code, however I don't feel strongly about it | 16:18 |
| *** Yogi1 has quit IRC | 16:19 | |
| bswartz | what I do feel strongly about is that we're NOT obligated to provide backward compatibility on an experimental feature | 16:19 |
| vponomaryov | bswartz: it means that latest client cannot be used anymore for mitaka and liberty | 16:19 |
| *** ksumit has joined #openstack-manila | 16:19 | |
| bswartz | the whole point of experimental is to free us from the constraint of backward compatibility | 16:19 |
| ganso | vponomaryov: only for share migration, right? | 16:19 |
| vponomaryov | yes | 16:19 |
| tbarron | bswartz: I haven't followed the replication stuff well enough (yet) to be able to give that one an informed review | 16:19 |
| bswartz | vponomaryov: you mean cannot be used for migration with those releases | 16:20 |
| vponomaryov | yes | 16:20 |
| *** ksumit has quit IRC | 16:20 | |
| bswartz | tbarron: it's just a GUI layer on top of the feature | 16:20 |
| *** ksumit has joined #openstack-manila | 16:20 | |
| *** ksumit has quit IRC | 16:21 | |
| tbarron | bswartz: is cknight (who has -1 on it) not available for this one then? | 16:21 |
| *** lpetrut has quit IRC | 16:22 | |
| vponomaryov | tbarron: he has some installation problems | 16:22 |
| tbarron | vponomaryov: well, I'd like to see him agree that the problems are orthogonal to this patch and supply the needed +2 | 16:23 |
| vponomaryov | tbarron: you do not believe me? )) | 16:23 |
| tbarron | vponomaryov: :) | 16:24 |
| tbarron | vponomaryov: you can do the +2 then, I don't know this stuff | 16:24 |
| ganso | tbarron: he will not be able to workflow it though, bswartz and cknight cannot workflow a patch together | 16:24 |
| vponomaryov | tbarron: I am author | 16:24 |
| tbarron | vponomaryov: i see | 16:25 |
| vponomaryov | tbarron: only today, I can show anyone interested an online demo of it | 16:26 |
| bswartz | tbarron: cknight will remove his -1 | 16:27 |
| gouthamr | vponomaryov: what was the user error in this case? | 16:27 |
| bswartz | but cknight and I can't merge something with just the 2 of us due to the rules we agreed on | 16:27 |
| tbarron | bswartz: and apply +2 +W at same time, right? | 16:27 |
| gouthamr | vponomaryov: i wasn't able to get that patch to build | 16:27 |
| tbarron | bswartz: ok, I see | 16:27 |
| gouthamr | vponomaryov: but my manila-ui is broken even without it | 16:27 |
| gouthamr | vponomaryov: so i don't know what cknight and i are doing wrong | 16:28 |
| vponomaryov | gouthamr: say me what are you doing | 16:28 |
| * tbarron leaves for phone meeting, back in half an hour | 16:28 | |
| bswartz | tbarron: if another core members feels comfortable +2ing after cknight +2s it I'll see if cknight is willing to do one last review | 16:28 |
| gouthamr | vponomaryov: go to manila-ui, git pull; launch browser - breaks | 16:28 |
| ganso | gouthamr: are you following this? https://github.com/openstack/manila-ui | 16:29 |
| vponomaryov | gouthamr: just pull latest horizon and follow instruction for manila ui installation from its main page | 16:29 |
| vponomaryov | gouthamr: also install latest deps of horizon | 16:29 |
| gouthamr | okay, a minute | 16:30 |
| vponomaryov | gouthamr: are you aware how to run developer mode of horizon? | 16:30 |
| vponomaryov | gouthamr: that is single-threaded? | 16:30 |
| gouthamr | vponomaryov: i thought i was doing that.. probably not.. will know in a min | 16:31 |
| *** akapil has quit IRC | 16:31 | |
| vponomaryov | bswartz: so, what about client and compatibility for old server releases? | 16:31 |
| vponomaryov | bswartz: of migration stuff? | 16:32 |
| bswartz | vponomaryov: it's unsupported -- that's the whole point of experimental -- it was an experiment that failed, so we're leaving it behind | 16:34 |
| bswartz | anyone who gets burned took a chance on using the experimental feature | 16:34 |
| bswartz | where it's easy to provide backwards compatibility, we should, but where it's not easy (like this case) then we don't | 16:34 |
| bswartz | anyone who depends on the old experimental feature can keep using the old client until they're ready for a full upgrade | 16:35 |
| vponomaryov | bswartz: you sure you are talking about client changes only? because it is very easy to keep compat there | 16:36 |
| vponomaryov | bswartz: new code just should be added, not replacing existing as it is now | 16:36 |
| bswartz | vponomaryov: on the client side, we know we'll eventually remove the old commands because they're confusing when listed next to the new commands | 16:37 |
| bswartz | vponomaryov: now is the appropriate time to remove them | 16:37 |
| bswartz | or "very soon" if not now | 16:38 |
| bswartz | jay-mehta, markstur: what's the status of https://review.openstack.org/#/c/329552/ | 16:41 |
| vponomaryov | I disagree, but ok, will not block the show going on | 16:48 |
| *** akshai has joined #openstack-manila | 16:50 | |
| vponomaryov | ganso: +2'ed client changes, so, left to fix server side problems | 16:51 |
| ganso | vponomaryov: job is almost done, so it will be ready for merge | 16:51 |
| vponomaryov | ganso: latest one was not tested with drivers | 16:51 |
| ganso | vponomaryov: only new_share_type patch will be left to merge, and that one is rather small | 16:51 |
| *** senk has joined #openstack-manila | 16:52 | |
| ganso | vponomaryov: let's rebase then | 16:52 |
| vponomaryov | ganso: share_type's commit update is a rebase | 16:52 |
| vponomaryov | ganso: so, we should not merge first one until other work on top of it | 16:53 |
| ganso | vponomaryov: I will take about one hour to finish fixing that | 16:53 |
| jay-mehta | bswartz, HPE CI has passed, Jenkins passed. some minor comments now, nothing on functionality much | 16:54 |
| vponomaryov | ganso: hm, on other hand, even if something wrong, you could add its fix to second commit | 16:54 |
| bswartz | jay-mehta: it's got a couple of hours to get +2A | 16:54 |
| ganso | vponomaryov: yes, if something goes wrong with the drivers | 16:54 |
| ganso | vponomaryov: plus, once the drivers are merged as well | 16:54 |
| ganso | vponomaryov: their CI will run against my patch | 16:55 |
| gouthamr | vponomaryov: hmmm, something's weird - i am on manila-ui master.. followed all the instructions - I still can't get horizon to load | 16:55 |
| vponomaryov | gouthamr: how can you prove that your horizon uses manila-ui in developer mode? | 16:56 |
| vponomaryov | gouthamr: and your latest horizon is running from dir you expect | 16:56 |
| gouthamr | vponomaryov: whatever that means :P i am running ./run_tests.sh --runserver 0.0.0.0:8080 | 16:56 |
| gouthamr | from /opt/stack/horizon | 16:56 |
| vponomaryov | and what error you get? | 16:56 |
| gouthamr | http://paste.openstack.org/show/565251/ | 16:57 |
| jay-mehta | bswartz, I will upload next patch in some mins. These are grammar changes mostly. Doing my best to get this in :) | 16:58 |
| vponomaryov | gouthamr: version of horizon? | 16:59 |
| gouthamr | vponomaryov: i'm on commit '26fab9c871883bcf50bb05861451632c86d5fda3' for manila-ui -> latest merged | 16:59 |
| gouthamr | vponomaryov: commit '87818bcd3f025b92b4930fd3059ea6fc66ec8c81' -> latest master | 17:00 |
| *** esker is now known as esker[away] | 17:00 | |
| vponomaryov | it is not latest | 17:00 |
| vponomaryov | it is about month old | 17:00 |
| gouthamr | :( lemme git pull. | 17:01 |
| vponomaryov | gouthamr: anyway, you run old code somehow | 17:01 |
| vponomaryov | gouthamr: remove all old artifacts | 17:01 |
| vponomaryov | gouthamr: compiled pyc files, etc | 17:01 |
| *** esker[away] is now known as esker | 17:03 | |
| *** esker is now known as esker[away] | 17:03 | |
| bswartz | jay-mehta: just making sure you know about the deadline and understand that missing it means the patch slips to ocata | 17:04 |
| gouthamr | vponomaryov: awesome that was one issue. got master to work; now fetching your code | 17:04 |
| vponomaryov | gouthamr: Holy mother of God, you did it! | 17:04 |
| gouthamr | :D | 17:05 |
| markstur | bswartz, Did you grant jay-mehta a FFE or just a FPFE? Ideally it will land before FF today, but the FFE makes me unsure of the deadline. | 17:07 |
| *** akshai has quit IRC | 17:07 | |
| *** faiz89 has joined #openstack-manila | 17:09 | |
| *** faiz89 has quit IRC | 17:10 | |
| *** baojg has quit IRC | 17:10 | |
| *** akshai has joined #openstack-manila | 17:12 | |
| markstur | Did I say "FF today"? | 17:12 |
| *** faiz89 has joined #openstack-manila | 17:13 | |
| *** akshai has quit IRC | 17:14 | |
| *** akshai has joined #openstack-manila | 17:17 | |
| *** dsariel has joined #openstack-manila | 17:23 | |
| *** akshai has quit IRC | 17:23 | |
| *** akshai has joined #openstack-manila | 17:25 | |
| bswartz | markstur: the exception was from the FPF, I don't see any reason to extends the deadline | 17:26 |
| *** akshai has quit IRC | 17:26 | |
| bswartz | jay-mehta claimed that it was ready at the time of the FPF and just missed the deadline by mere hours | 17:27 |
| *** akshai has joined #openstack-manila | 17:28 | |
| *** ksumit has joined #openstack-manila | 17:28 | |
| *** dsariel has quit IRC | 17:30 | |
| *** pcaruana has joined #openstack-manila | 17:39 | |
| *** xyang_ has quit IRC | 17:42 | |
| *** esker[away] is now known as esker | 17:49 | |
| openstackgerrit | Jay Mehta proposed openstack/manila: HPE 3PAR driver pool support https://review.openstack.org/329552 | 17:52 |
| *** porrua has quit IRC | 17:55 | |
| *** akshai has quit IRC | 17:57 | |
| *** porrua has joined #openstack-manila | 18:00 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration https://review.openstack.org/345142 | 18:01 |
| *** ksumit has quit IRC | 18:02 | |
| *** ksumit has joined #openstack-manila | 18:04 | |
| openstackgerrit | Merged openstack/manila: Share migration Newton improvements https://review.openstack.org/328431 | 18:05 |
| *** akshai has joined #openstack-manila | 18:06 | |
| *** lpetrut has joined #openstack-manila | 18:12 | |
| *** ksumit has quit IRC | 18:13 | |
| *** MikeG451 has quit IRC | 18:14 | |
| *** xyang_ has joined #openstack-manila | 18:15 | |
| *** Suyi_ has joined #openstack-manila | 18:18 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [ZFSonLinux] Add share migration support https://review.openstack.org/353417 | 18:21 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Dummy driver] Add share migration support https://review.openstack.org/347853 | 18:21 |
| *** faiz89 has quit IRC | 18:22 | |
| openstackgerrit | Alexey Khodos proposed openstack/manila: Nexenta: adding share drivers for NexentaStor https://review.openstack.org/309286 | 18:22 |
| *** faiz89 has joined #openstack-manila | 18:23 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila: Updated from global requirements https://review.openstack.org/363864 | 18:25 |
| *** sandanar_ has joined #openstack-manila | 18:27 | |
| *** sandanar_ has quit IRC | 18:28 | |
| *** sandanar has quit IRC | 18:30 | |
| *** esker has quit IRC | 18:31 | |
| *** MikeG451 has joined #openstack-manila | 18:35 | |
| *** ksumit has joined #openstack-manila | 18:37 | |
| *** senk has quit IRC | 18:49 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration https://review.openstack.org/345142 | 18:49 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [ZFSonLinux] Add share migration support https://review.openstack.org/353417 | 18:50 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Dummy driver] Add share migration support https://review.openstack.org/347853 | 18:50 |
| *** akshai has quit IRC | 18:55 | |
| *** senk has joined #openstack-manila | 18:55 | |
| *** akshai has joined #openstack-manila | 18:55 | |
| *** Yogi1 has joined #openstack-manila | 18:57 | |
| *** porrua has quit IRC | 19:11 | |
| *** Yogi1 has quit IRC | 19:11 | |
| *** porrua has joined #openstack-manila | 19:13 | |
| *** cknight has quit IRC | 19:25 | |
| *** porrua has quit IRC | 19:25 | |
| *** akshai has quit IRC | 19:25 | |
| *** ksumit has quit IRC | 19:27 | |
| *** akshai has joined #openstack-manila | 19:28 | |
| *** ksumit has joined #openstack-manila | 19:28 | |
| *** faiz89 has quit IRC | 19:28 | |
| *** akshai has quit IRC | 19:31 | |
| *** akshai has joined #openstack-manila | 19:32 | |
| *** ksumit has quit IRC | 19:32 | |
| *** cknight has joined #openstack-manila | 19:32 | |
| *** faiz89 has joined #openstack-manila | 19:43 | |
| *** akshai has quit IRC | 19:49 | |
| gouthamr | ganso: ping | 19:53 |
| ganso | gouthamr: pong | 19:53 |
| gouthamr | ganso: hey, https://review.openstack.org/#/c/345142 | 19:54 |
| gouthamr | ganso: something you can fix hopefully... also APIImpact | 19:54 |
| ganso | gouthamr: is gerrit very slow for your as well? | 19:55 |
| gouthamr | ganso: nope.. | 19:56 |
| bswartz | if it wasn't slow at this point in the release I'd be surprised | 19:56 |
| ganso | bswartz: that's what I expect | 19:56 |
| openstackgerrit | Merged openstack/manila: Change assertTrue(isinstance()) by optimal assert https://review.openstack.org/362671 | 19:56 |
| ganso | gouthamr: but if it is not slow for goutham and only for me, something is wrong with my internet | 19:57 |
| *** alyson_ has joined #openstack-manila | 19:57 | |
| gouthamr | :P or your browser | 19:57 |
| gouthamr | but yes, its possibly slow | 19:57 |
| ganso | gouthamr: unlikely, I restart my browser everyday | 19:57 |
| ganso | gouthamr: btw did you see the InvalidShare I raise in share/api? | 19:58 |
| gouthamr | ganso: not yet.. looking | 19:59 |
| ganso | gouthamr: btw, you +1'ed this: https://review.openstack.org/#/c/358119 | 19:59 |
| ganso | gouthamr: isn't this supposed to be a blueprint? | 19:59 |
| ganso | gouthamr: release notes says "Enhanced"... not "Fixed" | 20:00 |
| gouthamr | ganso: i think its a bug because most commands have it | 20:00 |
| gouthamr | ganso: oh.. | 20:00 |
| *** cknight has quit IRC | 20:08 | |
| *** eharney has quit IRC | 20:11 | |
| *** akerr has quit IRC | 20:17 | |
| *** porrua has joined #openstack-manila | 20:25 | |
| *** ksumit has joined #openstack-manila | 20:25 | |
| *** akshai has joined #openstack-manila | 20:25 | |
| *** faiz89 has quit IRC | 20:27 | |
| *** ksumit has quit IRC | 20:30 | |
| *** assassin has quit IRC | 20:33 | |
| *** ubijtsa has joined #openstack-manila | 20:33 | |
| *** ubijtsa is now known as Guest44588 | 20:34 | |
| *** faiz89 has joined #openstack-manila | 20:34 | |
| *** xyang_ has quit IRC | 20:37 | |
| *** xyang_ has joined #openstack-manila | 20:42 | |
| gouthamr | ganso: https://review.openstack.org/#/c/345142 <-- apart from those comments, i wasn't able to find anything amiss.. the share type, network change logic looks good.. | 20:51 |
| gouthamr | ganso: im okay if you just want to fix the API now and worry about other things as bugfixes.. | 20:51 |
| ganso | gouthamr: I am reading the comments hold on | 20:52 |
| *** ksumit has joined #openstack-manila | 20:52 | |
| ganso | gouthamr: regarding the reno | 20:53 |
| ganso | gouthamr: I planned for that patch to be complementary | 20:53 |
| ganso | gouthamr: I was not sure if that could work | 20:53 |
| ganso | gouthamr: so I will just create its own reno | 20:54 |
| ganso | gouthamr: I gotta go now, I will address your comments tonight | 20:55 |
| *** eharney has joined #openstack-manila | 20:55 | |
| *** porrua has quit IRC | 20:57 | |
| gouthamr | ganso: np.. | 20:57 |
| *** ksumit has quit IRC | 21:06 | |
| *** gouthamr has quit IRC | 21:18 | |
| *** faiz89 has quit IRC | 21:25 | |
| openstackgerrit | Merged openstack/manila-ui: Add share replication support https://review.openstack.org/226389 | 21:35 |
| *** faiz89 has joined #openstack-manila | 21:35 | |
| *** xyang_ has quit IRC | 21:51 | |
| *** xyang_ has joined #openstack-manila | 21:51 | |
| *** xyang_ has quit IRC | 21:55 | |
| *** xyang_ has joined #openstack-manila | 21:57 | |
| *** faiz89 has quit IRC | 22:03 | |
| *** alyson_ has quit IRC | 22:03 | |
| *** esker has joined #openstack-manila | 22:06 | |
| *** vbellur has joined #openstack-manila | 22:08 | |
| *** akshai has quit IRC | 22:12 | |
| *** xyang1 has quit IRC | 22:15 | |
| *** eharney has quit IRC | 22:17 | |
| *** xyang_ has quit IRC | 22:26 | |
| *** lpetrut has quit IRC | 22:26 | |
| *** rooneym has quit IRC | 22:29 | |
| *** xyang_ has joined #openstack-manila | 22:29 | |
| *** xyang_ has quit IRC | 22:29 | |
| *** akshai has joined #openstack-manila | 22:32 | |
| *** akshai has quit IRC | 22:34 | |
| *** akshai has joined #openstack-manila | 22:42 | |
| *** esker has quit IRC | 22:45 | |
| *** esker has joined #openstack-manila | 22:52 | |
| *** dustins has quit IRC | 22:55 | |
| *** gouthamr has joined #openstack-manila | 23:02 | |
| *** tpsilva has quit IRC | 23:14 | |
| *** akshai_ has joined #openstack-manila | 23:15 | |
| *** akshai has quit IRC | 23:19 | |
| ganso | gouthamr: ping | 23:29 |
| gouthamr | ganso: pong | 23:29 |
| ganso | gouthamr: hey goutham, regarding the db migration downgrade | 23:30 |
| ganso | gouthamr: your suggestion of getting the first is pretty equivalent to what I am doing | 23:30 |
| ganso | gouthamr: getting the first or the last is the same if we do not do anything special like check the instance status | 23:31 |
| gouthamr | ganso: but if you have three instances, lets say, you update the value thrice | 23:31 |
| ganso | gouthamr: oh yes | 23:32 |
| ganso | gouthamr: but do you think it is worth checking the instance status? | 23:32 |
| ganso | gouthamr: I don't think it is a good idea | 23:32 |
| gouthamr | ganso: yes.. we should just use first(), that's what we're doing when downgrading from share-instances to not having share-instances | 23:33 |
| ganso | gouthamr: there is no way to avoid the possibility of losing data, or choosing the share_type from the correct instance | 23:33 |
| gouthamr | ganso: yep.. i was suggesting adding a #NOTE to say what's going to happen | 23:33 |
| gouthamr | ganso: https://github.com/openstack/manila/blob/master/manila/db/migrations/alembic/versions/5077ffcc5f1c_add_share_instances.py#L290 | 23:35 |
| gouthamr | ganso: and https://github.com/openstack/manila/blob/master/manila/db/migrations/alembic/versions/5077ffcc5f1c_add_share_instances.py#L117 | 23:36 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration https://review.openstack.org/345142 | 23:43 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration https://review.openstack.org/345142 | 23:45 |
| *** esker has quit IRC | 23:47 | |
| *** Suyi_ has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!