| *** yangyapeng has quit IRC | 00:04 | |
| *** Suyi has quit IRC | 00:35 | |
| openstackgerrit | Merged openstack/python-manilaclient: Add snapshot instances admin CLIs https://review.openstack.org/304449 | 00:44 |
|---|---|---|
| *** yangyapeng has joined #openstack-manila | 01:26 | |
| *** wangqun has joined #openstack-manila | 01:37 | |
| *** yangyape_ has joined #openstack-manila | 01:59 | |
| *** yangyapeng has quit IRC | 02:03 | |
| *** vbellur has joined #openstack-manila | 02:17 | |
| *** houming has joined #openstack-manila | 02:36 | |
| *** liyifeng has joined #openstack-manila | 02:43 | |
| openstackgerrit | zhongjun proposed openstack/manila: Add IPv6 ACL support in Manila https://review.openstack.org/312321 | 02:54 |
| openstackgerrit | zhongjun proposed openstack/python-manilaclient: Add IPv6 ACL support in Manila Client https://review.openstack.org/328932 | 03:02 |
| openstackgerrit | zhongjun proposed openstack/python-manilaclient: Implement share backup https://review.openstack.org/344671 | 03:05 |
| *** liyifeng has quit IRC | 03:19 | |
| *** daidv has joined #openstack-manila | 03:20 | |
| *** liyifeng has joined #openstack-manila | 03:21 | |
| *** daidv has quit IRC | 03:45 | |
| *** yangyape_ has quit IRC | 03:56 | |
| *** yangyapeng has joined #openstack-manila | 03:58 | |
| *** daidv has joined #openstack-manila | 04:14 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 04:41 |
| *** senk_ has joined #openstack-manila | 05:16 | |
| *** houming has quit IRC | 05:24 | |
| *** lpetrut has joined #openstack-manila | 05:26 | |
| *** senk_ has quit IRC | 05:45 | |
| *** yangyape_ has joined #openstack-manila | 05:55 | |
| *** yangyapeng has quit IRC | 05:58 | |
| *** sandanar has joined #openstack-manila | 06:02 | |
| *** dsariel has joined #openstack-manila | 06:06 | |
| *** dsariel has quit IRC | 06:15 | |
| *** wangqun_ has joined #openstack-manila | 06:18 | |
| *** wangqun has quit IRC | 06:21 | |
| *** zengyingzhe_ has quit IRC | 06:21 | |
| *** lpetrut has quit IRC | 06:29 | |
| *** liyifeng has quit IRC | 06:35 | |
| *** yangyape_ has quit IRC | 06:38 | |
| openstackgerrit | Marc Koderer proposed openstack/manila: Add neutron driver for binding https://review.openstack.org/283494 | 06:39 |
| *** yangyapeng has joined #openstack-manila | 06:40 | |
| *** yangyape_ has joined #openstack-manila | 06:42 | |
| *** yangyapeng has quit IRC | 06:46 | |
| *** aovchinnikov has joined #openstack-manila | 06:48 | |
| *** dsariel has joined #openstack-manila | 06:56 | |
| *** lpetrut has joined #openstack-manila | 06:57 | |
| *** akapil has joined #openstack-manila | 07:05 | |
| *** lpetrut has quit IRC | 07:08 | |
| *** houming has joined #openstack-manila | 07:09 | |
| *** tovchinnikova has joined #openstack-manila | 07:11 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 07:20 |
| *** dsariel has quit IRC | 07:22 | |
| *** dsariel has joined #openstack-manila | 07:34 | |
| *** daidv has quit IRC | 07:38 | |
| *** daidv has joined #openstack-manila | 07:38 | |
| *** zengyingzhe has joined #openstack-manila | 07:39 | |
| *** chlong has quit IRC | 07:50 | |
| *** akapil has quit IRC | 07:58 | |
| openstackgerrit | Marc Koderer proposed openstack/manila: Add binding_profile option for backends https://review.openstack.org/284034 | 07:59 |
| openstackgerrit | Marc Koderer proposed openstack/manila: Add multi-segment support https://review.openstack.org/277731 | 07:59 |
| *** akapil has joined #openstack-manila | 08:02 | |
| *** akapil has quit IRC | 08:07 | |
| *** akapil has joined #openstack-manila | 08:08 | |
| *** dsariel has quit IRC | 08:12 | |
| *** wangqun_ has quit IRC | 08:27 | |
| openstackgerrit | Merged openstack/manila: In-tree Install Guide https://review.openstack.org/317152 | 08:32 |
| *** sandanar_ has joined #openstack-manila | 08:34 | |
| openstackgerrit | Ramana Raja proposed openstack/manila: add access_key to share_access_map https://review.openstack.org/343306 | 08:38 |
| *** sandanar has quit IRC | 08:38 | |
| *** dsariel has joined #openstack-manila | 08:38 | |
| *** akapil has quit IRC | 08:49 | |
| *** aovchinnikov has quit IRC | 08:52 | |
| *** daidv has quit IRC | 08:55 | |
| *** tovchinnikova has quit IRC | 08:55 | |
| *** tovchinnikova has joined #openstack-manila | 08:58 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-manilaclient: Updated from global requirements https://review.openstack.org/354311 | 09:00 |
| *** akapil has joined #openstack-manila | 09:05 | |
| *** akapil has quit IRC | 09:21 | |
| openstackgerrit | Erno Kuvaja proposed openstack/puppet-manila: Add CephFSNative driver logic https://review.openstack.org/353928 | 09:23 |
| *** akapil has joined #openstack-manila | 09:24 | |
| openstackgerrit | Marc Koderer proposed openstack/manila: Add binding_profile option for backends https://review.openstack.org/284034 | 09:24 |
| openstackgerrit | Marc Koderer proposed openstack/manila: Add multi-segment support https://review.openstack.org/277731 | 09:24 |
| openstackgerrit | Marc Koderer proposed openstack/manila: Add neutron driver for binding https://review.openstack.org/283494 | 09:24 |
| *** lpetrut has joined #openstack-manila | 09:37 | |
| *** ociuhandu has joined #openstack-manila | 09:40 | |
| *** akapil has quit IRC | 09:42 | |
| *** akapil has joined #openstack-manila | 09:42 | |
| *** dmellado has quit IRC | 09:46 | |
| *** liyifeng has joined #openstack-manila | 09:54 | |
| *** dmellado has joined #openstack-manila | 09:56 | |
| *** dsariel has quit IRC | 09:59 | |
| *** yangyape_ has quit IRC | 10:01 | |
| *** rraja has joined #openstack-manila | 10:01 | |
| *** sandanar__ has joined #openstack-manila | 10:03 | |
| *** sandanar_ has quit IRC | 10:07 | |
| openstackgerrit | Tom Barron proposed openstack/manila: Fix sample config generation for cinder,nova and neutron opts https://review.openstack.org/355517 | 10:10 |
| *** aovchinnikov has joined #openstack-manila | 10:11 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 10:14 |
| *** yangyapeng has joined #openstack-manila | 10:16 | |
| *** akapil has quit IRC | 10:17 | |
| *** lpetrut has quit IRC | 10:20 | |
| *** yangyapeng has quit IRC | 10:22 | |
| *** lpetrut has joined #openstack-manila | 10:22 | |
| *** akapil has joined #openstack-manila | 10:33 | |
| *** narayrak has joined #openstack-manila | 10:39 | |
| *** alyson_ has joined #openstack-manila | 11:09 | |
| *** ociuhandu has quit IRC | 11:20 | |
| *** merooney has joined #openstack-manila | 11:28 | |
| *** yangyapeng has joined #openstack-manila | 11:32 | |
| openstackgerrit | Ramana Raja proposed openstack/manila: manila_tempest_tests: fix an exception message https://review.openstack.org/355860 | 11:32 |
| *** yangyapeng has quit IRC | 11:36 | |
| openstackgerrit | Ramana Raja proposed openstack/manila: manila_tempest_tests: fix exception messages https://review.openstack.org/355860 | 11:40 |
| *** tpsilva has joined #openstack-manila | 11:41 | |
| *** dsariel has joined #openstack-manila | 11:44 | |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Add Hitachi HSP driver https://review.openstack.org/329134 | 11:44 |
| openstackgerrit | Marc Koderer proposed openstack/manila: Add binding_profile option for backends https://review.openstack.org/284034 | 11:47 |
| openstackgerrit | Marc Koderer proposed openstack/manila: Add multi-segment support https://review.openstack.org/277731 | 11:47 |
| openstackgerrit | Marc Koderer proposed openstack/manila: Add neutron driver for binding https://review.openstack.org/283494 | 11:47 |
| mkoderer | aovchinnikov: hi | 11:48 |
| mkoderer | aovchinnikov: jfyi the binding patches passes the experimental docker job :) | 11:49 |
| aovchinnikov | mkoderer: hi. great! so we'll have proper binding soon | 11:50 |
| mkoderer | aovchinnikov: you might do a review on https://review.openstack.org/283494 - I moved the config slightly | 11:53 |
| aovchinnikov | mkoderer: sure, I'll review it | 11:58 |
| mkoderer | tbarron: mhh, you corrected the missing blank in https://review.openstack.org/#/c/355517/2 ? | 12:06 |
| mkoderer | I can't see the change ;) | 12:07 |
| mkoderer | but let's merge it anyway :) | 12:07 |
| tbarron | mkoderer: ah, i fixed a difft one: no space between '[nova],' and '[cinder]' :) | 12:09 |
| openstackgerrit | Tom Barron proposed openstack/manila: Fix sample config generation for cinder, nova and neutron opts https://review.openstack.org/355517 | 12:10 |
| *** dsariel has quit IRC | 12:13 | |
| *** narayrak has quit IRC | 12:15 | |
| openstackgerrit | zhongjun proposed openstack/manila: Add IPv6 ACL support in Manila https://review.openstack.org/312321 | 12:20 |
| *** yangyapeng has joined #openstack-manila | 12:30 | |
| *** gouthamr has joined #openstack-manila | 12:31 | |
| *** sandanar__ has quit IRC | 12:39 | |
| *** lpetrut1 has joined #openstack-manila | 12:41 | |
| *** lpetrut has quit IRC | 12:41 | |
| *** lpetrut1 is now known as lpetrut | 12:41 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Fix sample config generation for cinder, nova and neutron opts https://review.openstack.org/355517 | 12:45 |
| *** dsariel has joined #openstack-manila | 12:46 | |
| openstackgerrit | Erno Kuvaja proposed openstack/puppet-manila: Add CephFSNative driver logic https://review.openstack.org/353928 | 12:49 |
| *** bswartz has joined #openstack-manila | 12:50 | |
| *** ociuhandu has joined #openstack-manila | 12:50 | |
| *** dsariel has quit IRC | 12:52 | |
| openstackgerrit | Alyson proposed openstack/manila: Fix Manila HNAS driver managing twice a share https://review.openstack.org/355906 | 12:54 |
| *** ociuhandu has quit IRC | 12:57 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 12:58 |
| *** rraja has quit IRC | 12:58 | |
| *** rraja has joined #openstack-manila | 12:59 | |
| *** ganso has joined #openstack-manila | 12:59 | |
| *** xyang1 has joined #openstack-manila | 13:03 | |
| *** cknight has joined #openstack-manila | 13:04 | |
| *** ociuhandu has joined #openstack-manila | 13:08 | |
| *** houming has quit IRC | 13:09 | |
| *** porrua has joined #openstack-manila | 13:13 | |
| tpsilva | cknight, gouthamr, ganso, xyang1: https://review.openstack.org/#/c/329134/ fixed comments and CI is working and reporting, would appreciate any reviews | 13:15 |
| gouthamr | tpsilva: sure thing.. | 13:15 |
| tpsilva | jenkins is almost done, +1 should be there in a bit | 13:15 |
| cknight | tpsilva: Hi, Tiago. Already on it. | 13:15 |
| tpsilva | cknight, gouthamr: thank you! | 13:15 |
| *** vbellur has quit IRC | 13:16 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: [Do Not Merge] - Tempest cleanup issues with share networks https://review.openstack.org/355915 | 13:18 |
| *** dustins has joined #openstack-manila | 13:22 | |
| *** rraja has quit IRC | 13:23 | |
| ganso | gouthamr: ping | 13:25 |
| gouthamr | ganso: pong | 13:25 |
| ganso | gouthamr: Hi Goutham | 13:25 |
| gouthamr | ganso: Hi Rodrigo.. sorry about the 40something comments :) | 13:25 |
| ganso | gouthamr: regarding your comment in https://review.openstack.org/#/c/332267/50/manila/data/utils.py | 13:25 |
| ganso | gouthamr: lol no problem, very good feedback :) | 13:26 |
| gouthamr | ganso: yessir.. what can i clarify? | 13:26 |
| ganso | gouthamr: the ideal way to create a view for the migration progress, is when we have the jobs table | 13:26 |
| ganso | gouthamr: the dict I create is so I can transfer that information back to the API | 13:26 |
| ganso | gouthamr: right now, that information would be equivalent to the one the view would have | 13:27 |
| ganso | gouthamr: unless you are suggesting I create a class to do so instead of dict | 13:27 |
| gouthamr | ganso: yes.. i think the API response should be consistent | 13:27 |
| ganso | gouthamr: so that would be, changing the dict to class, then in API changing back to a dict through view builder? | 13:28 |
| gouthamr | ganso: always respond with the same keys, even if the keys have no values.. | 13:28 |
| ganso | gouthamr: oh I see | 13:28 |
| ganso | gouthamr: no need to create the class then | 13:28 |
| gouthamr | ganso: these sort of things can be better handled with a view builder | 13:28 |
| ganso | gouthamr: just select the keys | 13:29 |
| gouthamr | ganso: still use a view builder.. no API should build a response without one.... | 13:29 |
| ganso | gouthamr: right | 13:30 |
| ganso | gouthamr: regarding the changes related to fallback in the same file | 13:30 |
| ganso | gouthamr: I opened a bug for it | 13:30 |
| gouthamr | ganso: yes, i'm okay with it being part of that patch.. the commit message doesn't specify it | 13:30 |
| ganso | gouthamr: the justification for including with the same change are: 1) easier to backport, assuming we are backporting that migration patch as well. 2) avoid dependency hell, since the newton improvements patch depends on both fixes | 13:31 |
| ganso | gouthamr: although, I am starting to think we are not going to backport that patch... | 13:31 |
| ganso | gouthamr: but the other fix should be backported | 13:31 |
| gouthamr | ganso: i don't see the value of backporting the driver optimized migration fixes.. unless someone is maintaining an out-of-tree driver and would like this fix? | 13:32 |
| ganso | gouthamr: exactly | 13:33 |
| ganso | gouthamr: since you also started working on it rebasing on top of the big fix patch, I thought about merging that one and the improvements | 13:34 |
| ganso | gouthamr: since basically you are developing something that will have its interfaces changed in the following patch, and also you SHOULD take advantage of the new parameters in the improvements patch | 13:35 |
| gouthamr | ganso: and propose a separate bugfix directly to mitaka? | 13:35 |
| ganso | gouthamr: for the fallback migration one yes, for the big fix, no | 13:35 |
| *** rraja has joined #openstack-manila | 13:36 | |
| *** catintheroof has joined #openstack-manila | 13:36 | |
| gouthamr | ganso: would it be hard to separate the generic portions from that patch? your backport can be a trivial cherry-pick if you do.. :) | 13:37 |
| ganso | gouthamr: the reason I separated is also that I wanted to focus on their specific proposed changes | 13:37 |
| ganso | gouthamr: yes, I am already on it | 13:37 |
| ganso | gouthamr: I assume you haven't looked deep into the newton improvements patch, but when you do, I assume it is also easier if it the changes are clear instead of a huge amount of changes mixed together | 13:38 |
| gouthamr | ganso: nope.. i was trying your bugfix first | 13:38 |
| ganso | gouthamr: so that's the main reason I haven't merged both patches | 13:38 |
| gouthamr | ganso: yep, i agree.. your newton improvements is a fairly large patch by itself | 13:39 |
| gouthamr | ganso: will take a look.. | 13:39 |
| ganso | gouthamr: I will address your view builder concern in the newton improvements patch | 13:40 |
| ganso | gouthamr: since I am entirely removing those changes from the driver-assisted big fix | 13:40 |
| gouthamr | ganso: sure.. | 13:40 |
| ganso | gouthamr: and it will also not make sense to include in the fix, since it is not related to the bug | 13:41 |
| gouthamr | ganso: yes.. np. | 13:41 |
| *** xyang_ has joined #openstack-manila | 13:43 | |
| *** catintheroof has quit IRC | 13:43 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix fallback share migration with empty files https://review.openstack.org/355946 | 13:53 |
| *** permalac has joined #openstack-manila | 13:53 | |
| *** vbellur has joined #openstack-manila | 13:58 | |
| openstackgerrit | Merged openstack/python-manilaclient: Updated from global requirements https://review.openstack.org/354311 | 14:01 |
| *** aovchinnikov has quit IRC | 14:01 | |
| openstackgerrit | Erno Kuvaja proposed openstack/puppet-manila: Add CephFSNative driver logic https://review.openstack.org/353928 | 14:05 |
| *** lpetrut1 has joined #openstack-manila | 14:10 | |
| *** lpetrut has quit IRC | 14:11 | |
| *** lpetrut1 is now known as lpetrut | 14:11 | |
| *** tovchinnikova has quit IRC | 14:20 | |
| alyson_ | ganso: https://review.openstack.org/#/c/355906/ | 14:22 |
| *** xyang_ has quit IRC | 14:39 | |
| *** akerr has joined #openstack-manila | 14:41 | |
| *** akapil has quit IRC | 14:44 | |
| *** xyang_ has joined #openstack-manila | 14:49 | |
| *** dsariel has joined #openstack-manila | 14:55 | |
| *** permalac has quit IRC | 14:58 | |
| *** lpetrut1 has joined #openstack-manila | 14:58 | |
| *** lpetrut has quit IRC | 15:00 | |
| *** lpetrut1 is now known as lpetrut | 15:00 | |
| *** vbellur has quit IRC | 15:02 | |
| *** vbellur has joined #openstack-manila | 15:17 | |
| *** mtanino has joined #openstack-manila | 15:20 | |
| *** akerr has quit IRC | 15:35 | |
| *** akerr has joined #openstack-manila | 15:35 | |
| *** porrua has quit IRC | 15:44 | |
| *** liyifeng has quit IRC | 16:04 | |
| *** liyifeng has joined #openstack-manila | 16:04 | |
| *** aovchinnikov has joined #openstack-manila | 16:06 | |
| *** xyang1 has quit IRC | 16:09 | |
| *** dsariel has quit IRC | 16:10 | |
| *** xyang1 has joined #openstack-manila | 16:18 | |
| mkoderer__ | gouthamr: hi, just to clarify - do you want the neutron driver opts in [neutron] or what it a question? | 16:21 |
| mkoderer__ | gouthamr: since moving them to [neutron] doesn't really work since the network settings differ per backend | 16:22 |
| gouthamr | mkoderer__: yes, thanks for responding.. no, i don't suggest adding them in [neutron | 16:22 |
| mkoderer__ | gouthamr: ok cool | 16:22 |
| mkoderer__ | gouthamr: I will address you finding tomorrow | 16:22 |
| mkoderer__ | s/finding/findings/ | 16:22 |
| gouthamr | mkoderer__: my question was wrt 'deprecated' group.. | 16:22 |
| *** dsariel has joined #openstack-manila | 16:23 | |
| gouthamr | mkoderer__: sure thing.. i guess the SingleNetworkPlugin *may* not work; i'm not thoroughly sure.. but since we're not testing it, i would like your opinion on what i posted. | 16:23 |
| mkoderer__ | gouthamr: I just marked it as deprecated because Alexey had it in. I would say new opts shouldn't have any deprecations | 16:24 |
| gouthamr | mkoderer__: exactly.. it's a new opt :D | 16:24 |
| *** porrua has joined #openstack-manila | 16:24 | |
| mkoderer__ | gouthamr: I remember I tested the singleNetworkPlugin but I can redo | 16:24 |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Rename and move HNAS driver https://review.openstack.org/356049 | 16:25 |
| mkoderer__ | gouthamr: I will check tomorrow | 16:25 |
| gouthamr | mkoderer__: sure.. np.. no rush | 16:25 |
| mkoderer__ | gouthamr: tomorrow is my last day before vacation :P | 16:25 |
| mkoderer__ | time to hurry haha | 16:25 |
| gouthamr | mkoderer__: :) we can merge this and fix bugs as we find them; specially this has been tested against a gate driver | 16:26 |
| * gouthamr especially. darn. | 16:26 | |
| *** Suyi has joined #openstack-manila | 16:28 | |
| rraja | gouthamr: hi, regarding db migration unit test failure for https://review.openstack.org/#/c/343306/ | 16:31 |
| rraja | http://logs.openstack.org/06/343306/10/check/gate-manila-python27-db-ubuntu-xenial/2a5f33d/console.html | 16:32 |
| rraja | https://review.openstack.org/#/c/343306/10/manila/tests/db/migrations/alembic/migrations_data_checks.py | 16:33 |
| rraja | https://github.com/openstack/manila/blob/master/manila/db/migrations/alembic/versions/579c267fbb4d_add_share_instances_access_map.py#L102 | 16:33 |
| rraja | gouthamr: i'm kind of stuck here. would you've any clue how I can overcome this failure? am I missing something while setting up data for the unit tests? | 16:34 |
| mkoderer__ | rraja: can you reproduce it locally? | 16:48 |
| rraja | mkoderer__: yes. | 16:48 |
| * mkoderer__ has a look | 16:49 | |
| rraja | mkoderer__: thanks a lot! | 16:50 |
| mkoderer__ | rraja: can you set a breakpoint and check the database | 16:53 |
| mkoderer__ | rraja: that's at least what I am doing | 16:54 |
| rraja | mkoderer__: yeah. i can do that. wondering, if I'm missing something obvious. | 16:55 |
| rraja | thanks! | 16:55 |
| mkoderer__ | I don't understand why these two migration script interfere each other | 16:55 |
| rraja | mkoderer__: yeah. i'm confused about that too. | 16:55 |
| mkoderer__ | rraja: yeah, at least I don't see it just by looking | 16:56 |
| mkoderer__ | rraja: but gouthamr is much smarter - maybe he will find it | 16:56 |
| mkoderer__ | :) | 16:56 |
| rraja | mkoderer__: oh no! i pinged him, as he's been reviewing my patch. | 16:57 |
| rraja | and he's quick to respond | 16:57 |
| mkoderer__ | rraja: ok, if you find it let me know - seems to be an intressting problem ;) | 16:58 |
| rraja | my intention was not to pick the smartest person. i'm not smart enough to figure who that is. | 16:58 |
| rraja | mkoderer__: cool! thanks! | 16:59 |
| mkoderer__ | rraja: you prefer low response times rather than smartness - I see :) | 17:01 |
| rraja | mkoderer__: :) | 17:01 |
| openstackgerrit | Ramana Raja proposed openstack/manila: add access_key to share_access_map https://review.openstack.org/343306 | 17:05 |
| *** rraja has quit IRC | 17:09 | |
| *** david-lyle_ has joined #openstack-manila | 17:09 | |
| *** Suyi has quit IRC | 17:10 | |
| *** david-lyle has quit IRC | 17:13 | |
| *** david-lyle_ is now known as david-lyle | 17:13 | |
| *** Suyi has joined #openstack-manila | 17:14 | |
| openstackgerrit | Merged openstack/manila: Add Hitachi HSP driver https://review.openstack.org/329134 | 17:15 |
| openstackgerrit | Lucian Petrut proposed openstack/manila: Windows SMB: avoid default read share access https://review.openstack.org/354853 | 17:17 |
| openstackgerrit | Lucian Petrut proposed openstack/manila: Windows SMB: implement 'update_access' method https://review.openstack.org/354855 | 17:17 |
| openstackgerrit | Lucian Petrut proposed openstack/manila: Windows SMB: remove redundant operations https://review.openstack.org/354854 | 17:17 |
| *** xyang_ has quit IRC | 17:20 | |
| *** lpetrut has quit IRC | 17:21 | |
| *** akapil has joined #openstack-manila | 17:23 | |
| *** dsariel has quit IRC | 17:46 | |
| *** akapil_ has joined #openstack-manila | 18:02 | |
| *** vbellur has quit IRC | 18:02 | |
| *** akapil has quit IRC | 18:04 | |
| *** ociuhandu has quit IRC | 18:07 | |
| *** lpetrut has joined #openstack-manila | 18:16 | |
| *** vbellur has joined #openstack-manila | 18:18 | |
| openstackgerrit | Alyson proposed openstack/manila: Add cleanup to create from snap in Manila HNAS driver https://review.openstack.org/356087 | 18:21 |
| *** ociuhandu has joined #openstack-manila | 18:32 | |
| ganso | gouthamr: ping | 18:32 |
| *** xyang_ has joined #openstack-manila | 18:34 | |
| *** akapil_ has quit IRC | 18:36 | |
| *** aovchinnikov has quit IRC | 18:37 | |
| gouthamr | ganso: pong | 18:37 |
| *** akerr is now known as akerr_away | 18:38 | |
| *** akerr_away is now known as akerr | 18:38 | |
| ganso | gouthamr: My coworkers and I are discussing whether Alyson's patch above deserves a reno or not. My vote is that it deserves a reno, others are argumenting that it does not. Its scenario is not explicitely described in reno docs, so I thought I would ask the reno guy for a proper answer :) | 18:39 |
| gouthamr | :P | 18:39 |
| gouthamr | https://review.openstack.org/#/c/356087/ | 18:39 |
| gouthamr | ? | 18:39 |
| ganso | gouthamr: ya | 18:39 |
| alyson_ | yes | 18:39 |
| gouthamr | looking | 18:39 |
| ganso | gouthamr: my argument is: suppose an admin knows about the bug, he tries to create a share from snapshot, but it failed, and he notices it leaves garbage in the storage | 18:40 |
| ganso | gouthamr: so, by including the bugfix in the reno, the admin can be aware this specific bug he knows about is fixed | 18:40 |
| gouthamr | ganso: i agree, whether or they knew of the bug, if its a bug, we can call it out and say its fixed.. | 18:42 |
| ganso | gouthamr: yes. The confusion regarding the reno docs, is about the user impact | 18:42 |
| ganso | gouthamr: the reno docs says "security bugs" | 18:43 |
| gouthamr | ganso: this isn't a security bug.. | 18:43 |
| gouthamr | ganso: "fixes" is appropriate.. | 18:43 |
| ganso | gouthamr: yes | 18:43 |
| ganso | gouthamr: thanks goutham! | 18:44 |
| gouthamr | ganso: np! | 18:44 |
| alyson_ | thanks reno guy :P | 18:44 |
| ganso | lol | 18:45 |
| gouthamr | :) | 18:47 |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Rename and move HNAS driver https://review.openstack.org/356049 | 18:52 |
| *** xyang_ has quit IRC | 18:58 | |
| *** xyang_ has joined #openstack-manila | 19:00 | |
| *** merooney has quit IRC | 19:20 | |
| *** merooney has joined #openstack-manila | 19:23 | |
| *** akapil has joined #openstack-manila | 19:23 | |
| *** xyang1 has quit IRC | 19:29 | |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Rename and move HNAS driver https://review.openstack.org/356049 | 19:33 |
| *** xyang_ has quit IRC | 19:37 | |
| *** Rantraven has joined #openstack-manila | 19:37 | |
| *** lpetrut has quit IRC | 19:39 | |
| *** akapil has quit IRC | 19:39 | |
| *** xyang_ has joined #openstack-manila | 19:41 | |
| *** xyang_ has quit IRC | 19:42 | |
| *** xyang_ has joined #openstack-manila | 19:42 | |
| *** xyang_ has quit IRC | 19:45 | |
| Rantraven | hi | 19:48 |
| ganso | gouthamr: ping | 19:49 |
| *** akapil has joined #openstack-manila | 19:49 | |
| openstackgerrit | Alyson proposed openstack/manila: Fix Manila HNAS driver managing twice a share https://review.openstack.org/355906 | 19:50 |
| openstackgerrit | Merged openstack/manila: manila_tempest_tests: fix exception messages https://review.openstack.org/355860 | 19:50 |
| openstackgerrit | Alyson proposed openstack/manila: Fix Manila HNAS driver managing twice a share https://review.openstack.org/355906 | 19:53 |
| gouthamr | ganso: pong | 19:55 |
| *** Rantraven has quit IRC | 19:56 | |
| ganso | gouthamr: https://review.openstack.org/#/c/332267/50/manila/share/manager.py LN 772 | 19:59 |
| ganso | gouthamr: what are you suggesting by polling? I believe polling is what I am doing o_O | 19:59 |
| openstackgerrit | Alex Meade proposed openstack/manila: Manila Share Groups https://review.openstack.org/335093 | 20:07 |
| *** porrua has quit IRC | 20:10 | |
| gouthamr | ganso: sorry for the latency.. have you looked at the other methods that do polling? | 20:10 |
| *** vbellur has quit IRC | 20:11 | |
| ganso | gouthamr: such as? | 20:11 |
| gouthamr | ganso: like delete_free_share_servers, periodic_share_replica_update | 20:12 |
| gouthamr | periodic_share_replica_snapshot_update | 20:12 |
| gouthamr | ganso: the gist is to use periodic_task from oslo_service instead of sleeping and waiting.. | 20:13 |
| *** merooney has quit IRC | 20:13 | |
| ganso | gouthamr: oh I see, that polling mechanism | 20:13 |
| *** akerr has quit IRC | 20:13 | |
| gouthamr | ganso: yes | 20:14 |
| ganso | gouthamr: I am trying to understand how period tasks work, I grepped that method name and can't see what triggers it | 20:17 |
| gouthamr | ganso: it's up here: https://github.com/openstack/oslo.service/blob/master/oslo_service/periodic_task.py | 20:19 |
| ganso | gouthamr: yes but I am looking for what registers "periodic_share_replica_update" to be a task | 20:19 |
| ganso | gouthamr: or when it should be triggered | 20:19 |
| gouthamr | ganso: "spacing" is the interval and that's a config opt.. | 20:20 |
| gouthamr | ganso: it's absolute | 20:20 |
| ganso | gouthamr: it seems to me it will always run | 20:20 |
| gouthamr | ganso: runs every five mins by default, from when the share manager starts.. | 20:20 |
| ganso | gouthamr: the driver_migration_continue should run only in specific situations, not always | 20:21 |
| ganso | gouthamr: if this task is triggered every 5 seconds (which is the current polling rate for my implementation), just to check if there is any driver doing migration and invoking a self-RPC like I am doing in init_host, it seems to me it will add an awful amount of overhead | 20:22 |
| gouthamr | ganso: no, you'll just see if there's an existing migration and call driver_migration_continue if it's there | 20:22 |
| ganso | gouthamr: AFAIK, that's exactly what I described above ^ | 20:23 |
| gouthamr | ganso: hmmm, why do you have to prod the driver every 5 sec? | 20:24 |
| ganso | gouthamr: to not make migration take too long because of it | 20:25 |
| ganso | gouthamr: 1 minute pollin wouldn't be bad | 20:25 |
| ganso | gouthamr: but thinking about the CI, which only tests with empty shares | 20:25 |
| gouthamr | ganso: so i think it's okay to do this as a poll.... we had a similar scenario with replication | 20:25 |
| ganso | gouthamr: waiting 1 minute just to perform next step is too much | 20:25 |
| gouthamr | ganso: yes, you can make the polling interval configurable? | 20:26 |
| ganso | gouthamr: yes | 20:26 |
| ganso | gouthamr: that would compromise the 1-phase implementation for that patch | 20:26 |
| ganso | gouthamr: even though it is going away | 20:26 |
| *** dsariel has joined #openstack-manila | 20:26 | |
| ganso | gouthamr: but then I would have to remove it right now, and would make more sense to merge the patches | 20:27 |
| ganso | gouthamr: or, I can change this in the newton improvements patch | 20:27 |
| gouthamr | ganso: https://github.com/openstack/manila/blob/master/contrib/ci/pre_test_hook.sh#L83 " :P <-- my "CI fix" | 20:27 |
| ganso | gouthamr: yes it makes sense | 20:27 |
| ganso | gouthamr: is it clear for you why it removes 1-phase capability? | 20:28 |
| gouthamr | ganso: yes, i'm okay with that.. :) | 20:28 |
| ganso | gouthamr: ok, I am going to change it in the newton-improvements patch | 20:28 |
| gouthamr | ganso: sure thing | 20:30 |
| *** gouthamr has quit IRC | 20:33 | |
| *** xyang1 has joined #openstack-manila | 20:36 | |
| openstackgerrit | Merged openstack/python-manilaclient: Add columns support for share-replica-list https://review.openstack.org/353073 | 20:40 |
| *** akerr has joined #openstack-manila | 20:45 | |
| *** dsariel has quit IRC | 20:54 | |
| *** akapil has quit IRC | 21:07 | |
| *** akerr has quit IRC | 21:07 | |
| *** akapil has joined #openstack-manila | 21:08 | |
| *** akapil has quit IRC | 21:19 | |
| *** lpetrut has joined #openstack-manila | 21:19 | |
| *** akapil has joined #openstack-manila | 21:26 | |
| *** dustins has quit IRC | 21:27 | |
| *** xyang_ has joined #openstack-manila | 21:46 | |
| *** xyang_ has quit IRC | 21:55 | |
| *** xyang_ has joined #openstack-manila | 21:59 | |
| *** xyang_ has quit IRC | 22:21 | |
| *** lpetrut has quit IRC | 22:31 | |
| *** xyang_ has joined #openstack-manila | 22:35 | |
| *** xyang_ has quit IRC | 22:37 | |
| *** gouthamr has joined #openstack-manila | 22:39 | |
| *** gouthamr_ has joined #openstack-manila | 22:40 | |
| *** gouthamr has quit IRC | 22:44 | |
| *** gouthamr_ is now known as gouthamr | 22:44 | |
| *** merooney has joined #openstack-manila | 23:02 | |
| *** alyson_ has quit IRC | 23:03 | |
| *** tpsilva has quit IRC | 23:08 | |
| *** xyang1 has quit IRC | 23:14 | |
| *** cknight has quit IRC | 23:33 | |
| *** bswartz has quit IRC | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!