*** Suyi_ has quit IRC | 00:01 | |
*** adrianofr has quit IRC | 00:01 | |
*** yangyapeng has quit IRC | 00:02 | |
*** faiz89 has joined #openstack-manila | 00:10 | |
*** gouthamr has joined #openstack-manila | 00:23 | |
*** faiz89 has quit IRC | 00:23 | |
*** gouthamr_ has joined #openstack-manila | 00:24 | |
*** gouthamr has quit IRC | 00:28 | |
*** mtanin___ has joined #openstack-manila | 00:28 | |
*** mtanino has quit IRC | 00:30 | |
*** tpsilva has quit IRC | 00:36 | |
*** vbellur has joined #openstack-manila | 01:05 | |
*** cfey has quit IRC | 01:10 | |
*** liyifeng has quit IRC | 01:12 | |
openstackgerrit | zhongjun proposed openstack/python-manilaclient: Add snapshot instances admin APIs https://review.openstack.org/304449 | 01:15 |
---|---|---|
*** yangyapeng has joined #openstack-manila | 01:16 | |
zhongjun_ | vponomaryov: ping | 01:18 |
*** cknight has joined #openstack-manila | 01:25 | |
*** yangyape_ has joined #openstack-manila | 01:47 | |
*** yangyapeng has quit IRC | 01:47 | |
*** mtanin___ has quit IRC | 01:52 | |
*** yangyapeng has joined #openstack-manila | 01:59 | |
*** yangyape_ has quit IRC | 02:02 | |
*** liyifeng has joined #openstack-manila | 02:03 | |
*** ganso has quit IRC | 02:11 | |
*** amitkqed has quit IRC | 02:30 | |
*** amitkqed has joined #openstack-manila | 02:30 | |
*** yangyapeng has quit IRC | 02:36 | |
*** yangyapeng has joined #openstack-manila | 02:36 | |
*** akapil has joined #openstack-manila | 02:42 | |
*** akapil has quit IRC | 02:47 | |
*** gouthamr_ has quit IRC | 03:31 | |
*** bill_az has quit IRC | 03:46 | |
*** shausy has joined #openstack-manila | 03:57 | |
*** akapil has joined #openstack-manila | 04:57 | |
*** akapil has quit IRC | 05:01 | |
*** nkrinner_afk is now known as nkrinner | 05:17 | |
*** cknight has quit IRC | 05:28 | |
*** cknight has joined #openstack-manila | 05:31 | |
*** nidhimittalhada has joined #openstack-manila | 05:47 | |
nidhimittalhada | https://review.openstack.org/315012 https://review.openstack.org/348160 https://review.openstack.org/342104 Can someone please review this? @vponomaryov @gouthamr @markstur @bswartz @ganso | 05:48 |
*** nidhimittalhada has quit IRC | 05:57 | |
*** cknight has quit IRC | 06:03 | |
*** lpetrut has joined #openstack-manila | 06:06 | |
*** tovchinnikova has joined #openstack-manila | 06:21 | |
*** lpetrut has quit IRC | 07:26 | |
*** dsariel has joined #openstack-manila | 07:30 | |
*** lpetrut has joined #openstack-manila | 07:37 | |
openstackgerrit | Marc Koderer proposed openstack/manila: Add MTU information in DB and API https://review.openstack.org/349506 | 07:39 |
*** gaurangt has joined #openstack-manila | 07:45 | |
*** lpetrut has quit IRC | 07:46 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 08:05 |
*** MikeG451 has quit IRC | 08:17 | |
*** DuncanT has quit IRC | 08:19 | |
*** DuncanT has joined #openstack-manila | 08:20 | |
*** MikeG451 has joined #openstack-manila | 08:31 | |
*** lpetrut has joined #openstack-manila | 09:02 | |
*** tovchinnikova has quit IRC | 09:11 | |
*** jcsp has joined #openstack-manila | 10:07 | |
*** jcsp has quit IRC | 10:08 | |
*** jcsp has joined #openstack-manila | 10:08 | |
*** yangyapeng has quit IRC | 10:23 | |
openstackgerrit | Béla Vancsics proposed openstack/manila: Use more specific asserts in tests https://review.openstack.org/349926 | 10:35 |
*** timcl has joined #openstack-manila | 10:52 | |
*** tovchinnikova has joined #openstack-manila | 10:54 | |
vponomaryov | jseiler: case you described is use case, and you should just handle such input in your driver, and don't disable test as tpsilva suggests | 11:02 |
*** rraja has joined #openstack-manila | 11:07 | |
*** ganso has joined #openstack-manila | 11:19 | |
*** gaurangt has left #openstack-manila | 11:21 | |
*** yangyapeng has joined #openstack-manila | 11:26 | |
zhongjun_ | vponomaryov: hi, in https://review.openstack.org/#/c/348160/ | 11:40 |
vponomaryov | zhongjun_: hello | 11:41 |
zhongjun_ | vponomaryov: I saw you update share/snapshot size to 1 after manage share/snapshot fail | 11:41 |
vponomaryov | and? | 11:41 |
zhongjun_ | vponomaryov: but I have a confuse: the quota(shares, share_gigabytes) will not be changed when we manage share(test_A) fail. but the quota(shares, share_gigabytes) will be changed(-1) when we delete share(test_A) | 11:43 |
zhongjun_ | vponomaryov: Because we update share size to 1 after manage share(test_A) fail | 11:44 |
vponomaryov | zhongjun_: your statement "the quota(shares, share_gigabytes) will not be changed when we manage share(test_A) fail" is false | 11:46 |
zhongjun_ | vponomaryov: you means the shares quota value will be changed? | 11:48 |
zhongjun_ | vponomaryov: I test it, did I miss something? | 11:49 |
vponomaryov | zhongjun_: sorry, you are right, "manage_share" method just has a bug, it should update quota always - https://github.com/openstack/manila/blob/225bae39/manila/share/manager.py#L1548 | 11:49 |
jseiler | vponomaryov: Thank you. After I posted above, I realized IP Address '1.2.3.4/32' is really just a single IP Address. Our file system can handle that, I was just sending it down wrong. | 11:50 |
jseiler | vponomaryov: So it turns out, I do not need to disable a single test case. And thank you for clarifying that a single test case should not be disabled. | 11:51 |
zhongjun_ | vponomaryov: so, we need to update quota if the manage operation fail, or not update size to 1 and check the size type when we delete a share. | 11:55 |
vponomaryov | zhongjun_: update always | 11:56 |
jseiler | ganso: I was trying to run the scenario tests. My driver is reporting snapshot_support = False. In tempest.conf, I have run_snapshot_tests = False. The scenario tests fail. | 11:57 |
ganso | jseiler: which scenario tests are failing? | 12:00 |
ganso | vponomaryov: ping | 12:00 |
vponomaryov | ganso: ? | 12:00 |
jseiler | ganso: {0} manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsCIFS.test_mount_share_one_vm [41.133299s] ... FAILED | 12:00 |
jseiler | {1} manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsNFS.test_mount_share_one_vm [40.221991s] ... FAILED | 12:00 |
jseiler | {1} manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsNFS.test_read_write_two_vms [32.301221s] ... FAILED | 12:00 |
jseiler | {0} manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsCIFS.test_read_write_two_vms [32.682002s] ... FAILED | 12:00 |
ganso | vponomaryov: Hi Valeriy | 12:00 |
ganso | jseiler: these tests are not related to snapshots | 12:01 |
vponomaryov | ganso: Hello Rodrigo, just see this -> https://bugs.launchpad.net/manila/+bug/1608293 | 12:01 |
openstack | Launchpad bug 1608293 in Manila "tempest tests for migration do not check for snapshot support" [Undecided,New] | 12:01 |
jseiler | ganso: I checked the console messages, but then also checked the m-sch window | 12:01 |
vponomaryov | jseiler: you just verified existing bug ^ | 12:02 |
ganso | vponomaryov: I am aware of that problem, it is fixed in one of my patches, I was thinking yesterday about moving the fix to a separate, more urgent patch | 12:02 |
zhongjun_ | vponomaryov: update always, sounds like there are so many places need to change. | 12:02 |
jseiler | ganso: in the scheduler, I noticed the message ' Share type ext | 12:02 |
jseiler | ra spec requirement "snapshot_support=<is> True" does not match reported capability "False" ' | 12:02 |
ganso | jseiler: could you please paste the error in paste.openstack.org and post here? | 12:02 |
ganso | vponomaryov: it is a negative test that is related to the bug, not scenarios | 12:03 |
vponomaryov | ganso: fix of that bug should be separate | 12:03 |
vponomaryov | ganso: we have scenario tests with migration | 12:03 |
vponomaryov | zhongjun_: could be | 12:03 |
ganso | vponomaryov: yes, but there is a negative test that tries to create snapshot without checking if it is supported | 12:04 |
vponomaryov | ganso: then we have two places with this bug | 12:05 |
vponomaryov | ganso: scenario tests do not pay attention to that config option | 12:05 |
ganso | vponomaryov: this is why I want to see the logs. manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsNFS.test_mount_share_one_vm [40.221991s] ... FAILED is not related to migration at all | 12:05 |
zhongjun_ | vponomaryov: How about we not update the size to 1 when manage fail? because actually the size is zero. Is there another problem if we not update the share size to 1. | 12:06 |
vponomaryov | ganso: it is related to wrong share type | 12:06 |
ganso | vponomaryov: yes, I assume it uses the default type | 12:06 |
vponomaryov | ganso: scenario tests run only with snapshot_support=True now | 12:06 |
ganso | vponomaryov, jseiler the default type has to be changed in manila.conf to one that has snapshot_support = False | 12:07 |
ganso | jseiler: that might fix your problem | 12:07 |
ganso | vponomaryov: really? | 12:07 |
ganso | vponomaryov: why? | 12:07 |
vponomaryov | because bug | 12:07 |
vponomaryov | )) | 12:07 |
ganso | vponomaryov: lol | 12:07 |
vponomaryov | Sincerely your captain obvious | 12:07 |
ganso | vponomaryov: anyway, I pinged you to talk about something else | 12:08 |
vponomaryov | zhongjun_: every registered thing should be handles correctly | 12:08 |
*** alyson_ has joined #openstack-manila | 12:08 | |
vponomaryov | s/handles/handled/ | 12:08 |
jseiler | ganso: Thanks. Let me try that. | 12:08 |
ganso | vponomaryov: I believe our migration names discussion outcome will be implemented in https://review.openstack.org/#/c/328431/ | 12:08 |
vponomaryov | zhongjun_: it is developer problem how complex it is | 12:09 |
ganso | vponomaryov: not https://review.openstack.org/#/c/332267/ | 12:09 |
ganso | vponomaryov: so there is no need to block the fix because of this | 12:09 |
vponomaryov | ganso: "fix" ? ))) | 12:09 |
ganso | vponomaryov: the big fix | 12:10 |
vponomaryov | ganso: why there? | 12:10 |
vponomaryov | ganso: when it directly influences implementation of share migration support? | 12:11 |
ganso | vponomaryov: because existing names have been agreed in mitaka | 12:11 |
vponomaryov | ganso: ? | 12:11 |
ganso | vponomaryov: and the other patch "newton migration improvements" can change that and bump API microversion | 12:11 |
vponomaryov | ganso: ther eis no relation of API to the driver inerface | 12:11 |
vponomaryov | ganso: still don't see a reason for making there | 12:12 |
ganso | vponomaryov: so are you saying you prefer the API to have one name and interface a different one? | 12:12 |
vponomaryov | ganso: I am saying they are not related directly | 12:12 |
vponomaryov | ganso: and fix of driver interface does not require update of API | 12:13 |
ganso | vponomaryov: if we are going to have different names, then no | 12:13 |
ganso | vponomaryov: but I assume you also disagree with the API name | 12:13 |
vponomaryov | ganso: main concern you already saw - one more driver method is required | 12:14 |
ganso | vponomaryov: if it is confusing for a developer, it is most likely confusing to a user too | 12:14 |
ganso | vponomaryov: driver interfaces are reflecting API | 12:14 |
ganso | vponomaryov: reflecting exactly the way the API is | 12:14 |
vponomaryov | ganso: we have driver interfaces that are not tied to API at all | 12:15 |
ganso | vponomaryov: yes we do, my main concern is getting the name right | 12:15 |
vponomaryov | ganso: you started from "implement it separately" | 12:16 |
vponomaryov | ganso: not "lets name it finally" | 12:16 |
ganso | vponomaryov: are you suggesting merging the patches? | 12:16 |
vponomaryov | OO Which patches? | 12:17 |
openstackgerrit | Yingzhe Zeng proposed openstack/manila: Implement replication support in huawei driver https://review.openstack.org/331586 | 12:17 |
ganso | vponomaryov: https://review.openstack.org/#/c/328431/ and https://review.openstack.org/#/c/332267/ | 12:17 |
vponomaryov | ganso: you got it from my mesages? )) | 12:18 |
vponomaryov | s/mesages/messages/ | 12:18 |
vponomaryov | ganso: I am saying that https://review.openstack.org/#/c/332267/ should be updated for having one more driver interface | 12:19 |
vponomaryov | ganso: for addressing concern raised in dummy driver commit | 12:19 |
vponomaryov | that implements share migration support | 12:19 |
ganso | vponomaryov: you are aware that once that dummy driver patch merges, I will have to update the interface for https://review.openstack.org/#/c/328431/ , right? | 12:20 |
ganso | vponomaryov: there are new parameters introduced, and others have been renamed | 12:20 |
vponomaryov | ganso: is it a problem? | 12:20 |
ganso | vponomaryov: it is not | 12:20 |
ganso | vponomaryov: I will include the dummy driver update in https://review.openstack.org/#/c/328431/ | 12:21 |
vponomaryov | then how can I help you? | 12:21 |
ganso | vponomaryov: because it will make changes to code that existing driver will be using | 12:21 |
zhongjun_ | vponomaryov: I see. By the way, :D, Could you please review the snapshot instance python-manilaclient code https://review.openstack.org/#/c/304449/. The part of snapshot instance manila code has been merged, thanks. | 12:21 |
ganso | vponomaryov: you are suggesting a change that will change later again | 12:21 |
ganso | vponomaryov: I am suggesting changing only once, later | 12:22 |
vponomaryov | ganso: sooooo complicated | 12:22 |
ganso | vponomaryov: if dummy driver code is merged right now, I will update it within the later patch | 12:22 |
vponomaryov | ganso: it is not dummy driver problem | 12:22 |
jseiler | ganso: Before I get too deep, the driver I'm working on is for ocata (I don't want to take up too much of your time with newton deadlines looming) | 12:22 |
vponomaryov | ganso: it is interface problem | 12:23 |
vponomaryov | ganso: why are you going to change interface after it? | 12:23 |
jseiler | ganso: before I ran the api tests, I had deleted the default service-type, then created the service-type for my driver and named it default | 12:23 |
vponomaryov | jseiler: don't be afraid, you already late for that party ) | 12:23 |
vponomaryov | service type? | 12:23 |
jseiler | ganso: I had not noticed the default_share_type in manila.conf | 12:24 |
ganso | vponomaryov: current one we are discussing: https://review.openstack.org/#/c/332267/37/manila/share/driver.py | 12:24 |
ganso | vponomaryov: later change https://review.openstack.org/#/c/328431/24/manila/share/driver.py | 12:24 |
ganso | vponomaryov: I assumed you had taken a look at it | 12:25 |
jseiler | sorry type - as in type-create | 12:25 |
jseiler | sorry, still new to manila | 12:25 |
ganso | jseiler: humm so that approach did not solve your problem | 12:25 |
ganso | jseiler: as vponomaryov said, an existing bug causes scenario tests to depend on snapshot_support = True regardless of the defined share type or driver | 12:26 |
vponomaryov | ganso: your statement about change was looking like you are going to remove that additional driver interface | 12:26 |
ganso | vponomaryov: no, not remove, update | 12:26 |
jseiler | ganso: oh, sorry, missed that | 12:26 |
ganso | jseiler: np, still, I believed it was worth a shot, too bad it did not work | 12:26 |
jseiler | ganso: vponomaryov: That answers my question. I will not be able to run the scenario tests until I update my driver to support snapshots - right? | 12:27 |
vponomaryov | ganso: actually by default it creates share type without regards to that value | 12:27 |
ganso | jseiler: or bug is fixed | 12:27 |
vponomaryov | ganso: but if we set option "default_share_type_name" it will use user defined share type | 12:28 |
ganso | vponomaryov: oh so it can be worked around | 12:28 |
vponomaryov | jseiler: ^ | 12:28 |
ganso | vponomaryov: cool, I wasn't aware of this option for tempest | 12:28 |
vponomaryov | https://github.com/openstack/manila/blob/b06e111e/manila_tempest_tests/tests/scenario/test_share_basic_ops.py#L144 | 12:28 |
vponomaryov | yes, it can be worked around | 12:29 |
jseiler | default_share_type_name - is that in manila.conf or tempest.conf ? | 12:30 |
ganso | jseiler: tempest_conf | 12:30 |
ganso | jseiler: but you are going to use the same value as you use for manila.conf | 12:30 |
*** adrianofr has joined #openstack-manila | 12:30 | |
jseiler | ok | 12:30 |
ganso | jseiler: in your case, you must set it to 'default' | 12:30 |
ganso | jseiler: since you created your custom share type and renamed it to default | 12:31 |
vponomaryov | ganso: false | 12:31 |
ganso | vponomaryov: ? | 12:31 |
vponomaryov | ganso: scenario tests either create its own share type or you one you defined, it can be any you provide there | 12:31 |
vponomaryov | s/you one you/one you/ | 12:31 |
*** xyang1 has joined #openstack-manila | 12:31 | |
vponomaryov | ganso: no relation to "default" | 12:32 |
*** gouthamr has joined #openstack-manila | 12:32 | |
vponomaryov | ganso: I provided link to the logic - https://github.com/openstack/manila/blob/b06e111e/manila_tempest_tests/tests/scenario/test_share_basic_ops.py#L144 | 12:32 |
ganso | vponomaryov: yes, I looked at it | 12:32 |
ganso | vponomaryov: the code for the config option will use one defined in tempest.conf | 12:33 |
ganso | vponomaryov: instead of creating one, if it is defined | 12:33 |
vponomaryov | ganso: it means your statement "in your case, you must set it to 'default'" is false | 12:33 |
ganso | vponomaryov: "default_share_type_name = default" in tempest.conf | 12:34 |
vponomaryov | ganso: it should be "... set it to one you defined in config" | 12:34 |
vponomaryov | ganso: because default in manila is different | 12:34 |
ganso | vponomaryov: yes, in his case, it is "default_share_type = default" in manila.conf as well, it is the one he wants to use, he changed it to have snapshot_support=False | 12:35 |
*** aovchinnikov has joined #openstack-manila | 12:42 | |
vponomaryov | zhongjun_: added comment | 12:42 |
zhongjun_ | vponomaryov: Thanks | 12:43 |
vponomaryov | zhongjun_: + for such thing it is really better to add functional tests | 12:43 |
openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: Add Hitachi HSP driver https://review.openstack.org/329134 | 12:43 |
jseiler | ganso: vponomaryov: I set default_share_type_name in tempest.conf. That resolved the supports_snapshots issue. but now I'm getting a failure because it is trying to create a CIFS share. | 12:48 |
jseiler | ganso: vponomaryov: My driver is intially supporting only nfs. that is configured in manila.conf. Is there another place I need to config nfs support only? | 12:48 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix share migration test with snapshot support https://review.openstack.org/349982 | 12:49 |
ganso | vponomaryov: fix ^ | 12:50 |
jseiler | ganso: vponomaryov: My driver reports storage_protocol: 'NFS' | 12:51 |
vponomaryov | jseiler: https://github.com/openstack/manila/blob/master/manila_tempest_tests/config.py | 12:51 |
ganso | jseiler: have you set: 'capability_storage_protocol=NFS' ? | 12:52 |
vponomaryov | jseiler: all available options are there | 12:52 |
vponomaryov | jseiler: so, set "enable_protocols=nfs", "enable_ip_rules_for_protocols=nfs" and so on | 12:53 |
jseiler | ganso: Yes, I have capability_storage_protocol = NFS in tempest.conf | 12:53 |
ganso | jseiler: if that and vponomaryov's settings suggested don't fix your problem, then it is another bug | 12:54 |
*** tpsilva has joined #openstack-manila | 12:55 | |
gouthamr | mkoderer: ping | 12:57 |
*** liyifeng has quit IRC | 12:57 | |
*** tpsilva has quit IRC | 12:58 | |
*** tpsilva_ has joined #openstack-manila | 12:58 | |
*** tpsilva_ is now known as tpsilva | 12:59 | |
*** rraja has quit IRC | 12:59 | |
*** mtanino has joined #openstack-manila | 13:02 | |
mkoderer | gouthamr: hello sir | 13:03 |
gouthamr | mkoderer: Hey Marc.. :) I have a quick question regarding https://review.openstack.org/#/c/349506 | 13:03 |
mkoderer | gouthamr: yes ;) | 13:03 |
mkoderer | gouthamr: I am currently discussing it with out on-site netapp team | 13:04 |
gouthamr | mkoderer: okay, so we were trying to allow configuring the MTU in the driver section of manila.conf; | 13:04 |
mkoderer | s/out/our/ | 13:04 |
gouthamr | mkoderer: nice | 13:04 |
gouthamr | mkoderer: i see your change pulls the MTU value from neutron/nova-network instead; i think that's better since you'll avoid two different places to configure it.. | 13:04 |
mkoderer | gouthamr: but the information comes from the neutron net, no? | 13:04 |
*** faiz89 has joined #openstack-manila | 13:05 | |
gouthamr | mkoderer: yeah.. so, my question was wrt to changes to MTU.. | 13:05 |
gouthamr | mkoderer: do you think admins can change the MTU value in the neutron config and expect changes to applied to existing VLAN resources? | 13:06 |
mkoderer | gouthamr: I don't think that neturon supports changing the MTU | 13:07 |
gouthamr | mkoderer: http://docs.openstack.org/mitaka/networking-guide/adv-config-mtu.html | 13:07 |
gouthamr | mkoderer: yep.. "For existing deployments, MTU values only apply to new network resources."; | 13:07 |
mkoderer | gouthamr: yep. So I think it ok to store the initial value | 13:09 |
mkoderer | gouthamr: we have issue with such things also with other neturon net information - like the gateway can't be updated too | 13:09 |
gouthamr | mkoderer: so, in the cDOT driver, we create broadcast domains that span the neutron subnet.. | 13:10 |
ganso | vponomaryov: is there an existing decorator function to use for that? I haven't found it and am about to create one | 13:11 |
*** mkoderer_cloud has joined #openstack-manila | 13:11 | |
vponomaryov | ganso: sure | 13:12 |
ganso | vponomaryov: which is? | 13:12 |
*** rraja has joined #openstack-manila | 13:13 | |
vponomaryov | ganso: i.e. https://github.com/openstack/manila/blob/49695bde/manila_tempest_tests/tests/api/test_share_networks_negative.py#L61 | 13:13 |
vponomaryov | ganso: or "@testtools.skipUnless(..." | 13:14 |
ganso | vponomaryov: oh it is in testtools | 13:14 |
ganso | vponomaryov: thanks | 13:14 |
gouthamr | mkoderer: so, think of this scenario: MTU is configured to 5000, a share network is created and manila creates a share server (NetApp vServer).. and then the admin changes the config value to 4000 and so, if a share server is created on the same subnet, and then the administrator changes the configuration | 13:16 |
*** dustins has joined #openstack-manila | 13:16 | |
gouthamr | mkoderer: this doesn't affect the existing subnet? | 13:17 |
openstackgerrit | Alexey Khodos proposed openstack/manila: Nexenta: adding share drivers for NexentaStor https://review.openstack.org/309286 | 13:17 |
mkoderer | gouthamr: so far I understand it in neutron there is no relation between mtu and subnet | 13:19 |
mkoderer | gouthamr: we are currently planning some more test in that area | 13:20 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix share migration test with snapshot support https://review.openstack.org/349982 | 13:20 |
mkoderer | gouthamr: I think we need to be sure how neutron handles changes of mtu's in general | 13:20 |
*** yangyapeng has quit IRC | 13:21 | |
gouthamr | mkoderer: yes.. i'll dig into their code/documentation.. I saw net_info['MTU'], and thought they're storing the info in the database per network | 13:21 |
*** akerr has joined #openstack-manila | 13:24 | |
gouthamr | mkoderer: thanks! we can discuss this more offline. | 13:25 |
*** yangyapeng has joined #openstack-manila | 13:25 | |
*** akshai has joined #openstack-manila | 13:36 | |
openstackgerrit | Dustin Schoenbrun proposed openstack/manila: Check for usage of same Cephx ID as manila service https://review.openstack.org/349718 | 13:36 |
openstackgerrit | Tatiana Ovchinnikova proposed openstack/manila-ui: Remove unit tests warnings https://review.openstack.org/350011 | 13:37 |
*** porrua has joined #openstack-manila | 13:38 | |
*** vbellur has quit IRC | 13:38 | |
*** mtanino has quit IRC | 13:41 | |
*** merooney has joined #openstack-manila | 13:43 | |
ganso | gouthamr: ping | 13:51 |
gouthamr | ganso: hey Rodrigo.. | 13:51 |
ganso | gouthamr: hey Goutham | 13:51 |
*** shausy has quit IRC | 13:51 | |
ganso | gouthamr: I saw your comment | 13:51 |
ganso | gouthamr: the option I used derives from the one you suggested | 13:51 |
*** rraja has quit IRC | 13:52 | |
gouthamr | ganso: yep, but it's specifically used for the extra-spec.. | 13:52 |
gouthamr | ganso: i can't see/don't know why we have two config opts. | 13:53 |
ganso | gouthamr: yes... I never guessed there was one specific option for extra-spec... since they are related | 13:53 |
gouthamr | ganso: ...sigh, but the test skips always use run_snapshot_tests.. | 13:54 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix share migration test with snapshot support https://review.openstack.org/349982 | 13:54 |
*** JoseMello has joined #openstack-manila | 13:59 | |
*** vbellur has joined #openstack-manila | 14:00 | |
*** tovchinnikova has quit IRC | 14:01 | |
*** bill_az has joined #openstack-manila | 14:02 | |
*** aovchinnikov has quit IRC | 14:04 | |
*** eharney_ has joined #openstack-manila | 14:15 | |
openstackgerrit | zhongjun proposed openstack/python-manilaclient: Add snapshot instances admin APIs https://review.openstack.org/304449 | 14:21 |
*** timcl has quit IRC | 14:26 | |
openstackgerrit | zhongjun proposed openstack/manila: Implement share backup https://review.openstack.org/343980 | 14:29 |
*** alkhodos has joined #openstack-manila | 14:30 | |
*** rraja has joined #openstack-manila | 14:42 | |
*** eharney_ is now known as eharney | 14:44 | |
*** mtanino has joined #openstack-manila | 14:45 | |
*** timcl has joined #openstack-manila | 14:49 | |
*** cknight has joined #openstack-manila | 15:10 | |
*** nkrinner is now known as nkrinner_afk | 15:17 | |
*** mkoderer_cloud has quit IRC | 15:18 | |
*** kaisers_ has joined #openstack-manila | 15:19 | |
*** dustins has quit IRC | 15:23 | |
*** faiz89 has quit IRC | 15:31 | |
*** rraja has quit IRC | 15:39 | |
*** dustins has joined #openstack-manila | 15:39 | |
*** timcl has quit IRC | 15:40 | |
*** cknight has quit IRC | 15:41 | |
*** zhonghua-lee has quit IRC | 15:45 | |
vponomaryov | xyang1: ping | 15:51 |
xyang1 | vponomaryov: hi | 15:55 |
vponomaryov | xyang1: Hello =) | 15:55 |
vponomaryov | xyang1: wanted to ask you, have you seen answer in https://review.openstack.org/#/c/349575/2/manila/share/drivers/zfsonlinux/driver.py ? | 15:55 |
xyang1 | vponomaryov: looking | 15:56 |
vponomaryov | xyang1: we just will not reach case of NameError, because we will fail eirlier if list is empty | 15:57 |
vponomaryov | s/eirlier/earlier/ | 15:58 |
xyang1 | vponomaryov: maybe, it just looks wierd using the variable defined in the loop only | 15:58 |
vponomaryov | xyang1: why do you find it weird? | 15:58 |
xyang1 | vponomaryov: if you define it before entering the loop, that looks better | 15:59 |
vponomaryov | xyang1: how? | 15:59 |
vponomaryov | xyang1: it is one of python features | 15:59 |
vponomaryov | xyang1: no need to define redundant object links | 16:00 |
xyang1 | vponomaryov: I think it's best to check if it is None before using it | 16:00 |
vponomaryov | xyang1: snapshot_id just cannot be None | 16:01 |
vponomaryov | xyang1: for snapshot_instance | 16:01 |
xyang1 | vponomaryov: not snapshot_id, I mean replica_snapshot | 16:01 |
vponomaryov | xyang1: it cannot be None too )) | 16:02 |
vponomaryov | xyang1: because we would fail in loop | 16:02 |
xyang1 | vponomaryov: I'd like others to take a look as well | 16:02 |
vponomaryov | earlier | 16:02 |
vponomaryov | xyang1: as you wish | 16:05 |
xyang1 | vponomaryov: removed -1. let's see if others are ok with it | 16:05 |
*** faiz89 has joined #openstack-manila | 16:17 | |
*** krotscheck is now known as krot_sickleave | 16:27 | |
*** porrua has quit IRC | 16:27 | |
vponomaryov | ganso: ping | 16:30 |
*** JoseMello has quit IRC | 16:30 | |
*** rhagarty has joined #openstack-manila | 16:31 | |
*** timcl has joined #openstack-manila | 16:40 | |
ganso | vponomaryov: I gotta go now | 16:53 |
vponomaryov | ganso: :( | 16:53 |
bswartz | vponomaryov: I just had a chat with ganso | 16:53 |
bswartz | I think we will all be in agreement soon about the migration interfaces | 16:53 |
vponomaryov | I had different question | 16:54 |
bswartz | I'm going to write a ML post and put time on teh agenda for the thursday meeting | 16:54 |
ganso | vponomaryov: I may have time to answer while I am mobile | 16:54 |
bswartz | oh sorry for taking ganso's time then vponomaryov | 16:54 |
bswartz | :-( | 16:54 |
vponomaryov | ganso: have you tested that https://review.openstack.org/#/c/332267/37/manila/share/access.py really fixes bug https://bugs.launchpad.net/manila/+bug/1566815 ? | 16:54 |
openstack | Launchpad bug 1566815 in Manila "share manager fails to remove access rules on replicated share" [High,In progress] - Assigned to Rodrigo Barbieri (rodrigo-barbieri2010) | 16:54 |
vponomaryov | ganso: I suspect it does | 16:55 |
vponomaryov | ganso: and we should separate it too another commit | 16:55 |
vponomaryov | ganso: and get some statistics | 16:55 |
*** lpetrut has quit IRC | 16:55 | |
vponomaryov | ganso: with just one change, lock should be on general "update" method | 16:56 |
vponomaryov | ganso: not private one that is just part of "update" | 16:56 |
*** chlong has quit IRC | 16:58 | |
*** dsariel has quit IRC | 16:59 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [Tempest] Run tempest with the only plugin - manila's https://review.openstack.org/338371 | 17:03 |
*** porrua has joined #openstack-manila | 17:03 | |
*** chlong has joined #openstack-manila | 17:12 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [debug] do not merge https://review.openstack.org/350168 | 17:16 |
*** dustins has quit IRC | 17:23 | |
*** timcl has quit IRC | 17:25 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] bug 1566815 https://review.openstack.org/350174 | 17:28 |
openstack | bug 1566815 in Manila "share manager fails to remove access rules on replicated share" [High,In progress] https://launchpad.net/bugs/1566815 - Assigned to Rodrigo Barbieri (rodrigo-barbieri2010) | 17:28 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG2] bug 1566815 https://review.openstack.org/350175 | 17:28 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG3] bug 1566815 https://review.openstack.org/350176 | 17:29 |
*** dustins has joined #openstack-manila | 17:33 | |
*** jcsp has quit IRC | 17:42 | |
*** gouthamr has quit IRC | 17:42 | |
*** timcl has joined #openstack-manila | 17:43 | |
*** lpetrut has joined #openstack-manila | 17:51 | |
*** faiz89 has quit IRC | 18:00 | |
*** faiz89 has joined #openstack-manila | 18:01 | |
*** gouthamr has joined #openstack-manila | 18:02 | |
openstackgerrit | Tatiana Ovchinnikova proposed openstack/manila-ui: Fix unit tests https://review.openstack.org/350210 | 18:11 |
*** akerr is now known as akerr_away | 18:15 | |
*** akerr_away has quit IRC | 18:15 | |
*** akerr has joined #openstack-manila | 18:15 | |
*** Suyi_ has joined #openstack-manila | 18:39 | |
*** lpetrut has quit IRC | 18:41 | |
*** abhi has joined #openstack-manila | 18:51 | |
*** lpetrut has joined #openstack-manila | 19:03 | |
*** kaisers_ has quit IRC | 19:07 | |
*** timcl has quit IRC | 19:22 | |
*** timcl has joined #openstack-manila | 19:24 | |
*** alkhodos has quit IRC | 19:51 | |
*** ganso has quit IRC | 19:51 | |
*** porrua has quit IRC | 20:18 | |
*** lpetrut has quit IRC | 20:21 | |
*** akerr has quit IRC | 20:34 | |
*** openstackgerrit_ has joined #openstack-manila | 20:35 | |
*** openstackgerrit_ has quit IRC | 20:36 | |
*** rhagarty has quit IRC | 20:38 | |
*** kaisers_ has joined #openstack-manila | 20:56 | |
*** timcl has quit IRC | 20:57 | |
*** kaisers_ has quit IRC | 21:01 | |
*** akshai has quit IRC | 21:02 | |
*** akshai has joined #openstack-manila | 21:09 | |
*** akshai has quit IRC | 21:10 | |
*** vbellur has quit IRC | 21:11 | |
*** vbellur has joined #openstack-manila | 21:44 | |
*** porrua has joined #openstack-manila | 21:51 | |
*** porrua_ has joined #openstack-manila | 21:54 | |
*** porrua has quit IRC | 21:57 | |
*** faiz89 has quit IRC | 22:02 | |
*** alyson_ has quit IRC | 22:03 | |
*** porrua_ has quit IRC | 22:04 | |
*** vbellur has quit IRC | 22:04 | |
*** dustins has quit IRC | 22:07 | |
*** faiz89 has joined #openstack-manila | 22:14 | |
*** lpetrut has joined #openstack-manila | 22:22 | |
*** faiz89 has quit IRC | 22:25 | |
*** eharney has quit IRC | 22:30 | |
*** lpetrut has quit IRC | 22:31 | |
*** kaisers_ has joined #openstack-manila | 22:45 | |
*** akerr has joined #openstack-manila | 22:47 | |
*** akerr_ has joined #openstack-manila | 22:48 | |
*** kaisers_ has quit IRC | 22:50 | |
*** david-lyle has quit IRC | 22:50 | |
*** david-lyle has joined #openstack-manila | 22:51 | |
*** akerr has quit IRC | 22:52 | |
*** tpsilva has quit IRC | 22:58 | |
*** merooney has quit IRC | 23:04 | |
*** gouthamr has quit IRC | 23:09 | |
*** xyang1 has quit IRC | 23:29 | |
*** liyifeng has joined #openstack-manila | 23:34 | |
*** bill_az has quit IRC | 23:44 | |
openstackgerrit | Mark Sturdevant proposed openstack/manila: HPE3PAR make share from snapshot writable https://review.openstack.org/337926 | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!