| *** akapil has quit IRC | 00:00 | |
| *** akapil has joined #openstack-manila | 00:00 | |
| *** yangyape_ has quit IRC | 00:00 | |
| *** akapil has quit IRC | 00:00 | |
| *** Suyi_ has quit IRC | 00:07 | |
| openstackgerrit | Mark Sturdevant proposed openstack/manila: HPE3PAR make share from snapshot writable https://review.openstack.org/337926 | 00:13 |
|---|---|---|
| *** timcl has joined #openstack-manila | 00:48 | |
| *** timcl1 has joined #openstack-manila | 00:50 | |
| *** timcl has quit IRC | 00:52 | |
| *** timcl1 has quit IRC | 01:06 | |
| *** yangyapeng has joined #openstack-manila | 01:17 | |
| *** yangyapeng has quit IRC | 01:17 | |
| *** yangyapeng has joined #openstack-manila | 01:18 | |
| *** vbellur has joined #openstack-manila | 01:31 | |
| *** faiz89 has joined #openstack-manila | 01:32 | |
| *** faiz89 has quit IRC | 01:33 | |
| *** faiz89 has joined #openstack-manila | 01:33 | |
| openstackgerrit | zhongjun proposed openstack/manila: Add snapshot instances admin APIs https://review.openstack.org/234658 | 01:37 |
| *** faiz891 has joined #openstack-manila | 01:40 | |
| *** faiz89 has quit IRC | 01:42 | |
| *** faiz891 has quit IRC | 01:44 | |
| *** faiz89 has joined #openstack-manila | 01:44 | |
| *** faiz891 has joined #openstack-manila | 01:46 | |
| *** faiz89 has quit IRC | 01:48 | |
| *** faiz89 has joined #openstack-manila | 01:50 | |
| *** faiz891 has quit IRC | 01:50 | |
| *** faiz891 has joined #openstack-manila | 01:54 | |
| *** faiz892 has joined #openstack-manila | 01:57 | |
| *** faiz89 has quit IRC | 01:57 | |
| *** yangyape_ has joined #openstack-manila | 01:58 | |
| *** faiz89 has joined #openstack-manila | 01:59 | |
| *** faiz891 has quit IRC | 01:59 | |
| *** faiz892 has quit IRC | 02:01 | |
| *** yangyapeng has quit IRC | 02:02 | |
| *** yangyapeng has joined #openstack-manila | 02:19 | |
| *** yangyape_ has quit IRC | 02:22 | |
| *** yangyape_ has joined #openstack-manila | 02:23 | |
| *** yangyapeng has quit IRC | 02:26 | |
| *** faiz89 has quit IRC | 02:29 | |
| *** lpetrut has joined #openstack-manila | 02:36 | |
| *** lpetrut has quit IRC | 02:40 | |
| *** yangyape_ has quit IRC | 02:42 | |
| *** yangyapeng has joined #openstack-manila | 02:42 | |
| *** gouthamr_ has quit IRC | 02:51 | |
| *** yangyape_ has joined #openstack-manila | 03:11 | |
| *** yangyapeng has quit IRC | 03:11 | |
| *** faiz89 has joined #openstack-manila | 03:16 | |
| openstackgerrit | zhongjun proposed openstack/manila: Add snapshot instances admin APIs https://review.openstack.org/234658 | 03:21 |
| *** yangyapeng has joined #openstack-manila | 03:23 | |
| *** yangyapeng has quit IRC | 03:23 | |
| *** yangyape_ has quit IRC | 03:23 | |
| *** bill_az has quit IRC | 03:26 | |
| *** yangyapeng has joined #openstack-manila | 03:27 | |
| *** faiz891 has joined #openstack-manila | 03:28 | |
| openstackgerrit | Cedric Zhuang proposed openstack/manila: Add EMC Unity Driver for Manila https://review.openstack.org/312423 | 03:29 |
| *** faiz89 has quit IRC | 03:29 | |
| *** yangyape_ has joined #openstack-manila | 03:47 | |
| *** yangyape_ has quit IRC | 03:47 | |
| *** yangyape_ has joined #openstack-manila | 03:48 | |
| *** yangyapeng has quit IRC | 03:48 | |
| *** faiz89 has joined #openstack-manila | 03:51 | |
| *** faiz891 has quit IRC | 03:54 | |
| *** faiz891 has joined #openstack-manila | 04:04 | |
| *** faiz89 has quit IRC | 04:05 | |
| *** faiz892 has joined #openstack-manila | 04:10 | |
| *** faiz891 has quit IRC | 04:13 | |
| *** faiz892 has quit IRC | 04:46 | |
| *** amitkqed has quit IRC | 05:19 | |
| *** amitkqed has joined #openstack-manila | 05:20 | |
| *** sjjfowler has quit IRC | 05:20 | |
| *** shausy has joined #openstack-manila | 05:31 | |
| *** sjjfowler has joined #openstack-manila | 05:38 | |
| *** nidhimittalhada has joined #openstack-manila | 05:58 | |
| nidhimittalhada | @vponomaryov @ganso @gouthamr Can you please review https://review.openstack.org/315012 | 05:59 |
| nidhimittalhada | https://review.openstack.org/342104 @vponomaryov @ganso @gouthamr @bswartz Spec for review please. | 06:00 |
| *** gouthamr has joined #openstack-manila | 06:01 | |
| *** nkrinner_afk is now known as nkrinner | 06:03 | |
| *** gouthamr has quit IRC | 06:10 | |
| openstackgerrit | Cedric Zhuang proposed openstack/manila: Add EMC Unity Driver for Manila https://review.openstack.org/312423 | 06:15 |
| *** shausy has quit IRC | 06:20 | |
| kaisers | gouthamr: Hi! Guess you meant an additional line break? will add (https://review.openstack.org/#/c/345219/9..10/manila/share/drivers/quobyte/jsonrpc.py) | 06:26 |
| openstackgerrit | Silvan Kaiser proposed openstack/manila: Replaces httplib with requests lib in Quobyte RPC layer https://review.openstack.org/345219 | 06:27 |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 06:36 |
| *** sticker_ has joined #openstack-manila | 06:41 | |
| openstackgerrit | Merged openstack/python-manilaclient: Replace OpenStack LLC with OpenStack Foundation https://review.openstack.org/347285 | 06:41 |
| *** sticker has quit IRC | 06:44 | |
| *** sandanar has joined #openstack-manila | 06:44 | |
| *** pcaruana has joined #openstack-manila | 06:45 | |
| *** sticker_ is now known as sticker | 06:49 | |
| nidhimittalhada | hi i wanted to run a single unit test in manila, i gave this command sudo tox -e py27 -- manila/tests/share/test_api.py:ShareAPITestCase.test_delete_size_none still its running all the test cases ..!! | 06:58 |
| nidhimittalhada | is there anything wrong in this? | 06:58 |
| *** nherciu has joined #openstack-manila | 07:10 | |
| *** sticker has quit IRC | 07:12 | |
| openstackgerrit | NidhiMittalHada proposed openstack/manila: Unary operator used with NoneType https://review.openstack.org/348160 | 07:36 |
| *** kaisers has quit IRC | 07:50 | |
| *** kaisers has joined #openstack-manila | 07:51 | |
| *** yangyapeng has joined #openstack-manila | 07:57 | |
| *** yangyap__ has joined #openstack-manila | 07:58 | |
| *** yangyape_ has quit IRC | 08:00 | |
| *** yangyapeng has quit IRC | 08:01 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 08:01 |
| vponomaryov | nidhimittalhada: use "tox -e py27 -- --path foo.bar" | 08:29 |
| vponomaryov | nidhimittalhada: such incompatibility was introduced with usage of another test runner | 08:29 |
| nidhimittalhada | @vponomaryov sudo tox -e py27 -- -r manila.tests.share.test_api.ShareAPITestCase.test_delete_size_none this also worked | 08:30 |
| *** shausy has joined #openstack-manila | 08:45 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests tests for Container driver https://review.openstack.org/347137 | 08:54 |
| *** nidhimittalhada has quit IRC | 09:08 | |
| openstackgerrit | Accela Zhao proposed openstack/manila: Driver private storage admin API https://review.openstack.org/315346 | 09:19 |
| *** yangyapeng has joined #openstack-manila | 09:24 | |
| *** ociuhandu has quit IRC | 09:25 | |
| *** yangyap__ has quit IRC | 09:26 | |
| *** permalac has joined #openstack-manila | 09:33 | |
| *** yangyapeng has quit IRC | 09:38 | |
| *** yangyapeng has joined #openstack-manila | 09:38 | |
| *** rraja has joined #openstack-manila | 09:39 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Add share replication support https://review.openstack.org/226389 | 09:52 |
| *** ociuhandu has joined #openstack-manila | 09:59 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix race condition in tempest test https://review.openstack.org/348829 | 10:21 |
| *** yangyapeng has quit IRC | 10:23 | |
| *** akapil has joined #openstack-manila | 10:49 | |
| *** akapil has quit IRC | 10:50 | |
| *** akapil has joined #openstack-manila | 10:50 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 11:01 |
| *** yangyapeng has joined #openstack-manila | 11:31 | |
| *** dsariel has joined #openstack-manila | 11:45 | |
| *** liyifeng has quit IRC | 11:55 | |
| *** liyifeng has joined #openstack-manila | 12:08 | |
| *** dsariel has quit IRC | 12:31 | |
| *** xyang1 has joined #openstack-manila | 12:36 | |
| vponomaryov | ganso: ping | 12:38 |
| vponomaryov | ganso: about https://review.openstack.org/#/c/347853/6/manila/tests/share/drivers/dummy.py | 12:39 |
| openstackgerrit | Merged openstack/manila-ui: Updated from global requirements https://review.openstack.org/348636 | 12:39 |
| ganso | vponomaryov: hi Valeriy | 12:40 |
| vponomaryov | ganso: Hello Rodrigo | 12:40 |
| vponomaryov | ganso: can you please answer first question there? | 12:40 |
| vponomaryov | Method called "migration_start" can finish migration? | 12:41 |
| ganso | vponomaryov: yes, if notify=True... (notify will be renamed to complete in next patch, once your patch merges I will update it along with mine) | 12:41 |
| *** tpsilva has joined #openstack-manila | 12:42 | |
| vponomaryov | ganso: so, and you disagree that "migration_start" name for method that finishes something is confusing? | 12:42 |
| ganso | vponomaryov: yes | 12:43 |
| vponomaryov | nice | 12:43 |
| vponomaryov | ganso: how many people provided you feedback on these method names? | 12:43 |
| ganso | vponomaryov: not many | 12:43 |
| vponomaryov | ganso; names? | 12:44 |
| vponomaryov | how many of them did use these interfaces? | 12:44 |
| ganso | vponomaryov: people at midcycle, and my local team | 12:44 |
| ganso | vponomaryov: nobody used | 12:44 |
| *** alyson_ has joined #openstack-manila | 12:44 | |
| ganso | vponomaryov: you are the first that used | 12:44 |
| ganso | vponomaryov: your opinion is valid, I appreciate it | 12:44 |
| ganso | vponomaryov: I just don't agree with the solution you proposed | 12:45 |
| ganso | vponomaryov: which is creating 2 similar interfaces | 12:45 |
| vponomaryov | ganso: which is? | 12:45 |
| ganso | vponomaryov: maybe a better name for migration-start could make more sense | 12:45 |
| ganso | vponomaryov: instead of splitting | 12:45 |
| vponomaryov | ganso: the fact that you require condition in that method says you lost one more method | 12:45 |
| ganso | vponomaryov: that would be a workaround only for the dummy driver | 12:46 |
| ganso | vponomaryov: because it is too fast | 12:46 |
| vponomaryov | it is interface | 12:46 |
| vponomaryov | I am talking about interace | 12:46 |
| vponomaryov | s/interace/interface/ | 12:46 |
| ganso | vponomaryov: oh nevermind, I read "the fact that you require race condition" | 12:47 |
| ganso | vponomaryov: disregard my comment above | 12:47 |
| *** timcl has joined #openstack-manila | 12:48 | |
| ganso | vponomaryov: sorry I did not understand your statement "...method says you lost one more method" | 12:48 |
| vponomaryov | ganso: I meant that design lacks of one more method | 12:49 |
| vponomaryov | presence of this lost method would remove naming confusion and will allow you to just drop that "notify" argument | 12:49 |
| ganso | vponomaryov: what would this interface be called? | 12:50 |
| vponomaryov | lots of possible names come into my mind, main criterion - i tis related to one-phase approach | 12:51 |
| ganso | vponomaryov: I agree the name of migration-start could be improved to be made more clear, so either new name or new names for split methods should be better than current approach | 12:52 |
| *** liyifeng has quit IRC | 12:52 | |
| *** bill_az has joined #openstack-manila | 12:52 | |
| vponomaryov | i.e: migrate_share_1_phase, migrate_share_2_phase_start, migrate_share_2_phase_complete, migrate_share_2_phase_cancel | 12:52 |
| vponomaryov | very clear | 12:53 |
| vponomaryov | no conditioned arguments | 12:53 |
| vponomaryov | clear relation | 12:53 |
| ganso | vponomaryov: I believe it should follow the "migration-" standard | 12:55 |
| ganso | vponomaryov: cancel and get_progress work for both phases | 12:55 |
| vponomaryov | em, it is not verb | 12:55 |
| vponomaryov | proposed names say what to do and how | 12:56 |
| ganso | vponomaryov: start is a verb | 12:56 |
| vponomaryov | ganso: why you believe it should start with "noun"? | 12:57 |
| *** faiz89 has joined #openstack-manila | 12:59 | |
| *** jcsp has joined #openstack-manila | 13:03 | |
| openstackgerrit | Marc Koderer proposed openstack/python-manilaclient: Add validation for token and bypass_url https://review.openstack.org/346680 | 13:04 |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests https://review.openstack.org/340236 | 13:07 |
| ganso | vponomaryov: I liked what we decided in mitaka that all migration methods start with "migration-"... although this is not true for replication | 13:07 |
| ganso | vponomaryov: I am not againsting to changing all back to "migrate share, get_migration_progress, cancel_migration," etc | 13:08 |
| ganso | vponomaryov: *against | 13:08 |
| ganso | vponomaryov: if we could stick to "migration-" it would be better | 13:08 |
| vponomaryov | ganso: ok, are you going to add one more driver interface for 1phase only? | 13:08 |
| ganso | vponomaryov: maybe, depends on naming | 13:09 |
| vponomaryov | I am ok for any clear naming )) | 13:10 |
| ganso | vponomaryov: since bswartz is a reviewer of migration patches, I think he could weigh in | 13:10 |
| vponomaryov | no "false= true ; true = false" )) | 13:10 |
| ganso | vponomaryov: Goutham as well | 13:10 |
| ganso | vponomaryov: lol wat | 13:11 |
| ganso | vponomaryov: :P | 13:11 |
| vponomaryov | ganso: type in python following: "False = True; assert False is True" | 13:12 |
| vponomaryov | ganso: so, your interface approach is kind of this for me )) | 13:12 |
| ganso | vponomaryov: ¬_¬ | 13:13 |
| ganso | vponomaryov: btw, access rules fix for zfs driver | 13:13 |
| ganso | vponomaryov: for 5 runs in a row, that tempest test has not failed | 13:13 |
| ganso | vponomaryov: but other have failed | 13:13 |
| ganso | vponomaryov: you can check the whole migration tree | 13:13 |
| vponomaryov | ganso: ZFSonLinux driver has one more bug - https://bugs.launchpad.net/manila/+bug/1607765 | 13:14 |
| openstack | Launchpad bug 1607765 in Manila "ZFSonLinux driver fails on snapshot deletion" [High,New] | 13:14 |
| ganso | vponomaryov: not sure if the other failures are a consequence or not, they seem very random, because they are not failing consistently in every run | 13:14 |
| ganso | vponomaryov: http://logs.openstack.org/36/295836/20/check/gate-manila-tempest-dsvm-postgres-zfsonlinux/d019940/console.html | 13:14 |
| ganso | vponomaryov: many other failures beside that one | 13:14 |
| ganso | vponomaryov: so driver looks very unstable | 13:15 |
| ganso | vponomaryov: it may not be the driver code per se... but it is not handling well tempest tests | 13:15 |
| *** timcl has quit IRC | 13:15 | |
| vponomaryov | ganso: your example caused exactly by bug I mentioned | 13:17 |
| vponomaryov | ganso: all errors you see appear only because of first failure | 13:17 |
| ganso | vponomaryov: including manila_tempest_tests.tests.api.test_rules.ShareIpRulesForNFSTest.test_create_delete_ro_access_rule_2_2_9 ? | 13:17 |
| *** gouthamr has joined #openstack-manila | 13:18 | |
| vponomaryov | ganso: second is existing bug | 13:18 |
| vponomaryov | ganso; so, it is 2in1 | 13:18 |
| vponomaryov | ganso; butit is still two bugs - one new and one old | 13:19 |
| vponomaryov | ganso: both concurrency-based | 13:19 |
| vponomaryov | ganso: old one not-driver related, this driver just discovers problem in manager | 13:19 |
| ganso | vponomaryov: oic, do you think it can be fixed in the driver? | 13:19 |
| vponomaryov | ganso: second, new is only-driver related | 13:19 |
| ganso | vponomaryov: ok, so it can be partially fixed in driver | 13:20 |
| *** merooney has joined #openstack-manila | 13:21 | |
| tpsilva | gouthamr: ping | 13:22 |
| gouthamr | tpsilva: pong | 13:22 |
| tpsilva | gouthamr: Hi Goutham! good morning | 13:22 |
| tpsilva | gouthamr: two questions, a quick one and a more complex, I guess :) | 13:23 |
| gouthamr | tpsilva: Hey Tiago! good morning. Wassup | 13:23 |
| gouthamr | tpsilva: shoot :) | 13:23 |
| tpsilva | gouthamr: https://review.openstack.org/#/c/345526/5/manila/api/v2/share_snapshots.py@166 | 13:23 |
| tpsilva | gouthamr: So, it should be a snapshot access view builder or can I include these snapshot access methods on the snapshot view? | 13:24 |
| gouthamr | tpsilva | 13:24 |
| tpsilva | gouthamr: because I cannot use two views on a single controller, right? | 13:24 |
| gouthamr | tpsilva: snapshot view should be sufficient | 13:24 |
| tpsilva | gouthamr: alright, I was afraid it could be conceptually wrong or something, but ok, I implemented it that way | 13:25 |
| *** jcsp has quit IRC | 13:25 | |
| tpsilva | gouthamr: now the complex one, regarding the replicas | 13:25 |
| gouthamr | tpsilva: we're not using a viewbuilder for share access, but maybe when we add that, we can dedupe this. | 13:25 |
| *** porrua has joined #openstack-manila | 13:25 | |
| tpsilva | gouthamr: yep, then we can add a separate controller for that | 13:25 |
| *** jcsp has joined #openstack-manila | 13:25 | |
| tpsilva | gouthamr: anyway, https://review.openstack.org/#/c/345526/5/manila/share/api.py@1494 | 13:25 |
| tpsilva | gouthamr: how should I handle it? | 13:26 |
| tpsilva | gouthamr: I think I need to study how the snapshots replica work to implement this correctly | 13:26 |
| gouthamr | tpsilva: yes, slightly tricky | 13:26 |
| gouthamr | tpsilva: when you guys implemented update_access, i added a docstring suggesting that drivers should check whether the instance being updated is a replica, and act accordingly.. because, in case of 'dr' style of replication, no access rules will make sense.. the drivers are not expected to create an export location for those (secondary) replicas. | 13:28 |
| gouthamr | tpsilva: maybe you can still mount snapshots from secondary replicas in case of 'readable'. vponomaryov: can we? | 13:29 |
| gouthamr | tpsilva: so i would just leave it to the driver implementer. I would not branch on the snapshot instance in the API though.. | 13:30 |
| tpsilva | gouthamr: what do you mean by branch on the instance? that iteration over the instances? | 13:31 |
| gouthamr | tpsilva: wait, i take that back. you have to send rpc calls to the specific host.. | 13:31 |
| tpsilva | gouthamr: yep | 13:31 |
| gouthamr | tpsilva: self.driver.snapshot_allow_access(context, snapshot_instance, access, share_server) | 13:32 |
| gouthamr | tpsilva: the snapshot doesn't have a field indicating that it is a replica.. | 13:32 |
| gouthamr | tpsilva: would you be able to pass the share (share instance pertaining to that snapshot instance, with share data) as well ? | 13:33 |
| tpsilva | gouthamr: but the share instance has, doesn't it? | 13:33 |
| ganso | gouthamr: shouldn't it include the share model in snapshot['share'] ? | 13:33 |
| *** akerr has joined #openstack-manila | 13:33 | |
| gouthamr | ganso: oh. probably true.. lemme check | 13:34 |
| tpsilva | gouthamr: snapshot['share_instance'] should do the trick, right? | 13:34 |
| tpsilva | gouthamr: you can access that from the driver | 13:34 |
| tpsilva | gouthamr: I think one of our (hds) drivers does that | 13:34 |
| *** nkrinner is now known as nkrinner_afk | 13:41 | |
| *** catintheroof has quit IRC | 13:42 | |
| *** dustins has joined #openstack-manila | 13:45 | |
| *** xyang_ has joined #openstack-manila | 13:45 | |
| openstackgerrit | Daniel Gonzalez Nothnagel proposed openstack/manila: Add binding_profile option for backends https://review.openstack.org/284034 | 13:48 |
| openstackgerrit | Daniel Gonzalez Nothnagel proposed openstack/manila: Add multi-segment support https://review.openstack.org/277731 | 13:48 |
| openstackgerrit | Daniel Gonzalez Nothnagel proposed openstack/manila: Add neutron driver for binding https://review.openstack.org/283494 | 13:48 |
| *** akshai has joined #openstack-manila | 13:50 | |
| *** vbellur has quit IRC | 13:57 | |
| *** faiz89 has quit IRC | 13:59 | |
| *** faiz89 has joined #openstack-manila | 14:03 | |
| bswartz | vponomaryov: paste.openstack.org is down | 14:05 |
| bswartz | I can't follow the link in that bug | 14:05 |
| vponomaryov | bswaartz: there is the same as you see in "raw" variant | 14:05 |
| vponomaryov | bswartz; or in "logs" part | 14:05 |
| vponomaryov | it is 3 ways of whowing the same | 14:06 |
| vponomaryov | s/whowing/showing/ | 14:06 |
| *** akshai has quit IRC | 14:06 | |
| *** akshai has joined #openstack-manila | 14:07 | |
| gouthamr | tpsilva: good stuff. sorry for the latency; got pulled into an offline meeting. | 14:11 |
| gouthamr | tpsilva: we should add stuff to the docstring saying that drivers are expected to make the decision appropriately when asked to apply an access rule to a snapshot on/from the secondary replica | 14:12 |
| openstackgerrit | Alyson proposed openstack/manila: Add support for CIFS shares in HNAS driver https://review.openstack.org/342960 | 14:17 |
| gouthamr | bswartz: could you please review a CI-Fix/backport https://review.openstack.org/#/c/347429/ | 14:19 |
| gouthamr | bswartz: jenkins runs bashate in the pep8 job, but warnings are ignored: http://logs.openstack.org/86/343386/2/check/gate-manila-pep8/8978910/console.html.gz | 14:22 |
| *** dustins has quit IRC | 14:28 | |
| *** dustins has joined #openstack-manila | 14:40 | |
| *** shausy has quit IRC | 14:40 | |
| *** dsariel has joined #openstack-manila | 14:40 | |
| *** david-lyle has joined #openstack-manila | 14:42 | |
| *** david-lyle has quit IRC | 14:47 | |
| tpsilva | gouthamr: okay, that ended up being quite simple then... I'll add that info. Thank you! | 14:53 |
| gouthamr | tpsilva: you're welcome. | 14:54 |
| openstackgerrit | Clinton Knight proposed openstack/manila: NetApp cDOT vserver deletion fails if no lifs present https://review.openstack.org/348912 | 14:57 |
| *** rraja has quit IRC | 15:10 | |
| *** akapil has quit IRC | 15:16 | |
| zhongjun_ | ganso: ping | 15:16 |
| *** david-lyle has joined #openstack-manila | 15:23 | |
| ganso | zhongjun_: pong | 15:25 |
| zhongjun_ | ganso: in https://review.openstack.org/#/c/234658/ | 15:26 |
| zhongjun_ | ganso: please see my response | 15:27 |
| ganso | zhongjun_: there are several places that don't need updating | 15:36 |
| ganso | zhongjun_: I did a quick grep | 15:36 |
| ganso | zhongjun_: most tests don't query the snapshot after create_snapshot_wait_for_active | 15:36 |
| *** Dinesh_Bhor has quit IRC | 15:37 | |
| ganso | zhongjun_: maybe if you just add the query in create_snapshot_wait_for_active like I suggested without updating other methods it will not break anything, other methods that are using will just be querying twice then | 15:37 |
| gouthamr | ganso: please see my response.. i guess vponomaryov intended that behavior; and it has thus far been a pattern that we're following with all create APIs | 15:37 |
| gouthamr | ganso: we need the response of the PIST API.. | 15:38 |
| gouthamr | s/PIST/POST | 15:38 |
| gouthamr | ganso: see create_share, create_replica, etc.. we have waiters in these methods as well. | 15:39 |
| ganso | gouthamr: why do you need to validate the response of a GET in the setup method? | 15:39 |
| ganso | gouthamr: indeed, the waiters are staying | 15:40 |
| gouthamr | ganso: we create a resource and we wait for it to be in a given state.. | 15:40 |
| ganso | gouthamr: my suggestion is to perform an additional GET at the end of the waiter | 15:40 |
| ganso | gouthamr: before the waiter returning with the available replica... in order to include the provider location | 15:40 |
| gouthamr | ganso: yes, but how do you validate the create API? | 15:41 |
| gouthamr | ganso: i mean, the response keys and values | 15:41 |
| ganso | gouthamr: the same way the waiter is doing... the waiter is validating it | 15:41 |
| ganso | gouthamr: let me double check the method | 15:41 |
| gouthamr | ganso: the waiter is not validating any fields apart from the fields that we tell it to look for the status | 15:42 |
| gouthamr | ganso: ex: task_state, replica_state, status, state | 15:42 |
| vponomaryov | ganso: gouthamr is right | 15:42 |
| ganso | I find it very unusual for the snapshot instance to be available and not have the provider location | 15:43 |
| ganso | maybe we can find a better way to address this instead of in tempest test | 15:43 |
| vponomaryov | ganso: setup method is not a test | 15:44 |
| *** bill_az has quit IRC | 15:44 | |
| zhongjun_ | ganso: as the gouthamr said, separate create and get, it will be more clear for developer. | 15:44 |
| ganso | vponomaryov: indeed, and it is not supposed to be, I am not suggesting performing a validation | 15:44 |
| vponomaryov | ganso: moreover, even if fix it, it should be out of this commit | 15:44 |
| gouthamr | +1 | 15:44 |
| ganso | alright | 15:45 |
| ganso | separate commit then | 15:45 |
| gouthamr | ganso: thanks.. i do agree it sounds confusing, but i thought i wasn't used to it.. maybe we need a better name :) | 15:45 |
| vponomaryov | "if" | 15:45 |
| vponomaryov | )) | 15:45 |
| zhongjun_ | ganso: thanks | 15:46 |
| ganso | vponomaryov: do you think current behavior is ideal? create snaphot instance and not have the provider location? | 15:46 |
| vponomaryov | ganso: in programming nothing is ideal | 15:46 |
| vponomaryov | ganso: what about migration? =) | 15:47 |
| vponomaryov | ganso: and our battle | 15:48 |
| vponomaryov | )) | 15:48 |
| vponomaryov | have you found support? | 15:48 |
| *** faiz89 has quit IRC | 15:48 | |
| *** faiz89 has joined #openstack-manila | 15:49 | |
| * gouthamr battles.. popcorn | 15:49 | |
| vponomaryov | gouthamr: you can participate, just jump in here https://review.openstack.org/#/c/347853/6/manila/tests/share/drivers/dummy.py | 15:49 |
| ganso | vponomaryov: don't run from current battle :P | 15:50 |
| ganso | vponomaryov: about migration, I am waiting on bswartz and gouthamr's input | 15:50 |
| *** Suyi_ has joined #openstack-manila | 15:50 | |
| ganso | vponomaryov: as I said before | 15:50 |
| gouthamr | ganso: top priority review on my backlog.. right alongside replication UI :) | 15:51 |
| *** faiz89 has quit IRC | 15:59 | |
| *** pcaruana has quit IRC | 16:01 | |
| *** dsariel has quit IRC | 16:02 | |
| vponomaryov | ganso: https://review.openstack.org/#/c/348829/ ? | 16:03 |
| ganso | vponomaryov: yes? | 16:04 |
| vponomaryov | ganso: nothing to do with your -1 there | 16:04 |
| ganso | vponomaryov: well, since your bugfix is about race conditions, you could use the patch to fix that one too | 16:04 |
| vponomaryov | ganso: ? | 16:08 |
| ganso | vponomaryov: manila_tempest_tests.tests.api.admin.test_share_servers.ShareServersAdminTest.test_show_share_server | 16:08 |
| ganso | vponomaryov: isn't it a race condition there as well? | 16:08 |
| vponomaryov | ganso: it was random failure | 16:09 |
| ganso | vponomaryov: random? | 16:09 |
| ganso | vponomaryov: so manila fails randomly with the dummy driver? | 16:10 |
| vponomaryov | ganso: we have problems not only because of drivers | 16:10 |
| vponomaryov | ganso: but lots of other things | 16:10 |
| vponomaryov | ganso: so, sure, since it failed, it can be fixed somehow | 16:12 |
| vponomaryov | ganso: but it is definitely not related to the goal of commit | 16:12 |
| vponomaryov | ganso: where fixed one concrete specific bug | 16:12 |
| openstackgerrit | zhongjun proposed openstack/python-manilaclient: Add snapshot instances admin APIs https://review.openstack.org/304449 | 16:13 |
| vponomaryov | ganso: if you think it worth fixing, then file a bug and we will fix it too if it appears again | 16:13 |
| ganso | vponomaryov: added comment in gerrit | 16:14 |
| *** akapil has joined #openstack-manila | 16:15 | |
| vponomaryov | ganso: according to test code, it is picks random first share server | 16:15 |
| vponomaryov | ganso: that could be from any other test | 16:15 |
| vponomaryov | ganso: so, I would say yes, it is concurrency bug, but hardly reproducible | 16:16 |
| vponomaryov | ganso: and should be easy to fix | 16:16 |
| ganso | vponomaryov: great, whatever you decide if separate commit or same, you can add 2 closes-bug | 16:16 |
| vponomaryov | separate | 16:16 |
| vponomaryov | only | 16:17 |
| *** akapil has quit IRC | 16:19 | |
| *** timcl has joined #openstack-manila | 16:24 | |
| *** bill_az has joined #openstack-manila | 16:30 | |
| *** permalac has quit IRC | 16:31 | |
| *** akapil has joined #openstack-manila | 16:47 | |
| *** akapil has quit IRC | 16:52 | |
| *** akapil has joined #openstack-manila | 17:06 | |
| *** akapil has quit IRC | 17:11 | |
| *** xyang_ has quit IRC | 17:14 | |
| *** nherciu has quit IRC | 17:15 | |
| openstackgerrit | Daniel Gonzalez Nothnagel proposed openstack/manila: Add binding_profile option for backends https://review.openstack.org/284034 | 17:19 |
| openstackgerrit | Daniel Gonzalez Nothnagel proposed openstack/manila: Add multi-segment support https://review.openstack.org/277731 | 17:19 |
| openstackgerrit | Daniel Gonzalez Nothnagel proposed openstack/manila: Add neutron driver for binding https://review.openstack.org/283494 | 17:19 |
| *** xyang_ has joined #openstack-manila | 17:19 | |
| *** xyang_ has quit IRC | 17:23 | |
| *** xyang_ has joined #openstack-manila | 17:25 | |
| openstackgerrit | Alex Meade proposed openstack/manila-specs: Add spec for Manila share groups https://review.openstack.org/315730 | 17:25 |
| *** xyang_ has quit IRC | 17:28 | |
| *** xyang_ has joined #openstack-manila | 17:28 | |
| *** faiz89 has joined #openstack-manila | 17:29 | |
| *** xyang_ has quit IRC | 17:32 | |
| gouthamr | vponomaryov: still around? | 17:33 |
| *** xyang_ has joined #openstack-manila | 17:33 | |
| openstackgerrit | Alex Meade proposed openstack/manila: WIP Manila Share Groups https://review.openstack.org/335093 | 17:36 |
| *** akapil has joined #openstack-manila | 17:37 | |
| *** akapil has quit IRC | 17:42 | |
| *** xyang_ has quit IRC | 17:43 | |
| *** dustins has quit IRC | 17:45 | |
| *** akapil has joined #openstack-manila | 17:53 | |
| *** sandanar has quit IRC | 17:56 | |
| openstackgerrit | Alyson proposed openstack/manila: Add support for CIFS shares in HNAS driver https://review.openstack.org/342960 | 17:56 |
| *** akapil_ has joined #openstack-manila | 17:58 | |
| *** akapil_ has quit IRC | 17:59 | |
| *** akapil has quit IRC | 18:02 | |
| *** xyang_ has joined #openstack-manila | 18:12 | |
| *** mtanino has joined #openstack-manila | 18:14 | |
| *** ociuhandu has quit IRC | 18:37 | |
| *** hoonetorg has quit IRC | 18:56 | |
| *** faiz89 has quit IRC | 18:58 | |
| *** faiz89 has joined #openstack-manila | 19:00 | |
| *** dustins has joined #openstack-manila | 19:03 | |
| *** zhonghua-lee has quit IRC | 19:25 | |
| *** porrua has quit IRC | 19:52 | |
| *** faiz89 has quit IRC | 19:59 | |
| *** faiz89 has joined #openstack-manila | 20:00 | |
| *** akerr has quit IRC | 20:00 | |
| *** merooney has quit IRC | 20:03 | |
| *** ociuhandu has joined #openstack-manila | 20:07 | |
| *** gouthamr has quit IRC | 20:41 | |
| *** akshai has quit IRC | 20:42 | |
| *** Suyi_ has quit IRC | 20:54 | |
| *** Suyi_ has joined #openstack-manila | 20:54 | |
| *** faiz89 has quit IRC | 20:59 | |
| *** timcl has quit IRC | 21:00 | |
| *** dustins has quit IRC | 21:12 | |
| *** cknight has joined #openstack-manila | 21:21 | |
| *** cknight has quit IRC | 21:30 | |
| *** cknight has joined #openstack-manila | 21:34 | |
| *** ganso has quit IRC | 21:41 | |
| *** aorourke has quit IRC | 21:43 | |
| *** xyang_ has quit IRC | 21:48 | |
| *** alyson_ has quit IRC | 21:53 | |
| *** xyang_ has joined #openstack-manila | 21:55 | |
| *** xyang_ has quit IRC | 21:56 | |
| *** adrianofr has quit IRC | 22:01 | |
| *** cknight has quit IRC | 22:03 | |
| *** xyang_ has joined #openstack-manila | 22:18 | |
| *** xyang_ has quit IRC | 22:29 | |
| *** jcsp has quit IRC | 22:34 | |
| *** tpsilva has quit IRC | 22:38 | |
| *** gouthamr has joined #openstack-manila | 22:45 | |
| *** xyang1 has quit IRC | 23:16 | |
| *** pgbridge has quit IRC | 23:22 | |
| *** Suyi_ has quit IRC | 23:38 | |
| *** cknight has joined #openstack-manila | 23:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!