*** yangyapeng has quit IRC | 00:05 | |
*** vbellur has joined #openstack-manila | 00:15 | |
*** gouthamr has joined #openstack-manila | 00:27 | |
*** amit213 has quit IRC | 00:42 | |
*** suyash has quit IRC | 00:49 | |
*** esker has joined #openstack-manila | 00:52 | |
*** esker has quit IRC | 00:57 | |
*** absubram has joined #openstack-manila | 00:57 | |
*** mtanino has quit IRC | 01:05 | |
*** absubram has quit IRC | 01:12 | |
*** yangyapeng has joined #openstack-manila | 01:13 | |
*** amit213 has joined #openstack-manila | 01:13 | |
*** yangyapeng has quit IRC | 01:15 | |
*** amit213 has quit IRC | 01:16 | |
*** esker has joined #openstack-manila | 01:28 | |
*** esker has quit IRC | 01:33 | |
*** gouthamr has quit IRC | 01:53 | |
*** esker has joined #openstack-manila | 02:04 | |
*** esker has quit IRC | 02:09 | |
*** esker has joined #openstack-manila | 02:40 | |
*** esker has quit IRC | 02:44 | |
*** wangqun has joined #openstack-manila | 02:45 | |
*** zhongjun_ has quit IRC | 03:03 | |
*** zhongjun_ has joined #openstack-manila | 03:04 | |
*** esker has joined #openstack-manila | 03:15 | |
*** esker has quit IRC | 03:20 | |
*** darkwsh has quit IRC | 03:29 | |
*** esker has joined #openstack-manila | 03:51 | |
*** esker has quit IRC | 03:57 | |
*** esker has joined #openstack-manila | 04:27 | |
*** esker has quit IRC | 04:32 | |
*** esker has joined #openstack-manila | 05:03 | |
*** esker has quit IRC | 05:08 | |
openstackgerrit | Merged openstack/manila-ui: Updated from global requirements https://review.openstack.org/311539 | 05:20 |
---|---|---|
openstackgerrit | Merged openstack/manila: Added docs for commit message tags https://review.openstack.org/310009 | 05:23 |
*** rraja has joined #openstack-manila | 05:26 | |
*** xiaoxi has joined #openstack-manila | 05:27 | |
*** gaurangt1 has joined #openstack-manila | 05:47 | |
*** nobse has joined #openstack-manila | 05:55 | |
*** openstackgerrit has quit IRC | 06:03 | |
*** openstackgerrit has joined #openstack-manila | 06:03 | |
openstackgerrit | Ramana Raja proposed openstack/manila: cephfs_native: doc fixes https://review.openstack.org/295448 | 06:04 |
*** nobse has quit IRC | 06:05 | |
*** gaurangt1 has left #openstack-manila | 06:14 | |
*** nobse has joined #openstack-manila | 06:15 | |
*** nobse has quit IRC | 06:16 | |
*** yangyapeng has joined #openstack-manila | 06:31 | |
*** soumitm has quit IRC | 06:33 | |
*** soumitm has joined #openstack-manila | 06:34 | |
*** soumitm has quit IRC | 06:39 | |
*** rraja has quit IRC | 07:29 | |
*** gaurangt has joined #openstack-manila | 07:33 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 07:51 |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 07:54 |
*** lpetrut has joined #openstack-manila | 07:54 | |
*** dmk0202 has joined #openstack-manila | 07:57 | |
*** dmk0202 has quit IRC | 08:03 | |
*** dmk0202 has joined #openstack-manila | 08:11 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 08:37 |
openstackgerrit | NidhiMittalHada proposed openstack/manila: Delete Snapshot: status wrongly set when busy https://review.openstack.org/311996 | 08:41 |
*** rraja has joined #openstack-manila | 08:49 | |
vponomaryov | tbarron: you are missing that it does not use tempest | 09:07 |
*** lpetrut has quit IRC | 09:07 | |
*** lpetrut has joined #openstack-manila | 09:08 | |
vponomaryov | tbarron: it has its own config file | 09:08 |
*** lpetrut has quit IRC | 09:14 | |
rraja | ganso: vponomaryov: it'd be great if you can https://review.openstack.org/#/c/295448/ help in merging the patch sometime soon. the doc fixes would be very useful for the early testers of the cephfs driver. thanks! | 09:22 |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 09:31 |
vponomaryov | rraja: +2'ed, seek for another +2 | 09:39 |
rraja | vponomaryov: super! once again thanks a lot! :) | 09:42 |
*** lpetrut has joined #openstack-manila | 09:47 | |
*** ishu has joined #openstack-manila | 09:57 | |
ishu | Hi all, can anyone help me in https://bugs.launchpad.net/manila/+bug/1578539 | 09:57 |
openstack | Launchpad bug 1578539 in Manila "Pop ssh instance in pool when calling remove function" [Undecided,New] - Assigned to iswarya vakati (v-iswarya) | 09:57 |
*** Guest22636 has joined #openstack-manila | 10:02 | |
*** iswarya has joined #openstack-manila | 10:03 | |
vponomaryov | ishu: what kind of help do you need? | 10:06 |
vponomaryov | ishu: confirm that there is dead-never-reached-insane-code? )) | 10:07 |
vponomaryov | ishu: bug topic is incomplete, it should what happens when described condition happens | 10:10 |
vponomaryov | it should say* | 10:10 |
iswarya | yes i am also about to ask this | 10:10 |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 10:27 |
*** wangqun has quit IRC | 10:31 | |
*** iswarya has quit IRC | 10:31 | |
*** iswarya has joined #openstack-manila | 10:32 | |
*** iswarya has quit IRC | 10:32 | |
*** ishu has quit IRC | 10:33 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Update detailed page for share servers https://review.openstack.org/312639 | 10:34 |
*** ishu has joined #openstack-manila | 10:35 | |
ishu | hi all | 10:36 |
*** yangyapeng has quit IRC | 10:46 | |
*** Guest22636 has quit IRC | 11:24 | |
openstackgerrit | Cedric Zhuang proposed openstack/manila: Add EMC Unity Driver for Manila https://review.openstack.org/312423 | 11:31 |
openstackgerrit | Merged openstack/manila: cephfs_native: doc fixes https://review.openstack.org/295448 | 11:32 |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 11:37 |
openstackgerrit | Cedric Zhuang proposed openstack/manila: Add EMC Unity Driver for Manila https://review.openstack.org/312423 | 11:42 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Update detailed page for share servers https://review.openstack.org/312639 | 11:50 |
*** tpsilva has joined #openstack-manila | 11:55 | |
*** akerr has joined #openstack-manila | 11:57 | |
*** aovchinnikov has joined #openstack-manila | 12:03 | |
*** gaurangt has left #openstack-manila | 12:05 | |
*** ekarlso has quit IRC | 12:06 | |
*** ekarlso has joined #openstack-manila | 12:06 | |
*** Guest22636 has joined #openstack-manila | 12:08 | |
*** xiaoxi has quit IRC | 12:16 | |
*** wangqun has joined #openstack-manila | 12:28 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 12:28 |
*** akerr_ has joined #openstack-manila | 12:30 | |
openstackgerrit | NidhiMittalHada proposed openstack/python-manilaclient: manila list --all-tenants should display projectID https://review.openstack.org/312017 | 12:31 |
*** timcl has joined #openstack-manila | 12:32 | |
*** akerr has quit IRC | 12:33 | |
bswartz | vponomaryov: can we switch the grenade job from experimental to check queue now or are we waiting on something still? | 12:41 |
vponomaryov | bswartz: it is not merged | 12:41 |
vponomaryov | bswartz: we are waiting for review only | 12:41 |
*** Guest22636 has quit IRC | 12:55 | |
*** xyang1 has joined #openstack-manila | 12:58 | |
*** yangyapeng has joined #openstack-manila | 12:59 | |
*** akerr_ is now known as akerr | 12:59 | |
*** gouthamr has joined #openstack-manila | 13:03 | |
*** eharney has joined #openstack-manila | 13:04 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Developer Reference: Adopt the openstackdocstheme https://review.openstack.org/312939 | 13:11 |
*** yangyapeng has quit IRC | 13:14 | |
*** ishu has quit IRC | 13:15 | |
*** esker has joined #openstack-manila | 13:17 | |
bswartz | vponomaryov: link to review? | 13:23 |
vponomaryov | bswartz: https://review.openstack.org/#/c/302801/ | 13:23 |
bswartz | vponomaryov: that's a manila change | 13:24 |
vponomaryov | bswartz: yes | 13:24 |
bswartz | if it hasn't merged, then why do grenade jobs pass on other manila changes? | 13:24 |
vponomaryov | bswartz: because grenade runs without manila | 13:25 |
vponomaryov | bswartz: only other projects succeed grenade in this job while that commit is not merged | 13:26 |
bswartz | okay | 13:26 |
bswartz | ganso xyang1 toabctl markstur: https://review.openstack.org/#/c/302801/ | 13:26 |
*** esker has quit IRC | 13:27 | |
*** esker has joined #openstack-manila | 13:28 | |
*** akshai has joined #openstack-manila | 13:31 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Developer Reference: Adopt the openstackdocstheme https://review.openstack.org/312939 | 13:32 |
*** yangyapeng has joined #openstack-manila | 13:35 | |
*** lpetrut has quit IRC | 13:37 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 13:40 |
*** porrua has joined #openstack-manila | 13:40 | |
*** mtanino has joined #openstack-manila | 13:41 | |
tbarron | vponomaryov: thanks for the reply regarding functional tests | 13:45 |
tbarron | vponomaryov: in cinder I just do 'tox -efunctional' with no special setup | 13:45 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Developer Reference: Adopt the openstackdocstheme https://review.openstack.org/312939 | 13:45 |
tbarron | vponomaryov: that didn't work in python-manilaclient, I got 'could not find requested endpoint in service catalog' | 13:46 |
tbarron | vponomaryov: so i tried following iinstructions from commit 8760b9cd | 13:46 |
tbarron | vponomaryov: but clearly I am confused | 13:47 |
*** openstackgerrit has quit IRC | 13:47 | |
vponomaryov | tbarron: cinder uses only one set of creds | 13:48 |
*** akapil has joined #openstack-manila | 13:48 | |
vponomaryov | cinderclient* | 13:48 |
vponomaryov | cinderclient functional tests* | 13:48 |
*** openstackgerrit has joined #openstack-manila | 13:48 | |
vponomaryov | that is why it works for you | 13:48 |
vponomaryov | you have env vars that are enough | 13:48 |
vponomaryov | in manila we requrie two different sets for creds | 13:48 |
vponomaryov | admin and user | 13:48 |
vponomaryov | you cannot satisfy it only with env vars that are used for clients in common way | 13:49 |
vponomaryov | for that reason config file is used | 13:49 |
vponomaryov | tbarron: our tests cover much more cases than cinderclient does | 13:50 |
tbarron | vponomaryov: and 'tox -egenconfig' will make that file for me? | 13:50 |
*** lpetrut has joined #openstack-manila | 13:50 | |
vponomaryov | tbarron: it generates sample | 13:51 |
vponomaryov | tbarron: setting of proper data stil lrequired | 13:51 |
vponomaryov | tbarron: the only thing I would say is lost for now - it is generation of such config on devstack installation step | 13:51 |
vponomaryov | but, if you do it from different-host-than-devstack you will have problems anyway )) | 13:52 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Fix share server info in CGs created from CGs https://review.openstack.org/312963 | 13:52 |
tbarron | vponomaryov: ok, I'll look at devstack setup, thanks. | 13:52 |
vponomaryov | http://logs.openstack.org/49/304449/6/check/gate-manilaclient-dsvm-neutron-functional/4bb3418/logs/devstack-gate-tbarron: post_test_hook.txt.gz#_2016-05-03_13_04_42_650 | 13:53 |
vponomaryov | tbarron: http://logs.openstack.org/49/304449/6/check/gate-manilaclient-dsvm-neutron-functional/4bb3418/logs/devstack-gate-post_test_hook.txt.gz#_2016-05-03_13_04_42_650 | 13:54 |
*** dustins has joined #openstack-manila | 13:55 | |
*** martyturner has joined #openstack-manila | 13:56 | |
vponomaryov | tbarron: and be aware there are not only read-only tests! | 13:56 |
vponomaryov | tbarron: lots of read-write tests too | 13:56 |
tbarron | vponomaryov: kk, thanks! | 13:56 |
ganso | gouthamr: ping | 13:57 |
gouthamr | ganso: pong | 13:57 |
ganso | gouthamr: Hi Goutham, good morning | 13:57 |
gouthamr | ganso: Goodmorning! :) | 13:57 |
ganso | gouthamr: in your patch proposed just above ^, shouldnt reno be renamed according to bug ID? | 13:58 |
ganso | gouthamr: s/renamed/named | 13:58 |
gouthamr | ganso: other renos aren't so far.. would that be helpful? | 13:59 |
ganso | gouthamr: if we have another fix related to consistency groups api then the name would be the same, just a different hash | 13:59 |
gouthamr | ganso: https://github.com/openstack/cinder/tree/master/releasenotes/notes https://github.com/openstack/nova/tree/master/releasenotes/notes | 14:00 |
gouthamr | ganso: yes.. that's quite a problem | 14:00 |
gouthamr | ganso: i just noticed that issue this morning with a cinder patch.. | 14:00 |
ganso | gouthamr: nobody is using the bug id :\ | 14:00 |
*** cknight has joined #openstack-manila | 14:07 | |
*** absubram has joined #openstack-manila | 14:18 | |
dustins | gouthamr: ping | 14:23 |
*** krotscheck has quit IRC | 14:27 | |
*** krotscheck has joined #openstack-manila | 14:33 | |
gouthamr | dustins: pong | 14:34 |
dustins | gouthamr: Good morning! | 14:35 |
dustins | gouthamr: Want to sync up real quick before the meeting? | 14:35 |
gouthamr | dustins: Goodmorning! yep.. | 14:35 |
*** akapil has quit IRC | 14:41 | |
*** akapil has joined #openstack-manila | 14:45 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 14:45 |
*** absubram has quit IRC | 14:51 | |
*** soumitm has joined #openstack-manila | 14:52 | |
*** markstur_ has joined #openstack-manila | 14:54 | |
*** a_ta has quit IRC | 14:57 | |
*** lpetrut has quit IRC | 14:57 | |
*** a_ta has joined #openstack-manila | 14:58 | |
vponomaryov | bswartz: meeting? | 15:01 |
gouthamr | bswartz: meeting time check | 15:01 |
*** wangqun has quit IRC | 15:03 | |
*** absubram has joined #openstack-manila | 15:05 | |
*** esker has quit IRC | 15:05 | |
*** soumitm has quit IRC | 15:05 | |
*** soumitm has joined #openstack-manila | 15:14 | |
*** lpetrut has joined #openstack-manila | 15:21 | |
*** absubram has quit IRC | 15:26 | |
*** absubram has joined #openstack-manila | 15:27 | |
*** lpetrut has quit IRC | 15:35 | |
*** lpetrut has joined #openstack-manila | 15:35 | |
*** dmk0202 has quit IRC | 15:38 | |
*** akapil has quit IRC | 15:40 | |
*** adrianofr has quit IRC | 15:42 | |
*** a_ta has quit IRC | 15:50 | |
*** a_ta has joined #openstack-manila | 15:50 | |
*** a_ta_ has joined #openstack-manila | 15:51 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 15:54 |
*** a_ta has quit IRC | 15:55 | |
*** akshai has quit IRC | 15:58 | |
*** akshai has joined #openstack-manila | 15:59 | |
*** martyturner has quit IRC | 16:00 | |
*** lpetrut has quit IRC | 16:01 | |
*** rraja has quit IRC | 16:01 | |
bswartz | vponomaryov: it should be defined to False when not set | 16:01 |
bswartz | I think the docs says that | 16:01 |
bswartz | that's important for backwards compatibility | 16:01 |
xyang1 | bswartz: You have said we should not mix the two | 16:02 |
gouthamr | bswartz: it defaults to False | 16:02 |
xyang1 | bswartz: is that changed? | 16:02 |
vponomaryov | I am talking about extra spec for "thin_provisioning" | 16:02 |
xyang1 | bswartz: you talked to me about it some time ago | 16:02 |
vponomaryov | it is not set by default | 16:02 |
xyang1 | bswartz: I mean thin and thick | 16:03 |
vponomaryov | bswartz: for your comment "(19:00:13) bswartz: you use the value from the share type, when creating the new share" - we do not use it is not set | 16:03 |
gouthamr | vponomaryov: ah.. i meant teh capability reported.. if the driver doens't report anything, it will be set to False | 16:03 |
vponomaryov | s/is/if/ | 16:03 |
bswartz | there is no thick in manila | 16:04 |
bswartz | just thin=false | 16:04 |
xyang1 | bswartz: there is both, True and False | 16:04 |
markstur_ | the original stipulatino was that if a driver did both, they would need to report as separate pools | 16:04 |
bswartz | thin can be both true and false | 16:04 |
*** martyturner has joined #openstack-manila | 16:04 | |
bswartz | there is no extra_spec/capability called thick though | 16:04 |
bswartz | thin=false MEANS thick | 16:05 |
xyang1 | bswartz: we had a discussion about calculation | 16:05 |
markstur_ | stipulation, I meant (but stipulatino is probably latin for that :) ) | 16:05 |
gouthamr | yes.. lists upset max_over_subscription_ratio | 16:05 |
bswartz | gouthamr: is there a bug? | 16:05 |
gouthamr | bswartz: nope.. i thought it was intended behavipr | 16:06 |
gouthamr | behavior | 16:06 |
xyang1 | bswartz: you said we should not let a pool supports both true and false for thin | 16:06 |
bswartz | oh wair | 16:06 |
bswartz | oh wait | 16:06 |
bswartz | yes I think you're right | 16:06 |
bswartz | while most capabilities can be lists of [True, False], thin_provisioning is one that shouldn't be | 16:07 |
gouthamr | bswartz: https://github.com/openstack/manila/blob/master/manila/scheduler/weighers/capacity.py#L66 | 16:07 |
markstur_ | tell sched you'll do 20x, but then allocate full anyway | 16:07 |
bswartz | some backends want it to be, but it breaks manila's space reservation logic | 16:07 |
xyang1 | bswartz: we probably shoukd take another look at this | 16:07 |
gouthamr | bswartz: if a driver reports [True,False] for thin_provisioning, scheduler assumes it is thin_provisioning=True | 16:07 |
markstur_ | I believe bswartz insisted that it would be bad to mix them in one pool | 16:08 |
gouthamr | bswartz: sry, that particular weigher.. not the scheduler | 16:08 |
bswartz | yeah.... if you mix them you create the following situation | 16:08 |
markstur_ | drivers can make their pool appear as 2 in reporting to manila | 16:08 |
*** yangyapeng has quit IRC | 16:08 | |
xyang1 | bswartz: if we take share type into consideration, we can get the calculation right | 16:08 |
*** yangyape_ has joined #openstack-manila | 16:08 | |
bswartz | you can fill up a pool with the maximum amount of thin provisioned shares (up to the max oversubscription ratio) | 16:08 |
bswartz | but then you can start to put thick shares on the same pool, which results in the oversub ratio going much much higher than it should | 16:09 |
gouthamr | bswartz: exactly.. | 16:09 |
xyang1 | bswartz: in reality, there are backends that can support both true and false in the same pool | 16:09 |
markstur_ | what if share type lets driver decide? | 16:09 |
bswartz | xyang1: yes we have that with netapp | 16:09 |
bswartz | which is why we have a long argument about thin provisioning after paris | 16:10 |
xyang1 | bswartz: the problem is in our calculation, we do not look at share types | 16:10 |
vponomaryov | markstur_: share_type is used to filter backends | 16:10 |
*** akapil has joined #openstack-manila | 16:10 | |
bswartz | ultimately I was convinced though that if we want to oversub ratio in manila to mean something, then we shouldn't mix thick and thin | 16:10 |
markstur_ | what if there is no extra-spec for thin_provisioning -- do we automatically set one? | 16:10 |
bswartz | markstur_: IMO it should default to thick if not set | 16:10 |
xyang1 | bswartz: we can check whether it is true or false from a type in scheduler and calculation should be right | 16:10 |
markstur_ | I think that one is left as "whatever" | 16:10 |
vponomaryov | markstur_: yes, not set equals to any | 16:11 |
xyang1 | markstur: we need to require that in extra specs if we do this | 16:11 |
bswartz | okay it sounds like there's a subtle bug here | 16:11 |
bswartz | in at least one place the default isn't being set | 16:11 |
bswartz | and the filter is being ignored | 16:11 |
markstur_ | So are we backtracking on the initial agreement that a pool can only be thin or thick? | 16:12 |
markstur_ | as reported to manila | 16:12 |
bswartz | and a share which *should* be thick is getting sent to a thin-only pool | 16:12 |
xyang1 | bswartz: markstur_ anyway, I think this is worth considering as an enhancement | 16:12 |
bswartz | markstur_: I'm not | 16:12 |
bswartz | markstur_: I think others might be trying to though | 16:13 |
xyang1 | bswartz: we get into that situation because we don't check if extra specs says true or false | 16:13 |
markstur_ | OK. Sounds like we are at least "revisiting" it. It's worth discussing, but I don't want it to just sneakily evolve | 16:13 |
xyang1 | bswartz: if we make that a requirement, we won't pick the wrong pool | 16:14 |
xyang1 | markstur_: sneakly? | 16:14 |
*** akapil has quit IRC | 16:14 | |
markstur_ | yeah. if the scheduler considered the extra-spec with a required default that would help | 16:14 |
markstur_ | Re: sneakily -- what happened was we agreed on one thing and then patches tried to change that (a while ago) | 16:15 |
markstur_ | and now the same thing is happening -- not really sneaky... just because we are perhaps not remembering the old conversations | 16:15 |
markstur_ | That's what I meant. | 16:16 |
bswartz | yeah we should probably put in patches which enforce what we say so that attempts to sneak around it are either obvious or don't work | 16:16 |
xyang1 | markstur_: we found problems in the original assumption and try to fix it | 16:16 |
* bswartz needs to run to lunch | 16:16 | |
bswartz | bbl | 16:16 |
xyang1 | bswartz: see you | 16:16 |
markstur_ | xyang1, Today we are discussing fixing it. Yes. | 16:16 |
markstur_ | xyang1, In the past there was one patch that simply didn't follow the spec and would have broken things (for other drivers too I think?) | 16:17 |
markstur_ | So let's not allow this w/o fixing the scheduler to be aware. | 16:18 |
xyang1 | markstur_: I don't know. we do not have spec in manila | 16:18 |
markstur_ | Spec is IRC logs ??? | 16:18 |
markstur_ | actually we have documented this for capabilities | 16:18 |
xyang1 | or wiki? | 16:18 |
markstur_ | better than spec. living doc | 16:18 |
gouthamr | markstur_ xyang1 bswartz: https://bugs.launchpad.net/manila/+bug/1578718 | 16:19 |
openstack | Launchpad bug 1578718 in Manila "max_over_subscription_ratio is miscalculated for drivers reporting list [True, False] for thin_provisioning" [Undecided,New] | 16:19 |
gouthamr | we need to triage ^ | 16:19 |
markstur_ | which drivers report that? | 16:20 |
gouthamr | markstur_: i was going to write some documentation on the usage of max_over_subscription_ratio for the admin guide | 16:20 |
gouthamr | markstur_: netapp :| | 16:20 |
markstur_ | Today that is a NetApp bug. Don't report both. | 16:21 |
gouthamr | markstur_: yep.. on the tree, just the netapp driver | 16:21 |
akerr | but we can support both | 16:21 |
gouthamr | markstur_: but it seems weird that i can do capability lists and then not do it for thin_provisioning | 16:22 |
xyang1 | gouthamr: it only works right if you have one pool support true or false but not both | 16:22 |
markstur_ | The comon capabilities spec says -- must be one or the other for this | 16:22 |
gouthamr | xyang1: that's correct.. | 16:22 |
xyang1 | gouthamr: bswartz talks to me about this a while back | 16:23 |
markstur_ | And if a driver wants to do both, they need to report as 2 separate pools | 16:23 |
xyang1 | gouthamr: to solve this, we should look at extra specs as I said earlier | 16:23 |
markstur_ | Was originally a NetApp proposal to require this (not naming names) :) | 16:23 |
*** jcsp has quit IRC | 16:23 | |
gouthamr | markstur_: that could be a solution.. | 16:23 |
gouthamr | markstur_: lol :D | 16:23 |
markstur_ | That _was_ the requried solution | 16:23 |
markstur_ | But as discussed today -- if we also fix the scheduler to be smarter, then maybe we could revisit this restriction | 16:24 |
gouthamr | xyang1: yes.. either we look at extra_specs and use it appropriately to do the max_over_subscription_ratio or we stop drivers from reporting a list | 16:24 |
gouthamr | markstur_: yes.. | 16:24 |
markstur_ | Unfortunately at least one driver was forced to use the dual-pool thing which they disagreed with | 16:25 |
akerr | or we take the cinder approach and make thin_provisioning one capability and thick_provisioning another | 16:25 |
markstur_ | Ack! | 16:25 |
markstur_ | Did he say "take the cinder approach"? | 16:25 |
xyang1 | akerr: cinder has the similar problem | 16:25 |
markstur_ | Yeah. I guess consistency with Cinder and fixing this problem a really 2 different things. | 16:26 |
xyang1 | akerr: the thick provisioning one is not really used | 16:26 |
akerr | xyang1: I guess that depends on the admin making the volume-types | 16:27 |
xyang1 | akerr: in cinder you need to create two pools too | 16:27 |
xyang1 | akerr: similar to manila | 16:27 |
markstur_ | If the scheduler looked at the extra-spec that would fix it. I don't think there would be a problem as long as the extra-spec is reaquired to have a value or default and not "don't care" like most extra-specs | 16:28 |
xyang1 | akerr: I mean the cinder approach does not solve this problem either | 16:28 |
akerr | i'm not sure how 2 pools fixes this problem, you still have 1 of the pools reporting incorrect capacity if they're both actually pointing to the same set of storage | 16:28 |
markstur_ | If there was another reason why mixing thin/think in one pool was bad, I don't remember what it was | 16:28 |
xyang1 | akerr: one pool report true and another false, not to mix them | 16:29 |
*** rraja has joined #openstack-manila | 16:29 | |
akerr | xyang1: but then i have 1 set of disks with 2 values for capacity in the scheduler, which is correct? | 16:30 |
markstur_ | akerr, One pool reports itself 2 ways is hacky. Solves this problem somewhat but then you are double-reporting and relying on the status update to fix up stats after each create | 16:30 |
akerr | i agree, its a crazy situation | 16:30 |
*** rraja has quit IRC | 16:30 | |
akerr | i'm just saying I don't think the 2 pools solution is correct either | 16:31 |
gouthamr | markstur_: +1 the simplest solution is stop supporting both, and just report one | 16:31 |
*** dustins has quit IRC | 16:31 | |
markstur_ | gouthamr, Yes. | 16:31 |
gouthamr | markstur_: we may be able to live with that.. we'll go back to our drawing boards when bswartz comes back from lunch :P | 16:31 |
*** dustins has joined #openstack-manila | 16:32 | |
* akerr wishes everything was thick provisioned. Then we don't have to worry about lying about capacity at all | 16:32 | |
markstur_ | akerr, blasphemy | 16:33 |
* gouthamr finds that rusty lamp | 16:33 | |
akerr | math is so much easier when 2-1 = 1, not 2 -1 = 2 sometimes | 16:33 |
xyang1 | markstur_: even if we check extra specs, weighing is still a challenge if the pool supports both | 16:33 |
markstur_ | akerr, I somewhat agree with you, but our companies really like their thin feature | 16:34 |
markstur_ | and in many cases it works great | 16:34 |
akerr | well ya, thin provisioning makes all this storage stuff have the proper ROI | 16:34 |
xyang1 | markstur_: check type can fix the filter, but which capacity to use for weighing | 16:34 |
akerr | still means you're lying to yourself :) | 16:34 |
markstur_ | It is a math conundrum though | 16:34 |
markstur_ | Fixed limits vs probabilities and statistics | 16:35 |
*** dustins has quit IRC | 16:36 | |
akerr | gouthamr: maybe we could make thick/thin a driver setting in the conf file? | 16:36 |
akerr | still nothing to stop them from making 2 backends pointing to the same disks, but then its on the admin for doing that | 16:37 |
xyang1 | bswartz: I'd like to know what you think, we should talk about this more | 16:37 |
markstur_ | xyang1, Not sure about weighing. I thought we had a problem getting the spec value, but I haven't looked at it in a long time | 16:37 |
markstur_ | I'v got to go. Be back in the office soon. | 16:38 |
xyang1 | markstur_: I thought that is available but I need to check too | 16:38 |
*** markstur_ has quit IRC | 16:38 | |
akerr | could you do the weighing based on what the share is asking for? so if its asking to be thin provisioned use that set of math, and if its asking to be thick use that set of math? And then default to something (thin?) if its unspecified? | 16:38 |
xyang1 | markstur_: maybe weighing can be configurable | 16:38 |
xyang1 | akerr: weighing is for a entire backend, not a share | 16:39 |
akerr | xyang1: but weight isn't calculated until a request comes in | 16:39 |
xyang1 | akerr: yes | 16:39 |
akerr | we know what the share's requirements are, so use that to help the weigher | 16:39 |
xyang1 | we could do that, I don't if that is the best way | 16:40 |
akerr | I'm not sure it is either, but just spit-balling ideas here | 16:41 |
openstackgerrit | Cedric Zhuang proposed openstack/manila: Add EMC Unity Driver for Manila https://review.openstack.org/312423 | 16:42 |
*** akshai has quit IRC | 16:44 | |
*** akshai has joined #openstack-manila | 16:47 | |
gouthamr | akerr: yes, in the simplest solution, we can let the admin configure which pools are thin and which ones are meant to be thick | 16:50 |
*** akshai has quit IRC | 16:52 | |
*** martyturner has quit IRC | 16:52 | |
*** martyturner has joined #openstack-manila | 16:52 | |
*** akshai has joined #openstack-manila | 16:54 | |
*** martyturner has quit IRC | 16:57 | |
*** adrianofr has joined #openstack-manila | 16:57 | |
*** lpetrut has joined #openstack-manila | 16:58 | |
*** cknight has quit IRC | 17:00 | |
*** cknight has joined #openstack-manila | 17:01 | |
*** martyturner has joined #openstack-manila | 17:03 | |
openstackgerrit | Daniel Gonzalez Nothnagel proposed openstack/manila: Fix IPv6 standalone network plugin test https://review.openstack.org/313061 | 17:04 |
*** akapil has joined #openstack-manila | 17:11 | |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Developer Reference: Adopt the openstackdocstheme https://review.openstack.org/312939 | 17:15 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Developer Reference: Adopt the openstackdocstheme https://review.openstack.org/312939 | 17:15 |
openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Developer Reference: Adopt the openstackdocstheme https://review.openstack.org/312939 | 17:15 |
* gouthamr doh | 17:15 | |
*** suyash has joined #openstack-manila | 17:21 | |
*** gluytium has quit IRC | 17:24 | |
*** dustins has joined #openstack-manila | 17:27 | |
gouthamr | tbarron: and looks fancy, no? :) | 17:34 |
tbarron | gouthamr: yeah, it looks good. Now for some contnent :) | 17:35 |
gouthamr | tbarron: yep.. on it :) | 17:35 |
tbarron | gouthamr: i know, just teasing you. Thanks for what you are doing! | 17:35 |
gouthamr | tbarron: :) | 17:35 |
ameade | gonna brain dump here | 17:39 |
ameade | so for porting messages | 17:39 |
ameade | I would actually really like all of the messages for all projects defined in one place | 17:39 |
ameade | so that the event_id of '000002' always means the same thing | 17:39 |
ameade | and we dont overload the ids | 17:39 |
ameade | smcginnis: you should help me think about this ^ :P | 17:40 |
ameade | eharney: you too | 17:40 |
ameade | for context, i am gonna port messages to manila | 17:41 |
smcginnis | ameade: I think that makes sense, but I'm not sure how practical it would end up being. | 17:41 |
smcginnis | ameade: I was actually thinking at the summit, maybe we should do like we did with hacking checks. | 17:41 |
eharney | ameade: just prefix them with another per-project number? | 17:41 |
ameade | maybe? | 17:41 |
smcginnis | So C0001 is a Cinder specific thing, M0001 is a manila specific thing. | 17:41 |
ameade | or maybe we make event ids more like a uuid? | 17:41 |
smcginnis | Then it's easy-ish to tell from the message ID where it came from. | 17:42 |
eharney | smcginnis: pretty much what i was thinking, just that instead of "C" i was imagining "100" | 17:42 |
smcginnis | And we could potentially suck all of them in to one reference page or catalog. | 17:42 |
smcginnis | eharney: That works too. | 17:42 |
eharney | but maybe they don't need to be numeric, not sure | 17:42 |
smcginnis | The thing I like about the C|M|N is it's some kind of indication without needing to look up what it means. | 17:42 |
smcginnis | But we do have multiple projects with the same first initial... | 17:43 |
ameade | you kind of get that with the resource_type in the error though | 17:43 |
smcginnis | Keeping all numeric would actually be just fine with me. | 17:43 |
ameade | in the message object i mean | 17:43 |
ameade | the main question is then, how do we avoid collisions? | 17:43 |
ameade | i could move stuff to oslo? | 17:43 |
smcginnis | ameade: uuid's are just harder to parse if someones trying to match things up manually. | 17:44 |
ameade | be really careful? | 17:44 |
eharney | technically if they're standardized error codes they should be prefixed with "volume" instead of "cinder" probably | 17:44 |
ameade | smcginnis: +1 | 17:44 |
smcginnis | eharney: Another good point. | 17:44 |
smcginnis | ameade: Haha, yeah - be really careful. ;) | 17:44 |
ameade | not hard to db migrate that at least | 17:44 |
ameade | ok i tell you what, i'll do volume_... | 17:45 |
ameade | that way it's easy to do in other projects until we figure out what can be abstracted (if anything) to oslo | 17:45 |
smcginnis | Sounds reasonable to me. | 17:45 |
ameade | so that patch will be incoming soon | 17:45 |
eharney | ameade: but what prefix do you use for brick? :) | 17:45 |
ameade | heh | 17:45 |
ameade | eharney: brick never talks to the db directly right? | 17:46 |
ameade | eharney: so likely we will have it bubble up to cinder or nova | 17:46 |
eharney | ameade: sure but that doesn't mean it won't throw interesting errors for us to create messages from | 17:46 |
eharney | yeah, i suppose so | 17:46 |
*** akapil has quit IRC | 17:54 | |
jseiler__ | We're working on a new manila driver. We've been referencing the manila minimum requirements page - http://docs.openstack.org/developer/manila/devref/driver_requirements.html | 18:00 |
jseiler__ | We've also found the manila API page - https://wiki.openstack.org/wiki/Manila/API. But that states that is is for how to develop applications that use manila. | 18:00 |
jseiler__ | In today's manila IRC meeting, I saw discussion of updating documentation. | 18:00 |
jseiler__ | Is there documentation for the interface that drivers must implement? | 18:00 |
*** cknight has quit IRC | 18:03 | |
*** jcsp has joined #openstack-manila | 18:03 | |
*** soumitm has quit IRC | 18:04 | |
*** cknight has joined #openstack-manila | 18:04 | |
*** akapil has joined #openstack-manila | 18:04 | |
* bswartz scrolls back | 18:05 | |
*** jasonsb has joined #openstack-manila | 18:07 | |
*** martyturner has quit IRC | 18:07 | |
bswartz | xyang1: still here? | 18:09 |
xyang1 | bswartz: yes | 18:10 |
bswartz | xyang1: so some more work is needed I think on max_oversubscribe_ratio -- if we want to allow mixing of thin and thick | 18:11 |
bswartz | I think we could make the scheduler a bit smarter, and get a sane result | 18:11 |
*** martyturner has joined #openstack-manila | 18:11 | |
bswartz | we would need filters in addition to weighers though | 18:11 |
xyang1 | bswartz: yes, look at type in filter and decide which logic to go? | 18:12 |
*** soumitm has joined #openstack-manila | 18:12 | |
bswartz | well for one, I think it makes sense to have a filter even if the pool is just thin | 18:12 |
xyang1 | bswartz: there is already a filter, what else do you need | 18:13 |
bswartz | because otherwise you could still exceed your max oversub ratio with just a lot of empty shares all on teh same pool | 18:13 |
bswartz | oh | 18:13 |
bswartz | gouthamr told me there wasn't | 18:13 |
xyang1 | we have capacity filter | 18:13 |
* bswartz goes to double check | 18:13 | |
xyang1 | it is there | 18:13 |
bswartz | does the capacity filter correctly handle virtual capacity? | 18:14 |
xyang1 | I think we just need to enhance it | 18:14 |
xyang1 | for one type, yes | 18:14 |
xyang1 | there is a problem if the pool supports both currently | 18:14 |
bswartz | okay | 18:14 |
bswartz | yes well we could fix that | 18:15 |
bswartz | I guess that's probably the smartest thing to do | 18:15 |
*** lpetrut has quit IRC | 18:15 | |
xyang1 | so if we say, if thin is true in extra specs, use the logic for thin, otherwise use the other logic | 18:15 |
bswartz | however I'd feel safer if we had test code that verified the correctness of these filters and weighers | 18:15 |
xyang1 | there are actually lots of tests | 18:16 |
bswartz | xyang1: well if we have both, we need to run 2 types of checks | 18:16 |
bswartz | there are unit tests but I'd like functional tests for the scheduler | 18:16 |
xyang1 | do we have any for scheduler? I don't remember | 18:17 |
bswartz | probably not | 18:17 |
bswartz | well we do for share types | 18:17 |
xyang1 | ok | 18:17 |
bswartz | we validate that share types are filtered properly I think | 18:17 |
bswartz | but I don't think we check that the capacity filter/weighers do the correct things | 18:17 |
xyang1 | probably not | 18:18 |
bswartz | that's one reason it's easy to get into a situation where we disagree about what the correct thing is | 18:18 |
bswartz | if we just had a test, then we could point to it | 18:18 |
xyang1 | sure | 18:18 |
bswartz | we could argue about changing the test, but we could never argue about what the test does | 18:18 |
akerr | bswartz: challenge accepted | 18:19 |
bswartz | akerr: what challenge? | 18:19 |
akerr | we could never argue about what the test does | 18:19 |
bswartz | akerr: are you going to write the scheduler tests? or are you going to prove that it's possible to argue about what a tests does? | 18:20 |
bswartz | lol | 18:20 |
*** dustins has quit IRC | 18:24 | |
bswartz | ameade: who is doing the work on defining better error response at the HTTP level (the step before you get to user messages) | 18:25 |
*** akapil has quit IRC | 18:25 | |
*** lpetrut has joined #openstack-manila | 18:26 | |
*** akapil has joined #openstack-manila | 18:26 | |
*** soumitm has quit IRC | 18:31 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: Container driver https://review.openstack.org/308930 | 18:37 |
*** dustins has joined #openstack-manila | 18:37 | |
openstackgerrit | Sumit Kumar proposed openstack/manila: Fix documentation for REST API version history and Scheduler https://review.openstack.org/313107 | 18:40 |
*** esker has joined #openstack-manila | 18:40 | |
*** esker has quit IRC | 18:40 | |
*** esker has joined #openstack-manila | 18:45 | |
*** jcsp has quit IRC | 18:47 | |
*** martyturner has quit IRC | 18:55 | |
gouthamr | jseiler__: hi, still around? | 18:58 |
*** martyturner has joined #openstack-manila | 18:58 | |
jseiler__ | gouthamr: Yes, still here | 18:58 |
gouthamr | jseiler__: not sure if anyone answered that question.. but yes, you found the driver minimum requirements doc... we're enhancing the driver interface docs.. so its easier to write code around those interfaces | 18:58 |
gouthamr | jseiler__: i mean, the docstrings we'll add/change will help you do the right thing for each interface.. | 18:59 |
*** timcl1 has joined #openstack-manila | 19:00 | |
*** akapil has quit IRC | 19:00 | |
jseiler__ | gouthamr: So, for reference, I should look at the docstrings in the driver code? Or is there a webpage somewhere too? | 19:01 |
*** timcl has quit IRC | 19:03 | |
openstackgerrit | Merged openstack/manila: Add Grenade support to Manila https://review.openstack.org/302801 | 19:06 |
*** akapil has joined #openstack-manila | 19:09 | |
*** akapil has joined #openstack-manila | 19:11 | |
*** akapil has joined #openstack-manila | 19:11 | |
*** akshai has quit IRC | 19:14 | |
*** akshai has joined #openstack-manila | 19:14 | |
*** akapil has quit IRC | 19:14 | |
-openstackstatus- NOTICE: Gerrit is restarting to address performance issues related to a suspected memory leak | 19:21 | |
*** akapil has joined #openstack-manila | 19:26 | |
*** akshai has quit IRC | 19:29 | |
*** akshai has joined #openstack-manila | 19:30 | |
*** jcsp has joined #openstack-manila | 19:34 | |
gouthamr | jseiler__: sorry for the latency.. as of today, its not all in one place.. but http://docs.openstack.org/developer/manila/devref/index.html is a place to start | 19:43 |
gouthamr | jseiler__: you may look at some of the reference drivers.. the individual driver documentation is on that page as well | 19:43 |
jseiler__ | gouthamr, OK. Thank your for the info and help. We were looking at the reference and other drivers too. | 19:45 |
gouthamr | jseiler__: we'll have it all in one place soon-ish.. dustins is currently working on that :) | 19:45 |
* dustins looks around | 19:46 | |
jseiler__ | gouthamr: My colleague that developer the cinder driver also used devstack to gather some info. i.e. add print statements to gather info on the calls the come down to the driver | 19:46 |
gouthamr | jseiler__: gee :P | 19:47 |
*** absubram has quit IRC | 19:47 | |
dustins | jseiler__: Yeah, I'm going through the driver interface now and tidying it up, expect some clarifications soon :) | 19:47 |
jseiler__ | dustins: Thank you. I appreciate the info :) | 19:48 |
dustins | jseiler__: No problem! | 19:49 |
*** absubram has joined #openstack-manila | 19:52 | |
*** gouthamr has quit IRC | 19:53 | |
*** gouthamr has joined #openstack-manila | 19:56 | |
*** akapil has quit IRC | 19:56 | |
*** martyturner has quit IRC | 19:56 | |
*** gouthamr has quit IRC | 19:56 | |
*** martyturner has joined #openstack-manila | 19:59 | |
*** akapil has joined #openstack-manila | 20:00 | |
*** jcsp has quit IRC | 20:00 | |
*** timcl has joined #openstack-manila | 20:01 | |
*** akapil has quit IRC | 20:01 | |
*** timcl1 has quit IRC | 20:03 | |
*** martyturner has quit IRC | 20:03 | |
ganso | cknight, bswartz, xyang1, markstur: Could you please take a look at https://review.openstack.org/#/c/299332/ ? | 20:06 |
ganso | cknight, bswartz, xyang1, markstur: that ^ needs to be backported as soon as it merges | 20:06 |
ganso | xyang1: thanks! =D | 20:10 |
xyang1 | ganso: no problem:) | 20:10 |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix HNAS error with unconfined filesystems https://review.openstack.org/307407 | 20:16 |
markstur | ameade, Doesn't devstack already solve the single letter thing with m- c- n- q- (neutron stuck with old q-)? Or do we already have issues with that? To devstacky? | 20:16 |
markstur | s/To/Too/ | 20:16 |
ameade | meh we may as well be more explicit | 20:16 |
markstur | ameade, Yeah. | 20:20 |
-openstackstatus- NOTICE: Gerrit is restarting to revert incorrect changes to test result displays | 20:29 | |
*** dmk0202 has joined #openstack-manila | 20:29 | |
*** lpetrut has quit IRC | 20:32 | |
*** akapil has joined #openstack-manila | 20:47 | |
*** amit213 has joined #openstack-manila | 20:50 | |
*** dustins has quit IRC | 20:51 | |
*** akapil has quit IRC | 20:51 | |
*** esker has quit IRC | 20:52 | |
*** porrua has quit IRC | 20:56 | |
openstackgerrit | Merged openstack/manila: Developer Reference: Adopt the openstackdocstheme https://review.openstack.org/312939 | 20:56 |
*** esker has joined #openstack-manila | 20:57 | |
*** akapil has joined #openstack-manila | 21:00 | |
*** lpetrut has joined #openstack-manila | 21:03 | |
*** lpetrut has quit IRC | 21:08 | |
*** akapil has quit IRC | 21:09 | |
*** dustins has joined #openstack-manila | 21:11 | |
*** gouthamr has joined #openstack-manila | 21:15 | |
*** timcl has quit IRC | 21:21 | |
*** jasonsb has quit IRC | 21:55 | |
*** jcsp has joined #openstack-manila | 21:55 | |
*** jasonsb has joined #openstack-manila | 21:58 | |
*** akshai has quit IRC | 22:12 | |
*** eharney has quit IRC | 22:15 | |
*** absubram has quit IRC | 22:22 | |
*** cknight has quit IRC | 22:22 | |
*** jcsp has quit IRC | 22:28 | |
*** a_ta_ has quit IRC | 22:36 | |
*** a_ta has joined #openstack-manila | 22:36 | |
*** akerr has quit IRC | 22:37 | |
*** a_ta has quit IRC | 22:41 | |
*** dustins has quit IRC | 22:42 | |
*** dustins has joined #openstack-manila | 22:43 | |
*** dustins has quit IRC | 22:43 | |
*** david-lyle has quit IRC | 22:51 | |
*** david-lyle has joined #openstack-manila | 22:53 | |
*** david-lyle has quit IRC | 22:58 | |
*** tpsilva has quit IRC | 23:07 | |
*** sgotliv has quit IRC | 23:21 | |
*** mtanino has quit IRC | 23:30 | |
*** mtanino has joined #openstack-manila | 23:30 | |
*** krotscheck has quit IRC | 23:31 | |
*** krotscheck has joined #openstack-manila | 23:31 | |
*** gouthamr_ has joined #openstack-manila | 23:31 | |
*** gouthamr has quit IRC | 23:36 | |
*** dmk0202 has quit IRC | 23:42 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!