| *** merooney has quit IRC | 00:00 | |
| *** haomaiwang has quit IRC | 00:01 | |
| *** haomaiwang has joined #openstack-manila | 00:01 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Implement admin network in generic driver https://review.openstack.org/278699 | 00:12 |
|---|---|---|
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Introduced Data Service https://review.openstack.org/244286 | 00:13 |
| *** qeelee has joined #openstack-manila | 00:31 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Move Share Migration code to Data Service https://review.openstack.org/250515 | 00:33 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 00:41 |
| *** akerr has joined #openstack-manila | 00:58 | |
| *** akerr_ has joined #openstack-manila | 00:59 | |
| *** haomaiwang has quit IRC | 01:01 | |
| *** haomaiwang has joined #openstack-manila | 01:01 | |
| *** akerr has quit IRC | 01:02 | |
| *** vbellur has quit IRC | 01:03 | |
| *** yangyapeng has joined #openstack-manila | 01:09 | |
| *** yangyapeng has quit IRC | 01:12 | |
| *** gouthamr_ has quit IRC | 01:13 | |
| *** gouthamr has joined #openstack-manila | 01:16 | |
| *** aorourke is now known as aorourke-afk | 01:17 | |
| *** haomaiwang has quit IRC | 01:22 | |
| *** mtanino has quit IRC | 01:32 | |
| *** jasonsb has joined #openstack-manila | 01:33 | |
| *** yangyapeng has joined #openstack-manila | 01:34 | |
| openstackgerrit | Clinton Knight proposed openstack/manila: Add preferred flag to export location metadata https://review.openstack.org/282070 | 01:35 |
| *** haomaiwang has joined #openstack-manila | 01:59 | |
| *** haomaiwang has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-manila | 02:01 | |
| openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Support preferred export locations in Manila CLI https://review.openstack.org/284499 | 02:16 |
| *** erlon has quit IRC | 02:16 | |
| *** houming has joined #openstack-manila | 02:26 | |
| *** vbellur has joined #openstack-manila | 02:26 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-manila | 03:01 | |
| *** akerr_ has quit IRC | 03:24 | |
| *** vbellur has quit IRC | 03:30 | |
| *** vbellur has joined #openstack-manila | 03:38 | |
| *** vbellur has left #openstack-manila | 03:39 | |
| *** chlong_ has quit IRC | 03:47 | |
| *** chlong_ has joined #openstack-manila | 03:49 | |
| *** qeelee has quit IRC | 04:00 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwa_ has joined #openstack-manila | 04:01 | |
| openstackgerrit | xing-yang proposed openstack/python-manilaclient: CLI for manage/unmanage snapshot https://review.openstack.org/249544 | 04:16 |
| *** gouthamr has quit IRC | 04:17 | |
| openstackgerrit | xing-yang proposed openstack/manila: Manage and unmanage snapshot https://review.openstack.org/249542 | 04:20 |
| openstackgerrit | Clinton Knight proposed openstack/python-manilaclient: Support preferred export locations in Manila CLI https://review.openstack.org/284499 | 04:28 |
| *** haomaiwa_ has quit IRC | 04:30 | |
| *** merooney_ has quit IRC | 04:31 | |
| *** haomaiwa_ has joined #openstack-manila | 04:39 | |
| *** qeelee has joined #openstack-manila | 04:59 | |
| openstackgerrit | xing-yang proposed openstack/manila: Manage and unmanage snapshot https://review.openstack.org/249542 | 04:59 |
| *** cknight1 has quit IRC | 04:59 | |
| *** haomaiwa_ has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-manila | 05:01 | |
| *** qeelee has quit IRC | 05:10 | |
| *** sgotliv has joined #openstack-manila | 05:23 | |
| *** cknight has joined #openstack-manila | 05:35 | |
| *** cknight has quit IRC | 05:46 | |
| *** qeelee has joined #openstack-manila | 05:49 | |
| *** nidhimittalhada has joined #openstack-manila | 05:57 | |
| *** nkrinner has joined #openstack-manila | 05:58 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-manila | 06:01 | |
| *** cknight has joined #openstack-manila | 06:27 | |
| *** nidhimittalhada has quit IRC | 06:32 | |
| *** nidhimittalhada has joined #openstack-manila | 06:33 | |
| nidhimittalhada | @vponomaryov: ping | 06:34 |
| *** cknight has quit IRC | 06:46 | |
| *** qeelee_ has joined #openstack-manila | 06:50 | |
| *** qeelee has quit IRC | 06:50 | |
| *** qeelee_ is now known as qeelee | 06:50 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-manila | 07:01 | |
| *** jasonsb has quit IRC | 07:02 | |
| *** lpetrut has joined #openstack-manila | 07:19 | |
| openstackgerrit | Béla Vancsics proposed openstack/manila: Use assertIsNone instead of assertEqual(None, ***) https://review.openstack.org/284124 | 07:22 |
| *** ociuhandu has joined #openstack-manila | 07:30 | |
| *** ociuhandu has quit IRC | 07:31 | |
| *** ociuhandu has joined #openstack-manila | 07:32 | |
| *** ociuhandu has quit IRC | 07:49 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwa_ has joined #openstack-manila | 08:01 | |
| openstackgerrit | zhaohua proposed openstack/manila: Huawei driver improve support of StandaloneNetworkPlugin https://review.openstack.org/284033 | 08:12 |
| *** lpetrut has quit IRC | 08:13 | |
| openstackgerrit | liucheng proposed openstack/manila: Update Huawei driver doc for Mitaka https://review.openstack.org/284581 | 08:16 |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: LXC/LXD driver https://review.openstack.org/245751 | 08:18 |
| *** sbjorn has joined #openstack-manila | 08:30 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] Do not merge me please https://review.openstack.org/284589 | 08:34 |
| *** rraja has joined #openstack-manila | 08:47 | |
| *** haomaiwa_ has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-manila | 09:01 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] Do not merge me please https://review.openstack.org/284589 | 09:08 |
| *** yangyapeng has quit IRC | 09:21 | |
| csaba | vponomaryov: ping | 09:33 |
| *** yangyapeng has joined #openstack-manila | 09:35 | |
| openstackgerrit | Csaba Henk proposed openstack/manila: gluster*: clean up volume option querying https://review.openstack.org/277141 | 09:44 |
| *** haomaiw__ has joined #openstack-manila | 09:48 | |
| *** haomaiwang has quit IRC | 09:49 | |
| *** qeelee has quit IRC | 09:51 | |
| *** haomaiw__ has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-manila | 10:01 | |
| *** nidhimittalhada has quit IRC | 10:02 | |
| *** yangyapeng has quit IRC | 10:12 | |
| *** zhongjun has joined #openstack-manila | 10:15 | |
| *** zhongjun2 has quit IRC | 10:18 | |
| *** qeelee has joined #openstack-manila | 10:19 | |
| *** qeelee has quit IRC | 10:31 | |
| openstackgerrit | Thomas Bechtold proposed openstack/manila: Improve exception msg when attaching/detaching volumes https://review.openstack.org/282220 | 10:33 |
| *** lpetrut has joined #openstack-manila | 10:39 | |
| vponomaryov | csaba: pong | 10:39 |
| csaba | vponomaryov: it's OK, I solved my problem | 10:39 |
| vponomaryov | csaba: say it was breakage of our CI an everything works ok now | 10:40 |
| toabctl | vponomaryov: do you know already a solution for the manilaclient gating problems? problem is when creating a neutron network: "An auth plugin is required to fetch a token" | 10:41 |
| *** pcaruana has joined #openstack-manila | 10:42 | |
| vponomaryov | toabctl: didn't dig up the roots of this problem, Manila is broken too | 10:42 |
| toabctl | vponomaryov: yeah :( | 10:42 |
| vponomaryov | I looove OpenStack )) | 10:42 |
| toabctl | lol | 10:43 |
| csaba | vponomaryov: I'm actually grateful this time for the CI breakage as it held back a 2*+2-d change from merger which was found to have an issue. | 10:43 |
| vponomaryov | everything that is done is done for a sake goodness, huh? )) | 10:44 |
| *** aovchinnikov has joined #openstack-manila | 10:58 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-manila | 11:01 | |
| *** ganso has joined #openstack-manila | 11:08 | |
| *** erlon has joined #openstack-manila | 11:20 | |
| *** houming has quit IRC | 11:31 | |
| ganso | vponomaryov: ping | 11:44 |
| vponomaryov | ganso: yees? | 11:45 |
| ganso | vponomaryov: Hello Valeriy. I see gates seem to be broken. Are you aware of any discussion around this issue? | 11:46 |
| vponomaryov | ganso: hello Rodrigo, yes, I am aware | 11:46 |
| ganso | vponomaryov: looks like this time it affected several projects | 11:47 |
| vponomaryov | ganso: devstack-gate projects breaks all who install sqlalchemy-utils lib | 11:47 |
| vponomaryov | s/projects/project/ | 11:47 |
| vponomaryov | ganso: so, keep calm and don't worry )) | 11:47 |
| vponomaryov | ganso; we are not alone )) | 11:47 |
| ganso | vponomaryov: hehe we are definitely not alone. Thanks! | 11:48 |
| vponomaryov | merge of https://review.openstack.org/#/c/284652/ potentially should fix gates | 11:52 |
| ganso | vponomaryov: =D | 11:54 |
| *** tpsilva has joined #openstack-manila | 11:58 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** haomaiwang has joined #openstack-manila | 12:01 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Do not merge] Test LVM mount capability https://review.openstack.org/282507 | 12:04 |
| openstackgerrit | zhaohua proposed openstack/manila: Huawei driver: change cifs rw to full control https://review.openstack.org/284675 | 12:06 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Do not merge] Test LVM mount capability https://review.openstack.org/282507 | 12:07 |
| *** fthiagogv has quit IRC | 12:10 | |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: [DEBUG] Test LVM share migration https://review.openstack.org/284676 | 12:11 |
| *** adrianofr_ has joined #openstack-manila | 12:11 | |
| openstackgerrit | Tiago Pasqualini da Silva proposed openstack/manila: [DEBUG] Test LVM share migration https://review.openstack.org/284676 | 12:16 |
| openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs/common: don't suppress vol set errors https://review.openstack.org/284683 | 12:20 |
| openstackgerrit | zhaohua proposed openstack/manila: Huawei driver: change CIFS rw to full control https://review.openstack.org/284675 | 12:25 |
| *** haomaiwang has quit IRC | 12:31 | |
| openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: LXC/LXD driver https://review.openstack.org/245751 | 12:33 |
| ganso | vponomaryov: looks like neutron lbaas fix breaks our non-postgres jobs | 12:36 |
| vponomaryov | ganso: imposibru! | 12:37 |
| vponomaryov | ganso: what are your proofs? | 12:37 |
| *** yangyapeng has joined #openstack-manila | 12:37 | |
| ganso | vponomaryov: Zuul: 282507,10 | 12:37 |
| ganso | vponomaryov: logs of neutron-multibackend jobs available at http://logs.openstack.org/07/282507/10/check/gate-manila-tempest-dsvm-neutron-multibackend/635ad3d/ | 12:38 |
| vponomaryov | ganso: yeah | 12:42 |
| vponomaryov | ganso: but i expect it to fail in their logs too | 12:43 |
| vponomaryov | ganso: need just to wait infra fix get in | 12:43 |
| ganso | vponomaryov: yup, then we can recheck their patch | 12:44 |
| *** fthiagogv has joined #openstack-manila | 12:53 | |
| *** pcaruana has quit IRC | 12:55 | |
| *** akerr has joined #openstack-manila | 13:00 | |
| openstackgerrit | xing-yang proposed openstack/manila: Manage and unmanage snapshot https://review.openstack.org/249542 | 13:03 |
| *** yangyapeng has quit IRC | 13:08 | |
| *** pcaruana has joined #openstack-manila | 13:09 | |
| *** yangyapeng has joined #openstack-manila | 13:09 | |
| *** yangyape_ has joined #openstack-manila | 13:13 | |
| *** yangyapeng has quit IRC | 13:16 | |
| *** timcl has joined #openstack-manila | 13:17 | |
| *** gouthamr has joined #openstack-manila | 13:22 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Do not merge] Test LVM mount capability https://review.openstack.org/282507 | 13:23 |
| vponomaryov | gouthamr: ping | 13:34 |
| vponomaryov | gouthamr: I think I found significant bug | 13:34 |
| vponomaryov | gouthamr: in replication "promote" operation | 13:35 |
| vponomaryov | gouthamr: If I have three replicas, two secondary and one active and promote one of secondaries, the one replica that is not being promoted/degreded becomes Deleted in DB | 13:36 |
| gouthamr | vponomaryov: pong | 13:36 |
| vponomaryov | gouthamr: can you please check it with NetApp driver? | 13:36 |
| vponomaryov | gouthamr: "delete_replica" even not called | 13:36 |
| gouthamr | vponomaryov: that's strange, i;ve checked that workflow with the netapp driver | 13:37 |
| vponomaryov | with which code? | 13:37 |
| gouthamr | vponomaryov: we've done stress tests with upto 6 secondary replicas.. | 13:37 |
| vponomaryov | I used as a base this - https://review.openstack.org/#/c/282081/3 | 13:37 |
| gouthamr | vponomaryov: the cDot driver impl is based off of the same.. | 13:38 |
| vponomaryov | gouthamr: bug is definitely exist and out of a driver | 13:38 |
| vponomaryov | gouthamr: either share manager or API | 13:38 |
| vponomaryov | gouthamr: need to dig it up | 13:38 |
| gouthamr | vponomaryov: happy to help test it. i've the latest code for the scheduler and the Admin APIs and am sorry couldn't push it up yesterday | 13:39 |
| gouthamr | vponomaryov: we've a bug that broke our CI.. i'll try getting them up asap | 13:40 |
| vponomaryov | gouthamr: oh, wait, it is not deleted, it is not listed | 13:42 |
| vponomaryov | gouthamr: after "promote", listed only those who were changed | 13:43 |
| gouthamr | vponomaryov: you mean, the API didn't list it? | 13:44 |
| vponomaryov | gouthamr: yes | 13:44 |
| gouthamr | vponomaryov: that's indeed weird... oh wait, are you passing an updated replica list/ | 13:44 |
| vponomaryov | gouthamr: yes | 13:45 |
| gouthamr | vponomaryov: if yes, did you return replica_state=None | 13:45 |
| vponomaryov | gouthamr: those which are unchanged just did not have it | 13:46 |
| vponomaryov | gouthamr: and it is expected from my perspective | 13:46 |
| vponomaryov | gouthamr: return only updated stuff | 13:46 |
| gouthamr | vponomaryov: ugh. indeed a bug :( | 13:48 |
| gouthamr | vponomaryov: thanks for pointing it out, i was handling a similar condition in update_replica_state but not here. i'll fix it in the admin APIs patch | 13:48 |
| vponomaryov | gouthamr: yes, according to Db method you filter out None, but allow to write it and write when not expected | 13:48 |
| gouthamr | vponomaryov: not sanity checking the replica_state update. bummer | 13:49 |
| *** martyturner has joined #openstack-manila | 13:50 | |
| vponomaryov | ganso: as we can see, Neutron fix is not a fix yet )) | 13:51 |
| vponomaryov | ganso; oh, it should "sadness" - :-( | 13:51 |
| ganso | vponomaryov: yes =( | 13:51 |
| vponomaryov | ganso; but you still can test LVM )) | 13:52 |
| *** xyang1 has joined #openstack-manila | 13:52 | |
| ganso | vponomaryov: yes, I am testing LVM in separate patches... if I want to test neutron-multibackend, I do not use depends-on, then in a debug patch, I use a depends-on | 13:52 |
| vponomaryov | ganso: be flexible like a snake and smashing like a tiger | 13:53 |
| *** JoseMello has joined #openstack-manila | 13:55 | |
| ganso | vponomaryov: =D | 13:55 |
| vponomaryov | this is the only possible way to survive in bug-apocalypse )) | 13:56 |
| *** porrua has joined #openstack-manila | 14:00 | |
| ganso | vponomaryov: gotta be armed to the teeth =) | 14:02 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Add ZFSonLinux share driver https://review.openstack.org/277192 | 14:09 |
| gouthamr | vponomaryov: kung fu panda? | 14:10 |
| vponomaryov | gouthamr: master Shifu )) | 14:11 |
| gouthamr | vponomaryov: hahaha keep it coming! | 14:13 |
| *** merooney has joined #openstack-manila | 14:20 | |
| *** ata has joined #openstack-manila | 14:20 | |
| *** ata is now known as Guest14459 | 14:21 | |
| *** Guest14459 has quit IRC | 14:22 | |
| *** a_ta has joined #openstack-manila | 14:23 | |
| *** cknight has joined #openstack-manila | 14:39 | |
| *** dustins has joined #openstack-manila | 14:39 | |
| *** Yogi1 has joined #openstack-manila | 14:47 | |
| *** markstur_ has joined #openstack-manila | 14:54 | |
| *** merooney has quit IRC | 14:56 | |
| *** eharney has joined #openstack-manila | 15:00 | |
| *** merooney has joined #openstack-manila | 15:01 | |
| *** nkrinner has quit IRC | 15:16 | |
| *** merooney has quit IRC | 15:18 | |
| *** merooney has joined #openstack-manila | 15:23 | |
| *** zhongjun2 has joined #openstack-manila | 15:23 | |
| *** a_ta__ has joined #openstack-manila | 15:26 | |
| *** zhongjun has quit IRC | 15:27 | |
| *** a_ta has quit IRC | 15:27 | |
| openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs.common: move the numreduct function to toplevel https://review.openstack.org/282069 | 15:33 |
| openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs_native: relocate module under glusterfs https://review.openstack.org/280935 | 15:33 |
| openstackgerrit | Csaba Henk proposed openstack/manila: gluster*: clean up volume option querying https://review.openstack.org/277141 | 15:33 |
| *** Yogi1 has quit IRC | 15:34 | |
| *** mtanino has joined #openstack-manila | 15:43 | |
| *** kaisers_ has joined #openstack-manila | 15:45 | |
| *** aorourke-afk is now known as aorourke | 15:49 | |
| *** mtanino has quit IRC | 15:52 | |
| *** kaisers_ has quit IRC | 15:57 | |
| *** alkhodos_ has quit IRC | 15:58 | |
| *** kaisers_ has joined #openstack-manila | 15:58 | |
| *** kaisers_ has quit IRC | 15:59 | |
| openstackgerrit | xing-yang proposed openstack/manila: Manage and unmanage snapshot https://review.openstack.org/249542 | 15:59 |
| *** jasonsb has joined #openstack-manila | 15:59 | |
| *** merooney has quit IRC | 15:59 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add Replication admin APIs and driver i/f changes https://review.openstack.org/282081 | 16:00 |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Scheduler enhancements for Share Replication https://review.openstack.org/277545 | 16:00 |
| *** a_ta__ has quit IRC | 16:00 | |
| *** timcl1 has joined #openstack-manila | 16:01 | |
| *** markstur_ has quit IRC | 16:01 | |
| *** a_ta has joined #openstack-manila | 16:01 | |
| *** timcl has quit IRC | 16:03 | |
| *** mtanino has joined #openstack-manila | 16:03 | |
| *** merooney has joined #openstack-manila | 16:03 | |
| xyang1 | vponomaryov: hi, I addressed your 4 comments https://review.openstack.org/#/c/249542/ | 16:06 |
| xyang1 | vponomaryov: can you take a look | 16:06 |
| *** dencaval has quit IRC | 16:06 | |
| vponomaryov | xyang1: looking | 16:06 |
| xyang1 | vponomaryov: thanks | 16:06 |
| dustins | bswartz: So, about that LVM thing... | 16:07 |
| *** dencaval has joined #openstack-manila | 16:07 | |
| *** aovchinnikov has quit IRC | 16:07 | |
| *** rraja has quit IRC | 16:09 | |
| bswartz | dustins: yes let me find the changes you need to look at | 16:10 |
| vponomaryov | xyang1: does gerrit lag for you? | 16:10 |
| bswartz | gerrit lags | 16:10 |
| xyang1 | vponomaryov: it has not run yet after I last submission | 16:11 |
| dustins | bswartz: Sounds good | 16:11 |
| xyang1 | vponomaryov: it is very slow | 16:11 |
| bswartz | dustins: this one shows how to test with the neutron+postgres bug fixed https://review.openstack.org/#/c/283939/ | 16:11 |
| vponomaryov | xyang1: it becomes a challenge to just view your changes )) | 16:11 |
| xyang1 | vponomaryov: ya | 16:11 |
| bswartz | dustins: this shows multiple successful runs with concurrency=1 https://review.openstack.org/#/c/276560/ | 16:12 |
| *** merooney has quit IRC | 16:12 | |
| xyang1 | vponomaryov: or you can just believe everything I told you:) | 16:13 |
| vponomaryov | xyang1: desscribe it, in two words | 16:13 |
| bswartz | dustins: to find the failures, we need to go back before neutron caused the postgres bugs and find patches that failed the lvm job but succeeded other jobs | 16:13 |
| bswartz | and check the logs for those failures | 16:13 |
| vponomaryov | xyang1: everyhing works? )) | 16:13 |
| bswartz | you can see which test lvm failed -- IIRC it was just 1 test | 16:13 |
| vponomaryov | dustins: you can use "logstash" for statistics | 16:13 |
| xyang1 | vponomaryov: I addressed the 4 comments I missed earlier | 16:14 |
| dustins | bswartz: Time to get my investigator hat on | 16:14 |
| dustins | vponomaryov: What's logstash? I honestly haven't heard of it | 16:14 |
| vponomaryov | dustins: http://logstash.openstack.org/ | 16:15 |
| vponomaryov | dustins: it allows to search logs by tags, filenames, messages in logs, etc | 16:15 |
| vponomaryov | dustins: for specific period of time | 16:15 |
| dustins | O_O | 16:15 |
| dustins | How have I not known about this?! | 16:15 |
| bswartz | dustins: here is 1 example: http://logs.openstack.org/51/245751/18/check/gate-manila-tempest-dsvm-neutron-postgres-lvm-multibackend/4c9df1f/ | 16:15 |
| vponomaryov | dustins: you just took your hat | 16:16 |
| vponomaryov | dustins: forgot? | 16:16 |
| vponomaryov | dustins: it works! | 16:16 |
| xyang1 | vponomaryov: it has passed Jenkins in patch set 65. the only thing I added after that was the new negative tempest test and addressing your comments | 16:16 |
| vponomaryov | xyang1: so, tempest tests require deep analysis | 16:16 |
| xyang1 | vponomaryov: the new test | 16:17 |
| vponomaryov | xyang1: dear, students, check of tests will take a while, please, be patient | 16:17 |
| dustins | Okay, looks like I know what I'm looking for, thanks bswartz and vponomaryov | 16:17 |
| xyang1 | vponomaryov: pretty easy task for you:). does it take long | 16:18 |
| vponomaryov | xyang1: in the end of the day? | 16:19 |
| vponomaryov | xyang1: ageeees | 16:19 |
| xyang1 | vponomaryov: sure | 16:19 |
| *** timcl1 has quit IRC | 16:19 | |
| *** a_ta has quit IRC | 16:20 | |
| openstackgerrit | John Spray proposed openstack/manila: Add Ceph Native driver https://review.openstack.org/270211 | 16:22 |
| bswartz | vponomaryov: https://review.openstack.org/284790 | 16:23 |
| *** haomaiwa_ has joined #openstack-manila | 16:24 | |
| *** a_ta has joined #openstack-manila | 16:24 | |
| *** lpabon has joined #openstack-manila | 16:28 | |
| *** merooney has joined #openstack-manila | 16:36 | |
| *** merooney has quit IRC | 16:38 | |
| *** JoseMello has quit IRC | 16:38 | |
| *** sgotliv has quit IRC | 16:39 | |
| *** timcl has joined #openstack-manila | 16:40 | |
| *** JoseMello has joined #openstack-manila | 16:41 | |
| *** bob___ has joined #openstack-manila | 16:41 | |
| bob___ | hello guys, what manila agent talks to openvswitch? | 16:41 |
| *** absubram has joined #openstack-manila | 16:43 | |
| *** lpabon has left #openstack-manila | 16:43 | |
| *** limamauricio has joined #openstack-manila | 16:45 | |
| *** limamauricio has left #openstack-manila | 16:45 | |
| vponomaryov | bob___: Manila agent? Manila does nto have agents | 16:49 |
| bob___ | sorry, neutron agents | 16:49 |
| bob___ | sorry, my bad | 16:49 |
| bob___ | my question is, why manila needs use openvswitch? | 16:50 |
| vponomaryov | bob__: only one driver needs it | 16:50 |
| vponomaryov | bob___: Generic share driver that uses Nova and Cinder | 16:50 |
| vponomaryov | bob___: and Windows driver too, it uses Nova and Cinder too | 16:50 |
| bob___ | hmm | 16:50 |
| bob___ | thank so much | 16:51 |
| vponomaryov | bob___: it connects manila-share service host to neutron networks | 16:51 |
| vponomaryov | bob___: to be able to talk to service VMs | 16:51 |
| vponomaryov | xyang1: tempest part looks ok, looking further | 16:52 |
| xyang1 | vponomaryov: thanks | 16:53 |
| bob___ | vponomaryov, thank so much :) | 16:53 |
| *** haomaiwa_ has quit IRC | 17:01 | |
| *** esker has quit IRC | 17:01 | |
| *** haomaiwang has joined #openstack-manila | 17:01 | |
| openstackgerrit | Ronald Bradford proposed openstack/manila: Subclass context from oslo_context base class https://review.openstack.org/284819 | 17:11 |
| vponomaryov | xtang1: https://review.openstack.org/#/c/249542/69/manila/share/manager.py, lines 1408-1418 | 17:14 |
| vponomaryov | xyang1: ^ | 17:14 |
| xyang1 | vponomaryov: hi, looking | 17:14 |
| *** timcl has quit IRC | 17:14 | |
| vponomaryov | xyang1: it looks veeeery strange | 17:15 |
| xyang1 | vponomaryov: you want me to remove the try except? | 17:16 |
| vponomaryov | xyang1: this part wil make everyone make face o.O | 17:17 |
| xyang1 | vponomaryov: I followed the code in manage share | 17:17 |
| vponomaryov | xyang1: but raise of your exception is the only part of try block where you exactly this exception | 17:18 |
| vponomaryov | s/you/ you catch/ | 17:18 |
| xyang1 | vponomaryov: I am looking at this again, but this is handling the similar way as unmanage share | 17:22 |
| xyang1 | vponomaryov: what is your suggestion | 17:23 |
| vponomaryov | xyang1: if merge it as it is now, someone else will use it as reference | 17:23 |
| vponomaryov | xyang1: it is just wrong thing to do | 17:23 |
| vponomaryov | xyang1: try block is redundant there | 17:23 |
| xyang1 | vponomaryov: what do you mean? remove try except block | 17:24 |
| vponomaryov | xyang1: yes | 17:24 |
| xyang1 | vponomaryov: this is the same as unmanage share, why is it a problem | 17:24 |
| xyang1 | vponomaryov: I break it into multiple try except blocks | 17:25 |
| xyang1 | vponomaryov: due to other review comments | 17:25 |
| vponomaryov | xyang1: your code does nmot have call of driver method | 17:25 |
| vponomaryov | xyang1: original one has | 17:25 |
| xyang1 | vponomaryov: line 1437 | 17:26 |
| vponomaryov | xyang1: and yes, there is, even in original case, only driver call should be | 17:26 |
| vponomaryov | xyang1: I am talking about top part | 17:26 |
| vponomaryov | xyang1: 1408-1418, as mentioned above | 17:26 |
| vponomaryov | xyang1: 1432-1435 does not include driver call and should be moved out of try block too | 17:27 |
| xyang1 | vponomaryov: I can change it but this code has passed tempest test earlier (except for the newly added negative test) | 17:28 |
| vponomaryov | xyang1: you make me cruel )) | 17:28 |
| xyang1 | vponomaryov: do you mean move checks out of try except, but keep driver.unmanage_snapshot inside try except | 17:30 |
| *** merooney has joined #openstack-manila | 17:30 | |
| vponomaryov | xyang1: actually, it will require rework, because on line 1435 exception is raised that is suppressed right after raise | 17:31 |
| xyang1 | vponomaryov: same as unmanage share | 17:32 |
| vponomaryov | xyang1: that says "raise of exception is redundant" | 17:32 |
| xyang1 | vponomaryov: can you explain why unmanage handles it that way but it is wrong here | 17:32 |
| xyang1 | unmanage share | 17:32 |
| vponomaryov | xyang1: both wrong )) | 17:32 |
| xyang1 | vponomaryov: good answer:) | 17:33 |
| vponomaryov | xyang1: yeah )) | 17:33 |
| vponomaryov | xyang1: does it make you feel better? ) | 17:33 |
| xyang1 | vponomaryov: yes:) | 17:33 |
| openstackgerrit | Ronald Bradford proposed openstack/manila: Subclass context from oslo_context base class https://review.openstack.org/284819 | 17:33 |
| vponomaryov | xyang1: ok, I will not insist on it, but would like to see it fixed | 17:34 |
| xyang1 | vponomaryov: do you still want unmanage snapshot driver call to be inside try except | 17:34 |
| *** dencaval has quit IRC | 17:35 | |
| vponomaryov | xyang1: it is up to open item - should we suppress error of unmanage operation as it is done now? | 17:35 |
| xyang1 | vponomaryov: if you ask me, my anwser is no | 17:36 |
| vponomaryov | xyang1: for the moment it is so | 17:36 |
| vponomaryov | xyang1: we just cannot fail unmanage operation | 17:36 |
| vponomaryov | xyang1: from driver perspective | 17:36 |
| xyang1 | vponomaryov: so we should only fail is driver mode is wrong | 17:37 |
| vponomaryov | xyang1: so, try block could be for writing some Db data, but suppress or not - open question | 17:37 |
| xyang1 | vponomaryov: what do you want me to change to? | 17:39 |
| xyang1 | vponomaryov: do we need to talk to bswartz ? | 17:39 |
| vponomaryov | xyang1: probably yes | 17:39 |
| vponomaryov | xyang1: but we can leave it as is until it is tested by plenty of people | 17:40 |
| xyang1 | bswartz: around? | 17:40 |
| vponomaryov | xyang1: don't you think we should make it "experimental API"? | 17:40 |
| xyang1 | vponomaryov: why experimental? | 17:40 |
| *** jasonsb has quit IRC | 17:41 | |
| vponomaryov | xyang1: new unstested feature | 17:41 |
| xyang1 | vponomaryov: it works, | 17:41 |
| vponomaryov | xyang1: all APIs works | 17:41 |
| xyang1 | vponomaryov: cknight tested with his driver | 17:41 |
| vponomaryov | xyang1: but they tend to be changed | 17:41 |
| xyang1 | vponomaryov: Can we sort out the original question first? | 17:41 |
| xyang1 | vponomaryov: what do you want me to change in manager.py | 17:42 |
| xyang1 | vponomaryov: stay unchanged sibce you said they are open questions | 17:42 |
| vponomaryov | xyang1: in general - do not do redundant coding | 17:43 |
| xyang1 | s/sibce/since | 17:43 |
| xyang1 | vponomaryov: what is redundant | 17:43 |
| vponomaryov | xyang1: usage of try block on 1408-1418 | 17:43 |
| xyang1 | vponomaryov: raise exception but catch it and return? | 17:43 |
| vponomaryov | xyang1: yes, catch of exception that is raised explicitly | 17:44 |
| xyang1 | vponomaryov: so this one should throw exception, don't catch it | 17:44 |
| openstackgerrit | Andrea Ma proposed openstack/manila: glusterManager instantiation regexp validation https://review.openstack.org/283777 | 17:44 |
| xyang1 | vponomaryov: is this what you mean | 17:44 |
| vponomaryov | xyang1: that part does not raise exception for outside | 17:45 |
| vponomaryov | xyang1: it returns | 17:45 |
| vponomaryov | xyang1: so, presense of conditions would be enough | 17:45 |
| xyang1 | vponomaryov: ok, so change status to error, but return | 17:46 |
| *** dencaval has joined #openstack-manila | 17:47 | |
| vponomaryov | xyang1: things that are done there - if DHSS=True, update DB with error, log error and return | 17:47 |
| *** dencaval has quit IRC | 17:47 | |
| vponomaryov | xyang1: try block is not required at all to do all these stuff | 17:47 |
| vponomaryov | xyang1: please, do not hate me ))) as mentioned above, I do not insist on it, as logic stays the same | 17:48 |
| xyang1 | vponomaryov: I won't hate you:). thanks for your review! | 17:49 |
| vponomaryov | xyang1: glad to hear it )), also small thing here - https://review.openstack.org/#/c/249542/69/manila/api/v2/share_snapshots.py | 17:53 |
| xyang1 | vponomaryov: got it, I will that to Mixin | 17:55 |
| vponomaryov | xyang1: so, in case of API, you could just inherit whole class and add manage stuff in new one | 17:55 |
| vponomaryov | xyang1: it will take less code cahnges | 17:55 |
| vponomaryov | xyang1: original manage API was done so, because it had two other differences that do not exist here | 17:56 |
| vponomaryov | xyang1: - separate modules and presense in APiv1 | 17:56 |
| vponomaryov | xyang1: your new "manage" has neither of these | 17:57 |
| xyang1 | vponomaryov: reset and force delete should still be in v2, no? | 17:57 |
| xyang1 | vponomaryov: there was nothing in v2 before | 17:57 |
| vponomaryov | xyang1: yes, all 2.x related APis can be moved | 17:57 |
| vponomaryov | xyang1: to new class | 17:57 |
| xyang1 | vponomaryov: I don't think I understand you completely | 17:58 |
| xyang1 | vponomaryov: what should call the new class | 17:59 |
| xyang1 | the name | 17:59 |
| vponomaryov | xyang1: idea in sources of both API classes | 18:00 |
| *** timcl has joined #openstack-manila | 18:00 | |
| vponomaryov | xyang1: two mentioned reasons - reason for having mixin | 18:00 |
| vponomaryov | xyang1: you just do not need to do "manage snapshot" APis in the same way as it is coded for "manage share" | 18:00 |
| vponomaryov | xyang1: because of mentioned two reasons | 18:00 |
| vponomaryov | xyang1: in your case it should be simplier | 18:00 |
| *** haomaiwang has quit IRC | 18:01 | |
| vponomaryov | xyang1: added comments there | 18:01 |
| *** haomaiwang has joined #openstack-manila | 18:01 | |
| vponomaryov | xyang1: but these comments do make logic change too | 18:02 |
| vponomaryov | xyang1: just coding-related stuff | 18:02 |
| xyang1 | vponomaryov: those are v2 apis too | 18:02 |
| xyang1 | vponomaryov: why move to v1 | 18:02 |
| vponomaryov | xyang1: "force_delete" legacy one exist in V1 | 18:03 |
| vponomaryov | xyang1: and can be reused | 18:03 |
| vponomaryov | xyang1: keeping range of API versions as was | 18:04 |
| vponomaryov | xyang1: 1.0-2.6 | 18:04 |
| vponomaryov | xyang1: and then just inherit it | 18:04 |
| openstackgerrit | Yogesh proposed openstack/manila: Add tempest tests for Share Replication https://review.openstack.org/244843 | 18:06 |
| xyang1 | vponomaryov: let me change it and you can tell me if it is what you wanted | 18:07 |
| *** lpetrut has quit IRC | 18:08 | |
| *** a_ta has quit IRC | 18:11 | |
| *** a_ta has joined #openstack-manila | 18:12 | |
| *** vbellur has joined #openstack-manila | 18:14 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Do not merge] Test LVM mount capability https://review.openstack.org/282507 | 18:14 |
| *** a_ta has quit IRC | 18:16 | |
| openstackgerrit | xing-yang proposed openstack/manila: Manage and unmanage snapshot https://review.openstack.org/249542 | 18:16 |
| xyang1 | vponomaryov: can you check to see if I changed correctly | 18:17 |
| xyang1 | vponomaryov: have not run unit tests yet. Want to make sure I fixed things first | 18:18 |
| vponomaryov | xyang1: mixin class now inherited only by v1 | 18:29 |
| vponomaryov | xyang1: so, mixin should not be added | 18:29 |
| xyang1 | vponomaryov: fine, what about everything else | 18:30 |
| vponomaryov | xyang1: lgtm | 18:32 |
| xyang1 | vponomaryov: ok, let me remove Mixin and fix unit tests, thanks | 18:32 |
| vponomaryov | xyang1: you are welcome )) | 18:32 |
| *** haomaiwang has quit IRC | 18:39 | |
| *** haomaiwang has joined #openstack-manila | 18:44 | |
| vponomaryov | goutham: ping | 18:47 |
| gouthamr | vponomaryov: pong | 18:47 |
| gouthamr | vponomaryov: what time is it? | 18:47 |
| vponomaryov | gouthamr: where? )) | 18:47 |
| gouthamr | vponomaryov: nvm, 8:47 PM | 18:47 |
| gouthamr | vponomaryov: waddup | 18:48 |
| vponomaryov | gouthamr: you wanted to disable scheduling of replcia to the same pool | 18:48 |
| vponomaryov | gouthamr: changed mind? | 18:48 |
| gouthamr | vponomaryov: yes spoke to bswartz about it; he said that's something that AZs should solve and not the replication filter | 18:48 |
| vponomaryov | ok | 18:49 |
| vponomaryov | gouthamr: that's all )) | 18:49 |
| *** haomaiwang has quit IRC | 18:49 | |
| gouthamr | vponomaryov: np! i'm going to test your replication CRUD today hopefully; | 18:49 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Add ZFSonLinux share driver https://review.openstack.org/277192 | 18:50 |
| vponomaryov | gouthamr: will upload one more PS and can be tested | 18:51 |
| gouthamr | vponomaryov: awesome. | 18:51 |
| *** merooney has quit IRC | 18:51 | |
| *** lpetrut has joined #openstack-manila | 18:56 | |
| *** cknight has quit IRC | 18:57 | |
| *** cknight has joined #openstack-manila | 18:58 | |
| *** merooney has joined #openstack-manila | 18:59 | |
| *** esker has joined #openstack-manila | 19:01 | |
| openstackgerrit | Clinton Knight proposed openstack/manila: Fix NetApp cDOT driver update_access negative test https://review.openstack.org/284877 | 19:03 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Add ZFSonLinux share driver https://review.openstack.org/277192 | 19:08 |
| vponomaryov | gouthamr: I finished for today with ZFS ^ | 19:09 |
| openstackgerrit | Diem Tran proposed openstack/manila: Add share resize support to Oracle ZFSSA driver https://review.openstack.org/273935 | 19:09 |
| vponomaryov | bswartz: shouldn't https://blueprints.launchpad.net/manila/+spec/new-share-access-driver-interface be marked as "implemented" | 19:12 |
| vponomaryov | and https://blueprints.launchpad.net/manila/+spec/manila-share-replication | 19:12 |
| gouthamr | vponomaryov: thanks. https://blueprints.launchpad.net/manila/+spec/manila-share-replication is waiting for the tempest tests to be merged | 19:14 |
| *** Yogi1 has joined #openstack-manila | 19:17 | |
| *** JoseMello has quit IRC | 19:18 | |
| openstackgerrit | Ronald Bradford proposed openstack/manila: Define context.roles with base class https://review.openstack.org/284898 | 19:38 |
| *** haomaiwang has joined #openstack-manila | 19:45 | |
| *** lpetrut has quit IRC | 19:48 | |
| *** krotscheck is now known as krotscheck_dcm | 19:50 | |
| *** timcl has quit IRC | 19:51 | |
| *** martyturner has quit IRC | 19:52 | |
| *** haomaiwang has quit IRC | 19:53 | |
| *** lpetrut has joined #openstack-manila | 19:54 | |
| *** timcl has joined #openstack-manila | 19:55 | |
| *** Yogi1 has quit IRC | 19:56 | |
| *** sedwards has joined #openstack-manila | 19:58 | |
| *** porrua has quit IRC | 19:59 | |
| *** a_ta has joined #openstack-manila | 19:59 | |
| *** porrua has joined #openstack-manila | 19:59 | |
| *** martyturner has joined #openstack-manila | 19:59 | |
| *** porrua has quit IRC | 20:02 | |
| *** porrua has joined #openstack-manila | 20:03 | |
| *** a_ta has quit IRC | 20:04 | |
| bswartz | gouthamr: ping | 20:19 |
| bswartz | gouthamr: I didn't understand your earlier comment about the AZ filter | 20:19 |
| bswartz | I think we need proper filtering by AZ, but when the replica is in the same AZ we should still do the right thing | 20:20 |
| *** esker has quit IRC | 20:21 | |
| ganso | cknight, bswartz, xyang1, markstur: Could you please take a look at https://review.openstack.org/#/c/278699/, https://review.openstack.org/#/c/244286/ and https://review.openstack.org/#/c/250515 when you have some time? Thanks in advance | 20:29 |
| cknight | ganso: yes, the migration stuff is still on my list to review | 20:30 |
| *** a_ta has joined #openstack-manila | 20:35 | |
| *** JoseMello has joined #openstack-manila | 20:42 | |
| *** haomaiwang has joined #openstack-manila | 20:50 | |
| *** haomaiwang has quit IRC | 20:58 | |
| *** martyturner has quit IRC | 21:02 | |
| *** timcl has quit IRC | 21:03 | |
| *** tpsilva has quit IRC | 21:07 | |
| *** merooney has quit IRC | 21:09 | |
| *** sedwards has quit IRC | 21:10 | |
| *** martyturner has joined #openstack-manila | 21:14 | |
| *** timcl has joined #openstack-manila | 21:17 | |
| *** timcl has quit IRC | 21:29 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: NetApp: Add Replication support in cDOT https://review.openstack.org/275416 | 21:30 |
| *** esker has joined #openstack-manila | 21:36 | |
| *** kaisers has quit IRC | 21:39 | |
| *** esker has quit IRC | 21:41 | |
| *** sgotliv has joined #openstack-manila | 21:41 | |
| *** kaisers has joined #openstack-manila | 21:41 | |
| *** esker has joined #openstack-manila | 21:46 | |
| *** akerr has quit IRC | 21:47 | |
| *** esker has quit IRC | 21:51 | |
| *** esker has joined #openstack-manila | 21:51 | |
| *** haomaiwang has joined #openstack-manila | 21:55 | |
| openstackgerrit | Andrea Ma proposed openstack/manila: glusterManager instantiation regexp validation https://review.openstack.org/283777 | 21:57 |
| *** haomaiwang has quit IRC | 22:01 | |
| *** merooney has joined #openstack-manila | 22:05 | |
| openstackgerrit | xing-yang proposed openstack/manila: Manage and unmanage snapshot https://review.openstack.org/249542 | 22:07 |
| *** porrua has quit IRC | 22:07 | |
| *** gouthamr has quit IRC | 22:07 | |
| *** martyturner has quit IRC | 22:08 | |
| *** eharney has quit IRC | 22:10 | |
| openstackgerrit | Clinton Knight proposed openstack/manila: Fix NetApp cDOT driver update_access negative test https://review.openstack.org/284877 | 22:29 |
| *** absubram has quit IRC | 22:48 | |
| *** esker has quit IRC | 22:52 | |
| *** haomaiwang has joined #openstack-manila | 22:59 | |
| *** haomaiwang has quit IRC | 23:01 | |
| *** cknight has quit IRC | 23:09 | |
| *** lpetrut has quit IRC | 23:11 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Do not merge] Test LVM mount capability https://review.openstack.org/282507 | 23:12 |
| *** xyang1 has quit IRC | 23:14 | |
| *** sedwards has joined #openstack-manila | 23:15 | |
| openstackgerrit | Merged openstack/manila: Add possibility to skip quota tests in Tempest https://review.openstack.org/281477 | 23:28 |
| *** JoseMello has quit IRC | 23:28 | |
| *** a_ta has quit IRC | 23:32 | |
| *** a_ta has joined #openstack-manila | 23:33 | |
| *** a_ta has quit IRC | 23:37 | |
| *** sgotliv has quit IRC | 23:42 | |
| openstackgerrit | Clinton Knight proposed openstack/manila: Fix NetApp cDOT driver update_access negative test https://review.openstack.org/284877 | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!