*** haomaiwang has quit IRC | 00:01 | |
*** haomaiwang has joined #openstack-manila | 00:01 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Do not merge] Testing CI network for migration #3 https://review.openstack.org/277190 | 00:06 |
---|---|---|
*** cknight has quit IRC | 00:23 | |
*** bill_az has quit IRC | 00:35 | |
*** tpsilva has quit IRC | 00:36 | |
*** jasonsb has joined #openstack-manila | 00:38 | |
*** jwang has quit IRC | 00:39 | |
*** jwang_ has joined #openstack-manila | 00:39 | |
*** jwang_ has quit IRC | 00:43 | |
*** jwang has joined #openstack-manila | 00:49 | |
*** jwang_ has joined #openstack-manila | 00:53 | |
*** jwang has quit IRC | 00:53 | |
*** haomaiwang has quit IRC | 01:01 | |
*** haomaiwang has joined #openstack-manila | 01:01 | |
*** mtanino has quit IRC | 01:34 | |
*** cknight has joined #openstack-manila | 01:40 | |
*** cknight1 has joined #openstack-manila | 01:42 | |
*** cknight has quit IRC | 01:45 | |
*** a_ta has joined #openstack-manila | 01:58 | |
*** haomaiwang has quit IRC | 02:01 | |
*** haomaiwang has joined #openstack-manila | 02:01 | |
*** a_ta has quit IRC | 02:03 | |
openstackgerrit | John Spray proposed openstack/manila: Add Ceph Native driver https://review.openstack.org/270211 | 02:10 |
openstackgerrit | John Spray proposed openstack/manila: Add Ceph Native driver https://review.openstack.org/270211 | 02:11 |
*** xyang1 has quit IRC | 02:26 | |
*** erlon has quit IRC | 02:26 | |
*** a_ta has joined #openstack-manila | 03:00 | |
*** haomaiwang has quit IRC | 03:01 | |
*** haomaiwang has joined #openstack-manila | 03:01 | |
*** a_ta has quit IRC | 03:04 | |
*** rkhanbikov has joined #openstack-manila | 03:50 | |
*** a_ta has joined #openstack-manila | 03:50 | |
*** a_ta has quit IRC | 03:55 | |
*** haomaiwang has quit IRC | 04:01 | |
*** haomaiwa_ has joined #openstack-manila | 04:01 | |
*** rkhanbikov has quit IRC | 04:41 | |
*** rkhanbikov has joined #openstack-manila | 04:42 | |
*** shausy has joined #openstack-manila | 04:52 | |
*** haomaiwa_ has quit IRC | 05:01 | |
*** haomaiwang has joined #openstack-manila | 05:01 | |
*** cknight1 has quit IRC | 05:02 | |
*** rkhanbikov has quit IRC | 05:15 | |
*** rkhanbikov has joined #openstack-manila | 05:36 | |
*** shausy has quit IRC | 05:37 | |
*** shausy has joined #openstack-manila | 05:38 | |
*** a_ta has joined #openstack-manila | 05:51 | |
*** rkhanbikov has quit IRC | 05:52 | |
*** a_ta has quit IRC | 05:55 | |
*** haomaiwang has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-manila | 06:01 | |
*** dcain has quit IRC | 06:07 | |
*** shausy has quit IRC | 06:07 | |
*** shausy has joined #openstack-manila | 06:07 | |
openstackgerrit | Ramana Raja proposed openstack/manila: Add Ceph Native driver https://review.openstack.org/270211 | 06:38 |
*** rraja has joined #openstack-manila | 06:42 | |
rraja | ganso: ping | 06:47 |
*** a_ta has joined #openstack-manila | 06:59 | |
*** haomaiwang has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-manila | 07:01 | |
*** nkrinner has joined #openstack-manila | 07:03 | |
*** lpetrut has joined #openstack-manila | 07:03 | |
*** a_ta has quit IRC | 07:03 | |
openstackgerrit | Ramana Raja proposed openstack/manila: Fix pep8 failure https://review.openstack.org/277710 | 07:11 |
openstackgerrit | Ramana Raja proposed openstack/manila: Fix pep8 failure https://review.openstack.org/277710 | 07:15 |
rraja | The pep8 CI job would fail due to https://bugs.launchpad.net/manila/+bug/1543434 . A fix has been posted. | 07:17 |
openstack | Launchpad bug 1543434 in Manila "pep8: ./manila/utils.py:401:12: F821 undefined name 'file'" [Undecided,In progress] - Assigned to Ramana Raja (rraja) | 07:17 |
rraja | ignore the above. false alarm. | 07:21 |
openstackgerrit | Marcus Furlong proposed openstack/puppet-manila: fix type definition on liberty https://review.openstack.org/277712 | 07:22 |
openstackgerrit | Marcus Furlong proposed openstack/puppet-manila: fix type definition on liberty https://review.openstack.org/277715 | 07:26 |
*** sgotliv has joined #openstack-manila | 07:30 | |
*** lpetrut has quit IRC | 07:31 | |
openstackgerrit | Ramana Raja proposed openstack/manila: Add Ceph Native driver https://review.openstack.org/270211 | 07:36 |
*** alyson_ has quit IRC | 07:37 | |
*** alyson_ has joined #openstack-manila | 07:37 | |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwa_ has joined #openstack-manila | 08:01 | |
openstackgerrit | daiki kato proposed openstack/python-manilaclient: Add missing element https://review.openstack.org/277730 | 08:24 |
*** deepakcs has joined #openstack-manila | 08:27 | |
openstackgerrit | Marc Koderer proposed openstack/manila: [WIP] Add multi-segment support https://review.openstack.org/277731 | 08:31 |
*** deepakcs has left #openstack-manila | 08:33 | |
*** sgotliv has quit IRC | 08:34 | |
openstackgerrit | Alexey Ovchinnikov proposed openstack/manila: LXC/LXD driver https://review.openstack.org/245751 | 08:41 |
*** haomaiwa_ has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-manila | 09:01 | |
*** shausy has quit IRC | 09:08 | |
*** shausy has joined #openstack-manila | 09:09 | |
*** shausy has quit IRC | 09:33 | |
*** ociuhandu has quit IRC | 09:38 | |
rraja | jcsp: ping | 09:50 |
*** lpetrut has joined #openstack-manila | 09:51 | |
*** a_ta has joined #openstack-manila | 09:54 | |
*** a_ta has quit IRC | 09:59 | |
*** haomaiwang has quit IRC | 10:01 | |
openstackgerrit | Marc Koderer proposed openstack/manila: [WIP] Add multi-segment support https://review.openstack.org/277731 | 10:01 |
*** haomaiwa_ has joined #openstack-manila | 10:01 | |
*** a_ta has joined #openstack-manila | 10:50 | |
*** a_ta has quit IRC | 10:54 | |
*** tpsilva has joined #openstack-manila | 10:55 | |
*** erlon has joined #openstack-manila | 10:56 | |
openstackgerrit | Ramana Raja proposed openstack/manila: Add Ceph Native driver https://review.openstack.org/270211 | 11:00 |
*** haomaiwa_ has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-manila | 11:01 | |
*** rraja has quit IRC | 11:03 | |
*** sgotliv has joined #openstack-manila | 11:04 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] test devstack for ZFSonLinux driver https://review.openstack.org/277803 | 11:59 |
*** haomaiwang has quit IRC | 12:01 | |
*** haomaiwang has joined #openstack-manila | 12:01 | |
*** aovchinnikov has joined #openstack-manila | 12:04 | |
*** sgotliv has quit IRC | 12:16 | |
*** mtanino has joined #openstack-manila | 12:28 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Do not merge] Testing CI network for migration https://review.openstack.org/276922 | 12:38 |
*** openstackgerrit_ has joined #openstack-manila | 12:39 | |
*** marcusvrn_ has joined #openstack-manila | 12:44 | |
*** a_ta has joined #openstack-manila | 12:51 | |
*** a_ta has quit IRC | 12:55 | |
*** porrua has joined #openstack-manila | 13:00 | |
*** haomaiwang has quit IRC | 13:01 | |
*** haomaiwang has joined #openstack-manila | 13:01 | |
*** rkhanbikov has joined #openstack-manila | 13:22 | |
*** deepakcs has joined #openstack-manila | 13:24 | |
*** bill_az has joined #openstack-manila | 13:25 | |
openstackgerrit | Marcus Furlong proposed openstack/puppet-manila: fix type definition on liberty https://review.openstack.org/277715 | 13:25 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] test devstack for ZFSonLinux driver https://review.openstack.org/277803 | 13:28 |
openstackgerrit | John Spray proposed openstack/manila: Add Ceph Native driver https://review.openstack.org/270211 | 13:31 |
*** dcain has joined #openstack-manila | 13:39 | |
*** alyson_ has quit IRC | 13:42 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/python-manilaclient: Added new CLI commands for Share migration https://review.openstack.org/250518 | 13:44 |
*** eharney has joined #openstack-manila | 13:45 | |
*** haomaiwang has quit IRC | 13:46 | |
*** haomaiwa_ has joined #openstack-manila | 13:47 | |
*** akerr has joined #openstack-manila | 13:49 | |
*** a_ta has joined #openstack-manila | 13:54 | |
*** openstackgerrit_ has quit IRC | 13:56 | |
*** a_ta has quit IRC | 13:58 | |
*** haomaiwa_ has quit IRC | 14:01 | |
*** haomaiwa_ has joined #openstack-manila | 14:01 | |
*** akerr has quit IRC | 14:01 | |
*** xyang1 has joined #openstack-manila | 14:02 | |
*** akerr has joined #openstack-manila | 14:05 | |
*** cknight has joined #openstack-manila | 14:05 | |
*** rkhanbikov has quit IRC | 14:05 | |
*** rkhanbikov has joined #openstack-manila | 14:06 | |
*** rkhanbikov has quit IRC | 14:07 | |
*** deepakcs has quit IRC | 14:07 | |
*** mtanino has quit IRC | 14:07 | |
*** haomaiwa_ has quit IRC | 14:08 | |
*** eharney has quit IRC | 14:19 | |
*** akshai has joined #openstack-manila | 14:30 | |
*** akerr has quit IRC | 14:36 | |
*** gouthamr has joined #openstack-manila | 14:37 | |
*** akerr has joined #openstack-manila | 14:37 | |
*** ociuhandu has joined #openstack-manila | 14:43 | |
*** a_ta has joined #openstack-manila | 14:43 | |
*** ociuhandu has quit IRC | 14:46 | |
*** dustins has joined #openstack-manila | 14:47 | |
*** amit213 has quit IRC | 14:51 | |
*** vbellur has quit IRC | 14:53 | |
*** tpatzig has quit IRC | 14:53 | |
*** mtanino has joined #openstack-manila | 14:54 | |
*** mkoderer has quit IRC | 14:55 | |
*** mkoderer has joined #openstack-manila | 14:56 | |
*** tpatzig has joined #openstack-manila | 14:56 | |
*** ociuhandu has joined #openstack-manila | 14:58 | |
*** a_ta has quit IRC | 14:59 | |
*** a_ta has joined #openstack-manila | 14:59 | |
*** a_ta has quit IRC | 15:04 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Add new Share migration API functions https://review.openstack.org/259642 | 15:04 |
*** a_ta has joined #openstack-manila | 15:13 | |
*** dustins has quit IRC | 15:26 | |
*** timcl has joined #openstack-manila | 15:27 | |
*** dustins has joined #openstack-manila | 15:28 | |
*** bsuchok_ has joined #openstack-manila | 15:29 | |
*** dustins has quit IRC | 15:33 | |
*** jcsp has quit IRC | 15:34 | |
*** dustins has joined #openstack-manila | 15:36 | |
*** vbellur has joined #openstack-manila | 15:43 | |
*** marcusvrn_ has quit IRC | 15:47 | |
*** esker has joined #openstack-manila | 16:01 | |
*** eharney has joined #openstack-manila | 16:02 | |
*** vbellur has quit IRC | 16:03 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Do not merge] Testing CI network for migration #2 https://review.openstack.org/277187 | 16:03 |
*** lpetrut has quit IRC | 16:04 | |
*** JoseMello has joined #openstack-manila | 16:06 | |
*** jcsp has joined #openstack-manila | 16:09 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Do not merge] Testing CI network for migration https://review.openstack.org/276922 | 16:12 |
*** jcsp has quit IRC | 16:14 | |
*** vbellur has joined #openstack-manila | 16:21 | |
openstackgerrit | Thomas Bechtold proposed openstack/manila: Update help text for some service instance config opts https://review.openstack.org/250360 | 16:34 |
*** esker has quit IRC | 16:49 | |
*** timcl has quit IRC | 17:00 | |
ganso | is gerrit unstable for anyone? | 17:10 |
*** martyturner has joined #openstack-manila | 17:18 | |
*** a_ta has quit IRC | 17:18 | |
*** a_ta has joined #openstack-manila | 17:19 | |
*** vbellur has quit IRC | 17:20 | |
openstackgerrit | xing-yang proposed openstack/manila: Manage and unmanage snapshot https://review.openstack.org/249542 | 17:21 |
*** a_ta has quit IRC | 17:23 | |
-openstackstatus- NOTICE: Gerrit is restarting now, to alleviate current performance impact and WebUI errors. | 17:24 | |
*** vbellur has joined #openstack-manila | 17:35 | |
*** timcl has joined #openstack-manila | 17:36 | |
*** dustins_ has joined #openstack-manila | 17:40 | |
*** a_ta has joined #openstack-manila | 17:40 | |
*** dustins has quit IRC | 17:41 | |
*** timcl1 has joined #openstack-manila | 17:53 | |
*** lpetrut has joined #openstack-manila | 17:55 | |
*** timcl has quit IRC | 17:56 | |
*** jwang has joined #openstack-manila | 18:00 | |
*** jwang_ has quit IRC | 18:00 | |
*** akshai has quit IRC | 18:00 | |
*** akshai has joined #openstack-manila | 18:02 | |
*** jasonsb has quit IRC | 18:04 | |
*** dustins_ has quit IRC | 18:11 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] test devstack for ZFSonLinux driver https://review.openstack.org/277803 | 18:13 |
*** dustins has joined #openstack-manila | 18:16 | |
xyang1 | cknight: around? | 18:16 |
cknight | xyang1: Hi, Xing. | 18:16 |
xyang1 | cknight: hi, about your comments on my patch, i think the tempest test should work for other drivers | 18:17 |
xyang1 | cknight: because rest api only needs driver_options and only driver knows how to parse it | 18:18 |
cknight | xyang1: So, for example, if my driver needs something like —driver_options "name=<snapname>", and another driver needs something else to uniquely identify the snapshot to be managed, how can Tempest do that? | 18:18 |
xyang1 | cknight: so I create a snapshot first, unmanage it and then manage again | 18:18 |
xyang1 | cknight: i am not giving that explicitly | 18:18 |
xyang1 | cknight: that is why I need the private data | 18:19 |
xyang1 | cknight: following manage share tempest test example | 18:19 |
xyang1 | cknight: create snapshot first | 18:19 |
xyang1 | cknight: so it already has the info | 18:19 |
cknight | xyang1: So leaving the issue with returning private data aside for the moment, you would ask each driver to store something standard in the private data so the Tempest test would work universally? | 18:21 |
xyang1 | cknight: then unmanage it, when I manage it again | 18:21 |
xyang1 | cknight: probably does not need to be standard | 18:21 |
*** martyturner has quit IRC | 18:22 | |
xyang1 | cknight: just need to be in private data I think | 18:22 |
xyang1 | cknight: so when snapshot is created, info is saved in private data | 18:22 |
xyang1 | cknight: by driver | 18:22 |
*** martyturner has joined #openstack-manila | 18:22 | |
*** timcl1 has quit IRC | 18:23 | |
cknight | xyang1: But then we're testing something that isn't part of the usual workflow. A snapshot to be managed by an admin won't have any private data. | 18:23 |
vponomaryov | xyang1: you mean you just need to provide the same thing as driver created for itself earlier? | 18:23 |
xyang1 | cknight: when i unmanage and manage again, driver should know how to get it again | 18:23 |
xyang1 | vponomaryov: yes | 18:24 |
xyang1 | cknight: ? | 18:24 |
vponomaryov | xyang1: your driver(s) require it? | 18:24 |
xyang1 | vponomaryov: driver knows what keys to read | 18:24 |
vponomaryov | xyang1: old name of snapshot based on its ID is not enough? | 18:25 |
vponomaryov | xyang1: do you rename snapshot managing it? | 18:25 |
xyang1 | vponomaryov: no | 18:25 |
cknight | xyang1: I understand how that tests the unmanage-manage workflow. But that seems much less common than the manage workflow, where manila never saw the snapshot before. | 18:26 |
cknight | vponomaryov: In my driver, yes, I would rename the snapshot to the driver's standard naming convention. | 18:26 |
vponomaryov | cknight, xyang1: looks liek we need agreement on rename/not rename thing | 18:27 |
vponomaryov | managing share/snapshots | 18:27 |
cknight | xyang1: I'm not at all sure how to test snapshot manage without the preceding unmanage operation, since each driver would need a unique piece of snapshot info. | 18:28 |
xyang1 | vponomaryov: I'll need to check that part | 18:28 |
*** dustins has quit IRC | 18:28 | |
cknight | xyang1: But you could write a negative test by creating a snapshot using manila, and then attempting to manage that; such a workflow should fail. | 18:28 |
*** dustins has joined #openstack-manila | 18:28 | |
xyang1 | cknight: I added a negative test | 18:29 |
*** dustins has quit IRC | 18:29 | |
xyang1 | cknight: you mean negative because it is already managed? | 18:30 |
cknight | xyang1: yes | 18:30 |
xyang1 | cknight: ok, I can add that | 18:30 |
*** esker has joined #openstack-manila | 18:30 | |
cknight | xyang1: But I don't know how to add a positive test for the common case, simply managing a previously unknown snapshot. Maybe vponomaryov has an idea. | 18:31 |
xyang1 | cknight: so manage share test is like that. | 18:31 |
xyang1 | cknight: create, unmanage, then manage | 18:31 |
vponomaryov | cknight: current manage tests in Tempest create everything and then do mange/unmanage stuff | 18:31 |
xyang1 | cknight: vponomaryov other ideas are welcome | 18:32 |
cknight | xyang1: OK, fair enough. But I discussed with vponomaryov and bswartz this morning, and we're agreed we shouldn't be returning driver private data via a tenant-facing REST API. | 18:32 |
xyang1 | cknight: ok, so how do I move forward | 18:32 |
cknight | xyang1: Tenants should never see that kind of backend-specific details. | 18:32 |
cknight | xyang1: Maybe an admin-only API specifically to get driver private data? | 18:33 |
vponomaryov | cknight: manage is designed to be admin only )) | 18:33 |
xyang1 | cknight: add that in the same patch? | 18:34 |
xyang1 | cknight: vponomaryov what if I add context check for admin | 18:34 |
cknight | vponomaryov: Yes, but this patch returns the private data in the GET /snapshots call. | 18:34 |
cknight | xyang1: You could do that, but given the sensitivity, I'd suggest you get alignment first. | 18:35 |
xyang1 | vponomaryov: I added that in views | 18:35 |
bswartz | we have manage/unmanage tests for shares in tempest? | 18:35 |
vponomaryov | cknight, xyang1: we can add such attr to admin view and hide for user | 18:35 |
vponomaryov | bswartz: yes | 18:35 |
bswartz | how does it know what string to use for the manage? | 18:35 |
vponomaryov | bswartz: it creates shares first | 18:36 |
*** akshai has quit IRC | 18:36 | |
xyang1 | vponomaryov: export location is already visible? | 18:37 |
vponomaryov | xyang1: it always was | 18:37 |
xyang1 | bswartz: Manage share needs export location which is already in views | 18:37 |
*** akshai has joined #openstack-manila | 18:38 | |
bswartz | is that how we prevent re-managing and already managed share too? | 18:38 |
bswartz | s/and/an/ | 18:38 |
*** ociuhandu has quit IRC | 18:39 | |
vponomaryov | bswartz: yes | 18:39 |
bswartz | in that case I would hope we could do something similar with snapshots | 18:40 |
vponomaryov | bswartz: there is no EL for snapshots in Manila | 18:40 |
bswartz | can't we find a vendor neutral syntax for snapshot management and avoiding exposing the driver private data? | 18:40 |
bswartz | I know | 18:40 |
vponomaryov | so, proposal "we can add such attr to admin view and hide for user" is not desired? | 18:41 |
xyang1 | vponomaryov: sounds good to me. bswartz cknight ? | 18:42 |
bswartz | I know we discussed providing read-only access to driver private share data for admin only before, I'm not opposed to that | 18:42 |
cknight | xyang1: So you would be returning driver private data for snapshots, but nothing else? I'm not thrilled with the inconsistency. | 18:43 |
bswartz | but I would rather that snapshot manage/unmanage didn't depend on that in order to work | 18:43 |
cknight | xyang1: A separate API would make that cleaner. | 18:43 |
cknight | bswartz: +1 | 18:43 |
bswartz | is it only the tests that require such information? | 18:43 |
xyang1 | bswartz: yes | 18:43 |
bswartz | can we add it as a separate feature then? | 18:43 |
xyang1 | bswartz: I need that for tempest | 18:44 |
xyang1 | bswartz: ? | 18:44 |
bswartz | one API for manage, one for unmanage, and one for read private data? | 18:44 |
bswartz | then allow tempest to call them as needed? | 18:44 |
xyang1 | bswartz: in the same patch? | 18:44 |
bswartz | well ideally there would be 3 patches | 18:44 |
bswartz | 1) manage/unmanage feature | 18:44 |
bswartz | 2) read driver private data feature | 18:45 |
bswartz | 3) tests for manage/unamange | 18:45 |
bswartz | if it's too much work to split it out then 1 patch would be okay I guess | 18:45 |
cknight | bswartz: Why not 2 patches, your #2 and then #1/3 ? | 18:45 |
vponomaryov | (2) and (1,3) | 18:45 |
vponomaryov | cknight +1 | 18:45 |
xyang1 | bswartz: vponomaryov prefers tempest test in the same patch | 18:45 |
cknight | vponomaryov: :-) | 18:45 |
bswartz | okay that's fine too | 18:46 |
vponomaryov | actually, it would be (2,3) and (1,3), where 3 is "some tempest tests" | 18:46 |
cknight | vponomaryov: +1 | 18:46 |
cknight | vponomaryov: Where is the check for export locations that prevent re-managing a share? I'm having trouble finding it again, and I wonder if it was updated after we added the multiple export locations feature. | 18:47 |
bswartz | I'm okay merging new features with as long as tests are proposed -- it doesn't matter to me that the patches are separate | 18:47 |
vponomaryov | manila/share/api | 18:47 |
xyang1 | patch 1: read driver private data, tempest for that | 18:48 |
xyang1 | patch 2: manage, unmanage and tempest for that | 18:48 |
vponomaryov | cknight: https://github.com/openstack/manila/blob/b1b723ad0b8a61eef296977c03ef2bb244e90e27/manila/share/api.py#L381 | 18:48 |
xyang1 | correct? vponomaryov cknight bswartz ? | 18:48 |
xyang1 | 2 depends on 1 | 18:48 |
vponomaryov | xyang1; yes | 18:49 |
xyang1 | cknight: bswartz ? | 18:49 |
cknight | xyang1: I'm good with that, thanks. | 18:50 |
xyang1 | cknight: any other concerns that I have not addessed? I added comments to your comments | 18:50 |
bswartz | xyang1: yes that's fine | 18:51 |
cknight | xyang1: Sorry, I haven't re-reviewed your latest fully. I'll check that now. | 18:51 |
bswartz | xyang1: I hope it's not a lot of work to split it | 18:51 |
xyang1 | cknight: np | 18:51 |
xyang1 | bswartz: a little tight now, I wish I brought this up at the midcycle | 18:52 |
vponomaryov | I need to go, bye all | 18:52 |
xyang1 | vponomaryov: bye | 18:52 |
*** timcl has joined #openstack-manila | 18:52 | |
cknight | xyang1: There is still the question of what happens when managing a snapshot of a replicated share. I don't know the best answer. Since you need to work on the private data patch anyway, perhaps this is a good topic for the Thursday meeting. | 18:56 |
*** martyturner has quit IRC | 18:56 | |
cknight | xyang1: But it'd be great to have a good answer to the question, even if it isn't implemented at first. | 18:57 |
bswartz | xyang1: if it's easier for you, I would be okay with a big patch that does all of what we mentioned | 18:57 |
bswartz | it's not like we would consider backporting the features | 18:57 |
bswartz | cknight: we don't support managing of replicated shares at all (yet) IMO | 18:58 |
cknight | bswartz: Fine, but this is about managing snapshots on already-replicated shares. If we want to detect that and fail, OK. But it shouldn't just proceed with undefined results. | 19:00 |
*** vbellur has quit IRC | 19:00 | |
*** cknight has quit IRC | 19:00 | |
xyang1 | cknight: what do we do with create snapshot? | 19:00 |
xyang1 | cknight: of replicated shar | 19:01 |
xyang1 | share | 19:01 |
*** akshai has quit IRC | 19:01 | |
xyang1 | bswartz: cknight dropped off | 19:01 |
xyang1 | bswartz: one patch will be easier to manage:) | 19:01 |
*** akshai has joined #openstack-manila | 19:02 | |
*** martyturner has joined #openstack-manila | 19:02 | |
bswartz | replicated shares should have the same snapshots on all replicas | 19:02 |
bswartz | so no matter which replicate you make the "active" one, you have all the snapshots manila knows about | 19:02 |
xyang1 | bswartz: I don't see any coding change on create snapshot that is why I am wondering | 19:03 |
*** cknight has joined #openstack-manila | 19:03 | |
bswartz | in the replication patch? | 19:03 |
*** ociuhandu has joined #openstack-manila | 19:03 | |
bswartz | I think the manager at least passed more information to the driver on create snapshot | 19:03 |
xyang1 | bswartz: yes | 19:04 |
bswartz | so the driver can do what it needs to do make sure the snapshot is everywhere it needs to be | 19:04 |
xyang1 | bswartz: cknight so should I fail manGe | 19:04 |
bswartz | there isn't much else to do in the code -- we should document more clearly though what the expectation for drivers is | 19:04 |
xyang1 | should I fail manage snapshot if it is replicated share? | 19:05 |
bswartz | yeah I would say failure is fine if the share is replicated and someone attempts to manage a snapshot | 19:05 |
cknight | sounds OK for now, yes | 19:05 |
bswartz | it would be nice to have better behaviour, but that's only possible if you rebase your patch on top of replication | 19:05 |
xyang1 | bswartz: cknight can I add that after replication patch is in? | 19:05 |
cknight | xyang1: makes sense. you could handle that as a bug. | 19:06 |
bswartz | yeah sure | 19:06 |
xyang1 | that will be much easier | 19:06 |
bswartz | I'm not sure we call it a bug, but it can certainly be separate and we could grant and FFE if it's valuable but can't make the FF deadline | 19:07 |
xyang1 | bswartz: ok, thanks | 19:07 |
*** rkhanbikov has joined #openstack-manila | 19:09 | |
*** alkhodos_ has joined #openstack-manila | 19:15 | |
*** timcl1 has joined #openstack-manila | 19:15 | |
*** esker has quit IRC | 19:16 | |
*** esker has joined #openstack-manila | 19:17 | |
*** rkhanbikov has quit IRC | 19:17 | |
*** vbellur has joined #openstack-manila | 19:18 | |
*** timcl has quit IRC | 19:18 | |
*** esker has quit IRC | 19:19 | |
*** JoseMello has quit IRC | 19:28 | |
*** esker has joined #openstack-manila | 19:34 | |
*** esker has quit IRC | 19:34 | |
*** a_ta has quit IRC | 19:34 | |
*** esker has joined #openstack-manila | 19:34 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: [Do not merge] Testing CI network for migration #1 https://review.openstack.org/276922 | 19:37 |
*** vbellur has quit IRC | 19:50 | |
*** esker has quit IRC | 19:56 | |
*** a_ta has joined #openstack-manila | 19:58 | |
*** dustins has joined #openstack-manila | 20:00 | |
*** rkhanbikov has joined #openstack-manila | 20:01 | |
*** rkhanbikov has quit IRC | 20:02 | |
*** akshai has quit IRC | 20:02 | |
*** timcl1 has quit IRC | 20:03 | |
*** a_ta has quit IRC | 20:03 | |
*** timcl has joined #openstack-manila | 20:04 | |
*** vbellur has joined #openstack-manila | 20:04 | |
openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Implement update_access() method in generic driver https://review.openstack.org/256281 | 20:05 |
*** akshai has joined #openstack-manila | 20:05 | |
*** rkhanbikov has joined #openstack-manila | 20:07 | |
*** rkhanbikov has quit IRC | 20:08 | |
*** rkhanbikov has joined #openstack-manila | 20:11 | |
*** martyturner has quit IRC | 20:19 | |
*** martyturner has joined #openstack-manila | 20:21 | |
*** a_ta has joined #openstack-manila | 20:31 | |
*** dcain1 has joined #openstack-manila | 20:33 | |
*** dcain has quit IRC | 20:33 | |
*** dcain1 has quit IRC | 20:38 | |
*** esker has joined #openstack-manila | 20:53 | |
*** akerr has quit IRC | 20:54 | |
*** esker has quit IRC | 20:59 | |
*** krotscheck is now known as krotscheck_dcm | 21:03 | |
*** dcain has joined #openstack-manila | 21:03 | |
*** timcl has quit IRC | 21:06 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] test devstack for ZFSonLinux driver https://review.openstack.org/277803 | 21:14 |
*** lpetrut has quit IRC | 21:18 | |
*** martyturner has quit IRC | 21:20 | |
*** martyturner has joined #openstack-manila | 21:23 | |
*** dcain has quit IRC | 21:24 | |
*** dcain has joined #openstack-manila | 21:24 | |
*** erlon has quit IRC | 21:26 | |
*** vbellur has quit IRC | 21:36 | |
*** tpsilva has quit IRC | 21:36 | |
*** dcain has quit IRC | 21:37 | |
*** cknight has quit IRC | 21:43 | |
*** nkrinner has quit IRC | 21:50 | |
*** martyturner has quit IRC | 21:54 | |
*** martyturner has joined #openstack-manila | 21:56 | |
*** esker has joined #openstack-manila | 22:00 | |
*** esker has quit IRC | 22:05 | |
*** gouthamr has quit IRC | 22:06 | |
*** cknight has joined #openstack-manila | 22:11 | |
*** martyturner has quit IRC | 22:11 | |
*** porrua has quit IRC | 22:17 | |
*** martyturner has joined #openstack-manila | 22:19 | |
*** vbellur has joined #openstack-manila | 22:21 | |
*** dcain has joined #openstack-manila | 22:26 | |
*** esker has joined #openstack-manila | 22:34 | |
*** dustins has quit IRC | 22:35 | |
*** dschoenb__ has joined #openstack-manila | 22:35 | |
*** dschoenb__ is now known as dustins | 22:35 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: [DEBUG] test devstack for ZFSonLinux driver https://review.openstack.org/277803 | 22:37 |
*** dcain1 has joined #openstack-manila | 22:41 | |
*** dcain has quit IRC | 22:44 | |
*** esker has quit IRC | 22:46 | |
*** martyturner has quit IRC | 22:47 | |
*** esker has joined #openstack-manila | 22:52 | |
*** dustins has quit IRC | 23:00 | |
*** eharney has quit IRC | 23:03 | |
*** xyang1 has quit IRC | 23:09 | |
*** dcain1 has quit IRC | 23:27 | |
*** a_ta has quit IRC | 23:28 | |
*** a_ta has joined #openstack-manila | 23:28 | |
*** a_ta has quit IRC | 23:33 | |
openstackgerrit | Shaun Edwards proposed openstack/manila: EMC Isilon Driver Support For NFS Read-Only Share https://review.openstack.org/271095 | 23:44 |
openstackgerrit | Shaun Edwards proposed openstack/manila: EMC Isilon Driver Support For CIFS Read-Only Share https://review.openstack.org/278148 | 23:44 |
*** sedwards has quit IRC | 23:47 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!