*** haomaiwang has quit IRC | 00:01 | |
*** haomaiwang has joined #openstack-manila | 00:02 | |
*** jwang_ has joined #openstack-manila | 00:14 | |
*** jwang has quit IRC | 00:17 | |
*** zhongjun2 has quit IRC | 00:24 | |
*** zhongjun has joined #openstack-manila | 00:26 | |
*** gnarld_ is now known as nug | 00:27 | |
*** nug is now known as Guest56749 | 00:28 | |
*** david-lyle has quit IRC | 00:40 | |
*** haomaiwa_ has joined #openstack-manila | 01:03 | |
*** haomaiwang has quit IRC | 01:03 | |
*** darkwsh has quit IRC | 01:20 | |
*** haomaiwa_ has quit IRC | 01:26 | |
*** jasonsb has quit IRC | 01:29 | |
*** david-lyle has joined #openstack-manila | 01:49 | |
*** xxxxxx has joined #openstack-manila | 01:54 | |
*** xxxxxx has quit IRC | 01:54 | |
*** xxxxxx has joined #openstack-manila | 01:56 | |
*** haomaiwang has joined #openstack-manila | 02:16 | |
*** houming has joined #openstack-manila | 02:33 | |
openstackgerrit | Hou Ming Wang proposed openstack/manila: Trivial: Remove unused logging import https://review.openstack.org/261538 | 02:45 |
---|---|---|
*** esker has joined #openstack-manila | 02:56 | |
*** david-lyle has quit IRC | 02:57 | |
*** haomaiwang has quit IRC | 03:01 | |
*** haomaiwa_ has joined #openstack-manila | 03:01 | |
*** esker has quit IRC | 03:02 | |
openstackgerrit | xing-yang proposed openstack/manila: Manage and unmanage snapshot https://review.openstack.org/249542 | 03:06 |
openstackgerrit | xing-yang proposed openstack/manila: Tempest tests for Manage and unmanage snapshot https://review.openstack.org/262114 | 03:06 |
*** jasonsb has joined #openstack-manila | 03:25 | |
*** david-lyle has joined #openstack-manila | 03:26 | |
*** david-lyle has quit IRC | 03:52 | |
*** haomaiwa_ has quit IRC | 04:01 | |
*** haomaiwang has joined #openstack-manila | 04:01 | |
*** esker has joined #openstack-manila | 05:00 | |
*** haomaiwang has quit IRC | 05:01 | |
*** 21WAAM5NW has joined #openstack-manila | 05:01 | |
*** esker has quit IRC | 05:05 | |
*** xxxxxx has quit IRC | 05:09 | |
*** david-lyle has joined #openstack-manila | 05:27 | |
*** sgotliv has joined #openstack-manila | 05:40 | |
*** xxxxxx has joined #openstack-manila | 05:47 | |
*** david-lyle has quit IRC | 05:58 | |
*** 21WAAM5NW has quit IRC | 06:01 | |
*** haomaiwa_ has joined #openstack-manila | 06:01 | |
*** jasonsb has quit IRC | 06:18 | |
*** jasonsb has joined #openstack-manila | 06:19 | |
*** david-lyle has joined #openstack-manila | 06:29 | |
*** haomaiwa_ has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-manila | 07:01 | |
*** esker has joined #openstack-manila | 07:03 | |
*** esker has quit IRC | 07:08 | |
*** lpetrut has joined #openstack-manila | 07:23 | |
openstackgerrit | liucheng proposed openstack/manila: Huawei: Add manage share with share type in Huawei driver https://review.openstack.org/250995 | 07:58 |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-manila | 08:01 | |
*** lpetrut has quit IRC | 08:25 | |
*** xxxxxx has quit IRC | 08:43 | |
*** xxxxxx has joined #openstack-manila | 08:47 | |
*** xxxxxx has quit IRC | 08:47 | |
*** haomaiwang has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-manila | 09:01 | |
*** esker has joined #openstack-manila | 09:06 | |
*** esker has quit IRC | 09:11 | |
*** haomaiwang has quit IRC | 10:01 | |
*** haomaiwa_ has joined #openstack-manila | 10:04 | |
*** esker has joined #openstack-manila | 10:07 | |
*** lpetrut has joined #openstack-manila | 10:10 | |
*** esker has quit IRC | 10:12 | |
ganso | vponomaryov: ping | 10:24 |
vponomaryov | ganso: pong | 10:25 |
ganso | vponomaryov: Hello! I've been reading your patches regarding export location metadata and admin export location. I'm having a hard time understanding how your implementation of admin export location works in generic driver | 10:26 |
ganso | vponomaryov: unless the implementation is still incomplete | 10:26 |
vponomaryov | ganso: return list of export locations with any amount of them with key "is_admin"only" set to boolean | 10:27 |
vponomaryov | ganso: generic, foo, bar driver, no diff | 10:28 |
ganso | vponomaryov: I don't see the driver.py base class being changed, is there no need to? | 10:32 |
vponomaryov | ganso: why driver.py should be changed? | 10:34 |
vponomaryov | ganso: share manager handles responses from share driver | 10:35 |
vponomaryov | ganso: you just change response | 10:35 |
vponomaryov | ganso: now share manager and DB api understand two approaches - old and new | 10:35 |
vponomaryov | ganso: so, admin export location mechanism is done | 10:38 |
ganso | vponomaryov: I see, I was expecting db.export_location_metadata_update to be called, but it isn't being called in code | 10:39 |
vponomaryov | ganso: and generic driver here has an example of using new approach here - https://review.openstack.org/#/c/251930/40/manila/share/drivers/generic.py , but it does not really create second export location | 10:39 |
vponomaryov | ganso: what do you mean not called? | 10:40 |
ganso | vponomaryov: in manager, to update metadata, but it is called only within DB class | 10:40 |
vponomaryov | ganso: driver returns data to manager and manager does all required stuff | 10:40 |
ganso | vponomaryov: I understand now, the only interaction point is when driver returns the export location when creating share / ensuring share | 10:42 |
ganso | vponomaryov: then manager takes care of all the rest | 10:43 |
vponomaryov | ganso: manage, and others | 10:43 |
vponomaryov | ganso: you can use this DB APi in any place of share manager | 10:43 |
vponomaryov | ganso: driver is not allowed to call DB | 10:43 |
ganso | vponomaryov: but for generic driver, it is not really allocating any IP from admin network right? (as far from what I see in the code, just an example), so for migration, it will not have any real reachable IP to mount | 10:44 |
vponomaryov | ganso: existing commits - implementation of mechanism | 10:45 |
vponomaryov | ganso: tha tis not used | 10:45 |
vponomaryov | ganso: implementation in drivers - completely separate thing | 10:46 |
vponomaryov | ganso: "example" shows that mechanism works | 10:46 |
vponomaryov | ganso: mechanism does not care where did you get info that is provided as export location | 10:47 |
ganso | vponomaryov: I see, so still all DHSS drivers need to implement something to support this feature, it is not something that can be done only in Manila core code. | 10:47 |
vponomaryov | ganso: in case of Generic driver it could be some additional option with admin net and its usage | 10:48 |
ganso | vponomaryov: I see that the export location metadata patch still has missing the part where it can print the additional metadata | 10:48 |
vponomaryov | ganso: if is finished | 10:48 |
vponomaryov | ganso: nothing is missed | 10:48 |
vponomaryov | s/if/it/ | 10:48 |
vponomaryov | ganso: read commit description | 10:48 |
ganso | vponomaryov: https://review.openstack.org/#/c/251930/40/manila/api/views/export_locations.py | 10:49 |
vponomaryov | ganso: there is no metadata to view | 10:49 |
ganso | vponomaryov: shouldn't it loop through the metadata and print them? | 10:49 |
vponomaryov | ganso: no | 10:49 |
ganso | vponomaryov: but if there was, would it work? | 10:49 |
vponomaryov | ganso: design assumes that we, as community, make agreement on metadata and only then define keys that will be shown explicitely | 10:50 |
vponomaryov | specific metadata | 10:50 |
vponomaryov | ganso: not all, not any | 10:50 |
ganso | vponomaryov: oh, so only common metadata, not scoped ones | 10:51 |
ganso | vponomaryov: ok so it is complete :) | 10:51 |
vponomaryov | ganso: yes | 10:51 |
vponomaryov | mechanism is completed | 10:51 |
ganso | vponomaryov: I will finish reviewing the unit tests now, thanks for clearing it up :) | 10:52 |
vponomaryov | np | 10:52 |
*** haomaiwa_ has quit IRC | 11:01 | |
*** haomaiwa_ has joined #openstack-manila | 11:01 | |
*** ociuhandu has quit IRC | 11:03 | |
*** ociuhandu has joined #openstack-manila | 11:29 | |
ganso | vponomaryov: btw, is gerrit failing a lot to load pages for you? | 11:29 |
*** haomaiwa_ has quit IRC | 12:01 | |
*** haomaiwa_ has joined #openstack-manila | 12:01 | |
*** lpetrut has quit IRC | 12:03 | |
*** lpetrut has joined #openstack-manila | 12:04 | |
*** david-lyle has quit IRC | 12:06 | |
*** esker has joined #openstack-manila | 12:10 | |
*** esker has quit IRC | 12:15 | |
openstackgerrit | huyang proposed openstack/manila: Huawei: Add share server support https://review.openstack.org/259719 | 12:35 |
mkoderer | ganso: gerrit is failing a lot for all of us.. see #openstack-infra ;) | 12:36 |
ganso | mkoderer: Thanks Marc! :) | 12:41 |
*** haomaiwa_ has quit IRC | 13:01 | |
*** houming has quit IRC | 13:01 | |
*** haomaiwang has joined #openstack-manila | 13:01 | |
*** haomaiwang has quit IRC | 13:04 | |
*** david-lyle has joined #openstack-manila | 13:09 | |
*** esker has joined #openstack-manila | 13:11 | |
*** esker has quit IRC | 13:17 | |
*** kambiz has quit IRC | 13:37 | |
*** porrua has joined #openstack-manila | 13:43 | |
*** haomaiwang has joined #openstack-manila | 13:43 | |
*** erlon has joined #openstack-manila | 13:57 | |
*** haomaiwang has quit IRC | 14:01 | |
*** kambiz has joined #openstack-manila | 14:01 | |
*** haomaiwang has joined #openstack-manila | 14:01 | |
*** porrua has quit IRC | 14:27 | |
*** kambiz has quit IRC | 14:50 | |
*** kambiz has joined #openstack-manila | 14:52 | |
*** haomaiwang has quit IRC | 15:01 | |
*** 7JTABFCS0 has joined #openstack-manila | 15:01 | |
*** ociuhandu has quit IRC | 15:20 | |
*** 7JTABFCS0 has quit IRC | 16:01 | |
*** 17WABFTAV has joined #openstack-manila | 16:01 | |
*** kambiz has quit IRC | 16:13 | |
*** kambiz has joined #openstack-manila | 16:15 | |
*** lpetrut has quit IRC | 16:15 | |
*** david-lyle has quit IRC | 16:21 | |
*** kambiz has quit IRC | 16:38 | |
*** kambiz has joined #openstack-manila | 16:41 | |
*** david-lyle has joined #openstack-manila | 16:42 | |
*** david-lyle has quit IRC | 16:48 | |
*** david-lyle has joined #openstack-manila | 16:58 | |
*** david-lyle has quit IRC | 16:59 | |
*** esker has joined #openstack-manila | 17:00 | |
*** 17WABFTAV has quit IRC | 17:01 | |
*** haomaiwang has joined #openstack-manila | 17:01 | |
*** dustins has quit IRC | 17:06 | |
*** esker has quit IRC | 17:09 | |
*** haomaiwang has quit IRC | 18:01 | |
*** 14WAAJEAT has joined #openstack-manila | 18:01 | |
*** david-lyle has joined #openstack-manila | 18:14 | |
*** david-lyle has quit IRC | 18:24 | |
*** vbellur has joined #openstack-manila | 18:31 | |
*** ociuhandu has joined #openstack-manila | 18:44 | |
*** 14WAAJEAT has quit IRC | 19:01 | |
*** haomaiwang has joined #openstack-manila | 19:01 | |
*** david-lyle has joined #openstack-manila | 19:28 | |
*** david-lyle has quit IRC | 19:33 | |
*** david-lyle has joined #openstack-manila | 19:33 | |
*** david-lyle has quit IRC | 19:42 | |
*** david-lyle has joined #openstack-manila | 19:43 | |
*** haomaiwang has quit IRC | 20:01 | |
*** 17WABFU7I has joined #openstack-manila | 20:01 | |
openstackgerrit | xing-yang proposed openstack/manila: Tempest tests for Manage and unmanage snapshot https://review.openstack.org/262114 | 20:03 |
*** david-lyle has quit IRC | 20:10 | |
*** ganso has quit IRC | 20:39 | |
*** david-lyle has joined #openstack-manila | 20:43 | |
*** esker has joined #openstack-manila | 21:00 | |
*** 17WABFU7I has quit IRC | 21:01 | |
*** 6A4ABG0AL has joined #openstack-manila | 21:01 | |
*** ociuhandu has quit IRC | 21:01 | |
*** ociuhandu has joined #openstack-manila | 21:03 | |
*** erlon has quit IRC | 21:16 | |
*** openstackgerrit has quit IRC | 21:17 | |
*** openstackgerrit has joined #openstack-manila | 21:18 | |
*** jasonsb has quit IRC | 21:20 | |
*** esker has quit IRC | 21:32 | |
*** 6A4ABG0AL has quit IRC | 22:01 | |
*** haomaiwa_ has joined #openstack-manila | 22:01 | |
openstackgerrit | Merged openstack/manila: Fix wrong flake8 exception and pep8 violations https://review.openstack.org/261335 | 22:12 |
*** david-lyle has quit IRC | 22:28 | |
*** david-lyle has joined #openstack-manila | 22:36 | |
*** david-lyle has quit IRC | 22:50 | |
*** haomaiwa_ has quit IRC | 23:01 | |
*** haomaiwang has joined #openstack-manila | 23:01 | |
*** marcusvrn_ has quit IRC | 23:07 | |
*** sgotliv has quit IRC | 23:42 | |
*** david-lyle has joined #openstack-manila | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!