| *** bswartz has joined #openstack-manila | 00:02 | |
| *** gouthamr has joined #openstack-manila | 00:12 | |
| *** jasonsb has joined #openstack-manila | 00:16 | |
| *** mtanino has quit IRC | 00:29 | |
| *** bill_az has quit IRC | 00:40 | |
| *** gouthamr has quit IRC | 00:47 | |
| *** cknight has joined #openstack-manila | 01:09 | |
| *** gouthamr has joined #openstack-manila | 01:15 | |
| *** akerr has joined #openstack-manila | 01:21 | |
| *** akerr_ has joined #openstack-manila | 01:33 | |
| *** dustins has joined #openstack-manila | 01:34 | |
| *** akerr has quit IRC | 01:36 | |
| *** EinstCrazy has joined #openstack-manila | 01:59 | |
| *** EinstCrazy has quit IRC | 02:04 | |
| *** markstur has quit IRC | 02:22 | |
| *** martyturner has joined #openstack-manila | 02:32 | |
| *** martyturner has quit IRC | 02:36 | |
| *** gouthamr has quit IRC | 02:41 | |
| openstackgerrit | Yusuke Hayashi proposed openstack/manila: Fix order of arguments in assertEqual https://review.openstack.org/229713 | 02:44 |
|---|---|---|
| *** haomaiwang has joined #openstack-manila | 02:50 | |
| *** haomaiwang has quit IRC | 02:50 | |
| *** haomaiwa_ has joined #openstack-manila | 02:51 | |
| *** gouthamr has joined #openstack-manila | 02:59 | |
| *** haomaiwa_ has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-manila | 03:01 | |
| *** dustins has quit IRC | 03:07 | |
| *** ociuhandu has joined #openstack-manila | 03:12 | |
| *** EinstCrazy has joined #openstack-manila | 03:14 | |
| *** BharatK has joined #openstack-manila | 03:21 | |
| *** gouthamr has quit IRC | 03:25 | |
| *** cknight has quit IRC | 03:53 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwang has joined #openstack-manila | 04:01 | |
| *** BharatK has quit IRC | 04:48 | |
| *** shausy has joined #openstack-manila | 04:48 | |
| *** rraja has joined #openstack-manila | 04:53 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-manila | 05:01 | |
| *** akerr_ is now known as akerr_away | 05:06 | |
| *** BharatK has joined #openstack-manila | 05:19 | |
| *** vbellur has quit IRC | 05:26 | |
| *** shausy has quit IRC | 05:35 | |
| *** shausy has joined #openstack-manila | 05:36 | |
| *** haomaiwang has quit IRC | 05:54 | |
| *** haomaiwang has joined #openstack-manila | 05:54 | |
| *** vbellur has joined #openstack-manila | 05:58 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-manila | 06:01 | |
| *** EinstCrazy has quit IRC | 06:05 | |
| *** shausy has quit IRC | 06:10 | |
| *** shausy has joined #openstack-manila | 06:10 | |
| *** nkrinner has joined #openstack-manila | 06:13 | |
| *** akerr_away has quit IRC | 06:25 | |
| *** HemanthaSKota has joined #openstack-manila | 06:45 | |
| *** izadorozhna has joined #openstack-manila | 06:54 | |
| *** vponomaryov has joined #openstack-manila | 06:54 | |
| *** sslypushenko has joined #openstack-manila | 06:54 | |
| *** u_glide has joined #openstack-manila | 06:56 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-manila | 07:01 | |
| *** lpetrut has joined #openstack-manila | 07:03 | |
| *** lpetrut has quit IRC | 07:20 | |
| openstackgerrit | Yanis Guenane proposed openstack/puppet-manila: Put all the logging related parameters to the logging class https://review.openstack.org/229758 | 07:26 |
| *** izadorozhna has quit IRC | 07:40 | |
| *** openstackgerrit has quit IRC | 07:46 | |
| *** openstackgerrit has joined #openstack-manila | 07:46 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-manila | 08:01 | |
| *** haomaiwang has quit IRC | 08:03 | |
| *** vbellur has quit IRC | 08:10 | |
| openstackgerrit | Csaba Henk proposed openstack/manila: glusterfs_native: use dynamic-auth option if available https://review.openstack.org/229409 | 08:11 |
| csaba | toabctl: ping | 08:16 |
| *** jasonsb has quit IRC | 08:27 | |
| *** haomaiwang has joined #openstack-manila | 08:37 | |
| *** wilson1 has quit IRC | 08:38 | |
| *** wilson1 has joined #openstack-manila | 08:38 | |
| *** shausy has quit IRC | 08:40 | |
| *** BharatK has quit IRC | 08:51 | |
| HemanthaSKota | hi glusterfs team, | 08:54 |
| HemanthaSKota | i am getting the below error | 08:54 |
| HemanthaSKota | 2015-10-01 08:34:33.918 | ++ mkdir -p /opt/stack/data/manila/export/manila-glusterfs-vol | 08:54 |
| HemanthaSKota | 2015-10-01 08:34:33.920 | mkdir: cannot create directory '/opt/stack/data/manila/export': Permission denied | 08:54 |
| HemanthaSKota | 2015-10-01 08:34:33.921 | + exit_trap | 08:54 |
| HemanthaSKota | seems we are running command with sudo option | 08:55 |
| HemanthaSKota | in 245 line | 08:55 |
| HemanthaSKota | mkdir -p $MANILA_STATE_PATH/export/$vol_name | 08:55 |
| HemanthaSKota | seems we are not running command with sudo option | 08:56 |
| HemanthaSKota | may be i am wrong | 08:56 |
| *** lpetrut has joined #openstack-manila | 08:58 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** jasonsb has joined #openstack-manila | 09:01 | |
| *** 6A4AALXHF has joined #openstack-manila | 09:01 | |
| *** BharatK has joined #openstack-manila | 09:04 | |
| *** vbellur has joined #openstack-manila | 09:06 | |
| *** deepakcs has joined #openstack-manila | 09:11 | |
| *** shausy has joined #openstack-manila | 09:19 | |
| *** jcsp has joined #openstack-manila | 09:41 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix display of availability-zone for manila-manage command https://review.openstack.org/229798 | 09:44 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix display of availability-zone for manila-manage command https://review.openstack.org/229798 | 09:44 |
| *** 6A4AALXHF has quit IRC | 09:52 | |
| *** haomaiwang has joined #openstack-manila | 09:52 | |
| *** sslypushenko has quit IRC | 09:58 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-manila | 10:01 | |
| *** shausy has quit IRC | 10:15 | |
| *** dsariel_ has joined #openstack-manila | 10:30 | |
| *** BharatK has quit IRC | 10:42 | |
| *** BharatK has joined #openstack-manila | 10:55 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-manila | 11:01 | |
| openstackgerrit | Csaba Henk proposed openstack/manila: add Red Hat GlusterFS drivers feature support info https://review.openstack.org/229830 | 11:26 |
| *** rraja has quit IRC | 11:27 | |
| *** rraja has joined #openstack-manila | 11:28 | |
| toabctl | csaba: pong | 11:33 |
| *** porrua has joined #openstack-manila | 11:36 | |
| *** timcl has joined #openstack-manila | 11:38 | |
| *** sgotliv has joined #openstack-manila | 11:55 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** haomaiwang has joined #openstack-manila | 12:01 | |
| *** marcusvrn_ has joined #openstack-manila | 12:06 | |
| *** HemanthaSKota has quit IRC | 12:06 | |
| *** haomaiwang has quit IRC | 12:18 | |
| *** haomaiwang has joined #openstack-manila | 12:19 | |
| bswartz | vponomaryov | 12:21 |
| *** ociuhandu has quit IRC | 12:24 | |
| *** deepakcs has quit IRC | 12:25 | |
| *** dzamboni has joined #openstack-manila | 12:27 | |
| bswartz | I'm backporting the changes that ned it | 12:29 |
| bswartz | need it | 12:29 |
| toabctl | is it already possible to create new shares from a CG ? | 12:30 |
| bswartz | toabctl: yes that was part of the feature | 12:31 |
| vponomaryov | bswartz: yes? | 12:32 |
| bswartz | vponomaryov: it was just about missing backports -- I have done them | 12:34 |
| vponomaryov | we have RC2 related bugfixes that not merged in master yet | 12:35 |
| vponomaryov | for example - https://review.openstack.org/#/c/229798/ | 12:35 |
| bswartz | vponomaryov: which? | 12:35 |
| *** BharatK has quit IRC | 12:35 | |
| bswartz | vponomaryov: this missed the deadline | 12:36 |
| bswartz | it was not tagged yesterday so I didn't see it | 12:36 |
| vponomaryov | bswartz: it was | 12:36 |
| bswartz | can it be merged in the next few hours? | 12:36 |
| vponomaryov | bug for incorrect project | 12:36 |
| vponomaryov | s/bug/but/ | 12:37 |
| toabctl | sorry. I added it to the wrong project. | 12:37 |
| vponomaryov | it was mistakenly assigned to manilaclient | 12:37 |
| bswartz | let's merge it now and see if we can sneak it into the RC | 12:37 |
| bswartz | is this the only one? | 12:38 |
| bswartz | or are there others? | 12:38 |
| vponomaryov | bswartz: others notmerged or not taged? | 12:38 |
| bswartz | either | 12:38 |
| vponomaryov | some of csaba's commits not merged | 12:38 |
| bswartz | chances are anything not already backported has missed the RC | 12:38 |
| bswartz | I'm willing to try with this one | 12:38 |
| bswartz | toabctl: can you +2A it? https://review.openstack.org/#/c/229798/ | 12:39 |
| toabctl | bswartz: done. | 12:40 |
| bswartz | there were 2 from redhat that missed the deadline I think -- but they were not critical | 12:40 |
| bswartz | I was about to go back and check if they were ready | 12:40 |
| bswartz | it's possible to sneak more fixes in, but only if they're ready and we can get them through the gate | 12:41 |
| *** wilson-1 has joined #openstack-manila | 12:41 | |
| bswartz | this one has no fix at all: https://bugs.launchpad.net/manila/+bug/1488356 | 12:41 |
| openstack | Launchpad bug 1488356 in Manila "glusterFS_native_driver: share size may be misleading" [Medium,In progress] - Assigned to Ramana Raja (rraja) | 12:41 |
| rraja | bswartz: sorry! I was unable to fix. got pulled into something else. yeah, I missed the deadline. | 12:42 |
| bswartz | this one we can review and try to get in: https://review.openstack.org/#/c/229409/ https://bugs.launchpad.net/manila/+bug/1489081 | 12:42 |
| openstack | Launchpad bug 1489081 in Manila "glusterFS_native_driver: Access allow or deny of a share to a nova VM should not disrupt IO on existing mounts" [Medium,In progress] - Assigned to Csaba Henk (chenk) | 12:42 |
| rraja | s/fix/fix it/ | 12:42 |
| bswartz | need +2A on: https://review.openstack.org/#/c/229409/ | 12:44 |
| *** wilson1 has quit IRC | 12:44 | |
| bswartz | if that can get merged I'll add it to the RC | 12:44 |
| bswartz | rraja: no worries, if it's not release critical it can always be done after Oct 15 | 12:45 |
| rraja | bswartz: yes. thanks! | 12:46 |
| *** gouthamr has joined #openstack-manila | 12:48 | |
| *** BharatK has joined #openstack-manila | 12:49 | |
| toabctl | bswartz: but iirc adding and removing shares to a existing CG isn't implemented yet, right? | 12:49 |
| bswartz | toabctl: yes that was a controversial aspect of the design -- I think we came down on the conservative side and said you couldn't add/remove shares from a group | 12:50 |
| *** bill_az has joined #openstack-manila | 12:53 | |
| toabctl | bswartz: btw. design - is there a design document for the migration feature and also for share instances/snapshot instances ? | 12:53 |
| bswartz | share instances, yes | 12:54 |
| bswartz | u_glide worked on that | 12:54 |
| bswartz | migration, I'm not sure, and ganso is not here | 12:54 |
| *** alyson_ has joined #openstack-manila | 12:54 | |
| toabctl | bswartz: and do you have a link? I just know https://docs.google.com/drawings/d/1qd9ABRnm7GwXJIMpNxjSkLSo82PPBBmmzKGXCD5d7Jk/edit but that's only the db schema changes. | 12:54 |
| bswartz | toabctl: the DB schema is the document that I'm aware of | 12:55 |
| bswartz | I didn't have a link -- that one might not be the most recent, so I was hoping u_glide would respond | 12:56 |
| bswartz | toabctl: it was discussed during the IRC meetings on a few occasions | 12:56 |
| toabctl | bswartz: ok. thx | 12:56 |
| bswartz | early in liberty it was a new idea and we spent a lot of time on it as a team | 12:56 |
| bswartz | then u_glide did the implementation | 12:57 |
| toabctl | bswartz: yeah. i remember that. but I don't remember the details. that's why I'm asking. | 12:57 |
| bswartz | if you want I can summarize the design as I understand it | 12:57 |
| bswartz | but I have a meeting in 3 minutes | 12:57 |
| u_glide | bswartz, toabctl: currently we don't have doc's for share instances | 12:57 |
| toabctl | bswartz: a summarize would be great. | 12:58 |
| u_glide | u_glide: but I hope I will create it in doc sprint | 12:58 |
| bswartz | mostly it was about changing the DB schema to allow for multiple instances of shares, where instances can be various things | 12:58 |
| toabctl | bswartz: but it's not urgent. also fine if you could do that in the next couple of days... | 12:58 |
| *** akerr has joined #openstack-manila | 12:58 | |
| bswartz | we knew we needed instances for the migration work, otherwise we'd end up with an implementation like cinder's, which has some problems | 12:58 |
| bswartz | the point was to allow the UUID that the end user sees and the UUID that the driver sees to be different | 12:59 |
| bswartz | users deal with shares, and drivers deal with instances | 12:59 |
| toabctl | bswartz: I remember that one problem was the uuid change if you don't have instances | 12:59 |
| bswartz | it was also a design goal that drivers should not have to change -- we wanted to cleanly swap share instances in and the drivers weren't supposed to notice | 13:00 |
| bswartz | I believe we achieved that goal | 13:00 |
| *** ktolstoy has joined #openstack-manila | 13:01 | |
| *** haomaiwang has quit IRC | 13:01 | |
| *** sslypush1nko has joined #openstack-manila | 13:01 | |
| *** haomaiwang has joined #openstack-manila | 13:01 | |
| toabctl | bswartz: ok. thanks | 13:01 |
| *** rraja has quit IRC | 13:01 | |
| jcsp | ah, that's actually a really useful explanation of what instances are fo | 13:04 |
| jcsp | *for | 13:04 |
| jcsp | should put it in a docstring on the ShareInstance class ;-) | 13:04 |
| *** jordanP has joined #openstack-manila | 13:04 | |
| toabctl | jcsp: go ahead! :-) | 13:05 |
| jordanP | bswartz, vponomaryov I am working on https://bugs.launchpad.net/manila/+bug/1500964 | 13:05 |
| openstack | Launchpad bug 1500964 in Manila "Manila-shr is auto restarted if exception is thrown in do_setup()" [Medium,New] | 13:05 |
| jordanP | I think it's because manila-shr dies too quickly so oslo.service didn"t realize the service was already started | 13:05 |
| bswartz | jordanP: yes you described the bug earlier | 13:11 |
| bswartz | thanks for fixing it | 13:11 |
| *** martyturner has joined #openstack-manila | 13:13 | |
| *** Yogi has joined #openstack-manila | 13:14 | |
| *** rraja has joined #openstack-manila | 13:16 | |
| *** Zhongjun has joined #openstack-manila | 13:18 | |
| *** dustins has joined #openstack-manila | 13:18 | |
| *** timcl has quit IRC | 13:24 | |
| *** sgotliv has quit IRC | 13:28 | |
| *** rraja has quit IRC | 13:34 | |
| *** cknight has joined #openstack-manila | 13:34 | |
| *** lpetrut has quit IRC | 13:39 | |
| *** lpetrut has joined #openstack-manila | 13:39 | |
| *** xyang1 has joined #openstack-manila | 13:41 | |
| *** timcl has joined #openstack-manila | 13:42 | |
| toabctl | bswartz: does share migration already work with backends != generic ? | 13:48 |
| bswartz | toabctl: it should work okay with any backend that doesn't have share servers, and it should also work with the generic driver | 13:50 |
| bswartz | getting it to work with share servers in general didn't happen in liberty and should be worked on in mitaka | 13:50 |
| toabctl | bswartz: and is it using a share server to mount the src and dst share for copying? | 13:53 |
| toabctl | eh - not a share server. I mean any sort of external machine. | 13:54 |
| *** ktolstoy has left #openstack-manila | 13:56 | |
| *** a_ta has joined #openstack-manila | 13:57 | |
| *** Yogi has left #openstack-manila | 13:59 | |
| *** haomaiwang has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-manila | 14:01 | |
| bswartz | toabctl: current impl uses the m-shr node | 14:02 |
| bswartz | that really sucks and is another thing that needs improving in Mitaka | 14:02 |
| toabctl | bswartz: yeah. I remember that we talked about a dedicated migration service which can be placed on any node. | 14:02 |
| *** eharney has joined #openstack-manila | 14:03 | |
| *** EinstCrazy has joined #openstack-manila | 14:05 | |
| *** Yogi has joined #openstack-manila | 14:10 | |
| *** david-lyle has quit IRC | 14:11 | |
| *** david-lyle has joined #openstack-manila | 14:13 | |
| openstackgerrit | Merged openstack/manila: glusterfs_native: use dynamic-auth option if available https://review.openstack.org/229409 | 14:15 |
| *** EinstCrazy has quit IRC | 14:24 | |
| *** mtanino has joined #openstack-manila | 14:27 | |
| csaba | u_glide: ping | 14:28 |
| u_glide | csaba: pong | 14:28 |
| *** jasonsb has quit IRC | 14:30 | |
| csaba | u_glide: we have some setup where it seems that ominous for loop in manager.init_host over the share instances misses out some entries | 14:30 |
| u_glide | csaba: Could you please provide more details? | 14:31 |
| *** timcl has quit IRC | 14:31 | |
| csaba | u_glide: we observed that some errant behavior occurs which we traced down to ensure_share not being invoked on restart | 14:34 |
| csaba | u_glide: rraja added some logs to shed more light on it but I haven't seen that and he's off now. | 14:34 |
| csaba | u_glide: I just got access to the test setup, I'm to check it | 14:34 |
| *** timcl has joined #openstack-manila | 14:37 | |
| *** ganso has joined #openstack-manila | 14:38 | |
| *** markstur has joined #openstack-manila | 14:46 | |
| *** dsariel_ has quit IRC | 14:47 | |
| csaba | u_glide: so do you remember it was your contribution to use ensure_share to register the already existing shares's volumes with the driver on startup? | 14:53 |
| *** ayma has joined #openstack-manila | 14:53 | |
| u_glide | csaba: no it wasn't :) | 14:54 |
| u_glide | csaba: but you can share details and we will consider it together | 14:56 |
| csaba | u_glide: https://github.com/openstack/manila/commit/49e223e2e67797fb8887b0f7052b5f3c6969aa06#diff-b3aecadf35ea04da97e8c26fd719a28bR804 | 14:57 |
| *** haomaiwang has quit IRC | 14:59 | |
| u_glide | csaba: yes, I remember this commit | 15:00 |
| *** haomaiwang has joined #openstack-manila | 15:00 | |
| *** haomaiwang has quit IRC | 15:01 | |
| vponomaryov | bswartz: meeting? | 15:01 |
| csaba | u_glide: so that's where you do what I said you do... "self.gluster_used_vols_dict[vol] = gluster_mgr" <==> "register the already existing shares's volumes with the driver", "on startup" <===> "in ensure_share" | 15:01 |
| *** haomaiwa_ has joined #openstack-manila | 15:01 | |
| *** EinstCrazy has joined #openstack-manila | 15:01 | |
| u_glide | csaba: ok, it's clear now | 15:02 |
| csaba | u_glide: so it seems that's a fragile mechanism b/c ensure_share is called if only the share avaialbe | 15:03 |
| csaba | u_glide: and there might be a number of volumes around in unclean state that are still belonging to volumes in error or error_deleting or whatever weird state | 15:04 |
| csaba | s/belonging to volumes/belonging to shares/ | 15:04 |
| *** haomaiwa_ has quit IRC | 15:04 | |
| csaba | u_glide: and then those vols will not be registered as "used" through ensure_share so be avaialabe for being picked up at share creation ... yet they are in unclean state | 15:06 |
| u_glide | csaba: probably, but fixing broken shares should be handled via common api | 15:06 |
| u_glide | csaba: and not via checks with db calls | 15:06 |
| csaba | u_glide: I did not mean that broken shares should be fixed | 15:07 |
| *** ayma has quit IRC | 15:08 | |
| csaba | u_glide: I just meant that the volume allocation happened on their behalf should not be missed | 15:08 |
| u_glide | csaba: resource release == fixing broken shares in my terminology :) | 15:09 |
| csaba | u_glide: which API call can be used for that? | 15:09 |
| u_glide | csaba: this call should be implemented | 15:10 |
| u_glide | csaba: in other words it's not implemented yet | 15:11 |
| u_glide | csaba: but should | 15:11 |
| csaba | u_glide: so anyway I think now the driver is now can be called broken... do you have any idea of an applicable fix? | 15:11 |
| u_glide | csaba: retrying "unstable" operations is the best what you can do currently | 15:13 |
| u_glide | csaba: you should prevent somehow " unclean states" of shares | 15:14 |
| *** martyturner has quit IRC | 15:21 | |
| *** nkrinner has quit IRC | 15:21 | |
| jordanP | bswartz, vponomaryov I updated https://bugs.launchpad.net/manila/+bug/1500964 could you plz read my last comment and share your thought ? | 15:23 |
| openstack | Launchpad bug 1500964 in Manila "Manila-shr is auto restarted if exception is thrown in do_setup()" [Medium,New] - Assigned to Jordan Pittier (jordan-pittier) | 15:23 |
| *** martyturner has joined #openstack-manila | 15:25 | |
| openstackgerrit | Merged openstack/manila: Fix display of availability-zone for manila-manage command https://review.openstack.org/229798 | 15:29 |
| mmartin78 | quick question, what happened to IBM GPFS driver? did it get remove for Liberty? | 15:31 |
| bswartz | vponomaryov: it merged, backport is already done: https://review.openstack.org/#/c/229798/ | 15:32 |
| *** EinstCrazy has quit IRC | 15:36 | |
| vponomaryov | mmartin78: yes, it was removed, because it did not have Third-party CI | 15:38 |
| mmartin78 | will it be added back, any word from IBM? | 15:38 |
| vponomaryov | mmartin78: bswartz can spill the light on it | 15:39 |
| mmartin78 | thanks | 15:40 |
| mmartin78 | bswartz: any insight on GPFS driver? | 15:40 |
| xyang1 | bswartz: you want to talk to me? | 15:49 |
| csaba | bswartz: wrt. https://github.com/openstack/manila/blob/master/doc/source/devref/share_back_ends_feature_support_mapping.rst -- pls see https://review.openstack.org/229830 | 15:51 |
| *** ociuhandu has joined #openstack-manila | 15:52 | |
| bswartz | csaba: thanks | 15:58 |
| bswartz | csaba: sorry you got hit with my reminder I just copied all the maintainers that didn't have merged updates | 15:59 |
| csaba | bswartz: no problem | 15:59 |
| *** Yogi has quit IRC | 16:01 | |
| *** martyturner has quit IRC | 16:06 | |
| *** breitz has quit IRC | 16:14 | |
| *** breitz has joined #openstack-manila | 16:14 | |
| *** jasonsb_ has joined #openstack-manila | 16:20 | |
| *** ameade has quit IRC | 16:31 | |
| *** ameade has joined #openstack-manila | 16:33 | |
| *** vbellur has quit IRC | 16:33 | |
| *** martyturner has joined #openstack-manila | 16:39 | |
| *** amit213 has joined #openstack-manila | 16:43 | |
| *** vbellur has joined #openstack-manila | 16:47 | |
| *** Yogi has joined #openstack-manila | 16:47 | |
| *** erlon has joined #openstack-manila | 16:53 | |
| *** markstur_ has joined #openstack-manila | 16:59 | |
| openstackgerrit | Jordan Pittier proposed openstack/manila: Share manager: catch exception raised by driver's setup() https://review.openstack.org/230018 | 17:00 |
| openstackgerrit | Mark Sturdevant proposed openstack/manila: Feature support matrix update for HP 3PAR https://review.openstack.org/230019 | 17:02 |
| *** a_ta has quit IRC | 17:03 | |
| *** a_ta has joined #openstack-manila | 17:03 | |
| bswartz | jordanP | 17:04 |
| jordanP | bswartz, that's me | 17:04 |
| bswartz | https://review.openstack.org/230018 | 17:04 |
| bswartz | I don't see how this solves the issue | 17:05 |
| jordanP | bswartz, because the manila-share process will not crash | 17:05 |
| jordanP | bswartz, so it will not be restarted | 17:05 |
| bswartz | oh | 17:05 |
| bswartz | what was doing the restarting? | 17:05 |
| jordanP | oslo_service.service.ProcessLauncher | 17:05 |
| bswartz | aha | 17:05 |
| bswartz | thanks for tracking that down | 17:06 |
| jordanP | no pb; it's my job :) | 17:06 |
| bswartz | I think that must be a new thing | 17:07 |
| *** a_ta has quit IRC | 17:07 | |
| bswartz | because a long time ago when I was working on netapp drivers, I didn't see that happening | 17:07 |
| jordanP | bswartz, there's another issue, even worse: | 17:08 |
| jordanP | if a driver fails in its __init__ it will cause every driver to crash | 17:08 |
| jordanP | but it's another bug and I'll open a bug report for that too | 17:08 |
| bswartz | you mean in a multibackend scenario? | 17:09 |
| jordanP | yes | 17:09 |
| jordanP | https://github.com/openstack/manila/blob/master/manila/cmd/share.py#L49 | 17:09 |
| bswartz | well drivers shouldn't be doing anything that can fail in init... | 17:09 |
| jordanP | if the create call fails, the cmd command will quit immediately | 17:09 |
| bswartz | is there a legitimate reason to throw an exception in the driver class constructor? | 17:10 |
| jordanP | bswartz, I don't see any. | 17:10 |
| bswartz | in most languages, constructors are funky methods and throwing exceptions from them is discouraged | 17:11 |
| jordanP | but an import error or an instanciation of a 3rd party library error etc... | 17:11 |
| jordanP | we should be defensive imo | 17:11 |
| bswartz | 3rd partly libraries should be loaded in a later method | 17:11 |
| bswartz | anything that can fail, should not be done in the constructor IMO | 17:12 |
| jordanP | agreed but it's hard to enforce | 17:13 |
| jordanP | anyway, I have to go :) | 17:13 |
| *** lpetrut has quit IRC | 17:21 | |
| *** zhongjun2 has quit IRC | 17:36 | |
| *** jasonsb_ has quit IRC | 17:36 | |
| *** ociuhandu has quit IRC | 17:36 | |
| *** zhongjun2 has joined #openstack-manila | 17:36 | |
| *** jasonsb has joined #openstack-manila | 17:37 | |
| *** wilson1 has joined #openstack-manila | 17:37 | |
| *** wilson-1 has quit IRC | 17:40 | |
| *** porrua has quit IRC | 17:41 | |
| *** jordanP has quit IRC | 17:52 | |
| *** ganso has quit IRC | 17:55 | |
| *** Zhongjun has quit IRC | 17:57 | |
| *** ociuhandu has joined #openstack-manila | 17:58 | |
| *** jasonsb has quit IRC | 18:02 | |
| *** jasonsb has joined #openstack-manila | 18:02 | |
| *** markstur has quit IRC | 18:02 | |
| *** jasonsb has quit IRC | 18:04 | |
| *** jasonsb has joined #openstack-manila | 18:04 | |
| *** BharatK has quit IRC | 18:09 | |
| *** rraja has joined #openstack-manila | 18:21 | |
| *** openstackgerrit has quit IRC | 18:31 | |
| *** openstackgerrit has joined #openstack-manila | 18:31 | |
| *** timcl has quit IRC | 18:33 | |
| *** dzamboni has quit IRC | 18:42 | |
| *** a_ta has joined #openstack-manila | 18:49 | |
| *** martyturner has quit IRC | 19:01 | |
| *** martyturner has joined #openstack-manila | 19:03 | |
| *** ociuhandu has quit IRC | 19:09 | |
| *** rraja has quit IRC | 19:11 | |
| *** bill_az has quit IRC | 19:17 | |
| *** david-lyle has quit IRC | 19:18 | |
| *** david-lyle has joined #openstack-manila | 19:27 | |
| *** logan2 has quit IRC | 19:47 | |
| *** bill_az has joined #openstack-manila | 19:48 | |
| *** ociuhandu has joined #openstack-manila | 19:54 | |
| *** logan2 has joined #openstack-manila | 19:55 | |
| *** ociuhandu has quit IRC | 20:04 | |
| *** a_ta has quit IRC | 20:04 | |
| *** ociuhandu has joined #openstack-manila | 20:06 | |
| *** akerr has quit IRC | 20:31 | |
| *** martyturner has quit IRC | 20:32 | |
| *** breitz has quit IRC | 20:41 | |
| *** bill_az_ has joined #openstack-manila | 20:46 | |
| *** eharney has quit IRC | 20:53 | |
| *** ekarlso has quit IRC | 20:55 | |
| *** ekarlso has joined #openstack-manila | 20:58 | |
| *** bill_az has quit IRC | 21:08 | |
| *** dustins has quit IRC | 21:15 | |
| *** a_ta has joined #openstack-manila | 21:36 | |
| openstackgerrit | Merged openstack/manila: Feature support matrix update for HP 3PAR https://review.openstack.org/230019 | 21:37 |
| *** david-lyle has quit IRC | 21:43 | |
| *** Yogi has quit IRC | 21:51 | |
| *** cknight1 has joined #openstack-manila | 21:52 | |
| *** cknight has quit IRC | 21:54 | |
| *** david-lyle has joined #openstack-manila | 21:56 | |
| *** bill_az has joined #openstack-manila | 22:10 | |
| *** alyson_ has quit IRC | 22:11 | |
| *** ociuhandu has quit IRC | 22:17 | |
| *** gouthamr has quit IRC | 22:18 | |
| openstackgerrit | Merged openstack/manila: Share manager: catch exception raised by driver's setup() https://review.openstack.org/230018 | 22:25 |
| *** a_ta has quit IRC | 22:30 | |
| *** a_ta has joined #openstack-manila | 22:31 | |
| *** gouthamr has joined #openstack-manila | 22:32 | |
| *** xyang1 has quit IRC | 22:33 | |
| *** gouthamr_ has joined #openstack-manila | 22:34 | |
| *** a_ta has quit IRC | 22:35 | |
| *** gouthamr has quit IRC | 22:37 | |
| *** zhongjun2 has quit IRC | 22:45 | |
| *** zhongjun2 has joined #openstack-manila | 22:45 | |
| *** cknight1 has quit IRC | 22:50 | |
| *** dsariel_ has joined #openstack-manila | 22:52 | |
| *** jasonsb has quit IRC | 23:03 | |
| *** chlong has quit IRC | 23:07 | |
| *** akerr has joined #openstack-manila | 23:07 | |
| *** akerr_ has joined #openstack-manila | 23:13 | |
| *** akerr has quit IRC | 23:16 | |
| *** akerr_ has quit IRC | 23:19 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!