| *** cknight has joined #openstack-manila | 00:40 | |
| *** cknight has quit IRC | 00:50 | |
| *** cknight has joined #openstack-manila | 00:50 | |
| *** cknight1 has joined #openstack-manila | 00:53 | |
| *** cknight1 has quit IRC | 00:54 | |
| *** cknight1 has joined #openstack-manila | 00:54 | |
| *** cknight has quit IRC | 00:55 | |
| *** cknight has joined #openstack-manila | 01:01 | |
| *** cknight1 has quit IRC | 01:03 | |
| *** david-ly_ has joined #openstack-manila | 01:06 | |
| *** david-lyle has quit IRC | 01:09 | |
| *** jasonsb has quit IRC | 01:11 | |
| *** chen12 has joined #openstack-manila | 01:20 | |
| *** cknight has quit IRC | 01:34 | |
| *** cknight has joined #openstack-manila | 01:34 | |
| *** amoturi has quit IRC | 01:45 | |
| *** echoingumesh has quit IRC | 01:49 | |
| *** echoingumesh has joined #openstack-manila | 01:49 | |
| *** cknight has quit IRC | 01:50 | |
| *** echoingumesh has quit IRC | 01:53 | |
| *** BitSmith has joined #openstack-manila | 01:58 | |
| *** BitSmith is now known as [BitSmith] | 02:03 | |
| *** [BitSmith] is now known as BitSmith | 02:03 | |
| *** BitSmith has quit IRC | 02:09 | |
| *** BitSmith has joined #openstack-manila | 02:12 | |
| *** jasonsb has joined #openstack-manila | 02:14 | |
| *** BitSmith has quit IRC | 02:34 | |
| *** lpabon has quit IRC | 02:47 | |
| *** esker has joined #openstack-manila | 02:54 | |
| *** esker has quit IRC | 02:54 | |
| *** esker has joined #openstack-manila | 02:55 | |
| *** jasonsb has quit IRC | 03:05 | |
| *** jasonsb has joined #openstack-manila | 03:06 | |
| *** xyang1 has quit IRC | 03:09 | |
| *** jasonsb has quit IRC | 03:10 | |
| *** xyang1 has joined #openstack-manila | 03:14 | |
| *** david-ly_ is now known as david-lyle | 03:51 | |
| *** lpetrut has joined #openstack-manila | 03:52 | |
| *** jasonsb has joined #openstack-manila | 03:55 | |
| *** xyang1 has quit IRC | 04:15 | |
| *** lpetrut has quit IRC | 04:34 | |
| *** rraja has joined #openstack-manila | 04:39 | |
| *** mtanino has joined #openstack-manila | 05:43 | |
| *** kaisers has quit IRC | 05:51 | |
| *** kaisers has joined #openstack-manila | 05:53 | |
| *** mtanino is now known as mtanino_zzz | 06:00 | |
| *** mtanino_zzz has quit IRC | 06:14 | |
| *** lpetrut has joined #openstack-manila | 06:36 | |
| *** lpetrut has quit IRC | 07:00 | |
| *** chen12 has quit IRC | 07:07 | |
| *** chen12 has joined #openstack-manila | 07:07 | |
| *** lpetrut has joined #openstack-manila | 07:10 | |
| *** lpetrut has quit IRC | 07:14 | |
| *** rcallawa has quit IRC | 08:55 | |
| *** breitz has quit IRC | 09:05 | |
| *** breitz has joined #openstack-manila | 09:06 | |
| openstackgerrit | Xingchao Yu proposed openstack/puppet-manila: Update README.md for project namespace change https://review.openstack.org/195942 | 09:17 |
|---|---|---|
| openstackgerrit | Xingchao Yu proposed openstack/puppet-manila: Update README.md for project namespace change https://review.openstack.org/195942 | 09:46 |
| *** rcallawa has joined #openstack-manila | 10:28 | |
| *** rcallawa has quit IRC | 10:29 | |
| *** rcallawa has joined #openstack-manila | 10:29 | |
| *** rcallawa has quit IRC | 10:55 | |
| *** sgotliv has quit IRC | 11:18 | |
| *** sgotliv has joined #openstack-manila | 11:19 | |
| *** lpetrut has joined #openstack-manila | 11:25 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Implement shrink_share() method in Generic driver https://review.openstack.org/190037 | 11:30 |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Implement shrink_share() method in Generic driver https://review.openstack.org/190037 | 11:33 |
| *** rraja has quit IRC | 11:48 | |
| *** BitSmith has joined #openstack-manila | 11:53 | |
| *** BitSmith is now known as [BitSmith] | 11:53 | |
| *** timcl has joined #openstack-manila | 11:59 | |
| *** rraja has joined #openstack-manila | 12:02 | |
| *** [BitSmith] is now known as BitSmith | 12:04 | |
| *** BitSmith is now known as [BitSmith] | 12:05 | |
| *** [BitSmith] is now known as BitSmith | 12:06 | |
| *** akerr has joined #openstack-manila | 12:11 | |
| *** cknight has joined #openstack-manila | 12:25 | |
| *** bswartz has quit IRC | 12:26 | |
| *** cknight has quit IRC | 12:33 | |
| *** rraja has quit IRC | 12:35 | |
| openstackgerrit | Julia Varlamova proposed openstack/manila: Add PoolWeigher for Manila scheduler https://review.openstack.org/184053 | 12:52 |
| openstackgerrit | Julia Varlamova proposed openstack/manila: Remove duplicated options in manila/opts.py https://review.openstack.org/196038 | 13:00 |
| *** kaisers has quit IRC | 13:11 | |
| *** kaisers has joined #openstack-manila | 13:13 | |
| *** bswartz has joined #openstack-manila | 13:19 | |
| *** csaba1 has joined #openstack-manila | 13:28 | |
| *** csaba has quit IRC | 13:28 | |
| *** dustins has joined #openstack-manila | 13:31 | |
| *** cknight has joined #openstack-manila | 13:45 | |
| *** cknight has quit IRC | 13:56 | |
| *** cknight has joined #openstack-manila | 13:56 | |
| *** eharney has joined #openstack-manila | 14:00 | |
| *** cknight has quit IRC | 14:04 | |
| *** amoturi has joined #openstack-manila | 14:14 | |
| openstackgerrit | Tom Barron proposed openstack/manila: More Manila cDOT qualified specs https://review.openstack.org/195699 | 14:25 |
| tbarron | markstur: bswartz: I updated the commit message ^^^^^ to point to a current BP | 14:27 |
| *** sgotliv has quit IRC | 14:34 | |
| *** lpabon has joined #openstack-manila | 14:41 | |
| *** xyang1 has joined #openstack-manila | 14:43 | |
| *** jasonsb has quit IRC | 15:03 | |
| *** jasonsb has joined #openstack-manila | 15:04 | |
| *** timcl has quit IRC | 15:06 | |
| *** jasonsb has quit IRC | 15:08 | |
| *** JuliaOdruzova has joined #openstack-manila | 15:18 | |
| *** DericHorn-HP has joined #openstack-manila | 15:23 | |
| *** rcallawa has joined #openstack-manila | 15:29 | |
| *** rcallawa has quit IRC | 15:31 | |
| *** rcallawa has joined #openstack-manila | 15:32 | |
| *** DericHorn-HP has quit IRC | 15:36 | |
| *** jasonsb has joined #openstack-manila | 15:48 | |
| *** amoturi has quit IRC | 15:55 | |
| *** zaitcev has joined #openstack-manila | 15:57 | |
| *** markstur has quit IRC | 15:58 | |
| *** rcallawa_ has joined #openstack-manila | 16:00 | |
| *** markstur has joined #openstack-manila | 16:00 | |
| *** rcallawa has quit IRC | 16:01 | |
| *** jasonsb has quit IRC | 16:02 | |
| *** rcallawa_ has quit IRC | 16:03 | |
| *** rcallawa has joined #openstack-manila | 16:04 | |
| *** DericHorn-HP has joined #openstack-manila | 16:11 | |
| *** BitSmith is now known as [BitSmith] | 16:17 | |
| *** JuliaOdruzova has quit IRC | 16:19 | |
| *** [BitSmith] is now known as BitSmith | 16:20 | |
| *** BitSmith is now known as [BitSmith] | 16:20 | |
| *** [BitSmith] is now known as BitSmith | 16:21 | |
| *** BitSmith is now known as [BitSmith] | 16:21 | |
| *** [BitSmith] is now known as BitSmith | 16:22 | |
| *** bill_az has joined #openstack-manila | 16:26 | |
| *** absubram has joined #openstack-manila | 16:35 | |
| *** absubram has quit IRC | 16:36 | |
| *** absubram has joined #openstack-manila | 16:37 | |
| bswartz | tbarron: it's targeted now | 16:41 |
| *** eharney has quit IRC | 17:05 | |
| *** bswartz has quit IRC | 17:07 | |
| *** ameade is now known as ameade_vacation | 17:16 | |
| *** eharney has joined #openstack-manila | 17:21 | |
| *** eharney has quit IRC | 17:25 | |
| *** eharney has joined #openstack-manila | 17:26 | |
| *** bswartz has joined #openstack-manila | 17:30 | |
| *** timcl has joined #openstack-manila | 17:30 | |
| *** jasonsb has joined #openstack-manila | 17:36 | |
| *** echoingumesh has joined #openstack-manila | 17:39 | |
| *** amoturi has joined #openstack-manila | 17:39 | |
| *** echoingumesh has quit IRC | 17:56 | |
| *** echoingumesh has joined #openstack-manila | 17:56 | |
| *** akerr has quit IRC | 18:04 | |
| markstur | bswartz, https://blueprints.launchpad.net/manila/+spec/share-server-pool-mapping | 18:05 |
| tbarron | bswartz: thanks! | 18:06 |
| markstur | bswartz, I did a recheck. I'd like to see the no-SS test pass. But otherwise that BP looks close to appoval. | 18:07 |
| bswartz | markstur: actually the BP should have been approved before the work was done -- this is just backwards process due to me not paying attention | 18:08 |
| bswartz | regarding the failed test, did you investigate that failure, or you're just hoping it's transient? | 18:08 |
| markstur | bswartz, The devstack failed to start manila. Related to the service image I think... But that said... I'm hoping it's transient. | 18:09 |
| markstur | bswartz, Regarding BP's. I think we could all use some clarification on your expectations there. | 18:10 |
| bswartz | hmm | 18:11 |
| bswartz | maybe it's a weekly meeting topic then | 18:11 |
| markstur | bswartz, I don't want "more process", but it seems we aren't following the process much. E.g. when can we skip BP's. | 18:11 |
| bswartz | I'm happy to talk about it here | 18:11 |
| bswartz | oh yes I'm against adding more process, but we should follow the process we do have, and BPs are part of that | 18:11 |
| markstur | bswartz, I think a weekly meeting thing would be best. Just to reiterate expecations. | 18:11 |
| bswartz | actually now that I think about it, markstur you're the only one who is new to manila core who doesn't also have experience with other/previous openstack projects | 18:12 |
| *** DericHorn-HP has quit IRC | 18:12 | |
| *** DericHorn-HP has joined #openstack-manila | 18:13 | |
| markstur | bswartz, Hey! I worked on Cinder | 18:13 |
| bswartz | oh really? sorry I didn't know that :-[ | 18:13 |
| markstur | bswartz, I was confused about their process too | 18:13 |
| bswartz | were you working on cinder for long? | 18:13 |
| markstur | Just Juno and some early Kilo commits | 18:14 |
| bswartz | ok | 18:14 |
| markstur | but I was hit with the "should have a BP or bug" request | 18:14 |
| bswartz | yeah I'll cover the expectations right here, we don't need a meeting topic | 18:15 |
| bswartz | this channel is now logged too so people could go back and read the log if they wish... | 18:15 |
| bswartz | basically the rule is that every gerrit change that affects code should either reference a bug or a blueprint | 18:16 |
| bswartz | some gerrit changes only affect docs or requirements or other procedural things and they are excepted from this requirement | 18:16 |
| bswartz | but for code changes, we always want a reference | 18:16 |
| markstur | we've been letting a lot of general goodness, tests, etc skip that process | 18:17 |
| bswartz | so changes that fix bugs should naturally reference a bug in LP, and that bug should ideally be targeted at the current release/milestone | 18:17 |
| *** DericHorn-HP has quit IRC | 18:17 | |
| bswartz | in code freeze times, we ONLY allow bugfixes to merge if they're correctly targeted | 18:17 |
| *** DericHorn-HP has joined #openstack-manila | 18:18 | |
| bswartz | blueprints are similar to bugs but for changes that implement new things | 18:18 |
| bswartz | the theory is that you propose the BP first, and get general agreement on the idea | 18:18 |
| bswartz | the BP is approved and targeted, then you start working on the code | 18:18 |
| markstur | "theory" :) | 18:19 |
| bswartz | and BP can be a few sentences for a trivial and/or obvious new feature, or it can link to a large wiki if it's a major new feature | 18:19 |
| bswartz | but then the code that implements the BP should reference it, so reviewers can understand what the point of the new code that they are reviewing is | 18:19 |
| *** jasonsb has quit IRC | 18:20 | |
| bswartz | we sometimes skip the BP proposing step and write the code first, either because the feature was actually discussed in some forum like the design summit or a weekly meeting, but there's really not a good reason to skip the BP step because it's so easy | 18:21 |
| *** jasonsb has joined #openstack-manila | 18:21 | |
| bswartz | what we want to happen is for all of the actively-worked-on new features they all have BPs and they're all targeted at milestones and prioritized. then reviewers can start their job from the launchpad page rather than the gerrit page to find out what needs reviewing most urgently | 18:22 |
| bswartz | liberty has been a mess both because lots of new features were proposed and then we discovered they have complex interactions (see: migration, AZs, replication) and because I've been slacking on my PTL job due to the new baby | 18:23 |
| bswartz | during L-2 I'm going to be more strict about features needing BPs | 18:24 |
| bswartz | and that's a topic I guess I do need to bring up at the weekly meeting | 18:24 |
| bswartz | because the whole core team needs to enforce the rules the same | 18:24 |
| *** dustins has quit IRC | 18:38 | |
| *** echoingumesh has quit IRC | 18:44 | |
| *** echoingumesh has joined #openstack-manila | 18:44 | |
| *** echoingumesh has quit IRC | 18:49 | |
| markstur | Thanks, Ben | 18:49 |
| openstackgerrit | Clinton Knight proposed openstack/manila: Enable Manila multi-SVM driver on NetApp cDOT 8.3 https://review.openstack.org/196184 | 18:50 |
| *** timcl has left #openstack-manila | 19:32 | |
| bswartz | markstur: https://review.openstack.org/#/c/184053/ | 19:32 |
| bswartz | looks like you got your wish | 19:32 |
| markstur | bswartz, Had my fingers crossed the whole time | 19:33 |
| markstur | I'm reviewing it now. It looks well-reviewed already, but I'm behind. | 19:33 |
| *** jasonsb has quit IRC | 19:37 | |
| openstackgerrit | Merged openstack/manila: More Manila cDOT qualified specs https://review.openstack.org/195699 | 19:39 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-manila: acceptance: install RDO repo the right way https://review.openstack.org/196212 | 19:49 |
| *** amoturi has quit IRC | 20:27 | |
| openstackgerrit | Merged openstack/manila: Add PoolWeigher for Manila scheduler https://review.openstack.org/184053 | 20:41 |
| openstackgerrit | Mark Sturdevant proposed openstack/manila: Remove duplicated options in manila/opts.py https://review.openstack.org/196038 | 20:45 |
| bswartz | markstur: :) | 20:46 |
| markstur | struggling with that | 20:46 |
| bswartz | yeah this is perhaps a case where the bug was unneccesary | 20:47 |
| bswartz | but it doesn't hurt to create a bug | 20:47 |
| markstur | bswartz, I didn't do anything there that will take credit from Julia did I | 20:47 |
| bswartz | it will give better visibility in LP at the very least | 20:47 |
| bswartz | no the committer is unimportant | 20:47 |
| bswartz | the author always gets credit | 20:47 |
| bswartz | you can steal authorship (and I've seen it done) but you didn't do that | 20:48 |
| markstur | Yeah. Was wishing it was a more significant "bug". But after today's conversation I didn't want to just push it thru | 20:48 |
| markstur | bswartz, Can you assign the bug to her? | 20:48 |
| bswartz | the main thing about the committer field is that it tells you who's login was used to push the patch so if something evil gets added you know who to go after | 20:49 |
| *** xyang1 has quit IRC | 20:50 | |
| *** BitSmith has quit IRC | 20:51 | |
| *** sgotliv has joined #openstack-manila | 20:52 | |
| *** lpetrut has quit IRC | 21:09 | |
| *** openstack has joined #openstack-manila | 21:25 | |
| *** DericHorn-HP has quit IRC | 21:34 | |
| *** DericHorn-HP has joined #openstack-manila | 22:18 | |
| *** DericHorn-HP has quit IRC | 22:19 | |
| *** DericHorn-HP has joined #openstack-manila | 22:40 | |
| *** absubram has quit IRC | 22:48 | |
| *** pgbridge has quit IRC | 23:12 | |
| *** jasonsb has joined #openstack-manila | 23:13 | |
| *** ekarlso has quit IRC | 23:18 | |
| *** ekarlso has joined #openstack-manila | 23:18 | |
| *** DericHorn-HP has quit IRC | 23:27 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!