| *** chen12 has joined #openstack-manila | 00:25 | |
| *** mtanino has quit IRC | 00:49 | |
| *** chen12 has quit IRC | 01:03 | |
| *** cknight has joined #openstack-manila | 01:21 | |
| *** haomaiwa_ has quit IRC | 01:26 | |
| *** haomaiwa_ has joined #openstack-manila | 01:28 | |
| *** cknight has quit IRC | 02:02 | |
| *** cknight has joined #openstack-manila | 02:06 | |
| *** mtanino has joined #openstack-manila | 02:09 | |
| *** chen12 has joined #openstack-manila | 02:10 | |
| *** mtanino has quit IRC | 03:00 | |
| *** cknight1 has joined #openstack-manila | 03:23 | |
| *** cknight has quit IRC | 03:23 | |
| *** tobe4333 has joined #openstack-manila | 03:48 | |
| openstackgerrit | Merged openstack/manila: ganesha: Add doc https://review.openstack.org/165482 | 04:01 |
|---|---|---|
| *** tobe4333 has quit IRC | 04:20 | |
| *** sgotliv has joined #openstack-manila | 04:23 | |
| *** sgotliv has quit IRC | 04:30 | |
| *** cknight1 has quit IRC | 04:35 | |
| *** deepakcs has joined #openstack-manila | 04:58 | |
| *** sgotliv has joined #openstack-manila | 05:00 | |
| *** sks has joined #openstack-manila | 05:04 | |
| openstackgerrit | Merged openstack/manila: Fix share-server resources cleanup in generic driver https://review.openstack.org/181380 | 05:25 |
| openstackgerrit | Merged openstack/manila: Make generic driver use only ipv4 addresses from service instances https://review.openstack.org/183158 | 05:33 |
| *** sgotliv has quit IRC | 05:48 | |
| *** rraja has joined #openstack-manila | 05:49 | |
| *** zaitcev has quit IRC | 05:57 | |
| *** ajo has joined #openstack-manila | 06:21 | |
| *** lpetrut has joined #openstack-manila | 06:21 | |
| *** chlong has quit IRC | 07:32 | |
| *** tobe4333 has joined #openstack-manila | 07:44 | |
| *** tobe4333 has quit IRC | 08:07 | |
| *** lpetrut has quit IRC | 08:07 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Add share extend API https://review.openstack.org/182377 | 08:17 |
| openstackgerrit | Igor Malinovskiy proposed openstack/python-manilaclient: Add share extend API https://review.openstack.org/182606 | 08:29 |
| *** sgotliv has joined #openstack-manila | 09:09 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Release Neutron ports after share server deletion using generic driver https://review.openstack.org/181470 | 09:23 |
| *** deepakcs has quit IRC | 09:30 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Release Neutron ports after share server deletion using generic driver https://review.openstack.org/181470 | 09:40 |
| *** sgotliv has quit IRC | 09:40 | |
| *** vbellur has joined #openstack-manila | 09:41 | |
| *** lpetrut has joined #openstack-manila | 09:42 | |
| *** Zhongjun has joined #openstack-manila | 09:48 | |
| *** u_glide has quit IRC | 10:20 | |
| *** tobe4333 has joined #openstack-manila | 10:27 | |
| *** u_glide has joined #openstack-manila | 10:29 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Implement extend_share() method in Generic driver https://review.openstack.org/182383 | 10:32 |
| *** ajo has quit IRC | 10:33 | |
| *** rcallawa has quit IRC | 11:02 | |
| *** rcallawa has joined #openstack-manila | 11:02 | |
| *** tobe4333 has quit IRC | 11:07 | |
| *** rraja has quit IRC | 11:08 | |
| *** cknight has joined #openstack-manila | 11:10 | |
| *** sgotliv has joined #openstack-manila | 11:35 | |
| *** sgotliv has quit IRC | 11:36 | |
| *** sgotliv has joined #openstack-manila | 11:36 | |
| *** marcusvrn1 has joined #openstack-manila | 11:50 | |
| *** dencaval has joined #openstack-manila | 11:51 | |
| *** dencaval has left #openstack-manila | 11:52 | |
| *** marcusvrn has quit IRC | 11:52 | |
| *** marcusvrn1 has quit IRC | 11:57 | |
| *** marcusvrn has joined #openstack-manila | 11:59 | |
| *** rcallawa has quit IRC | 11:59 | |
| *** Zhongjun has quit IRC | 11:59 | |
| *** marcusvrn1 has joined #openstack-manila | 12:02 | |
| *** marcusvrn has quit IRC | 12:03 | |
| *** marcusvrn has joined #openstack-manila | 12:08 | |
| *** marcusvrn1 has quit IRC | 12:08 | |
| *** ajo has joined #openstack-manila | 12:09 | |
| *** ajo has quit IRC | 12:13 | |
| *** marcusvrn has quit IRC | 12:16 | |
| *** marcusvrn has joined #openstack-manila | 12:18 | |
| *** marcusvrn has quit IRC | 12:32 | |
| *** marcusvrn has joined #openstack-manila | 12:36 | |
| *** timcl has joined #openstack-manila | 12:36 | |
| *** cknight has quit IRC | 12:42 | |
| *** cknight has joined #openstack-manila | 12:42 | |
| *** rcallawa has joined #openstack-manila | 12:45 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Add share extend API https://review.openstack.org/182377 | 12:50 |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Implement extend_share() method in Generic driver https://review.openstack.org/182383 | 12:50 |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Implement tempest tests for share extend API https://review.openstack.org/183497 | 12:50 |
| *** bswartz has quit IRC | 12:52 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Export custom Share model properties with _extra_keys https://review.openstack.org/180971 | 13:10 |
| *** sks has quit IRC | 13:12 | |
| *** erlon has joined #openstack-manila | 13:22 | |
| *** timcl has quit IRC | 13:27 | |
| *** bswartz has joined #openstack-manila | 13:29 | |
| *** dustins has joined #openstack-manila | 13:33 | |
| *** sgotliv has quit IRC | 13:42 | |
| *** marcusvrn has quit IRC | 13:43 | |
| *** marcusvrn has joined #openstack-manila | 13:44 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Implement tempest tests for share extend API https://review.openstack.org/183497 | 13:46 |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Add share extend API https://review.openstack.org/182377 | 13:50 |
| *** fthiagogv has joined #openstack-manila | 13:54 | |
| openstackgerrit | Merged openstack/manila: Release Neutron ports after share server deletion using generic driver https://review.openstack.org/181470 | 13:58 |
| *** timcl has joined #openstack-manila | 14:05 | |
| *** eharney has joined #openstack-manila | 14:18 | |
| *** rushil has joined #openstack-manila | 14:18 | |
| *** rushil has quit IRC | 14:31 | |
| *** lpetrut has quit IRC | 14:53 | |
| *** rushil has joined #openstack-manila | 14:55 | |
| *** rushil has quit IRC | 14:57 | |
| *** rushil has joined #openstack-manila | 15:03 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Implement tempest tests for share extend API https://review.openstack.org/183497 | 15:08 |
| *** sks has joined #openstack-manila | 15:15 | |
| *** mtanino has joined #openstack-manila | 15:29 | |
| *** lpetrut has joined #openstack-manila | 15:30 | |
| *** jasonsb has quit IRC | 15:30 | |
| *** jasonsb has joined #openstack-manila | 15:31 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Add share extend API https://review.openstack.org/182377 | 15:31 |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Implement extend_share() method in Generic driver https://review.openstack.org/182383 | 15:32 |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Implement tempest tests for share extend API https://review.openstack.org/183497 | 15:32 |
| *** jasonsb has quit IRC | 15:36 | |
| openstackgerrit | Deliang Fan proposed openstack/manila: Add SSL middleware to fix incorrect version host_url https://review.openstack.org/180483 | 15:38 |
| *** timcl has quit IRC | 15:38 | |
| *** rushil has quit IRC | 15:52 | |
| *** marcusvrn has quit IRC | 15:52 | |
| *** rushil has joined #openstack-manila | 15:53 | |
| *** marcusvrn has joined #openstack-manila | 15:58 | |
| *** rushil has quit IRC | 15:59 | |
| *** ganso has joined #openstack-manila | 16:00 | |
| *** xyang1 has quit IRC | 16:08 | |
| *** xyang1 has joined #openstack-manila | 16:09 | |
| *** u_glide has quit IRC | 16:12 | |
| openstackgerrit | Deliang Fan proposed openstack/manila: Add SSL middleware to fix incorrect version host_url https://review.openstack.org/180483 | 16:24 |
| *** timcl has joined #openstack-manila | 16:28 | |
| *** marcusvrn has quit IRC | 16:29 | |
| *** marcusvrn has joined #openstack-manila | 16:30 | |
| *** cknight has quit IRC | 16:32 | |
| *** jasonsb has joined #openstack-manila | 16:33 | |
| *** rushil has joined #openstack-manila | 16:50 | |
| *** cknight has joined #openstack-manila | 17:04 | |
| *** marcusvrn1 has joined #openstack-manila | 17:06 | |
| *** marcusvrn has quit IRC | 17:09 | |
| *** marcusvrn1 has quit IRC | 17:17 | |
| *** marcusvrn has joined #openstack-manila | 17:22 | |
| openstackgerrit | Deliang Fan proposed openstack/manila: Add SSL middleware to fix incorrect version host_url https://review.openstack.org/180483 | 17:40 |
| *** marcusvrn has quit IRC | 17:48 | |
| *** marcusvrn has joined #openstack-manila | 17:50 | |
| *** sks has quit IRC | 17:54 | |
| ganso | vponomaryov: ping | 17:58 |
| vponomaryov | ganso: pong | 17:59 |
| ganso | vponomaryov: Hello! I have a question for u_glide but he is not here right now, I was wondering if you could help me | 18:00 |
| vponomaryov | lets try =) | 18:00 |
| ganso | vponomaryov: please, take a look at this https://review.openstack.org/#/c/177679/9/manila/share/drivers/generic.py | 18:00 |
| vponomaryov | line? | 18:00 |
| ganso | sorry, line 528 | 18:01 |
| vponomaryov | 528? it is unchanged | 18:01 |
| ganso | self.private_storage.delete(share['id']) | 18:02 |
| vponomaryov | 554 | 18:02 |
| vponomaryov | it deletes data from storage | 18:02 |
| vponomaryov | after share deletion | 18:02 |
| ganso | weird, it shows 528 for me | 18:03 |
| ganso | anyway | 18:03 |
| ganso | vponomaryov: I am concerned about the responsibility of deleting a share's private data being delegated to drivers | 18:03 |
| vponomaryov | it is soft deletion as in whole openstack | 18:04 |
| vponomaryov | all data will be set as 'deleted' as well as share in 'shares' table | 18:04 |
| ganso | vponomaryov: since private share data is indexed by share_id, if the share is deleted, I think the Manager should remove the share's private data | 18:04 |
| *** rcallawa_ has joined #openstack-manila | 18:04 | |
| *** vbellur has quit IRC | 18:04 | |
| vponomaryov | it is private driver storage | 18:05 |
| vponomaryov | driver updates it | 18:05 |
| ganso | vponomaryov: I understand that, but if I comment that line, and delete the share, the private data remains without being set as deleted | 18:05 |
| vponomaryov | so, why not delete it within driver? | 18:05 |
| ganso | vponomaryov: yes, that's what I would like your opinion about | 18:05 |
| *** rcallawa has quit IRC | 18:05 | |
| ganso | vponomaryov: If it is private share data, should I handle it from the manager when doing migration? | 18:06 |
| vponomaryov | doing it you force driver to use private storage | 18:06 |
| ganso | vponomaryov: I am not sure if Manager should be able to touch that or not | 18:06 |
| vponomaryov | each driver | 18:06 |
| ganso | vponomaryov: I was thinking about migrating the share's private data when I migrate it | 18:07 |
| ganso | vponomaryov: like, one of the fields is "host", I need to update that | 18:07 |
| vponomaryov | where? DB record should be the same | 18:07 |
| vponomaryov | right, manager will update host | 18:07 |
| vponomaryov | and driver will write all private data if any | 18:07 |
| vponomaryov | the former is a must, but the latter is optional | 18:08 |
| ganso | hummm | 18:08 |
| ganso | I have one other question | 18:09 |
| vponomaryov | yes? | 18:10 |
| ganso | vponomaryov: I am thinking about creating the physical share on destination backend without creating a DB entry, like you suggested... I am a bit lost on how to track the reference to that physical share without creating its DB entry and without saving something on the original share_id private share data myself | 18:11 |
| vponomaryov | ganso: this case is Ok to use from manager | 18:12 |
| vponomaryov | ganso: originally you asked about deletion | 18:12 |
| ganso | vponomaryov: I could delegate to driver to save the physical share ID or other info in private share data when doing migration, I don't know if it looks ugly or wrong implementing it in base driver class, since Manager should not touch it | 18:12 |
| vponomaryov | why should not? | 18:13 |
| *** rushil has quit IRC | 18:13 | |
| ganso | because, it's the driver's private storage | 18:13 |
| vponomaryov | right, but is there a harm to use it by both? | 18:14 |
| ganso | you just said it is ok, but looks conceptually wrong | 18:14 |
| vponomaryov | share deletion is required feature | 18:15 |
| vponomaryov | migration is not | 18:15 |
| ganso | ok, so when I am doing migration, the Manager may use the share's private storage to handle temporary data? | 18:16 |
| vponomaryov | yes, because there is real need | 18:17 |
| vponomaryov | required for migration, but not specific driver | 18:17 |
| vponomaryov | you will use two drivers | 18:17 |
| vponomaryov | each driver for itself can write any data | 18:18 |
| vponomaryov | and delete too | 18:18 |
| vponomaryov | that is done on line 528/544 | 18:18 |
| ganso | yes, that is another problem when creating a physical share not associated with an ID | 18:19 |
| *** rushil has joined #openstack-manila | 18:19 | |
| vponomaryov | why not associated? | 18:19 |
| vponomaryov | with original one - you will be able to write to private storage only by ID | 18:19 |
| *** timcl has left #openstack-manila | 18:20 | |
| ganso | ok so if I use the original ID, the create_share method in the destination backend will save any private data it wants based on that share's ID key, it may even overwrite private share data that was already there, added by the source backend | 18:20 |
| vponomaryov | could be | 18:21 |
| vponomaryov | if driver does not use prefixes | 18:21 |
| ganso | the "create_share" method in the destination backend does not know it is being called for a migration purpose | 18:22 |
| *** openstackgerrit has quit IRC | 18:22 | |
| ganso | if drivers are not aware of this situation, it could possibly lead to a mess | 18:22 |
| *** openstackgerrit has joined #openstack-manila | 18:22 | |
| ganso | I am trying to implement it in a way that requires less effort from drivers in the Generic Migration approach | 18:24 |
| *** sgotliv has joined #openstack-manila | 18:24 | |
| vponomaryov | ganso: then use different driver method than "create" | 18:25 |
| vponomaryov | ganso: it would be indeed more correct | 18:25 |
| *** sgotliv has quit IRC | 18:26 | |
| ganso | vponomaryov: so far, I am analyzing advantages and disadvantages or using Temp DB entry vs not using | 18:26 |
| *** sgotliv has joined #openstack-manila | 18:26 | |
| ganso | vponomaryov: Creating another method and forcing drivers to implement both "create_share" and "create_share_for_migration" looks like more complicated to driver vendors than using a temp DB entry that driver vendors do not need to worry about | 18:27 |
| vponomaryov | ganso: we should allow drivers do something special | 18:28 |
| vponomaryov | ganso: not expecting that it is totally the same as creation | 18:28 |
| vponomaryov | from scratch | 18:28 |
| ganso | vponomaryov: they can, in Migration, the first thing we do is call driver.migrate_share so they can migrate themselves in an optimized way if possible | 18:28 |
| ganso | vponomaryov: at this moment I do not see a situation where it would need to be different than a standard creation | 18:29 |
| *** cknight has quit IRC | 18:32 | |
| *** cknight has joined #openstack-manila | 18:32 | |
| vponomaryov | ganso: by, default we can use "creation" in "migration" and allow any driver redefine it | 18:36 |
| vponomaryov | letting do it we do not lose nothing | 18:36 |
| vponomaryov | but provide more possibilities | 18:36 |
| vponomaryov | now I have to go | 18:37 |
| ganso | vponomaryov: ok, thanks a lot for the help! :) | 18:37 |
| vponomaryov | bye =) | 18:38 |
| ganso | vponomaryov: bye :) | 18:38 |
| *** marcusvrn has quit IRC | 18:40 | |
| *** vponomaryov has quit IRC | 18:42 | |
| *** rushil has quit IRC | 18:43 | |
| *** marcusvrn has joined #openstack-manila | 18:44 | |
| *** marcusvrn has quit IRC | 18:48 | |
| *** rushil has joined #openstack-manila | 18:52 | |
| *** marcusvrn has joined #openstack-manila | 18:57 | |
| *** ajo has joined #openstack-manila | 19:15 | |
| *** ajo has quit IRC | 19:20 | |
| *** sgotliv has quit IRC | 19:35 | |
| *** dustins has quit IRC | 19:37 | |
| *** rushil has quit IRC | 19:42 | |
| *** rcallawa_ has quit IRC | 19:49 | |
| *** cknight has quit IRC | 19:50 | |
| *** lpabon has joined #openstack-manila | 20:01 | |
| lpabon | bswartz: ping | 20:01 |
| *** marcusvrn has quit IRC | 20:02 | |
| *** fthiagogv has quit IRC | 20:07 | |
| *** jasonsb_ has joined #openstack-manila | 20:13 | |
| *** jasonsb has quit IRC | 20:13 | |
| *** zaitcev has joined #openstack-manila | 20:18 | |
| *** rcallawa has joined #openstack-manila | 20:21 | |
| *** rcallawa has quit IRC | 20:26 | |
| *** ganso has quit IRC | 20:27 | |
| *** ajo has joined #openstack-manila | 20:34 | |
| *** bswartz has quit IRC | 20:42 | |
| *** rcallawa has joined #openstack-manila | 20:56 | |
| *** lpabon has quit IRC | 20:58 | |
| *** jasonsb_ has quit IRC | 20:59 | |
| *** jasonsb has joined #openstack-manila | 21:00 | |
| *** jasonsb has quit IRC | 21:05 | |
| *** rcallawa has quit IRC | 21:05 | |
| *** rcallawa has joined #openstack-manila | 21:06 | |
| *** lpetrut has quit IRC | 21:28 | |
| *** eharney has quit IRC | 21:36 | |
| *** erlon has quit IRC | 21:41 | |
| *** bswartz has joined #openstack-manila | 22:09 | |
| *** ajo has quit IRC | 23:19 | |
| *** rhagarty has quit IRC | 23:38 | |
| *** gary-smith has quit IRC | 23:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!