| *** ho_ has joined #openstack-manila | 00:00 | |
| *** akerr has quit IRC | 00:05 | |
| *** jasonsb_ has quit IRC | 00:10 | |
| *** bswartz has quit IRC | 00:30 | |
| *** bswartz has joined #openstack-manila | 00:31 | |
| *** mtanino has quit IRC | 01:18 | |
| *** cknight has joined #openstack-manila | 01:20 | |
| *** cknight has quit IRC | 01:32 | |
| *** erlon has quit IRC | 02:31 | |
| *** sanjeo_ has joined #openstack-manila | 02:52 | |
| *** xyang1 has quit IRC | 02:54 | |
| *** haigang has joined #openstack-manila | 02:56 | |
| *** haigang has quit IRC | 02:58 | |
| *** haigang has joined #openstack-manila | 02:59 | |
| *** chen12 has joined #openstack-manila | 03:31 | |
| *** haigang has quit IRC | 03:33 | |
| *** lpetrut has joined #openstack-manila | 04:11 | |
| *** vbellur has quit IRC | 04:46 | |
| *** sgotliv has joined #openstack-manila | 05:37 | |
| *** vbellur has joined #openstack-manila | 05:44 | |
| *** sgotliv has quit IRC | 05:46 | |
| *** sks has joined #openstack-manila | 05:59 | |
| *** lpetrut has quit IRC | 06:00 | |
| *** jasonsb has joined #openstack-manila | 06:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila: Imported Translations from Transifex https://review.openstack.org/171941 | 06:11 |
|---|---|---|
| *** haigang has joined #openstack-manila | 06:24 | |
| *** rraja has joined #openstack-manila | 06:27 | |
| *** sanjeo_ has quit IRC | 07:04 | |
| *** nileshb has joined #openstack-manila | 07:37 | |
| *** nileshb has quit IRC | 07:49 | |
| *** vbellur has quit IRC | 07:56 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila: Prevent hanging share server in 'creating' state https://review.openstack.org/170528 | 08:04 |
| *** vbellur has joined #openstack-manila | 08:12 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/python-manilaclient: Implement wrapper for ascii table parser from tempest_lib.cli https://review.openstack.org/172137 | 08:42 |
| *** Maike has joined #openstack-manila | 09:03 | |
| *** vbellur has quit IRC | 10:00 | |
| *** vbellur has joined #openstack-manila | 10:13 | |
| *** rcallawa has quit IRC | 10:26 | |
| *** haigang has quit IRC | 10:29 | |
| *** rraja has quit IRC | 11:02 | |
| *** marcusvrn has joined #openstack-manila | 11:03 | |
| *** vbellur has quit IRC | 11:48 | |
| toabctl | vponomaryov: have you deleted the comment from https://bugs.launchpad.net/manila/+bug/1441602 ? | 11:50 |
| openstack | Launchpad bug 1441602 in Manila "Response 404 NotFound for listing share types request" [Medium,In progress] - Assigned to Valeriy Ponomaryov (vponomaryov) | 11:50 |
| vponomaryov | toabctl: yes, it was false | 11:50 |
| toabctl | vponomaryov: ok. so no longer 100% sure that it's in type-access-list ? because I'm also searching and I tried to reproduce it without success | 11:51 |
| vponomaryov | toabctl: add/remove access have influence | 11:51 |
| *** rcallawa has joined #openstack-manila | 12:24 | |
| *** timcl has joined #openstack-manila | 12:31 | |
| *** bswartz has quit IRC | 12:33 | |
| *** ganso_ has joined #openstack-manila | 12:41 | |
| *** akerr has joined #openstack-manila | 12:42 | |
| *** ho_ has quit IRC | 12:44 | |
| *** xyang1 has joined #openstack-manila | 12:50 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Add object caching in manila REST API requests https://review.openstack.org/172407 | 13:03 |
| vponomaryov | toabctl: It is not reproducable for me with above change ^ | 13:08 |
| vponomaryov | toabctl: so, absense of caching was the cause | 13:08 |
| toabctl | vponomaryov: hm. I don't understand why caching should solve the problem of mixed requests/responses ... | 13:19 |
| toabctl | vponomaryov: I guess caching could hide it. but do you know now exactly what the problem is? I still don't understand it. | 13:19 |
| *** bswartz has joined #openstack-manila | 13:20 | |
| bswartz | xyang1: any ideas why EMC unit tests have started to fail? | 13:21 |
| bswartz | on patches unrelated to EMC | 13:21 |
| u_glide | root cause of problem - https://bugs.launchpad.net/python-neutronclient/+bug/1442367 | 13:22 |
| openstack | Launchpad bug 1442367 in python-neutronclient "2.4.0 release destroys grenade since stable/juno isn't capped properly" [Critical,Confirmed] - Assigned to Akihiro Motoki (amotoki) | 13:22 |
| u_glide | neutron client is broken | 13:23 |
| bswartz | how can neutronclient break a unit test? | 13:23 |
| u_glide | it's better to ask xyang1 :) | 13:23 |
| vponomaryov | bswartz: because it uses neutronclient | 13:24 |
| bswartz | Kyle Mestery (mestery) wrote 16 hours ago: Love the title of the bug, next time I'd go instead with "python-neutronclient release release plague on humanity". | 13:24 |
| xyang1 | u_glide: what is it? | 13:24 |
| bswartz | xyang1: 2 emc unit tests have started to consistently fail | 13:25 |
| bswartz | seems to be related to neutron bug | 13:25 |
| bswartz | this prevents us from merging anything :-( | 13:25 |
| bswartz | my questions would be why a unit tests doesn't mock out anything related to neutron | 13:26 |
| bswartz | (assuming that's the problem) | 13:26 |
| u_glide | I think neutron imports are broken, thats why we have problems with UT | 13:28 |
| u_glide | *neutron-client | 13:28 |
| bswartz | why only those 2 tests though? | 13:28 |
| bswartz | manila.tests.share.drivers.emc.test_driver.EMCShareFrameworkTestCase.test_update_share_stats | 13:29 |
| bswartz | manila.tests.share.drivers.emc.test_driver.EMCShareFrameworkTestCase.test_driver_setup | 13:29 |
| *** cknight has joined #openstack-manila | 13:30 | |
| *** dustins has joined #openstack-manila | 13:33 | |
| *** Maike has quit IRC | 13:37 | |
| *** eharney has joined #openstack-manila | 13:39 | |
| *** Maike has joined #openstack-manila | 13:39 | |
| *** esker has joined #openstack-manila | 13:43 | |
| *** akerr has quit IRC | 13:46 | |
| *** akerr has joined #openstack-manila | 13:48 | |
| *** sks has quit IRC | 13:48 | |
| *** bswartz has quit IRC | 13:59 | |
| *** bswartz has joined #openstack-manila | 14:02 | |
| *** rushil has joined #openstack-manila | 14:06 | |
| *** vbellur has joined #openstack-manila | 14:07 | |
| *** xyang_ has joined #openstack-manila | 14:10 | |
| *** mtanino has joined #openstack-manila | 14:14 | |
| toabctl | vponomaryov: I'll recheck 172407. jus to give it another try if the bug occurs again. ok? | 14:42 |
| *** esker has quit IRC | 14:47 | |
| *** xyang_ has quit IRC | 14:58 | |
| *** dustins_ has joined #openstack-manila | 14:59 | |
| *** timcl1 has joined #openstack-manila | 15:01 | |
| *** timcl has quit IRC | 15:02 | |
| *** rushil has quit IRC | 15:02 | |
| *** dustins has quit IRC | 15:03 | |
| *** esker has joined #openstack-manila | 15:08 | |
| *** xyang_ has joined #openstack-manila | 15:11 | |
| *** rraja has joined #openstack-manila | 15:12 | |
| *** rcallawa has quit IRC | 15:20 | |
| *** rushil has joined #openstack-manila | 15:21 | |
| *** timcl1 has quit IRC | 15:21 | |
| *** lpabon has joined #openstack-manila | 15:27 | |
| *** timcl has joined #openstack-manila | 15:30 | |
| *** timcl has quit IRC | 15:32 | |
| lpabon | bswartz, quick question, Does horizon (upstream) support manila in kilo? | 15:43 |
| -openstackstatus- NOTICE: gerrit has been restarted to address a hung event stream. change events between 15:00 and 15:43 utc which were lost will need to be rechecked or have approval workflow votes reapplied for zuul to act on them | 15:44 | |
| *** vbellur has quit IRC | 15:49 | |
| *** fanyaohong has joined #openstack-manila | 15:52 | |
| markstur | lpabon, Upstream Horizon does not work with Manila in Kilo. Use the forked version. We're working on a Horizon plugin but that would be too late to count on for Kilo | 15:52 |
| markstur | lpabon, https://wiki.openstack.org/wiki/Manila/docs/HOWTO_use_manila_with_horizon | 15:53 |
| bswartz | markstur: +1 | 15:55 |
| *** vbellur has joined #openstack-manila | 16:03 | |
| toabctl | markstur: what means "working"? is there some review in progress? or a blueprint? | 16:04 |
| toabctl | I'm not an horizon expert but I think there is some sort of plugin mechanism. that would allow us to maintain the horizon code in manila. similar to the devstack code | 16:05 |
| markstur | toabctl, The plugin goes in a separate repo. There's a review process to make that official. | 16:07 |
| toabctl | markstur: can you point me to the repo/review, please? | 16:07 |
| bswartz | toabctl: https://github.com/NetApp/horizon/tree/manila_kilo | 16:09 |
| markstur | toabctl, bswartz I think he's asking about the future plugin | 16:10 |
| toabctl | bswartz: I know that one. | 16:10 |
| toabctl | markstur: yes :) | 16:10 |
| markstur | toabctl, bswartz I'll go check on when we'll have something to preview. Obviously when it becomes official it'll all be shared, but I'm not sure how the interim works. I'll check. | 16:11 |
| markstur | toabctl, Don't want to confuse people too much during Kilo though. We need that other Horizon working for Kilo! | 16:11 |
| toabctl | markstur: sure. but am I right that you are working internally (Whatever that means) on moving the fork to a plugin structure? I just want to know that because it's something I may would look into if nobody else is doning that. | 16:13 |
| *** gary-smith has joined #openstack-manila | 16:14 | |
| markstur | toabctl, agreed. Getting more info soon from gary-smith. | 16:18 |
| *** sks has joined #openstack-manila | 16:18 | |
| gary-smith | I'll post a URL to the repo containing the manila-ui horizon plugin in a minute | 16:18 |
| *** Maike has quit IRC | 16:20 | |
| *** Maike has joined #openstack-manila | 16:22 | |
| gary-smith | Here is the URL: https://github.com/hp-storage/manila-ui | 16:22 |
| toabctl | gary-smith: cool. thanks | 16:23 |
| gary-smith | toabctl: welcome. Please let me know if it works for you | 16:23 |
| bswartz | gary-smith: is this a fork of something or is it brand new code? | 16:24 |
| gary-smith | bswartz: it is the code from the kilo branch of netapp's horizon repo | 16:24 |
| gary-smith | but "plugin-ized" | 16:25 |
| gary-smith | One caveat: it does not include the share-networks support added in commits 581de66 and c3db324, since those required changes into horizon proper | 16:25 |
| gary-smith | those can be added in after the corresponding changes are made into horizon (basically adding API calls for nova and neutron) | 16:26 |
| bswartz | and the plan is to migrate this to the manila/contrib directory? | 16:26 |
| gary-smith | the plan is to work through the process of making it a new openstack project | 16:27 |
| gary-smith | akin to tuskar-ui | 16:27 |
| bswartz | oh that's right | 16:27 |
| gary-smith | I'll start on that process on Monday | 16:27 |
| bswartz | I suppose with cross-project dependencies we can manage stuff across reops | 16:28 |
| bswartz | repos | 16:28 |
| gary-smith | I haven't been able to extensively test this code yet, so any extra eyeballs on it would be good | 16:29 |
| * bswartz is still distracted by RC stuff | 16:30 | |
| gary-smith | understandably | 16:30 |
| esker | gary-smith: can you elaborate on the new openstack project you're referring to? | 16:30 |
| esker | gary-smith: where can I learn more? | 16:30 |
| bswartz | esker: its for our horizon integration to live in | 16:31 |
| gary-smith | well, I haven't started that yet | 16:31 |
| *** timcl has joined #openstack-manila | 16:31 | |
| bswartz | horizon is creating a new plugin model in liberty | 16:31 |
| markstur | bswartz, While we get into the approval process and 'extra eyeballs' we'll need to try to be careful not to veer people away from the supported Horizon (NetApp) Manila UI | 16:31 |
| esker | Ah.. .and each plugin is a separate project? | 16:31 |
| esker | didn | 16:31 |
| bswartz | markstur: +1 | 16:31 |
| esker | didn't know that... | 16:31 |
| gary-smith | I have to run to meeting right now (sorry). In the interim, please ake a look at the tuskar-ui project | 16:31 |
| esker | bswartz: is my interpretation correct? Liberty Horizon moves every plugin into a new project? | 16:32 |
| *** Maike_ has joined #openstack-manila | 16:32 | |
| markstur | I think the relevant conversation is here (fyi): http://eavesdrop.openstack.org/meetings/manila/2015/manila.2015-03-12-15.00.log.html | 16:33 |
| esker | bswartz: so there will be a Cinder Horizon project, a Neutron one.. et cetera ... something to that effect? | 16:33 |
| *** Maike has quit IRC | 16:33 | |
| *** timcl has quit IRC | 16:33 | |
| markstur | esker, That is what Horizon wants. Not sure how fast the move will happen. | 16:33 |
| esker | markstur: thx | 16:33 |
| markstur | esker, Easier to say it is the right direction for us. | 16:33 |
| bswartz | esker: I'm not sure that currently integrated projects will move to a new repo, but projects that are not currently integrated will have a way to integrate using plugins | 16:33 |
| vponomaryov | esker: I think main projects will be in one place and all other as plugins | 16:33 |
| bswartz | maybe they will move eventually, but in the short term there is no other option for projects like manila | 16:34 |
| esker | vponomaryov: got it, thx | 16:34 |
| bswartz | the fork strategy that we had for Juno and Kilo stinks | 16:34 |
| markstur | The Horizon discussion about moving to plugins is: http://eavesdrop.openstack.org/meetings/horizon/2015/horizon.2015-03-11-20.00.log.html | 16:35 |
| markstur | s/The/A/ I don't know what other talks they've had | 16:35 |
| esker | bswartz: that wasn't a strategy ;-) | 16:35 |
| esker | bswartz: it was expedient | 16:36 |
| bswartz | agreed | 16:36 |
| *** rraja has quit IRC | 16:36 | |
| markstur | Seems suggesting the command-line was all that was needed doesn't go very far. | 16:36 |
| gary-smith | I got out of my meeting. FWIW, horizon is moving to the plugin model for all new openstack projects | 16:37 |
| bswartz | gary-smith: when you say "new" that sounds like it implies that "old" projects won't move. do you know what will happen with UIs like cinders? | 16:38 |
| gary-smith | not really... | 16:39 |
| gary-smith | but all of the dashboards and panels in horizon right now are actually in plugins, but they still live within the horizon code base | 16:40 |
| gary-smith | not sure if they will be moving externally or not | 16:40 |
| markstur | bswartz, I think I heard they'd like cinder to move (not sure if that is likely), but also heard moving Neutron wouldn't be practical. | 16:40 |
| markstur | So I'd say the "strategy" is evolving | 16:41 |
| bswartz | I hope horizon is thinking about avoiding a 1st class / 2nd class plugin hierarchy | 16:41 |
| markstur | I was hoping plug-ins would be 1st class and the old squatters would be 2nd class. | 16:42 |
| gary-smith | I don't think they intend to relegate it to a lower class. I believe that tuskar-ui (and manila-ui in the future) will belong under the horizon project, but just in separate repos | 16:43 |
| gary-smith | let me rephrase that. I believe that tuskar-ui is currently under horizion, and manila-ui will be also | 16:44 |
| bswartz | gary-smith: :) | 16:44 |
| *** xyang_ has quit IRC | 16:50 | |
| *** 7YUAABJ1S has joined #openstack-manila | 16:54 | |
| *** 64MACKOGK has joined #openstack-manila | 16:54 | |
| *** 7YUAABJ1S has quit IRC | 16:57 | |
| *** 64MACKOGK has quit IRC | 16:57 | |
| *** xyang_ has joined #openstack-manila | 16:57 | |
| *** dustins_ has quit IRC | 16:59 | |
| *** timcl has joined #openstack-manila | 17:00 | |
| *** dustins has joined #openstack-manila | 17:02 | |
| *** sgotliv has joined #openstack-manila | 17:10 | |
| *** bswartz has quit IRC | 17:15 | |
| *** bswartz has joined #openstack-manila | 17:18 | |
| markstur | xyang1, xyang_ ping | 17:25 |
| *** erlon has joined #openstack-manila | 17:26 | |
| *** esker has quit IRC | 17:29 | |
| *** sgotliv has quit IRC | 17:29 | |
| xyang1 | markstur: Hi | 17:31 |
| lpabon | thanks markstur | 17:31 |
| *** sks has quit IRC | 17:46 | |
| *** Maike_ has quit IRC | 17:57 | |
| *** Maike_ has joined #openstack-manila | 17:58 | |
| *** fanyaohong has quit IRC | 17:59 | |
| *** timcl1 has joined #openstack-manila | 18:01 | |
| *** timcl has quit IRC | 18:03 | |
| *** dustins has quit IRC | 18:16 | |
| *** Maike_ has quit IRC | 18:21 | |
| *** Maike has joined #openstack-manila | 18:21 | |
| *** Maike_ has joined #openstack-manila | 18:29 | |
| *** Maike has quit IRC | 18:29 | |
| openstackgerrit | Ryan Hefner proposed stackforge/puppet-manila: Update share driver parameters https://review.openstack.org/171778 | 18:36 |
| bswartz | xyang1, anyone else: has anyone looked into the failing EMC unit tests? | 18:37 |
| bswartz | we need to fix them/disable them ASAP to unblock our gate | 18:37 |
| xyang_ | bswartz: I am looking at it, but it doesn't happen on my set up. It failed in neutron network plugin | 18:43 |
| bswartz | xyang_: did you nuke your venv and rebuild? | 18:43 |
| xyang_ | bswartz: no | 18:43 |
| bswartz | ./run_tests.sh -f | 18:43 |
| xyang_ | bswartz: I can temporarily disable these two tests if it helps other patches to pass | 18:44 |
| bswartz | xyang_: that is the backup plan -- it would be better to understand why the unit tests aren't mocking out everything related to those methods and fix them so neutronclient can't break the tests | 18:45 |
| xyang_ | is vponomaryov still around | 18:45 |
| bswartz | it's pretty late where he is -- and it's a holiday weekend (orthodox easter) | 18:45 |
| xyang_ | It looks like it has to do with loading neutron network plugin | 18:45 |
| xyang_ | the code in emc driver: self.driver = emcdriver.EMCShareDriver( | 18:47 |
| xyang_ | configuration=self.configuration) | 18:47 |
| xyang_ | self.driver = emcdriver.EMCShareDriver( | 18:47 |
| xyang_ | configuration=self.configuration) | 18:47 |
| xyang_ | self.driver = emcdriver.EMCShareDriver(configuration=self.configuration) | 18:47 |
| xyang_ | that was the line that caused this | 18:47 |
| xyang_ | but then it started to call neutron client | 18:48 |
| *** dustins has joined #openstack-manila | 18:48 | |
| bswartz | xyang_: I think you need more mocks before you do that | 18:48 |
| bswartz | the unit test should isolate the method being tested so that you don't accidentally tests a bunch of other stuff | 18:48 |
| xyang_ | there're mocks before that | 18:49 |
| xyang_ | let me take a look of tests of other drivers | 18:50 |
| bswartz | we've spent a bunch of time improving the netapp unit tests -- you can look at them for examples of how to mock | 18:50 |
| xyang_ | sure | 18:50 |
| bswartz | I'll take a look at those failing tests and see if I can find the missing mock | 18:50 |
| xyang_ | ok, thanks | 18:52 |
| *** dustins has quit IRC | 18:54 | |
| *** dustins has joined #openstack-manila | 19:09 | |
| xyang_ | bswartz: I wonder if this is the problem: @mock.patch('stevedore.extension.ExtensionManager', mock.Mock(return_value=FakeEMCExtensionManager())) | 19:12 |
| bswartz | xyang_: if you follow the stacktrace of the failing test, the problem seems to exist in the parent driver class | 19:13 |
| bswartz | so I'm trying to figure out why only EMC's driver instantiation tests are affected | 19:13 |
| xyang_ | bswartz: we mocked it for emc plugins, but the neutron network plugin may expect this to be non empty | 19:13 |
| *** dustins has quit IRC | 19:13 | |
| bswartz | what is stevedore.extension.ExtensionManager? | 19:14 |
| xyang_ | bswartz: that is a framework to discover plugins automatically | 19:14 |
| bswartz | does your driver use it? | 19:14 |
| xyang_ | bswartz: emc parent driver uses it to discover vnx and isilon plugins | 19:14 |
| xyang_ | bswartz: I think neutron network plugin uses it as well | 19:15 |
| bswartz | is it essential to mock it out this way in unit tests? | 19:15 |
| xyang_ | bswartz: so my theory is this didn't happen before the neutron network plugin was introduced. now we mocked it to be [] | 19:15 |
| xyang_ | bswartz: maybe neutron network plugin expect it to be non empty | 19:16 |
| xyang_ | bswartz: I'll have see | 19:16 |
| xyang_ | have to see | 19:16 |
| bswartz | xyang_: still seems bad that a unit test like this involves instantiating a whole neutron client -- the goal of the test is to prove the EMC driver constructor is correct, not to test the parent classes and what they do | 19:18 |
| bswartz | perhaps an additional mock would prevent the neutron client from ever getting created | 19:19 |
| xyang_ | bswartz: this test is specific for the parent class. we have other tests for vnx and isilon plugins | 19:19 |
| bswartz | I'm referring to manila/manila/share/driver.py | 19:20 |
| bswartz | the high level parent | 19:20 |
| bswartz | higher* | 19:20 |
| bswartz | that's where neutron is getting setup | 19:20 |
| *** eharney has quit IRC | 19:22 | |
| *** u_glide1 has joined #openstack-manila | 19:24 | |
| *** dustins has joined #openstack-manila | 19:24 | |
| *** u_glide1 has quit IRC | 19:26 | |
| *** timcl1 has quit IRC | 19:36 | |
| *** dustins has quit IRC | 19:36 | |
| *** dustins has joined #openstack-manila | 19:37 | |
| xyang_ | bswartz: I think I have a simple fix, let me do some more testing | 19:37 |
| *** dustins has quit IRC | 19:38 | |
| *** timcl has joined #openstack-manila | 19:38 | |
| cknight | xyang_: You can add "self.mock_object(driver.ShareDriver, '__init__')" in emc/test_driver::setUp right before you create the driver. | 19:40 |
| cknight | xyang_: All your tests pass if you do that. | 19:41 |
| *** lpabon has quit IRC | 19:41 | |
| xyang_ | cknight: hi, thanks! I can try that. I was going to change driver_handles_share_server=False. that works too | 19:43 |
| xyang_ | cknight: this parent class should not claim driver handles share server = True | 19:43 |
| xyang_ | cknight: if it is False, it will not try to load neutron plugin | 19:44 |
| xyang_ | cknight: the parent class has two plugins, vnx supports True, while Isilon supports False. So parent really should not say True | 19:44 |
| cknight | xyang_: Sure. But this is a unit test, so ideally it shouldn't be necessary to depend on so many outside things that could be mocked instead. | 19:45 |
| xyang_ | cknight: so it should still try to load the plugins | 19:46 |
| xyang_ | cknight: I know it is faked | 19:46 |
| cknight | xyang_: Yes, as long as you run EMCShareDriver.__init__, then you will load your plugin. The problem happens when that constructor calls __init__ in ShareDriver, and a mock can prevent that. | 19:48 |
| xyang_ | cknight: so doing your way can prevent it from calling anything in the parent driver | 19:48 |
| xyang_ | cknight: I mean maybe prevent future issues | 19:50 |
| cknight | xyang_: True, but if unit tests depend on functionality from superclasses, they aren't really unit tests. I'm assuming you have asserts in place that ensure your plugins are loaded as expected. If so, and your tests all pass, then I expect you're good. | 19:51 |
| cknight | xyang_: Mine definitely isn't the only possible fix, but it seems simple and in the spirit of localized unit testing. | 19:52 |
| *** lpetrut has joined #openstack-manila | 19:53 | |
| xyang_ | cknight: I think it really depends on what you want to test. I think I can go either way on this one. do you know if there's a bug open for this already | 19:56 |
| bswartz | xyang_: I'll file a bug | 19:57 |
| bswartz | https://bugs.launchpad.net/manila/+bug/1442788 | 19:58 |
| openstack | Launchpad bug 1442788 in Manila "Two EMC unit tests failing due to changes in neutronclient" [Critical,Triaged] - Assigned to Xing Yang (xing-yang) | 19:58 |
| xyang_ | bswartz: thanks | 20:01 |
| *** timcl has quit IRC | 20:14 | |
| openstackgerrit | xing-yang proposed openstack/manila: Mock out base share driver __init__ in EMC driver https://review.openstack.org/172557 | 20:15 |
| *** xyang_ has quit IRC | 20:15 | |
| *** akerr has quit IRC | 20:18 | |
| xyang1 | cknight: bswartz, submitted:) | 20:18 |
| *** xyang_ has joined #openstack-manila | 20:23 | |
| bswartz | xyang1: ty | 20:31 |
| bswartz | xyang1, xyang_: you know you switch back and forth between 2 IRC handles | 20:31 |
| *** rcallawa has joined #openstack-manila | 20:32 | |
| *** lpetrut has quit IRC | 20:33 | |
| xyang_ | bswartz: yes, for some reason, I still can't see your message on the one as xyang1 | 20:34 |
| bswartz | :-( | 20:34 |
| xyang_ | bswartz: xyang1 is on an IRC client on my ipad. this one is on my laptop. it is easier to type on laptop | 20:35 |
| *** rcallawa_ has joined #openstack-manila | 20:36 | |
| *** rcallawa has quit IRC | 20:38 | |
| *** marcusvrn has quit IRC | 20:38 | |
| bswartz | xyang_: might be a setting in your ipad IRC client | 20:40 |
| bswartz | did you accidentally blacklist me? Am I the only one you can see on that client? | 20:40 |
| xyang_ | bswartz: :) | 20:42 |
| xyang_ | bswartz: seems to be so far, I haven't discovered others yet. I kept seeing other reply to you without your response | 20:42 |
| xyang_ | bswartz: I thought you were sending private messages:) | 20:43 |
| *** rcallawa_ has quit IRC | 20:43 | |
| *** rcallawa has joined #openstack-manila | 20:44 | |
| bswartz | xyang_: might want to change the topic on your change https://review.openstack.org/#/c/172557/ | 20:47 |
| bswartz | then again it makes more sense when you read the commit message | 20:47 |
| bswartz | topics aren't part of the permanent record though so I guess it does't matter | 20:47 |
| xyang_ | bswartz: sure | 20:48 |
| *** rcallawa has quit IRC | 20:48 | |
| *** rcallawa has joined #openstack-manila | 20:48 | |
| *** cknight has quit IRC | 20:52 | |
| *** lpetrut has joined #openstack-manila | 20:53 | |
| xyang_ | bswartz: so changed to "Fixed unit test failures in EMC driver"? | 20:53 |
| bswartz | no I was talking about the gerrit topic | 20:54 |
| bswartz | which named after your git branch | 20:54 |
| xyang_ | bswartz: so change it to use the bug number? | 20:54 |
| bswartz | no there's no need to change | 20:55 |
| xyang_ | ok, thanks | 20:55 |
| *** marcusvrn has joined #openstack-manila | 20:57 | |
| *** rcallawa has quit IRC | 21:03 | |
| *** rcallawa has joined #openstack-manila | 21:07 | |
| *** bswartz has quit IRC | 21:08 | |
| *** rcallawa has quit IRC | 21:17 | |
| *** rcallawa has joined #openstack-manila | 21:18 | |
| *** jasonsb has quit IRC | 21:25 | |
| *** jasonsb has joined #openstack-manila | 21:26 | |
| *** rcallawa has quit IRC | 21:31 | |
| *** jasonsb has quit IRC | 21:31 | |
| *** rcallawa has joined #openstack-manila | 21:31 | |
| *** lpetrut has left #openstack-manila | 21:38 | |
| *** rushil has quit IRC | 21:41 | |
| *** bswartz has joined #openstack-manila | 22:10 | |
| *** cknight has joined #openstack-manila | 22:14 | |
| *** rcallawa has quit IRC | 22:30 | |
| *** rcallawa has joined #openstack-manila | 22:31 | |
| markstur | cknight, bswartz if you're online the EMC unit test gate fix could use a +A https://review.openstack.org/#/c/172557/ | 22:40 |
| cknight | markstur: We're online, and we've mutually decided to give the non-NetApp cores a chance to do the +A. Xing wrote the fix, so the Mirantis guys are needed for the +A, most likely early tomorrow. If for whatever reason they don't, we'll do it ourselves. | 22:42 |
| bswartz | markstur: we're trying to follow the new rule we established | 22:45 |
| bswartz | in an emergency I'd +A it, but we can wait until the ukranians guys wake up tomorrow | 22:46 |
| markstur | bswartz, I thought you just weren't supposed to +A w/ only NetApp stuff. I see it now it is only NetApp +2's | 22:47 |
| markstur | bswartz, I pretty much assumed Xing would approve, but that does make things tricky now doesn't it? | 22:48 |
| bswartz | it's a minor thing | 22:48 |
| bswartz | if we grow the core team a few more people this problem should go away | 22:48 |
| bswartz | RC can't happen until all 6 bugs merge | 22:48 |
| markstur | Yes, but it is holding up the gate and did we make RC1? | 22:48 |
| bswartz | merging that fix won't shorten the time until RC1 | 22:48 |
| bswartz | we need all 6 | 22:48 |
| markstur | OK. It's holding up the 2 gluster fixes. I didn't check the whole list. | 22:49 |
| *** erlon has quit IRC | 22:51 | |
| markstur | It looks like all 6 have +2 | 22:52 |
| bswartz | yeah we're pretty close | 22:55 |
| bswartz | just need a few last core reviews and workflows | 22:55 |
| bswartz | then after that we can merge 172104 | 22:56 |
| bswartz | xyang_ if you're still on, we'd appreciate +2As on the other 3 bugs that need it | 22:57 |
| markstur | bswartz, Didn't you say xyang_ xyang1 filtered you :) | 23:00 |
| bswartz | I think xyang1 filters me but xyang_ doesn't | 23:00 |
| bswartz | she's east coast though so not much hope she's still working | 23:00 |
| markstur | Yeah. That's why I thought you our Clinton would +A that one if one of you were online. Didn't think thru the new rules correctly tho. | 23:01 |
| bswartz | we may end up regretting the rule and reversing it | 23:02 |
| bswartz | I'm regretting it today, but I really think this is an unusual situation | 23:03 |
| *** Maike_ has quit IRC | 23:12 | |
| *** cknight has quit IRC | 23:15 | |
| *** cknight has joined #openstack-manila | 23:16 | |
| *** ganso_ has quit IRC | 23:17 | |
| *** cknight has quit IRC | 23:19 | |
| *** cknight has joined #openstack-manila | 23:24 | |
| *** cknight has quit IRC | 23:25 | |
| *** cknight has joined #openstack-manila | 23:35 | |
| *** jasonsb has joined #openstack-manila | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!