*** ho has joined #openstack-manila | 00:09 | |
*** chen12 has joined #openstack-manila | 00:12 | |
*** mtanino has quit IRC | 00:21 | |
*** rcallawa has joined #openstack-manila | 00:26 | |
*** rcallawa has quit IRC | 00:26 | |
*** rcallawa has joined #openstack-manila | 00:27 | |
*** cknight has joined #openstack-manila | 00:50 | |
*** cknight has quit IRC | 00:57 | |
*** cknight has joined #openstack-manila | 00:57 | |
*** vbellur has quit IRC | 01:21 | |
*** echoingumesh has quit IRC | 01:24 | |
*** echoingumesh has joined #openstack-manila | 01:25 | |
*** echoingumesh has quit IRC | 01:30 | |
*** devlaps has joined #openstack-manila | 01:31 | |
*** devlaps has quit IRC | 01:51 | |
*** vbellur has joined #openstack-manila | 02:01 | |
*** rcallawa has quit IRC | 02:09 | |
*** jasonsb has joined #openstack-manila | 02:20 | |
*** cknight has quit IRC | 02:25 | |
*** kaisers2 has joined #openstack-manila | 02:41 | |
*** kaisers3 has joined #openstack-manila | 02:42 | |
*** kaisers1 has quit IRC | 02:42 | |
*** kaisers has quit IRC | 02:43 | |
*** cknight has joined #openstack-manila | 02:56 | |
*** cknight has joined #openstack-manila | 02:56 | |
*** echoingumesh has joined #openstack-manila | 03:11 | |
*** resker has joined #openstack-manila | 03:18 | |
*** esker has quit IRC | 03:21 | |
*** echoingumesh has quit IRC | 03:45 | |
*** echoingumesh has joined #openstack-manila | 03:46 | |
*** cknight1 has joined #openstack-manila | 03:46 | |
*** echoingumesh has quit IRC | 03:47 | |
*** cknight has quit IRC | 03:48 | |
*** echoingumesh has joined #openstack-manila | 03:48 | |
*** echoingumesh has quit IRC | 03:52 | |
*** cknight1 has quit IRC | 04:02 | |
*** xyang1 has quit IRC | 05:02 | |
*** deepakcs has joined #openstack-manila | 05:18 | |
*** netapp has quit IRC | 05:49 | |
*** netapp has joined #openstack-manila | 05:49 | |
*** netapp has quit IRC | 06:02 | |
*** ajo has joined #openstack-manila | 06:03 | |
*** netapp has joined #openstack-manila | 06:08 | |
*** Maike has joined #openstack-manila | 06:41 | |
*** resker has quit IRC | 06:49 | |
*** esker has joined #openstack-manila | 06:50 | |
*** anand1 has joined #openstack-manila | 07:09 | |
*** kaisers3 has quit IRC | 07:15 | |
*** ajo has quit IRC | 07:19 | |
*** ajo has joined #openstack-manila | 07:23 | |
openstackgerrit | Marc Koderer proposed openstack/manila: Add initial scenario test for Manila https://review.openstack.org/162628 | 07:58 |
---|---|---|
*** chlong has quit IRC | 08:01 | |
mkoderer | vponomaryov: I posted a comment on your fix (https://review.openstack.org/#/c/162138/) | 08:08 |
mkoderer | vponomaryov: IMHO the share-network need a state to fix it in a clean way | 08:09 |
*** TobiasE has joined #openstack-manila | 08:29 | |
*** TobiasE has quit IRC | 08:31 | |
*** HoloIRCUser2 has joined #openstack-manila | 08:38 | |
*** ajo has quit IRC | 08:46 | |
*** ajo has joined #openstack-manila | 08:47 | |
*** ho has quit IRC | 09:15 | |
vponomaryov | mkoderer: ping | 09:44 |
*** anand1 has quit IRC | 09:45 | |
*** anand has joined #openstack-manila | 09:46 | |
*** HoloIRCUser2 has quit IRC | 10:01 | |
*** HoloIRCUser1 has joined #openstack-manila | 10:02 | |
*** tbarron has joined #openstack-manila | 10:03 | |
*** TobiasE has joined #openstack-manila | 10:03 | |
*** deepakcs has quit IRC | 10:04 | |
*** TobiasE has quit IRC | 10:05 | |
*** chlong has joined #openstack-manila | 10:23 | |
mkoderer | vponomaryov: pong | 10:32 |
* mkoderer just reads the comment on the reviews | 10:33 | |
mkoderer | vponomaryov: so I don't get your point :) | 10:37 |
mkoderer | vponomaryov: if I create a a subnet the generic driver launches a VM | 10:37 |
mkoderer | vponomaryov: subnet= share network based using a subnet | 10:38 |
*** HoloIRCUser2 has joined #openstack-manila | 10:38 | |
*** HoloIRCUser1 has quit IRC | 10:39 | |
mkoderer | vponomaryov: I agree that the sceanrio test is far from being complete but anyway if a share network is deleted I aspect that all resouces are deleted from a tenant perspective | 10:40 |
*** HoloIRCUser2 has quit IRC | 10:56 | |
*** TobiasE has joined #openstack-manila | 10:56 | |
*** TobiasE has quit IRC | 10:59 | |
vponomaryov | mkoderer: here? | 11:10 |
vponomaryov | mkoderer: resources for user are shares and snapshots | 11:12 |
vponomaryov | mkoderer: and when they are absent then user can delete share-network | 11:12 |
vponomaryov | mkoderer: which is container of data | 11:12 |
vponomaryov | mkoderer: container of data can not have state | 11:13 |
vponomaryov | mkoderer: it is either exist or not | 11:13 |
vponomaryov | mkoderer: and I still do not see relation of mentioned by you "tenant router" and Manila in general | 11:13 |
vponomaryov | mkoderer: and in your case, you get error "router still has ports" due to improper actions as cleanup | 11:20 |
vponomaryov | mkoderer: share server as Nova VM still exist on step you try delete router, so, it fails as expected | 11:21 |
vponomaryov | mkoderer: but, as said in comments to scenario tests, you should not create router at all | 11:21 |
vponomaryov | mkoderer: and use preprepared share-network from share manager | 11:22 |
mkoderer | vponomaryov: ok so, you create a resource "share network" and out of the blue there is a share service created | 11:22 |
vponomaryov | mkoderer: share service? | 11:23 |
vponomaryov | mkoderer: what do call with this? | 11:23 |
mkoderer | vponomaryov: so what is your suggestions.. we shouldn't create any router? | 11:25 |
vponomaryov | mkoderer: lets start from the begging, why do you do it? | 11:26 |
vponomaryov | s/begging/begining/ =) | 11:26 |
vponomaryov | mkoderer: how did you come to idea of router creation? | 11:27 |
*** timcl has joined #openstack-manila | 11:29 | |
vponomaryov | mkoderer: anyway, error you get is not related to change https://review.openstack.org/#/c/162138/ at all | 11:30 |
vponomaryov | mkoderer: share-network can exist and router can have no ports | 11:31 |
vponomaryov | mkoderer: so, share-network as entity is not related to deletion of router at all | 11:32 |
vponomaryov | mkoderer: because share-network is just data container | 11:32 |
vponomaryov | mkoderer: so, you expect relation where it is absent | 11:32 |
vponomaryov | mkoderer: you need verifies that share-servers are absent | 11:33 |
vponomaryov | mkoderer: and they have state | 11:33 |
vponomaryov | mkoderer: they, "share-servers" are related to Nova VMs in case of generic driver | 11:33 |
vponomaryov | s/verifies/verify/ | 11:34 |
vponomaryov | mkoderer: in scenario tests would be useful to delete share servers directly not by means of share-networks | 11:35 |
vponomaryov | mkoderer: and in that case you do not need to wait for fix, that is useful for users in general | 11:35 |
vponomaryov | mkoderer: but not for automated scenario tests | 11:36 |
*** esker has quit IRC | 11:55 | |
*** erlon has joined #openstack-manila | 12:04 | |
mark-os | bswartz: managed to eventually get the tables to work again, must have done the installation wrong | 12:08 |
*** timcl has quit IRC | 12:09 | |
*** akerr has joined #openstack-manila | 12:14 | |
*** Administrator_ has joined #openstack-manila | 12:25 | |
*** esker has joined #openstack-manila | 12:44 | |
*** timcl has joined #openstack-manila | 12:44 | |
*** esker has quit IRC | 12:47 | |
*** tbarron has quit IRC | 12:47 | |
*** esker has joined #openstack-manila | 12:50 | |
*** vbellur has quit IRC | 12:50 | |
*** esker has quit IRC | 12:51 | |
*** bswartz has quit IRC | 12:51 | |
*** TobiasE has joined #openstack-manila | 12:53 | |
*** TobiasE has quit IRC | 12:54 | |
*** TobiasE has joined #openstack-manila | 12:55 | |
*** anand has quit IRC | 12:55 | |
*** TobiasE has quit IRC | 12:59 | |
*** vbellur has joined #openstack-manila | 13:00 | |
*** ganso_ has joined #openstack-manila | 13:02 | |
mkoderer | vponomaryov: it correct .. share-network is not related to router.. but the router to the shared service and the shared service to the shared network | 13:06 |
mkoderer | vponomaryov: I mean I can remove the router creation step.. but why shouldn't it be allowed to create a router in a tenant | 13:08 |
*** esker has joined #openstack-manila | 13:10 | |
*** dustins has joined #openstack-manila | 13:22 | |
*** bswartz has joined #openstack-manila | 13:25 | |
*** tbarron has joined #openstack-manila | 13:27 | |
*** cknight has joined #openstack-manila | 13:28 | |
bswartz | vponomaryov: ping | 13:29 |
bswartz | mark-os: that's good news! | 13:29 |
bswartz | mark-os: so are there any problems at all with postgres? | 13:29 |
vponomaryov | bswartz: зщтп | 13:29 |
vponomaryov | bswartz: pong | 13:29 |
*** eharney has joined #openstack-manila | 13:55 | |
*** zaitcev has joined #openstack-manila | 13:55 | |
*** TobiasE has joined #openstack-manila | 13:56 | |
*** TobiasE has quit IRC | 13:58 | |
*** vbellur has quit IRC | 14:04 | |
*** timcl has left #openstack-manila | 14:04 | |
*** xyang_ has joined #openstack-manila | 14:05 | |
*** uschreiber has joined #openstack-manila | 14:17 | |
*** timcl has joined #openstack-manila | 14:19 | |
*** anand1 has joined #openstack-manila | 14:22 | |
*** uschreiber is now known as uschreiber_ | 14:22 | |
*** uschreiber_ is now known as uschreiber__ | 14:23 | |
*** uschreiber__ is now known as uschreiber | 14:23 | |
*** anand1 has left #openstack-manila | 14:24 | |
*** esker has quit IRC | 14:26 | |
*** HoloIRCUser1 has joined #openstack-manila | 14:27 | |
*** uschreiber is now known as uschreiber_ | 14:28 | |
*** uschreiber_ is now known as uschreiber__ | 14:29 | |
*** uschreiber__ is now known as uschreiber | 14:29 | |
*** eharney has quit IRC | 14:34 | |
mark-os | bswartz: Having quite a bit of trouble with postgres, tried to issue 'manila create nfs 30' and I got the following message: ERROR: The server has either erred or is incapable of performing the requested operation. | 14:36 |
bswartz | mark-os: did you collect the log errors immediately when that happened? | 14:36 |
*** mtanino has joined #openstack-manila | 14:36 | |
mark-os | bswartz: looking through the logs it's definately db issues, it shows me the SELECT, FROM and WHERE commands issued | 14:37 |
*** esker has joined #openstack-manila | 14:38 | |
mark-os | bswartz: In this case I got this eror | 14:39 |
mark-os | s/eror/error | 14:39 |
mark-os | 2015-03-11 11:50:03.866 32340 ERROR manila.api.middleware.fault [req-24096c32-118b-4528-bcd5-ad8e0056aab8 None] Caught error: (ProgrammingError) column "shares.created_at" must appear in the GROUP BY clause or be used in an aggregate function | 14:39 |
bswartz | mark-os: ok | 14:40 |
bswartz | so it looks like work remains to be done before we can claim postgres support | 14:40 |
bswartz | Please file bugs as you find them -- and clearly mark them "postgres" related | 14:41 |
bswartz | if they are small we could fix them for Kilo, and if they are large we might need to invest in changes to support postgres for Liberty | 14:42 |
*** marcusvrn has joined #openstack-manila | 14:43 | |
*** marcusvrn1 has quit IRC | 14:45 | |
vponomaryov | bswartz, mark-os: actually, we have SQL code in manila that contradicts rules of SQL related to usage or "GROUP BY" | 14:45 |
vponomaryov | s/or/of/ | 14:45 |
bswartz | vponomaryov: do you already know where the bug is? | 14:46 |
vponomaryov | bswartz, mark-os: where all "select" columns should be under group by clause | 14:46 |
*** TobiasE has joined #openstack-manila | 14:46 | |
vponomaryov | in MySQL | 14:46 |
bswartz | lol | 14:46 |
bswartz | I mean *our* bug | 14:46 |
vponomaryov | it allowed to be used | 14:46 |
vponomaryov | and first value from aggregate wil lbe taken | 14:46 |
bswartz | if we wish to support both mysql and postgres, then we need to make our SQL conformant to those 2 engines at least | 14:47 |
vponomaryov | so, if PostGRES does not allow it, then it fails due to this | 14:47 |
*** rcallawa has joined #openstack-manila | 14:47 | |
mark-os | I don't understand why there is a GROUP BY command, why would that be issued when the command 'manila create nfs 30' is issued? | 14:47 |
bswartz | mark-os: do you have a stack trace? | 14:48 |
*** TobiasE has quit IRC | 14:48 | |
bswartz | we could tell you exactly why it's doing that with a stack trace | 14:48 |
mark-os | bswartz: I have a trace in the manila-api.log | 14:48 |
vponomaryov | mark-os: it is just assumption, any API request makes DB calls | 14:48 |
vponomaryov | bswartz: https://github.com/NetApp/horizon/tree/manila_kilo | 14:49 |
bswartz | vponomaryov: fully compatible with master branch of client? | 14:50 |
bswartz | or work left to be done? | 14:50 |
vponomaryov | bswartz: yes, compatible, but does not implement all features yet | 14:50 |
vponomaryov | bswartz: it can be used now | 14:50 |
mark-os | bswartz: we had to alter one of the lines of code in models.py just for us to be able to access the API. Not sure if this is an older version of manila and so could have potentially been fixed for the upcoming Kilo release | 14:51 |
bswartz | so now we can update this wiki to include horizon instructions: https://wiki.openstack.org/wiki/Manila/KiloDevstack | 14:51 |
vponomaryov | bswartz: we have separate page for Horizon | 14:51 |
vponomaryov | mark-os: what do you mean you "had to"? | 14:52 |
vponomaryov | s/you/by/ | 14:52 |
mark-os | vponomaryov: Without the change we implemented to models.py, we couldn't access the API | 14:53 |
vponomaryov | mark-os: which change? | 14:53 |
*** timcl1 has joined #openstack-manila | 14:54 | |
*** timcl has quit IRC | 14:56 | |
*** marcusvrn1 has joined #openstack-manila | 14:56 | |
*** marcusvrn has quit IRC | 14:58 | |
*** marcusvrn1 has quit IRC | 15:03 | |
*** eharney has joined #openstack-manila | 15:03 | |
mark-os | vponomaryov: been told it'll be submitted as a bug fix | 15:05 |
*** rcallawa has quit IRC | 15:06 | |
mark-os | vponomaryov: that is, unless it's already been fixed for a future version | 15:06 |
vponomaryov | mark-os: have you some link? | 15:06 |
mark-os | vponomaryov: not currently | 15:08 |
*** marcusvrn has joined #openstack-manila | 15:09 | |
*** vponomaryov has left #openstack-manila | 15:11 | |
*** vponomaryov has joined #openstack-manila | 15:11 | |
*** marcusvrn has quit IRC | 15:14 | |
*** TobiasE has joined #openstack-manila | 15:24 | |
*** TobiasE has quit IRC | 15:25 | |
*** Administrator_ has quit IRC | 15:26 | |
*** Administrator_ has joined #openstack-manila | 15:27 | |
*** mtanino is now known as mtanino_away | 15:30 | |
*** uschreiber has quit IRC | 15:36 | |
openstackgerrit | Clinton Knight proposed openstack/manila: Manila Scheduler should read full driver capabilities https://review.openstack.org/163487 | 15:36 |
bswartz | vponomaryov, xyang_: ^ this bugfix is essential for us | 15:37 |
bswartz | for NetApp* I mean. Drivers that use pools break without that fix | 15:38 |
xyang_ | bswartz: 163487? | 15:39 |
bswartz | yes | 15:39 |
*** deepakcs has joined #openstack-manila | 15:41 | |
*** marcusvrn has joined #openstack-manila | 15:45 | |
*** marcusvrn1 has joined #openstack-manila | 15:47 | |
*** marcusvrn has quit IRC | 15:49 | |
*** xyang_ has quit IRC | 15:50 | |
*** marcusvrn has joined #openstack-manila | 15:52 | |
*** marcusvrn1 has quit IRC | 15:54 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Remove CLI tests from tempest plugin https://review.openstack.org/163501 | 15:55 |
*** diemt has joined #openstack-manila | 15:56 | |
*** xyang_ has joined #openstack-manila | 15:57 | |
*** TobiasE has joined #openstack-manila | 16:02 | |
*** TobiasE has quit IRC | 16:03 | |
*** rushil has joined #openstack-manila | 16:08 | |
*** nkrinner has quit IRC | 16:13 | |
*** marcusvrn has quit IRC | 16:14 | |
*** marcusvrn has joined #openstack-manila | 16:14 | |
*** nkrinner has joined #openstack-manila | 16:16 | |
*** marcusvrn1 has joined #openstack-manila | 16:22 | |
*** marcusvrn has quit IRC | 16:23 | |
*** marcusvrn has joined #openstack-manila | 16:25 | |
*** esker has quit IRC | 16:26 | |
*** marcusvrn1 has quit IRC | 16:27 | |
*** rcallawa has joined #openstack-manila | 16:31 | |
*** mtanino_away has quit IRC | 16:32 | |
*** timcl1 has quit IRC | 16:33 | |
*** timcl has joined #openstack-manila | 16:33 | |
*** vbellur has joined #openstack-manila | 16:42 | |
*** TobiasE has joined #openstack-manila | 16:50 | |
*** openstack has joined #openstack-manila | 16:55 | |
*** rcallawa_ has joined #openstack-manila | 16:56 | |
*** timcl1 has joined #openstack-manila | 16:58 | |
*** timcl has quit IRC | 16:58 | |
*** TobiasE has quit IRC | 17:00 | |
*** rcallawa has quit IRC | 17:01 | |
bswartz | vponomaryov, mkoderer: back here please | 17:02 |
bswartz | so here is what I understand | 17:02 |
bswartz | the tenant created a router | 17:02 |
bswartz | manila attached a nova VM to it that the tenant cannot see (the share server) | 17:03 |
bswartz | even after deletion of the share_network, the nova VM still exists | 17:03 |
bswartz | and thus the router cannot be deleted | 17:03 |
mkoderer | bswartz: yep that's the situation | 17:04 |
bswartz | under normal circumstances, the nova VM will eventually go away | 17:04 |
bswartz | but in error case, it will hang around and require admin action to fix it | 17:04 |
vponomaryov | problem in timing | 17:04 |
mkoderer | bswartz: and this is not obivous for a user at the end | 17:04 |
bswartz | there's nothing we do about the error case, other than not allow deletion of the share_network | 17:04 |
vponomaryov | share servers are scheduled for deletion and scenario tests do not wait | 17:04 |
bswartz | but that doesn't really solve anything | 17:05 |
mkoderer | vponomaryov: yep the scenario test doen't wait because it would need admin creads to do so | 17:05 |
bswartz | the user would still be blocked and admin action would still be needed to cleanup the VM regardless of whether we delete the share network | 17:05 |
bswartz | so mkoderer you want a synchronous way to know when the service VM is really gone? | 17:06 |
mkoderer | bswartz: I would suggest to have a "state" in share_network to make it obvious for endusers | 17:06 |
bswartz | yeah, we don't currently have a state field at all | 17:07 |
bswartz | adding one would be more work | 17:07 |
vponomaryov | bswartz: it existed and was removed | 17:08 |
mkoderer | vponomaryov: :) | 17:08 |
bswartz | well we don't really have time to add it back in for kilo | 17:08 |
*** esker has joined #openstack-manila | 17:08 | |
bswartz | we can consider that for liberty if it adds value | 17:08 |
*** timcl1 has quit IRC | 17:08 | |
bswartz | the question I think we need to answer is whether it's worth merging or blocking this change as-is, assuming we will come back and solve mkoderer's problem later | 17:09 |
vponomaryov | for user - unlikely, people switch buttons and horizon responds in bigger time than vms are deleted | 17:09 |
bswartz | I can see merging the current change and solving mkoderer's problem in a subsequent change | 17:09 |
mkoderer | bswartz: I can raise a bug describing the issue and I unblock the review | 17:09 |
bswartz | mkoderer: that works for me | 17:10 |
bswartz | vponomaryov: but for scripts being able to query the state can add value | 17:10 |
bswartz | because adding state is a user-visible change it would have to wait until liberty, but I think we can consider it | 17:11 |
mkoderer | bswartz: which scripts? | 17:11 |
bswartz | mkoderer: your test script! | 17:11 |
mkoderer | ah :) | 17:11 |
bswartz | mkoderer: right now you'll just have to loop and retry when deletion of the router fails | 17:12 |
mkoderer | bswartz: so I can adapt the scenario test that it uses admin cread to query the state of the vm | 17:12 |
bswartz | after we fix the bug you file you might be able to query some state and know when it's okay | 17:12 |
mkoderer | it's kind of dirty but anyway :) | 17:12 |
bswartz | guys I'm extremely late for my next meeting | 17:13 |
vponomaryov | mkoderer: why you do not use admin creds from the begining? | 17:13 |
bswartz | I think we have agreement though | 17:13 |
bswartz | bbiab | 17:13 |
mkoderer | bswartz: yep thx | 17:13 |
*** bswartz has quit IRC | 17:13 | |
vponomaryov | mkoderer: scenario tests should verify non-api stuff, so, admin creds are ok completely | 17:14 |
mkoderer | vponomaryov: mhh I feel like scenario test should be real life test | 17:14 |
mkoderer | vponomaryov: yeah non-api things are real life.. but a user with a tenant user and admin? not really | 17:16 |
*** bswartz has joined #openstack-manila | 17:16 | |
*** HoloIRCUser1 has quit IRC | 17:16 | |
vponomaryov | mkoderer: is creation of all these stuff is real life? Moreover, removal in short period of time right after share creation? | 17:17 |
vponomaryov | s/share creation/share deletion/ | 17:18 |
vponomaryov | common situation - all networks stuff exist and that's it | 17:18 |
mkoderer | vponomaryov: ok... I get your point :) | 17:18 |
vponomaryov | =) | 17:18 |
vponomaryov | Now i nee to go | 17:19 |
vponomaryov | bye | 17:19 |
mkoderer | bye | 17:19 |
*** resker has joined #openstack-manila | 17:20 | |
*** timcl has joined #openstack-manila | 17:21 | |
*** chlong has quit IRC | 17:21 | |
*** esker has quit IRC | 17:24 | |
openstackgerrit | Merged openstack/manila: Add nova network plugin https://review.openstack.org/160393 | 17:24 |
*** HoloIRCUser2 has joined #openstack-manila | 17:31 | |
*** timcl has quit IRC | 17:33 | |
*** devlaps has joined #openstack-manila | 17:42 | |
*** jasonsb has quit IRC | 17:43 | |
*** jasonsb has joined #openstack-manila | 17:44 | |
*** jasonsb has quit IRC | 17:48 | |
*** mtanino has joined #openstack-manila | 17:52 | |
*** vbellur has quit IRC | 17:55 | |
*** marcusvrn has quit IRC | 18:00 | |
*** Maike has quit IRC | 18:11 | |
*** marcusvrn has joined #openstack-manila | 18:16 | |
*** marcusvrn has quit IRC | 18:19 | |
openstackgerrit | Igor Malinovskiy proposed openstack/manila: Implement manage/unmanage support in generic driver https://review.openstack.org/163553 | 18:19 |
*** jasonsb has joined #openstack-manila | 18:25 | |
*** marcusvrn has joined #openstack-manila | 18:34 | |
*** timcl has joined #openstack-manila | 18:38 | |
*** timcl has quit IRC | 18:40 | |
*** timcl has joined #openstack-manila | 18:41 | |
openstackgerrit | Merged openstack/manila: Manila Scheduler should read full driver capabilities https://review.openstack.org/163487 | 18:42 |
*** timcl has quit IRC | 18:43 | |
bswartz | cknight: ^ | 18:45 |
*** ho has joined #openstack-manila | 18:52 | |
*** echoingumesh has joined #openstack-manila | 18:54 | |
*** Administrator__ has joined #openstack-manila | 18:56 | |
*** mtanino has quit IRC | 18:57 | |
*** mtanino has joined #openstack-manila | 18:57 | |
*** bswartz has quit IRC | 18:57 | |
*** marcusvrn has quit IRC | 18:58 | |
*** rcallawa_ has quit IRC | 19:00 | |
*** Administrator_ has quit IRC | 19:00 | |
*** marcusvrn has joined #openstack-manila | 19:01 | |
*** bswartz has joined #openstack-manila | 19:03 | |
*** HoloIRCUser2 has quit IRC | 19:11 | |
*** timcl has joined #openstack-manila | 19:20 | |
*** rushil has quit IRC | 19:20 | |
*** timcl has quit IRC | 19:25 | |
*** resker has quit IRC | 19:27 | |
*** marcusvrn has quit IRC | 19:29 | |
*** xyang_ has quit IRC | 19:32 | |
*** rcallawa has joined #openstack-manila | 19:33 | |
*** esker has joined #openstack-manila | 19:33 | |
*** esker has quit IRC | 19:34 | |
*** esker has joined #openstack-manila | 19:36 | |
*** rushil has joined #openstack-manila | 19:38 | |
*** Administrator__ has quit IRC | 19:52 | |
*** Administrator__ has joined #openstack-manila | 19:52 | |
*** esker has quit IRC | 19:53 | |
*** timcl has joined #openstack-manila | 19:55 | |
*** ajo has quit IRC | 20:00 | |
*** timcl has quit IRC | 20:00 | |
*** diemt has quit IRC | 20:06 | |
*** esker has joined #openstack-manila | 20:09 | |
*** echoingumesh has quit IRC | 20:10 | |
*** cknight has quit IRC | 20:12 | |
*** cknight has joined #openstack-manila | 20:20 | |
*** xyang_ has joined #openstack-manila | 20:25 | |
*** xyang_ has quit IRC | 20:30 | |
*** xyang_ has joined #openstack-manila | 20:30 | |
*** cknight has quit IRC | 20:36 | |
*** vbellur has joined #openstack-manila | 20:37 | |
*** scottda_ has joined #openstack-manila | 20:39 | |
*** jasonsb has quit IRC | 20:39 | |
*** jwang_ has quit IRC | 20:40 | |
*** scottda_ has quit IRC | 20:41 | |
*** ajo has joined #openstack-manila | 20:42 | |
*** rcallawa has quit IRC | 20:50 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Remove CLI tests from tempest plugin https://review.openstack.org/163501 | 20:51 |
*** akerr has quit IRC | 20:52 | |
*** jwang_ has joined #openstack-manila | 20:55 | |
*** mtanino has quit IRC | 20:56 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Add ro level of access support to generic driver https://review.openstack.org/161176 | 20:57 |
*** dustins has quit IRC | 20:57 | |
xyang_ | vponomaryov: ping | 20:58 |
*** vponomaryov1 has joined #openstack-manila | 21:00 | |
vponomaryov1 | xyang_: hey | 21:00 |
*** rcallawa has joined #openstack-manila | 21:01 | |
bswartz | vponomaryov1: you're up late! | 21:01 |
vponomaryov1 | tsss | 21:02 |
xyang_ | vponomaryov1: about this one: https://review.openstack.org/#/c/162138/13/manila/share/manager.py | 21:02 |
vponomaryov1 | yes? | 21:02 |
xyang_ | vponomaryov1: I still don't understand why it doesn't save it in share_server['backend_details'] | 21:02 |
*** esker has quit IRC | 21:02 | |
vponomaryov1 | it is saved exactly tehre | 21:02 |
vponomaryov1 | if our "it" are the same =) | 21:03 |
*** bswartz has quit IRC | 21:03 | |
*** tbarron has quit IRC | 21:05 | |
xyang_ | vponomaryov1: why doesn't share_server have it already, you need to go get it from db again? | 21:05 |
xyang_ | line 558 | 21:06 |
vponomaryov1 | xyang_: excuse me, but what do you call "it"? | 21:06 |
vponomaryov1 | xyang_: share server can be deleted in two ways | 21:06 |
vponomaryov1 | xyang_: one of them - share-server-delete API | 21:06 |
vponomaryov1 | xyang_: in that case details will have data | 21:06 |
vponomaryov1 | xyang_:another case - side-call by share-network-delete API | 21:07 |
vponomaryov1 | xyang_: and latter does not fetch details | 21:07 |
vponomaryov1 | so, share-network API does not have server details | 21:07 |
xyang_ | vponomaryov1: ok | 21:08 |
vponomaryov1 | your question was about it? | 21:08 |
vponomaryov1 | separate taking of details? | 21:08 |
xyang_ | vponomaryov1: correct | 21:08 |
xyang_ | vponomaryov1: I was wondering why there are two code paths | 21:08 |
vponomaryov1 | xyang_: anyway, additional call to DB will be done only when it is needed | 21:09 |
vponomaryov1 | xyang_: because of condition | 21:09 |
xyang_ | vponomaryov1: I see | 21:10 |
*** eharney has quit IRC | 21:10 | |
xyang_ | vponomaryov1: thanks for explaining | 21:10 |
*** cknight has joined #openstack-manila | 21:11 | |
*** vbellur has quit IRC | 21:12 | |
*** vponomaryov has quit IRC | 21:13 | |
*** vponomaryov has joined #openstack-manila | 21:15 | |
*** esker has joined #openstack-manila | 21:21 | |
*** vponomaryov1 has quit IRC | 21:22 | |
openstackgerrit | Silvan Kaiser proposed openstack/manila: NFS based driver for Quobyte file storage system https://review.openstack.org/161308 | 21:32 |
*** scottda_ has joined #openstack-manila | 21:36 | |
*** rushil_ has joined #openstack-manila | 21:38 | |
*** rushil has quit IRC | 21:39 | |
*** scottda_ has quit IRC | 21:42 | |
*** xyang_ has quit IRC | 21:43 | |
*** esker has quit IRC | 21:55 | |
*** akerr has joined #openstack-manila | 22:03 | |
*** akerr_ has joined #openstack-manila | 22:04 | |
*** rcallawa has quit IRC | 22:05 | |
openstackgerrit | Merged openstack/manila: Always allow delete share-network when no shares exist https://review.openstack.org/162138 | 22:08 |
*** akerr has quit IRC | 22:08 | |
*** ho__ has joined #openstack-manila | 22:12 | |
*** ganso_ has quit IRC | 23:07 | |
*** scottda_ has joined #openstack-manila | 23:15 | |
*** scottda_ has quit IRC | 23:16 | |
*** cknight has quit IRC | 23:17 | |
*** scottda_ has joined #openstack-manila | 23:24 | |
*** rcallawa has joined #openstack-manila | 23:25 | |
*** akerr_ has quit IRC | 23:27 | |
*** scottda_ has quit IRC | 23:29 | |
*** bswartz has joined #openstack-manila | 23:37 | |
*** scottda_ has joined #openstack-manila | 23:38 | |
*** HoloIRCUser1 has joined #openstack-manila | 23:39 | |
*** chlong has joined #openstack-manila | 23:41 | |
*** mtanino has joined #openstack-manila | 23:52 | |
*** scottda_ has quit IRC | 23:58 | |
*** scottda_ has joined #openstack-manila | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!