| openstackgerrit | Merged openstack/loci master: Pass python3 flag to bindep https://review.openstack.org/641313 | 01:41 |
|---|---|---|
| *** jsuchome has joined #openstack-loci | 06:57 | |
| evrardjp | hogepodge: great | 07:39 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/loci master: Revert "For OpenSUSE Leap, use more recent version of zVMCloudConnector" https://review.openstack.org/641957 | 07:45 |
| evrardjp | hogepodge: I have prepped the patch already for the revert in loci, should the patch in requirements merge. So that we can vote on Jiri's patch first. | 07:46 |
| evrardjp | I would still prefer we discuss, at the meeting, an approach for this kind of hacks | 07:46 |
| jsuchome | do you think we need it becase it could take a long time to merge the requirement patch? | 07:54 |
| openstackgerrit | Merged openstack/loci master: Fix mismatched mod_wsgi for python3 https://review.openstack.org/641741 | 09:26 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/loci master: add missing libvirt package for suse https://review.openstack.org/641985 | 11:30 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/loci master: add missing libvirt package for suse https://review.openstack.org/641985 | 11:41 |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/loci master: add missing libvirt package for suse https://review.openstack.org/641985 | 11:44 |
| *** jsuchome has left #openstack-loci | 14:24 | |
| hogepodge | evrardjp: Ah, I didn't want to block and thought you had signed off on it for Suse. | 14:41 |
| evrardjp | o/ | 15:00 |
| hogepodge | #startmeeting loci | 15:01 |
| openstack | Meeting started Fri Mar 8 15:01:40 2019 UTC and is due to finish in 60 minutes. The chair is hogepodge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| *** openstack changes topic to " (Meeting topic: loci)" | 15:01 | |
| openstack | The meeting name has been set to 'loci' | 15:01 |
| hogepodge | ping portdirect | 15:01 |
| hogepodge | #topic agenda | 15:02 |
| *** openstack changes topic to "agenda (Meeting topic: loci)" | 15:02 | |
| hogepodge | #link https://etherpad.openstack.org/p/loci-meeting agenda | 15:02 |
| evrardjp | hogepodge: we'll need to reap votes indeed | 15:02 |
| itxaka | o/ | 15:04 |
| hogepodge | #topic zVMCloudConnector | 15:05 |
| *** openstack changes topic to "zVMCloudConnector (Meeting topic: loci)" | 15:05 | |
| hogepodge | evrardjp: go ahead | 15:05 |
| hogepodge | sorry about merging that, I saw your +2 then missed your -1 | 15:05 |
| evrardjp | thanks | 15:05 |
| evrardjp | I don't think there is an issue yet hogepodge :) | 15:06 |
| evrardjp | let me clarify what's up | 15:06 |
| evrardjp | zVMCloudCOnnector cannot build with python3.6 -- which means impossible to build in leap15. | 15:06 |
| evrardjp | this will be a problem for queens and below | 15:06 |
| evrardjp | I have submitted a patch for requirements, which is unlikely to get accepted | 15:07 |
| evrardjp | So I propose we merge the workaround in loci, with a revert should the one in requirements be accepted | 15:07 |
| evrardjp | workaround is here: https://review.openstack.org/#/c/641647/ | 15:07 |
| evrardjp | revert is here: https://review.openstack.org/#/c/641957/1 which depends on https://review.openstack.org/#/c/641738/ | 15:08 |
| evrardjp | if we merge the first one, that unblocks SUSE | 15:08 |
| evrardjp | yet -- I believe we should not pile up those kind of hacks | 15:08 |
| evrardjp | So I propose instead to build a blacklist file, with default content, that we COPY at the beginning of the process, and use that to simplify life of deployers -- We can by default list the ones we have, and deployers can extend | 15:09 |
| evrardjp | COPY or ADD, depends on the willingness here | 15:09 |
| hogepodge | I can merge it right now | 15:10 |
| evrardjp | that would totally help hogepodge | 15:10 |
| evrardjp | should we, at next step, think about blacklisting for a "permanent" solution? | 15:10 |
| evrardjp | if no one is interested by that, we can continue piling up hacks, I am fine with that | 15:12 |
| hogepodge | so https://review.openstack.org/#/c/641647/ is good to go? | 15:12 |
| evrardjp | it's better that we share those hacks anyway | 15:12 |
| evrardjp | hogepodge: yes | 15:12 |
| evrardjp | please +W :D | 15:12 |
| hogepodge | ok, think I got it all | 15:13 |
| evrardjp | side note: if we can't get portdirect to vote on https://review.openstack.org/#/c/637963/ I would totally love if you could +w it too | 15:13 |
| hogepodge | I think we need to try and grow the core team, or relax two core voting rules | 15:13 |
| hogepodge | (assume a core's patch would come with an implicit +2 for example) | 15:14 |
| evrardjp | that's fair | 15:14 |
| evrardjp | I guess I hope I can see a few reviews from colleagues like itxaka :D | 15:15 |
| hogepodge | :-) | 15:15 |
| hogepodge | hi itxaka! | 15:15 |
| hogepodge | #topic branching | 15:16 |
| *** openstack changes topic to "branching (Meeting topic: loci)" | 15:16 | |
| evrardjp | can I switch to a new topic? | 15:16 |
| evrardjp | haha you did | 15:16 |
| evrardjp | perfect | 15:16 |
| itxaka | maybe, but I dont want to mass vote on all my colleagues patches just because :P | 15:16 |
| itxaka | you'll have to earn those votes ;) | 15:16 |
| evrardjp | itxaka: great mindset, but you can vote also on other patches :D | 15:16 |
| evrardjp | hogepodge: branching \o/ | 15:17 |
| itxaka | branching yay \o/ | 15:17 |
| hogepodge | so, I'm wondering how heavy a profiles-based approach would be vs a branching approach | 15:17 |
| hogepodge | If we can make profiles work without it being a giant pile of hacks, I would be all for that. | 15:17 |
| hogepodge | Stable branch management is a slog and we don't really have the team depth to handle it. | 15:17 |
| hogepodge | evrardjp: you have ideas? | 15:18 |
| evrardjp | you can have a branch named stable without subscribing to stable maint team | 15:18 |
| evrardjp | team process* | 15:18 |
| evrardjp | but IMO, we shouldn't branch loci for now | 15:18 |
| hogepodge | it's not even the formality of it, it's that every time you send a patch up you have to decide if it's appropriate to cherry pick back to every other stable branch. | 15:18 |
| evrardjp | yeah | 15:19 |
| evrardjp | totally | 15:19 |
| evrardjp | that's what I consider the pain | 15:19 |
| evrardjp | I haven't seen any code of loci itself that deserved branching | 15:19 |
| hogepodge | If it's just in changing which packages are installed, I'd much rather have business logic to handle it rather than infrastructure logic | 15:19 |
| evrardjp | totally | 15:19 |
| evrardjp | which is why I believe the bindep approach is better | 15:19 |
| evrardjp | but there are two ways to do it now | 15:19 |
| evrardjp | one could be to insert openstack branch names into profiles | 15:20 |
| evrardjp | the other would be having multiple bindeps | 15:20 |
| evrardjp | in the latter form, we could have a conditional use of the bindep file based on PROJECT_REF | 15:21 |
| evrardjp | I would prefer the former tbh, and maybe grow into the latter | 15:21 |
| itxaka | both sounds good, would we have a generic-non attached to any branch bindep as to not duplicate things in the second case? | 15:21 |
| evrardjp | itxaka: have you seen many packages in bindep/pydep that are branch dependent? | 15:21 |
| itxaka | just one I think | 15:21 |
| evrardjp | itxaka: we can indeed | 15:21 |
| hogepodge | itxaka: I was thinking the same thing | 15:22 |
| evrardjp | right now there is this | 15:22 |
| itxaka | ok, then Im ok with both, not sure if we will use it much but it would be good to have a plan just in case we need to | 15:22 |
| evrardjp | https://github.com/openstack/loci/blob/master/Dockerfile#L29 | 15:22 |
| hogepodge | itxaka: evrardjp: a primary bindep then an stable-branch overrides bindep | 15:22 |
| evrardjp | we can have bindep which is common | 15:22 |
| evrardjp | and then extra_bindep can be set to the extra ones | 15:23 |
| hogepodge | the question is what happens when there are conflicting bindep entries? | 15:23 |
| evrardjp | right now there is no merge of those | 15:23 |
| evrardjp | it's just literally sequential calls of bindeps | 15:23 |
| evrardjp | because bindep cannot be passed multiple files, AFAIK | 15:23 |
| evrardjp | we can write a merge function, if necessary | 15:24 |
| hogepodge | ok, so what I might find helpful is just a quick write-up of the proposed solutions as a spec, which I know is more work but we're going to have to live with whatever decision is made | 15:24 |
| evrardjp | that sounds fair | 15:25 |
| hogepodge | I was thinking of primary bindep, with branch overrides (that default to something like master), then stable/<release>, and have a tool to merge in favor of what is in the stable | 15:25 |
| evrardjp | question for the merge resolution | 15:26 |
| evrardjp | if a line appears in default, and stable, but don't have the same matchers, what happens? | 15:26 |
| evrardjp | only the package name in stable is retained, and only the matcher from stable applies? | 15:26 |
| evrardjp | that sounds fair to me | 15:26 |
| evrardjp | but all of this seem far more complex than just adding profiles into regular bindep right now | 15:27 |
| hogepodge | I guess? A spec would help to visualize it and work through the logic | 15:27 |
| evrardjp | so I am wondering if we are heading the right direction | 15:27 |
| evrardjp | itxaka: can you tackle this> | 15:27 |
| itxaka | will do | 15:27 |
| evrardjp | you have this: https://review.openstack.org/#/c/640711/ | 15:27 |
| evrardjp | that's a good example of branching content for the spec | 15:28 |
| hogepodge | my only concern with profiles in regular bindep is explosion of complexity within one file, and stale branch information that we'd constantly have to be going back and pruning | 15:28 |
| evrardjp | fair | 15:28 |
| evrardjp | to simplify code, we can also not write a merge function | 15:29 |
| hogepodge | I'm open to suggestions though, tbh. My first instinct is often not the right one | 15:29 |
| evrardjp | but declare if there is a need of branching, then it is automatically removed from the default | 15:29 |
| evrardjp | hogepodge: haha | 15:29 |
| evrardjp | ok | 15:29 |
| itxaka | I dont think we are gonna use it too much tbh, so we should keep it as simple and dumb as possible | 15:29 |
| evrardjp | good to know | 15:29 |
| evrardjp | itxaka: I agree on keep it simple | 15:29 |
| hogepodge | +1 to that | 15:29 |
| itxaka | I'll write the blueprint on that soon-ish | 15:30 |
| evrardjp | great | 15:30 |
| hogepodge | #topic open discussion | 15:31 |
| *** openstack changes topic to "open discussion (Meeting topic: loci)" | 15:31 | |
| hogepodge | any other topics? | 15:31 |
| evrardjp | how is your test framework going? | 15:31 |
| evrardjp | locistack iirc? | 15:31 |
| hogepodge | evrardjp: stalled out this week because of other work, hoping to get a patch up today or Monday once I clear my morning meeting block | 15:31 |
| evrardjp | :D | 15:32 |
| evrardjp | good to hear | 15:32 |
| hogepodge | evrardjp: one patch I need to use in my framework is try to take advantage of profiles correctly, I'm kind of building in specific packages but that means I'm not using stock images | 15:32 |
| hogepodge | for correctness some have to be built with profiles for AIO, like Cinder for example | 15:33 |
| evrardjp | interesting, how are you using that? | 15:33 |
| hogepodge | apparently Sam had an AIO installer also, which I should take a look at. | 15:33 |
| evrardjp | different bindep? | 15:33 |
| evrardjp | oh I didn't know | 15:33 |
| evrardjp | proves I am young in this project :p | 15:34 |
| hogepodge | https://github.com/hogepodge/locistack/blob/master/build/Makefile#L9 | 15:34 |
| hogepodge | which gets applied down here https://github.com/hogepodge/locistack/blob/master/build/Makefile#L73 | 15:35 |
| evrardjp | oh god, it totally looks like what I am writing | 15:35 |
| hogepodge | Haha it helps cut down on layers and additional builds | 15:36 |
| hogepodge | But you can't use stock builds which is kind of the point anyway. | 15:37 |
| evrardjp | I am just templating this using bash instead of a makefile, but meh | 15:37 |
| evrardjp | I should maybe convert to make | 15:37 |
| hogepodge | I really like make for... making things | 15:38 |
| evrardjp | :D | 15:38 |
| hogepodge | ok, anything else? | 15:39 |
| evrardjp | none | 15:39 |
| hogepodge | thanks! have a great weekend! | 15:40 |
| evrardjp | you too! | 15:40 |
| hogepodge | #endmeeting | 15:40 |
| *** openstack changes topic to "Build image -- `docker build https://github.com/openstack/loci.git --build-arg PROJECT=keystone` || Review patches -- https://review.openstack.org/#/q/projects:openstack/loci+status:open" | 15:40 | |
| openstack | Meeting ended Fri Mar 8 15:40:59 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:41 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/loci/2019/loci.2019-03-08-15.01.html | 15:41 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/loci/2019/loci.2019-03-08-15.01.txt | 15:41 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/loci/2019/loci.2019-03-08-15.01.log.html | 15:41 |
| itxaka | o/ | 15:41 |
| itxaka | good weekend | 15:41 |
| hrw | too late. | 15:43 |
| evrardjp | oh hrw I saw your patch was still up, I didn't know if I should brought it up | 15:50 |
| evrardjp | maybe next week? | 15:50 |
| openstackgerrit | Merged openstack/loci master: For OpenSUSE Leap, use more recent version of zVMCloudConnector https://review.openstack.org/641647 | 15:51 |
| openstackgerrit | Merged openstack/loci master: Support self-signed certificates docker registry https://review.openstack.org/637963 | 15:52 |
| hrw | evrardjp: nothing changed with it | 15:55 |
| openstackgerrit | Merged openstack/loci master: add missing libvirt package for suse https://review.openstack.org/641985 | 15:56 |
| hrw | evrardjp: and no plans so far for working on it | 15:57 |
| hrw | evrardjp: working on py3inzing Kolla images | 15:58 |
| evrardjp | k | 15:58 |
| evrardjp | have fun I'd say? :p | 15:58 |
| hrw | ha! my calendar just said "loci meeting" | 16:00 |
| hrw | evrardjp: convincing others that they have to rewrite their yet-not-merged patches | 16:01 |
| evrardjp | should bump this :p | 16:01 |
| hrw | Tasks: 940, 3158 thr, 2087 kthr; 17 running | 16:02 |
| *** itxaka has quit IRC | 16:43 | |
| *** e0ne has joined #openstack-loci | 17:03 | |
| *** e0ne has quit IRC | 17:08 | |
| *** irclogbot_1 has quit IRC | 20:13 | |
| *** e0ne has joined #openstack-loci | 20:24 | |
| *** e0ne has quit IRC | 21:03 | |
| *** irclogbot_1 has joined #openstack-loci | 23:02 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!