| *** e0ne has joined #openstack-loci | 07:10 | |
| *** dims has quit IRC | 08:32 | |
| *** dims has joined #openstack-loci | 08:33 | |
| evrardjp | hogepodge: good question :) | 09:33 |
|---|---|---|
| evrardjp | hogepodge: do you count giving your opinion, or wait for our feedback? | 09:33 |
| evrardjp | should we decide to tag our images with versions, we'll probably be clear about the branching strategy too. | 09:34 |
| *** e0ne has quit IRC | 12:53 | |
| *** e0ne has joined #openstack-loci | 13:31 | |
| evrardjp | I also have an idea on how to simplify the image building, removing many of the previous dockerfiles (per distro), removing the base->requirements->project and keeping only one Dockerfile using multi-staged builds. | 14:28 |
| evrardjp | (without changing the interface on the users) | 14:29 |
| hrw | evrardjp: how? | 14:32 |
| evrardjp | hrw: https://docs.docker.com/develop/develop-images/multistage-build/ | 14:36 |
| evrardjp | COPY distro/install-${DISTRO}.sh for example in stage 0. That would provide a base image that's fine. stage 1 would be requirements for said stage0. stage2 would build with wheels from stage1. | 14:37 |
| evrardjp | no need to have fancy fetch wheels anymore, reducing the amount of code to ship. | 14:37 |
| hrw | so loci-base -> requirements -> cinder/horizon/etc | 14:38 |
| hrw | looks sane | 14:39 |
| evrardjp | yeah. | 14:39 |
| evrardjp | also it means it's tightly coupled, which makes it super easy for releasing | 14:39 |
| evrardjp | if we force this path, there is no reuse of requirements, so it might be loci base > requirements + anything > copy from requirements > projects | 14:40 |
| hrw | evrardjp: but can it be used to generate several images? | 14:41 |
| evrardjp | But I like the simplicity of everything in a file. | 14:41 |
| evrardjp | hrw: exactly like it is now | 14:41 |
| hrw | cause doc looks like 'lets build few images in a row but release last one' | 14:41 |
| evrardjp | hrw: it's just adding a few extra things on top, removing other files. | 14:41 |
| hrw | evrardjp: requirements image is time saver on arm64 | 14:42 |
| hrw | if I have to builds wheels per each image then I will be against | 14:42 |
| hrw | now it is: base, requirements, projects | 14:42 |
| evrardjp | I have to test if COPY can accept an argument | 14:43 |
| hrw | if multistage will be: for project in cinder horizon etc;do docker build 'base->requirements->$project';done - then I am against | 14:43 |
| evrardjp | (if it can, we can go for multistage with everything in one file) | 14:43 |
| evrardjp | (if it cannot, it will have to be split into two things: base + requirements, projects) | 14:44 |
| evrardjp | I see | 14:44 |
| hrw | so nothing change basically | 14:44 |
| evrardjp | re-using code from docker instead of writing our own :) | 14:44 |
| hrw | as now we say "do own base" and requirements do not have to use that base as it generate only wheels | 14:45 |
| evrardjp | and wrapping that with plays/shell scripts sounds bad | 14:45 |
| evrardjp | requirements building should happen on the same kind of host as final image | 14:45 |
| evrardjp | else you can have mistmatching libs | 14:46 |
| hrw | evrardjp: https://git.linaro.org/ci/job/configs.git/tree/ldcg-loci/build.sh is my simplest way of building whole loci | 14:46 |
| evrardjp | libvirt would probably be a nuisance for example | 14:46 |
| hrw | base, requirements, projects | 14:46 |
| hrw | one after another in one CI job | 14:46 |
| evrardjp | yeah, at the same time, it already work, so why change it :) | 14:47 |
| hrw | that multistage thing will be nice if one 'docker build' could generate several outputs | 14:47 |
| hrw | sorry to ruin your idea | 14:50 |
| evrardjp | it's fine :) | 15:19 |
| evrardjp | that's why we are here to talk about it | 15:19 |
| evrardjp | less work for me too :) | 15:19 |
| hrw | D | 15:20 |
| hrw | : | 15:20 |
| *** munimeha1 has joined #openstack-loci | 15:53 | |
| *** e0ne has quit IRC | 16:26 | |
| *** e0ne has joined #openstack-loci | 16:38 | |
| *** e0ne has quit IRC | 16:48 | |
| *** e0ne has joined #openstack-loci | 20:20 | |
| *** e0ne has quit IRC | 20:30 | |
| *** dhellmann_ has joined #openstack-loci | 23:26 | |
| *** dhellmann has quit IRC | 23:26 | |
| *** dhellmann_ is now known as dhellmann | 23:30 | |
| *** pbourke has quit IRC | 23:46 | |
| *** pbourke has joined #openstack-loci | 23:47 | |
| *** munimeha1 has quit IRC | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!