| johnsom | docutils seems to have changed and broke the octavia-tempest-plugin docs job. Turns out the issue is actually in the tempest code itself. | 00:13 |
|---|---|---|
| johnsom | https://bugs.launchpad.net/tempest/+bug/2086747 | 00:13 |
| johnsom | Crazy obscure to figure out | 00:13 |
| skraynev_ | @gthiemonge : hello, I left the answer on PR: https://review.opendev.org/c/openstack/octavia/+/933254 however I have some doubts about correct comprehension your question. I can see the debug message and error happens when the row is missed. | 06:41 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-lib master: Add vip_sg_ids to the data model https://review.opendev.org/c/openstack/octavia-lib/+/919722 | 06:45 |
| gthiemonge | skraynev: ok thanks, I replied in the review, I think it's ok to not display the exceptions when deleting the amp health records | 08:29 |
| opendevreview | Merged openstack/octavia-lib master: Add vip_sg_ids to the data model https://review.opendev.org/c/openstack/octavia-lib/+/919722 | 08:35 |
| skraynev | ok, got it. I think that suspending all exceptions on this flow is ok. I will update PR with 'pass' statement | 08:36 |
| opendevreview | Sergey Kraynev proposed openstack/octavia master: Remove amphora_health record on revert CreateAmphoraInDB https://review.opendev.org/c/openstack/octavia/+/933254 | 08:45 |
| gthiemonge | skraynev: thanks! | 08:48 |
| skraynev | @gthiemonge : could you please also take a look backports for PR: https://review.opendev.org/c/openstack/octavia/+/933101 | 08:49 |
| gthiemonge | skraynev: yeah I will | 08:52 |
| skraynev | thank you | 09:04 |
| opendevreview | Tom Weininger proposed openstack/python-octaviaclient master: Add missing FAILOVER_STOPPED amphora status https://review.opendev.org/c/openstack/python-octaviaclient/+/934133 | 09:40 |
| opendevreview | Tom Weininger proposed openstack/python-octaviaclient master: Add missing FAILOVER_STOPPED loadbalancer status https://review.opendev.org/c/openstack/python-octaviaclient/+/934133 | 09:48 |
| opendevreview | Tom Weininger proposed openstack/python-octaviaclient master: Add missing FAILOVER_STOPPED amphora status https://review.opendev.org/c/openstack/python-octaviaclient/+/934133 | 09:57 |
| opendevreview | Tom Weininger proposed openstack/python-octaviaclient master: Add missing FAILOVER_STOPPED amphora status https://review.opendev.org/c/openstack/python-octaviaclient/+/934133 | 10:03 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Handle undefined protocol field in security group rules correctly https://review.opendev.org/c/openstack/octavia/+/934224 | 10:45 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Handle undefined protocol field in security group rules correctly https://review.opendev.org/c/openstack/octavia/+/934224 | 11:06 |
| opendevreview | Tom Weininger proposed openstack/python-octaviaclient master: Add missing FAILOVER_STOPPED amphora status https://review.opendev.org/c/openstack/python-octaviaclient/+/934133 | 11:07 |
| opendevreview | Tom Weininger proposed openstack/python-octaviaclient master: Add missing FAILOVER_STOPPED amphora status https://review.opendev.org/c/openstack/python-octaviaclient/+/934133 | 11:09 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Handle undefined protocol field in security group rules correctly https://review.opendev.org/c/openstack/octavia/+/934224 | 11:10 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Document how the stale amps get processed internally https://review.opendev.org/c/openstack/octavia/+/934235 | 12:21 |
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed Nov 6 16:00:14 2024 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| gthiemonge | o/ | 16:00 |
| tweining | o/ | 16:00 |
| johnsom | o/ | 16:00 |
| gthiemonge | #topic Announcements | 16:02 |
| gthiemonge | well... no announcements from me this week | 16:02 |
| gthiemonge | did we miss anything? | 16:02 |
| johnsom | Nope | 16:02 |
| johnsom | Tempest broke our docs job in octavia-tempest-plugin | 16:03 |
| johnsom | I opened a bug and posted a patch | 16:03 |
| gthiemonge | #topic CI Status | 16:03 |
| gthiemonge | yeah I saw it in the RBAC test patch | 16:03 |
| gthiemonge | I though it was the patch | 16:04 |
| gthiemonge | thanks for reporting and fixing it johnsom | 16:04 |
| tweining | https://review.opendev.org/c/openstack/tempest/+/934194 for reference | 16:05 |
| gthiemonge | interesting | 16:06 |
| gthiemonge | good catch | 16:06 |
| johnsom | Tough to track down | 16:06 |
| gthiemonge | yeah :) | 16:06 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:07 |
| tweining | let me know when you are done because I have three minor patches this time | 16:08 |
| gthiemonge | I'm fixing an issue with SINGLE LBs with UDP listener, the GARP is not sent by the amphora (so it can affect the LB after a failover for instance), patch got a -1 I'll update it tomorrow | 16:09 |
| johnsom | I have been testing and re-organizing the RBAC patch chain. Your comment was actually my next step, switching the jobs around. | 16:09 |
| gthiemonge | tweining: you can send the links now | 16:09 |
| tweining | https://review.opendev.org/c/openstack/python-octaviaclient/+/934133 1 is a missing FAILOVER_STOPPED status in python-octaviaclient | 16:09 |
| gthiemonge | johnsom: I reviewed and tested the Octavia RBAC patch, it LGTM, very clean patch | 16:10 |
| tweining | https://review.opendev.org/c/openstack/octavia/+/934224 2 is a bugfix for a bug reported to kolla-ansible but not octavia before | 16:10 |
| johnsom | Thanks, just need to get all of the gates straight now | 16:10 |
| gthiemonge | tweining: +1 thanks for the patch, I'll leave a comment in the kolla-ansible bug | 16:11 |
| tweining | https://review.opendev.org/c/openstack/octavia/+/934235 3 is a documentation update with a comment. I think we could optimize that health check function a bit | 16:11 |
| tweining | gthiemonge: thanks. tell them to open a bug for octavia next time. :) | 16:11 |
| gthiemonge | yeah they could have just added it to the list of affected project :/ | 16:12 |
| johnsom | tweining, on that comment. I think she did it this way to account for multiple health manager instances. | 16:14 |
| johnsom | I.e. you don't want two processes with the same list in the thread pool. | 16:14 |
| johnsom | There is a way to do it in bulk with the DB, but I think she went down the easier path | 16:15 |
| tweining | mmh, I think I see what you mean. | 16:16 |
| johnsom | There was also something about randomizing the list so it didn't pull the same list every time, but maybe that was another issue.... | 16:17 |
| tweining | I it would require some inter process synchronization mechanism othewise and that can complicate things | 16:19 |
| tweining | *I think | 16:19 |
| johnsom | Yeah, we prefer to use the database locking for things like this | 16:19 |
| johnsom | When she pulls one at a time, she locks the object at the same time | 16:20 |
| johnsom | It's atomic at the DB level | 16:20 |
| gthiemonge | I need to investigate but the submit(failover_amphora) may have a different behavior now we are using amphorav2 (or maybe it's different only when jobboard is enabled) | 16:20 |
| gthiemonge | (that would mean that we probably no longer need to have many threads that looks for stale amphorae) | 16:21 |
| gthiemonge | anyway the comments are helpful there | 16:21 |
| gthiemonge | #topic Open Discussion | 16:23 |
| tweining | hmm, maybe multiprocessing.Queue could work https://docs.python.org/3/library/multiprocessing.html#exchanging-objects-between-processes | 16:23 |
| johnsom | Health manager processes are usually on different hosts | 16:24 |
| tweining | okay :/ | 16:24 |
| tweining | I don't have other things to discuss, I think. I stopped working on rate limiting to work on a downstream task | 16:25 |
| gthiemonge | ack | 16:27 |
| gthiemonge | I guess we can close this meeting! | 16:28 |
| gthiemonge | thank you guys! | 16:28 |
| gthiemonge | #endmeeting | 16:28 |
| opendevmeet | Meeting ended Wed Nov 6 16:28:37 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:28 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-11-06-16.00.html | 16:28 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-11-06-16.00.txt | 16:28 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2024/octavia.2024-11-06-16.00.log.html | 16:28 |
| opendevreview | Ghanshyam proposed openstack/octavia-tempest-plugin master: Remove stable/2023.1 job from master gate https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/934270 | 19:50 |
| opendevreview | Michael Johnson proposed openstack/octavia-tempest-plugin master: Remove system scope token usage https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/926867 | 20:24 |
| opendevreview | Michael Johnson proposed openstack/octavia-tempest-plugin master: Remove system scope token usage https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/926867 | 20:26 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!