| skraynev | Hello, I added release notes to PRs with bug fixes, could someone please review: https://review.opendev.org/c/openstack/octavia/+/933101 and https://review.opendev.org/c/openstack/octavia/+/933254 | 07:07 |
|---|---|---|
| gthiemonge | skraynev: added a comment to the first one | 07:10 |
| skraynev | @gthiemonge : thx. Actually I didn't think about it, because it was the old format before fix. potentially I could remove the old error message and print always the version without db_lb. wdyt ? another option to display ip_address, vip_subnet, vip_network from VIP db object. | 07:17 |
| gthiemonge | skraynev: IMHO a straightforward approach is to display the id of the LB (loadbalancer[constants.LOADBALANCER_ID]) which is the unique identifier of the VIP | 07:22 |
| skraynev | Hm. It will solve the issue totally. without db_lb in message it will be a simple fix in error message. I will update PR | 07:30 |
| gthiemonge | skraynev: maybe add result[constants.VRRP_PORT_ID] too? | 07:33 |
| skraynev | sure, it's possible | 07:34 |
| opendevreview | Sergey Kraynev proposed openstack/octavia master: Do not fail on revert PlugVIPAmphora due undefined db_lb https://review.opendev.org/c/openstack/octavia/+/933101 | 08:12 |
| skraynev | @gthiemonge : updated, could you please take a look? I add info about VRRP_PORT_ID and want to make sure, that it matches with your expectations | 08:14 |
| opendevreview | Denys Mishchenko proposed openstack/octavia master: Add spec for multiple AZ amphora placement https://review.opendev.org/c/openstack/octavia/+/923571 | 11:23 |
| skraynev | @gthiemonge comments are fixed and Pr are ready for review: https://review.opendev.org/c/openstack/octavia/+/933254 , https://review.opendev.org/c/openstack/octavia/+/933101 | 12:21 |
| servagem | Hello, I am trying to understand the default value for the listener connection limit option. IIUC, the default is set to -1, which represents an unlimited number of connections. However, when using HAProxy (in Amphorae), the default is set to 50000 connections instead. Is that correct? | 17:41 |
| tkajinam | https://github.com/openstack/octavia/blob/fd071d3391e5695e50748f74af4529186d63e472/octavia/common/config.py#L428-L430 | 17:51 |
| tkajinam | servagem, probably this answers you question ? ^^^ | 17:51 |
| tkajinam | https://docs.openstack.org/api-ref/load-balancer/v2/#id35 | 17:52 |
| tkajinam | connection_limit (Optional) | 17:52 |
| tkajinam | 17:52 | |
| tkajinam | body | 17:52 |
| tkajinam | 17:52 | |
| tkajinam | integer | 17:52 |
| tkajinam | 17:52 | |
| tkajinam | The maximum number of connections permitted for this listener. Default value is -1 which represents infinite connections or a default value defined by the provider driver. | 17:52 |
| johnsom | This changed over time. HAProxy changed memory allocation, so we had to drop the -1 to 50,000 by default. | 17:54 |
| johnsom | I guess not all of the docs got updated | 17:55 |
| servagem | What confused me is the fact that it depends on the provider. For example, according to the API reference, it states 'unlimited,' but for the Amphora provider driver, the limit is 50k. | 17:56 |
| servagem | so, I am not sure if that is really expected or it is missing update the docs to 50k | 17:56 |
| johnsom | Yes, that is true. It is provider specific | 17:57 |
| servagem | yep, got it | 18:03 |
| servagem | thank you tkajinam and johnsom | 18:06 |
| opendevreview | Merged openstack/octavia-tempest-plugin master: Remove support for Pyton 3.8 and older https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/933270 | 18:59 |
| opendevreview | Michael Johnson proposed openstack/octavia master: Make keystone default roles the default RBAC https://review.opendev.org/c/openstack/octavia/+/929580 | 21:11 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!