| opendevreview | Tom Weininger proposed openstack/octavia master: pyupgrade changes for Python3.8+ (1) https://review.opendev.org/c/openstack/octavia/+/905591 | 08:36 |
|---|---|---|
| opendevreview | Tom Weininger proposed openstack/octavia master: pyupgrade changes for Python3.8+ (2) https://review.opendev.org/c/openstack/octavia/+/905592 | 08:36 |
| opendevreview | Tom Weininger proposed openstack/octavia master: pyupgrade changes for Python3.8+ (3) https://review.opendev.org/c/openstack/octavia/+/905593 | 08:36 |
| opendevreview | Tom Weininger proposed openstack/octavia master: pyupgrade changes for Python3.8+ (4) https://review.opendev.org/c/openstack/octavia/+/905594 | 08:36 |
| opendevreview | Tom Weininger proposed openstack/octavia master: pyupgrade changes for Python3.8+ (5) https://review.opendev.org/c/openstack/octavia/+/905595 | 08:36 |
| opendevreview | Tom Weininger proposed openstack/octavia master: pyupgrade changes for Python3.8+ (6) https://review.opendev.org/c/openstack/octavia/+/905596 | 08:36 |
| opendevreview | Tom Weininger proposed openstack/octavia master: pyupgrade changes for Python3.8+ (7) https://review.opendev.org/c/openstack/octavia/+/899263 | 08:36 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add pyupgrade hook to pre-commit config https://review.opendev.org/c/openstack/octavia/+/899264 | 08:36 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Use f-strings where possible https://review.opendev.org/c/openstack/octavia/+/900156 | 08:36 |
| tweining | rebasing these ^ was pretty straightforward actually. Only two files were in conflict. | 08:36 |
| tweining | ... and I didn't lose all the votes, which is good as well. | 08:39 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Integrate mypy type checker https://review.opendev.org/c/openstack/octavia/+/879749 | 11:21 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Integrate mypy type checker https://review.opendev.org/c/openstack/octavia/+/879749 | 11:41 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Integrate mypy type checker https://review.opendev.org/c/openstack/octavia/+/879749 | 11:46 |
| skraynev | @gthiemonge : hi, could you please help with review: https://review.opendev.org/c/openstack/octavia/+/914811 , https://review.opendev.org/c/openstack/octavia/+/910464 and backport https://review.opendev.org/c/openstack/octavia/+/909824 ? | 12:15 |
| gthiemonge | skraynev: done on 2 of them, looking at the 3rd patch (HM parameters), I wish we could have another way to validate the parameters in the fully-populated API :/ | 12:30 |
| gthiemonge | sorry I had to read the launchpad again, it's not related to the fully-populated API, I'm testing your fix | 12:33 |
| skraynev | @gthiemonge : thank you. Regarding validation for HM paramaters - the aim was to fix issue with minimal changes. I don't mind to add more changes/apply another approach, if it's required. just let me know ;) | 12:34 |
| gthiemonge | skraynev: LGTM but we need a release note for such bugfixes | 12:55 |
| skraynev | @gthiemonge : sure, I will add it. btw, what do I need to do with the fail on backport? https://review.opendev.org/c/openstack/octavia/+/909824 it reports about files missed in the patch | 12:58 |
| gthiemonge | skraynev: yeah, there's probably a new pylint release that detects new issues on this branch | 13:07 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add typing information to remaining octavia code https://review.opendev.org/c/openstack/octavia/+/905195 | 13:07 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Integrate mypy type checker https://review.opendev.org/c/openstack/octavia/+/879749 | 13:07 |
| gthiemonge | skraynev: we have to fix that first | 13:07 |
| gthiemonge | let me do it | 13:07 |
| skraynev | @gthiemonge : thank you, please let me know, when I could re-run job. | 13:08 |
| opendevreview | Sergey Kraynev proposed openstack/octavia master: Handle empty delay on update healthmonitor https://review.opendev.org/c/openstack/octavia/+/914811 | 13:21 |
| opendevreview | Sergey Kraynev proposed openstack/octavia master: Handle empty delay on update healthmonitor https://review.opendev.org/c/openstack/octavia/+/914811 | 13:23 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/2023.1: Pin pylint (<=3.0.4) https://review.opendev.org/c/openstack/octavia/+/915423 | 13:24 |
| skraynev | @gthiemonge could you please take a brief look. is it enough for Release note: https://review.opendev.org/c/openstack/octavia/+/914811/3 ? | 13:24 |
| gthiemonge | skraynev: yeah LGTM | 13:27 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Integrate mypy type checker https://review.opendev.org/c/openstack/octavia/+/879749 | 13:55 |
| *** gouthamr_ is now known as gouthamr | 14:35 | |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add typing information to remaining octavia code https://review.opendev.org/c/openstack/octavia/+/905195 | 14:42 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Integrate mypy type checker https://review.opendev.org/c/openstack/octavia/+/879749 | 14:42 |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: Add TERMINATED_HTTPS listener API tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/893066 | 15:17 |
| opendevreview | Michael Johnson proposed openstack/octavia stable/2023.1: Pin pylint (<=3.0.4) https://review.opendev.org/c/openstack/octavia/+/915423 | 16:30 |
| opendevreview | Merged openstack/octavia stable/zed: Fix the issue of losing nf_conntrace* values after a reboot. https://review.opendev.org/c/openstack/octavia/+/909825 | 17:34 |
| opendevreview | Merged openstack/octavia stable/2023.1: Pin pylint (<=3.0.4) https://review.opendev.org/c/openstack/octavia/+/915423 | 21:07 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!