| opendevreview | Tom Weininger proposed openstack/octavia master: Integrate mypy type checker https://review.opendev.org/c/openstack/octavia/+/879749 | 14:50 |
|---|---|---|
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed Nov 8 16:00:20 2023 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| gthiemonge | hello | 16:00 |
| oschwart | o/ | 16:00 |
| tweining | o/ | 16:00 |
| johnsom | o/ | 16:00 |
| gthiemonge | #topic Announcements | 16:01 |
| gthiemonge | * 2024.1 Caracal Release Schedule | 16:01 |
| gthiemonge | FYI next week is Caracal-1 milestone! | 16:02 |
| gthiemonge | I think we should focus on reviewing the specs | 16:02 |
| gthiemonge | (SR-IOV, LB resize) | 16:02 |
| johnsom | Wow, so fast. | 16:02 |
| gthiemonge | yeah | 16:02 |
| tweining | already? we just had PTG | 16:02 |
| johnsom | BTW, I am updating the SR-IOV spec as we speak | 16:02 |
| johnsom | I should push an update today | 16:03 |
| gthiemonge | https://releases.openstack.org/caracal/schedule.html | 16:03 |
| gthiemonge | I don't have any other announcements | 16:07 |
| gthiemonge | anyone? | 16:07 |
| tweining | will there be a summary about the ptg? or did I miss it? | 16:07 |
| gthiemonge | it's in the etherpad ;-) | 16:08 |
| johnsom | +1 | 16:08 |
| johnsom | lol | 16:08 |
| tweining | ok, I have a few things about the ptg but we can discuss it in the open discussion | 16:09 |
| gthiemonge | ack | 16:10 |
| gthiemonge | I'll skip the CI status section, I didn't see any issues | 16:11 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:11 |
| johnsom | You aren't impacted by the oslo util issue for the sqlalchemy 2.x job? | 16:11 |
| gthiemonge | johnsom: oh yes we are | 16:12 |
| gthiemonge | https://zuul.opendev.org/t/openstack/builds?job_name=octavia-tox-functional-py39-sqlalchemy-tips&project=openstack/octavia | 16:12 |
| johnsom | We made it non-voting for now on designate | 16:12 |
| gthiemonge | ack we can do the same thing in octavia | 16:12 |
| johnsom | The fix merged yesterday, I'm not sure when a release and UC bump will happen | 16:13 |
| gthiemonge | ok | 16:13 |
| johnsom | This is the bug I opened if you aren't familiar with the issue: https://bugs.launchpad.net/bugs/2042886 | 16:13 |
| gthiemonge | thanks johnsom | 16:15 |
| gthiemonge | I dont have new patches for you guys | 16:18 |
| gthiemonge | but tkajinam proposed to fix the deprecated/removed pyopenssl functions: | 16:18 |
| gthiemonge | https://review.opendev.org/c/openstack/octavia/+/900142 | 16:18 |
| gthiemonge | damn, we passed the 900000 reviews | 16:19 |
| johnsom | Yeah, good stuff. Glad cryptography finished the pkcs12 work | 16:19 |
| tweining | openssl had that deprecated for 3 years apparently | 16:19 |
| johnsom | Yeah, it was in 2.5, but that wasn't in distros | 16:20 |
| tweining | mypy caught that issue as well btw | 16:20 |
| johnsom | Yeah, that is a problem, it's running unconstrained? | 16:20 |
| johnsom | This is the reason I am reluctant to add more/new tooling like this | 16:21 |
| tweining | it got the typing info from the latest pyopenssl release | 16:21 |
| tweining | (where this function was removed) | 16:21 |
| johnsom | Yeah, so that is a problem | 16:21 |
| gthiemonge | the pyopenssl typing module doesn't have upper constraints | 16:22 |
| tweining | I see that as a feature, not a problem | 16:22 |
| johnsom | It means those jobs will be broken very often | 16:22 |
| gthiemonge | but it could report false positives | 16:23 |
| tweining | what do you mean? that it alarms about a release that openstack won't use? | 16:23 |
| johnsom | A release OpenStack is not using yet. | 16:23 |
| gthiemonge | if the typing info don't match the code, we may have some false reports | 16:24 |
| tweining | I think it is good that typing packages are not constrained by uc in openstack, so that things like that get caught early | 16:24 |
| johnsom | Like sqlalchemy for example, it was released long before OpenStack was ready for it. | 16:24 |
| tweining | well, in that case it would need to be constrained then. I agree. | 16:25 |
| gthiemonge | then we can also have an unconstraint job | 16:25 |
| johnsom | Yeah, if there is value, we can add tips jobs, but they are non-voting. | 16:26 |
| tweining | I will come back to mypy later as well. let's move on | 16:27 |
| gthiemonge | we can move to the next topic | 16:27 |
| gthiemonge | #topic Open Discussion | 16:27 |
| johnsom | I want to run a design decision by you all | 16:28 |
| johnsom | On the SR-IOV patch, right now the API does not show if the VIP is a SR-IOV VF or not. | 16:28 |
| johnsom | I am thinking I should add that to my patch and have a vip_vnic_type field that would be "normal" or "direct" (same as the neutron port). | 16:29 |
| johnsom | Thoughts? | 16:29 |
| gthiemonge | johnsom: does the user need it? | 16:29 |
| johnsom | Eh, I don't know. They can't see it otherwise as the port is owned by Octavia | 16:30 |
| tweining | I can imagine it can be useful to have that info in some cases | 16:31 |
| gthiemonge | johnsom: maybe a stupid question, how does octavia know that a VIP is a SR-IOV port? (I mean internally) | 16:33 |
| johnsom | The neutron port has a vnic_type field. Also, when we create the port, we ask for a "direct" port | 16:33 |
| gthiemonge | it's in the flavor too? | 16:34 |
| johnsom | <someone hasn't read the docs in the patch yet> grin | 16:34 |
| gthiemonge | https://review.opendev.org/c/openstack/octavia/+/899504/2/octavia/api/drivers/amphora_driver/flavor_schema.py | 16:34 |
| gthiemonge | I'm reading it ;-) | 16:34 |
| johnsom | So, yeah, the Octavia flavor has a new parameter that says this LB should be created with SR-IOV ports | 16:34 |
| gthiemonge | ack | 16:35 |
| johnsom | In neutron the port has: | 16:35 |
| johnsom | | binding_vnic_type | direct | 16:35 |
| gthiemonge | ok I think a new field in the API is fine | 16:36 |
| johnsom | Where "normal" is an OVS/OVN port | 16:36 |
| gthiemonge | +1 | 16:36 |
| johnsom | Ok, I was leaning that direction too, but wanted feedback | 16:36 |
| tweining | ok, let me come back to mypy again... | 16:37 |
| tweining | https://review.opendev.org/c/openstack/octavia/+/879749 for reference | 16:37 |
| tweining | I understand there is some resistance against that new tool. would it help if I separate the typing information that I added from the mypy tool related stuff? | 16:38 |
| johnsom | I don't have an issue with adding typing to the python. (Though I don't have that habit yet) | 16:38 |
| tweining | because it's the code stuff that is more important to me personally | 16:38 |
| johnsom | My concern is about job stability and is this another tool that breaks our gates regularly | 16:39 |
| tweining | we could give it a chance at least. a trial period or so. | 16:40 |
| gthiemonge | I think we can keep it like that, we just need to check if all the required changes are relevant | 16:40 |
| gthiemonge | maybe we need to make it non-voting until we clarify/fix those unconstrainted requirements | 16:41 |
| tweining | ok, thanks. I am looking forward to your reviews :) | 16:41 |
| tweining | another topic. I found a few interesting things on the PTG etherpad of the nova project | 16:42 |
| tweining | pyupdate and codespell are two other tools and I posted patches about them already. thanks for the reviews | 16:43 |
| tweining | the other thing was a spec for "per-process-healthchecks" | 16:44 |
| tweining | https://review.opendev.org/c/openstack/nova-specs/+/897225 | 16:44 |
| tweining | maybe we should have something similar for octavia as well. ATM only o-api has a healthcheck endpoint | 16:44 |
| tweining | it would improve compatibility with kubernetes I guess | 16:45 |
| gthiemonge | do they add REST servers to all their services? | 16:45 |
| johnsom | Yeah, the kubernetes issue is something I have raised internally a number of times. | 16:45 |
| johnsom | This topic has been debated for a number of years in OpenStack as well. | 16:45 |
| tweining | I haven't read that spec in detail yet to be honest | 16:46 |
| johnsom | I have not read the nova spec, but the previous PTG debates have been around how to do this | 16:46 |
| johnsom | Many of us don't want to add HTTP stacks to every process. For security and resource usage reasons. | 16:47 |
| gthiemonge | I'll read it | 16:47 |
| johnsom | There is the approach of using rabbit messages, designate went down this path to some degree, but didn't finish | 16:47 |
| tweining | it is not really blocking k8s compatibility because there are other mechanisms, but it would be nice to have it probably | 16:47 |
| johnsom | That doesn't solve the k8s issue though | 16:47 |
| johnsom | It really is necessary for k8s as otherwise graceful shutdowns can be interrupted by k8s timeouts and very bad things happen | 16:48 |
| johnsom | There was talk of opening a local socket too. This would work for k8s and many monitoring agents. | 16:49 |
| johnsom | Then the debate goes into, per process, per thread, etc. How much it tests (db, rabbit, etc.) | 16:49 |
| johnsom | Anyhow, I think it would be a good thing, but it's a complicated topic. If you have ideas, I encourage you to post a spec. | 16:50 |
| johnsom | The current oslo middleware healthcheck stuff is not great | 16:51 |
| gthiemonge | ack | 16:52 |
| gthiemonge | interesting stuff | 16:52 |
| gthiemonge | thanks for bringing up the topic tweining | 16:54 |
| tweining | yeah, it's food for thought | 16:54 |
| tweining | there was another tool on the nova etherpad, I think sphinxlint or so. I didn't look into that one. | 16:55 |
| johnsom | https://review.opendev.org/c/openstack/oslo-specs/+/531456 | 16:55 |
| johnsom | That was an old spec starting to address some issues with the healthcheck middleware | 16:56 |
| johnsom | it's abandoned | 16:56 |
| gthiemonge | ok folsk, we're almost at the top of the hour | 16:59 |
| gthiemonge | anything else before we close the meeting? | 16:59 |
| tweining | that's all from me | 16:59 |
| gthiemonge | ok | 17:00 |
| gthiemonge | good discussions! | 17:00 |
| gthiemonge | thank you guys! | 17:00 |
| gthiemonge | #endmeeting | 17:00 |
| opendevmeet | Meeting ended Wed Nov 8 17:00:32 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-11-08-16.00.html | 17:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-11-08-16.00.txt | 17:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-11-08-16.00.log.html | 17:00 |
| opendevreview | Michael Johnson proposed openstack/octavia master: Add spec for SR-IOV in Octavia Amphora https://review.opendev.org/c/openstack/octavia/+/891244 | 23:20 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!