| *** osmanlicilegi is now known as Guest0 | 04:33 | |
| tobias-urdin | some years back (2018) i reported an issue https://storyboard.openstack.org/#!/story/2004255 moving from python 2.7 -> 3 where the default format version for pickle() was changed | 06:28 |
|---|---|---|
| tobias-urdin | now some years later, moving from python 3.6 -> 3.9 the same issue occurs, if you run (same octavia version) on python 3.6 and python 3.9 with a rolling approach, python 3.6 nodes will crash when trying to read data pickle()'d on a node that is running python 3.9 | 06:29 |
| tobias-urdin | I didn't spend any time looking into it in more details, but isn't there any (easy?) way we could work around this by using an older pickle version (that would probably mean setting it to the py3.9 version in master) or moving away from pickle to just raw json like johnsom talked about back then? | 06:31 |
| tobias-urdin | gthiemonge: ^ i talked back in 2018 to johnsom about it | 06:31 |
| gthiemonge | tobias-urdin: hi | 06:50 |
| gthiemonge | I see | 06:50 |
| gthiemonge | so basically sa.PickleType() depends on the python version :/ | 06:51 |
| tobias-urdin | yea, and it's a little bit of a pain since you can't really do a rolling upgrade of octavia, anytime a pickle() format version 5 (python3.9 created LB for example) hits a python 3.6 running octavia service you'd get a provisioning_status error on changes and would need to troubleshoot and fix that for example | 06:53 |
| tobias-urdin | it's annoying for an operator :( | 06:53 |
| tobias-urdin | i have an example tb https://paste.opendev.org/show/b9FMUPOX2vdED3ueNgoR/ – but yea it's in the db layer | 06:55 |
| gthiemonge | https://docs.python.org/3/library/pickle.html#data-stream-format | 06:55 |
| gthiemonge | so protocol version 4 should be ok | 06:55 |
| tobias-urdin | checking codesearch, i can see heat has the same for resource_properties I think i've had that as well, but seems like octavia and heat are the only ones using PickleType (of core projects) | 06:56 |
| tobias-urdin | looks like it, perhaps that could be set as a default | 06:59 |
| gthiemonge | let's discuss it when johnsom is here, I think that passing protocol=4 to PickleType() would be acceptable | 06:59 |
| tobias-urdin | if you have the issue with version 5 already you'd still need to solve it, having new ones with version 4 seems fair | 07:00 |
| tobias-urdin | ack, thanks for looking into it! | 07:00 |
| gthiemonge | tobias-urdin: what openstack versions are you using? | 07:00 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: Fix links to the bug tracker in the docs/releasenotes https://review.opendev.org/c/openstack/octavia/+/895141 | 08:14 |
| tobias-urdin | gthiemonge: yoga | 11:33 |
| opendevreview | Merged openstack/octavia-tempest-plugin master: Fixed typo in override-checkout branch for stable/2023.1 https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/894821 | 12:49 |
| -opendevstatus- NOTICE: The lists.airshipit.org and lists.katacontainers.io sites will be offline briefly for migration to a new server | 16:48 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!