| opendevreview | Michael Johnson proposed openstack/octavia-lib master: Fix a possible receive timeout https://review.opendev.org/c/openstack/octavia-lib/+/892417 | 00:14 |
|---|---|---|
| opendevreview | Gaudenz Steinlin proposed openstack/octavia master: Raise NotFound on update of inexistent resources https://review.opendev.org/c/openstack/octavia/+/892281 | 07:00 |
| opendevreview | Gaudenz Steinlin proposed openstack/octavia master: Lock SELECTed DB rows when updating https://review.opendev.org/c/openstack/octavia/+/892460 | 07:23 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: DNM/WIP Testing c9s fix https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/892484 | 08:26 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: DNM/WIP Testing c9s fix https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/892484 | 08:57 |
| opendevreview | Omer Schwartz proposed openstack/octavia master: Fix l7 objects quota decrement on lb cascade delete https://review.opendev.org/c/openstack/octavia/+/886111 | 10:59 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Fix centos-9-stream jobs https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/892484 | 11:32 |
| opendevreview | Tom Weininger proposed openstack/python-octaviaclient master: Add extra validation for HSTS related arguments https://review.opendev.org/c/openstack/python-octaviaclient/+/892533 | 11:50 |
| opendevreview | Gaudenz Steinlin proposed openstack/octavia master: Raise NotFound on update of inexistent resources https://review.opendev.org/c/openstack/octavia/+/892281 | 14:18 |
| opendevreview | Omer Schwartz proposed openstack/octavia master: Fix l7 objects quota decrement on lb cascade delete https://review.opendev.org/c/openstack/octavia/+/886111 | 14:35 |
| johnsom | So this octavia-tox-functional-py39-sqlalchemy-tips job is failing, did py39 get removed somewhere? | 15:13 |
| johnsom | https://zuul.opendev.org/t/openstack/build/071180ebc8444f13befb5f9e5a06dfd9/log/job-output.txt#1646 | 15:13 |
| johnsom | https://review.opendev.org/c/openstack/octavia-lib/+/892417 | 15:13 |
| gthiemonge | hu | 15:24 |
| gthiemonge | johnsom: the commit that adds this job was merged yesterday, but it was tested only against openstack/octavia | 15:25 |
| gthiemonge | https://zuul.opendev.org/t/openstack/builds?job_name=octavia-tox-functional-py39-sqlalchemy-tips | 15:25 |
| gthiemonge | maybe tox.ini is not correct in octavia-lib | 15:26 |
| gthiemonge | functional-py39 doesn't exist there | 15:27 |
| johnsom | Yeah, that environment is missing in octavia-lib, so.... | 15:27 |
| johnsom | Do we have any sqlalchemy in octavia-lib? Do we need that job there? | 15:27 |
| gthiemonge | I don't think we need :/ | 15:27 |
| johnsom | Yeah, so there is no sqla there, can we remove that job? | 15:28 |
| gthiemonge | but it is inherited from https://review.opendev.org/c/openstack/octavia/+/889384/3/zuul.d/jobs.yaml | 15:28 |
| gthiemonge | can we skip it on octavia-lib? | 15:28 |
| gthiemonge | we can remove it from octavia-tox-tips and create a octavia-tox-sqlalchemy-tips that will be used only in octavia | 15:29 |
| gthiemonge | I can propose a fix | 15:29 |
| johnsom | Thank you | 15:30 |
| opendevreview | Omer Schwartz proposed openstack/octavia master: Fix l7 objects quota increment on populated lb create https://review.opendev.org/c/openstack/octavia/+/886263 | 15:31 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: Remove sqlalchemy-tips from the generic tips template https://review.opendev.org/c/openstack/octavia/+/892550 | 15:32 |
| gthiemonge | ^ that should do it | 15:33 |
| -opendevstatus- NOTICE: Gerrit is going to be restarted to pick up a small config update. You will notice a short outage of the service. | 15:33 | |
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed Aug 23 16:00:23 2023 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| johnsom | o/ | 16:00 |
| gthiemonge | hi | 16:00 |
| tweining | o/ | 16:00 |
| gthiemonge | #topic Announcements | 16:01 |
| gthiemonge | * Combined PTL/TC 2024.1 cycle Election Season | 16:01 |
| gthiemonge | FYI nominations are still open until Aug 30 | 16:02 |
| gthiemonge | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-August/034744.html | 16:02 |
| gthiemonge | * 2023.2 Bobcat Release Schedule: R-6 | 16:03 |
| gthiemonge | 6 weeks! | 16:03 |
| * johnsom thinks "four more years!" | 16:03 | |
| gthiemonge | This week marks the final release for non-client libraries (for us it's octavia-lib) | 16:03 |
| gthiemonge | And next week is feature freeze and final release for client libraries | 16:04 |
| gthiemonge | reminder: we have the priority review list | 16:04 |
| gthiemonge | https://etherpad.opendev.org/p/octavia-priority-reviews | 16:04 |
| tweining | thanks for your reviews on the HSTS patches | 16:04 |
| gthiemonge | There are a few open patches for octavia-lib but I think the HSTS patches in octavia/octaviaclient should have an higher priority | 16:04 |
| gthiemonge | and great news, the sqlalchemy2 stuff is merged!! | 16:06 |
| johnsom | +100 | 16:06 |
| tweining | https://review.opendev.org/c/openstack/octavia/+/880806 regarding this one, the main HSTS patch. it is not merged because it has parent patches in the chain. It would be nice if you could review them, otherwise let me know if I should remove them from the patch chain. | 16:07 |
| oschwart_ | great to hear about sqlalchemy2! o/ btw | 16:07 |
| johnsom | It would probably be best to break those apart, they are unrelated (at least at first glance) | 16:07 |
| tweining | yeah, I could try running the pyspy patch on master and see how bad it is now ;) | 16:08 |
| gthiemonge | anyway I'll review them tomorrow | 16:08 |
| tweining | they are. thanks | 16:08 |
| gthiemonge | but if you change the order of the chain we could merge the HSTS patch today since it already has 2 CR+2/W+1 | 16:09 |
| johnsom | I guess they are in global-requirements, so not as far out there as I thought those patches were | 16:09 |
| tweining | ok, sounds good I'll change the order then | 16:10 |
| johnsom | I just don't want to have a "special" test runner in Octavia as compared to the rest of OpenStack. So, I haven't had time to go do the research to see if we are causing trouble by using pytest | 16:11 |
| tweining | those patches change nothing in the CI. they just add new tox envs that make my life a lot easier when debugging tests | 16:11 |
| johnsom | This patch indicates it's more than just an optional test runner: https://review.opendev.org/c/openstack/octavia/+/881805/8 | 16:11 |
| tweining | pytest runs test classes that start with Test, that is why I had to rename them | 16:12 |
| johnsom | I am not clear on the benefit of pytest, what does it bring? | 16:13 |
| tweining | function wise it shouldn't change anything | 16:13 |
| tweining | more features, more convenience for the user, I think we had that discussion before :) | 16:13 |
| johnsom | Sorry I don't remember. I just didn't see any specific benefit in the but or patch commit. | 16:14 |
| johnsom | I am asking that we capture this, simply because it's one more thing to maintain, so it's not a zero cost thing for the project. | 16:15 |
| tweining | hm, okay. I'll need to think about how to capture it somewhere then. | 16:16 |
| johnsom | Thank you | 16:16 |
| gthiemonge | #topic CI Status | 16:17 |
| gthiemonge | c9s jobs are broken, it seems that it's a regression in devstack | 16:18 |
| gthiemonge | https://bugs.launchpad.net/devstack/+bug/2031639 | 16:18 |
| gthiemonge | they are fixing it but we also need to update the definition of our jobs | 16:18 |
| gthiemonge | I proposed a patch | 16:18 |
| gthiemonge | https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/892484 | 16:18 |
| johnsom | Ah cool, I was seeing the keystone wsgi failure in Designate and had pinged the PTL | 16:19 |
| gthiemonge | octavia-v2-dsvm-scenario-centos-9-stream-non-traffic-ops failed for an unrelated reason (haproxy crash?), I will investigate | 16:19 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add support for HTTP Strict Transport Security https://review.opendev.org/c/openstack/octavia/+/880806 | 16:19 |
| gthiemonge | BTW There's the same issue with rocky linux | 16:19 |
| gthiemonge | we haven't yet merged rocky linux support so I will have to update the open commit | 16:19 |
| gthiemonge | https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/873490 | 16:19 |
| gthiemonge | it's just one line... I'll ping you guys to get my CR+2s ;-) | 16:20 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:22 |
| gthiemonge | I forgot one thing, we broke octavia-lib CI | 16:22 |
| gthiemonge | the new sqlalchemy-tips tox job is executed there, but it doesn't work and it's not needed | 16:23 |
| gthiemonge | I've just proposed a patch in octavia that would fix octavia-lib | 16:23 |
| gthiemonge | https://review.opendev.org/c/openstack/octavia/+/892550 | 16:23 |
| tweining | ok, I'll have a look later | 16:24 |
| gthiemonge | on my side, I've done a lot of tests/reviews | 16:26 |
| tweining | I'd like to mention another one of my patches. It is also optional, but I hope I don't need to explain why I think it is useful. | 16:26 |
| tweining | https://review.opendev.org/c/openstack/octavia/+/879749 the mypy patch will need to be rebased again. but now that sqla2 patches are merged I hope it will be the last time. | 16:26 |
| tweining | it's obviously not urgent as it is not considered a feature, but I do want to have it merged during this cycle | 16:27 |
| gthiemonge | ack | 16:27 |
| gthiemonge | #topic Open Discussion | 16:31 |
| gthiemonge | any other topics folks? | 16:31 |
| oschwart_ | from my side I will start reviewing the patches on the priority list | 16:31 |
| oschwart_ | I am a little out of the loop | 16:32 |
| gthiemonge | thanks oschwart_! | 16:32 |
| tweining | I'm looking at https://review.opendev.org/c/openstack/octavia/+/892550 and am a bit confused that it actually doesn't remove anything in the patch | 16:32 |
| johnsom | It moved line 123 down to it's own job | 16:33 |
| johnsom | job->template | 16:33 |
| gthiemonge | tweining: octavia-lib uses octavia-tox-tips (project can use jobs defined in other jobs) | 16:33 |
| tweining | ah, got it. it is moved to another template | 16:33 |
| gthiemonge | tweining: so it doesn't change anything for octavia, but it will change the jobs in octaiva-lib | 16:34 |
| johnsom | The gerrit diff is deceiving | 16:34 |
| tweining | IDK. I think I didn't give an update about dpdk tests in a while but you all know the state | 16:36 |
| tweining | DPDK just works with Octavia amps. :) | 16:36 |
| tweining | nothing else to say from my side | 16:37 |
| gthiemonge | tweining: good to know ;-) | 16:37 |
| gthiemonge | ok guys, I think that's it! | 16:38 |
| gthiemonge | thank you! | 16:38 |
| gthiemonge | #endmeeting | 16:38 |
| opendevmeet | Meeting ended Wed Aug 23 16:38:32 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:38 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-08-23-16.00.html | 16:38 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-08-23-16.00.txt | 16:38 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-08-23-16.00.log.html | 16:38 |
| opendevreview | Michael Johnson proposed openstack/octavia-lib master: Fix a possible receive timeout https://review.opendev.org/c/openstack/octavia-lib/+/892417 | 16:44 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add pytest testenv to tox.ini https://review.opendev.org/c/openstack/octavia/+/881739 | 16:59 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Make tests work with pytest runner https://review.opendev.org/c/openstack/octavia/+/881805 | 17:00 |
| opendevreview | Merged openstack/octavia master: Remove sqlalchemy-tips from the generic tips template https://review.opendev.org/c/openstack/octavia/+/892550 | 19:19 |
| opendevreview | Merged openstack/octavia master: Add support for HTTP Strict Transport Security https://review.opendev.org/c/openstack/octavia/+/880806 | 20:23 |
| opendevreview | Merged openstack/octavia master: Fix IPv6 session persistence failed https://review.opendev.org/c/openstack/octavia/+/888530 | 22:36 |
| opendevreview | Merged openstack/octavia master: Fix health message format for v2 and v3 in unit tests https://review.opendev.org/c/openstack/octavia/+/885749 | 23:11 |
| opendevreview | Merged openstack/octavia master: Mock access to tuned active_profile file in unittests https://review.opendev.org/c/openstack/octavia/+/885750 | 23:11 |
| opendevreview | Merged openstack/octavia master: Update the bug tracker links in the doc (switch to Launchpad) https://review.opendev.org/c/openstack/octavia/+/879139 | 23:11 |
| opendevreview | Merged openstack/octavia master: Fix quota error messages https://review.opendev.org/c/openstack/octavia/+/879278 | 23:22 |
| opendevreview | Merged openstack/octavia master: Fix the issue of losing nf_conntrace* values after a reboot. https://review.opendev.org/c/openstack/octavia/+/886370 | 23:24 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!