| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlalchemy2] Turn on RemovedIn20Warnings in tests https://review.opendev.org/c/openstack/octavia/+/861288 | 07:07 |
|---|---|---|
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlalchemy2] move to Session.get() https://review.opendev.org/c/openstack/octavia/+/861289 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlalchemy2] use attribute to indicate relationship https://review.opendev.org/c/openstack/octavia/+/861310 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlalchemy2] positional arguments for case https://review.opendev.org/c/openstack/octavia/+/861311 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlalchemy2] Use subquery to select from a query https://review.opendev.org/c/openstack/octavia/+/861312 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlalchemy2] Using non-integer/slice indices on Row is deprecated https://review.opendev.org/c/openstack/octavia/+/861313 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlaclhemy2] Don't pass strings to session.execute https://review.opendev.org/c/openstack/octavia/+/861314 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlalchemy2] Removal of cascade backrefs https://review.opendev.org/c/openstack/octavia/+/861315 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlalchemy2] Added missing relationships in models https://review.opendev.org/c/openstack/octavia/+/875364 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlalchemy2] subtransactions & autocommit removal https://review.opendev.org/c/openstack/octavia/+/861316 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: [sqlalchemy2] Disabling 'create_engine.convert_unicode' filter https://review.opendev.org/c/openstack/octavia/+/875365 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: Fix sqlalchemy declarative_base import https://review.opendev.org/c/openstack/octavia/+/875892 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: WIP Adding a functional job with SQLAlchemy master https://review.opendev.org/c/openstack/octavia/+/875532 | 07:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: Fix pool_timeout for tests with sqlite file backend https://review.opendev.org/c/openstack/octavia/+/882117 | 07:07 |
| opendevreview | Tom Weininger proposed openstack/octavia master: DNM: profile w/ sqlalchemy2 using py-spy https://review.opendev.org/c/openstack/octavia/+/878917 | 07:16 |
| opendevreview | Tom Weininger proposed openstack/octavia-lib master: Add pre-commit config https://review.opendev.org/c/openstack/octavia-lib/+/882127 | 07:56 |
| opendevreview | Tom Weininger proposed openstack/octavia-lib master: Better __repr__() for data model https://review.opendev.org/c/openstack/octavia-lib/+/881701 | 08:00 |
| opendevreview | Tom Weininger proposed openstack/octavia-lib master: Add support for HTTP Strict Transport Security https://review.opendev.org/c/openstack/octavia-lib/+/880821 | 08:00 |
| opendevreview | Tom Weininger proposed openstack/python-octaviaclient master: Add support for HTTP Strict Transport Security https://review.opendev.org/c/openstack/python-octaviaclient/+/880808 | 08:05 |
| opendevreview | Tom Weininger proposed openstack/python-octaviaclient master: Add support for HTTP Strict Transport Security https://review.opendev.org/c/openstack/python-octaviaclient/+/880808 | 09:55 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add support for HTTP Strict Transport Security https://review.opendev.org/c/openstack/octavia/+/880806 | 10:13 |
| opendevreview | Merged openstack/octavia-tempest-plugin master: Add h2 traffic/scenario test https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/874424 | 10:28 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add support for HTTP Strict Transport Security https://review.opendev.org/c/openstack/octavia/+/880806 | 10:28 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add support for HTTP Strict Transport Security https://review.opendev.org/c/openstack/octavia/+/880806 | 11:22 |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: DNM profile o-* using py-spy https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/878919 | 13:41 |
| opendevreview | Tom Weininger proposed openstack/python-octaviaclient master: Add support for HTTP Strict Transport Security https://review.opendev.org/c/openstack/python-octaviaclient/+/880808 | 13:57 |
| johnsom | The Octavia forum session will be Wednesday at 9am | 14:17 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add support for HTTP Strict Transport Security https://review.opendev.org/c/openstack/octavia/+/880806 | 14:19 |
| crab | johnsom: on my controller I have client_ca.cert.pem client.cert-and-key.pem server_ca.cert.pem server_ca.key.pem | 14:52 |
| crab | amphora gets: client_ca.pem server.pem | 14:54 |
| crab | for starters, does that seem correct? | 14:54 |
| crab | (at least in terms of number of files if not content!) | 14:54 |
| johnsom | Yes, that seems correct | 14:54 |
| johnsom | The required files are listed here: https://docs.openstack.org/octavia/latest/admin/guides/certificates.html#configuring-octavia | 14:55 |
| crab | yeah i have worked through that whole document | 15:09 |
| crab | im trying to work out if i missed a step or got something wrong though. | 15:10 |
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed May 3 16:00:20 2023 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| gthiemonge | o/ | 16:00 |
| tweining | o/ | 16:00 |
| johnsom | o/ | 16:01 |
| gthiemonge | #topic Announcements | 16:02 |
| gthiemonge | * Octavia Forum Session at Vancouver | 16:02 |
| gthiemonge | FYI The Octavia Forum Session will be Wednesday, June 14th (9am) | 16:02 |
| johnsom | Yep, it is scheduled for Wednesday morning at 9am | 16:02 |
| tweining | what time is that in CEST? | 16:03 |
| tweining | and, will it be streamed somehow? | 16:03 |
| gthiemonge | well I don't think it will be streamed | 16:04 |
| gthiemonge | I didn't see an announcement about it | 16:04 |
| tweining | ok, then forget my questions | 16:04 |
| johnsom | No, I don't think they will be streaming the forum sessions | 16:05 |
| johnsom | I will be this time slot however | 16:05 |
| gthiemonge | * Bobcat Release Schedule | 16:07 |
| gthiemonge | tweining has updated the review list etherpad with our priorities for the next milestones | 16:07 |
| gthiemonge | #link https://etherpad.opendev.org/p/octavia-priority-reviews | 16:07 |
| gthiemonge | priority #1 is python-neutronclient removal | 16:07 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/866327 | 16:07 |
| gthiemonge | johnsom: you gave a CR+2 before it was rebased, could you take another look? | 16:07 |
| johnsom | Sure, NP | 16:08 |
| gthiemonge | thanks! | 16:08 |
| gthiemonge | #topic CI Status | 16:09 |
| gthiemonge | the Ubuntu Jammy nested-virt nodes are ok now | 16:10 |
| gthiemonge | the vexxhost nodes were removed | 16:10 |
| johnsom | Oh good | 16:10 |
| gthiemonge | (the latest issue was random mirror issues that is under investigation) | 16:10 |
| gthiemonge | so the question: | 16:10 |
| gthiemonge | should we merge "Updating Octavia tempest jobs on Ubuntu jammy (22.04)" now? | 16:10 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/861369 | 16:10 |
| gthiemonge | in case those nodes are re-enabled we might be exposed to new failures | 16:11 |
| gthiemonge | or should we expect that if they re-enable the nodes, they should work as expected? | 16:11 |
| gthiemonge | what do you think? | 16:11 |
| johnsom | I think it's ok to merge if it's passing | 16:11 |
| johnsom | We should remove that centos 8 job too | 16:11 |
| johnsom | in another patch | 16:11 |
| gthiemonge | yeah | 16:12 |
| gthiemonge | ok, I'm +2 it | 16:12 |
| tweining | I concur | 16:12 |
| gthiemonge | we also need to add zed(!) and antelope jobs (zed is in the chain) | 16:12 |
| gthiemonge | gmann has also a patch for the CI jobs, I'll rebase it | 16:13 |
| gthiemonge | johnsom: could you also review https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/861369 ? | 16:13 |
| tweining | that was fast :) | 16:14 |
| gthiemonge | thanks! | 16:14 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:15 |
| gthiemonge | I have 2 bugfixes that need reviews: | 16:15 |
| johnsom | gthiemonge I already did +2 that one | 16:15 |
| gthiemonge | +1 | 16:15 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/881728 | 16:15 |
| gthiemonge | this patch fixes the incorrect removal of one IP rule in the amphora namespace | 16:15 |
| gthiemonge | with some specific network topologies, the bug makes the VIP unresponsive | 16:16 |
| gthiemonge | it is backport candidate to >=wallaby | 16:16 |
| gthiemonge | and I also have: | 16:16 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/881719 | 16:16 |
| gthiemonge | it fixes a potential bug when plugging a new member subnet into the amp | 16:16 |
| gthiemonge | see https://bugs.launchpad.net/octavia/+bug/2017894 | 16:16 |
| gthiemonge | it affects all the releases (>=train) | 16:17 |
| gthiemonge | tweining had an interesting question, because I added an hardcoded value to a loop | 16:17 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/881719/comment/4fd18ed7_78438fab/ | 16:17 |
| gthiemonge | maybe I should set a more reasonable value, or I should remove the upper limit, but I don't like to add a possible infinite loop | 16:17 |
| tweining | my concern was mostly about test performance, although the number isn't huge really | 16:18 |
| gthiemonge | the loop should never go that far | 16:19 |
| gthiemonge | unless a user adds 65k members with their own networks | 16:19 |
| tweining | https://review.opendev.org/c/openstack/octavia/+/881719/2/octavia/tests/unit/amphorae/backends/agent/api_server/test_plug.py#447 | 16:19 |
| johnsom | One other thing there, we always work with MAC addresses and never trust the interface name. | 16:19 |
| johnsom | Interface naming changes release to release and across distros | 16:20 |
| gthiemonge | it is used for renaming the new interface in the ns | 16:20 |
| johnsom | I was very careful in the old code to never rely on the name unless we set it | 16:20 |
| gthiemonge | I mean, this name is only used when renaming the iface, and in other calls, we use the hwaddr | 16:21 |
| johnsom | Ok, I will take some time looking at this patch. Historically we used the interface file to make sure we had no name conflicts, etc. | 16:21 |
| gthiemonge | we could use "eth<network_uuid>" | 16:21 |
| johnsom | Nah, short is fine, just want to make sure we don't make assumptions that will break on other distros | 16:22 |
| gthiemonge | ok | 16:22 |
| tweining | I'm mostly done with my work on the new HSTS feature, but there might be some detail fixes while I'm still testing | 16:24 |
| tweining | https://review.opendev.org/q/topic:hsts-haproxy+-is:wip | 16:24 |
| tweining | for some reason the new tempest test times out in my devstack env, but I think it succeeded in Zuul, so it's probably a configuration issue with my environment | 16:25 |
| gthiemonge | ack, the priority is the octavia-lib patch, because we need a new release for the other patches | 16:25 |
| johnsom | Right | 16:26 |
| gthiemonge | #topic Open Discussion | 16:29 |
| tweining | regarding that octavia-lib change you talked. there is a parent patch: https://review.opendev.org/c/openstack/octavia-lib/+/881701/2 | 16:30 |
| tweining | it is similar to the db model repr() implementation I did last year. I'll need to check if there are fields that might be security sensitive. | 16:31 |
| gthiemonge | ack | 16:32 |
| tweining | also, since I hate stestr I worked on adding support for running unit tests and functional tests with pytest | 16:32 |
| tweining | for octavia, not octavia-lib | 16:32 |
| tweining | https://review.opendev.org/q/topic:tox-pytest | 16:33 |
| gthiemonge | tweining: what are the main differences? | 16:33 |
| tweining | much more convenient to use. just look at the options that pytest offers. | 16:34 |
| tweining | I also love pytest for its fixtures and ease of use, but we're uses standard unittest style tests, so that is not a benefit in our case | 16:35 |
| gthiemonge | johnsom: do we have some requirements on those tools? | 16:35 |
| gthiemonge | johnsom: stestr vs pytest | 16:36 |
| tweining | pytest can also run tests in parallel and I noticed that certain tests fail when I run them in parallel. that is a sign that there is something wrong with some tests | 16:36 |
| johnsom | Yeah, I think there is an OpenStack standard for that. I vaguely remember it when we switched the tool, testr->ostestr->stester | 16:36 |
| johnsom | All our tests run in parallel | 16:37 |
| tweining | I saw that some openstack projects do use pytest | 16:37 |
| tweining | yeah, but stestr runs them differently aparently | 16:37 |
| johnsom | For example: 2023-05-03 13:45:00.458197 | ubuntu-jammy | {7} octavia.tests.unit.common.tls_utils.test_cert_parser.TestTLSParseUtils.test_validate_cert_and_key_match [0.138818s] ... ok | 16:38 |
| johnsom | The {7} means it is running on the seventh thread | 16:38 |
| johnsom | The current system also randomizes the order of the tests | 16:39 |
| gthiemonge | we could ping openstack-qa to get their feedback on it | 16:39 |
| tweining | IDK, that might play a role. | 16:39 |
| tweining | just to be clear: I do not propose to use pytest instead of stestr | 16:40 |
| tweining | my patch only adds pytest as an option and as new tox test envs | 16:41 |
| tweining | pytest-unit and pytest-func | 16:41 |
| gthiemonge | ack | 16:42 |
| gthiemonge | ok folks, any other topics? | 16:44 |
| gthiemonge | ok! | 16:46 |
| gthiemonge | thank you! | 16:46 |
| gthiemonge | #endmeeting | 16:46 |
| opendevmeet | Meeting ended Wed May 3 16:46:41 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:46 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-05-03-16.00.html | 16:46 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-05-03-16.00.txt | 16:46 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-05-03-16.00.log.html | 16:46 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Make tests work with pytest runner https://review.opendev.org/c/openstack/octavia/+/881805 | 16:47 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add pytest testenv to tox.ini https://review.opendev.org/c/openstack/octavia/+/881739 | 16:47 |
| opendevreview | Tom Weininger proposed openstack/octavia master: DNM: Test CI with pytest running https://review.opendev.org/c/openstack/octavia/+/881740 | 16:47 |
| opendevreview | Merged openstack/octavia master: Remove python-neutronclient https://review.opendev.org/c/openstack/octavia/+/866327 | 18:39 |
| crab | johnsom: so i think that a big part of our problem was that we didnt set the correct mtu on our switch for the vxlan interface on the hypervisor that hosts our octavia controller. we have fixed that now, so the ssl negotiation seems to "work" we have some other problems but that was the main thing. | 21:26 |
| crab | we had it right for our neutron instances but that one caught us off guard. :( | 21:26 |
| johnsom | crab Awesome that you found the issue! | 21:34 |
| crab | indeed. and thanks very much for your help. | 21:50 |
| crab | i think we still have a few hurdles to get over but we are getting there | 21:51 |
| johnsom | Cool, let us know if we can help | 21:53 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!