| *** tweining_ is now known as tweining | 10:34 | |
| opendevreview | Tom Weininger proposed openstack/octavia master: todo mypy https://review.opendev.org/c/openstack/octavia/+/879749 | 15:48 |
|---|---|---|
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed Apr 12 16:00:13 2023 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| gthiemonge | Hi | 16:00 |
| johnsom | o/ | 16:00 |
| tweining | o/ | 16:00 |
| oschwart | o/ | 16:00 |
| QG | Hello ! | 16:00 |
| gthiemonge | #topic Announcements | 16:01 |
| gthiemonge | * Bobcat Release Schedule: R-25 | 16:01 |
| gthiemonge | the first commit of the amphorav1-removal chain is merged! | 16:01 |
| gthiemonge | #link https://review.opendev.org/q/topic:amphorav1-removal | 16:01 |
| gthiemonge | johnsom: I updated the next commit | 16:02 |
| gthiemonge | https://review.opendev.org/c/openstack/octavia/+/876035 | 16:02 |
| gthiemonge | you gave me a -1, could you take a look again? (and other folks please ;-) | 16:02 |
| johnsom | Ack | 16:02 |
| gthiemonge | thank you! | 16:02 |
| tweining | ok | 16:03 |
| gthiemonge | i don't have any other announcements, did I miss something? | 16:03 |
| tweining | do we need to update our zuul jobs definition to test py310? | 16:05 |
| tweining | I think we're only testing 3.9 right now | 16:06 |
| johnsom | It should be done at the main zuul job | 16:06 |
| gthiemonge | I don't think we need it | 16:06 |
| gthiemonge | yeah we should inherit from "openstack-python3-jobs" | 16:06 |
| johnsom | It is already there | 16:07 |
| gthiemonge | https://opendev.org/openstack/octavia/src/branch/master/zuul.d/projects.yaml#L8 | 16:07 |
| gthiemonge | oh right | 16:07 |
| johnsom | openstack-tox-py310 | 16:07 |
| tweining | thanks | 16:07 |
| tweining | I was looking at the "octavia-tox-tips" jobs | 16:08 |
| tweining | anyway, that is not an announcement | 16:08 |
| johnsom | py39 for tips should be fine, py39 is still in the PTI for bobcat | 16:09 |
| gthiemonge | hmm | 16:09 |
| gthiemonge | yeah I think we need only one tips job | 16:09 |
| gthiemonge | #topic CI Status | 16:10 |
| gthiemonge | we are still running our jobs on Ubuntu Focal | 16:11 |
| gthiemonge | I'm trying to get the list of the Ubuntu Jammy "broken" hosts | 16:11 |
| gthiemonge | we could report them to vexxhost | 16:11 |
| gthiemonge | (context: https://bugs.launchpad.net/octavia/+bug/2015244) | 16:11 |
| gthiemonge | 2nd item: | 16:11 |
| gthiemonge | the periodic job octavia-amphora-image-build is broken (my fault) | 16:12 |
| gthiemonge | This commit should fix it: | 16:12 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/879824 | 16:12 |
| gthiemonge | johnsom: could you take a look? | 16:12 |
| johnsom | Done | 16:13 |
| gthiemonge | thanks! | 16:13 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:15 |
| tweining | I managed to get py-spy to work with the CI! | 16:17 |
| gthiemonge | nice | 16:17 |
| gthiemonge | I proposed a patch that would fix some potential CI issues | 16:18 |
| tweining | mmh, looking for the patch but can't find it... | 16:18 |
| gthiemonge | (issues that I didn't see upstream, but we've faced them downstream here) | 16:18 |
| gthiemonge | #link https://bugs.launchpad.net/octavia/+bug/2015572 | 16:18 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/879898 | 16:19 |
| gthiemonge | My proposal: for each new subnet plugged into the amphora, the amphora-agent sends a GARP packet | 16:19 |
| gthiemonge | Please ready the story and review the patch | 16:19 |
| gthiemonge | thanks | 16:19 |
| gthiemonge | tweining: https://review.opendev.org/q/topic:py-spy | 16:20 |
| gthiemonge | ? | 16:20 |
| tweining | sorry for the CR-1, I think I should have CR+1'ed it so that it gets better visibility | 16:20 |
| tweining | thanks | 16:20 |
| gthiemonge | I'll update it with the annotations | 16:20 |
| tweining | ... which brings me to the next topic I've been working on: static code checks with mypy | 16:21 |
| tweining | I just started working on it and there is still a lot of work to do. However, I suggest we put more care into adding more type annotations in new code. | 16:22 |
| QG | Please review the RFE for Let's encrypt #link https://review.opendev.org/c/openstack/octavia/+/877281 | 16:23 |
| gthiemonge | QG: ack | 16:24 |
| gthiemonge | tweining: do you plan to add annotations to the existing code? | 16:24 |
| tweining | QG: yeah, it's on my list, but this is a big one | 16:25 |
| tweining | gthiemonge: I am actually in process of doing it where mypy is complaining. | 16:25 |
| tweining | Just to clarify: Not everything needs to have annotions. mypy can derive that information from context and other sources often times. | 16:26 |
| tweining | https://review.opendev.org/c/openstack/octavia/+/879749 is the WIP mypy patch BTW | 16:27 |
| QG | Thanls ! | 16:28 |
| tweining | I'm done with octavia.cmd now. | 16:28 |
| QG | thanks ! ^^ | 16:28 |
| gthiemonge | tweining: if we add annotations to a class, does mypy check that they are correct in an inherited class? I'm thinking about our plugins/interfaces (network driver/rest api driver/etc...) | 16:29 |
| tweining | yes, I think that should work. mypy is quite smart. | 16:29 |
| gthiemonge | ack | 16:30 |
| gthiemonge | #topic Open Discussion | 16:32 |
| gthiemonge | I have one topic here | 16:32 |
| gthiemonge | I proposed a patch that enables zookeeper for jobboard in devstack | 16:32 |
| tweining | https://review.opendev.org/c/openstack/openstacksdk/+/867968 is an example where mypy would also need some help. (that change was for helping PyCharm mainly) | 16:32 |
| gthiemonge | https://review.opendev.org/c/openstack/octavia/+/862671 | 16:32 |
| gthiemonge | johnsom raised a good point: why are we installing it from the source instead of using packages | 16:33 |
| gthiemonge | I'm using centos and unfortunately there is no package for zookeeper in the default repositories | 16:33 |
| gthiemonge | so I'm pulling zookeeper from upstream | 16:33 |
| gthiemonge | this week, I tried to add a specific case to my patch for ubuntu (but it seems that the zookeeper package doesn't come with a systemd init file :/) | 16:34 |
| johnsom | That is odd | 16:34 |
| gthiemonge | if we want to support both methods (deb and source) I need to generate systemd file and config file for both distribs (and of course the content of those files would be different) | 16:34 |
| gthiemonge | I don't know if it's worth it to add the support for .deb (I would rather avoid duplicate things) | 16:35 |
| gthiemonge | (BTW I didn't mention it in the commit, but I stole this code from the monasca-api repo, I'll fix that) | 16:35 |
| gthiemonge | any advices/comments on this? | 16:36 |
| johnsom | Yeah, that is fair. If it gets messy because the distros are not complete, we can continue to use the soruce | 16:36 |
| gthiemonge | ack | 16:36 |
| gthiemonge | I'm setting W-1 because I found out that I messed with the service name | 16:36 |
| gthiemonge | thanks for your feedback johnsom | 16:37 |
| gthiemonge | any other topics folks? | 16:38 |
| tweining | oh, I think I know why I didn't find the py-spy patch I was looking for (the link that gthiemonge posted does not contain the one I mean) | 16:39 |
| tweining | when two patches have the same Change-Id will one replace the other? | 16:39 |
| gthiemonge | yes | 16:39 |
| gthiemonge | (and the same branch) | 16:40 |
| tweining | it's the same target branch if you mean that, but a different topic | 16:40 |
| gthiemonge | gerrit uses the change-id and the branch name to identify a unique patch | 16:41 |
| gthiemonge | (and the repo of course) | 16:41 |
| gthiemonge | the topic is only a metadata | 16:41 |
| gthiemonge | BTW you can add hashtags now :D | 16:42 |
| opendevreview | Tom Weininger proposed openstack/octavia master: DNM: profile w/ sqlalchemy2 using py-spy https://review.opendev.org/c/openstack/octavia/+/880190 | 16:42 |
| tweining | mmh, ^ should have a different change-id now. still I don't see the other patch | 16:43 |
| gthiemonge | let's have this discussion offline (after the meeting) :D | 16:44 |
| gthiemonge | thank you folks | 16:44 |
| gthiemonge | #endmeeting | 16:44 |
| opendevmeet | Meeting ended Wed Apr 12 16:44:49 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:44 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-04-12-16.00.html | 16:44 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-04-12-16.00.txt | 16:44 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-04-12-16.00.log.html | 16:44 |
| tweining | sure | 16:44 |
| gthiemonge | tweining: so your patch is probably in the history of this change: https://review.opendev.org/c/openstack/octavia/+/878917 | 16:45 |
| gthiemonge | you can go throught the different patchset | 16:45 |
| tweining | right | 16:45 |
| gthiemonge | when you find the right patchset I would suggest that you download it | 16:45 |
| gthiemonge | > git fetch https://review.opendev.org/openstack/octavia refs/changes/17/878917/<patchset_id> && git cherry-pick FETCH_HEAD | 16:46 |
| gthiemonge | and re-submit it with git-review, it will become patchset 23 | 16:46 |
| gthiemonge | (maybe there's a smarter way to do that - like reverting a patchset - but I don't know it) | 16:47 |
| opendevreview | Tom Weininger proposed openstack/octavia master: DNM: profile using py-spy https://review.opendev.org/c/openstack/octavia/+/880192 | 16:48 |
| tweining | much better :D | 16:48 |
| tweining | I downloaded it, ran git commit --amend, removed the change-id line, ran git review again, voila | 16:49 |
| tweining | thanks | 16:50 |
| opendevreview | Tom Weininger proposed openstack/octavia master: todo mypy https://review.opendev.org/c/openstack/octavia/+/879749 | 17:36 |
| opendevreview | Tom Weininger proposed openstack/octavia master: todo mypy https://review.opendev.org/c/openstack/octavia/+/879749 | 17:50 |
| opendevreview | Merged openstack/octavia master: Fix octavia-amphora-image-build periodic job https://review.opendev.org/c/openstack/octavia/+/879824 | 18:25 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: Send IP advertisements when plugging a new member subnet https://review.opendev.org/c/openstack/octavia/+/879898 | 19:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!