| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/yoga: Fix PING health-monitor with recent haproxy releases https://review.opendev.org/c/openstack/octavia/+/871682 | 07:50 |
|---|---|---|
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/xena: Fix PING health-monitor with recent haproxy releases https://review.opendev.org/c/openstack/octavia/+/871683 | 08:06 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/wallaby: Fix PING health-monitor with recent haproxy releases https://review.opendev.org/c/openstack/octavia/+/871684 | 08:07 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/zed: Fix PING health-monitor with recent Centos releases https://review.opendev.org/c/openstack/octavia/+/871685 | 08:09 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/yoga: Fix PING health-monitor with recent Centos releases https://review.opendev.org/c/openstack/octavia/+/871686 | 08:10 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/xena: Fix PING health-monitor with recent Centos releases https://review.opendev.org/c/openstack/octavia/+/871687 | 08:11 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/wallaby: Fix PING health-monitor with recent Centos releases https://review.opendev.org/c/openstack/octavia/+/871688 | 08:11 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/zed: Filter ComputeWaitTimeoutException when jobboard is disabled https://review.opendev.org/c/openstack/octavia/+/871562 | 08:21 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/xena: Add a newline when writing the server state file https://review.opendev.org/c/openstack/octavia/+/871689 | 08:36 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/wallaby: Add a newline when writing the server state file https://review.opendev.org/c/openstack/octavia/+/871690 | 08:36 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/zed: Filter out details from taskflow logs with v2+jobboard https://review.opendev.org/c/openstack/octavia/+/871691 | 08:38 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/yoga: Filter out details from taskflow logs with v2+jobboard https://review.opendev.org/c/openstack/octavia/+/871692 | 08:40 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/xena: Filter out details from taskflow logs with v2+jobboard https://review.opendev.org/c/openstack/octavia/+/871693 | 09:04 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/wallaby: Filter out details from taskflow logs with v2+jobboard https://review.opendev.org/c/openstack/octavia/+/871694 | 09:05 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/victoria: Filter out details from taskflow logs with v2+jobboard https://review.opendev.org/c/openstack/octavia/+/871695 | 09:05 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/ussuri: Filter out details from taskflow logs with v2+jobboard https://review.opendev.org/c/openstack/octavia/+/871696 | 09:05 |
| opendevreview | Merged openstack/octavia stable/yoga: Add a newline when writing the server state file https://review.opendev.org/c/openstack/octavia/+/867151 | 13:10 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/wallaby: DNM/WIP Testing octavia-v2-dsvm-tls-barbican-amphora-v2 https://review.opendev.org/c/openstack/octavia/+/871733 | 14:20 |
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed Jan 25 16:00:21 2023 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| johnsom | o/ | 16:00 |
| gthiemonge | Hi everyone | 16:00 |
| oschwart | o/ | 16:00 |
| tweining[m] | Hey | 16:01 |
| yebinama | Hello | 16:02 |
| gthiemonge | #topic Announcements | 16:03 |
| gthiemonge | * Antelope Release schedule | 16:03 |
| gthiemonge | just a reminder | 16:03 |
| gthiemonge | we are 2 weeks from the final release for non-client librairies | 16:03 |
| gthiemonge | AFAIK we have no open patch for octavia-lib | 16:03 |
| johnsom | Yep, nothing there that is ready to go | 16:04 |
| gthiemonge | and FYI we registered Octavia for the virtual PTG in March | 16:04 |
| gthiemonge | any other announcements that I missed? | 16:05 |
| johnsom | Individual registration is open for the March PTG as well, so sign up! | 16:05 |
| johnsom | It is virtual and free | 16:05 |
| gthiemonge | +1 | 16:06 |
| gthiemonge | #topic Amphorav2+Jobboard security issue | 16:08 |
| gthiemonge | we had a new story last week about a security issue when using amphorav2+jobboard with taskflow logs set to >=INFO | 16:08 |
| gthiemonge | when creating a TLS listener, the certificates and private_keys are written to the octavia worker logs | 16:08 |
| gthiemonge | #link https://storyboard.openstack.org/#!/story/2010523 | 16:08 |
| gthiemonge | please note these important things: | 16:09 |
| gthiemonge | - jobboard is not enabled by default in Octavia | 16:09 |
| gthiemonge | - taskflow logger is only >=WARNING by default, INFO messages are not enabled | 16:09 |
| gthiemonge | - the data is only visible by the admins of the cloud | 16:09 |
| gthiemonge | the fix is already on master, patches have been proposed on stable branches | 16:10 |
| gthiemonge | #link https://review.opendev.org/q/I2df8a49851feb1445b5128ce99b880ddb77782ad | 16:10 |
| gthiemonge | (I had a merge conflict, so please review carefully) | 16:10 |
| gthiemonge | then we will cut new releases when the patches are merged | 16:11 |
| gthiemonge | any questions/comments? | 16:12 |
| matfechner | o/ | 16:13 |
| johnsom | Thanks for working on this. I think the patch looks good. | 16:15 |
| gthiemonge | thanks for the reviews ;-) | 16:16 |
| gthiemonge | BTW I will open a bug against taskflow, the INFO-level messages are maybe printing too many details | 16:17 |
| gthiemonge | #topic CI Status | 16:18 |
| johnsom | Yep, let me know when that is ready for review | 16:18 |
| gthiemonge | ack | 16:18 |
| gthiemonge | for the CI: we had a new issue with grenade last week, because nova has enabled the sRBAC by default on master | 16:19 |
| gthiemonge | johnsom fixed it by adding new roles for the users in octavia-tempest-plugin | 16:19 |
| gthiemonge | johnsom: thanks! | 16:19 |
| johnsom | NP | 16:19 |
| gthiemonge | and for this week, nothing new to report | 16:19 |
| johnsom | Yeah, I guess every cloud will need to make changes to every account on upgrade to Antelope due to the "secure-RBAC" goal. | 16:20 |
| johnsom | This surprised me | 16:21 |
| gthiemonge | yeah | 16:22 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:24 |
| gthiemonge | so this week, I had to work on this security issue | 16:25 |
| gthiemonge | and with tweining[m], we have worked on migration to openstacksdk in the neutron driver | 16:26 |
| gthiemonge | I think it is ready for reviews now: | 16:26 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/866327 | 16:26 |
| gthiemonge | and if you want to test it and you also have the ovn-octavia-provider in your env, you need to update it too (with https://review.opendev.org/c/openstack/ovn-octavia-provider/+/870514) | 16:27 |
| gthiemonge | I think that for the rest of the week I will review the barbican secrets consumers patch | 16:28 |
| gthiemonge | #topic Open Discussion | 16:30 |
| oschwart | gthiemonge: ack | 16:30 |
| yebinama | I have a question regarding pool lb_algorithm. | 16:31 |
| gthiemonge | yebinama: hi | 16:31 |
| yebinama | hello :) | 16:32 |
| yebinama | I'm currently developing a provider driver for my company internal loadbalancing solution (that may become opensource in the future). We use 'MAGLEV' as the loadbalancing algorithm. | 16:32 |
| yebinama | When creating a pool, the Octavia API checks the payload sent by the user and only allow to specify one of ROUND_ROBIN, LEAST_CONNECTIONS, SOURCE_IP or SOURCE_IP_PORT as lb_algorithm so I can't send "MAGLEV". Before doing a merge request, I wanted to know what would be the preferred way: either add 'MAGLEV' to Octavia library or maybe just remove the check from the Octavia API as each driver does its own check to | 16:32 |
| yebinama | validate user payload and may support other algorithms than those 4. | 16:32 |
| yebinama | BTW creating a driver is very easy and well documented | 16:33 |
| johnsom | yebinama Thank you for the kind words. | 16:34 |
| johnsom | So, Maglev is a load balancer offering, but I don't think it is a proprietary load balancing algorithm. | 16:34 |
| yebinama | It' an algorithm from Google | 16:34 |
| yebinama | You can use it in IPVS for example | 16:35 |
| johnsom | It uses ECMP, which most default implementation use round robin | 16:35 |
| johnsom | Some will use source tuples with consistent hashing | 16:36 |
| yebinama | ECMP is used to reach the servers that are acting as lb, to contact the members it is indeed done wit some kind of hashing | 16:37 |
| gthiemon1e | (sorry, I was dropped) | 16:37 |
| johnsom | So, instead of "maglev" it might be best to use some kind of generic (i.e. used by other LB implementations) term for the algorithm. | 16:37 |
| yebinama | Sure, something like "hashing" will be fine | 16:39 |
| johnsom | I haven't read up on Maglev in a while, but I think it has an option (beyond round-robin) for a consistent hash based on protocol, source IP, source port, destination address, destination port. | 16:39 |
| yebinama | Yep that is how we used it | 16:39 |
| yebinama | To reach the same member, whatever the lb you hit | 16:40 |
| johnsom | So, yeah, maybe "5-tuple" or something similar that we can explain in the docs somewhere. | 16:40 |
| *** gthiemon1e is now known as gthiemonge | 16:40 | |
| johnsom | That way other provider drivers can also use that algorithm if they support it and not be labeled "maglev". | 16:40 |
| yebinama | Yes, it's a good solution | 16:41 |
| johnsom | Yeah, so first step on that is to propose a patch to octavia-lib, adding the new algorithm. | 16:42 |
| johnsom | Also, be careful to understand the different between the load balancing algorithm and session persistence. They are two different things. | 16:42 |
| johnsom | LB algorithm is about how the first member server is selected, session persistence is about how subsequent packets for the client are handled. | 16:43 |
| yebinama | Yes I'm talking about the lb algorithm | 16:43 |
| yebinama | I may need to also update the python-octaviaclient as it doesn't use the octavia lib to check on user input | 16:44 |
| johnsom | Yeah, if I remember, maglev does not support session persistence concepts, but generally behaves that way. | 16:44 |
| johnsom | Correct, after it is added to octavia-lib, the main octavia, client, and dashboard will need to be updated to support this new algorithm. | 16:45 |
| johnsom | It's really pretty easy to add these. | 16:45 |
| yebinama | Sure I'll update these also | 16:46 |
| johnsom | Oh, and probably the OpenStack SDK | 16:46 |
| yebinama | I'll take a look on it to be sure | 16:47 |
| johnsom | Yeah, so welcome. If you have questions this is a good place to ask them or the discuss mailing list. | 16:47 |
| johnsom | We are happy to help you | 16:47 |
| yebinama | So to open the request I go with "5-tuple"? | 16:47 |
| yebinama | Thanks :) | 16:47 |
| johnsom | Yeah, that is my personal thought on the algorithm name. Maybe others here or reviewers will have other ideas. | 16:48 |
| johnsom | Propose it, can't hurt | 16:48 |
| gthiemonge | it's ok for me | 16:48 |
| johnsom | Easy to change if you get better feedback | 16:48 |
| yebinama | Fine then. Thank you, I'll try to open it next week. | 16:49 |
| gthiemonge | great! | 16:50 |
| gthiemonge | anything else folks? | 16:51 |
| oschwart | Nothing from me, welcome yebinama | 16:52 |
| yebinama | thanks oschwart | 16:53 |
| tweining[m] | No | 16:53 |
| gthiemonge | ok, thank you guys! | 16:53 |
| gthiemonge | #endmeeting | 16:53 |
| opendevmeet | Meeting ended Wed Jan 25 16:53:53 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:53 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-01-25-16.00.html | 16:53 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-01-25-16.00.txt | 16:53 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-01-25-16.00.log.html | 16:53 |
| skraynev | Hi guys. | 17:37 |
| skraynev | I need help with understanding error in yoga release: | 17:38 |
| skraynev | oslo_messaging.rpc.server taskflow.exceptions.MissingDependencies: 'linear_flow.Flow: octavia-create-loadbalancer-flow(len=21)' requires ['amphorae_network_config'] but no other entity produces said requirements | 17:38 |
| skraynev | oslo_messaging.rpc.server MissingDependencies: 'execute' method on 'octavia.controller.worker.v1.tasks.amphora_driver_tasks.AmphoraePostNetworkPlug==1.0' requires ['amphorae_network_config'] but no other entity produces said requirements | 17:38 |
| skraynev | it looks like backport https://review.opendev.org/c/openstack/octavia/+/856992 broke something with amphora v1. | 17:39 |
| skraynev | I could see extra argument for AmphoraePostNetworkPlug, but I could not find where this value was added to taskflow store. | 17:39 |
| johnsom | skraynev I think this has been reported: https://storyboard.openstack.org/#!/story/2010488 | 17:41 |
| johnsom | skraynev This may be the fix you need: https://review.opendev.org/c/openstack/octavia/+/869902 | 17:41 |
| skraynev | yeah! it's indeed what I am looking for. | 17:42 |
| skraynev | johnsom: huge thank you for the help !! | 17:42 |
| johnsom | NP, sorry for the trouble in the first place. I think there is some work going on to improve the single-call-create test coverage to help stop this in the future. | 17:43 |
| skraynev | johnsom: yeah. it will be really awesome when this part of logic will take more unittests. I hope, that it will be added soon :) | 17:49 |
| gthiemonge | sorry about that :/ there's an open octavia-tempest-plgin that covers it | 17:55 |
| skraynev | gthiemonge: Hm... I used it, but it did not catch this particular case. Maybe it should be specifically configured or some new tests are available in master version of this tempest plugin? | 18:15 |
| *** dkehn__ is now known as dkehn | 22:10 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!